Re: [PATCH] drivers/net/wireless/d80211: Check configuration type in hw->config_interface.

2006-07-19 Thread Michael Wu
On Wednesday 19 July 2006 13:26, Jean-Mickael Guerin wrote: > This patch prevents a NULL pointer dereferencing in AP mode: > ieee80211_if_config will set conf->bssid only if device is of type STA > or IBSS. Why is that? Isn't there a BSSID in AP mode too? Perhaps it is calling config_interface bef

Re: [PATCH] drivers/net/wireless/d80211: Check configuration type in hw->config_interface.

2006-07-20 Thread Jiri Benc
On Wed, 19 Jul 2006 22:26:52 +0200, Jean-Mickael Guerin wrote: > This patch prevents a NULL pointer dereferencing in AP mode: > ieee80211_if_config will set conf->bssid only if device is of type STA > or IBSS. > I see it using following commands right after module loading (with rt61) > # iwconfig

Re: [PATCH] drivers/net/wireless/d80211: Check configuration type in hw->config_interface.

2006-07-20 Thread Jiri Benc
On Wed, 19 Jul 2006 18:07:05 -0700, Michael Wu wrote: > Why is that? Isn't there a BSSID in AP mode too? Perhaps it is calling > config_interface before setting the BSSID? The bssid field in ieee80211_if_conf structure is not set in AP mode. There is no need for that - you already have a MAC addr

Re: [PATCH] drivers/net/wireless/d80211: Check configuration type in hw->config_interface.

2006-07-20 Thread Ivo Van Doorn
Hi, > This patch prevents a NULL pointer dereferencing in AP mode: > ieee80211_if_config will set conf->bssid only if device is of type STA > or IBSS. > I see it using following commands right after module loading (with rt61) > # iwconfig wlan0 mode Master > # ifconfig wlan0 up The patch seems

Re: [PATCH] drivers/net/wireless/d80211: Check configuration type in hw->config_interface.

2006-07-20 Thread Ivo Van Doorn
Hi, > > This patch prevents a NULL pointer dereferencing in AP mode: > > ieee80211_if_config will set conf->bssid only if device is of type STA > > or IBSS. > > I see it using following commands right after module loading (with rt61) > > # iwconfig wlan0 mode Master > > # ifconfig wlan0 up > > T