Re: [PATCH net v2 9/9] net: ethernet: mediatek: fix error handling inside mtk_mdio_init

2016-08-29 Thread Andrew Lunn
On Mon, Aug 29, 2016 at 01:03:23PM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > return -ENODEV if no child is found in MDIO bus. The "no child" is wrong here, and got me confused. What the code is actually doing is of_device_is_available() which is looking to see if there is a stat

Re: [PATCH net v2 9/9] net: ethernet: mediatek: fix error handling inside mtk_mdio_init

2016-08-29 Thread Sean Wang
Date: Mon, 29 Aug 2016 15:15:58 +0200,Andrew Lunn wrote: >On Mon, Aug 29, 2016 at 01:03:23PM +0800, sean.w...@mediatek.com wrote: >> From: Sean Wang >> >> return -ENODEV if no child is found in MDIO bus. > >Hi Sean > >Why is it an error not to have any children on the bus? > >Say i have a fibre o

Re: [PATCH net v2 9/9] net: ethernet: mediatek: fix error handling inside mtk_mdio_init

2016-08-29 Thread Andrew Lunn
On Mon, Aug 29, 2016 at 01:03:23PM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > return -ENODEV if no child is found in MDIO bus. Hi Sean Why is it an error not to have any children on the bus? Say i have a fibre optical module connected to the MAC. It is unlikely to have an MII i