Re: [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr to speedup ipv6_addr_equal() & ipv6_addr_any()

2007-04-30 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: 30 Apr 2007 23:34:20 +0200 > David Miller <[EMAIL PROTECTED]> writes: > > > > Unfortunately, as mentioned elsewhere, we're only able to assume > > 32-bit alignment of ipv6 packet headers and that isn't likely to > > change any time soon. > > On x86 it w

Re: [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr to speedup ipv6_addr_equal() & ipv6_addr_any()

2007-04-30 Thread Andi Kleen
David Miller <[EMAIL PROTECTED]> writes: > > Unfortunately, as mentioned elsewhere, we're only able to assume > 32-bit alignment of ipv6 packet headers and that isn't likely to > change any time soon. On x86 it would be fine at least -- unaligned access is cheap. I believe the same is true for PO

Re: [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr to speedup ipv6_addr_equal() & ipv6_addr_any()

2007-04-30 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Mon, 30 Apr 2007 21:08:45 +0200 > Maybe we could at least define a 'struct in6_addr_k' for internal > structures only, to speedup some parts of IPV6 stack. I think it's better to put this on the backburner for now :-) We could achieve all of this if w

Re: [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr to speedup ipv6_addr_equal() & ipv6_addr_any()

2007-04-30 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Mon, 30 Apr 2007 16:28:51 +0200 > On 64bit arches, we can speedup some IPV6 addresses compares, using 64 bits > fields in struct in6_addr. > > I am not sure if this patch wont break some user ABI, maybe we should use > some ifdef(KERNEL) ? > > This

Re: [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr to speedup ipv6_addr_equal() & ipv6_addr_any()

2007-04-30 Thread Eric Dumazet
David Miller a écrit : From: Brian Haley <[EMAIL PROTECTED]> Date: Mon, 30 Apr 2007 12:27:07 -0400 The problem is that drivers don't necessarily align the address on the correct boundary, so on some 64-bit arches this could be fatal. There's ways around it since I did it in a previous life, b

Re: [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr to speedup ipv6_addr_equal() & ipv6_addr_any()

2007-04-30 Thread David Miller
From: Brian Haley <[EMAIL PROTECTED]> Date: Mon, 30 Apr 2007 12:27:07 -0400 > The problem is that drivers don't necessarily align the address on the > correct boundary, so on some 64-bit arches this could be fatal. There's > ways around it since I did it in a previous life, but you'd need to co

Re: [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr to speedup ipv6_addr_equal() & ipv6_addr_any()

2007-04-30 Thread Brian Haley
Eric Dumazet wrote: On 64bit arches, we can speedup some IPV6 addresses compares, using 64 bits fields in struct in6_addr. diff --git a/include/linux/in6.h b/include/linux/in6.h index 2a61c82..a4241a6 100644 --- a/include/linux/in6.h +++ b/include/linux/in6.h @@ -34,10 +34,12 @@ struct in6_ad

Re: [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr to speedup ipv6_addr_equal() & ipv6_addr_any()

2007-04-30 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 30 Apr 2007 16:28:51 +0200), Eric Dumazet <[EMAIL PROTECTED]> says: > On 64bit arches, we can speedup some IPV6 addresses compares, using 64 bits > fields in struct in6_addr. > > I am not sure if this patch wont break some user ABI, maybe we should use >