Re: neigh_lookup lockdep bug.

2006-08-02 Thread David Miller
From: Arjan van de Ven <[EMAIL PROTECTED]> Date: Wed, 02 Aug 2006 04:26:49 +0200 > fwiw the patch is at > http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc2/2.6.18-rc2-mm1/broken-out/lockdep-split-the-skb_queue_head_init-lock-class.patch > and a followup cleanup at > http://

Re: neigh_lookup lockdep bug.

2006-08-01 Thread Arjan van de Ven
On Tue, 2006-08-01 at 23:19 +1000, Herbert Xu wrote: > Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > > we fixed lockdep to have this lock key to be per skb queue ... didn't > > you put that patch in rawhide Dave (J) ? > > I've only briefly looked at the lockdep_set_class code so I might be >

Re: neigh_lookup lockdep bug.

2006-08-01 Thread Arjan van de Ven
On Tue, 2006-08-01 at 23:19 +1000, Herbert Xu wrote: > > I've only briefly looked at the lockdep_set_class code so I might be > way off here. your reading of the code is right, and in fact this is what the code in -mm does, and is waiting for the networking guys or Andrew to send it to Linus (hin

Re: neigh_lookup lockdep bug.

2006-08-01 Thread Herbert Xu
Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > we fixed lockdep to have this lock key to be per skb queue ... didn't > you put that patch in rawhide Dave (J) ? I've only briefly looked at the lockdep_set_class code so I might be way off here. It seems that for lockdep_set_class to work its seco

Re: neigh_lookup lockdep bug.

2006-08-01 Thread Arjan van de Ven
On Mon, 2006-07-31 at 14:02 -0700, David Miller wrote: > From: Dave Jones <[EMAIL PROTECTED]> > Date: Mon, 31 Jul 2006 16:50:04 -0400 > > > 2.6.18rc2-gitSomething on my firewall box just triggered this.. > > Lockdep is perhaps confused. > > > [515613.904945] swapper/0 is trying to acquire lock:

Re: neigh_lookup lockdep bug.

2006-07-31 Thread David Miller
From: Dave Jones <[EMAIL PROTECTED]> Date: Mon, 31 Jul 2006 16:50:04 -0400 > 2.6.18rc2-gitSomething on my firewall box just triggered this.. Lockdep is perhaps confused. > [515613.904945] swapper/0 is trying to acquire lock: > [515613.931489] (&tbl->lock){-+-+}, at: [] neigh_lookup+0x50/0xaf >

neigh_lookup lockdep bug.

2006-07-31 Thread Dave Jones
2.6.18rc2-gitSomething on my firewall box just triggered this.. Dave [515613.791771] === [515613.841467] [ INFO: possible circular locking dependency detected ] [515613.873284]