Re: switchdev fib offload issues

On 4/18/16, 10:17 AM, Hannes Frederic Sowa wrote: > Hi Jiri, > > On 18.04.2016 17:47, Jiri Pirko wrote: >> Proposed solutions (ideas): >> 1) per-netns. Add a procfs file: >> /proc/sys/net/ipv4/route/fib_offload_error_policy >> with values: "evict" - default, current behaviour >>

Re: switchdev fib offload issues

Mon, Apr 18, 2016 at 07:52:27PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Mon, 18 Apr 2016 17:47:57 +0200 > >> However, if for any reason the switchdev add operation fails, there is an >> abort function called (switchdev_fib_ipv4_abort). This function does two >>

Re: switchdev fib offload issues

Mon, Apr 18, 2016 at 06:59:37PM CEST, d...@cumulusnetworks.com wrote: >On 4/18/16 9:47 AM, Jiri Pirko wrote: >>Proposed solutions (ideas): >>1) per-netns. Add a procfs file: >> /proc/sys/net/ipv4/route/fib_offload_error_policy >>with values: "evict" - default, current behaviour >>

Re: switchdev fib offload issues

From: Jiri Pirko Date: Mon, 18 Apr 2016 17:47:57 +0200 > However, if for any reason the switchdev add operation fails, there is an > abort function called (switchdev_fib_ipv4_abort). This function does two > things which are both unfortunate in many usecases: > 1) evicts all

Re: switchdev fib offload issues

Hi Jiri, On 18.04.2016 17:47, Jiri Pirko wrote: Proposed solutions (ideas): 1) per-netns. Add a procfs file: /proc/sys/net/ipv4/route/fib_offload_error_policy with values: "evict" - default, current behaviour "fail" - propagate offload error to user

Re: switchdev fib offload issues

On 4/18/16 10:38 AM, Ilan Tayari wrote: Hi Jiri, Thoughts? One general thought comes to mind, regardless of your proposed solutions: You'll need to take care to propagate the error properly in case of routes created by the kernel, such as local routes. Local routes are created when an IP

Re: switchdev fib offload issues

On 4/18/16 9:47 AM, Jiri Pirko wrote: Proposed solutions (ideas): 1) per-netns. Add a procfs file: /proc/sys/net/ipv4/route/fib_offload_error_policy with values: "evict" - default, current behaviour "fail" - propagate offload error to user The

RE: switchdev fib offload issues

Hi Jiri, > Thoughts? One general thought comes to mind, regardless of your proposed solutions: You'll need to take care to propagate the error properly in case of routes created by the kernel, such as local routes. Local routes are created when an IP address is added to an interface, so in

switchdev fib offload issues

Hi all. The current situation of fib offloading is not good, I believe we need to make some changes, therefore I'm writing this email. Please read, think and comment. Currently what we have is that for every fib entry inserted into a table, there is a call to switchdev: