Re: [Madwifi-devel] d80211: ANNOUNCE: DadWifi, a port of MadWifi to d80211

2006-10-18 Thread Pavel Roskin
On Tue, 2006-10-17 at 21:55 -0700, Stephen Hemminger wrote: On Tue, 2006-10-17 at 18:51 -0700, Stephen Hemminger wrote: I would consider this a BAD thing. You are creating a derived work out of GPL and non-GPL software. This actually will hurt the possible acceptance of the d80211

RE: Suppress / delay SYN-ACK

2006-10-18 Thread Martin Schiller
On Tuesday, October 17, 2006 2:54 PM, Eric Dumazet wrote: Well, did you solve Lennert problem if the final (third packet of three packet TCP establishment handshake) packet is missing ? It seems no timer will fire and tell you the socket is not usable... Sorry, but I don't know what you

Re: [PATCH] [NET] reduce sizeof(struct flow)

2006-10-18 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Wed, 18 Oct 2006 07:42:17 +0200 How many people are using DECNET and want to pay the price of this 20 bytes dnports structure ? I bet you could make that cost get hidden by careful rearrangement of the struct flow, or adjustment of the implementation.

[PATCH 0/6] Changeset of Camellia cipher algorithm.

2006-10-18 Thread Noriaki TAKAMIYA
Hi, This set of the patches enables to use of the Camellia cipher algorithm for the ESP encryption. Git tree is also available on camellia20061017 branch at: git://git.skbuff.net/gitroot/takamiya/camellia20061017 The following patches are available for the top of davem's net-2.6 and

[PATCH 4/6] [IPSEC] added the definition of Camellia cipher algorithm.

2006-10-18 Thread Noriaki TAKAMIYA
This patch adds the definitions used by pfkeyv2 interface for Camellia cipher algorithm. Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] --- include/linux/pfkeyv2.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) 1b6712cdb8fd31482d7e7da56e5f602357ec4aa4 diff --git

[PATCH 1/6] [CRYPTO] added Kconfig entry for Camellia.

2006-10-18 Thread Noriaki TAKAMIYA
Hi, This patch adds the Kconfig entry for Camellia. Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] --- crypto/Kconfig | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) 01b0c3898fdf1cb4da8cdf5577e58328ecb11e4e diff --git a/crypto/Kconfig b/crypto/Kconfig index

[PATCH 6/6] [CRYPTO] added the developer of Camellia cipher algorithm.

2006-10-18 Thread Noriaki TAKAMIYA
This patch adds the developer of Camellia cipher algorithm. Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] --- Documentation/crypto/api-intro.txt |4 1 files changed, 4 insertions(+), 0 deletions(-) 80a5df8127311212e99bd64103771de19c5908dd diff --git

[PATCH 3/6] [CRYPTO] added the testing code of Camellia cipher algorithm.

2006-10-18 Thread Noriaki TAKAMIYA
This patch adds the code of Camellia code for testing module. Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] --- crypto/tcrypt.c | 43 ++ crypto/tcrypt.h | 165 +++ 2 files changed, 207 insertions(+), 1 deletions(-)

[PATCH 5/6] [IPSEC] added the entry of Camellia cipher algorithm to ealg_list[].

2006-10-18 Thread Noriaki TAKAMIYA
This patch adds the entry of Camellia cipher algorithm to ealg_list[]. Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] --- net/xfrm/xfrm_algo.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) 2253254f5a802c1cc8a5fc367fae911172f28846 diff --git

[PATCH] [NET] inet_peer : group together avl_left, avl_right, v4daddr to speedup lookups on some CPUS

2006-10-18 Thread Eric Dumazet
Hi David Lot of routers still use CPUS with 32 bytes cache lines. (Intel PIII) It make sense to make sure fields used at lookup time are in the same cache line, to reduce cache footprint and speedup lookups. Signed-off-by: Eric Dumazet [EMAIL PROTECTED] --- linux/include/net/inetpeer.h

Re: [PATCH 0/14] TIPC updates

2006-10-18 Thread Per Liden
On Mon, 16 Oct 2006, David Miller wrote: From: Per Liden [EMAIL PROTECTED] Date: Fri, 13 Oct 2006 13:37:23 +0200 (CEST) This patch set includes a number TIPC fixes/cleanups. Please see each individual patch for further description. Please pull from:

Re: [PATCH] [NET] reduce sizeof(struct flow)

2006-10-18 Thread Steven Whitehouse
Hi, On Tue, Oct 17, 2006 at 11:53:36PM -0700, David Miller wrote: From: Eric Dumazet [EMAIL PROTECTED] Date: Wed, 18 Oct 2006 07:42:17 +0200 How many people are using DECNET and want to pay the price of this 20 bytes dnports structure ? Point taken :-) Eric, you also need to add a ||

[DECNET] Fix input routing bug

2006-10-18 Thread Steven Whitehouse
This patch fixes a silly bug that has been in the input routing code for some time. It results in trying to send to a node directly when the origin of the packet is via the default router. Its been tested by Alan Kemmerer [EMAIL PROTECTED] who reported the bug and its a fairly obvious fix for a

Re: [PATCH] [NET] reduce sizeof(struct flow)

2006-10-18 Thread Eric Dumazet
On Wednesday 18 October 2006 10:20, Steven Whitehouse wrote: Hi, On Tue, Oct 17, 2006 at 11:53:36PM -0700, David Miller wrote: From: Eric Dumazet [EMAIL PROTECTED] Date: Wed, 18 Oct 2006 07:42:17 +0200 How many people are using DECNET and want to pay the price of this 20 bytes

Re: [RFC] Ethernet Cheap Cryptography

2006-10-18 Thread Dawid Ciezarkiewicz
On Wednesday, 18 October 2006 05:21, you wrote: Dawid Ciezarkiewicz writes: I'd be thankful for your opinions about that idea. Please forgive me any nuances that I didn't know about. * I suggest extending the documentation with some motivating examples of why someone would want to

[PATCH,RFC] bridge: call eth_type_trans() in br_pass_frame_up()

2006-10-18 Thread Lennert Buytenhek
Hi, I've been seeing a failure to reply to incoming ARP packets on a bridge interface until after the first few packets have been transmitted over that interface, and the patch below seems to fix the issue, the 'issue' being that the incoming ARP packets are marked with PACKET_OTHERHOST, and

Re: [RFC] Ethernet Cheap Cryptography

2006-10-18 Thread Dawid Ciezarkiewicz
On Wednesday, 18 October 2006 05:25, David Miller wrote: From: [EMAIL PROTECTED] (Stephen J. Bevan) Date: Tue, 17 Oct 2006 20:21:46 -0700 * You write frames will be delivered in order, so on the other side IV can be always in sync. In fact, in addition to your comments, Linux can

[IPv6] route: Fix prohibit and blackhole routing decision

2006-10-18 Thread Thomas Graf
Lookups resolving to ip6_blk_hole_entry must result in silently discarding the packets whereas an ip6_pkt_prohibit_entry is supposed to cause an ICMPV6_ADM_PROHIBITED message to be sent. Thanks to Kim Nordlund [EMAIL PROTECTED] for noticing this bug. Signed-off-by: Thomas Graf [EMAIL PROTECTED]

Re: [RFC] Ethernet Cheap Cryptography

2006-10-18 Thread David Miller
From: Dawid Ciezarkiewicz [EMAIL PROTECTED] Date: Wed, 18 Oct 2006 11:51:46 +0200 I've tried to put ccrypt handlers as close to hardware xmit and recv as possible so local reorder doesn't matter. Medium doesn't reorder frames and switches, bridges shouldn't do that neither (but as Stephen J.

Re: d80211: ANNOUNCE: DadWifi, a port of MadWifi to d80211

2006-10-18 Thread Christoph Hellwig
On Tue, Oct 17, 2006 at 05:14:29PM -0700, David Kimdon wrote: Hi, DadWifi is a port of MadWifi to the d80211 stack. It works now in managed and monitor mode, lightly tested. Any card supported by MadWifi should be supported by DadWifi [1]. This allows a large number of cards to now take

Re: [PATCH] [NET] reduce sizeof(struct flow)

2006-10-18 Thread Ingo Oeser
Hi David, David Miller schrieb: I don't like these kinds of patches because %99 of people will never ever realize the savings because distribution vendors will always, unlaterally, enable everything. People producing Linux Appliances DO compile their own kernels. And some distribution

Re: [RFC] Ethernet Cheap Cryptography

2006-10-18 Thread Dawid Ciezarkiewicz
On Wednesday, 18 October 2006 12:16, David Miller wrote: From: Dawid Ciezarkiewicz [EMAIL PROTECTED] Date: Wed, 18 Oct 2006 11:51:46 +0200 I've tried to put ccrypt handlers as close to hardware xmit and recv as possible so local reorder doesn't matter. Medium doesn't reorder frames and

2.6.19rc2 XFRM does too large direct mapping allocations for hashes

2006-10-18 Thread Andi Kleen
I got this while restarting ipsec on a 2.6.19rc2 system that was up for a few days. Order 8 is really a bit big to get from the direct mapping after boot. Should the hash allocation fall back to vmalloc? -Andi Initializing XFRM netlink socket events/0: page allocation failure. order:8,

Re: [PATCH] [NET] reduce sizeof(struct flow)

2006-10-18 Thread Steven Whitehouse
Hi, Its not used at the moment[*], but would be required for any kind of flow tracking. The objnum field, could be folded into the objname field I guess on the basis that objnamel == 0 means objname[0] represents the objnum, but that doesn't really buy much. Well, as I privately said

Re: [PATCH 2/7] d80211: add support for SIOCSIWRATE and SIOCGIWRATE

2006-10-18 Thread Jiri Benc
On Thu, 12 Oct 2006 15:35:59 -0700, mabbas wrote: Should I add the new field to sta_info or to ieee80211_sub_if_data. If we added to sta_info then it wont be persistent. We will loose SIOCSIWRATE restriction once we associate with new AP. Then in 3 we bitmask sta-curr_rates with

Re: [PATCH 2/7] d80211: add support for SIOCSIWRATE and SIOCGIWRATE

2006-10-18 Thread Johannes Berg
On Wed, 2006-10-18 at 14:59 +0200, Jiri Benc wrote: But we will have to convert d80211 to cfg80211 anyway, so it will depend on the way rate limiting is implemented in cfg80211 in the end. I'd think it should be more the other way round with d80211/cfg80211 doing whatever makes most sense...

80211 questions

2006-10-18 Thread Bar, Eitan
Hi, I'm working on adding WE (wireless extensions) support to a WLAN driver, and have recently bumped into references of nl80211, cfg80211 and d80211. My questions: - Can someone please shortly describe each term? - Other than reading the source code and searching in news-groups, is there any

Re: [PATCH] d80211: ieee80211_hw handlers should be allowed to sleep

2006-10-18 Thread Jiri Benc
On Sat, 7 Oct 2006 11:23:15 +0200, Ivo van Doorn wrote: --- a/net/d80211/ieee80211.c +++ b/net/d80211/ieee80211.c @@ -2075,15 +2075,15 @@ void ieee80211_if_shutdown(struct net_de case IEEE80211_IF_TYPE_STA: case IEEE80211_IF_TYPE_IBSS: sdata-u.sta.state =

Re: [PATCH] [NET] reduce sizeof(struct flow)

2006-10-18 Thread Eric Dumazet
On Wednesday 18 October 2006 14:42, Steven Whitehouse wrote: Hi, Its not used at the moment[*], but would be required for any kind of flow tracking. The objnum field, could be folded into the objname field I guess on the basis that objnamel == 0 means objname[0] represents the

Re: 80211 questions

2006-10-18 Thread Johannes Berg
Hi, I'm working on adding WE (wireless extensions) support to a WLAN driver, and have recently bumped into references of nl80211, cfg80211 and d80211. My questions: - Can someone please shortly describe each term? d80211: wireless stack slated to replace the current ieee80211 subsystem

Re: [PATCH 2/7] d80211: add support for SIOCSIWRATE and SIOCGIWRATE

2006-10-18 Thread Jiri Benc
On Wed, 18 Oct 2006 15:02:32 +0200, Johannes Berg wrote: On Wed, 2006-10-18 at 14:59 +0200, Jiri Benc wrote: But we will have to convert d80211 to cfg80211 anyway, so it will depend on the way rate limiting is implemented in cfg80211 in the end. I'd think it should be more the other way

Re: [PATCH 2/7] d80211: add support for SIOCSIWRATE and SIOCGIWRATE

2006-10-18 Thread Johannes Berg
On Wed, 2006-10-18 at 15:34 +0200, Jiri Benc wrote: Current WE implementation of rate limiting (SIOCSIWRATE) doesn't make much sense with d80211. Right. Hopefully we'll invent a better solution for cfg80211. We could do it right here and now then. I haven't understood the matter though,

RE: 80211 questions

2006-10-18 Thread Bar, Eitan
-Original Message- From: Johannes Berg [mailto:[EMAIL PROTECTED] Sent: Wednesday, October 18, 2006 3:30 PM To: Bar, Eitan Cc: netdev@vger.kernel.org Subject: Re: 80211 questions Hi, I'm working on adding WE (wireless extensions) support to a WLAN driver, and have recently

RE: 80211 questions

2006-10-18 Thread Johannes Berg
On Wed, 2006-10-18 at 15:45 +0200, Bar, Eitan wrote: [Eitan Bar] I was actually looking for any kind of design document, or anything related to the concept behind it. As for cfg80211/nl80211 it was mostly discussed here on netdev and I haven't written up anything. I'm adding WE support for a

Re: [patch 3/3] d80211: silence sparse warning: bad constant expression

2006-10-18 Thread Jiri Benc
On Mon, 9 Oct 2006 13:11:02 -0700, David Kimdon wrote: --- wireless-dev.orig/net/d80211/ieee80211_sta.c +++ wireless-dev/net/d80211/ieee80211_sta.c @@ -930,8 +930,8 @@ static void ieee80211_rx_mgmt_auth(struc printk(KERN_DEBUG %s: AP denied authentication (auth_alg=%d

BCM5461 phy issue in 10M/Full duplex

2006-10-18 Thread Kumar Gala
I was wondering if anyone has had any issues when trying to force a BCM5461 phy into 10M/full duplex. I seem to be having an issue in the two managed switches I've tried this on but autoneg to 10/half. This causes a problem in that I start seeing a large number of frame errors. I

Re: 80211 questions

2006-10-18 Thread Dan Williams
On Wed, 2006-10-18 at 15:09 +0200, Bar, Eitan wrote: Hi, I'm working on adding WE (wireless extensions) support to a WLAN driver, and have recently bumped into references of nl80211, cfg80211 and d80211. My questions: - Can someone please shortly describe each term? - Other than

Re: [RFC] Ethernet Cheap Cryptography

2006-10-18 Thread Dawid Ciezarkiewicz
On Wednesday, 18 October 2006 11:15, Dawid Ciezarkiewicz wrote: * Given your desire not to change the size of the payload you have no space for MAC. This makes it easier (but by no means easy) to alter the payload in such a way that it is still decrypted and considered valid.

Re: [e1000]: flow control on by default - good idea really?

2006-10-18 Thread jamal
On Tue, 2006-17-10 at 14:02 -0700, Auke Kok wrote: For now, we should really report the FC status in e1000 at link up time. Jamal: this should help you out for now, I'll send something like this upstream later on. Thanks - this puts you at par with the tg3 at least. On Tue, 2006-17-10

Re: [PATCH] bcm43xx: Readd dropped assignment

2006-10-18 Thread Michael Buesch
On Wednesday 18 October 2006 01:12, Daniel Drake wrote: Larry Finger pointed out a problem with my ieee80211 IV/ICV stripping patch, which I forgot about. Sorry about that. The patch readds the frame_ctl assignment which was accidently dropped. Signed-off-by: Daniel Drake [EMAIL PROTECTED]

Re: [patch 3/3] d80211: silence sparse warning: bad constant expression

2006-10-18 Thread David Kimdon
On Wed, Oct 18, 2006 at 03:56:07PM +0200, Jiri Benc wrote: On Mon, 9 Oct 2006 13:11:02 -0700, David Kimdon wrote: --- wireless-dev.orig/net/d80211/ieee80211_sta.c +++ wireless-dev/net/d80211/ieee80211_sta.c @@ -930,8 +930,8 @@ static void ieee80211_rx_mgmt_auth(struc

Re: [e1000]: flow control on by default - good idea really?

2006-10-18 Thread Auke Kok
jamal wrote: On Tue, 2006-17-10 at 14:02 -0700, Auke Kok wrote: For now, we should really report the FC status in e1000 at link up time. Jamal: this should help you out for now, I'll send something like this upstream later on. Thanks - this puts you at par with the tg3 at least. On Tue,

Re: [PATCH] Bound TSO defer time (resend)

2006-10-18 Thread Andi Kleen
On Tuesday 17 October 2006 06:18, John Heffner wrote: Stephen Hemminger wrote: On Mon, 16 Oct 2006 20:53:20 -0400 (EDT) John Heffner [EMAIL PROTECTED] wrote: This patch limits the amount of time you will defer sending a TSO segment to less than two clock ticks, or the time between two

Re: [patch 3/3] d80211: silence sparse warning: bad constant expression

2006-10-18 Thread Jiri Benc
On Wed, 18 Oct 2006 08:12:27 -0700, David Kimdon wrote: I actually think the code reads slightly cleaner using num_algs, but don't have a strong preference. I'd be happy to make the change if removing num_algs is preferred. Don't know. But nobody except me objected for more than a week so

Re: d80211: ANNOUNCE: DadWifi, a port of MadWifi to d80211

2006-10-18 Thread Jiri Benc
On Wed, 18 Oct 2006 11:16:05 +0100, Christoph Hellwig wrote: Guys, why do you waste your time on doing stuff that's useless for most of us, and that people can't even legally redistribute. I dislike HAL too. But I don't think this effort is useless. It's a great base for a future fully open

Re: [PATCH] d80211: Fix TX/RX rates

2006-10-18 Thread Jiri Benc
On Sun, 15 Oct 2006 20:14:07 +0200, Ivo van Doorn wrote: This patch correctly initializes the force_unicast_rateidx and max_ratectrl_rateidx. This was not done previously and caused a bug in rf80211_simple where when rate_control_simple_get_rate() was called, the incorrect rate was selected

[PATCH 15/18] d80211: use FCS_LEN instead of hardcoded number.

2006-10-18 Thread Jiri Benc
From: David Kimdon [EMAIL PROTECTED] Signed-off-by: David Kimdon [EMAIL PROTECTED] Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- net/d80211/ieee80211.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) 22acdd71c90cc4123d3df59a07919d432847e3e7 diff --git a/net/d80211/ieee80211.c

[PATCH 0/18] d80211: pull request

2006-10-18 Thread Jiri Benc
Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git up to obtain following patches: David Kimdon: d80211: Fix overflow when creating AVS header d80211: allow wireless vlan interface to have same MAC an AP interface d80211: use FCS_LEN instead of

[PATCH 16/18] d80211: silence sparse warning: bad constant expression

2006-10-18 Thread Jiri Benc
From: David Kimdon [EMAIL PROTECTED] Sparse does not figure out that algs[] isn't really a variable length array. The message is: net/d80211/ieee80211_sta.c:934:12: error: bad constant expression This switches algs[] to be obviously a constant array, and derives the value of num_algs algs[].

[PATCH 13/18] d80211: retain PS frames for at least STA listen interval

2006-10-18 Thread Jiri Benc
From: Jouni Malinen [EMAIL PROTECTED] Start using 2 * listen_int * beacon_int as a timeout for PS buffered unicast frames if that is longer than 10 seconds. Previously, we used fixed 10 second limit regardless of the listen interval. This fixes power saving for STAs that request very long listen

[PATCH 4/18] d80211: rename rate_control.h to ieee80211_rate.h

2006-10-18 Thread Jiri Benc
rate_control.h is not a header for rate_control.c as the name suggests. Furthermore, we want to introduce ieee80211_rate.c which implements some things defined in rate_control.h. This patch renames rate_control.h to ieee80211_rate.h. Signed-off-by: Jiri Benc [EMAIL PROTECTED] ---

[PATCH 18/18] d80211: remove unused Super AG definitions, purge comment

2006-10-18 Thread Jiri Benc
From: David Kimdon [EMAIL PROTECTED] Remove unused Super AG structure members, enums. In struct ieee80211_tx_status the queue_length and queue_number could be useful outside the context of Super AG, so remove the comment and leave the members. Signed-off-by: David Kimdon [EMAIL PROTECTED]

[PATCH 10/18] d80211: Fix overflow when creating AVS header

2006-10-18 Thread Jiri Benc
From: David Kimdon [EMAIL PROTECTED] Fix overflow when converting timespec to microseconds. Without this patch you can get an overflow during the multiplication which can result in a negative number. hostime is define here: 4.4 hosttime The hosttime field is set to the current value of the

[PATCH 6/18] d80211: rename rate_control.c to rc80211_simple.c

2006-10-18 Thread Jiri Benc
To support changing of the rate control modules on the fly we need well-defined names of the modules. Let it be rc80211_*. Rename the only one rate control module (rate_control.c) into rc80211_simple.c. The module alias for the default module is changed to rc80211_default. Signed-off-by: Jiri

[PATCH 17/18] d80211: Fix TX/RX rates

2006-10-18 Thread Jiri Benc
From: Modestas Vainius [EMAIL PROTECTED] This patch correctly initializes the force_unicast_rateidx and max_ratectrl_rateidx. This was not done previously and caused a bug in rf80211_simple where when rate_control_simple_get_rate() was called, the incorrect rate was selected from the list.

[PATCH 7/18] d80211: proper rate control structures freeing

2006-10-18 Thread Jiri Benc
Add a reference counting to the rate control algorithm structure. This prevents unloading of the rate control module when there still exists a sta entry which uses that module. To achieve this some other things need to be done in this patch as well: - The new rate_control_ref structure is

[PATCH 9/18] d80211: rate_control: do not use atomic allocations when not necessary

2006-10-18 Thread Jiri Benc
Allow GFP_KERNEL to be used for allocations of sta entries triggered from the user space. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- net/d80211/ieee80211_ioctl.c |2 +- net/d80211/ieee80211_rate.h |7 --- net/d80211/ieee80211_sta.c |4 ++-- net/d80211/rc80211_simple.c |

[PATCH 1/18] d80211: fix is_ieee80211_device

2006-10-18 Thread Jiri Benc
The is_ieee80211_device function must ensure that the passed net_device belongs to the hardware device we are working with. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- net/d80211/ieee80211.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-)

[PATCH 8/18] d80211: allow changing of the rate control algorithm

2006-10-18 Thread Jiri Benc
Allow changing of the rate control algorithm. This has some limitations: - The rate control algorithm can be set per-wiphy only. - All of network interfaces of the wiphy have to be down to change the algorithm. - All sta entries are flushed when the algorithm is succesfully changed. - The

[PATCH 5/18] d80211: proper rate_control loading

2006-10-18 Thread Jiri Benc
Fix locking issues with loading of rate_control modules. This still doesn't allow changing of the modules on the fly. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- net/d80211/Makefile |1 net/d80211/ieee80211.c | 108 ++-

[PATCH 3/18] d80211: del sta timer on interface close

2006-10-18 Thread Jiri Benc
Delete sta timer when the corresponding network interface is brought down. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- net/d80211/ieee80211.c | 24 net/d80211/ieee80211_i.h |1 + net/d80211/ieee80211_iface.c | 12 +++-

Re: [patch] d80211: remove initialization of unused xr structure members

2006-10-18 Thread Jiri Benc
On Fri, 13 Oct 2006 12:34:57 -0700, David Kimdon wrote: The structure member xr_end was removed from d80211.h. John, please apply this after you pull from my tree (perhaps with a rt2x00 prefix in the subject instead of d80211?). Thanks, Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this

Re: [take1 0/5] d80211 patches

2006-10-18 Thread Jiri Benc
On Tue, 17 Oct 2006 10:17:13 -0700, David Kimdon wrote: Continue d80211 bitfield removal. In general, compilers have difficulty generating efficient code for bitfields. This patchset removes all bitfields from include/net/d80211.h. Thanks for the patches! At first I intended to ask you to

[PATCH 11/18] d80211: remove unused xr structure members, interface, etc.

2006-10-18 Thread Jiri Benc
From: Elliot Schwartz [EMAIL PROTECTED] This is all unused. Signed-off-by: Elliot Schwartz [EMAIL PROTECTED] Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- include/net/d80211.h |9 - include/net/d80211_mgmt.h|4 include/net/d80211_shared.h |4

[PATCH 2/18] d80211: add missing rtnl_unlock()

2006-10-18 Thread Jiri Benc
Add forgotten rtnl_unlock() in the error path of ieee80211_register_hw. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- net/d80211/ieee80211.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) 693ca0e679ae17dd34f5392886f99ba36f68940c diff --git a/net/d80211/ieee80211.c

[PATCH 12/18] d80211: remove rate limit code

2006-10-18 Thread Jiri Benc
From: Elliot Schwartz [EMAIL PROTECTED] Remove unused and more or less pointless rate limiting code. This would have just dropped multicast frames arbitrarily when the limit is reached which is quite useless and does not really belong to 802.11 code. Signed-off-by: Elliot Schwartz [EMAIL

Re: [patch] d80211: remove initialization of unused xr structure members

2006-10-18 Thread Ivo van Doorn
Hi, The structure member xr_end was removed from d80211.h. John, please apply this after you pull from my tree (perhaps with a rt2x00 prefix in the subject instead of d80211?). The patch itself looked good, but it doesn't fix rt2500usb and rt73usb, I will send a patch to fix the rt2x00 USB

[PATCH] rt2x00: Remove xr_end references

2006-10-18 Thread Ivo van Doorn
This removes the xr_end references from rt2500usb and rt71usb. The rt2x00 pci drivers were already fixed by David Kimdon. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff --git a/drivers/net/wireless/d80211/rt2x00/rt2500usb.c b/drivers/net/wireless/d80211/rt2x00/rt2500usb.c index

Re: [PATCH] Bound TSO defer time (resend)

2006-10-18 Thread Stephen Hemminger
On Wed, 18 Oct 2006 17:37:36 +0200 Andi Kleen [EMAIL PROTECTED] wrote: On Tuesday 17 October 2006 06:18, John Heffner wrote: Stephen Hemminger wrote: On Mon, 16 Oct 2006 20:53:20 -0400 (EDT) John Heffner [EMAIL PROTECTED] wrote: This patch limits the amount of time you will defer

Re: [PATCH,RFC] bridge: call eth_type_trans() in br_pass_frame_up()

2006-10-18 Thread Stephen Hemminger
On Wed, 18 Oct 2006 11:14:45 +0200 Lennert Buytenhek [EMAIL PROTECTED] wrote: Hi, I've been seeing a failure to reply to incoming ARP packets on a bridge interface until after the first few packets have been transmitted over that interface, and the patch below seems to fix the issue, the

[PATCH, resent] [NET] reduce per cpu ram used for loopback stats

2006-10-18 Thread Eric Dumazet
Sorry David, the previous attachment had a missing / in one filename [NET] reduce per cpu ram used for loopback device stats We dont need a full struct net_device_stats (currently 23 long : 184 bytes on x86_64) per possible CPU, but only two counters : bytes and packets We save few CPU cycles

Re: BCM5461 phy issue in 10M/Full duplex

2006-10-18 Thread Rick Jones
Kumar Gala wrote: I was wondering if anyone has had any issues when trying to force a BCM5461 phy into 10M/full duplex. I seem to be having an issue in the two managed switches I've tried this on but autoneg to 10/half. This causes a problem in that I start seeing a large number of frame

[PATCH] [NET] reduce per cpu ram used for loopback stats

2006-10-18 Thread Eric Dumazet
We dont need a full struct net_device_stats (currently 23 long : 184 bytes on x86_64) per possible CPU, but only two counters : bytes and packets We save few CPU cycles too in loopback_xmit() not updating 4 fields, but 2. Signed-off-by: Eric Dumazet [EMAIL PROTECTED] ---

Re: [take1 0/5] d80211 patches

2006-10-18 Thread Ivo van Doorn
On Wednesday 18 October 2006 19:20, David Kimdon wrote: On Wed, Oct 18, 2006 at 06:01:31PM +0200, Jiri Benc wrote: On Tue, 17 Oct 2006 10:17:13 -0700, David Kimdon wrote: Continue d80211 bitfield removal. In general, compilers have difficulty generating efficient code for bitfields.

Re: [PATCH] d80211: ieee80211_hw handlers should be allowed to sleep

2006-10-18 Thread Ivo van Doorn
On Wednesday 18 October 2006 15:06, Jiri Benc wrote: On Sat, 7 Oct 2006 11:23:15 +0200, Ivo van Doorn wrote: --- a/net/d80211/ieee80211.c +++ b/net/d80211/ieee80211.c @@ -2075,15 +2075,15 @@ void ieee80211_if_shutdown(struct net_de case IEEE80211_IF_TYPE_STA: case

[PATCH wireless-2.6] ieee80211: don't flood log with errors

2006-10-18 Thread Jiri Benc
The ieee80211: Workaround malformed 802.11 frames from AP patch (see http://kernel.org/git/?p=linux/kernel/git/linville/wireless-2.6.git;a=commit;h=f09fc44d8c25f22c4d985bb93857338ed02feac6 ) fixes the problem with some buggy APs but also converts debug message into an error one. This floods the

Re: [take1 0/5] d80211 patches

2006-10-18 Thread David Kimdon
On Wed, Oct 18, 2006 at 06:01:31PM +0200, Jiri Benc wrote: On Tue, 17 Oct 2006 10:17:13 -0700, David Kimdon wrote: Continue d80211 bitfield removal. In general, compilers have difficulty generating efficient code for bitfields. This patchset removes all bitfields from

[PATCH 3/3] ethtool: dump_registers post mortem

2006-10-18 Thread Stephen Hemminger
This patch allows: ethtool -d eth0 raw on saved_regs and later ethtool -d eth0 file saved_regs Selfish motive is to be able to take register dumps from users and and decode later, possibly adding more output as needed. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] ---

[PATCH 2/3] ethtool: sky2 more decode

2006-10-18 Thread Stephen Hemminger
Dump even more GMAC/GPHY state Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- marvell.c | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/marvell.c b/marvell.c index 244bb69..e867521 100644 --- a/marvell.c +++ b/marvell.c @@ -113,7 +113,7 @@ static

Re: [take1 0/5] d80211 patches

2006-10-18 Thread David Kimdon
On Wed, Oct 18, 2006 at 07:23:14PM +0200, Ivo van Doorn wrote: On Wednesday 18 October 2006 19:20, David Kimdon wrote: On Wed, Oct 18, 2006 at 06:01:31PM +0200, Jiri Benc wrote: On Tue, 17 Oct 2006 10:17:13 -0700, David Kimdon wrote: Continue d80211 bitfield removal. In general,

[PATCH 4/6] net: use bitrev8

2006-10-18 Thread Akinobu Mita
Use bitrev8 for bmac, mace, macmace, macsonic, and skfp drivers. Cc: Jeff Garzik [EMAIL PROTECTED] Cc: Paul Mackerras [EMAIL PROTECTED] Cc: Mirko Lindner [EMAIL PROTECTED] Cc: Thomas Bogendoerfer [EMAIL PROTECTED] Signed-off-by: Akinobu Mita [EMAIL PROTECTED] drivers/net/Kconfig|1

Re: [PATCH] d80211: ieee80211_hw handlers should be allowed to sleep

2006-10-18 Thread Jan Kiszka
Ivo van Doorn wrote: On Wednesday 18 October 2006 15:06, Jiri Benc wrote: On Sat, 7 Oct 2006 11:23:15 +0200, Ivo van Doorn wrote: --- a/net/d80211/ieee80211.c +++ b/net/d80211/ieee80211.c @@ -2075,15 +2075,15 @@ void ieee80211_if_shutdown(struct net_de case IEEE80211_IF_TYPE_STA:

[PATCH 1/3] ethtool: sky2 GMAC decode

2006-10-18 Thread Stephen Hemminger
Add decoding of GMAC bits. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- marvell.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/marvell.c b/marvell.c index 16147a9..244bb69 100644 --- a/marvell.c +++ b/marvell.c @@ -113,6 +113,31

Re: 2.6.19rc2 XFRM does too large direct mapping allocations for hashes

2006-10-18 Thread David Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Wed, 18 Oct 2006 13:50:22 +0200 I got this while restarting ipsec on a 2.6.19rc2 system that was up for a few days. It's been fixed already in current GIT. The xfrm state counters weren't being maintained correctly, so they'd go negative and the

[PATCH] sky2: netpoll on dual port cards

2006-10-18 Thread Stephen Hemminger
The sky2 driver uses a single NAPI poll routine for both ports on dual ported cards (because there is a single IRQ and status ring). Netpoll makes assumptions about the relationship between network device and NAPI that aren't correct on the second port, this will cause the port to never clear

[PATCH] netpoll: don't send packets to detached device

2006-10-18 Thread Stephen Hemminger
Netpoll shouldn't send packets to devices that have detached themselves. This can happen during shutdown or suspend. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/core/netpoll.c2006-10-18 13:41:49.0 -0700 +++ b/net/core/netpoll.c2006-10-18

[PATCH] netpoll: netpoll_send_skb local optimization

2006-10-18 Thread Stephen Hemminger
This cleans up netpoll_send_skb: * np and np-dev are always non-null given the local callers * get device into a local variable Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- orig/net/core/netpoll.c 2006-10-18 13:44:27.0 -0700 +++ new/net/core/netpoll.c 2006-10-18

Re: [PATCH] bcm43xx: Readd dropped assignment

2006-10-18 Thread Larry Finger
Michael Buesch wrote: On Wednesday 18 October 2006 01:12, Daniel Drake wrote: Larry Finger pointed out a problem with my ieee80211 IV/ICV stripping patch, which I forgot about. Sorry about that. The patch readds the frame_ctl assignment which was accidently dropped. Signed-off-by: Daniel

[take2 5/5] d80211: remove bitfields from ieee80211_conf

2006-10-18 Thread David Kimdon
All four one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_CONF_* definitions. Signed-off-by: David Kimdon [EMAIL PROTECTED] Index: wireless-dev/include/net/d80211.h === ---

[take2 4/5] d80211: remove bitfields from ieee80211_hw

2006-10-18 Thread David Kimdon
All twelve one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_HW_* definitions. Signed-off-by: David Kimdon [EMAIL PROTECTED] Index: wireless-dev/drivers/net/wireless/d80211/adm8211/adm8211.c

[take2 2/5] d80211: remove bitfields from ieee80211_tx_status

2006-10-18 Thread David Kimdon
Both one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_TX_STATUS_* definitions. Signed-off-by: David Kimdon [EMAIL PROTECTED] Index: wireless-dev/include/net/d80211.h === ---

[take2 3/5] d80211: remove bitfields from ieee80211_key_conf

2006-10-18 Thread David Kimdon
All three one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_KEY_* definitions. The 8 bit keyidx bitfield is converted to type s8. Signed-off-by: David Kimdon [EMAIL PROTECTED] Index: wireless-dev/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c

[take2 1/5] d80211: remove bitfields from ieee80211_tx_control

2006-10-18 Thread David Kimdon
All one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_TXCTL_* definitions. The multiple bit members were converted to u8, s8 or u16 as appropriate. Signed-off-by: David Kimdon [EMAIL PROTECTED] Index: wireless-dev/include/net/d80211.h

[take2 0/5] d80211: remove bitfields from include/net/d80211.h

2006-10-18 Thread David Kimdon
Continue d80211 bitfield removal. In general, compilers have difficulty generating efficient code for bitfields. This patchset removes all bitfields from include/net/d80211.h. I converted the 1 bit bitfields into a bit in a u32/u16 or u8 flags structure member. Larger bitfields I converted

[PATCH] netpoll: retry memory leak

2006-10-18 Thread Stephen Hemminger
If netpoll uses up it's retries, it should drop the skb not leak memory. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/core/netpoll.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index ead5920..c375fde 100644

[patch] d80211: fix kernel doc for ieee80211_get_buffered_bc

2006-10-18 Thread David Kimdon
ieee80211_beacon_get() was already described. The doc entry in question describes ieee80211_get_buffered_bc(). Signed-off-by: David Kimdon [EMAIL PROTECTED] Index: wireless-dev/include/net/d80211.h === ---

netpoll causes malformed protocol message

2006-10-18 Thread Stephen Hemminger
Now that I know what this is, perhaps others should know. Linus Torvalds [EMAIL PROTECTED] wrote: Since I've been re-testing the Apple Intel Mac Mini suspend/resume due to a USB problem, I thought I might as well see if this rings any bells.. On resume, networking does actually

Re: [Madwifi-devel] d80211: ANNOUNCE: DadWifi, a port of MadWifi to d80211

2006-10-18 Thread Matt Brown
Christoph Hellwig wrote: Guys, why do you waste your time on doing stuff that's useless for most of us, and that people can't even legally redistribute. Well that may be your opinion, but it's certainly not mine. We had just discussed starting an in-house project to port the HAL to the d80211

[patch] Add ethtool -i interface to Prism54

2006-10-18 Thread Kai Engert
Attached is a small patch that will add support for ethtool -i to the prism54 driver. ethtool -i queries the specified ethernet device for associated driver information. This helps tools like Fedora's system-config-network to provide GUI management of network devices. I learned how to

[PATCH 1/7] I/OAT: Push pending transactions to hardware more frequently

2006-10-18 Thread Chris Leech
Every 20 descriptors turns out to be to few append commands with newer/faster CPUs. Pushing every 4 still cuts down on MMIO writes to an acceptable level without letting the DMA engine run out of work. Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/dma/ioatdma.c |4 ++-- 1 files

  1   2   >