On 09/02/15 at 10:00am, Herbert Xu wrote:
> On Tue, Sep 01, 2015 at 04:51:24PM +0200, Thomas Graf wrote:
> >
> > 1. The current in-kernel self-test
> > 2. bind_netlink.c: https://github.com/tgraf/rhashtable
>
> Thanks, I will try to reproduce this.
The path in question is:
int rhashtable_insert_
Hi Jiri,
It's probably a bug fix that unveils the link errors.
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: 20a17bf6c04e3eca8824c930ecc55ab832558e3b
commit: 751a587ac9f9a8bf314590fbac32d9e418060c5a [300/401] route: fix breakage
after moving lwtunnel sta
On 09/02/2015 09:26 AM, kbuild test robot wrote:
Hi Jiri,
It's probably a bug fix that unveils the link errors.
I'll have a look, thanks!
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: 20a17bf6c04e3eca8824c930ecc55ab832558e3b
commit: 751a587ac9f9a8bf3
Add option to disable any reply not related to a listening socket,
like RST/ACK for TCP and ICMP Port-Unreachable for UDP.
Also disables ICMP replies to echo request and timestamp.
The stealth mode can be enabled selectively for a single interface.
Signed-off-by: Matteo Croce
---
Documentation/n
tse_poll() calls __napi_complete() with irq enabled. This leads napi
poll_list corruption and may stop all napi drivers working.
Use napi_complete() instead of __napi_complete().
Signed-off-by: Atsushi Nemoto
---
drivers/net/ethernet/altera/altera_tse_main.c |3 +--
1 file changed, 1 insert
Hi Eric!
Thanks for the direction. I tried packet drill locally (with the same kernel
Linux 3.18.5 to start with)
with the following script. And it doesn’t show the problem I mentioned.
So the fast retransmit happens after getting the dupack.
It would be good if I could get some information from
From: Russell King
The patch just to re-submit the patch "db3421c114cfa6326" because the
patch "4d494cdc92b3b9a0" remove the change.
Clear any pending receive interrupt before we process a pending packet.
This helps to avoid any spurious interrupts being raised after we have
fully cleaned the re
On Wed, Sep 02, 2015 at 11:40:15AM +0200, Philippe De Muyter wrote:
> On Wed, Sep 02, 2015 at 05:24:14PM +0800, Fugang Duan wrote:
> > From: Russell King
> >
> > The patch just to re-submit the patch "db3421c114cfa6326" because the
> > patch "4d494cdc92b3b9a0" remove the change.
>
> I think you
On 09/02/2015 02:04 AM, Ken-ichirou MATSUZAWA wrote:
On Wed, Aug 19, 2015 at 04:29:32PM +0200, Daniel Borkmann wrote:
On 08/17/2015 11:02 PM, David Miller wrote:
From: Daniel Borkmann
Date: Fri, 14 Aug 2015 12:38:21 +0200
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index
On Wed, Jul 15, 2015 at 12:24 AM, Andy Lutomirski wrote:
> On x86_64, there's no socketcall syscall; instead all of the socket
> calls are real syscalls. For 32-bit programs, we're stuck offering
> the socketcall syscall, but it would be nice to expose the direct
> calls as well. This will enabl
This reverts commit 8013d1d7eafb0589ca766db6b74026f76b7f5cb4.
There are several issues with this patch.
It completely cancels the security changes introduced by 6fd99094de2b
("ipv6: Don't reduce hop limit for an interface").
The current default value (min hop limit = 1) can result in the same
deni
On Wed, Sep 02, 2015 at 05:24:14PM +0800, Fugang Duan wrote:
> From: Russell King
>
> The patch just to re-submit the patch "db3421c114cfa6326" because the
> patch "4d494cdc92b3b9a0" remove the change.
I think you should mention also the titles of the commits.
And maybe send it also to stable.
On Tue, 2015-09-01 at 18:49 -0700, Alexander Duyck wrote:
> On 07/30/2015 03:19 PM, Alexander Duyck wrote:
> > This patch updates the lowest limit for adaptive interrupt interrupt
> > moderation to roughly 12K interrupts per second.
> >
> > The way I came about reaching 12K as the desired interrupt
Thank you for the reply.
On Wed, Sep 02, 2015 at 11:47:26AM +0200, Daniel Borkmann wrote:
> On 09/02/2015 02:04 AM, Ken-ichirou MATSUZAWA wrote:
> >Talking about skb_copy path, original skb's shared info is accessed
> >only in copy_skb_header, to get gso related field. As a result of
>
> It's sti
diag socket's sock_diag_put_filterinfo() dumps classic BPF programs
upon request to user space (ss -0 -b). However, native eBPF programs
attached to sockets (SO_ATTACH_BPF) cannot be dumped with this method:
Their orig_prog is always NULL. However, sock_diag_put_filterinfo()
unconditionally tries
Xen's PV network protocol includes messages to add/remove ethernet
multicast addresses to/from a filter list in the backend. This allows
the frontend to request the backend only forward multicast packets
which are off interest thus preventing unnecessary noise on the shared
ring.
The canonical net
On 09/02/2015 08:22 AM, Cong Wang wrote:
(Why not Cc'ing Jamal for net_sched pathes?)
Sorry, forgot about it, and thanks for the Cc!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.ker
This switches IPv6 policy routing to use the shared
fib_default_rule_pref() function of IPv4 and DECnet. It is also used in
multicast routing for IPv4 as well as IPv6.
The motivation for this patch is a complaint about iproute2 behaving
inconsistent between IPv4 and IPv6 when adding policy rules:
Le 02/09/2015 14:00, Daniel Borkmann a écrit :
diag socket's sock_diag_put_filterinfo() dumps classic BPF programs
upon request to user space (ss -0 -b). However, native eBPF programs
attached to sockets (SO_ATTACH_BPF) cannot be dumped with this method:
Their orig_prog is always NULL. However,
On Wed, 2015-09-02 at 10:54 +0200, Mohammad Rajiullah wrote:
> Hi Eric!
>
> Thanks for the direction. I tried packet drill locally (with the same kernel
> Linux 3.18.5 to start with)
> with the following script. And it doesn’t show the problem I mentioned.
> So the fast retransmit happens after
On Wed, Sep 02, 2015 at 01:19:53PM +0100, Paul Durrant wrote:
> Xen's PV network protocol includes messages to add/remove ethernet
> multicast addresses to/from a filter list in the backend. This allows
> the frontend to request the backend only forward multicast packets
> which are off interest th
> -Original Message-
> From: Wei Liu [mailto:wei.l...@citrix.com]
> Sent: 02 September 2015 15:01
> To: Paul Durrant
> Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org; Ian Campbell;
> Wei Liu
> Subject: Re: [PATCH net-next] xen-netback: add support for multicast control
>
> On W
On 9/2/15 5:00 AM, Daniel Borkmann wrote:
diag socket's sock_diag_put_filterinfo() dumps classic BPF programs
upon request to user space (ss -0 -b). However, native eBPF programs
attached to sockets (SO_ATTACH_BPF) cannot be dumped with this method:
...
Fixes: 89aa075832b0 ("net: sock: allow eB
From: Dmitry S Kolmakov
If an attempt to wake up users of broadcast link is made when there is no
enough place in send queue than it may hang up inside the tipc_sk_rcv()
function since the loop breaks only after the wake up queue becomes empty. This
can lead to complete CPU stall with the foll
On 09/02/2015 01:35 PM, Ken-ichirou MATSUZAWA wrote:
Thank you for the reply.
On Wed, Sep 02, 2015 at 11:47:26AM +0200, Daniel Borkmann wrote:
On 09/02/2015 02:04 AM, Ken-ichirou MATSUZAWA wrote:
Talking about skb_copy path, original skb's shared info is accessed
only in copy_skb_header, to ge
On 9/1/15, 10:54 PM, Roopa Prabhu wrote:
From: Roopa Prabhu
Problem:
The ecmp route replace support for ipv6 in the kernel, deletes the
existing ecmp route too early, ie when it installs the first nexthop.
If there is an error in installing the subsequent nexthops, its too late
to recover the a
Le 02/09/2015 01:23, James Loosli a écrit :
I seem to have an issue with using namespace-specific hosts files.
Here's an example.
I have different entries for foo.com in my hosts file for the
namespace and the system-wide hosts file;
root@server-01 Tue Sep 01 04:15:02pm
cat /etc/netns/nsXX-XXX
From: Fabio Estevam
Commit a5597008dbc2 ("phy: fixed_phy: Add gpio to determine link up/down.")
added a new argument to fixed_phy_register(), but missed to update bgmac
driver, causing the following build failure:
drivers/net/ethernet/broadcom/bgmac.c:1450:2: error: too few arguments to
functio
Wed, Sep 02, 2015 at 06:33:34AM CEST, t...@herbertland.com wrote:
>On Tue, Sep 1, 2015 at 9:19 PM, David Miller wrote:
>>
>> Signed-off-by: David S. Miller
>> ---
>> include/linux/skbuff.h| 8 ++---
>> include/net/flow.h| 8 ++---
>> net/core/flow_dissector.c | 79
>> +
All callers to rt_dst_alloc have nearly the same initialization following
a successful allocation. Consolidate it into rt_dst_alloc.
Signed-off-by: David Ahern
---
net/ipv4/route.c | 85 ++--
1 file changed, 33 insertions(+), 52 deletions(-)
d
Add the FIB table id to rtable to make the information available for
IPv4 as it is for IPv6.
Signed-off-by: David Ahern
---
drivers/net/vrf.c | 2 ++
include/net/route.h | 2 ++
net/ipv4/route.c| 8
net/ipv4/xfrm4_policy.c | 1 +
4 files changed, 13 insertions(+)
diff
rt_fill_info which is called for 'route get' requests hardcodes the
table id as RT_TABLE_MAIN which is not correct when multiple tables
are used. Use the newly added table id in the rtable to send back
the correct table.
Signed-off-by: David Ahern
---
net/ipv4/route.c | 4 ++--
1 file changed, 2
> Make sure you backported commit
> 10e2eb878f3ca07ac2f05fa5ca5e6c4c9174a27a
> ("udp: fix dst races with multicast early demux")
I just tried the latest CoreOS alpha, which had that patch. Sadly, I saw
just as many reboots. Here's a sample of the different types of Oopses I
see (I've put the re
> On Sep 1, 2015, at 8:17 PM, Tom Herbert wrote:
>
> I suspect this is not UDP-encapsulation specific, will it work with
> TCP/IP/IP, TCP/IP/GRE etc.?
It could do more, but this is what has been tested up to this point.
> Isn't there anyway the ixgbe could just be made to NETIF_HW_CSUM? That
>
> On Sep 1, 2015, at 8:31 PM, Tom Herbert wrote:
>
>> @@ -7240,6 +7267,10 @@ static void ixgbe_atr(struct ixgbe_ring *ring,
>>struct ipv6hdr *ipv6;
>>} hdr;
>>struct tcphdr *th;
>> + struct sk_buff *skb;
>> +#ifdef CONFIG_IXGBE_VXLAN
>> + u8 encap = fal
Xen's PV network protocol includes messages to add/remove ethernet
multicast addresses to/from a filter list in the backend. This allows
the frontend to request the backend only forward multicast packets
which are of interest thus preventing unnecessary noise on the shared
ring.
The canonical neti
On Wed, Sep 2, 2015 at 9:39 AM, Jiri Pirko wrote:
> Wed, Sep 02, 2015 at 06:33:34AM CEST, t...@herbertland.com wrote:
>>On Tue, Sep 1, 2015 at 9:19 PM, David Miller wrote:
>>>
>>> Signed-off-by: David S. Miller
>>> ---
>>> include/linux/skbuff.h| 8 ++---
>>> include/net/flow.h| 8
On Wed, Sep 02, 2015 at 05:58:36PM +0100, Paul Durrant wrote:
> Xen's PV network protocol includes messages to add/remove ethernet
> multicast addresses to/from a filter list in the backend. This allows
> the frontend to request the backend only forward multicast packets
> which are of interest thu
restore_regulatory_settings() should restore alpha2
as computed in restore_alpha2(), not raw user_alpha2 to
behave as described in the comment just above that code.
This fixes endless loop of calling CRDA for "00" and "97"
countries after resume from suspend on my laptop.
Looks like others had th
Table id is not dumped for 'ip route get' requests because the RTM_F_CLONED
flag is set in rt_fill_info. Move it out from the check and show user the
table id any time it is not MAIN.
Example:
$ ip ru ls
0: from all lookup local
32765: from all to 10.2.1.0/24 lookup 10
On Wed, Sep 2, 2015 at 9:46 AM, Rustad, Mark D wrote:
>> On Sep 1, 2015, at 8:17 PM, Tom Herbert wrote:
>>
>> I suspect this is not UDP-encapsulation specific, will it work with
>> TCP/IP/IP, TCP/IP/GRE etc.?
>
> It could do more, but this is what has been tested up to this point.
>
Well, please
From: Atsushi Nemoto
Date: Wed, 2 Sep 2015 17:49:29 +0900
> tse_poll() calls __napi_complete() with irq enabled. This leads napi
> poll_list corruption and may stop all napi drivers working.
> Use napi_complete() instead of __napi_complete().
>
> Signed-off-by: Atsushi Nemoto
Two lines below
From: Daniel Borkmann
Date: Wed, 2 Sep 2015 14:00:36 +0200
> diag socket's sock_diag_put_filterinfo() dumps classic BPF programs
> upon request to user space (ss -0 -b). However, native eBPF programs
> attached to sockets (SO_ATTACH_BPF) cannot be dumped with this method:
>
> Their orig_prog is
From: Phil Sutter
Date: Wed, 2 Sep 2015 15:03:12 +0200
> This switches IPv6 policy routing to use the shared
> fib_default_rule_pref() function of IPv4 and DECnet. It is also used in
> multicast routing for IPv4 as well as IPv6.
>
> The motivation for this patch is a complaint about iproute2 be
From: Fabio Estevam
Date: Wed, 2 Sep 2015 13:25:59 -0300
> From: Fabio Estevam
>
> Commit a5597008dbc2 ("phy: fixed_phy: Add gpio to determine link up/down.")
> added a new argument to fixed_phy_register(), but missed to update bgmac
> driver, causing the following build failure:
>
> drivers/
From: Jiri Pirko
Date: Wed, 2 Sep 2015 18:39:34 +0200
> Wed, Sep 02, 2015 at 06:33:34AM CEST, t...@herbertland.com wrote:
>>> @@ -19,14 +19,14 @@
>>> #include
>>> #include
>>>
>>> -static bool skb_flow_dissector_uses_key(struct flow_dissector
>>> *flow_dissector,
>>> -
On 09/02/15 at 09:40am, David Ahern wrote:
> rt_fill_info which is called for 'route get' requests hardcodes the
> table id as RT_TABLE_MAIN which is not correct when multiple tables
> are used. Use the newly added table id in the rtable to send back
> the correct table.
>
> Signed-off-by: David A
From: Paul Durrant
Date: Wed, 2 Sep 2015 17:58:36 +0100
> Xen's PV network protocol includes messages to add/remove ethernet
> multicast addresses to/from a filter list in the backend. This allows
> the frontend to request the backend only forward multicast packets
> which are of interest thus pr
On 09/02/15 at 11:34am, David Miller wrote:
> From: Phil Sutter
> Date: Wed, 2 Sep 2015 15:03:12 +0200
>
> > This switches IPv6 policy routing to use the shared
> > fib_default_rule_pref() function of IPv4 and DECnet. It is also used in
> > multicast routing for IPv4 as well as IPv6.
> >
> > Th
From: Thomas Graf
Date: Wed, 2 Sep 2015 20:43:46 +0200
> On 09/02/15 at 09:40am, David Ahern wrote:
>> rt_fill_info which is called for 'route get' requests hardcodes the
>> table id as RT_TABLE_MAIN which is not correct when multiple tables
>> are used. Use the newly added table id in the rtable
On 9/2/15 12:49 PM, David Miller wrote:
From: Thomas Graf
Date: Wed, 2 Sep 2015 20:43:46 +0200
On 09/02/15 at 09:40am, David Ahern wrote:
rt_fill_info which is called for 'route get' requests hardcodes the
table id as RT_TABLE_MAIN which is not correct when multiple tables
are used. Use the n
While testing various Kconfig options on another issue, I found that
the following one triggers as well on allmodconfig and nf_conntrack
disabled:
net/ipv4/netfilter/nf_dup_ipv4.c: In function ‘nf_dup_ipv4’:
net/ipv4/netfilter/nf_dup_ipv4.c:72:20: error: ‘nf_skb_duplicated’ undeclared
(first
Add support for 'ip [-6] route get table X' where the user wants to
force the FIB lookup from a given table.
Signed-off-by: David Ahern
---
include/net/flow.h | 4
include/net/ip_fib.h| 15 +++
net/ipv4/fib_frontend.c | 2 ++
net/ipv4/route.c| 2 ++
net/ipv6/
On 09/02/15 at 12:51pm, David Ahern wrote:
> On 9/2/15 12:49 PM, David Miller wrote:
> >From: Thomas Graf
> >Date: Wed, 2 Sep 2015 20:43:46 +0200
> >
> >>On 09/02/15 at 09:40am, David Ahern wrote:
> >>>rt_fill_info which is called for 'route get' requests hardcodes the
> >>>table id as RT_TABLE_MA
On 09/02/15 at 12:03pm, David Ahern wrote:
> Add support for 'ip [-6] route get table X' where the user wants to
> force the FIB lookup from a given table.
>
> Signed-off-by: David Ahern
Will you use this outside of 'ip route get' as well? If so, how? I'm
asking because you propose to add the ch
These are two fixes for sctp after my patch on 0ca50d12fe46 ("sctp: fix
src address selection if using secondary addresses")
The first, fix a dst leak on those it decided to skip.
The second, adds the fallback on src selection that Vlad had asked
about. Unfortunatelly a lot of ipvs setups relies
Commit 0ca50d12fe46 failed to release the reference to dst entries that
it decided to skip.
Fixes: 0ca50d12fe46 ("sctp: fix src address selection if using secondary
addresses")
Signed-off-by: Marcelo Ricardo Leitner
---
net/sctp/protocol.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-
Commit 0ca50d12fe46 added a restriction that the address must belong to
the output interface, so that sctp will use the right interface even
when using secondary addresses.
But it breaks IPVS setups, on which people is used to attach VIP
addresses to loopback interface on real servers. It's prefer
On 9/2/15 1:12 PM, Thomas Graf wrote:
On 09/02/15 at 12:03pm, David Ahern wrote:
Add support for 'ip [-6] route get table X' where the user wants to
force the FIB lookup from a given table.
Signed-off-by: David Ahern
Will you use this outside of 'ip route get' as well? If so, how? I'm
asking
On 09/02/15 at 01:22pm, David Ahern wrote:
> On 9/2/15 1:12 PM, Thomas Graf wrote:
> >On 09/02/15 at 12:03pm, David Ahern wrote:
> >>Add support for 'ip [-6] route get table X' where the user wants to
> >>force the FIB lookup from a given table.
> >>
> >>Signed-off-by: David Ahern
> >
> >Will you
On Wed, Sep 02, 2015 at 09:08:36PM +0200, Thomas Graf wrote:
> On 09/02/15 at 12:51pm, David Ahern wrote:
> > On 9/2/15 12:49 PM, David Miller wrote:
> > >From: Thomas Graf
> > >Date: Wed, 2 Sep 2015 20:43:46 +0200
> > >
> > >>On 09/02/15 at 09:40am, David Ahern wrote:
> > >>>rt_fill_info which is
On 9/2/15 1:38 PM, Thomas Graf wrote:
On 09/02/15 at 01:22pm, David Ahern wrote:
On 9/2/15 1:12 PM, Thomas Graf wrote:
On 09/02/15 at 12:03pm, David Ahern wrote:
Add support for 'ip [-6] route get table X' where the user wants to
force the FIB lookup from a given table.
Signed-off-by: David A
IPv4 ABI has the table hardcoded as RT_TABLE_MAIN regardless of the table
hit for the route lookup. Add the table using a new attribute,
RTA_TABLE_LOOKUP, to maintain the ABI yet return the right table id.
Signed-off-by: David Ahern
---
Thomas: Something like this?
The current ABI is returning
On 09/02/2015 02:48 AM, Geert Uytterhoeven wrote:
>
> Should all other architectures follow suit?
> Or should we follow the s390 approach:
>
It is up to the maintainer(s), largely dependent on how likely you are
going to want to support this in your libc, but in general, socketcall
is an abomina
On 09/02/15 at 03:43pm, Andy Gospodarek wrote:
> On Wed, Sep 02, 2015 at 09:08:36PM +0200, Thomas Graf wrote:
> > This behaviour comes back from when we still had the IPv4 routing cache
> > which was flat.
>
> So before the routing cache was removed, was the response always
> RTA_TABLE_MAIN since
On 09/02/15 at 01:16pm, David Ahern wrote:
> IPv4 ABI has the table hardcoded as RT_TABLE_MAIN regardless of the table
> hit for the route lookup. Add the table using a new attribute,
> RTA_TABLE_LOOKUP, to maintain the ABI yet return the right table id.
>
> Signed-off-by: David Ahern
> ---
>
>
On 09/02/15 02:22, Cong Wang wrote:
(Why not Cc'ing Jamal for net_sched pathes?)
On Tue, Sep 1, 2015 at 9:34 AM, Daniel Borkmann wrote:
From: John Fastabend
Add a new ->preclassify() op to allow multiqueue queuing disciplines
to call tc_classify() or perform other work before dev_pick_tx().
On 9/2/15 2:23 PM, Thomas Graf wrote:
On 09/02/15 at 01:16pm, David Ahern wrote:
IPv4 ABI has the table hardcoded as RT_TABLE_MAIN regardless of the table
hit for the route lookup. Add the table using a new attribute,
RTA_TABLE_LOOKUP, to maintain the ABI yet return the right table id.
Signed-o
On 09/02/2015 01:16 PM, David Ahern wrote:
IPv4 ABI has the table hardcoded as RT_TABLE_MAIN regardless of the table
hit for the route lookup. Add the table using a new attribute,
RTA_TABLE_LOOKUP, to maintain the ABI yet return the right table id.
Signed-off-by: David Ahern
---
Thomas: Someth
On 9/2/15 2:41 PM, Alexander Duyck wrote:
Why not implement this this same for IPv4 and IPv6? It looks like it is
only included if it is non-zer and not MAIN in the above case, and then
below as long as a table ID is non-zero you are setting the value. Why
not just include the value in all cas
On Wed, 2 Sep 2015 13:16:20 -0700
David Ahern wrote:
> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
> index 702024769c74..5add1468350a 100644
> --- a/include/uapi/linux/rtnetlink.h
> +++ b/include/uapi/linux/rtnetlink.h
> @@ -310,6 +310,7 @@ enum rtattr_type_t {
>
On Wed, Sep 2, 2015 at 8:38 PM, Tom Herbert wrote:
> On Wed, Sep 2, 2015 at 9:46 AM, Rustad, Mark D
> wrote:
>>> On Sep 1, 2015, at 8:17 PM, Tom Herbert wrote:
>>>
>>> I suspect this is not UDP-encapsulation specific, will it work with
>>> TCP/IP/IP, TCP/IP/GRE etc.?
>>
>> It could do more, but
Add the FIB table id to rtable to make the information available for
IPv4 as it is for IPv6.
Signed-off-by: David Ahern
---
drivers/net/vrf.c | 2 ++
include/net/route.h | 2 ++
net/ipv4/route.c| 8
net/ipv4/xfrm4_policy.c | 1 +
4 files changed, 13 insertions(+)
diff
All callers to rt_dst_alloc have nearly the same initialization following
a successful allocation. Consolidate it into rt_dst_alloc.
Signed-off-by: David Ahern
---
net/ipv4/route.c | 85 ++--
1 file changed, 33 insertions(+), 52 deletions(-)
d
rt_fill_info which is called for 'route get' requests hardcodes the
table id as RT_TABLE_MAIN which is not correct when multiple tables
are used. Use the newly added table id in the rtable to send back
the correct table similar to what is done for IPv6.
To maintain current ABI a new request flag,
On Tue, Sep 01, 2015 at 01:14:20PM -0700, Eric Dumazet wrote:
> > 2. Use a spinlock to protect the dst_cache operations
>
> Well, a seqlock would be better : No need for an atomic operation in
> fast path.
>
seqlock can ensure consistency between idst->dst and idst->cookie.
However, IPv6 dst destru
On Wed, Sep 2, 2015 at 8:38 PM, Tom Herbert wrote:
> On Wed, Sep 2, 2015 at 9:46 AM, Rustad, Mark D
> wrote:
>> Note: NETIF_F_HW_CSUM is a superset of NETIF_F_IP_CSUM + NETIF_F_IPV6_CSUM.
>> It means that device can fill TCP/UDP-like checksum anywhere in the packets
>> whatever headers there mi
On Wed, 2015-09-02 at 13:58 -0700, Martin KaFai Lau wrote:
> On Tue, Sep 01, 2015 at 01:14:20PM -0700, Eric Dumazet wrote:
> > > 2. Use a spinlock to protect the dst_cache operations
> >
> > Well, a seqlock would be better : No need for an atomic operation in
> > fast path.
> >
> seqlock can ensure
On Wed, Sep 02, 2015 at 02:30:45PM -0700, Eric Dumazet wrote:
> Object cannot be freed until all cpus have exited their RCU sections.
You meant the dst_destroy() here will wait for all cpus exited their RCU
sections?
static inline void dst_free(struct dst_entry *dst)
{
if (dst->obsolete >
On Wed, Sep 02, 2015 at 05:56:36PM +0200, Daniel Borkmann wrote:
> you suggest or not), for two reasons: I think (will start experimenting
> more with it tomorrow), you would get an out of bounds access here in
> case the skb->data is the last slot in the ring buffer and reaches
> exactly to the ri
We previously register IPPROTO_ROUTING offload under inet6_add_offload(),
but in error path, we try to unregister it with inet_del_offload(). This
doesn't seem correct, it should actually be inet6_del_offload(), also
ipv6_exthdrs_offload_exit() from that commit seems rather incorrect (it
also uses
From: Daniel Borkmann
Date: Thu, 3 Sep 2015 00:29:07 +0200
> We previously register IPPROTO_ROUTING offload under inet6_add_offload(),
> but in error path, we try to unregister it with inet_del_offload(). This
> doesn't seem correct, it should actually be inet6_del_offload(), also
> ipv6_exthdrs
From: Andy Gospodarek
Date: Wed, 2 Sep 2015 15:43:27 -0400
> On Wed, Sep 02, 2015 at 09:08:36PM +0200, Thomas Graf wrote:
>> On 09/02/15 at 12:51pm, David Ahern wrote:
>> > On 9/2/15 12:49 PM, David Miller wrote:
>> > >From: Thomas Graf
>> > >Date: Wed, 2 Sep 2015 20:43:46 +0200
>> > >
>> > >>On
-Original Message-
From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On
Behalf Of Jarod Wilson
Sent: Thursday, August 13, 2015 11:03 AM
To: linux-ker...@vger.kernel.org
Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; Jarod Wilson
Subject: [Intel-wired
On Wed, Sep 2, 2015 at 2:07 PM, Or Gerlitz wrote:
> On Wed, Sep 2, 2015 at 8:38 PM, Tom Herbert wrote:
>> On Wed, Sep 2, 2015 at 9:46 AM, Rustad, Mark D
>> wrote:
>
>>> Note: NETIF_F_HW_CSUM is a superset of NETIF_F_IP_CSUM + NETIF_F_IPV6_CSUM.
>>> It means that device can fill TCP/UDP-like che
On Wed, 2015-09-02 at 14:52 -0700, Martin KaFai Lau wrote:
> On Wed, Sep 02, 2015 at 02:30:45PM -0700, Eric Dumazet wrote:
> > Object cannot be freed until all cpus have exited their RCU sections.
> You meant the dst_destroy() here will wait for all cpus exited their RCU
> sections?
>
> static in
From: Eric Dumazet
Date: Wed, 02 Sep 2015 15:48:57 -0700
> On Wed, 2015-09-02 at 14:52 -0700, Martin KaFai Lau wrote:
>> On Wed, Sep 02, 2015 at 02:30:45PM -0700, Eric Dumazet wrote:
>> > Object cannot be freed until all cpus have exited their RCU sections.
>> You meant the dst_destroy() here wil
On Wed, Sep 02, 2015 at 03:48:57PM -0700, Eric Dumazet wrote:
> On Wed, 2015-09-02 at 14:52 -0700, Martin KaFai Lau wrote:
> > On Wed, Sep 02, 2015 at 02:30:45PM -0700, Eric Dumazet wrote:
> > > Object cannot be freed until all cpus have exited their RCU sections.
> > You meant the dst_destroy() he
From: Martin KaFai Lau
Date: Wed, 2 Sep 2015 16:10:31 -0700
> On Wed, Sep 02, 2015 at 03:48:57PM -0700, Eric Dumazet wrote:
>> dst_free() is called after RCU grace period, in the case you are
>> interested in.
>>
>> Look at dst_rcu_free() and rt_free()
> Yes for IPv4 FIB
>
> Not for IPv6 FIB. F.
From: Sabrina Dubroca
Date: Wed, 2 Sep 2015 11:43:01 +0200
> This reverts commit 8013d1d7eafb0589ca766db6b74026f76b7f5cb4.
>
> There are several issues with this patch.
> It completely cancels the security changes introduced by 6fd99094de2b
> ("ipv6: Don't reduce hop limit for an interface").
>
From: Fugang Duan
Date: Wed, 2 Sep 2015 17:24:14 +0800
> From: Russell King
>
> The patch just to re-submit the patch "db3421c114cfa6326" because the
> patch "4d494cdc92b3b9a0" remove the change.
>
> Clear any pending receive interrupt before we process a pending packet.
> This helps to avoid
On Wed, Sep 2, 2015 at 9:46 AM, Rustad, Mark D wrote:
>> On Sep 1, 2015, at 8:17 PM, Tom Herbert wrote:
>>
>> I suspect this is not UDP-encapsulation specific, will it work with
>> TCP/IP/IP, TCP/IP/GRE etc.?
>
Mark, another question in this area of code. Looking at ixgbe_tx_csum,
I'm wondering w
Fengguang reported, that some randconfig generated the following linker
issue with nf_ct_zone_dflt object involved:
[...]
CC init/version.o
LD init/built-in.o
net/built-in.o: In function `ipv4_conntrack_defrag':
nf_defrag_ipv4.c:(.text+0x93e95): undefined reference to `nf_ct_zo
From: Kolmakov Dmitriy
Date: Wed, 2 Sep 2015 15:33:00 +
> If an attempt to wake up users of broadcast link is made when there
> is no enough place in send queue than it may hang up inside the
> tipc_sk_rcv() function since the loop breaks only after the wake up
> queue becomes empty. This can
From: Daniel Borkmann
Date: Wed, 2 Sep 2015 20:54:02 +0200
> While testing various Kconfig options on another issue, I found that
> the following one triggers as well on allmodconfig and nf_conntrack
> disabled:
>
> net/ipv4/netfilter/nf_dup_ipv4.c: In function ‘nf_dup_ipv4’:
> net/ipv4/net
From: Daniel Borkmann
Date: Thu, 3 Sep 2015 01:26:07 +0200
> Fengguang reported, that some randconfig generated the following linker
> issue with nf_ct_zone_dflt object involved:
>
> [...]
> CC init/version.o
> LD init/built-in.o
> net/built-in.o: In function `ipv4_conntrack_d
From: Roopa Prabhu
Problem:
The ecmp route replace support for ipv6 in the kernel, deletes the
existing ecmp route too early, ie when it installs the first nexthop.
If there is an error in installing the subsequent nexthops, its too late
to recover the already deleted existing route
This patch f
On Wed, 2015-09-02 at 16:10 -0700, Martin KaFai Lau wrote:
> On Wed, Sep 02, 2015 at 03:48:57PM -0700, Eric Dumazet wrote:
> > On Wed, 2015-09-02 at 14:52 -0700, Martin KaFai Lau wrote:
> > > On Wed, Sep 02, 2015 at 02:30:45PM -0700, Eric Dumazet wrote:
> > > > Object cannot be freed until all cpus
On 09/02/2015 06:39 PM, Shaun Crampton wrote:
Make sure you backported commit
10e2eb878f3ca07ac2f05fa5ca5e6c4c9174a27a
("udp: fix dst races with multicast early demux")
I just tried the latest CoreOS alpha, which had that patch. Sadly, I saw
just as many reboots. Here's a sample of the differ
> On Sep 2, 2015, at 4:21 PM, Tom Herbert wrote:
>
> Mark, another question in this area of code. Looking at ixgbe_tx_csum,
> I'm wondering what happens with those default cases for the switch
> statements. If those are hit for whatever reason does that mean the
> checksum is never resolved? It s
1 - 100 of 115 matches
Mail list logo
