Re: arp_filter and IPv6 ND

2016-12-02 Thread Saku Ytti
On 2 December 2016 at 16:08, Hannes Frederic Sowa wrote: Hey, > May I ask why you want to turn it off? Certainly. I don't want device to answer with link address for L3 address it does not have on the link. In my case it triggers this bug

RE: [PATCH net] fib_trie: Avoid expensive update of suffix length when not required

2016-12-02 Thread Duyck, Alexander H
> -Original Message- > From: Robert Shearman [mailto:rshea...@brocade.com] > Sent: Friday, December 2, 2016 5:54 AM > To: Alexander Duyck > Cc: David Miller ; Netdev ; > Duyck, Alexander H

Re: stmmac: turn coalescing / NAPI off in stmmac

2016-12-02 Thread Giuseppe CAVALLARO
Hi Pavel On 12/2/2016 11:42 AM, Pavel Machek wrote: Hi! Anyway... since you asked. I belive I have way to disable NAPI / tx coalescing in the driver. Unfortunately, locking is missing on the rx path, and needs to be extended to _irqsave variant on tx path. I have just replied to a previous

[PATCH net] net: avoid signed overflows for SO_{SND|RCV}BUFFORCE

2016-12-02 Thread Eric Dumazet
From: Eric Dumazet CAP_NET_ADMIN users should not be allowed to set negative sk_sndbuf or sk_rcvbuf values, as it can lead to various memory corruptions, crashes, OOM... Note that before commit 82981930125a ("net: cleanups in sock_setsockopt()"), the bug was even more

Re: [PATCH v3] sh_eth: remove unchecked interrupts for RZ/A1

2016-12-02 Thread David Miller
From: Chris Brandt Date: Thu, 1 Dec 2016 13:32:14 -0500 > When streaming a lot of data and the RZ/A1 can't keep up, some status bits > will get set that are not being checked or cleared which cause the > following messages and the Ethernet driver to stop working. This

Re: pull-request: can 2016-12-02

2016-12-02 Thread David Miller
From: Marc Kleine-Budde Date: Fri, 2 Dec 2016 09:29:29 +0100 > this is a pull request for net/master. > > THere are two patches by Stephane Grosjean, who adds support for the new > PCAN-USB X6 USB interface to the pcan_usb driver. Pulled, thanks.

Re: [PATCH net v3] tipc: check minimum bearer MTU

2016-12-02 Thread David Miller
From: Michal Kubecek Date: Fri, 2 Dec 2016 09:33:41 +0100 (CET) > Qian Zhang (张谦) reported a potential socket buffer overflow in > tipc_msg_build() which is also known as CVE-2016-8632: due to > insufficient checks, a buffer overflow can occur if MTU is too short for > even

Re: [PATCH net] net: avoid signed overflows for SO_{SND|RCV}BUFFORCE

2016-12-02 Thread David Miller
From: Eric Dumazet Date: Fri, 02 Dec 2016 09:44:53 -0800 > From: Eric Dumazet > > CAP_NET_ADMIN users should not be allowed to set negative > sk_sndbuf or sk_rcvbuf values, as it can lead to various memory > corruptions, crashes, OOM... > > Note

Re: [PATCH net v2] net: bcmgenet: Utilize correct struct device for all DMA operations

2016-12-02 Thread David Miller
From: Florian Fainelli Date: Thu, 1 Dec 2016 09:45:45 -0800 > From: Florian Fainelli > > __bcmgenet_tx_reclaim() and bcmgenet_free_rx_buffers() are not using the > same struct device during unmap that was used for the map operation, > which makes

Re: pull-request: wireless-drivers-next 2016-12-01

2016-12-02 Thread David Miller
From: Kalle Valo Date: Thu, 01 Dec 2016 20:33:37 +0200 > here's another pull request for net-next. Nothing special to mention > about, the details are in the signed tag below. > > This time there's a trivial conflict in > drivers/net/wireless/ath/ath10k/mac.c: > > <<<

Re: [patch] net: renesas: ravb: unintialized return value

2016-12-02 Thread David Miller
From: Dan Carpenter Date: Thu, 1 Dec 2016 23:57:44 +0300 > We want to set the other "err" variable here so that we can return it > later. My version of GCC misses this issue but I caught it with a > static checker. > > Fixes: 9f70eb339f52 ("net: ethernet: renesas:

Re: [PATCH] iproute2: ss: escape all null bytes in abstract unix domain socket

2016-12-02 Thread Eric Dumazet
On Sat, 2016-11-12 at 10:17 +0300, Stephen Hemminger wrote: > On Sat, 29 Oct 2016 22:20:19 +0300 > Isaac Boukris wrote: > > > Abstract unix domain socket may embed null characters, > > these should be translated to '@' when printed by ss the > > same way the null prefix is

Re: [PATCH net] geneve: avoid use-after-free of skb->data

2016-12-02 Thread David Miller
From: Sabrina Dubroca Date: Fri, 2 Dec 2016 16:49:29 +0100 > geneve{,6}_build_skb can end up doing a pskb_expand_head(), which > makes the ip_hdr(skb) reference we stashed earlier stale. Since it's > only needed as an argument to ip_tunnel_ecn_encap(), move this > directly

Re: bpf bounded loops. Was: [flamebait] xdp

2016-12-02 Thread Hannes Frederic Sowa
Hi, On 02.12.2016 19:39, Alexei Starovoitov wrote: > On Thu, Dec 01, 2016 at 10:27:12PM +0100, Hannes Frederic Sowa wrote: >> like") and the problematic of parsing DNS packets in XDP due to string >> processing and looping inside eBPF. > > Hannes, > Not too long ago you proposed a very

Re: [PATCH 4/6] net: ethernet: ti: cpts: add ptp pps support

2016-12-02 Thread Richard Cochran
On Fri, Dec 02, 2016 at 11:58:34AM -0600, Grygorii Strashko wrote: > or I missed smth? You are missing three important points. 1. Unlike the code you posted, no edges will be lost. 2. The solution using the PWM is implemented in USER SPACE. If people use this way, then they will be forced

[GIT] Networking

2016-12-02 Thread David Miller
1) Lots more phydev and probe error path leaks in various drivers by Johan Hovold. 2) Fix race in packet_set_ring(), from Philip Pettersson. 3) Use after free in dccp_invalid_packet(), from Eric Dumazet. 4) Signnedness overflow in SO_{SND,RCV}BUFFORCE, also from Eric Dumazet. 5) When

Re: [PATCHv2 net-next 3/4] net: dsa: mv88e6xxx: Move the tagging protocol into info

2016-12-02 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > @@ -3749,6 +3756,7 @@ static const struct mv88e6xxx_info mv88e6xxx_table[] = { > .global1_addr = 0x1b, > .age_time_coeff = 15000, > .g1_irqs = 9, > + .tag_protocol = DSA_TAG_PROTO_EDSA, >

Re: bpf bounded loops. Was: [flamebait] xdp

2016-12-02 Thread Hannes Frederic Sowa
On Fri, Dec 2, 2016, at 20:42, John Fastabend wrote: > On 16-12-02 11:25 AM, Hannes Frederic Sowa wrote: > > Hi, > > > > On 02.12.2016 19:39, Alexei Starovoitov wrote: > >> On Thu, Dec 01, 2016 at 10:27:12PM +0100, Hannes Frederic Sowa wrote: > >>> like") and the problematic of parsing DNS

Re: [flamebait] xdp, well meaning but pointless

2016-12-02 Thread Stephen Hemminger
On Fri, 2 Dec 2016 19:12:00 +0100 Hannes Frederic Sowa wrote: > On 02.12.2016 17:59, Tom Herbert wrote: > > On Fri, Dec 2, 2016 at 3:54 AM, Hannes Frederic Sowa > > wrote: > >> On 02.12.2016 11:24, Jesper Dangaard Brouer wrote: > >>>

Re: [PATCH v2] sh_eth: remove unchecked interrupts

2016-12-02 Thread Geert Uytterhoeven
Hi Chris, On Thu, Dec 1, 2016 at 7:53 PM, Chris Brandt wrote: > On 12/1/2016, Sergei Shtylyov wrote: >> >> On 12/01/2016 05:42 PM, Geert Uytterhoeven wrote: >> >> >> --- a/drivers/net/ethernet/renesas/sh_eth.c >> >> +++ b/drivers/net/ethernet/renesas/sh_eth.c >> >> @@

Re: [PATCHv2 net-next 2/4] net: dsa: mv88e6xxx: Monitor and Management tables

2016-12-02 Thread Andrew Lunn
On Fri, Dec 02, 2016 at 02:32:39PM -0500, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > @@ -3184,6 +3186,8 @@ static const struct mv88e6xxx_ops mv88e6085_ops = { > > .stats_get_sset_count = mv88e6095_stats_get_sset_count, > > .stats_get_strings =

Re: [PATCH next] dctcp: update cwnd on congestion event

2016-12-02 Thread Florian Westphal
Neal Cardwell wrote: > On Mon, Nov 14, 2016 at 10:42 AM, Florian Westphal wrote: > > > > draft-ietf-tcpm-dctcp-02 says: > > > > ... when the sender receives an indication of congestion > > (ECE), the sender SHOULD update cwnd as follows: > > > >

[PATCH] adm80211: add checks for dma mapping errors

2016-12-02 Thread Alexey Khoroshilov
The driver does not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/wireless/admtek/adm8211.c | 24

Re: [PATCHv2 net-next 2/4] net: dsa: mv88e6xxx: Monitor and Management tables

2016-12-02 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > On Fri, Dec 02, 2016 at 02:32:39PM -0500, Vivien Didelot wrote: >> Hi Andrew, >> >> Andrew Lunn writes: >> >> > @@ -3184,6 +3186,8 @@ static const struct mv88e6xxx_ops mv88e6085_ops = { >> >.stats_get_sset_count =

[PATCH net-next] tools: hv: Enable network manager for bonding scripts on RHEL

2016-12-02 Thread Haiyang Zhang
From: Haiyang Zhang We found network manager is necessary on RHEL to make the synthetic NIC, VF NIC bonding operations handled automatically. So, enabling network manager here. Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan

[PATCH net-next v5] ipv6 addrconf: Implemented enhanced DAD (RFC7527)

2016-12-02 Thread Erik Nordmark
Implemented RFC7527 Enhanced DAD. IPv6 duplicate address detection can fail if there is some temporary loopback of Ethernet frames. RFC7527 solves this by including a random nonce in the NS messages used for DAD, and if an NS is received with the same nonce it is assumed to be a looped back DAD

Re: [PATCHv2 net-next 4/4] net: dsa: mv88e6xxx: Refactor CPU and DSA port setup

2016-12-02 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> The port's EgressMode, FrameMode and EtherType are really tied together >> to compose the mode of the port. > > Setting the EtherType is somewhat separate. It is only needed on ports > using EDSA. And that can only happen on a CPU port. Humm,

Re: [PATCH iproute2 1/1] tc: updated man page to reflect handle-id use in filter GET command.

2016-12-02 Thread Stephen Hemminger
On Thu, 1 Dec 2016 15:20:44 -0500 Roman Mashak wrote: > Signed-off-by: Roman Mashak > --- > man/man8/tc.8 | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/man/man8/tc.8 b/man/man8/tc.8 > index 8a47a2b..d957ffa 100644 > ---

Re: [iproute PATCH v2 00/18] ss: Minor code review

2016-12-02 Thread Stephen Hemminger
On Fri, 2 Dec 2016 11:39:44 +0100 Phil Sutter wrote: > This is a series of misc changes to ss code which happened as fall-out > when working on a unified output formatter (still unfinished). > > Changes since v1: > - Rebased onto current upstream, resolved conflicts in patch 4

Re: [PATCH net-next 3/4] tcp: tsq: add shortcut in tcp_tasklet_func()

2016-12-02 Thread Eric Dumazet
On Fri, 2016-12-02 at 10:25 -0800, Eric Dumazet wrote: > Under high stress, I've seen tcp_tasklet_func() consuming > ~700 usec, handling ~150 tcp sockets. > > By setting TCP_TSQ_DEFERRED in tcp_wfree(), we give a chance > for other cpus/threads entering tcp_write_xmit() to grab it, > allowing

Re: [PATCH iproute2 V5 0/3] tc: Support for ip tunnel metadata set/unset/classify

2016-12-02 Thread Stephen Hemminger
On Fri, 2 Dec 2016 13:25:12 +0200 Amir Vadai wrote: > Hi, > > This short series adds support for matching and setting metadata for ip tunnel > shared device using the TC system, introduced in kernel 4.9 [1]. > > Applied and tested on top of commit b6c7fc61faab ("ss: print new

Re: [PATCH iproute2/net-next] ss: initialise variables outside of for loop

2016-12-02 Thread Stephen Hemminger
On Fri, 2 Dec 2016 12:56:05 +0100 Simon Horman wrote: > Initialise for loops outside of for loops. GCC flags this as being > out of spec unless C99 or C11 mode is used. > > With this change the entire tree appears to compile cleanly with -Wall. > > $ gcc --version

<    1   2   3   4