[PATCH 4/8] ipconfig: BOOTP: Request CONF_NAMESERVERS_MAX name servers

When ipconfig is autoconfigured via BOOTP, the request packet initialised by ic_bootp_init_ext() always allocates 8 bytes for the name server option, limiting the BOOTP server to responding with at most 2 name servers even though ipconfig in fact supports an arbitrary number of name servers (as

[PATCH net-next 00/19] r8169: series with further smaller improvements

This series includes further smaller improvements. Then I think the basic cleanup has been done and next step would be preparing the switch to phylib. Heiner Kallweit (19): r8169: remove unused member features from struct rtl8169_private r8169: remove member align from struct rtl_cfg_info

[net-next PATCH v4 03/13] net: netcp: ethss: use macro for checking ss_version consistently

Driver currently uses macro for NU and XBE hardwrae, while other places for older hardware such as that on K2H/K SoC (version 1.4 of the cpsw hardware, it explicitly check for the ss_version inline. Add a new macro for version 1.4 and use it to customize code in the driver. While at it also fix

[net-next PATCH v4 13/13] net: netcp: ethss: k2g: add promiscuous mode support

From: WingMan Kwok This patch adds support for promiscuous mode in k2g's network driver. When upper layer instructs to transition from non-promiscuous mode to promiscuous mode or vice versa K2G network driver needs to configure ALE accordingly so that in case of non-promiscuous

[net-next PATCH v4 05/13] net: netcp: ethss: add support for handling rgmii link interface

2u cpsw hardware on K2G uses rgmii link to interface with Phy. So add support for this interface in the code so that driver can be re-used for 2u hardware. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp.h | 2 ++

Re: general protection fault in encode_rpcb_string

On Mon, Apr 16, 2018 at 09:02:01PM -0700, syzbot wrote: > syzbot hit the following crash on bpf-next commit > 5d1365940a68dd57b031b6e3c07d7d451cd69daf (Thu Apr 12 18:09:05 2018 +) > Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net > syzbot dashboard link: >

[net-next PATCH v4 07/13] net: netcp: ethss: map vlan priorities to zero flow

The driver currently support only vlan priority zero. So map the vlan priorities to zero flow in hardware. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 9 + 1 file changed, 9 insertions(+) diff --git

[net-next PATCH v4 00/13] Add support for netcp driver on K2G SoC

K2G SoC is another variant of Keystone family of SoCs. This patch series add support for NetCP driver on this SoC. The QMSS found on K2G SoC is a cut down version of the QMSS found on other keystone devices with less number of queues, internal link ram etc. The patch series has 2 patch sets that

[PATCH net-next 12/19] r8169: change argument type of counters handling functions

The counter handling functions don't deal with the net_device, so code can be simplified by changing the argument type to struct rtl8169_private *. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 32 +++- 1 file changed, 13

[PATCH net-next 11/19] r8169: change hw_start argument type

Code can be simplified by changing the argument type of hw_start callbacks from struct net_device * to struct rtl8169_private *. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 41 ++-- 1 file changed, 15 insertions(+), 26

[PATCH net-next 05/19] r8169: switch to napi_schedule_irqoff

napi_schedule() is called from hard irq context, so we can switch to napi_schedule_irqoff() and avoid some overhead. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next 03/19] r8169: use skb_copy_to_linear_data in rtl8169_try_rx_copy

Not a giant leap for mankind, but let's avoid the open-coded memcpy and use standard helper skb_copy_to_linear_data instead. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next 04/19] r8169: use constant NAPI_POLL_WAIT

We can use generic constant NAPI_POLL_WAIT instead of defining an own constant for the same value. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH net-next 09/19] r8169: replace rx_buf_sz with a constant

rx_buf_sz is constant, so we don't have to pass it as parameter and in general can replace it with a constant. When working on this I noticed that also before in rtl_set_rx_max_size() a value of 0x4000 is set, what is not in line with the chip spec. According to the spec only bits 0..13 are used

[PATCH net-next 15/19] r8169: don't display tp->mmio_addr address

For security reasons since commit ad67b74d2469 "printk: hash addresses printed with %p" %p doesn't display the full address any longer. We could switch to %px, but I think the pointer address doesn't provide a real benefit, so remove printing the hashed address. Signed-off-by: Heiner Kallweit

Re: [PATCH net-next 0/5] virtio-net: Add SCTP checksum offload support

On 04/02/2018 10:47 AM, Marcelo Ricardo Leitner wrote: > On Mon, Apr 02, 2018 at 09:40:01AM -0400, Vladislav Yasevich wrote: >> Now that we have SCTP offload capabilities in the kernel, we can add >> them to virtio as well. First step is SCTP checksum. > > Thanks. > >> As for GSO, the way sctp

[PATCH bpf-next v4 10/10] bpf: btf: Add BTF tests

This patch tests the BTF loading, map_create with BTF and the changes in libbpf. -r: Raw tests that test raw crafted BTF data -f: Test LLVM compiled bpf prog with BTF data -g: Test BPF_OBJ_GET_INFO_BY_FD for btf_fd -p: Test pretty print The tools/testing/selftests/bpf/Makefile will probe for BTF

[PATCH bpf-next v4 05/10] bpf: btf: Add BPF_BTF_LOAD command

This patch adds a BPF_BTF_LOAD command which 1) loads and verifies the BTF (implemented in earlier patches) 2) returns a BTF fd to userspace. In the next patch, the BTF fd can be specified during BPF_MAP_CREATE. It currently limits to CAP_SYS_ADMIN. Signed-off-by: Martin KaFai Lau

[PATCH bpf-next v4 06/10] bpf: btf: Add BPF_OBJ_GET_INFO_BY_FD support to BTF fd

This patch adds BPF_OBJ_GET_INFO_BY_FD support to BTF fd. The original BTF data, which was used to create the BTF fd during the earlier BPF_BTF_LOAD call, will be returned. The userspace is expected to allocate buffer to info.info and the buffer size is set to info.info_len before calling

[PATCH bpf-next v4 07/10] bpf: btf: Add pretty print support to the basic arraymap

This patch adds pretty print support to the basic arraymap. Support for other bpf maps can be added later. This patch adds new attrs to the BPF_MAP_CREATE command to allow specifying the btf_fd, btf_key_id and btf_value_id. The BPF_MAP_CREATE can then associate the btf to the map if the creating

Re: linux-next on x60: network manager often complains "network is disabled" after resume

Hi! On Mon 2018-03-26 10:33:55, Dan Williams wrote: > On Sun, 2018-03-25 at 08:19 +0200, Pavel Machek wrote: > > > > > Ok, what does 'nmcli dev' and 'nmcli radio' show? > > > > > > > > Broken state. > > > > > > > > pavel@amd:~$ nmcli dev > > > > DEVICE TYPE STATECONNECTION > > > >

[PATCH net-next] hv_netvsc: propogate Hyper-V friendly name into interface alias

This patch implement the 'Device Naming' feature of the Hyper-V network device API. In Hyper-V on the host through the GUI or PowerShell it is possible to enable the device naming feature which causes the host to make available to the guest the name of the device. This shows up in the RNDIS

[net-next PATCH v4 09/13] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes

The phy used for K2G allows for internal delays to be added optionally to the clock circuitry based on board desing. To add this support, enhance the driver to use of_get_phy_mode() to read the phy-mode from the phy device and pass the same to phy through of_phy_connect(). Signed-off-by: Murali

[net-next PATCH v4 06/13] net: netcp: ethss: use rgmii link status for 2u cpsw hardware

Introduce rgmii link status to handle link state events for 2u cpsw hardware on K2G. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git

[net-next PATCH v4 12/13] net: netcp: add api to support set rx mode in netcp modules

From: WingMan Kwok This patch adds an API to support setting rx mode in netcp modules. If a netcp module needs to be notified when upper layer transitions from one rx mode to another and react accordingly, such a module will implement the new API set_rx_mode added in this patch.

[net-next PATCH v4 04/13] net: netcp: ethss: make sgmii configuration conditional

As a preparatory patch to add support for 2u cpsw hardware found on K2G SoC, make sgmii configuration conditional. This is required since 2u uses RGMII interface instead of SGMII and to allow for driver re-use. Signed-off-by: Murali Karicheri ---

[net-next PATCH v4 10/13] Revert "net: netcp: remove dead code from the driver"

As the probe sequence is not guaranteed contrary to the assumption of the commit 2d8e276a9030, same has to be reverted. commit 2d8e276a9030 ("net: netcp: remove dead code from the driver") Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_core.c | 9

[PATCH net-next 16/19] r8169: improve rtl8169_get_mac_version

Certain entries in array mac_info[] are redundant, so remove them: 0x7cf, 0x2c20 (VER 33): matched by entry 0x7c8, 0x2c00 0x7cf, 0x2830 (VER 26): matched by entry 0x7c8, 0x2800 0x7cf, 0x3cb0 (VER 24): matched by entry 0x7c8, 0x3c80 0x7cf, 0x3c40 (VER 22): matched by

[PATCH net-next 19/19] r8169: remove jumbo_tx_csum from chip config struct

According to the chip configuration entries only RTL8169 (ver <= 06) supports tx checksumming for jumbo packets. By the way: constant JUMBO_1K is a little misleading because it refers to the standard packet size and not to a jumbo packet size. By implementing this rule we can get rid of

[PATCH net-next 10/19] r8169: remove rtl8169_map_to_asic

This function is very simple and used only once, so we can inline the two statements. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c

[PATCH net-next 18/19] r8169: improve pci region handling

The region to be used is always the first of type IORESOURCE_MEM. We can implement this rule directly w/o having to specify which region is the first one per configuration entry. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 16 +---

[PATCH net-next 07/19] r8169: improve rtl8169_init_ring

This function doesn't use the net_device, therefore change the parameter to type struct rtl8169_private * to simplify the code. In addition we don't need the calculations in the memset statements, we can use the size of the arrays directly. Signed-off-by: Heiner Kallweit

[PATCH net-next 06/19] r8169: simplify rtl8169_alloc_rx_data

dev->dev.parent has the same value as tp_to_dev(tp) (set by SET_NETDEV_DEV() in rtl_init_one()) and we know it can't be NULL. This allows us to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 3 +-- 1 file changed, 1

[PATCH net-next 13/19] r8169: change interrupt handler argument type

Code can be a little simplified by switching the interrupt handler argument type to struct rtl8169_private *. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH net-next 17/19] r8169: drop member txd_version from struct rtl8169_private

txd_version is used in rtl_init_one() only, so we can drop member txd_version from struct rtl8169_private. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

[PATCH net-next 01/19] r8169: remove unused member features from struct

Member features of struct rtl8169_private isn't used any longer since commit 6c6aa15fdea5 "r8169: improve interrupt handling", so remove it. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH net-next 08/19] r8169: remove unneeded check in rtl8169_rx_fill

rtl8169_rx_fill() is called only once and directly before the call array tp->Rx_databuff[] is filled with zero's. Therefore we don't need this check. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH net-next 14/19] r8169: drop member opts1_mask from struct rtl8169_private

We can get rid of member opts1_mask and in addition save a few cpu cycles in the hot path of rtl_rx(). Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git

[PATCH net-next 02/19] r8169: remove member align from struct rtl_cfg_info

Since commit 6f0333b8fde4 "r8169: use 50% less ram for RX ring" member align isn't used any longer, so remove it. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 4 1 file changed, 4 deletions(-) diff --git

Re: [PATCH v2 net-next] net: introduce a new tracepoint for tcp_rcv_space_adjust

On Wed, Apr 18, 2018 at 1:27 AM, Eric Dumazet wrote: > > > On 04/17/2018 09:36 AM, Yafang Shao wrote: >> tcp_rcv_space_adjust is called every time data is copied to user space, >> introducing a tcp tracepoint for which could show us when the packet is >> copied to user. >>

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

Hi Andrew, thanks, that's what I was looking for. The next version will have all but one patch correctly attributed to Michael Karcher. Cheers, Michael On Wed, Apr 18, 2018 at 9:13 AM, Andrew Lunn wrote: > On Wed, Apr 18, 2018 at 08:32:25AM +1200, Michael Schmitz wrote: >>

Re:Re: [PATCH net] net: Fix one possible memleak in ip_setup_cork

At 2018-04-17 05:18:25, "Eric Dumazet" wrote: > > >On 04/16/2018 09:58 AM, David Miller wrote: >> From: gfree.w...@vip.163.com >> Date: Mon, 16 Apr 2018 10:16:45 +0800 >> >>> From: Gao Feng >>> >>> It would allocate memory in this function when

[Regression] net/phy/micrel.c v4.9.94

Hello, I like to get your heads up at a regression introduced in 4.9.94 commitment lead to a kernel ops and make the network unusable on my MX6DL customized board. Race condition resume is called on startup and the phy not yet initialized. [7.313366] Unable to handle kernel NULL pointer

Re: [PATCH v3 net,stable] tun: fix vlan packet truncation

On 2018年04月18日 04:46, Bjørn Mork wrote: Bogus trimming in tun_net_xmit() causes truncated vlan packets. skb->len is correct whether or not skb_vlan_tag_present() is true. There is no more reason to adjust the skb length on xmit in this driver than any other driver. tun_put_user() adds 4 bytes

Re: [PATCH net-next 0/5] virtio-net: Add SCTP checksum offload support

On Tue, Apr 17, 2018 at 04:35:18PM -0400, Vlad Yasevich wrote: > On 04/02/2018 10:47 AM, Marcelo Ricardo Leitner wrote: > > On Mon, Apr 02, 2018 at 09:40:01AM -0400, Vladislav Yasevich wrote: > >> Now that we have SCTP offload capabilities in the kernel, we can add > >> them to virtio as well.

[PATCH 3/3] ath10k: Support ethtool gstats2 API.

From: Ben Greear Skip a firmware stats update when calling code indicates the stats refresh is not needed. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/debug.c | 18 +++--- drivers/net/wireless/ath/ath10k/debug.h |

[PATCH] ethtool: Support ETHTOOL_GSTATS2 API.

From: Ben Greear This allows users to specify flags to the get-stats API, potentially saving expensive stats queries when they are not desired. Signed-off-by: Ben Greear --- ethtool-copy.h | 9 + ethtool.c | 25

[PATCH 2/3] mac80211: Add support for ethtool gstats2 API.

From: Ben Greear This enables users to request fewer stats to be refreshed in cases where firmware does not need to be probed. Signed-off-by: Ben Greear --- include/net/mac80211.h| 6 ++ net/mac80211/driver-ops.h | 9 +++--

[PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

From: Ben Greear This is similar to ETHTOOL_GSTATS, but it allows you to specify flags. These flags can be used by the driver to decrease the amount of stats refreshed. In particular, this helps with ath10k since getting the firmware stats can be slow. Signed-off-by:

Re: [PATCH bpf-next 09/10] [bpf]: make tun compatible w/ bpf_xdp_adjust_tail

On 2018年04月17日 14:51, Nikita V. Shirokov wrote: w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as well (only "decrease" of pointer's location is going to be supported). changing of this pointer will change packet's size. for tun driver we need to adjust XDP_PASS handling

Re: [PATCHv2 net-next] vxlan: add ttl inherit support

On Tue, Apr 17, 2018 at 03:16:27PM -0400, David Miller wrote: > From: Hangbin Liu > Date: Tue, 17 Apr 2018 20:52:54 +0800 > > > Like tos inherit, ttl inherit should also means inherit the inner protocol's > > ttl values, which actually not implemented in vxlan yet. > > > >

Re: [PATCH bpf-next 10/10] [bpf]: make virtio compatible w/ bpf_xdp_adjust_tail

On 2018年04月17日 14:51, Nikita V. Shirokov wrote: w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as well (only "decrease" of pointer's location is going to be supported). changing of this pointer will change packet's size. for virtio driver we need to adjust XDP_PASS

Re: [PATCH RFC net-next 00/11] udp gso

On 4/17/2018 2:07 PM, Willem de Bruijn wrote: On Tue, Apr 17, 2018 at 4:48 PM, Sowmini Varadhan wrote: On (04/17/18 16:23), Willem de Bruijn wrote: Assuming IPv4 with an MTU of 1500 and the maximum segment size of 1472, the receiver will see three datagrams with

Re: [PATCH] PCI: Add PCIe to pcie_print_link_status() messages

On Fri, 13 Apr 2018 11:16:38 -0700, Jakub Kicinski wrote: > Currently the pcie_print_link_status() will print PCIe bandwidth > and link width information but does not mention it is pertaining > to the PCIe. Since this and related functions are used exclusively > by networking drivers today users

Re: [PATCH net-next 3/5] ipv4: support sport, dport and ip protocol in RTM_GETROUTE

On Tue, Apr 17, 2018 at 1:10 AM, Ido Schimmel wrote: > On Mon, Apr 16, 2018 at 01:41:36PM -0700, Roopa Prabhu wrote: >> @@ -2757,6 +2796,12 @@ static int inet_rtm_getroute(struct sk_buff *in_skb, >> struct nlmsghdr *nlh, >> fl4.flowi4_oif = tb[RTA_OIF] ?

[PATCH bpf-next] tools: bpftool: make it easier to feed hex bytes to bpftool

From: Quentin Monnet bpftool uses hexadecimal values when it dumps map contents: # bpftool map dump id 1337 key: ff 13 37 ff value: a1 b2 c3 d4 ff ff ff ff Found 1 element In order to lookup or update values with bpftool, the natural reflex is then to

Fw: [Bug 199429] New: smc_shutdown(net/smc/af_smc.c) has a UAF causing null pointer vulnerability.

This may already be fixed. Begin forwarded message: Date: Wed, 18 Apr 2018 01:52:59 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 199429] New: smc_shutdown(net/smc/af_smc.c) has a UAF causing null pointer vulnerability.

Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+

On 01/24/2018 03:59 PM, Ben Greear wrote: On 06/20/2017 08:03 PM, David Ahern wrote: On 6/20/17 5:41 PM, Ben Greear wrote: On 06/20/2017 11:05 AM, Michal Kubecek wrote: On Tue, Jun 20, 2017 at 07:12:27AM -0700, Ben Greear wrote: On 06/14/2017 03:25 PM, David Ahern wrote: On 6/14/17 4:23 PM,

[PATCH net] net: qualcomm: rmnet: Fix warning seen with fill_info

When the last rmnet device attached to a real device is removed, the real device is unregistered from rmnet. As a result, the real device lookup fails resulting in a warning when the fill_info handler is called as part of the rmnet device unregistration. Fix this by returning the rmnet flags as 0

Re: [PATCH] samples/bpf: correct comment in sock_example.c

On Tue, Apr 17, 2018 at 10:25:20AM +0800, Wang Sheng-Hui wrote: > The program run against loopback interace "lo", not "eth0". > Correct the comment. > > Signed-off-by: Wang Sheng-Hui Acked-by: Alexei Starovoitov for future patches please use the following

Re: [RFC PATCH v3 bpf-next 2/5] bpf/verifier: rewrite subprog boundary detection

On Fri, Apr 06, 2018 at 06:13:59PM +0100, Edward Cree wrote: > By storing a subprogno in each insn's aux data, we avoid the need to keep > the list of subprog starts sorted or bsearch() it in find_subprog(). > Also, get rid of the weird one-based indexing of subprog numbers. > > Signed-off-by:

Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

I ran this with a few folks offline and gathered some good feedbacks that I'd like to share thus revive the discussion. First of all, as illustrated in the reply below, cloud service providers require transparent live migration. Specifically, the main target of our case is to support SR-IOV live

[PATCH v2] net: change the comment of dev_mc_init

The comment of dev_mc_init() is wrong. which use dev_mc_flush instead of dev_mc_init. Signed-off-by: Lianwen Sun --- net/core/dev_addr_lists.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c

[PATCH net-next v2 07/21] net/ipv6: Save route type in rt6_info

The RTN_ type for IPv6 FIB entries is currently embedded in rt6i_flags and dst.error. Since dst is going to be removed, it can no longer be relied on for FIB dumps so save the route type as fib6_type. fc_type is set in current users based on the algorithm in rt6_fill_node: - rt6i_flags contains

[PATCH net-next v2 10/21] net/ipv6: move metrics from dst to rt6_info

Similar to IPv4, add fib metrics to the fib struct, which at the moment is rt6_info. Will be moved to fib6_info in a later patch. Copy metrics into dst by reference using refcount. To make the transition: - add dst_metrics to rt6_info. Default to dst_default_metrics if no metrics are passed

[PATCH net-next v2 11/21] net/ipv6: move expires into rt6_info

Add expires to rt6_info for FIB entries, and add fib6 helpers to manage it. Data path use of dst.expires remains. The transition is fairly straightforward: when working with fib entries, rt->dst.expires is just rt->expires, rt6_clean_expires is replaced with fib6_clean_expires, rt6_set_expires

[PATCH net-next v2 00/21] net/ipv6: Separate data structures for FIB and data path

IPv6 uses the same data struct for both control plane (FIB entries) and data path (dst entries). This struct has elements needed for both paths adding memory overhead and complexity (taking a dst hold in most places but an additional reference on rt6i_ref in a few). Furthermore, because of the

[PATCH net-next v2 01/21] net: Move fib_convert_metrics to metrics file

Move logic of fib_convert_metrics into ip_metrics_convert. This allows the code that converts netlink attributes into metrics struct to be re-used in a later patch by IPv6. This is mostly a code move with the following changes to variable names: - fi->fib_net becomes net - fc_mx and fc_mx_len

[PATCH net-next v2 05/21] net/ipv6: Pass net namespace to route functions

Pass network namespace reference into route add, delete and get functions. Signed-off-by: David Ahern --- include/net/ip6_route.h | 12 ++- net/ipv6/addrconf.c | 33 -- net/ipv6/anycast.c | 10 + net/ipv6/ndisc.c|

[PATCH net-next v2 15/21] net/ipv6: Create a neigh_lookup for FIB entries

The router discovery code has a FIB entry and wants to validate the gateway has a neighbor entry. Refactor the existing dst_neigh_lookup for IPv6 and create a new function that takes the gateway and device and returns a neighbor entry. Use the new function in ndisc_router_discovery to validate the

[PATCH net-next v2 12/21] net/ipv6: Add fib6_null_entry

ip6_null_entry will stay a dst based return for lookups that fail to match an entry. Add a new fib6_null_entry which constitutes the root node and leafs for fibs. Replace existing references to ip6_null_entry with the new fib6_null_entry when dealing with FIBs. Signed-off-by: David Ahern

[PATCH net-next v2 09/21] net/ipv6: Defer initialization of dst to data path

Defer setting dst input, output and error until fib entry is copied. The reject path from ip6_route_info_create is moved to a new function ip6_rt_init_dst_reject with a helper doing the conversion from fib6_type to dst error. The remainder of the new ip6_rt_init_dst is an amalgamtion of dst code

[PATCH net-next v2 04/21] net/ipv6: Pass net to fib6_update_sernum

Pass net namespace to fib6_update_sernum. It can not be marked const as fib6_new_sernum will change ipv6.fib6_sernum. Signed-off-by: David Ahern --- include/net/ip6_fib.h | 2 +- net/ipv6/ip6_fib.c| 3 +-- net/ipv6/route.c | 10 +- 3 files changed, 7

[PATCH net-next v2 03/21] vrf: Move fib6_table into net_vrf

A later patch removes rt6i_table from rt6_info. Save the ipv6 table for a VRF in net_vrf. fib tables can not be deleted so no reference counting or locking is required. Signed-off-by: David Ahern --- drivers/net/vrf.c | 25 ++--- 1 file changed, 6

[PATCH net-next v2 06/21] net/ipv6: Move support functions up in route.c

Code move only. Signed-off-by: David Ahern --- net/ipv6/route.c | 119 +++ 1 file changed, 59 insertions(+), 60 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 045811a3da76..0daf4c9c9f2b 100644 ---

Re: [PATCH bpf-next 08/10] [bpf]: make netronome nfp compatible w/ bpf_xdp_adjust_tail

On Tue, 17 Apr 2018 16:08:29 -0700, Alexei Starovoitov wrote: > On Mon, Apr 16, 2018 at 11:51:29PM -0700, Nikita V. Shirokov wrote: > > w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as > > well (only "decrease" of pointer's location is going to be supported). > > changing

Re: [PATCH v2 bpf-next 0/3] Add missing types to bpftool, libbpf

On Tue, Apr 17, 2018 at 10:28:43AM -0700, Andrey Ignatov wrote: > v1->v2: > - add new types to bpftool-cgroup man page; > - add new types to bash completion for bpftool; > - don't add types that should not be in bpftool cgroup. > > Add support for various BPF prog types and attach types that have

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

On Wed, Apr 18, 2018 at 12:53:21PM +1200, Michael Schmitz wrote: > I think this is a false positive - we're encouraged to provide the > full parameter list for functions, so the sreuct sk_buff* can't be > avoided. Hi Michael How is being included? You probably want to build using the .config

Re: [RFC v2] virtio: support packed ring

On Tue, Apr 17, 2018 at 06:54:51PM +0300, Michael S. Tsirkin wrote: > On Tue, Apr 17, 2018 at 10:56:26PM +0800, Tiwei Bie wrote: > > On Tue, Apr 17, 2018 at 05:04:59PM +0300, Michael S. Tsirkin wrote: > > > On Tue, Apr 17, 2018 at 08:47:16PM +0800, Tiwei Bie wrote: > > > > On Tue, Apr 17, 2018 at

Re: [patch net-next RFC 00/12] devlink: introduce port flavours and common phys_port_name generation

On Tue, 17 Apr 2018 16:23:48 +0300, Or Gerlitz wrote: > On Thu, Mar 22, 2018 at 1:55 PM, Jiri Pirko wrote: > > From: Jiri Pirko > > > > This patchset resolves 2 issues we have right now: > > 1) There are many netdevices / ports in the system, for port, pf, vf

Re: fix for bnx2x panic during ethtool reporting

+netdev, Ariel, On 04/17/2018 10:21 AM, Sebastian Kuzminsky wrote: > "ethtool -i" on a bnx2x interface causes kernel panic when the > firmware version is longer than expected. The attached patch fixes > the problem by simplifying the string handling in bnx2x_fill_fw_str(). > It applies cleanly

Re: [PATCH net-next] net: introduce a new tracepoint for tcp_rcv_space_adjust

On Mon, Apr 16, 2018 at 08:43:31AM -0700, Eric Dumazet wrote: > > > On 04/16/2018 08:33 AM, Yafang Shao wrote: > > tcp_rcv_space_adjust is called every time data is copied to user space, > > introducing a tcp tracepoint for which could show us when the packet is > > copied to user. > > This

Re: One question about __tcp_select_window()

Thanks for your reply, Eric. Actually, this is a query about the code while I am reading code. >From my instinct and the comment, I think we should choose the bigger one but maybe I miss something(like your said, autotuning) Anyway, I will read more codes and do more tests. Thanks. On Tue, Apr

[PATCH net-next v2 2/2] openvswitch: Support conntrack zone limit

Currently, nf_conntrack_max is used to limit the maximum number of conntrack entries in the conntrack table for every network namespace. For the VMs and containers that reside in the same namespace, they share the same conntrack table, and the total # of conntrack entries for all the VMs and

Re: [PATCH net-next 2/2] openvswitch: Support conntrack zone limit

> s/to commit/from committing/ > s/entry/entries/ Thanks, will fix that in both patches in v2. > I think this is a great idea but I suggest porting to the iproute2 package > so everyone can use it. Then git rid of the OVS specific prefixes. > Presuming of course that the conntrack connection >

[PATCH net-next v2 0/2] openvswitch: Support conntrack zone limit

Currently, nf_conntrack_max is used to limit the maximum number of conntrack entries in the conntrack table for every network namespace. For the VMs and containers that reside in the same namespace, they share the same conntrack table, and the total # of conntrack entries for all the VMs and

[PATCH net-next v2 1/2] openvswitch: Add conntrack limit netlink definition

Define netlink messages and attributes to support user kernel communication that uses the conntrack limit feature. Signed-off-by: Yi-Hung Wei --- include/uapi/linux/openvswitch.h | 62 1 file changed, 62 insertions(+) diff --git

[PATCH net-next v2 20/21] net/ipv6: Flip FIB entries to fib6_info

Convert all code paths referencing a FIB entry from rt6_info to fib6_info. Signed-off-by: David Ahern --- .../net/ethernet/mellanox/mlxsw/spectrum_router.c | 64 ++--- include/net/if_inet6.h | 4 +- include/net/ip6_fib.h

[PATCH net-next v2 08/21] net/ipv6: Move nexthop data to fib6_nh

Introduce fib6_nh structure and move nexthop related data from rt6_info and rt6_info.dst to fib6_nh. References to dev, gateway or lwtstate from a FIB lookup perspective are converted to use fib6_nh; datapath references to dst version are left as is. Signed-off-by: David Ahern

[PATCH net-next v2 19/21] net/ipv6: separate handling of FIB entries from dst based routes

Last step before flipping the data type for FIB entries: - use fib6_info_alloc to create FIB entries in ip6_route_info_create and addrconf_dst_alloc - use fib6_info_release in place of dst_release, ip6_rt_put and rt6_release - remove the dst_hold before calling __ip6_ins_rt or ip6_del_rt -

[PATCH net-next v2 17/21] net/ipv6: Cleanup exception and cache route handling

IPv6 FIB will only contain FIB entries with exception routes added to the FIB entry. Once this transformation is complete, FIB lookups will return a fib6_info with the lookup functions still returning a dst based rt6_info. The current code uses rt6_info for both paths and overloads the rt6_info

[PATCH net-next v2 14/21] net/ipv6: Move dst flags to booleans in fib entries

Continuing to wean FIB paths off of dst_entry, use a bool to hold requests for certain dst settings. Add a helper to convert the flags to DST flags when a FIB entry is converted to a dst_entry. Signed-off-by: David Ahern --- include/net/ip6_fib.h | 5 -

[PATCH net-next v2 16/21] net/ipv6: Add gfp_flags to route add functions

Most FIB entries can be added using memory allocated with GFP_KERNEL. Add gfp_flags to ip6_route_add and addrconf_dst_alloc. Code paths that can be reached from the packet path (e.g., ndisc and autoconfig) or atomic notifiers use GFP_ATOMIC; paths from user context (adding addresses and routes)

[PATCH net-next v2 18/21] net/ipv6: introduce fib6_info struct and helpers

Add fib6_info struct and alloc, destroy, hold and release helpers. Signed-off-by: David Ahern --- include/net/ip6_fib.h | 55 ++ net/ipv6/ip6_fib.c| 60 +++ 2 files changed, 115

[PATCH net-next v2 21/21] net/ipv6: Remove unused code and variables for rt6_info

Drop unneeded elements from rt6_info struct and rearrange layout to something more relevant for the data path. Signed-off-by: David Ahern --- include/net/ip6_fib.h | 60 +++-- net/ipv6/ip6_fib.c | 22 --

[PATCH net-next v2 02/21] net: Handle null dst in rtnl_put_cacheinfo

Need to keep expires time for IPv6 routes in a dump of FIB entries. Update rtnl_put_cacheinfo to allow dst to be NULL in which case rta_cacheinfo will only contain non-dst data. Signed-off-by: David Ahern --- net/core/rtnetlink.c | 8 +--- 1 file changed, 5 insertions(+),

[PATCH net-next v2 13/21] net/ipv6: Add rt6_info create function for ip6_pol_route_lookup

ip6_pol_route_lookup is the lookup function for ip6_route_lookup and rt6_lookup. At the moment it returns either a reference to a FIB entry or a cached exception. To move FIB entries to a separate struct, this lookup function needs to convert FIB entries to an rt6_info that is returned to the

Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+

On 4/17/18 5:29 PM, Ben Greear wrote: > > FYI, problem still happens in 4.16.  I'm going to re-enable my hack below > for this kernel as well...I had hopes it might be fixed... Interesting. I was hoping the same. > > BUG: unable to handle kernel NULL pointer dereference at 8 > IP:

Re: [PATCH RFC net-next 06/11] udp: add gso support to virtual devices

On Tue, Apr 17, 2018 at 1:00 PM, Willem de Bruijn wrote: > From: Willem de Bruijn > > Virtual devices such as tunnels and bonding can handle large packets. > Only segment packets when reaching a physical or loopback device. > > Signed-off-by:

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

rhaps something to improve: > > [auto build test WARNING on v4.16] > [cannot apply to net-next/master net/master v4.17-rc1 next-20180417] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0d

<    1   2   3   4   5   >