Re: [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac

2017-08-24 Thread Corentin Labbe
On Wed, Aug 23, 2017 at 09:31:53AM -0700, Florian Fainelli wrote: > On 08/23/2017 12:49 AM, Maxime Ripard wrote: > > Hi Florian, > > > > On Tue, Aug 22, 2017 at 11:35:01AM -0700, Florian Fainelli wrote: > > So I think what you are saying is either impossible or engineering-wise > > a very

[PATCH] net: stmmac: dwmac-sun8i: Use reset exclusive

2017-08-25 Thread Corentin Labbe
The current dwmac_sun8i module cannot be rmmod/modprobe due to that the reset controller was not released when removed. This patch remove ambiguity, by using of_reset_control_get_exclusive and add the missing reset_control_put(). Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.

[PATCH] net: stmmac: Handle possible fixed-link with need_mdio_ids

2017-08-25 Thread Corentin Labbe
In case of fixed link, there are no mdio node. This patch add a test for fixed-link for bypassing MDIO node register. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] net: stmmac: dwmac-sun8i: Use reset exclusive

2017-08-25 Thread Corentin Labbe
On Fri, Aug 25, 2017 at 04:48:32PM +0200, Maxime Ripard wrote: > On Fri, Aug 25, 2017 at 04:38:05PM +0200, Corentin Labbe wrote: > > The current dwmac_sun8i module cannot be rmmod/modprobe due to that > > the reset controller was not released when removed. > > > >

Re: [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac

2017-08-19 Thread Corentin Labbe
On Sat, Aug 19, 2017 at 01:05:21AM +0800, Chen-Yu Tsai wrote: > On Fri, Aug 18, 2017 at 8:21 PM, Corentin Labbe > <clabbe.montj...@gmail.com> wrote: > > In case of a MDIO switch, the registered MDIO node should be > > the parent of the PHY. Otherwise of_phy_connect will

Re: [PATCH v3 4/4] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-08-19 Thread Corentin Labbe
On Sat, Aug 19, 2017 at 12:57:07AM +0800, Chen-Yu Tsai wrote: > On Fri, Aug 18, 2017 at 8:21 PM, Corentin Labbe > <clabbe.montj...@gmail.com> wrote: > > This patch add documentation about the MDIO switch used on sun8i-h3-emac > > for integrated PHY. > > >

Re: [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac

2017-08-20 Thread Corentin Labbe
On Sat, Aug 19, 2017 at 10:38:36PM +0200, Andrew Lunn wrote: > On Sat, Aug 19, 2017 at 08:50:25PM +0200, Corentin Labbe wrote: > > On Sat, Aug 19, 2017 at 01:05:21AM +0800, Chen-Yu Tsai wrote: > > > On Fri, Aug 18, 2017 at 8:21 PM, Corentin Labbe > > > <cl

Re: [PATCH v4 4/5] net: stmmac: dwmac-sun8i: choose internal PHY via phy-is-integrated

2017-08-29 Thread Corentin Labbe
On Sat, Aug 26, 2017 at 11:20:51PM +0200, Andrew Lunn wrote: > Hi Corentin > > I think we have now all agreed this is an mdio-mux, plus it is also an > MII mux. We should represent that in device tree. This patchset does > this. However, as it is now, the mux structure in DT is ignored. All > it

Re: [PATCH 0/5] net: mdio-mux: Misc fix

2017-09-01 Thread Corentin Labbe
On Wed, Aug 30, 2017 at 09:01:19PM +0200, Andrew Lunn wrote: > On Wed, Aug 30, 2017 at 07:46:46PM +0200, Corentin Labbe wrote: > > Hello > > > > This patch series fix minor problems found when working on the > > dwmac-sun8i syscon mdio-mux. > > Hi Corentin

[PATCH v2 2/5] net: mdio-mux: Remove unnecessary 'out of memory' message

2017-09-01 Thread Corentin Labbe
This patch fix checkpatch warning about unnecessary 'out of memory' message. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Reviewed-by: Andrew Lunn <and...@lunn.ch> --- drivers/net/phy/mdio-mux.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/phy/

[PATCH v2 5/5] net: mdio-mux: fix unbalanced put_device

2017-09-01 Thread Corentin Labbe
her branch of "if (mux_bus)". Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/phy/mdio-mux.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/mdio-mux.c b/drivers/net/phy/mdio-mux.c index 282828551bdd..6f75e9f27fed 100644 --- a/

[PATCH v2 3/5] net: mdio-mux: printing driver version is useless

2017-09-01 Thread Corentin Labbe
Remove the driver version information because this information is not useful in an upstream kernel driver. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/phy/mdio-mux.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/phy/mdio-mux.c b/drivers/n

[PATCH v2 1/5] net: mdio-mux: Fix NULL Comparison style

2017-09-01 Thread Corentin Labbe
This patch fix checkpatch warning about NULL Comparison style. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Reviewed-by: Andrew Lunn <and...@lunn.ch> --- drivers/net/phy/mdio-mux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/

[PATCH v2 0/5] net: mdio-mux: Misc fix

2017-09-01 Thread Corentin Labbe
Hello This patch series fix minor problems found when working on the dwmac-sun8i syscon mdio-mux. Regards Changes since v1: - Removed obsolete comment about of_mdio_find_bus/put_device - removed more DRV_VERSION Corentin Labbe (5): net: mdio-mux: Fix NULL Comparison style net: mdio-mux

[PATCH v2 4/5] net: mdio-mux-mmioreg: Can handle 8/16/32 bits registers

2017-09-01 Thread Corentin Labbe
This patch fix an old information that mdio-mux-mmioreg can only handle 8bit registers. This is not true anymore. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Reviewed-by: Andrew Lunn <and...@lunn.ch> --- drivers/net/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+)

[PATCH 0/1] net: mdio-mux: add mdio_mux parameter to mdio_mux_init()

2017-09-04 Thread Corentin Labbe
acceptable. Regards Corentin Labbe (1): net: mdio-mux: add mdio_mux parameter to mdio_mux_init() drivers/net/phy/mdio-mux-bcm-iproc.c | 2 +- drivers/net/phy/mdio-mux-gpio.c | 2 +- drivers/net/phy/mdio-mux-mmioreg.c | 3 ++- drivers/net/phy/mdio-mux.c | 7 --- include/linux/

[PATCH 1/1] net: mdio-mux: add mdio_mux parameter to mdio_mux_init()

2017-09-04 Thread Corentin Labbe
a direct owning device. For example a mdio-mux which is a subnode of a real device. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/phy/mdio-mux-bcm-iproc.c | 2 +- drivers/net/phy/mdio-mux-gpio.c | 2 +- drivers/net/phy/mdio-mux-mmioreg.c | 3 ++- drivers/net/ph

Re: [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-10-04 Thread Corentin Labbe
On Thu, Sep 28, 2017 at 09:37:08AM +0200, Corentin Labbe wrote: > On Wed, Sep 27, 2017 at 04:02:10PM +0200, Andrew Lunn wrote: > > Hi Corentin > > > > > +Required properties for the mdio-mux node: > > > + - compatible = "mdio-mux" > > &g

[PATCH v6 11/11] of: mdio: Prevent of_mdiobus_register from scanning mdio-mux nodes

2017-09-27 Thread Corentin Labbe
] mdio_bus stmmac-0: scan phy mdio-mux at address 1 [...] [ 18.176420] mdio_bus stmmac-0: scan phy mdio-mux at address 30 [ 18.176452] mdio_bus stmmac-0: scan phy mdio-mux at address 31 Since mdio-mux nodes are not PHY, this patch a way to to not scan them. Signed-off-by: Corentin Labbe <clabbe.mo

[PATCH v6 10/11] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

2017-09-27 Thread Corentin Labbe
The Allwinner H3 SoC have two distinct MDIO bus, only one could be active at the same time. The selection of the active MDIO bus are done via some bits in the EMAC register of the system controller. This patch implement this MDIO switch via a custom MDIO-mux. Signed-off-by: Corentin Labbe

[PATCH v6 09/11] net: stmmac: dwmac-sun8i: choose internal PHY via phy-is-integrated

2017-09-27 Thread Corentin Labbe
property. Since the internal_phy variable does not need anymore to contain the xMII mode used by the internal PHY, it is still used for knowing the presence of an internal PHY, so it is modified to a boolean soc_has_internal_phy. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>

[PATCH v6 07/11] arm64: dts: allwinner: add snps,dwmac-mdio compatible to emac/mdio

2017-09-27 Thread Corentin Labbe
stmmac bindings docs said that its mdio node must have compatible = "snps,dwmac-mdio"; Since dwmac-sun8i does not have any good reasons to not doing it, all their MDIO node must have it. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm64/boot/dts/allwinner

[PATCH v6 06/11] ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac

2017-09-27 Thread Corentin Labbe
Since dwmac-sun8i could use either an integrated PHY or an external PHY (which could be at same MDIO address), we need to represent this selection by a MDIO switch. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sunxi-h3-h5.dts

[PATCH v6 08/11] net: stmmac: snps,dwmac-mdio MDIOs are automatically registered

2017-09-27 Thread Corentin Labbe
s not need to be in need_mdio_ids. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_

[PATCH v6 03/11] arm64: dts: allwinner: Restore EMAC changes

2017-09-27 Thread Corentin Labbe
This patch restore arm64 DT about dwmac-sun8i This reverts commit 87e1f5e8bb4b ("arm64: dts: allwinner: Revert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 16 .../boot/dts/

[PATCH v6 02/11] arm: dts: sunxi: Restore EMAC changes

2017-09-27 Thread Corentin Labbe
This patch restore arm DT about dwmac-sun8i This reverts commit fe45174b72ae ("arm: dts: sunxi: Revert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 9 arch/arm/boot/dts/sun8i-h3-bana

[PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-09-27 Thread Corentin Labbe
This patch add documentation about the MDIO switch used on sun8i-h3-emac for integrated PHY. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 138 +++-- 1 file changed, 126 insertions(+), 12 deletions(-)

[PATCH v6 04/11] net: stmmac: sun8i: Restore the compatibles

2017-09-27 Thread Corentin Labbe
This patch restore compatibles about dwmac-sun8i This reverts commit ad4540cc5aa3 ("net: stmmac: sun8i: Remove the compatibles") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 8 1 file changed, 8 ins

[PATCH v6 00/11] net: stmmac: dwmac-sun8i: Handle integrated PHY

2017-09-27 Thread Corentin Labbe
since v1: - Dropped phy-is-integrated documentation patch since another same patch was already merged - Moved phy-is-integrated from SoC dtsi to final board DT. Corentin Labbe (11): dt-bindings: net: Restore sun8i dwmac binding arm: dts: sunxi: Restore EMAC changes arm64: dts: allwinner:

[PATCH v6 01/11] dt-bindings: net: Restore sun8i dwmac binding

2017-09-27 Thread Corentin Labbe
This patch restore dt-bindings documentation about dwmac-sun8i This reverts commit 8aa33ec2f481 ("dt-bindings: net: Revert sun8i dwmac binding") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 84 ++

Re: [PATCH v6 06/11] ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac

2017-09-27 Thread Corentin Labbe
On Wed, Sep 27, 2017 at 12:16:22PM +0200, Maxime Ripard wrote: > On Wed, Sep 27, 2017 at 07:34:09AM +0000, Corentin Labbe wrote: > > Since dwmac-sun8i could use either an integrated PHY or an external PHY > > (which could be at same MDIO address), we need to represent this selectio

[PATCH v7 06/10] ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac

2017-10-18 Thread Corentin Labbe
Since dwmac-sun8i could use either an integrated PHY or an external PHY (which could be at same MDIO address), we need to represent this selection by a MDIO switch. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sunxi-h3-h5.dts

[PATCH v7 10/10] of: mdio: Prevent of_mdiobus_register from scanning mdio-mux nodes

2017-10-18 Thread Corentin Labbe
] mdio_bus stmmac-0: scan phy mdio-mux at address 1 [...] [ 18.176420] mdio_bus stmmac-0: scan phy mdio-mux at address 30 [ 18.176452] mdio_bus stmmac-0: scan phy mdio-mux at address 31 Since mdio-mux nodes are not PHY, this patch a way to to not scan them. Signed-off-by: Corentin Labbe <clabbe.mo

[PATCH v7 02/10] arm: dts: sunxi: Restore EMAC changes

2017-10-18 Thread Corentin Labbe
evert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 9 arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 19 + arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts | 19 +++

[PATCH v7 01/10] dt-bindings: net: Restore sun8i dwmac binding

2017-10-18 Thread Corentin Labbe
ot;dt-bindings: net: Revert sun8i dwmac binding") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 84 ++ 1 file changed, 84 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/dwmac

[PATCH v7 00/10] net: stmmac: dwmac-sun8i: Handle integrated PHY

2017-10-18 Thread Corentin Labbe
same patch was already merged - Moved phy-is-integrated from SoC dtsi to final board DT. Corentin Labbe (10): dt-bindings: net: Restore sun8i dwmac binding arm: dts: sunxi: Restore EMAC changes arm64: dts: allwinner: Restore EMAC changes net: stmmac: sun8i: Restore the compatibles dt-bind

[PATCH v7 03/10] arm64: dts: allwinner: Restore EMAC changes

2017-10-18 Thread Corentin Labbe
inner: Revert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 16 .../boot/dts/allwinner/sun50i-a64-pine64-plus.dts| 15 +++ arch/arm64/boot/dts/allwinner/sun50i-a64-

[PATCH v7 09/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

2017-10-18 Thread Corentin Labbe
The Allwinner H3 SoC have two distinct MDIO bus, only one could be active at the same time. The selection of the active MDIO bus are done via some bits in the EMAC register of the system controller. This patch implement this MDIO switch via a custom MDIO-mux. Signed-off-by: Corentin Labbe

[PATCH v7 08/10] net: stmmac: snps,dwmac-mdio MDIOs are automatically registered

2017-10-18 Thread Corentin Labbe
s not need to be in need_mdio_ids. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_

[PATCH v7 05/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-10-18 Thread Corentin Labbe
This patch add documentation about the MDIO switch used on sun8i-h3-emac for integrated PHY. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 139 +++-- 1 file changed, 127 insertions(+), 12 deletions(-)

[PATCH v7 07/10] arm64: dts: allwinner: add snps,dwmac-mdio compatible to emac/mdio

2017-10-18 Thread Corentin Labbe
stmmac bindings docs said that its mdio node must have compatible = "snps,dwmac-mdio"; Since dwmac-sun8i does not have any good reasons to not doing it, all their MDIO node must have it. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm64/boot/dts/allwinner

[PATCH v7 04/10] net: stmmac: sun8i: Restore the compatibles

2017-10-18 Thread Corentin Labbe
sun8i: Remove the compatibles") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmm

Re: [PATCH v7 02/10] arm: dts: sunxi: Restore EMAC changes

2017-10-18 Thread Corentin Labbe
On Wed, Oct 18, 2017 at 06:44:50PM +0200, Andrew Lunn wrote: > On Wed, Oct 18, 2017 at 01:44:50PM +0200, Corentin Labbe wrote: > > The original dwmac-sun8i DT bindings have some issue on how to handle > > integrated PHY and was reverted in last RC of 4.13. > > But now we have

[PATCH v8 10/10] net: stmmac: sun8i: Restore the compatibles

2017-10-23 Thread Corentin Labbe
sun8i: Remove the compatibles") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmm

[PATCH v8 04/10] arm: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac

2017-10-23 Thread Corentin Labbe
Since dwmac-sun8i could use either an integrated PHY or an external PHY (which could be at same MDIO address), we need to represent this selection by a MDIO switch. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sunxi-h3-h5.dts

[PATCH v8 01/10] dt-bindings: net: Restore sun8i dwmac binding

2017-10-23 Thread Corentin Labbe
ot;dt-bindings: net: Revert sun8i dwmac binding") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 84 ++ 1 file changed, 84 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/dwmac

[PATCH v8 03/10] arm: dts: sunxi: h3/h5: Restore EMAC changes

2017-10-23 Thread Corentin Labbe
evert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi index c1bd09dab3

[PATCH v8 00/10] net: stmmac: dwmac-sun8i: Handle integrated PHY

2017-10-23 Thread Corentin Labbe
distinction between integrated and external MDIO. - phy-is-integrated is not set in dtsi. Changes since v1: - Dropped phy-is-integrated documentation patch since another same patch was already merged - Moved phy-is-integrated from SoC dtsi to final board DT. Corentin Labbe (10): dt-bindings: ne

[PATCH v8 02/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-10-23 Thread Corentin Labbe
This patch add documentation about the MDIO switch used on sun8i-h3-emac for integrated PHY. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 139 +++-- 1 file changed, 127 insertions(+), 12 deletions(-)

[PATCH v8 05/10] arm: dts: sunxi: Restore EMAC changes (boards)

2017-10-23 Thread Corentin Labbe
: dts: sunxi: Revert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 9 + arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 19 +++ arch/arm/boot/dts/sun8i-h3-nanopi-m1-p

[PATCH v8 09/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

2017-10-23 Thread Corentin Labbe
The Allwinner H3 SoC have two distinct MDIO bus, only one could be active at the same time. The selection of the active MDIO bus are done via some bits in the EMAC register of the system controller. This patch implement this MDIO switch via a custom MDIO-mux. Signed-off-by: Corentin Labbe

[PATCH v8 07/10] arm64: dts: allwinner: add snps,dwmac-mdio compatible to emac/mdio

2017-10-23 Thread Corentin Labbe
stmmac bindings docs said that its mdio node must have compatible = "snps,dwmac-mdio"; Since dwmac-sun8i does not have any good reasons to not doing it, all their MDIO node must have it. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm64/boot/dts/allwinner

[PATCH v8 06/10] arm64: dts: allwinner: Restore EMAC changes

2017-10-23 Thread Corentin Labbe
inner: Revert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 16 .../boot/dts/allwinner/sun50i-a64-pine64-plus.dts| 15 +++ arch/arm64/boot/dts/allwinner/sun50i-a64-

[PATCH v8 08/10] net: stmmac: snps,dwmac-mdio MDIOs are automatically registered

2017-10-23 Thread Corentin Labbe
s not need to be in need_mdio_ids. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_

[PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

2017-11-28 Thread Corentin Labbe
The driver expect "allwinner,leds-active-low" to be in PHY node, but the binding doc expect it to be in MAC node. Since all board DT use it also in MAC node, the driver need to search allwinner,leds-active-low in MAC node. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com&

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

2017-11-29 Thread Corentin Labbe
On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > > The driver expect "allwinner,leds-active-low" to be in PHY node, but > > the binding doc expect it to be in MAC node. > > > >

[PATCH v9 10/10] net: stmmac: sun8i: Restore the compatibles

2017-10-24 Thread Corentin Labbe
sun8i: Remove the compatibles") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmm

[PATCH v9 09/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

2017-10-24 Thread Corentin Labbe
The Allwinner H3 SoC have two distinct MDIO bus, only one could be active at the same time. The selection of the active MDIO bus are done via some bits in the EMAC register of the system controller. This patch implement this MDIO switch via a custom MDIO-mux. Signed-off-by: Corentin Labbe

[PATCH v9 08/10] net: stmmac: snps,dwmac-mdio MDIOs are automatically registered

2017-10-24 Thread Corentin Labbe
s not need to be in need_mdio_ids. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_

[PATCH v9 04/10] arm: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac

2017-10-24 Thread Corentin Labbe
Since dwmac-sun8i could use either an integrated PHY or an external PHY (which could be at same MDIO address), we need to represent this selection by a MDIO switch. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sunxi-h3-h5.dts

[PATCH v9 03/10] arm: dts: sunxi: h3/h5: Restore EMAC changes

2017-10-24 Thread Corentin Labbe
evert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi index c1bd09dab3

[PATCH v9 06/10] arm64: dts: allwinner: Restore EMAC changes

2017-10-24 Thread Corentin Labbe
inner: Revert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 16 .../boot/dts/allwinner/sun50i-a64-pine64-plus.dts| 15 +++ arch/arm64/boot/dts/allwinner/sun50i-a64-

[PATCH v9 07/10] arm64: dts: allwinner: add snps,dwmac-mdio compatible to emac/mdio

2017-10-24 Thread Corentin Labbe
stmmac bindings docs said that its mdio node must have compatible = "snps,dwmac-mdio"; Since dwmac-sun8i does not have any good reasons to not doing it, all their MDIO node must have it. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm64/boot/dts/allwinner

[PATCH v9 02/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-10-24 Thread Corentin Labbe
This patch add documentation about the MDIO switch used on sun8i-h3-emac for integrated PHY. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 145 +++-- 1 file changed, 133 insertions(+), 12 deletions(-)

[PATCH v9 05/10] arm: dts: sunxi: Restore EMAC changes (boards)

2017-10-24 Thread Corentin Labbe
: dts: sunxi: Revert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 9 + arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 19 +++ arch/arm/boot/dts/sun8i-h3-nanopi-m1-p

[PATCH v9 00/10] net: stmmac: dwmac-sun8i: Handle integrated PHY

2017-10-24 Thread Corentin Labbe
hanges since v1: - Dropped phy-is-integrated documentation patch since another same patch was already merged - Moved phy-is-integrated from SoC dtsi to final board DT. Acked-by: Florian Fainelli <f.faine...@gmail.com> Corentin Labbe (10): dt-bindings: net: Restore sun8i dwmac binding d

[PATCH v9 01/10] dt-bindings: net: Restore sun8i dwmac binding

2017-10-24 Thread Corentin Labbe
ot;dt-bindings: net: Revert sun8i dwmac binding") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Rob Herring <r...@kernel.org> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 84 ++ 1 file changed, 84 insertions(+) create mod

Re: [PATCH v7 10/10] of: mdio: Prevent of_mdiobus_register from scanning mdio-mux nodes

2017-10-24 Thread Corentin Labbe
On Tue, Oct 24, 2017 at 01:46:54PM -0500, Rob Herring wrote: > On Wed, Oct 18, 2017 at 01:44:58PM +0200, Corentin Labbe wrote: > > Each child node of an MDIO node is scanned as a PHY when calling > > of_mdiobus_register() givint the following result: > > [ 18.175379] md

[PATCH v10 8/8] arm64: dts: allwinner: add snps,dwmac-mdio compatible to emac/mdio

2017-10-31 Thread Corentin Labbe
stmmac bindings docs said that its mdio node must have compatible = "snps,dwmac-mdio"; Since dwmac-sun8i does not have any good reasons to not doing it, all their MDIO node must have it. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Florian Fainelli <f

[PATCH v10 5/8] ARM: dts: sunxi: Restore EMAC changes (boards)

2017-10-31 Thread Corentin Labbe
: dts: sunxi: Revert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Florian Fainelli <f.faine...@gmail.com> --- arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 9 + arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 19

[PATCH v10 7/8] arm64: dts: allwinner: H5: Restore EMAC changes

2017-10-31 Thread Corentin Labbe
arm64: dts: allwinner: Revert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Florian Fainelli <f.faine...@gmail.com> --- arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts | 17 + .../arm64/boot/dts/allwinner/sun50i-h5

[PATCH v10 4/8] ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac

2017-10-31 Thread Corentin Labbe
Since dwmac-sun8i could use either an integrated PHY or an external PHY (which could be at same MDIO address), we need to represent this selection by a MDIO switch. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Florian Fainelli <f.faine...@gmail.com> Reviewed-by:

[PATCH v10 0/8] net: stmmac: dwmac-sun8i: Handle integrated PHY

2017-10-31 Thread Corentin Labbe
rom SoC dtsi to final board DT. Corentin Labbe (8): dt-bindings: net: Restore sun8i dwmac binding dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY arm: dts: sunxi: h3/h5: Restore EMAC changes ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac

[PATCH v10 6/8] arm64: dts: allwinner: A64: Restore EMAC changes

2017-10-31 Thread Corentin Labbe
: dts: allwinner: Revert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Florian Fainelli <f.faine...@gmail.com> --- .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 16 .../boot/dts/allwinner/sun50i-a64-pine64-plus.dts| 15

[PATCH v10 1/8] dt-bindings: net: Restore sun8i dwmac binding

2017-10-31 Thread Corentin Labbe
ot;dt-bindings: net: Revert sun8i dwmac binding") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Rob Herring <r...@kernel.org> Acked-by: Florian Fainelli <f.faine...@gmail.com> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 84 ++

[PATCH v10 2/8] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-10-31 Thread Corentin Labbe
This patch add documentation about the MDIO switch used on sun8i-h3-emac for integrated PHY. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Florian Fainelli <f.faine...@gmail.com> Reviewed-by: Andrew Lunn <and...@lunn.ch> --- .../devicetree/bindings/n

[PATCH v10 3/8] arm: dts: sunxi: h3/h5: Restore EMAC changes

2017-10-31 Thread Corentin Labbe
evert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Florian Fainelli <f.faine...@gmail.com> --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dts

Re: [PATCH v9 02/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-10-30 Thread Corentin Labbe
On Fri, Oct 27, 2017 at 09:37:10AM -0500, Rob Herring wrote: > On Tue, Oct 24, 2017 at 07:57:06PM +0200, Corentin Labbe wrote: > > This patch add documentation about the MDIO switch used on sun8i-h3-emac > > for integrated PHY. > > > > Signed-off-by: Corentin Labbe

Re: [PATCH v9 06/10] arm64: dts: allwinner: Restore EMAC changes

2017-10-30 Thread Corentin Labbe
On Fri, Oct 27, 2017 at 05:11:14PM +0200, Maxime Ripard wrote: > On Tue, Oct 24, 2017 at 07:57:10PM +0200, Corentin Labbe wrote: > > The original dwmac-sun8i DT bindings have some issue on how to handle > > integrated PHY and was reverted in last RC of 4.13. > > But now we

[BUG] net: stmmac: dwmac-sun8i broken in linux-next

2018-05-16 Thread Corentin Labbe
Hello The dwmac-sun8i driver is broken in next-20180515, symptom are no RX and TX errors as shown by ifconfig: eth0: flags=4163 mtu 1500 inet 192.168.1.204 netmask 255.255.255.0 broadcast 192.168.1.255 ether 96:75:ff:0d:f6:d8 txqueuelen 1000

Re: [PATCH v3 net-next 00/12] net: stmmac: Clean-up and tune-up

2018-05-18 Thread Corentin Labbe
On Fri, May 18, 2018 at 02:55:57PM +0100, Jose Abreu wrote: > This targets to uniformize the handling of the different GMAC versions in > stmmac_main.c file and also tune-up the HW. > > Currently there are some if/else conditions in the main source file which > calls different callbacks depending

Re: [PATCH v3 net-next 00/12] net: stmmac: Clean-up and tune-up

2018-05-18 Thread Corentin Labbe
On Fri, May 18, 2018 at 03:23:44PM +0100, Jose Abreu wrote: > Hi Corentin, > > On 18-05-2018 15:12, Corentin Labbe wrote: > > On Fri, May 18, 2018 at 02:55:57PM +0100, Jose Abreu wrote: > >> This targets to uniformize the handling of the different GMAC versions in > >

Re: [PATCH net-next] net: stmmac: Populate missing callbacks in HWIF initialization

2018-05-18 Thread Corentin Labbe
not previously populated by HW specific setup. > > Signed-off-by: Jose Abreu <joab...@synopsys.com> > Fixes: 5f0456b43140 ("net: stmmac: Implement logic to automatically > select HW Interface") > Reported-by: Corentin Labbe <clabbe.montj...@gmail.com> > Cc: C

[PATCH] net: ethernet: i40e: remove i40e_fcoe files

2018-01-28 Thread Corentin Labbe
i40e_fcoe support was removed via commit 9eed69a9147c ("i40e: Drop FCoE code from core driver files") But this left files in place but uncompilable. Let's finish the cleaning. Signed-off-by: Corentin Labbe <cla...@baylibre.com> --- drivers/net/ethernet/intel/i40e/i4

Re: [linux-sunxi] [PATCH 4/5] arm64: allwinner: h6: add EMAC device nodes

2018-07-22 Thread Corentin Labbe
On Sun, Jul 22, 2018 at 01:39:54PM +0800, Icenowy Zheng wrote: > Allwinner H6 SoC has an EMAC like the one in A64. > > Add device tree nodes for the H6 DTSI file. > > Signed-off-by: Icenowy Zheng > --- > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 30 > 1 file changed,

<    1   2   3   4   5