reproduce the failures.
Given that some of the most interesting netlink attributes to specify
like a mac address or a network device name seem are generally
the wrong thing to do this seems like the right approach.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
drivers/net/veth.c | 16
[EMAIL PROTECTED] (Eric W. Biederman) writes:
Pavel Emelyanov [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
Stephen it looks like you weren't cc'd on the latest version
of the veth support. So this patchset first reverts the old
He was. The latest version looks completely different
Stephen Hemminger [EMAIL PROTECTED] writes:
On Wed, 12 Sep 2007 07:05:42 -0600
[EMAIL PROTECTED] (Eric W. Biederman) wrote:
This adds support for setting the IFLA_NET_NS_PID attribute
on links allowing them to be moved between network namespaces.
Signed-off-by: Eric W. Biederman [EMAIL
Pavel Emelyanov [EMAIL PROTECTED] writes:
+}
-tbp = peer_tb;
-} else
-tbp = tb;
The intention of this part was to get the same parameters for
peer as for the first device if no peer argument was specified
for ip utility. Does it still work?
I know it is
Pavel Emelyanov [EMAIL PROTECTED] writes:
[snip]
@@ -25,6 +26,3 @@ clean:
LDLIBS += -ldl
LDFLAGS += -Wl,-export-dynamic
-
-%.so: %.c
-$(CC) $(CFLAGS) -shared $ -o $@
%) How do we get the .so file then?
The code was built into iproute2, so we don't need the .so file.
Pavel Emelyanov [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
Pavel Emelyanov [EMAIL PROTECTED] writes:
+ }
- tbp = peer_tb;
- } else
- tbp = tb;
The intention of this part was to get the same parameters for
peer as for the first device if no peer argument
. In that case I return -ENXIO because
effectively the network namespace has already gone away so the files
we are trying to access don't exist anymore.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
fs/proc/proc_net.c |6 ++
include/linux/proc_fs.h |5 +
include/net
This replaces the void * parameter with a struct net_device * which
is what is actually required.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
include/linux/netdevice.h |2 +-
net/core/dev.c|4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
Now that the network namespace work is partly merged I figure
a short status summary of where everything is at is in order.
David Miller has merged the core of the network namespace work
and that probably needs to sit just a little while to make certain
we don't have unexpected breakage.
Before
Oliver Hartkopp [EMAIL PROTECTED] writes:
can you send me your current AF_PACKET patch? I just want to update our
recent post of the CAN (controller area network) subsystem (AF_CAN)
which is (in some parts) similar to AF_PACKET. So i can take a look on
it to provide the latest technique in
Stephen Hemminger [EMAIL PROTECTED] writes:
On Fri, 14 Sep 2007 11:39:32 +0400
Pavel Emelyanov [EMAIL PROTECTED] wrote:
I proposed introducing a list_for_each_entry_continue_reverse
macro to be used in setup_net() when unrolling the failed
-init callback.
Here is the macro and some more
Johannes Berg [EMAIL PROTECTED] writes:
Now that the network namespace work is in net-2.6.24, I'm wondering how
wireless will be handling this. Is there any benefit at all to a
wireless device supporting network namespaces?
Good question. Network namespaces are designed as a general tool
so
, but the code
looks nicer.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Acked-by: Eric W. Biederman [EMAIL PROTECTED]
Eric
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
Stephen Hemminger [EMAIL PROTECTED] writes:
Could we just make it so dev-init is not allowed to fail? Then it
can be a void function and the nasty unwind code can go?
Unfortunately we need to allocate memory, and perform other operations
that can fail. That's the nature of the problem.
So I
David Miller [EMAIL PROTECTED] writes:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 13 Esp 2007 13:12:08 -0600
The final blocker to having multiple useful instances of network
namespaces is the loopback device. We recognize the network namespace
of incoming packets by looking
David Miller [EMAIL PROTECTED] writes:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 14 Sep 2007 22:07:14 +0200
Could we just make it so dev-init is not allowed to fail? Then it
can be a void function and the nasty unwind code can go?
Someone (not me :-) need to do an audit to find
, but the code
looks nicer.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Acked-by: Eric W. Biederman [EMAIL PROTECTED]
Pavel if you are going down this route. Could you look at
cleanup_net as well. The reverse walk there could probably
benefit from being list_for_each_entry_reverse.
Eric
he will use this for the
namespace stuff.
Acked-by: Eric W. Biederman [EMAIL PROTECTED]
Not that it doesn't already have my signed off by.
I have an earlier version of this patch sitting in my tree,
along with some additional patches to make this per namespace.
I don't really care which version
David Miller [EMAIL PROTECTED] writes:
I've put these patches into the just-rebased net-2.6.24 tree.
I made a minor modification to the second patch, the
out_free_netdev: code in loopback_init() ended like this:
out_free_netdev:
free_netdev(dev);
goto out;
return err;
special cases from net/core/dev.c
renames functions from netdev_sysfs_ to netdev_kobject_
and always compiles in net-sysfs.c
net-sysfs.c is modified with a CONFIG_SYSFS guard around the parts
that are actually sysfs specific.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/core
namespace support into code paths
that exist when the CONFIG_NET is not selected there are a few
additions made to net_namespace.h to allow a few more functions
to be used when the networking stack is not compiled in.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
include/linux/sched.h
network namespace instances.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
drivers/net/loopback.c | 32
1 files changed, 28 insertions(+), 4 deletions(-)
diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
index 4b6f7b2..f3018bb 100644
and calling inetdev_destroy works
fine so there appears to be no reason for avoiding unregistering the
loopback device.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/ipv4/devinet.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/devinet.c b/net/ipv4
Now that multiple loopback devices are becoming possible it makes
the code a little cleaner and more maintainable to test if a deivice
is th a loopback device by testing dev-flags IFF_LOOPBACK instead
of dev == loopback_dev.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/ipv4
it as init_net.loopback_dev, keeping all of the
code compiling and working. A later pass will be needed to
update the users to use something other than the initial network
namespace.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
drivers/net/loopback.c | 26 +-
include/linux
it and looking at the alternatives carefully
it looks like the simplest and most maintainable solution is
to remove net_list_mutex altogether, and to use the rtnl_mutex instead.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
include/net/net_namespace.h |3 ---
net/core/net_namespace.c
David Miller [EMAIL PROTECTED] writes:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Wed, 26 Sep 2007 17:53:40 -0600
This patch add support for dynamically allocating the statistics counters
for the loopback device and adds appropriate device methods for allocating
and freeing
Urs Thuermann [EMAIL PROTECTED] writes:
This patch adds the virtual CAN bus (vcan) network driver.
The vcan device is just a loopback device for CAN frames, no
real CAN hardware is involved.
I'm trying to wrap my head around the CAN use of IFF_LOOPBACK.
6.2 loopback
As described in
Daniel Lezcano [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
Now that multiple loopback devices are becoming possible it makes
the code a little cleaner and more maintainable to test if a deivice
is th a loopback device by testing dev-flags IFF_LOOPBACK instead
of dev == loopback_dev
I guess in particular IFF_LOOPBACK means that all packets from
a device will come right back to the current machine, and go
nowhere else.
That usage sounds completely different then the CAN usage which
appears to mean. Broadcast packets will be returned to this machine
as well as being sent out
Denis V. Lunev [EMAIL PROTECTED] writes:
Moving dst entries into init_net.loopback_dev is not a good thing.
This hides obvious and non-obvious ref-counting bugs.
Acked-by: Eric W. Biederman [EMAIL PROTECTED]
To be clear using init_net.loopback is currently safe because we don't
have any
Denis V. Lunev [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
This patch makes loopback_dev per network namespace. Adding
code to create a different loopback device for each network
namespace and adding the code to free a loopback device
when a network namespace exits.
This patch
Cedric Le Goater [EMAIL PROTECTED] writes:
diff --git a/include/linux/sched.h b/include/linux/sched.h
index a01ac6d..e10a0a8 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -27,6 +27,7 @@
#define CLONE_NEWUTS0x0400 /* New utsname group? */
David Miller [EMAIL PROTECTED] writes:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 27 Sep 2007 01:48:00 -0600
I'm not doing get_cpu/put_cpu so does the comment make sense
in relationship to per_cpu_ptr?
It is possible. But someone would need to go check for
sure.
Verified
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
include/linux/sched.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index e10a0a8..d82c1f7 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -27,7
A hint as to why it is safe to use per cpu variables,
and note that we actually can have multiple instances
of the loopback device now.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
drivers/net/loopback.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git
David Miller [EMAIL PROTECTED] writes:
Eric, pick an appropriate new non-conflicting number NOW.
Done. My apologies for the confusion. I thought the
way Cedric and the IBM guys were testing someone would have
shouted at me long before now.
This adds unnecessary extra work for Andrew Morton,
Andrew Morton [EMAIL PROTECTED] writes:
On Thu, 27 Sep 2007 17:10:53 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
I will gladly do what I can, to help. Working against 3 trees
development at the moment is a bit of a development challenge.
Andrew has to work against 30 or so
I
Jiri Slaby [EMAIL PROTECTED] writes:
On 09/27/2007 11:22 AM, Andrew Morton wrote:
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/
Yep.
# find /proc /dev/null
find: WARNING: Hard link count is wrong for /proc/net: this may be a bug in
your
Oliver Hartkopp [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
Currently IFF_LOOPBACK set in dev-flags means we are dealing
with drivers/net/loopback.c.
This is a very general view, don't you think? The one is an interface
flag and the other one is an interface itself. This looks
ASSERT_RTNL to use that.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
include/linux/rtnetlink.h |4 ++--
net/core/rtnetlink.c |5 +
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/include/linux/rtnetlink.h b/include/linux/rtnetlink.h
index dff3192..9c21e45
be disabled.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/bridge/br_netlink.c |9 +
net/core/fib_rules.c| 11 +++
net/core/neighbour.c| 18 ++
net/core/rtnetlink.c| 19 +++
net/decnet/dn_dev.c | 12
net
After this patch none of the netlink callback support anything
except the initial network namespace but the rtnetlink infrastructure
now handles multiple network namespaces.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
include/linux/rtnetlink.h |8 ++--
include/net
about are invisible.
If applications start getting confused or when ifindex
numbers become local to the network namespace we may need
to do something different in the future.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/core/rtnetlink.c | 27 +++
1 files
This is done by making packet_sklist_lock and packet_sklist per
network namespace and adding an additional filter condition on
received packets to ensure they came from the proper network
namespace.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
include/net/net_namespace.h |4 +
net
Patrick McHardy [EMAIL PROTECTED] writes:
I'm wondering why this receive queue processing on unlock is still
necessary today, we don't do trylock in rtnetlink_rcv anymore, so
all senders will simply wait until the lock is released and then
process the queue.
Good question, I should probably
Patrick McHardy [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
Because of the global nature of garbage collection, and because of the
cost of per namespace hash tables unix_socket_table has been kept
global. With a filter added on lookups so we don't see sockets from
the wrong namespace
Herbert Xu [EMAIL PROTECTED] writes:
Eric W. Biederman [EMAIL PROTECTED] wrote:
Currently we have the call path:
macvlan_open - dev_unicast_add - __dev_set_rx_mode -
__dev_set_promiscuity - ASSERT_RTNL - mutex_trylock
When mutex debugging is on taking a mutex complains if we
Patrick McHardy [EMAIL PROTECTED] writes:
Maybe I can save you some time: we used to do down_trylock()
for the rtnl mutex, so senders would simply return if someone
else was already processing the queue *or* the rtnl was locked
for some other reason. In the first case the process already
Denis V. Lunev [EMAIL PROTECTED] writes:
The presence of the message in the queue during rtnl_unlock is quite
possible as normal user-kernel message processing path for rtnl is the
following:
netlink_sendmsg
netlink_unicast
netlink_sendskb
skb_queue_tail
Patrick McHardy [EMAIL PROTECTED] writes:
Denis V. Lunev wrote:
By the way, Patrick, this looks like nlk-pid == 0 if and only if this
is a kernel socket. Right?
Thats correct.
I have told with Alexey Kuznetsov and we have discrovered a way to get
rid of
Kok, Auke [EMAIL PROTECTED] writes:
maximilian attems wrote:
Linux tau 2.6.23-rc8-mm2-686 #1 SMP Wed Oct 3 23:56:32 CEST 2007 i686
GNU/Linux
eth0 renamed to eth1
sysfs: duplicate filename 'eth1' can not be created
WARNING: at fs/sysfs/dir.c:433 sysfs_add_one()
[c0104f9c]
Stephen Hemminger [EMAIL PROTECTED] writes:
On Fri, 28 Sep 2007 22:47:16 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Ayaz Abdulla wrote:
I am trying to track down a forcedeth driver issue described by bug 9047
in bugzilla (2.6.23-rc7-git1 forcedeth w/ MCP55 oops under heavy load).
I
Denis V. Lunev [EMAIL PROTECTED] writes:
David Miller wrote:
From: Denis V. Lunev [EMAIL PROTECTED]
Date: Mon, 08 Oct 2007 10:34:23 +0400
OK. I am installing Fedora 7 right now...
You don't need to install Fedora, just read the code! :-)
The bug is obvious and it's been explained
Pavel Emelyanov [EMAIL PROTECTED] writes:
Currently indexes for netdevices come sequentially one by
one, and the same stays true even for devices that are
created for namespaces.
Side effects of this are:
* lo device has not 1 index in a namespace. This may break
some userspace that
David Stevens [EMAIL PROTECTED] writes:
Sorry if this is a dumb question, but what is the model you intend for
SNMP? Do you want each namespace to be its own virtual machine with
its own, separate MIB?
Each network namespace appears to user space as a completely separate
network stack. So
David Miller [EMAIL PROTECTED] writes:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Tue, 09 Oct 2007 11:43:58 -0600
David Stevens [EMAIL PROTECTED] writes:
Sorry if this is a dumb question, but what is the model you intend for
SNMP? Do you want each namespace to be its own virtual
Pavel Emelyanov [EMAIL PROTECTED] writes:
I know there are several data structures internal to the kernel that
are indexed by ifindex, and not struct net_device *. There is the
iflink field in struct net_device. We need a way to refer to network
devices in other namespaces in rtnetlink in
Denis V. Lunev [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
Before I can enable rtnetlink to work in all network namespaces
I need to be certain that something won't break. So this
patch deliberately disables all of the rtnletlink methods in everything
except the initial network
Johannes Berg [EMAIL PROTECTED] writes:
On Tue, 2007-10-09 at 11:41 -0600, Eric W. Biederman wrote:
So please hold off on this until the kernel has been audited and
we have removed all of the uses of ifindex that assume ifindex is
global, that we can find.
I certainly have this assumption
David Miller [EMAIL PROTECTED] writes:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Fri, 28 Sep 2007 18:59:08 -0600
Currently we have the call path:
macvlan_open - dev_unicast_add - __dev_set_rx_mode -
__dev_set_promiscuity - ASSERT_RTNL - mutex_trylock
When mutex debugging
Herbert Xu [EMAIL PROTECTED] writes:
On Thu, Oct 11, 2007 at 12:57:31AM -0600, Eric W. Biederman wrote:
There was a practical suggestion by Herbert that ASSERT_RTNL have a
might_sleep() added. That suggestion will currently result in
ASSERT_RTNL firing unnecessarily from the macvlan_open
Herbert Xu [EMAIL PROTECTED] writes:
Well thanks to that warning we're on our way of improving the
code that triggered it in such a way that this warning will soon
go silent.
That's precisely the reason why I object to having this warning
removed. Now you have a good point that this
Johannes Berg [EMAIL PROTECTED] writes:
On Wed, 2007-10-10 at 13:51 -0600, Eric W. Biederman wrote:
Yes. Netlink sockets are per-namespace and you can use the namespace
of a netlink socket to look up a netdev.
Ok, thanks. I still haven't really looked into the wireless vs. net
namespaces
David, all. My apologies. I'm tired and I don't have the energy to
grok yet another part of the kernel right now. So I can not
productively participate in this discussion.
I do agree that the locking below dev_unicast_add() that was exposed
by the macvlan driver is unmaintainable even if it is
)
check is false.
This patch avoids the leak.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
This patch appears trivially correct to me.
Acked-by: Eric W. Biederman [EMAIL PROTECTED]
---
af_netlink.c |2 ++
1 file changed, 2 insertions(+)
--- linux-2.6/net/netlink/af_netlink.c~ 2007
to check up on sysctl values.
This should fix it.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
diff --git a/kernel/sysctl_check.c b/kernel/sysctl_check.c
index 3c9ef5a..ed6fe51 100644
--- a/kernel/sysctl_check.c
+++ b/kernel/sysctl_check.c
@@ -731,7 +731,7 @@ static struct trans_ctl_table
Denis V. Lunev [EMAIL PROTECTED] writes:
The patch attached should help. The idea is simple. The init should be
called only once without NETNS. Period. No need for any lists.
I'll resend it to Dave after the ACK.
First in the case of the code that is currently merged none of
the __net_init
Benjamin Thery [EMAIL PROTECTED] writes:
Denis V. Lunev wrote:
The patch attached should help. The idea is simple. The init should be
called only once without NETNS. Period. No need for any lists.
This is the kind of idea I had but I didn't think it could be
that simple. :)
Thanks Denis.
David Miller [EMAIL PROTECTED] writes:
From: Jeff Garzik [EMAIL PROTECTED]
Date: Tue, 23 Oct 2007 22:25:05 -0400
h. Using ethtool isn't a big deal, but IMO you probably want more
than just an exported list for the usage you described... it sounds
like some sort of reservation system
Benjamin Thery [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
Benjamin Thery [EMAIL PROTECTED] writes:
Denis V. Lunev wrote:
The patch attached should help. The idea is simple. The init should be
called only once without NETNS. Period. No need for any lists.
This is the kind of idea I
Denis V. Lunev [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
Benjamin Thery [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
Benjamin Thery [EMAIL PROTECTED] writes:
Denis V. Lunev wrote:
The patch attached should help. The idea is simple. The init should be
called only once
Rick Jones [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
Duplicate mac addresses across interfaces on the same machine
should generally be a don't care. Although there may some
cases we don't mind.
What might the switches think of that? Outside of the context of a
link-aggregate I
#ifdef sounds good to me.
Acked-by: Eric W. Biederman [EMAIL PROTECTED]
-- snip --
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
22ea6cd56e4fa844b0b1bbab2542f09eb6c9a5ab
diff --git a/net/core/sock.c b/net/core/sock.c
index febbcbc..ee1cc4f 100644
--- a/net/core/sock.c
+++ b/net/core
David Miller [EMAIL PROTECTED] writes:
Thanks for doing this.
But this appears to be still discussed, so I'll give
Denis and others another day to work out the fix they
want to include.
At this point I think all that really needs to happen is to remove
__net_initdata. The function
.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
drivers/net/loopback.c |2 +-
fs/proc/proc_net.c |2 +-
include/net/net_namespace.h |2 --
net/core/dev.c |6 +++---
net/core/dev_mcast.c|2 +-
net/netlink/af_netlink.c|2 +-
6
race I introduced with
accessing current is actually removed.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/core/rtnetlink.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 4a2640d..e1ba26f 100644
--- a/net
David Miller [EMAIL PROTECTED] writes:
From: Rick Jones [EMAIL PROTECTED]
Date: Fri, 26 Oct 2007 16:31:47 -0700
Eric W. Biederman wrote:
Adrian Bunk [EMAIL PROTECTED] writes:
This patch fixes the following build error with CONFIG_SYSCTL=n:
-- snip --
...
ERROR
David Miller [EMAIL PROTECTED] writes:
Applied, thanks Eric.
Although juding by his comments I though that Denis had different
plans in mind to fix this.
He might. Somehow I wasn't on that thread so I missed it until after
I sent this patch. Reading through that thread again it looks like
Daniel Lezcano [EMAIL PROTECTED] writes:
When a network namespace reference is held by a network subsystem,
and when this reference is decremented in a rcu update callback, we
must ensure that there is no more outstanding rcu update before
trying to free the network namespace.
In the
-by: Eric W. Biederman [EMAIL PROTECTED]
Looks like a good clean up to me.
---
net/ipv6/addrconf.c |4
1 file changed, 4 deletions(-)
Index: net-2.6/net/ipv6/addrconf.c
===
--- net-2.6.orig/net/ipv6/addrconf.c
Daniel Lezcano [EMAIL PROTECTED] writes:
Yes, I had this problem when doing ipv6 isolation for netns49. The ipv6
subsystem creation failed and the different subsystem where rollbacked in the
setup_net function.
When the network namespace was about to be freed in free_net function, I had
the
Benjamin Herrenschmidt [EMAIL PROTECTED] writes:
Bug is in the new dev_ifname32:
uifr = compat_alloc_user_space(sizeof(struct ifreq));
if (copy_in_user(uifr, compat_ptr(arg), sizeof(struct ifreq32)));
return -EFAULT;
There's a stray ; after the if statement, that
Eric Dumazet [EMAIL PROTECTED] writes:
Definitly wanted here. Thank you.
One more refcounting on each socket creation/deletion was expensive.
Really? Have you actually measured that? If the overhead is
measurable and expensive we may want to look at per cpu counters or
something like that.
Eric Dumazet [EMAIL PROTECTED] writes:
Eric W. Biederman a écrit :
Eric Dumazet [EMAIL PROTECTED] writes:
Definitly wanted here. Thank you.
One more refcounting on each socket creation/deletion was expensive.
Really? Have you actually measured that? If the overhead is
measurable
David Miller [EMAIL PROTECTED] writes:
From: Eric Dumazet [EMAIL PROTECTED]
Date: Wed, 31 Oct 2007 23:40:59 +0100
Eric W. Biederman a écrit :
Eric Dumazet [EMAIL PROTECTED] writes:
Definitly wanted here. Thank you.
One more refcounting on each socket creation/deletion
Daniel Lezcano [EMAIL PROTECTED] writes:
The loopback is now dynamically allocated. The ipv6 code was written
considering the loopback is allocated before the ipv6 protocol
initialization. This is still the case when we don't use multiple
network namespaces.
You do know that
Denis V. Lunev [EMAIL PROTECTED] writes:
Index: linux-2.6-netns/net/ipv6/addrconf.c
===
--- linux-2.6-netns.orig/net/ipv6/addrconf.c
+++ linux-2.6-netns/net/ipv6/addrconf.c
@@ -2272,7 +2272,8 @@ static int addrconf_notify(struct
Denis V. Lunev [EMAIL PROTECTED] writes:
why should we care on down? we are destroying the device. It should
gone. All references to it should also gone. So, we should perform the
cleaning and remove all IPv6 addresses, so notifier should also work.
We need to take care of netdev down,
Daniel Lezcano [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
Denis V. Lunev [EMAIL PROTECTED] writes:
Index: linux-2.6-netns/net/ipv6/addrconf.c
===
--- linux-2.6-netns.orig/net/ipv6/addrconf.c
+++ linux-2.6-netns/net
David Miller [EMAIL PROTECTED] writes:
Well this is a weird way to get to this part of the conversation.
From: Denis V. Lunev [EMAIL PROTECTED]
Date: Mon, 12 Nov 2007 19:49:03 +0300
Unregister for a loopback in !init_net is a _valid_ operation and should
be clean, i.e. without kludges in
YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] writes:
In article [EMAIL PROTECTED] (at Mon, 12 Nov 2007
12:50:53 -0700), [EMAIL PROTECTED] (Eric W. Biederman) says:
My opinion is that both your analysis is slightly off (as to the cause
of your problems) and that your approach to fix your
Simon Horman [EMAIL PROTECTED] writes:
Hi Christian, Hi Dave,
I have indeed been looking into this of late. Assuming that you use of
CTL_UNNUMBERED is correct, this patch looks fine to me. Acked.
I was planning to do the same and also switch over all the other entries
over to use
David Miller [EMAIL PROTECTED] writes:
From: Olof Johansson [EMAIL PROTECTED]
Date: Tue, 13 Nov 2007 01:23:13 -0600
As seen when booting ppc64_defconfig:
sysctl table check failed: /net/token-ring .3.14 procname does not match
binary path procname
Signed-off-by: Olof Johansson [EMAIL
Simon Horman [EMAIL PROTECTED] writes:
Hi,
this series of three patches, the first of which is by
Christian Borntraeger, switches IPVS over to use CTL_UNNUMBERED,
removing a lot of unused cruft.
Acked-by: Eric W. Biederman [EMAIL PROTECTED]
Looks sane to me.
Eric
-
To unsubscribe from
Julian Anastasov [EMAIL PROTECTED] writes:
I assume /proc/sys is still valid place, only sysctl interface
is scheduled for removal.
Yes. The ascii versions of the sysctls that show up in /proc/sys are
definitely still valid.
So, as long as these entries are not
accessible from sysctl
Olof Johansson [EMAIL PROTECTED] writes:
On Wed, Nov 14, 2007 at 08:45:28AM -0800, Randy Dunlap wrote:
On Wed, 14 Nov 2007 08:56:20 -0700 Eric W. Biederman wrote:
David Miller [EMAIL PROTECTED] writes:
From: Olof Johansson [EMAIL PROTECTED]
Date: Tue, 13 Nov 2007 01:23:13 -0600
Simon Horman [EMAIL PROTECTED] writes:
On Thu, Nov 15, 2007 at 02:38:32AM +0200, Julian Anastasov wrote:
Hi Julian,
On Tue, 13 Nov 2007, Simon Horman wrote:
[snip]
As for the commented out entries. They are supposed to be exposed by
some other means - I believe the thinking was to
Denis V. Lunev [EMAIL PROTECTED] writes:
If CONFIG_NET_NS is not set, the only namespace is possible.
This patch removes list of pernet_operations and cleanups code a bit.
This list is not needed if there are no namespaces. We should just call
-init method.
Additionally, the -exit will be
Denis V. Lunev [EMAIL PROTECTED] writes:
This patch reverts Eric's commit 2b008b0a8e96b726c603c5e1a5a7a509b5f61e35
It diets .text .data section of the kernel if CONFIG_NET_NS is not set.
This is safe after list operations cleanup.
Ok. This patch is technically safe because none of the
301 - 400 of 1118 matches
Mail list logo
