Re: [e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed...

2006-03-31 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

[E1000]: Tiny clean-up to RX checksum calculation

2006-03-31 Thread Herbert Xu
for big-endian architectures. Signed-off-by: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt diff

Re: [e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed...

2006-03-31 Thread Herbert Xu
computing the number of descriptors and calling e1000_tx_map. This is bad because e1000_tx_map gets the wrong value for last_tx_tso and therefore may corrupt memory for every TSO packet when the ring is almost full. This bug exists on UP as well as SMP. Signed-off-by: Herbert Xu [EMAIL PROTECTED

Re: [e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed...

2006-03-31 Thread Herbert Xu
/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index 49cd096..64ac6f4 100644 --- a/drivers/net/e1000/e1000_main.c +++ b

Re: [RFC][PATCH] avoid multi page allocs in ip_append_data

2006-03-31 Thread Herbert Xu
; + alloclen += datalen + fragheaderlen; For the else clause wouldn't we be counting fragheaderlen twice if the multi page if falls through above despite NETIF_F_SG being true? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: ipsec tunnel MTU issue [was: ipsec double lookup]

2006-03-31 Thread Herbert Xu
: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-03-31 Thread Herbert Xu
it as if (dest_ip htonl(0xUL) == htonl(0xA9FEUL)) dest_hw = NULL; Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-03-31 Thread Herbert Xu
: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

[1/*] [IPSEC]: Kill unused decap state argument

2006-03-31 Thread Herbert Xu
to move the encap type check to the generic xfrm_rcv function. This allows us to get rid of the decap state argument altogether. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

[2/*] [IPSEC]: Kill unused decap state structure

2006-03-31 Thread Herbert Xu
Hi Dave: This patch removes the *_decap_state structures which were previously used to share state between input/post_input. This is no longer needed. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-04-01 Thread Herbert Xu
. The only missing bit is the notification when there is a cache miss. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-04-01 Thread Herbert Xu
, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED

Re: ipsec tunnel asymmetrical mtu

2006-04-01 Thread Herbert Xu
Marco Berizzi [EMAIL PROTECTED] wrote: Thanks a lot for the reply Herbert. Is there a way to tell netkey to frag packets like klips ignoring the DF bit? There is a netfilter module around which can zap the DF bit for you. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert

[3/*] [INET]: Move no-tunnel ICMP error to tunnel4/tunnel6

2006-04-02 Thread Herbert Xu
-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c index eef07b0..ea398ee

Re: ipsec tunnel asymmetrical mtu

2006-04-02 Thread Herbert Xu
: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: Fw: bridge+netfilter broken for IP fragments in 2.6.16?

2006-04-02 Thread Herbert Xu
the IP layer, so the bridge netfilter code needs to take care of fragmentation itself. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Thanks Patrick. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert

[IPSEC]: Check x-encap before dereferencing it

2006-04-03 Thread Herbert Xu
dereferencing it We need to dereference x-encap before dereferencing it for encap_type. If it's absent then the encap_type is zero. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: ipsec tunnel asymmetrical mtu

2006-04-03 Thread Herbert Xu
can observe what's going on without disturbing the bug? -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line

Re: [PATCH] [IPSEC] Avoid null pointer dereference in xfrm4_rcv_encap

2006-04-05 Thread Herbert Xu
without testing it for null. The fix for this bug has just been merged. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from

Re: [e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed...

2006-04-05 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

[INET]: Use port unreachable instead of proto for tunnels

2006-04-05 Thread Herbert Xu
tunnel type. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt diff --git a/net/ipv4/ip_gre.c b/net

Re: [XFRM] Restore aevent timer

2006-04-06 Thread Herbert Xu
of a notification. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev

Re: dst_output() inner loop.

2006-04-06 Thread Herbert Xu
? As far as I can see it should work fine since it's not that different from netfilter queueing. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: dst_output() inner loop.

2006-04-06 Thread Herbert Xu
Evgeniy Polyakov [EMAIL PROTECTED] wrote: I just wonder why stackable dst_output() was removed? It's part of the netfilter/xfrm change where this change (not really a removal though) makes things much easier. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: [XFRM] Restore aevent timer

2006-04-07 Thread Herbert Xu
sane setup the SA should've expired by then but it pays to be safe. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from

Re: Broadcast ARP packets on link local addresses (Version2).

2006-04-07 Thread Herbert Xu
reasons (address selection) and it's not polite to suddenly turn all their ARPs into broadcasts. So how about a new address flag? We still have some vacancies there. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [PATCH] softmac: don't send out packets while scanning

2006-04-07 Thread Herbert Xu
stuck for quite a while. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev

Re: ipfrag calculating its hash outside lock

2006-04-07 Thread Herbert Xu
: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH] softmac: don't send out packets while scanning

2006-04-08 Thread Herbert Xu
. If the answer is no then you're fine. Otherwise you need to do something more drastic to stop the traffic. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] bcm43xx: set trans_start on TX to prevent bogus timeouts

2006-04-09 Thread Herbert Xu
posts seem to be turning up on netdev. The last message from you that I received through netdev was dated the 15th of Mrach. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: ipfrag calculating its hash outside lock

2006-04-10 Thread Herbert Xu
On Sun, Apr 09, 2006 at 10:44:24PM -0700, David S. Miller wrote: I got tired of waiting for Zach to cook up a patch so I tossed the following into my tree :-) Thanks David :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [XFRM] Restore aevent timer

2006-04-11 Thread Herbert Xu
)) + !mod_timer(x-rtimer, jiffies + x-replay_maxage)) { xfrm_state_hold(x); + x-xflags = ~XFRM_TIME_DEFER; + } You can skip this hunk because it's a brand new state which should already be zeroed. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert

Re: [PATCH] shutting down an interface should remove ipv4 addresses

2006-04-11 Thread Herbert Xu
David S. Miller [EMAIL PROTECTED] wrote: I agree, it should behave just like ipv4. AOL That would've made quite a few races that we had to fix non-existant by definition :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [RFC][PATCH] Avoid multi-page allocs for large mtu datagram sends

2006-04-12 Thread Herbert Xu
, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH] atm: clip causes unregister hang

2006-04-12 Thread Herbert Xu
entries may get added even if the device is down. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line

Re: [RFC][PATCH] Avoid multi-page allocs for large mtu datagram sends

2006-04-12 Thread Herbert Xu
On Wed, Apr 12, 2006 at 11:22:58AM -0700, Zach Brown wrote: Did you have an opinion of the rest of the original patch? Sorry, I've been busy lately so I've only just started reading it. I should have something to say by tomorrow :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert

Re: [PATCH] atm: clip causes unregister hang

2006-04-12 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH] atm: clip causes unregister hang

2006-04-12 Thread Herbert Xu
: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH] atm: clip causes unregister hang

2006-04-13 Thread Herbert Xu
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Thanks a lot Stephen. This version looks good. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert

Re: [PATCH] atm: clip timer race

2006-04-13 Thread Herbert Xu
it before we forget about it. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev

Re: [RFC][PATCH] Avoid multi-page allocs for large mtu datagram sends

2006-04-13 Thread Herbert Xu
frag so we don't need to worry about trailer_len at all. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send

Re: [XFRM] Fix aevent timer

2006-04-13 Thread Herbert Xu
On Thu, Apr 13, 2006 at 08:55:58AM -0400, jamal wrote: Finally got an opportunity to test this. I have incorporated all the feedback and it passes all the scenarios i know. Looks good to me. Thanks Jamal. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

Re: [PATCH] atm: clip timer race

2006-04-13 Thread Herbert Xu
On Thu, Apr 13, 2006 at 10:26:30AM -0700, Stephen Hemminger wrote: Arp and neighbor table have the same rescheduling bug. You're absolutely right. Maybe the easy way out for now is to make clip unremovable. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

Re: [PATCH] atm: clip timer race

2006-04-13 Thread Herbert Xu
is not running (and it does this test with the timer base lock held). OK, how am I being stupid? No you're definitely right. I just missed the fix that was made to del_timer_sync last year. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-14 Thread Herbert Xu
. It doesn't take much code at all to do netlink. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line

Re: fixing sk_stream_rfree()

2006-04-16 Thread Herbert Xu
have one niggling doubt though as to why turning off TSO seems to cure the problem for people. Perhaps it'll become clearer tomorrow morning when I look at it again :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: fixing sk_stream_rfree()

2006-04-17 Thread Herbert Xu
trigger with TSO enabled, and my next planned chore is to audit the TSO splitting during ACK processing. We may be doing something stupid there. BTW, do we have a dmesg log from the machine that did this with tg3? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: fixing sk_stream_rfree()

2006-04-17 Thread Herbert Xu
be related to the reclaim stuff. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH] ip_route_input panic fix

2006-04-17 Thread Herbert Xu
really need this? After all we can get completely bogus values coming in through the network too. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Crypto Update for 2.6.21

2007-02-07 Thread Herbert Xu
in preparation for async. Andrew Donofrio (1): [CRYPTO] tcrypt: Added test vectors for sha384/sha512 David Howells (2): [CRYPTO] pcbc: Add Propagated CBC template [CRYPTO] fcrypt: Add FCrypt from RxRPC Herbert Xu (7): [CRYPTO] all: Check for usage in hard IRQ context [CRYPTO

Re: [PATCH 1/5] Add PCBC crypto template support

2007-02-08 Thread Herbert Xu
: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: 2.6.20 crash in tcp_tso_segment()

2007-02-09 Thread Herbert Xu
a private module loaded at the time but it does no networking and I doubt it is the culprit. Yeah we should never get here if we only have one segment. Could you get it to print out the value of skb-gso_*? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

Re: [Bugme-new] [Bug 7974] New: BUG: scheduling while atomic: swapper/0x10000100/0

2007-02-11 Thread Herbert Xu
Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: 2.6.20 crash in tcp_tso_segment()

2007-02-13 Thread Herbert Xu
it's copied from. [NETFILTER]: Clear GSO bits for TCP reset packet The TCP reset packet is copied from the original. This includes all the GSO bits which do not apply to the new packet. So we should clear those bits. Spotted by Patrick McHardy. Signed-off-by: Herbert Xu [EMAIL PROTECTED

Re: 2.6.20 crash in tcp_tso_segment()

2007-02-13 Thread Herbert Xu
to 2.6.18. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/net/ipv4/netfilter/ipt_REJECT.c b/net/ipv4/netfilter/ipt_REJECT.c index

Re: [GIT PULL] IPv6 Updates

2007-02-14 Thread Herbert Xu
on the devices to occur before they're brought up or addresses are added. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au

Re: [RFC 1/2] bridge: avoid ptype_all packet handling

2007-03-02 Thread Herbert Xu
. This is using packet_bind_spkt which uses a name instead of ifindex. As you may recall, I've made a patch to convert it to use the new (actually it's not-so-new anymore) AF_PACKET interface. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page

Re: [PATCH/RFC] Use of uninitialized data in udp_recvmsg().

2007-03-05 Thread Herbert Xu
and its initial value is not used. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH/RFC] Use of uninitialized data in udp_recvmsg().

2007-03-05 Thread Herbert Xu
On Mon, Mar 05, 2007 at 01:01:16PM -0800, Jim Chow wrote: On Tue, 6 Mar 2007, Herbert Xu wrote: msg_flags [...] its initial value is not used. That's not true. Please see my post. Specifically, at linux-2.6.20.1/net/ipv4/udp.c:843, it seems that udp_recvmsg() can randomly ignore

Re: [PATCH/RFC] Use of uninitialized data in udp_recvmsg().

2007-03-05 Thread Herbert Xu
On Tue, Mar 06, 2007 at 10:34:49AM +1100, Herbert Xu wrote: That's not true. Please see my post. Specifically, at linux-2.6.20.1/net/ipv4/udp.c:843, it seems that udp_recvmsg() can randomly ignore whether the HW has computed a checksum and compute it in SW redundantly. Sorry

[UDP]: Reread uh pointer after pskb_trim

2007-03-05 Thread Herbert Xu
Hi Dave: [UDP]: Reread uh pointer after pskb_trim The header may have moved when trimming. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key

Re: netlink recvmsg() and MSG_TRUNC

2007-03-06 Thread Herbert Xu
? Which netlink family generates (or needs to generate) unbounded messages to user-space? Or indeed which ones generate messages greater than 64K (or 4K for that matter)? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: netlink recvmsg() and MSG_TRUNC

2007-03-06 Thread Herbert Xu
, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: netlink recvmsg() and MSG_TRUNC

2007-03-06 Thread Herbert Xu
, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: netlink recvmsg() and MSG_TRUNC

2007-03-06 Thread Herbert Xu
, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH] udp: net-2.6.22 build fix

2007-03-07 Thread Herbert Xu
, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH] Ensure IF_READY is unset when link is not ready

2007-03-07 Thread Herbert Xu
Now that we add the IPv6 device at registration time we don't need to set IF_READY in ipv6_add_dev anymore because we will always get a NETDEV_UP event later on should the device ever become ready. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org

Re: [PATCH][SCTP] Re: lockdep: inconsistent lock state ipv6_add_addr/sctp_v6_copy_addrlist (2.6.21-rc1)

2007-03-08 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH][SCTP] Re: lockdep: inconsistent lock state ipv6_add_addr/sctp_v6_copy_addrlist (2.6.21-rc1)

2007-03-08 Thread Herbert Xu
On Thu, Mar 08, 2007 at 10:00:23PM +1100, Herbert Xu wrote: Who's calling ipv6_add_addr from softirq context? That's got to be wrong because ipv6_add_addr requires the RTNL. Nevermind, I was thinking of ipv6_add_dev. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: Fw: [Bugme-new] [Bug 8151] New: Established connections not displayed in /proc/tcp/netstat

2007-03-08 Thread Herbert Xu
connections. If it does then we can confirm a problem with /proc, otherwise the you might have a TCP problem instead. Note that with a recent kernel you may have to build/load the tcp_diag module before 'ss -nt' will work. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: [NETLINK] periodically rehash table, why?

2007-03-14 Thread Herbert Xu
don't see a reason why periodically rehashing might help in any way (without resizing). Is there a reason for that? It's to prevent attackers from guessing the hash secret and causing hash chains to grow excessively. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: + myri10ge-build-fix.patch added to -mm tree

2006-06-21 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH] Export accept queue len of a TCP listening socket via /proc/net/tcp{6}

2006-06-21 Thread Herbert Xu
did for /proc? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH] Export accept queue len of a TCP listening socket via /proc/net/tcp{6}

2006-06-21 Thread Herbert Xu
? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: Memory corruption in 8390.c ? (was Re: Possible leaks in network drivers)

2006-06-21 Thread Herbert Xu
, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [1/5] [NET]: Merge TSO/UFO fields in sk_buff

2006-06-21 Thread Herbert Xu
Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED

Re: Memory corruption in 8390.c ? (was Re: Possible leaks in network drivers)

2006-06-21 Thread Herbert Xu
On Thu, Jun 22, 2006 at 10:55:44AM +1000, Herbert Xu wrote: I think skb_padto simply shouldn't allocate a new skb. It only needs to extend the data area. OK, here is a patch to make it do that. [NET]: Avoid allocating skb in skb_pad First of all it is unnecessary to allocate a new skb

[NET]: Prevent transmission after dev_deactivate

2006-06-22 Thread Herbert Xu
outstanding xmit_lock holders have exited is also given by dev_watchdog_down. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

[0/5] GSO: Generic Segmentation Offload

2006-06-22 Thread Herbert Xu
. This provides massive savings for Xen as it uses a bridge-based architecture and TSO/GSO produces a much larger effective MTU for internal traffic between domains. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert

[1/5] [NET]: Merge TSO/UFO fields in sk_buff

2006-06-22 Thread Herbert Xu
of SKB_GSO_TCPV4 | SKB_GSO_TCPV4_ECN while all other TSO packets would be SKB_GSO_TCPV4. This means that only the CWR packets need to be emulated in software. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

[2/5] [NET]: Add generic segmentation offload

2006-06-22 Thread Herbert Xu
. The same structure can be used to support software IPv6 TSO, as well as UFO and segmentation offload for other relevant protocols, e.g., DCCP. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page

[4/5] [NET]: Added GSO toggle

2006-06-22 Thread Herbert Xu
Hi: [NET]: Added GSO toggle This patch adds a generic segmentation offload toggle that can be turned on/off for each net device. For now it only supports in TCPv4. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

[5/5] [IPSEC]: Handle GSO packets

2006-06-22 Thread Herbert Xu
packets into dom0. Of course this also can be used by other virtualisation schemes such as VMWare or UML since the tap device could be modified to inject GSO packets received through splice. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email

Re: [0/5] GSO: Generic Segmentation Offload

2006-06-22 Thread Herbert Xu
Hi: If anyone is interested here is the incremental patch against the previous series. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[3/5] [NET]: Add software TSOv4

2006-06-22 Thread Herbert Xu
Hi: [NET]: Add software TSOv4 This patch adds the GSO implementation for IPv4 TCP. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [3/5] [NET]: Add software TSOv4

2006-06-22 Thread Herbert Xu
On Thu, Jun 22, 2006 at 06:14:00PM +1000, herbert wrote: [NET]: Add software TSOv4 Doh, forgot to remove an unused declaration. Here is an updated version. [NET]: Add software TSOv4 This patch adds the GSO implementation for IPv4 TCP. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers

Re: Memory corruption in 8390.c ? (was Re: Possible leaks in network drivers)

2006-06-22 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: Memory corruption in 8390.c ?

2006-06-22 Thread Herbert Xu
On Thu, Jun 22, 2006 at 01:26:09AM -0700, David Miller wrote: Want me to let this cook in 2.6.18 for a while before sending it off to -stable? You know I'm never one to push anything quickly so absolutely yes :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

Re: Memory corruption in 8390.c ? (was Re: Possible leaks in network drivers)

2006-06-22 Thread Herbert Xu
starfire.c yellowfin.c That doesn't really invalidate the point :) These drivers are still only padding very small packets. Hmm, at least cassini pads it to 255 for gigabit... Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page

Re: Memory corruption in 8390.c ? (was Re: Possible leaks in network drivers)

2006-06-22 Thread Herbert Xu
especially dodgy. It supports SG and also requires the whole length to be a multiple of 4 if the firmware is broken. The question is do they really intend this or do they want each fragment to terminate on a 4-byte boundary. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: Memory corruption in 8390.c ?

2006-06-22 Thread Herbert Xu
actually seen the fixed 8390 version being posted yet or at least not to netdev :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [NET]: Prevent multiple qdisc runs

2006-06-22 Thread Herbert Xu
: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [NET]: Prevent multiple qdisc runs

2006-06-22 Thread Herbert Xu
. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread Herbert Xu
a 16-bit quantity. This also means that htonl(delta) + th-check still fits in 32 bits. Therefore we don't have to use csum_add on this operations. This is based on a patch by Michael Chan [EMAIL PROTECTED]. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http

Re: Kernel Janitor TODO: dev_kfree_skb

2006-06-23 Thread Herbert Xu
objective is to strive to not have to call kfree_skb in IRQ context at all. Have a look at the TG3 driver for an example where IRQ context is kept to a minimum. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au

Re: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread Herbert Xu
[EMAIL PROTECTED]. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [0/5] GSO: Generic Segmentation Offload

2006-06-23 Thread Herbert Xu
for lo should apply. In those scenarios, GSO is basically on par with the default segmentation. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [patch 6/6] neighbour.c, pneigh_get_next() skips published entry

2006-06-25 Thread Herbert Xu
: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH]NET: Fix GSO problems in dev_hard_start_xmit()

2006-06-25 Thread Herbert Xu
if the netif_queue is stopped. Signed-off-by: Michael Chan [EMAIL PROTECTED] Good catch. Acked-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: ipsec tunnel asymmetrical mtu

2006-06-27 Thread Herbert Xu
On Tue, Jun 27, 2006 at 08:45:52AM +0200, Marco Berizzi wrote: Herbert Xu wrote: However, the fact that the tcpdump causes more chunky packets to make it through could be an indication that there is a bug somewhere in our NAT/IPsec code or at least a suboptimal memory allocation strategy

<    2   3   4   5   6   7   8   9   10   11   >