On Mon, May 13, 2019 at 09:55:21PM -0300, Jason Gunthorpe wrote:
> gcc 9 now does allocation size tracking and thinks that passing the member
> of a union and then accessing beyond that member's bounds is an overflow.
>
> Instead of using the union member, use the entire union with a cast to
> get
On Thu, May 16, 2019 at 12:21:48PM -0300, Jason Gunthorpe wrote:
> On Thu, May 16, 2019 at 02:44:28PM +0200, Simon Horman wrote:
> > On Mon, May 13, 2019 at 09:55:21PM -0300, Jason Gunthorpe wrote:
> > > gcc 9 now does allocation size tracking and thinks that passing the membe
From: Pieter Jansen van Vuuren
Previously we did not have offloading support for set IPv6 actions. This
patch enables TC flower offload of set IPv6 src and dst address actions.
Signed-off-by: Pieter Jansen van Vuuren
Reviewed-by: Jakub Kicinski
Signed-off-by: Simon Horman
---
drivers/net
From: Pieter Jansen van Vuuren
Previously MPLS match offloading was not supported. This patch enables
MPLS match offloading support for label, bos and tc fields.
Signed-off-by: Pieter Jansen van Vuuren
Reviewed-by: Jakub Kicinski
Signed-off-by: Simon Horman
---
drivers/net/ethernet
From: Pieter Jansen van Vuuren
Previously we did not have offloading support for set ethernet actions.
This patch enables TC flower offload of set ethernet actions.
Signed-off-by: Pieter Jansen van Vuuren
Reviewed-by: Jakub Kicinski
Signed-off-by: Simon Horman
---
drivers/net/ethernet
Pieter says:
This series extends flower offload match and action capabilities. It
specifically adds offload capabilities for matching on MPLS, TTL, TOS
and flow label. Furthermore offload capabilities for action have been
expanded to include set ethernet, ipv4, ipv6, tcp and udp headers.
Pieter J
From: Pieter Jansen van Vuuren
Previously matching on IPv4 ttl and tos fields were not offloaded. This
patch enables offloading IPv4 ttl and tos as match fields.
Signed-off-by: Pieter Jansen van Vuuren
Reviewed-by: Jakub Kicinski
Signed-off-by: Simon Horman
---
drivers/net/ethernet
From: Pieter Jansen van Vuuren
Previously matching on IPv6 ttl and tos fields were not offloaded. This
patch enables offloading IPv6 ttl and tos as match fields.
Signed-off-by: Pieter Jansen van Vuuren
Reviewed-by: Jakub Kicinski
Signed-off-by: Simon Horman
---
drivers/net/ethernet
From: Pieter Jansen van Vuuren
Previously we did not have offloading support for set TCP/UDP actions. This
patch enables TC flower offload of set TCP/UDP sport and dport actions.
Signed-off-by: Pieter Jansen van Vuuren
Reviewed-by: Jakub Kicinski
Signed-off-by: Simon Horman
---
drivers/net
From: Pieter Jansen van Vuuren
Previously we did not have offloading support for set IPv4 actions. This
patch enables TC flower offload of set IPv4 src and dst address actions.
Signed-off-by: Pieter Jansen van Vuuren
Reviewed-by: Jakub Kicinski
Signed-off-by: Simon Horman
---
drivers/net
parisc64
> architectures.
>
> Signed-off-by: Helge Deller
> Cc: Wensong Zhang
> Cc: netdev@vger.kernel.org
> Cc: lvs-de...@vger.kernel.org
> Cc: netfilter-de...@vger.kernel.org
Sorry for the delay in processing this.
Acked-by: Simon Horman
Pablo, could you take this through the nf-next tree directly?
On Fri, Oct 06, 2017 at 08:34:59AM -0700, Tom Herbert wrote:
> Simon,
>
> Maybe a bit off topic, but I had the impression netronome would
> support BPF so that filters could be programmed for arbitrary
> protocols and fields. Is that true? If so, what is the relationship
> between that functionali
On Mon, Oct 09, 2017 at 08:45:41AM -0700, Tom Herbert wrote:
> On Mon, Oct 9, 2017 at 1:05 AM, Simon Horman
> wrote:
> > On Fri, Oct 06, 2017 at 08:34:59AM -0700, Tom Herbert wrote:
> >> Simon,
> >>
> >> Maybe a bit off topic, but I had the impression n
On Thu, Oct 12, 2017 at 10:24:53AM +0200, Geert Uytterhoeven wrote:
> The module clock is used for two purposes:
> - Wake-on-LAN (WoL), which is optional,
> - gPTP Timer Increment (GTI) configuration, which is mandatory.
>
> As the clock is needed for GTI configuration anyway, WoL is always
>
On Thu, Oct 12, 2017 at 02:20:45PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Thu, Oct 12, 2017 at 11:55 AM, Simon Horman wrote:
> > On Thu, Oct 12, 2017 at 10:24:53AM +0200, Geert Uytterhoeven wrote:
> >> The module clock is used for two purposes:
> >>
-time effect and
is compile-tested only.
Signed-off-by: Simon Horman
---
drivers/net/ethernet/renesas/sh_eth.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c
b/drivers/net/ethernet/renesas/sh_eth.c
index
is to name
common code, compatibility strings and so on after Rcar Gen2.
Signed-off-by: Simon Horman
---
Documentation/devicetree/bindings/net/sh_eth.txt | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/sh_eth.txt
b/Document
ks is to name
common code, compatibility strings and so on after Rcar Gen2.
Signed-off-by: Simon Horman
---
drivers/net/ethernet/renesas/sh_eth.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c
b/drivers/net/ethernet/renesas/sh_eth.c
index c9f92fc
ation.
For the above reasons and convenience when enabling new SoCs a
per-generation fallback compatibility string scheme being adopted for
drivers for Renesas SoCs.
Simon Horman (3):
dt-bindings: net: sh_eth: add R-Car Gen[12] fallback compatibility
strings
net: sh_eth: rename name structur
On Tue, Oct 17, 2017 at 09:47:44AM +0200, Simon Horman wrote:
> Add fallback compatibility strings for R-Car Gen 1 and 2.
>
> In the case of Renesas R-Car hardware we know that there are generations of
> SoCs, f.e. Gen 1 and 2. But beyond that its not clear what the relationship
ty of description of bindings usage
Simon Horman (3):
dt-bindings: net: sh_eth: add R-Car Gen[12] fallback compatibility
strings
net: sh_eth: rename name structures as rcar_gen[12]_*
net: sh_eth: implement R-Car Gen[12] fallback compatibility strings
Documentation/devicetree/binding
no run-time effect and
is compile-tested only.
Signed-off-by: Simon Horman
Reviewed-by: Geert Uytterhoeven
Acked-by: Sergei Shtylyov
---
v2
* Updated changelog
* Collected review tags
---
drivers/net/ethernet/renesas/sh_eth.c | 30 +++---
1 file changed, 15 insertions
is to name
common code, compatibility strings and so on after R-Car Gen2.
Signed-off-by: Simon Horman
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Sergei Shtylyov
---
v2
* Corrected typos in changelog
* Collected review tags
* Made whitespace usage consistent with existing text
* Add comma to
locks is to name
common code, compatibility strings and so on after R-Car Gen2.
Signed-off-by: Simon Horman
Reviewed-by: Geert Uytterhoeven
Acked-by: Sergei Shtylyov
---
v2
* Corrected typos in changelog
* Collected review tags
---
drivers/net/ethernet/renesas/sh_eth.c | 2 ++
1 file chang
et sched actions: fix coding style in pedit headers
> net sched actions: fix sparse warning
> net sched actions: use sizeof operator for buffer length
> net sched actions: fix misleading text strings in pedit action
All patches:
Reviewed-by: Simon Horman
Some changelog text should go here.
On Wed, Jun 27, 2018 at 10:50:51AM -0700, Jesus Sanchez-Palencia wrote:
> Signed-off-by: Jesus Sanchez-Palencia
Otherwise, this seems fine to me.
Reviewed-by: Simon Horman
> ---
> man/man8/tc-cbs.8 | 4 ++--
> 1 file changed, 2 insertions(+),
his change improves complexity of dumping flower classifier from
> quadratic to linearithmic. (assuming idr lookup has logarithmic complexity)
>
> Reviewed-by: Jiri Pirko
> Signed-off-by: Vlad Buslov
Reported-by: Simon Horman
Thanks, I'm very pleased to see this change. I would apprecia
On Tue, Jul 10, 2018 at 08:02:10PM +0300, Vlad Buslov wrote:
>
> On Tue 10 Jul 2018 at 13:55, Simon Horman wrote:
> > On Mon, Jul 09, 2018 at 01:29:11PM +0300, Vlad Buslov wrote:
> >> Extend struct tcf_walker with additional 'cookie' field. It is intended to
filter add dev eth0 protocol ip parent : \
flower indev eth0 \
ip_flags nofirstfrag \
ip_proto udp \
action mirred egress redirect dev eth1
Signed-off-by: Pieter Jansen van Vuuren
Reviewed-by: Jakub Kicinski
Signed-off-by: Simon Horman
---
man/man8/tc-flower.8 | 8
On Sun, Apr 01, 2018 at 02:11:51PM +0300, Julian Anastasov wrote:
>
> Hello,
>
> On Sun, 1 Apr 2018, Vincent Bernat wrote:
>
> > The sh/dh/lblc/lblcr algorithms are using Knuth's multiplicative
> > hashing incorrectly. Replace its use by the hash_32() macro, which
> > correctly implements
On Sun, Apr 01, 2018 at 08:00:54AM -0700, John Fastabend wrote:
> If a socket with pending cork data is closed we do not return the
> memory to the socket until the garbage collector free's the psock
> structure. The garbage collector though can run after the sock has
> completed its close operatio
Hi Sergei,
this series is composed of otherwise unrelated RAVB patches from the R-Car
BSP v3.6.2 which at a first pass seem worth considering for upstream.
I would value your feedback on these patches so they can either proceed
into net-next or remain local to the BSP.
Thanks!
Kazuya Mizuguchi
60
[ 59.117925] [] start_kernel+0x38c/0x3a0
[ 59.124261] [] __primary_switched+0x5c/0x64
Fixes: f51bdc236b6c ("ravb: Add dma queue interrupt support")
Signed-off-by: Masaru Nagai
Signed-off-by: Kazuya Mizuguchi
Signed-off-by: Simon Horman
---
drivers/net/ethernet/renesas/ravb_main.c | 3
From: Kazuya Mizuguchi
Signed-off-by: Kazuya Mizuguchi
Signed-off-by: Simon Horman
---
drivers/net/ethernet/renesas/ravb.h | 5 -
drivers/net/ethernet/renesas/ravb_main.c | 15 ---
2 files changed, 20 deletions(-)
diff --git a/drivers/net/ethernet/renesas/ravb.h
b
From: Kazuya Mizuguchi
This patch sets from two descriptor to one descriptor because R-Car Gen3
does not have the 4 bytes alignment restriction of the transmission buffer.
Signed-off-by: Kazuya Mizuguchi
Signed-off-by: Simon Horman
---
drivers/net/ethernet/renesas/ravb.h | 6
Mizuguchi
Signed-off-by: Simon Horman
---
drivers/net/ethernet/renesas/ravb_main.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c
b/drivers/net/ethernet/renesas/ravb_main.c
index b311b1ac1286..dbde3d11458b 100644
--- a/drivers/net/ethern
From: Kazuya Mizuguchi
This patch corrects writing 1 to reserved bits.
The write value should be 0.
Signed-off-by: Kazuya Mizuguchi
Signed-off-by: Simon Horman
---
drivers/net/ethernet/renesas/ravb.h | 12
drivers/net/ethernet/renesas/ravb_main.c | 9 +
drivers/net
On Sat, Feb 24, 2018 at 09:53:17PM -0500, David Miller wrote:
> From: Sergei Shtylyov
> Date: Sat, 24 Feb 2018 21:01:15 +0300
>
> > On 02/01/2018 11:13 PM, Sergei Shtylyov wrote:
> >
> >> Renesas R-Car V3H (R8A77980) SoC has the R-Car gen3 compatible EtherAVB
> >> device, so document the SoC spe
On Mon, Feb 26, 2018 at 03:10:51PM -0500, David Miller wrote:
> From: Simon Horman
> Date: Mon, 26 Feb 2018 11:58:24 +0100
>
> > On Sat, Feb 24, 2018 at 09:53:17PM -0500, David Miller wrote:
> >> From: Sergei Shtylyov
> >> Date: Sat, 24 Feb 2018 21:01:15 +0300
On Tue, Feb 27, 2018 at 09:28:38AM +0100, jacopo mondi wrote:
> Hi Geert,
>
> On Mon, Feb 26, 2018 at 07:28:47PM +0100, Geert Uytterhoeven wrote:
> > Hi Jacopo,
> >
> > On Mon, Feb 26, 2018 at 6:57 PM, Jacopo Mondi
> > wrote:
> > > as discussed with you Sergei and Geert, in order to enable Eth
On Tue, Feb 27, 2018 at 11:22:44AM +0100, Jacopo Mondi wrote:
> Hi Simon, Geert,
>in this second iteration I have dropped iommu dependencies for EtherAVB
> and have changed "phy-mode" for all mainlines Gen-3 boards, this time
> including
> ULCB, Draak, Eagle and V3MSK.
>
> The series add phy-
On Mon, Mar 05, 2018 at 03:35:57PM -0600, Gustavo A. R. Silva wrote:
> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva
Signed-off-by: Simon Horman
Pablo, coul
Hi all,
This set adds Geneve options support to the TC tunnel key action.
Options TLVs are exposed to userspace using a list of netlink attributes
with each option described using attributes for class, type and data.
The series also enhances the tunnel key action to use extended ack.
Simon
information
to users when parsing their input.
Signed-off-by: Simon Horman
Reviewed-by: Jakub Kicinski
---
net/sched/act_tunnel_key.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/sched/act_tunnel_key.c b/net/sched/act_tunnel_key.c
index 9169b7e78ada..7ce95538177b 100644
dev geneve0
Signed-off-by: Simon Horman
Signed-off-by: Pieter Jansen van Vuuren
Reviewed-by: Jakub Kicinski
---
include/uapi/linux/tc_act/tc_tunnel_key.h | 26
net/sched/act_tunnel_key.c| 199 +-
2 files changed, 220 insertions(+), 5 deletions
Add extended ack support for the tunnel key action by using NL_SET_ERR_MSG
during validation of user input.
Signed-off-by: Simon Horman
Signed-off-by: Pieter Jansen van Vuuren
Reviewed-by: Jakub Kicinski
---
net/sched/act_tunnel_key.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions
Signed-off-by: Simon Horman
---
include/uapi/linux/pkt_cls.h | 1 +
net/sched/cls_flower.c | 6 ++
2 files changed, 7 insertions(+)
diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h
index 7cafb26df555..be05e66c167b 100644
--- a/include/uapi/linux/pkt_cls.h
+++ b
On Tue, Mar 06, 2018 at 07:11:12PM +0200, Or Gerlitz wrote:
> On Tue, Mar 6, 2018 at 7:08 PM, Simon Horman
> wrote:
> > Hi all,
> >
> > This set adds Geneve options support to the TC tunnel key action.
> > Options TLVs are exposed to userspace using a list of ne
From: John Hurley
Add a helper function that returns the length of the cmsg data when given
the cmsg skb
Signed-off-by: John Hurley
Signed-off-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 5 +
drivers/net/ethernet/netronome/nfp/flower/metadata.c | 2 +-
2
From: Simon Horman
John says:
This patch set allows offloading of TC flower match and set tunnel fields
to the NFP. The initial focus is on VXLAN traffic. Due to the current
state of the NFP firmware, only VXLAN traffic on well known port 4789 is
handled. The match and action fields must
implemented
by overwriting the index on NFP.
Signed-off-by: John Hurley
Signed-off-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/Makefile| 3 +-
drivers/net/ethernet/netronome/nfp/flower/cmsg.c | 7 -
drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 9 +
drivers/net/ethernet
relevant information.
Overwrite routes with zero values on the NFP when they expire.
Signed-off-by: John Hurley
Reviewed-by: Simon Horman
Signed-off-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/flower/cmsg.c | 6 +
drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 2 +
drivers/net
From: John Hurley
Compile set tunnel actions for tc flower. Only support VXLAN and ensure a
tunnel destination port of 4789 is used.
Signed-off-by: John Hurley
Signed-off-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/flower/action.c | 169 ++---
drivers/net/ethernet
that are
currently used by rules on the device
Signed-off-by: John Hurley
Reviewed-by: Simon Horman
Signed-off-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 1 +
drivers/net/ethernet/netronome/nfp/flower/main.h | 7 ++
drivers/net/ethernet/netronome/nfp/flower
verify the connection. From an NFP perspective, packets
will not fall back mid-flow unless the link is verified to be down.
Signed-off-by: John Hurley
Reviewed-by: Simon Horman
Signed-off-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/flower/cmsg.c | 3 +
drivers/net/ethernet/net
From: John Hurley
Compile ovs-tc flower vxlan metadata match fields for offloading. Only
support offload of tunnel data when the VXLAN port specifically matches
well known port 4789.
Signed-off-by: John Hurley
Signed-off-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/flower/cmsg.h
On Mon, Sep 25, 2017 at 06:25:03PM +0300, Or Gerlitz wrote:
> On Mon, Sep 25, 2017 at 1:23 PM, Simon Horman
> wrote:
> > From: Simon Horman
> >
> > John says:
> >
> > This patch set allows offloading of TC flower match and set tunnel fields
> > to the
On Tue, Sep 26, 2017 at 09:29:03PM -0700, David Miller wrote:
> From: Simon Horman
> Date: Mon, 25 Sep 2017 12:23:34 +0200
>
> > From: Simon Horman
> >
> > John says:
> >
> > This patch set allows offloading of TC flower match and set tunnel fields
:
* Drop RFC prefix
* Correct changelogs and enhance cover letter.
Simon Horman (2):
net/sched: add tunnel option support to act_tunnel_key
net/sched: allow flower to match tunnel options
include/net/flow_dissector.h | 13
include/uapi/linux/pkt_cls.h | 3
egress redirect dev geneve0
Signed-off-by: Simon Horman
Reviewed-by: Jakub Kicinski
---
v2
* Correct example which was incorrectly described matching rather
than setting tunnel options
---
include/uapi/linux/tc_act/tc_tunnel_key.h | 1 +
net/sched/act_tunnel_key.c| 26
eth1
Signed-off-by: Simon Horman
Reviewed-by: Jakub Kicinski
---
v2
* Correct example which was incorrectly described setting rather
than matching tunnel options
---
include/net/flow_dissector.h | 13 +
include/uapi/linux/pkt_cls.h | 3 +++
net/sched/cls_flower.c | 35
l ip parent : \
> > flower \
> > enc_src_ip 10.0.99.192 \
> > enc_dst_ip 10.0.99.193 \
> > enc_key_id 11 \
> > enc_opts 0102800100800020/fff0 \
> > ip_proto udp \
> > action mirred egress redirect dev
> flower \
> >> > enc_src_ip 10.0.99.192 \
> >> > enc_dst_ip 10.0.99.193 \
> >> > enc_key_id 11 \
> >> > enc_opts 0102800100800020/fff0 \
> >> > ip_proto udp \
> >> > action mirred e
On Wed, Sep 27, 2017 at 01:08:22PM +0200, Jiri Pirko wrote:
> Wed, Sep 27, 2017 at 11:27:33AM CEST, simon.hor...@netronome.com wrote:
> >On Wed, Sep 27, 2017 at 11:10:05AM +0200, Jiri Pirko wrote:
> >> Wed, Sep 27, 2017 at 10:16:34AM CEST, simon.hor...@netronome.com wrote:
...
> >> > enum flow_di
On Wed, Sep 27, 2017 at 02:56:03PM +0200, Jiri Pirko wrote:
> Wed, Sep 27, 2017 at 02:52:06PM CEST, simon.hor...@netronome.com wrote:
> >On Wed, Sep 27, 2017 at 01:08:22PM +0200, Jiri Pirko wrote:
> >> Wed, Sep 27, 2017 at 11:27:33AM CEST, simon.hor...@netronome.com wrote:
> >> >On Wed, Sep 27, 201
On Wed, Sep 27, 2017 at 03:47:50PM +0200, Jiri Pirko wrote:
> Wed, Sep 27, 2017 at 03:37:33PM CEST, simon.hor...@netronome.com wrote:
> >On Wed, Sep 27, 2017 at 02:56:03PM +0200, Jiri Pirko wrote:
> >> Wed, Sep 27, 2017 at 02:52:06PM CEST, simon.hor...@netronome.com wrote:
> >> >On Wed, Sep 27, 201
On Wed, Sep 27, 2017 at 04:00:11PM +0200, Jiri Pirko wrote:
> Wed, Sep 27, 2017 at 03:50:44PM CEST, simon.hor...@netronome.com wrote:
> >On Wed, Sep 27, 2017 at 03:47:50PM +0200, Jiri Pirko wrote:
> >> Wed, Sep 27, 2017 at 03:37:33PM CEST, simon.hor...@netronome.com wrote:
> >> >On Wed, Sep 27, 201
On Wed, Sep 20, 2017 at 08:11:59AM -0700, Stephen Hemminger wrote:
> I noticed that the iproute man pages are up to date but the LaTex
> documentation
> is very out of date. Rarely updated since the Linux 2.2 days.
>
> Either someone needs to do a massive editing job on them, or they should just
On Thu, Sep 21, 2017 at 04:43:02PM -0700, Cong Wang wrote:
> Cc: Chris Mi
> Cc: Jamal Hadi Salim
> Signed-off-by: Cong Wang
Hi Cong,
this looks like a nice enhancement to me. Did you measure any performance
benefit from it. Perhaps it could be described in the changelog_ I also
have a more de
On Wed, Sep 13, 2017 at 08:54:00PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 09/12/2017 04:04 PM, Simon Horman wrote:
>
> >Add support for RX checksum offload. This is enabled by default and
> >may be disabled and re-enabled using ethtool:
> >
> > # etht
On Thu, Sep 28, 2017 at 03:19:05PM -0700, Cong Wang wrote:
> On Thu, Sep 28, 2017 at 12:34 AM, Simon Horman
> wrote:
> > Hi Cong,
> >
> > this looks like a nice enhancement to me. Did you measure any performance
> > benefit from it. Perhaps it could be described in
On Fri, Sep 29, 2017 at 05:54:23AM +0100, David Miller wrote:
> From: Simon Horman
> Date: Wed, 27 Sep 2017 10:16:32 +0200
>
> > Users of options:
> >
> > * There are eBPF hooks to allow getting on and setting tunnel metadata:
> > bpf_skb_set_t
Move dissection of tunnel info from the flower classifier to the flow
dissector where all other dissection occurs. This should not have any
behavioural affect on other users of the flow dissector.
Signed-off-by: Simon Horman
Reviewed-by: Jakub Kicinski
---
net/core/flow_dissector.c | 100
Move dissection of tunnel info from the flower classifier to the flow
dissector where all other dissection occurs. This should not have any
behavioural affect on other users of the flow dissector.
Simon Horman (2):
net/dst: Make skb parameter of skb{metadata_dst,tunnel_info}() const
Make the skb parameter of skb_metadata_dst() and skb_tunnel_info()
const as they are not modified. This is in preparation for using
them in call-sites where skb is const.
Signed-off-by: Simon Horman
Reviewed-by: Jakub Kicinski
---
include/net/dst_metadata.h | 5 +++--
1 file changed, 3
On Mon, Oct 02, 2017 at 12:36:33PM -0700, Tom Herbert wrote:
> On Mon, Oct 2, 2017 at 1:41 AM, Simon Horman
> wrote:
> > Move dissection of tunnel info from the flower classifier to the flow
> > dissector where all other dissection occurs. This should not have any
> &g
On Mon, Oct 02, 2017 at 01:37:55PM -0700, Tom Herbert wrote:
> On Mon, Oct 2, 2017 at 1:41 AM, Simon Horman
> wrote:
> > Move dissection of tunnel info from the flower classifier to the flow
> > dissector where all other dissection occurs. This should not have any
> &g
-off-by: Simon Horman
---
v2
Address review of v1 by Sergei Shtylyov
* set features rather than oring them with (zero) existing values:
* Set/unset using a single call to ravb_modify()
---
drivers/net/ethernet/renesas/ravb_main.c | 55 +++-
1 file changed, 54 insertions
On Tue, Oct 03, 2017 at 11:17:46AM -0700, Tom Herbert wrote:
> On Tue, Oct 3, 2017 at 2:40 AM, Simon Horman
> wrote:
> > On Mon, Oct 02, 2017 at 01:37:55PM -0700, Tom Herbert wrote:
> >> On Mon, Oct 2, 2017 at 1:41 AM, Simon Horman
> >> wrote:
> >> &g
ue, Oct 03, 2017 at 11:17:46AM -0700, Tom Herbert wrote:
> >>>> On Tue, Oct 3, 2017 at 2:40 AM, Simon Horman
> >>>> wrote:
> >>>> > On Mon, Oct 02, 2017 at 01:37:55PM -0700, Tom Herbert wrote:
> >>>> >> On Mon, Oct 2, 2017 at
On Wed, Sep 12, 2018 at 01:53:14AM +0200, Andrew Lunn wrote:
> Some MAC hardware cannot support a subset of link modes. e.g. often
> 1Gbps Full duplex is supported, but Half duplex is not. Add a helper
> to remove such a link mode.
>
> Signed-off-by: Andrew Lunn
> Reviewed-by: Florian Fainelli
>
On Mon, Sep 17, 2018 at 05:38:11PM +0200, Andrew Lunn wrote:
> On Mon, Sep 17, 2018 at 05:13:07PM +0200, Simon Horman wrote:
> > On Wed, Sep 12, 2018 at 01:53:14AM +0200, Andrew Lunn wrote:
> > > Some MAC hardware cannot support a subset of link modes. e.g. often
> >
:54 -0500
> Subject: [PATCH] ravb: Disable Pause Advertisement
>
> The previous commit to ravb had the side effect of making the PHY
> advertise Pause. This previously did not happen, and it appears the
> MAC does not support Pause. By default, phydev->supported has Pause
> en
John Hurley says:
This patchset adds support for offloading the encap and decap of Geneve
tunnels to the NFP. In both cases, specifying well known port 6081 is a
requirement for rule offload.
Geneve firmware support has been recently added, so the patchset includes
the reading of a fw symbol that
attempt to offload if the fw supports Geneve.
Signed-off-by: John Hurley
Reviewed-by: Jakub Kicinski
Signed-off-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/flower/action.c | 75 +-
drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 11 ++--
2 files changed, 48
-by: Jakub Kicinski
Signed-off-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 32 -
drivers/net/ethernet/netronome/nfp/flower/main.h | 9 +++-
drivers/net/ethernet/netronome/nfp/flower/match.c | 55 +-
.../net/ethernet/netronome/nfp
.
Signed-off-by: John Hurley
Reviewed-by: Jakub Kicinski
Signed-off-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/flower/main.c | 10 +-
drivers/net/ethernet/netronome/nfp/flower/main.h | 2 ++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet
function
is then no longer required to return the IP separately.
Because tun_dst is localised to tunnel matches, move the declaration to
the tunnel if branch.
Signed-off-by: John Hurley
Reviewed-by: Jakub Kicinski
Signed-off-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/flower/match.c
t (like we
do for promisc flag). The lack of L2MC capability is
assumed to mean all multicast traffic goes through.
Signed-off-by: Jakub Kicinski
Signed-off-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
di
On Thu, Jan 04, 2018 at 04:10:19PM +0100, Simon Horman wrote:
> From: Jakub Kicinski
>
> We currently always pass all multicast traffic through.
> Only set L2MC when actually needed. Since the driver
> was not making use of the capability to filter out mcast
> frames, some
Jiri Pirko
> Signed-off-by: Paul Blakey
Reviewed-by: Simon Horman
iority")
> Reported-by: Vlad Buslov
> Reviewed-by: Roi Dayan
> Reviewed-by: Jiri Pirko
> Signed-off-by: Paul Blakey
Reviewed-by: Simon Horman
Hemminger
Reviewed-by: Simon Horman
he commit message, thanks Hangbin Liu
>
> Fixes: fa1b1cff3d06 ("net_cls_act: Make act_simple use of netlink policy.")
> Signed-off-by: Davide Caratti
Reviewed-by: Simon Horman
On Fri, Jun 08, 2018 at 09:20:37AM -0700, Eric Biggers wrote:
> From: Eric Biggers
>
> My recent fix for dns_resolver_preparse() printing very long strings was
> incomplete, as shown by syzbot which still managed to hit the
> WARN_ONCE() in set_precision() by adding a crafted "dns_resolver" key:
On Mon, Jun 11, 2018 at 10:57:42AM -0700, Eric Biggers wrote:
> Hi Simon,
>
> On Mon, Jun 11, 2018 at 11:40:23AM +0200, Simon Horman wrote:
> > On Fri, Jun 08, 2018 at 09:20:37AM -0700, Eric Biggers wrote:
> > > From: Eric Biggers
> > >
> > > My recen
gt; out to offloaded and non-offloaded. Users seem to like those a lot.
>
> Next there is a statistic for decryption errors. These are primarily
> useful for device offload debug, in normal deployments decryption
> errors should not be common.
>
> Last but not least a counter for dev
On Thu, Oct 03, 2019 at 02:57:59PM -0700, Tom Herbert wrote:
> From: Tom Herbert
>
> Move generic functions in exthdrs.c to new exthdrs_common.c so that
> exthdrs.c only contains functions that are specific to IPv6 processing,
> and exthdrs_common.c contains functions that are generic. These
> fu
net/ipeh.h to contain common definitions for IP extension
> headers.
>
> Signed-off-by: Tom Herbert
Hi Tom,
I'm not entirely clear on the direction this patchset it going in -
I assume its part of a larger journey - but in isolation this
patch seems fine to me.
Reviewed-by: Simon Horman
On Thu, Oct 03, 2019 at 02:58:00PM -0700, Tom Herbert wrote:
> From: Tom Herbert
>
> Create a generic TLV parser. This will be used with various
> extension headers that carry options including Destination,
> Hop-by-Hop, Segment Routing TLVs, and other cases of simple
> stateless parsing.
>
> Si
101 - 200 of 1311 matches
Mail list logo
