Re: [PATCH 2/3] build: add --disable-libdir-abi-detection

2019-06-26 Thread Jeffrey Walton
On Wed, Jun 26, 2019 at 12:43 PM Niels Möller wrote: > > Jeffrey Walton writes: > > >> From which autoconf version? I'd be happy to require a recent autoconf > >> and drop this code if it's no longer needed. When this hack was added, > >> it was the case that one or the other of > > > > Please

Re: [PATCH 2/3] build: add --disable-libdir-abi-detection

2019-06-26 Thread Niels Möller
Dmitry Eremin-Solenikov writes: > What about just checking if libdir was overwritten via argument and not > touching it if it was the case? Will that work for you? That's exactly how it has worked ever since this detection was added back in 2010. Which is why I suggest that packagers who find

Re: [PATCH 2/3] build: add --disable-libdir-abi-detection

2019-06-26 Thread Niels Möller
Jeffrey Walton writes: >> From which autoconf version? I'd be happy to require a recent autoconf >> and drop this code if it's no longer needed. When this hack was added, >> it was the case that one or the other of > > Please NO. Don't require an updated Autotools version. Huh? The configure

Re: [PATCH 2/3] build: add --disable-libdir-abi-detection

2019-06-26 Thread Alon Bar-Lev
On Wed, Jun 26, 2019 at 6:08 PM Dmitry Eremin-Solenikov wrote: > > ср, 26 июн. 2019 г. в 17:00, Alon Bar-Lev : > > > > On Wed, Jun 26, 2019 at 4:53 PM Jeffrey Walton wrote: > > > > > > On Wed, Jun 26, 2019 at 9:45 AM Niels Möller wrote: > > > > > > > > ... > > > > From which autoconf version?

Re: [PATCH 2/3] build: add --disable-libdir-abi-detection

2019-06-26 Thread Alon Bar-Lev
On Wed, Jun 26, 2019 at 4:53 PM Jeffrey Walton wrote: > > On Wed, Jun 26, 2019 at 9:45 AM Niels Möller wrote: > > > > ... > > From which autoconf version? I'd be happy to require a recent autoconf > > and drop this code if it's no longer needed. When this hack was added, > > it was the case that

Re: [PATCH 2/3] build: add --disable-libdir-abi-detection

2019-06-26 Thread Niels Möller
Alon Bar-Lev writes: > You should not do this in autoconf, autoconf is already detecting > everything that is required, From which autoconf version? I'd be happy to require a recent autoconf and drop this code if it's no longer needed. When this hack was added, it was the case that one or the

Re: [PATCH 2/3] build: add --disable-libdir-abi-detection

2019-06-26 Thread Niels Möller
Alon Bar-Lev writes: > opt out overriding the libdir, in most cases downstream distribution is > providing the correct one > > Signed-off-by: Alon Bar-Lev > --- > configure.ac | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index