[PATCH] ModemManager: Icera CID handling without an APN

2011-05-12 Thread Nathan Williams
In mm-generic-gsm.c, if an APN is not provided as a property to simple_connect(), priv->cid is never set and remains at -1. The Icera modem plugin has a _get_cid() wrapper call which checks for this and returns 0 if the stored CID is -1. There are two problems with this: * 0 is not a valid CID; a

[PATCH] ModemManager: Split the Samsung initialization sequence so that echoing is properly disabled

2011-05-12 Thread Nathan Williams
We were sometimes seeing the IMSI reported as "AT+CIMI\n\r\n\r31026..." because echoing was not always turned off at the point that the IMSI is requested. This patch fixes that by splitting the reset commands so that the second part of the command gets processed after the reset is complete. (This w

[PATCH 3/3] ADSL: Add libnm-glib and nmcli code

2011-05-12 Thread Pantelis Koukousoulas
For the finale, this is the libnm-glib and nmcli part of the support, with this you can now make a full pppoatm connection from NetworkManager by configuring it in system scope in a keyfile. As an example, here is mine: (password and username snipped for obvious reasons) [connection] id=MYISP uui

ADSL: Carrier Handling and PPP support

2011-05-12 Thread Pantelis Koukousoulas
This is the "juice" of the patch series. Initial cut at carrier handling (by polling /sys/class/atm/$iface/carrier) and also support for calling pppd with the proper command-line to achieve a connection. Also implement the necessary boilerplate for the NM state machine to be happy with our device.

[PATCH 1/3] ADSL: Settings and initial "scaffolding"

2011-05-12 Thread Pantelis Koukousoulas
This patch adds the settings code (NMSettingAdsl) and the initial "scaffolding" i.e., a tiny stub version of NMDeviceAdsl and the udev handler code to get the device detected. With this patch you should be able to see an atm device being detected by networkmanager in the logs, although of course i

[PATCH 0/3] Support for ADSL modems v2

2011-05-12 Thread Pantelis Koukousoulas
This is the second version, respinned with suggestions from first round implemented. More specifically: * Fixed the parenthesis-related coding style bugs (hope I found all of them) * Settings for Encapsulation and Protocol now lowercased * Add checks in settings verify() for VCI/VPI nu

Re: What about the patch for USB gadgets?

2011-05-12 Thread Dan Williams
On Wed, 2011-05-11 at 15:11 +0200, W. Martin Borgert wrote: > Hi, > > there was a patch sent to the list in February: > > http://mail.gnome.org/archives/networkmanager-list/2011-February/msg00152.html > > However, I can't find any reaction on the list, neither > approval nor rejection. Can someo

Re: ModemManager: MMCallbackInfo scheduled twice when device removed

2011-05-12 Thread Aleksander Morgado
> > > > Each MMCallbackInfo holds a weak reference to the MMModem to which the > > AT command was sent. When the MMModem is destroyed, > > mm-callback-info.c::modem_destroyed_cb() gets called and the modem > > pointer in the callback info is reset to NULL, to avoid having a pointer > > to an alre

Re: What about the patch for USB gadgets?

2011-05-12 Thread Thomas Bechtold
Hi Dan, On 12/05/11 04:55, Dan Williams wrote: A quick question on these, are they properly represented in sysfs or are they "virtual" devices? Given that they are USB connected it would seem they should be properly presented, even in the case of platform drivers since there has to be a USB tre