Re: NetworkManager Build System

2020-08-25 Thread Iñigo Martínez via networkmanager-list
Ok, forgot my last mail. I read the mail wrong and also forgot NM's requirement to build it on systems without python3. Sorry, El mar., 25 ago. 2020 a las 14:56, Iñigo Martínez () escribió: > Although meson needs python 3 to work, meson's Python module[0] can be > also used to w

Re: NetworkManager Build System

2020-08-25 Thread Iñigo Martínez via networkmanager-list
Although meson needs python 3 to work, meson's Python module[0] can be also used to work with python2 code. BTW, I still have a couple of meson only (I mean, my changes were only meson oriented) updates for NetworkManager around. These changes remove autotools and also moves NM to the latest gette

Re: How to Build Network Manager ?

2020-01-26 Thread Iñigo Martínez via networkmanager-list
Hi, I can also provide some assistance regarding meson if necessary. The first step would be to execute meson in the cloned NM repository providing a build directory. Something like `meson _build`. If this step is successful, you would then execute ninja to build it providing the previously used

Re: Collect agreement/disagreement to Relicense NetworkManager under LGPL-2.1+

2020-01-14 Thread Iñigo Martínez via networkmanager-list
those that have modified the files, this is the list of involved authors: Antonio Cardace Beniamino Galvani Benjamin Berg Christian Kellner Corentin Noël Francesco Giudici Iñigo Martínez Jan Alexander Steffens (heftig) Jan Tojnar Javier Arteaga Lubomir Rintel Michael Biebl Soapux Taegil Bae Thomas

Re: Collect agreement/disagreement to Relicense NetworkManager under LGPL-2.1+

2020-01-10 Thread Iñigo Martínez via networkmanager-list
Hi, What about meson build files? Although usually the license is not included, there are some exceptions that they do[0]. If necessary, I also agree with relicensing. BR, [0] https://github.com/systemd/systemd/blob/master/meson.build El jue., 9 ene. 2020 a las 15:40, Dan Williams via networkm

[PATCH 3/4] meson: Fix missing symbols in libnm-glib

2018-01-11 Thread Iñigo Martínez
The following symbols are missing from the libnm-glib library: * libnm_glib_get_network_state * libnm_glib_init * libnm_glib_register_callback * libnm_glib_shutdown * libnm_glib_unregister_callback This has been changed by linking `libdeprecated_nm_glib` as a whole. --- libnm-glib/meson.build |

[PATCH 4/4] build: Rename settings-docs.c file

2018-01-11 Thread Iñigo Martínez
The `settings-docs.c` file is generated by processing the `nm-property-docs.xml` file. Although this works in autotools, the `.c` extension makes meson not to handle it properly. Given the fact that it only contains a number of defines it makes sense to change its extension to `.h` an use it as a

[PATCH 1/4] meson: Reuse linker script strings

2018-01-11 Thread Iñigo Martínez
There are some linker scripts which are used at link time. These are not modified very much, so by using variables with already formatted string can increase meson's parsing time. Preformatted strings have been used for `binary`, `device` and `settings` link scripts. Those link scripts which are

[PATCH 2/4] meson: Slightly simplify jansson soname retrieval

2018-01-11 Thread Iñigo Martínez
The process for retrieving jansson's soname has been slightly simplified. --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 1a2d3b97b..ec283a96c 100644 --- a/meson.build +++ b/meson.build @@ -188,8 +188,7 @@ config_h.set10('WITH_J

[PATCH] build: Add meson build files to distributable files

2018-01-09 Thread Iñigo Martínez
Hi, Although meson has some interesting benefits, it still has some stilshortcomings compared to autotools. While both build systems coexists, this patch adds meson build files as autotools distributable files, so they are also packed when generating the distributable file. BR, From 983ef983c84f

[PATCH] meson: Improve dependency system

2018-01-07 Thread Iñigo Martínez
Some targets are missing dependencies on some generated sources in the meson port. These makes the building fail due to missing source files on a highly multithreaded building. These dependencies have been resolved by taking advantage of meson's internal dependencies and reviewing the whole meson

[PATCH 2/2] dhcp: Add missing include to systemd DHCP client

2018-01-05 Thread Iñigo Martínez
In a recent commit 686afe531ab3774cd818feda8361de74101971f5, a new macro called `_NM_SD_MAX_CLIENT_ID_LEN` was introduced. However, the systemd DHCP client handler did not include the file where the macro was defined, `nm-types.h`. Although this worked in autotools, it fails on meson. The include

[PATCH 1/2] ifcfg: test for sysconfig network path also on meson

2018-01-05 Thread Iñigo Martínez
In a recent commit 1402fa7487b29fc1ea39a6bf7659fee7f30bb0e0 a new way for testing Red Hat compatible distributions had been added. This new testing approach has also been added to meson. --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meson.build b/meson.buil

[PATCH 2/2] build: Workaround for gtkdoc dependencies

2017-12-24 Thread Iñigo Martínez
gtkdoc uses some custom generated targets as content files. However, there are still two problem. The first is that gtkdoc does not support targets which are not strings. This is being fixed in the following issue: https://github.com/mesonbuild/meson/pull/2806 The second issue is that the gtkdoc

[PATCH 1/2] build: Remove default install directories

2017-12-24 Thread Iñigo Martínez
The install directories of those targets that match the default install directories have been removed because they are redundant. This also allows a simple meson build files and it is unnecessary to create some paths. --- clients/cli/meson.build | 3 +-- clients/meson.build | 3 +--

[PATCH] build: Enable unused-but-set warning in meson

2017-12-18 Thread Iñigo Martínez
The unused-but-set warning has recently been enabled in autotools (e912b36d95a3c26a6021eeb27e663bd05910a9b4), so this also modifies meson to enable it. --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index 6d0b29592..11e6cdd90 100644 --- a/meson.build +

[PATCH] build: Remove documentation generation workarounds

2017-12-18 Thread Iñigo Martínez
Documentation was not working in meson due to problems with files generated in `libnm`. To avoid these problems, workarounds were used. This problems have been recently fixed so these workarounds are not necessary anymore. --- clients/common/meson.build | 4 +--- docs/api/meson.build | 4 +--

[PATCH] build: Move default path values to options file

2017-12-18 Thread Iñigo Martínez
Since meson 0.44 there is a new option type called `array`, which allows to use an array with different values in those options. These fits the needs of different options that are used to pass binary paths, which have multiple paths as an alternate locations. meson's version has been bumped to 0.

[PATCH] build: Drop HAVE_VLAN_FLAG_LOOSE_BINDING

2017-12-18 Thread Iñigo Martínez
Both meson and autotools define HAVE_VLAN_FLAG_LOOSE_BINDING to 1 or 0 depending if a small code snippet is compiled. However, this define is not used anymore. --- config.h.meson | 3 --- configure.ac | 22 -- meson.build| 15 --- 3 files changed, 40 deletion

[PATCH] build: Use template files for enum types' sources generation

2017-12-16 Thread Iñigo Martínez
Source files for enum types are generated by passing segments of the source code of the files to the `glib-mkenums` command. This patch removes those parameters where source code is used from meson build files by moving those segmeents to template files. --- clients/cli/meson.build

[PATCH 2/2] build: Merge no introspection headers with public headers

2017-12-15 Thread Iñigo Martínez
There are three headers `nm-secret-agent-old.h`, `nm-vpn-plugin-old.h`, and `nm-vpn-service-plugin.h`, which are named as no introspection headers. However, these files also join to the rest headers to generate introspection data. This patch merges those no introspection headers with the public he

[PATCH 1/2] build: Make generate-plugin-docs.pl independent of autotools

2017-12-15 Thread Iñigo Martínez
`generate-plugin-docs.pl` script which is used to parse `nm-setting-c*.c` files depends on autotools. This is because it parses the `Makefile.am` in order to figure out the setting files it needs to parse. This patch makes the script independent of autotools by passing the necessary setting files

[PATCH 1/3] build: Fix libnm_linking test

2017-12-14 Thread Iñigo Martínez
The `libnm_linking` test that belongs to the libnm-util's general tests is failing because the test is not able to find the `test-libnm-linking` binary, which is executed as a child process. The problem lies to the `BUILD_DIR` macro definition which is used to set the place to find the binary, and

[PATCH 3/3] build: Rename unit tests with the `test-` pattern

2017-12-14 Thread Iñigo Martínez
There are some tests located in different directories which are using the same name. To avoid any confussion a prefix was used to name the test and the target. This patch uses the prefix just for the target, to avoid any collision that may happen, and uses the `test-` pattern as the name. --- cli

[PATCH 2/3] build: Fix test-ndisc-linux test

2017-12-14 Thread Iñigo Martínez
The `test-ndisc-linux` test is being run as an unit test. However, it is not meant to be run as one of them. This patch simply builts it as not installable binary. --- src/ndisc/tests/meson.build | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --gi

Re: [PATH 1/2] build: Library paths as parameters for generate-settings-docs.py

2017-12-14 Thread Iñigo Martínez
Thanks! I was thinking on using the `add_argument`'s `default` parameter, but I must have forgotten it. Best regards, 2017-12-14 15:26 GMT+01:00 Thomas Haller : > On Thu, 2017-12-14 at 12:58 +0100, Iñigo Martínez wrote: >> The following two patches fix the problem with the gen

[PATCH 2/2] build: Fix targets generated by generate-settings-docs.py

2017-12-14 Thread Iñigo Martínez
This patch uses the recently added `--lib-path` parameter to pass the `libnm`'s built directory, which allows the proper generation of the files in meson. For correctness, the `libnm` target has also been added as dependency for both targets, even though there is an indirect dependency through `li

[PATH 1/2] build: Library paths as parameters for generate-settings-docs.py

2017-12-14 Thread Iñigo Martínez
The following two patches fix the problem with the generation of the `nm-settings-docs.xml` and `nm-property-docs.xml` files, which made the meson build port to fail when documentation generation was enabled. This patch adds a new optional parameter, `-l` or `--lib-path` that can be used to pass d

Re: Port NetworkManager to meson

2017-11-08 Thread Iñigo Martínez
2017-11-08 18:56 GMT+01:00 Colin Helliwell : > >> On 08 November 2017 at 16:54 Thomas Haller wrote: >> >> On Wed, 2017-11-08 at 13:40 +0100, Iñigo Martínez wrote: >> >> > Hi all, >> > >> > These past few months I have been porting some l

Re: Port NetworkManager to meson

2017-11-08 Thread Iñigo Martínez
2017-11-08 17:54 GMT+01:00 Thomas Haller : > On Wed, 2017-11-08 at 13:40 +0100, Iñigo Martínez wrote: >> Hi all, >> >> These past few months I have been porting some libraries and >> applications to meson build system[0], within the "MesonPorting" >> init

Port NetworkManager to meson

2017-11-08 Thread Iñigo Martínez
Hi all, These past few months I have been porting some libraries and applications to meson build system[0], within the "MesonPorting" initiative[1] that tries to port packages under GNOME umbrella to meson. As you may know, meson is a new build system which offers some benefits over autotools, of