Re: [patch NetworkManager] ifcfg-rh writer: do not se TYPE for team ports

Mon, Mar 10, 2014 at 07:11:01PM CET, d...@redhat.com wrote: >On Sat, 2014-03-08 at 12:48 +0100, Jiri Pirko wrote: >> The problem is that initscripts rewrite DEVICETYPE in case TYPE is specified >> which prevents team port from being configured. Fix this by removing TYPE. >> &

[patch NetworkManager] ifcfg-rh reader: assume type for Team ports

Initscripts compatibility requires that if DEVICETYPE is set, TYPE shall not be set. So do something similar we already do for Team masters for Team ports. Signed-off-by: Jiri Pirko --- src/settings/plugins/ifcfg-rh/reader.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/settings

[patch NetworkManager] ifcfg-rh writer: do not se TYPE for team ports

The problem is that initscripts rewrite DEVICETYPE in case TYPE is specified which prevents team port from being configured. Fix this by removing TYPE. Signed-off-by: Jiri Pirko diff --git a/src/settings/plugins/ifcfg-rh/writer.c b/src/settings/plugins/ifcfg-rh/writer.c index baa851a..b687bee

Re: [PATCH] team: read team port configuration when generating connections

Wed, Nov 13, 2013 at 09:25:03PM CET, d...@redhat.com wrote: >Now that libteam 1.9 can return port configuration, use it. This >bumps the requirement to libteam 1.9. Acked-by: Jiri Pirko >--- > configure.ac | 2 +- > src/devices/nm-dev

Re: [patch NetworkManager 0/4] adjust virtual interface name according to connection interface name

Wed, Nov 06, 2013 at 01:17:38PM CET, thal...@redhat.com wrote: >On Wed, 2013-09-25 at 15:37 +0200, Jiri Pirko wrote: >> So far, we have 2 properties for interface name, connection.interface-name >> and bond/bridge/team.interface-name. If user wants to change it, he need to >&

Re: [patch NetworkManager 0/4] adjust virtual interface name according to connection interface name

f user wants to change it, he need to >change both. This patchset adjusts the bond/bridge/team property so >it is the same as the connection one. > >Jiri Pirko (4): > nm-setting: adjust virtual interface name according to connection >interface name > nm-setting-bond: imple

Re: [patch network-manager-applet v2] add support for team devices

Wed, Sep 25, 2013 at 04:46:48PM CEST, d...@gnome.org wrote: >On 09/16/2013 03:28 AM, Jiri Pirko wrote: >> Hi, any comments please? I discussed this with jklimes and he seems >> happy with it. > >Sorry for the delay. Mostly good, and I see jklimes already fixed some >th

[patch NetworkManager 4/4] nm-setting-team: implement set_virtual_iface_name()

Signed-off-by: Jiri Pirko --- libnm-util/nm-setting-team.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/libnm-util/nm-setting-team.c b/libnm-util/nm-setting-team.c index fa0cebb..a7f45e4 100644 --- a/libnm-util/nm-setting-team.c +++ b/libnm-util/nm

[patch NetworkManager 3/4] nm-setting-bridge: implement set_virtual_iface_name()

Signed-off-by: Jiri Pirko --- libnm-util/nm-setting-bridge.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/libnm-util/nm-setting-bridge.c b/libnm-util/nm-setting-bridge.c index 64d3fc8..f7b362d 100644 --- a/libnm-util/nm-setting-bridge.c +++ b

[patch NetworkManager 2/4] nm-setting-bond: implement set_virtual_iface_name()

Signed-off-by: Jiri Pirko --- libnm-util/nm-setting-bond.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/libnm-util/nm-setting-bond.c b/libnm-util/nm-setting-bond.c index 005bf89..e0b53c7 100644 --- a/libnm-util/nm-setting-bond.c +++ b/libnm-util/nm

[patch NetworkManager 1/4] nm-setting: adjust virtual interface name according to connection interface name

Signed-off-by: Jiri Pirko --- libnm-util/nm-setting-connection.c | 3 ++- libnm-util/nm-setting.c| 21 + libnm-util/nm-setting.h| 2 ++ 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/libnm-util/nm-setting-connection.c b/libnm-util/nm

[patch NetworkManager 0/4] adjust virtual interface name according to connection interface name

So far, we have 2 properties for interface name, connection.interface-name and bond/bridge/team.interface-name. If user wants to change it, he need to change both. This patchset adjusts the bond/bridge/team property so it is the same as the connection one. Jiri Pirko (4): nm-setting: adjust

Re: [patch network-manager-applet] add support for team devices

Wed, Sep 04, 2013 at 02:26:23PM CEST, jkli...@redhat.com wrote: >On Tuesday 03 of September 2013 16:57:05 Jiri Pirko wrote: >> Signed-off-by: Jiri Pirko >> --- >> src/Makefile.am | 2 + >> src/applet-device-team.c | 1

Re: [patch NetworkManager 00/11] team driver related updates and fixes

Thu, Aug 22, 2013 at 03:47:24PM CEST, d...@gnome.org wrote: >I committed the non-nmcli parts (with three small fixes: added spaces >before "(" in function calls [eg, "teamdctl_alloc ()"], fixed a build >error when building without libteamdctl ["error: unused variable >'priv'"], and made a minor gra

[patch NetworkManager v2 2/2] ifcfg-rh: add test for BOOTPROTO=none reader

Signed-off-by: Jiri Pirko --- .../ifcfg-rh/tests/network-scripts/ifcfg-test-noip | 3 ++ .../plugins/ifcfg-rh/tests/test-ifcfg-rh.c | 47 ++ 2 files changed, 50 insertions(+) create mode 100644 src/settings/plugins/ifcfg-rh/tests/network-scripts/ifcfg-test-noip

[patch NetworkManager v2 1/2] ifcfg-rh: reader: allow device to not have ipv4 setting.

If BOOTPROTO is set to "none", user states that no ipv4 setting should be set. So respect that. Introduce helper is_any_ip4_address_defined() along the way to make the code more readable. Signed-off-by: Jiri Pirko --- libnm-util/nm-setting-ip4-config.c | 27 - lib

[patch NetworkManager v2 0/2] ifcfg-rh: reader: allow device to not have ipv4 setting.

v1->v2: - Processed DanW's comments - added test case Jiri Pirko (2): ifcfg-rh: reader: allow device to not have ipv4 setting. ifcfg-rh: add test for BOOTPROTO=none reader libnm-util/nm-setting-ip4-config.c | 27 -- libnm-util/nm-setting-ip6-

Re: [patch NetworkManager] ifcfg-rh: reader: allow device to do not have ipv4 setting.

Wed, Aug 21, 2013 at 06:08:19PM CEST, d...@gnome.org wrote: >You should add a test case to test-ifcfg-rh for this, to make sure we >don't break it later. Will try. > > >Other than that, just nitpicks: > >Drop the word "do" in the commit summary line. > >> +static gchar *get_numbered_tag (gchar *t

[patch NetworkManager] ifcfg-rh: reader: allow device to do not have ipv4 setting.

If BOOTPROTO is set to "none", user states that no ipv4 setting should be set. So respect that. Introduce helper is_any_ip4_address_defined() along the way to make the code more readable. Signed-off-by: Jiri Pirko --- libnm-util/nm-setting-ip4-config.c | 27 - lib

Re: [patch NetworkManager 00/11] team driver related updates and fixes

Fri, Aug 16, 2013 at 10:59:24PM CEST, d...@redhat.com wrote: >On Fri, 2013-08-16 at 15:33 +0200, Jiri Pirko wrote: >> Jiri Pirko (11): >> cli: add team and team-slave detail printing >> cli: add team port setting >> cli: add config option for team devices

[patch NetworkManager 07/11] team: use libteamdctl to update port config before enslave

Signed-off-by: Jiri Pirko --- src/devices/nm-device-team.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/devices/nm-device-team.c b/src/devices/nm-device-team.c index 797b2ec..187f02e 100644 --- a/src/devices/nm-device-team.c +++ b/src/devices/nm-device

[patch NetworkManager 11/11] cli: add missed setting name to nmc_team_slave_settings

Signed-off-by: Jiri Pirko --- cli/src/connections.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cli/src/connections.c b/cli/src/connections.c index 6c5e625..d3b2cdd 100644 --- a/cli/src/connections.c +++ b/cli/src/connections.c @@ -1891,6 +1891,7 @@ static const NameItem

[patch NetworkManager 10/11] team: kill existing teamd for same device name during teamd start phase

Signed-off-by: Jiri Pirko --- src/devices/nm-device-team.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/devices/nm-device-team.c b/src/devices/nm-device-team.c index 187f02e..b37502d 100644 --- a/src/devices/nm-device-team.c +++ b/src/devices/nm-device-team.c

[patch NetworkManager 09/11] nm-manager: fix goto in system_create_virtual_device() in team section

Signed-off-by: Jiri Pirko --- src/nm-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nm-manager.c b/src/nm-manager.c index efcde4a..8c1040c 100644 --- a/src/nm-manager.c +++ b/src/nm-manager.c @@ -1338,7 +1338,7 @@ system_create_virtual_device (NMManager *self

[patch NetworkManager 08/11] nm-manager: do not fail if team device already exists

Similar has been done with bond and bridge Signed-off-by: Jiri Pirko --- src/nm-manager.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/nm-manager.c b/src/nm-manager.c index 35f17ff..efcde4a 100644 --- a/src/nm-manager.c +++ b/src/nm-manager.c @@ -1334,7 +1334,8

[patch NetworkManager 06/11] nm-device-team: use libteamdctl

Signed-off-by: Jiri Pirko --- src/Makefile.am | 8 src/devices/nm-device-team.c | 28 +++- 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 8370e5a..c90c12c 100644 --- a/src/Makefile.am +++ b/src

[patch NetworkManager 05/11] add libteamdctl for configure.ac

Signed-off-by: Jiri Pirko --- configure.ac | 20 1 file changed, 20 insertions(+) diff --git a/configure.ac b/configure.ac index 5ab5b38..2fcbce6 100644 --- a/configure.ac +++ b/configure.ac @@ -366,6 +366,25 @@ else fi AM_CONDITIONAL(WITH_WIMAX, test "${enable_

[patch NetworkManager 04/11] ifcfg-rh writer: write DEVICETYPE for all team ports

even for that which does not have settings Signed-off-by: Jiri Pirko --- src/settings/plugins/ifcfg-rh/writer.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/settings/plugins/ifcfg-rh/writer.c b/src/settings/plugins/ifcfg-rh/writer.c index 99e7812..891a9c2 100644

[patch NetworkManager 03/11] cli: add config option for team devices

Signed-off-by: Jiri Pirko --- cli/src/connections.c | 8 1 file changed, 8 insertions(+) diff --git a/cli/src/connections.c b/cli/src/connections.c index b8e1061..6c5e625 100644 --- a/cli/src/connections.c +++ b/cli/src/connections.c @@ -2741,6 +2741,12 @@ cleanup_vlan

[patch NetworkManager 02/11] cli: add team port setting

Signed-off-by: Jiri Pirko --- cli/src/connections.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/cli/src/connections.c b/cli/src/connections.c index f0f26eb..b8e1061 100644 --- a/cli/src/connections.c +++ b/cli/src/connections.c @@ -2151,6 +2151,7

[patch NetworkManager 01/11] cli: add team and team-slave detail printing

Signed-off-by: Jiri Pirko --- cli/src/settings.c | 82 ++ 1 file changed, 82 insertions(+) diff --git a/cli/src/settings.c b/cli/src/settings.c index 7594792..cd45afd 100644 --- a/cli/src/settings.c +++ b/cli/src/settings.c @@ -598,6 +598,29

[patch NetworkManager 00/11] team driver related updates and fixes

Jiri Pirko (11): cli: add team and team-slave detail printing cli: add team port setting cli: add config option for team devices ifcfg-rh writer: write DEVICETYPE for all team ports add libteamdctl for configure.ac nm-device-team: use libteamdctl team: use libteamdctl to update port

[patch NetworkManager v3 6/6] nm-device-team: spawn teamd for team device connection

Signed-off-by: Jiri Pirko --- src/devices/nm-device-team.c | 280 ++- 1 file changed, 279 insertions(+), 1 deletion(-) diff --git a/src/devices/nm-device-team.c b/src/devices/nm-device-team.c index 320b659..d920f9d 100644 --- a/src/devices/nm-device

[patch NetworkManager v3 0/6] add support for network team devices

TER_TO_INT (no need for extra structure) Jiri Pirko (6): add support for team device add setting for team port ifcfg: add read support for team devices ifcfg: add write support for team devices cli: add team driver support nm-device-team: spawn teamd for team device conne

[patch NetworkManager v3 2/6] add setting for team port

Signed-off-by: Jiri Pirko --- libnm-util/Makefile.am| 2 + libnm-util/libnm-util.ver | 5 ++ libnm-util/nm-connection.c| 17 libnm-util/nm-connection.h| 2 + libnm-util/nm-setting-team-port.c | 174 ++ libnm-util

[patch NetworkManager v3 3/6] ifcfg: add read support for team devices

Signed-off-by: Jiri Pirko --- src/settings/plugins/ifcfg-rh/reader.c | 163 + 1 file changed, 147 insertions(+), 16 deletions(-) diff --git a/src/settings/plugins/ifcfg-rh/reader.c b/src/settings/plugins/ifcfg-rh/reader.c index 650f711..6dde8e8 100644 --- a/src

[patch NetworkManager v3 4/6] ifcfg: add write support for team devices

Signed-off-by: Jiri Pirko --- src/settings/plugins/ifcfg-rh/writer.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/src/settings/plugins/ifcfg-rh/writer.c b/src/settings/plugins/ifcfg-rh/writer.c index 810b526..6ed6921 100644 --- a/src/settings/plugins

[patch NetworkManager v3 5/6] cli: add team driver support

Signed-off-by: Jiri Pirko --- cli/src/connections.c | 132 ++ 1 file changed, 113 insertions(+), 19 deletions(-) diff --git a/cli/src/connections.c b/cli/src/connections.c index 9c11b6d..4d6cb7e 100644 --- a/cli/src/connections.c +++ b/cli/src

Re: [patch NetworkManager v2 6/6] nm-device-team: spawn teamd for team device connection

Wed, Jul 24, 2013 at 07:23:51PM CEST, d...@redhat.com wrote: >On Wed, 2013-07-24 at 07:37 +0200, Jiri Pirko wrote: >> Wed, Jul 24, 2013 at 01:53:56AM CEST, d...@redhat.com wrote: >> >On Mon, 2013-07-15 at 09:46 +0200, Jiri Pirko wrote: >> >> Signed-off-by: Jiri Pirko

Re: [patch NetworkManager v2 2/6] add setting for team port

Wed, Jul 24, 2013 at 01:26:00AM CEST, d...@redhat.com wrote: >On Mon, 2013-07-15 at 09:46 +0200, Jiri Pirko wrote: >> Signed-off-by: Jiri Pirko >> --- >> libnm-util/Makefile.am| 2 + >> libnm-util/libnm-util.ver | 5 ++ >> libnm-

Re: [patch NetworkManager v2 6/6] nm-device-team: spawn teamd for team device connection

Wed, Jul 24, 2013 at 01:53:56AM CEST, d...@redhat.com wrote: >On Mon, 2013-07-15 at 09:46 +0200, Jiri Pirko wrote: >> Signed-off-by: Jiri Pirko >> --- >> src/devices/nm-device-team.c | 283 >> ++- >> 1 file chang

Re: [patch NetworkManager v2 0/6] add support for network team devices

fig setup). That I want to add once this patchset gets applied. > >v1->v2: > - rebased on current NM git > - removed "nm-setting-team.h" include from src/devices/nm-device-ethernet.c > - fixed typo TEAM_CONFIG -> TEAM_PORT_CONFIG in write_team_port_setting() > -

Re: [patch NetworkManager 0/6] add support for network team devices

Tue, Jul 16, 2013 at 04:32:10PM CEST, d...@redhat.com wrote: >On Tue, 2013-07-16 at 10:53 +0200, Jiri Pirko wrote: >> Mon, Jul 15, 2013 at 08:22:27PM CEST, d...@gnome.org wrote: >> >On 07/14/2013 11:29 AM, Jiri Pirko wrote: >> >> teamd config is non-trivial tree s

Re: [patch NetworkManager 0/6] add support for network team devices

Mon, Jul 15, 2013 at 08:22:27PM CEST, d...@gnome.org wrote: >On 07/14/2013 11:29 AM, Jiri Pirko wrote: >> teamd config is non-trivial tree structure (JSON). At this point, there is >> really no point to have NM to be aware of the teamd config structure. >> Once NM will n

[patch NetworkManager v2 3/6] ifcfg: add read support for team devices

Signed-off-by: Jiri Pirko --- src/settings/plugins/ifcfg-rh/reader.c | 163 + 1 file changed, 147 insertions(+), 16 deletions(-) diff --git a/src/settings/plugins/ifcfg-rh/reader.c b/src/settings/plugins/ifcfg-rh/reader.c index 650f711..6dde8e8 100644 --- a/src

[patch NetworkManager v2 6/6] nm-device-team: spawn teamd for team device connection

Signed-off-by: Jiri Pirko --- src/devices/nm-device-team.c | 283 ++- 1 file changed, 282 insertions(+), 1 deletion(-) diff --git a/src/devices/nm-device-team.c b/src/devices/nm-device-team.c index 320b659..ac0467c 100644 --- a/src/devices/nm-device

[patch NetworkManager v2 0/6] add support for network team devices

include from src/devices/nm-device-ethernet.c - fixed typo TEAM_CONFIG -> TEAM_PORT_CONFIG in write_team_port_setting() - added "-n" option to teamd Jiri Pirko (6): add support for team device add setting for team port ifcfg: add read support for team devices ifcfg: add writ

[patch NetworkManager v2 2/6] add setting for team port

Signed-off-by: Jiri Pirko --- libnm-util/Makefile.am| 2 + libnm-util/libnm-util.ver | 5 ++ libnm-util/nm-connection.c| 17 libnm-util/nm-connection.h| 2 + libnm-util/nm-setting-team-port.c | 174 ++ libnm-util

[patch NetworkManager v2 5/6] cli: add team driver support

Signed-off-by: Jiri Pirko --- cli/src/connections.c | 116 +- 1 file changed, 97 insertions(+), 19 deletions(-) diff --git a/cli/src/connections.c b/cli/src/connections.c index 24cb4b5..3e36243 100644 --- a/cli/src/connections.c +++ b/cli/src

[patch NetworkManager v2 4/6] ifcfg: add write support for team devices

Signed-off-by: Jiri Pirko --- src/settings/plugins/ifcfg-rh/writer.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/src/settings/plugins/ifcfg-rh/writer.c b/src/settings/plugins/ifcfg-rh/writer.c index 810b526..6ed6921 100644 --- a/src/settings/plugins

Re: [patch NetworkManager 0/6] add support for network team devices

Fri, Jul 12, 2013 at 10:08:49PM CEST, d...@gnome.org wrote: >On 07/11/2013 11:31 AM, Jiri Pirko wrote: >> I heavily reused existing code, mainly bonding parts. > >Makes sense (and makes it easy to review...) > >> The only thing not >> implemented yet is dbus

[patch NetworkManager 6/6] nm-device-team: spawn teamd for team device connection

Signed-off-by: Jiri Pirko --- src/devices/nm-device-team.c | 282 ++- 1 file changed, 281 insertions(+), 1 deletion(-) diff --git a/src/devices/nm-device-team.c b/src/devices/nm-device-team.c index 5052a8c..9a9abc1 100644 --- a/src/devices/nm-device

[patch NetworkManager 0/6] add support for network team devices

I heavily reused existing code, mainly bonding parts. The only thing not implemented yet is dbus communication with teamd (used particulary for port config setup). That I want to add once this patchset gets applied. Jiri Pirko (6): add support for team device add setting for team port ifcfg

[patch NetworkManager 2/6] add setting for team port

Signed-off-by: Jiri Pirko --- libnm-util/Makefile.am| 2 + libnm-util/libnm-util.ver | 5 ++ libnm-util/nm-connection.c| 17 libnm-util/nm-connection.h| 2 + libnm-util/nm-setting-team-port.c | 174 ++ libnm-util

[patch NetworkManager 5/6] cli: add team driver support

Signed-off-by: Jiri Pirko --- cli/src/connections.c | 116 +- 1 file changed, 97 insertions(+), 19 deletions(-) diff --git a/cli/src/connections.c b/cli/src/connections.c index 24cb4b5..3e36243 100644 --- a/cli/src/connections.c +++ b/cli/src

[patch NetworkManager 3/6] ifcfg: add read support for team devices

Signed-off-by: Jiri Pirko --- src/settings/plugins/ifcfg-rh/reader.c | 163 + 1 file changed, 147 insertions(+), 16 deletions(-) diff --git a/src/settings/plugins/ifcfg-rh/reader.c b/src/settings/plugins/ifcfg-rh/reader.c index e99cbe6..89c422d 100644 --- a/src

[patch NetworkManager 4/6] ifcfg: add write support for team devices

Signed-off-by: Jiri Pirko --- src/settings/plugins/ifcfg-rh/writer.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/src/settings/plugins/ifcfg-rh/writer.c b/src/settings/plugins/ifcfg-rh/writer.c index eadcfd3..7591d24 100644 --- a/src/settings/plugins

Re: [MM] [PATCH] iface-modem-3gpp: handle non-deferrable registration state updates

Wed, Mar 06, 2013 at 09:35:03AM CET, aleksan...@lanedo.com wrote: >On 05/03/13 22:41, Dan Williams wrote: >> On Tue, 2013-03-05 at 21:27 +0100, Jiri Pirko wrote: >>> Tue, Mar 05, 2013 at 07:32:21PM CET, aleksan...@lanedo.com wrote: >>>> On 03/05/2013 03:37 AM, Be

Re: [MM] [PATCH] iface-modem-3gpp: handle non-deferrable registration state updates

Tue, Mar 05, 2013 at 07:32:21PM CET, aleksan...@lanedo.com wrote: >On 03/05/2013 03:37 AM, Ben Chan wrote: >> This patch changes MMIfaceModem3gpp to differentiate between deferrable >> and non-deferrable 3GPP registration state updates. Periodic or >> unsolicited registration state updates are defe

Re: NetworkManager-ssh

cover all necessary. In case of any troubles/questions feel free to ask. Jiri > >Sorry for my "greenness" when it comes to working with distributions... > >On Sat, Mar 2, 2013 at 8:38 PM, Jiri Pirko wrote: > >> Sat, Mar 02, 2013 at 01:16:32AM CET, malko...@gmail.c

Re: NetworkManager-ssh

Sat, Mar 02, 2013 at 01:16:32AM CET, malko...@gmail.com wrote: >Hey Pavel, > >Thanks again for showing interest. > >If by distributions you mean RPM/DEB packaging - than yes. Can be easily >packaged for Fedora/Ubuntu. > >I'm still search for a place to host RPMs/DEBs as github is not really a >good

Re: NetworkManager-ssh

Fri, Mar 01, 2013 at 10:59:13AM CET, malko...@gmail.com wrote: >Hi everybody, > >I'm bumping this one up as I haven't heard much and would like to know if >there's any interest at all. > >Since publishing it I managed to get much more work done and thanks to >Whoopie things compile on Ubuntu much b