Re: [PATCH] dns: use DBus to make dnsmasq nameserver changes

2016-04-21 Thread Thomas Haller
On Tue, 2016-03-22 at 10:03 -0400, Mathieu Trudel-Lapierre wrote: > Use DBus to make nameserver updates rather than restarting the > dnsmasq binary > again and again. > > Signed-off-by: Mathieu Trudel-Lapierre ical.com> For the record: The patch got merged to

Re: [PATCH] dns: use DBus to make dnsmasq nameserver changes

2016-04-14 Thread Thomas Haller
On Tue, 2016-03-22 at 10:03 -0400, Mathieu Trudel-Lapierre wrote: > Use DBus to make nameserver updates rather than restarting the > dnsmasq binary > again and again. > > Signed-off-by: Mathieu Trudel-Lapierre ical.com> Hi, I opened a bug for this patch.

Re: [PATCH] dns: use DBus to make dnsmasq nameserver changes

2016-03-22 Thread Thomas Haller
On Tue, 2016-03-22 at 12:44 -0400, Mathieu Trudel-Lapierre wrote: > On Tue, Mar 22, 2016 at 12:33 PM, Thomas Haller > wrote: > [...]  > > Hi Mathieu, > > > [...]  > > Can I give it back to you in this form and let's take it from > > there? > Sure, but what changes would you

Re: [PATCH] dns: use DBus to make dnsmasq nameserver changes

2016-03-22 Thread Mathieu Trudel-Lapierre
On Tue, Mar 22, 2016 at 12:33 PM, Thomas Haller wrote: [...] > Hi Mathieu, > > [...] > Can I give it back to you in this form and let's take it from there? > Sure, but what changes would you like to see? [...] > I dislike a bit the builder-member > GVariantBuilder

Re: [PATCH] dns: use DBus to make dnsmasq nameserver changes

2016-03-22 Thread Thomas Haller
On Tue, 2016-03-22 at 10:03 -0400, Mathieu Trudel-Lapierre wrote: > Use DBus to make nameserver updates rather than restarting the > dnsmasq binary > again and again. > > Signed-off-by: Mathieu Trudel-Lapierre lapie...@canonical.com> Hi Mathieu, I picked one part of this patch and pushed it

[PATCH] dns: use DBus to make dnsmasq nameserver changes

2016-03-22 Thread Mathieu Trudel-Lapierre
Use DBus to make nameserver updates rather than restarting the dnsmasq binary again and again. Signed-off-by: Mathieu Trudel-Lapierre --- src/dns-manager/nm-dns-dnsmasq.c| 338 ++-- src/dns-manager/nm-dns-manager.c