Re: [PATCH] vpn-connection: lack of ipv4 config in remote VPN is not fatal

On 16/11/2015 18:12, Lubomir Rintel wrote: > On Thu, 2015-11-05 at 12:44 +0100, Rafaël Carré wrote: >> Hello, >> >> On 05/11/2015 12:31, Lubomir Rintel wrote: >>> Thanks for the patch, Rafaël. >>> >>> I'm not sure it's correct, though. The VPN plugin probably should >>> probably only emit "Config"

Re: [PATCH] vpn-connection: lack of ipv4 config in remote VPN is not fatal

On 16/11/2015 18:12, Lubomir Rintel wrote: > On Thu, 2015-11-05 at 12:44 +0100, Rafaël Carré wrote: >> Hello, >> >> On 05/11/2015 12:31, Lubomir Rintel wrote: >>> Thanks for the patch, Rafaël. >>> >>> I'm not sure it's correct, though. The VPN plugin probably should >>> probably only emit "Config"

Re: [PATCH] vpn-connection: lack of ipv4 config in remote VPN is not fatal

On Thu, 2015-11-05 at 12:44 +0100, Rafaël Carré wrote: > Hello, > > On 05/11/2015 12:31, Lubomir Rintel wrote: > > Thanks for the patch, Rafaël. > > > > I'm not sure it's correct, though. The VPN plugin probably should > > probably only emit "Config" signal and not "IP4Config" when it has > > no

Re: [PATCH] vpn-connection: lack of ipv4 config in remote VPN is not fatal

Hello, On 05/11/2015 12:31, Lubomir Rintel wrote: > Thanks for the patch, Rafaël. > > I'm not sure it's correct, though. The VPN plugin probably should > probably only emit "Config" signal and not "IP4Config" when it has no > IPv4 configuration. You tell me :) I've been looking at this issue

Re: [PATCH] vpn-connection: lack of ipv4 config in remote VPN is not fatal

Thanks for the patch, Rafaël. I'm not sure it's correct, though. The VPN plugin probably should probably only emit "Config" signal and not "IP4Config" when it has no IPv4 configuration. On Tue, 2015-11-03 at 19:31 +0100, Rafaël Carré wrote: > IPv4 config can be set manually > --- >  

[PATCH] vpn-connection: lack of ipv4 config in remote VPN is not fatal

IPv4 config can be set manually --- src/vpn-manager/nm-vpn-connection.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/vpn-manager/nm-vpn-connection.c b/src/vpn-manager/nm-vpn-connection.c index 0c0ac1c..fc49304 100644 --- a/src/vpn-manager/nm-vpn-connection.c +++