Re: ModemManager [PATCH 2/2] Take 3 of: Improvements to SIM PIN handling - Add EnabledFacilityLocks property

2011-12-04 Thread Aleksander Morgado
I guess I don't have a problem with merging them, although strictly speaking they refer to different things - locks vs. the PINs needed to unlock those locks. Yeah, you're totally right... but at the end the PIN/PUK codes are directly related to facilities. E.g SIM

Re: ModemManager [PATCH 2/2] Take 3 of: Improvements to SIM PIN handling - Add EnabledFacilityLocks property

2011-12-02 Thread Dan Williams
On Thu, 2011-12-01 at 09:11 +0100, Aleksander Morgado wrote: I guess I don't have a problem with merging them, although strictly speaking they refer to different things - locks vs. the PINs needed to unlock those locks. Yeah, you're totally right... but at the end the PIN/PUK

Re: ModemManager [PATCH 2/2] Take 3 of: Improvements to SIM PIN handling - Add EnabledFacilityLocks property

2011-12-01 Thread Aleksander Morgado
I guess I don't have a problem with merging them, although strictly speaking they refer to different things - locks vs. the PINs needed to unlock those locks. Yeah, you're totally right... but at the end the PIN/PUK codes are directly related to facilities. E.g SIM facility, has

Re: ModemManager [PATCH 2/2] Take 3 of: Improvements to SIM PIN handling - Add EnabledFacilityLocks property

2011-11-30 Thread Dan Williams
On Wed, 2011-11-23 at 20:14 +0100, Aleksander Morgado wrote: Hey hey, I guess I don't have a problem with merging them, although strictly speaking they refer to different things - locks vs. the PINs needed to unlock those locks. Yeah, you're totally right... but at the end the PIN/PUK

Re: ModemManager [PATCH 2/2] Take 3 of: Improvements to SIM PIN handling - Add EnabledFacilityLocks property

2011-11-23 Thread Aleksander Morgado
Hey Eric Dan, On Fri, 2011-11-11 at 15:10 -0500, Eric Shienbrood wrote: Subject: [PATCH] Added new property to track which facility locks are enabled. The property EnabledFacilityLocks on the .Modem.Gsm.Card interface is a bit mask that indicates which of the various personalization codes

Re: ModemManager [PATCH 2/2] Take 3 of: Improvements to SIM PIN handling - Add EnabledFacilityLocks property

2011-11-23 Thread Eric Shienbrood
I guess I don't have a problem with merging them, although strictly speaking they refer to different things - locks vs. the PINs needed to unlock those locks. Two other points to consider regarding lock/PIN handling in the new API: - PIN, PUK, PIN2, and PUK2 are PINs for SIM locks. The rest

Re: ModemManager [PATCH 2/2] Take 3 of: Improvements to SIM PIN handling - Add EnabledFacilityLocks property

2011-11-23 Thread Aleksander Morgado
Hey hey, I guess I don't have a problem with merging them, although strictly speaking they refer to different things - locks vs. the PINs needed to unlock those locks. Yeah, you're totally right... but at the end the PIN/PUK codes are directly related to facilities. E.g SIM facility, has PIN

ModemManager [PATCH 2/2] Take 3 of: Improvements to SIM PIN handling - Add EnabledFacilityLocks property

2011-11-11 Thread Eric Shienbrood
From 2594d75ec8535e54afb556708a8e17ab77ed68bd Mon Sep 17 00:00:00 2001 From: Eric Shienbrood e...@chromium.org Date: Thu, 11 Aug 2011 13:58:59 -0400 Subject: [PATCH] Added new property to track which facility locks are enabled. The property EnabledFacilityLocks on the .Modem.Gsm.Card interface