Re: [Nfs-ganesha-devel] The life of tcp drc

2017-10-13 Thread Malahal Naineni
#1. Looks like a bug! Lines 629 and 630 should be deleted #2. See nfs_rpc_free_user_data(). It sets xp_u2 to NULL and drc ref is decremented there. #3. Life time of drc should start when it is allocated in nfs_dupreq_get_drc() using alloc_tcp_drc(). It can live beyond xprt's xp_u2 setting to

Re: [Nfs-ganesha-devel] The life of tcp drc

2017-10-13 Thread Kinglong Mee
Hi Malahal, Thanks for your reply. #1. I'd like to post a patch to delete it, because I have some cleanups for drc. #2/#3. Sorry for my missing of nfs_rpc_free_user_data(). With it, everything is okay. thanks, Kinglong Mee On 10/13/2017 15:52, Malahal Naineni wrote: > #1. Looks like a bug! Lin

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: drc: fix duplicate referance of drc for xprt

2017-10-13 Thread GerritHub
>From Kinglong Mee : Kinglong Mee has uploaded this change for review. ( https://review.gerrithub.io/382413 Change subject: drc: fix duplicate referance of drc for xprt .. drc: fix duplicate referance of drc for xprt Change-I

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: drc: add missing initialization of rq_u1/rq_u2 as DUPREQ_BAD...

2017-10-13 Thread GerritHub
>From Kinglong Mee : Kinglong Mee has uploaded this change for review. ( https://review.gerrithub.io/382414 Change subject: drc: add missing initialization of rq_u1/rq_u2 as DUPREQ_BAD_ADDR1 .. drc: add missing initialization

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: drc: remove some useless DRC flags

2017-10-13 Thread GerritHub
>From Kinglong Mee : Kinglong Mee has uploaded this change for review. ( https://review.gerrithub.io/382416 Change subject: drc: remove some useless DRC flags .. drc: remove some useless DRC flags Change-Id: Id6315ac9299d8b57

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: drc: drop useless of xprt from nfs_dupreq_put_drc

2017-10-13 Thread GerritHub
>From Kinglong Mee : Kinglong Mee has uploaded this change for review. ( https://review.gerrithub.io/382415 Change subject: drc: drop useless of xprt from nfs_dupreq_put_drc .. drc: drop useless of xprt from nfs_dupreq_put_drc

[Nfs-ganesha-devel] pseudo mount issue with ganesha proxy server

2017-10-13 Thread Charles Short
Hi, I am testing a v simple ganesha proxy and get pseudo mount INODE errors on the ganesha server when I try and mount the NFS volume from client to proxy ##On server startup 13/10/2017 10:13:43 : epoch 59e091d7 : ganesha-cems : ganesha.nfsd-19778[main] export_display :CONFIG :M_DBG :RESULT

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_PROXY: fix slotid index management

2017-10-13 Thread GerritHub
>From Patrice LUCAS : Patrice LUCAS has uploaded this change for review. ( https://review.gerrithub.io/382427 Change subject: FSAL_PROXY: fix slotid index management .. FSAL_PROXY: fix slotid index management Change-Id: I1b42

Re: [Nfs-ganesha-devel] pseudo mount issue with ganesha proxy server

2017-10-13 Thread Charles Short
More complete logs with all 'errors' - https://pastebin.com/ZzRybVeE On 13/10/2017 11:30, Charles Short wrote: Hi, I am testing a v simple ganesha proxy and get pseudo mount INODE errors on the ganesha server when I try and mount the NFS volume from client to proxy ##On server startup 13/

Re: [Nfs-ganesha-devel] pseudo mount issue with ganesha proxy server

2017-10-13 Thread LUCAS Patrice
Hello Charles, You ganesha proxy-server configuration file seems to be a bit outdated (you can find an up to date example with this wiki link : https://github.com/nfs-ganesha/nfs-ganesha/wiki/Testing-FSAL_PROXY ) According to your configuration this one would be correct : EXPORT { #

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Remove unused parameters "Dispatch_Max_Reqs" and "Dispatch_M...

2017-10-13 Thread GerritHub
>From : supriti.si...@suse.com has uploaded this change for review. ( https://review.gerrithub.io/382453 Change subject: Remove unused parameters "Dispatch_Max_Reqs" and "Dispatch_Max_Reqs_Xprt" .. Remove unused parameters "D

[Nfs-ganesha-devel] FSAL_PROXY : client NFSv3 and NFSv4.0 bugs solved

2017-10-13 Thread LUCAS Patrice
Hello everyone, During last Fall Bakeathon, we brought bugs out when NFSv3 or NFSv4.0 clients access a FSAL_PROXY  ganesha export. The two last patchs I submit fix these bugs. *FSAL_PROXY : fix open from a NFSv4.0 client https://review.gerrithub.io/#/c/381637/ *FSAL_PROXY: fix slotid index

Re: [Nfs-ganesha-devel] The life of tcp drc

2017-10-13 Thread Matt Benjamin
Yes, nfs_rpc_free_user_data() is the secret :) Matt On Fri, Oct 13, 2017 at 4:11 AM, Kinglong Mee wrote: > Hi Malahal, > > Thanks for your reply. > > #1. I'd like to post a patch to delete it, because I have some cleanups for > drc. > #2/#3. Sorry for my missing of nfs_rpc_free_user_data(). Wit

Re: [Nfs-ganesha-devel] pseudo mount issue with ganesha proxy server

2017-10-13 Thread Charles Short
The ganesha server does not like the FSAL proxy config option - 13/10/2017 15:39:05 : epoch 59e0de19 : ganesha-cems : ganesha.nfsd-7820[main] config_errs_to_log :CONFIG :CRIT :Config File (/etc/ganesha/ganesha.conf:63): 1 validation errors in block FSAL 13/10/2017 15:39:05 : epoch 59e0de19 : ga

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: RGW: set fso_compute_readdir_cookie

2017-10-13 Thread GerritHub
>From Matt Benjamin : Matt Benjamin has uploaded this change for review. ( https://review.gerrithub.io/382503 Change subject: RGW: set fso_compute_readdir_cookie .. RGW: set fso_compute_readdir_cookie The change that implemen

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Remove unused codes of stallq

2017-10-13 Thread GerritHub
>From Kinglong Mee : Kinglong Mee has uploaded this change for review. ( https://review.gerrithub.io/382527 Change subject: Remove unused codes of stallq .. Remove unused codes of stallq Change-Id: If2d2b708b6231dcc5315fb657a