Re: [Nfs-ganesha-devel] commit test Comparisons

2017-06-29 Thread Daniel Gryniewicz
On 06/28/2017 08:41 PM, William Allen Simpson wrote: This is a good programming practice of long-standing value. Why of why do these evil commit tests keep creeping in? bill@simpson91:~/rdma/nfs-ganesha$ git commit --amend -a WARNING: Comparisons should place the constant on the right side of t

Re: [Nfs-ganesha-devel] commit test Comparisons

2017-06-29 Thread Matt Benjamin
I find this example of constant on the left less clear, to be honest. Matt - Original Message - > From: "William Allen Simpson" > To: "NFS Ganesha Developers" > Sent: Wednesday, June 28, 2017 8:41:26 PM > Subject: [Nfs-ganesha-devel] commit test

Re: [Nfs-ganesha-devel] commit test Comparisons

2017-06-29 Thread Malahal Naineni
My brain has easier time if it compares a variable with a constant (meaning the constant is on the right side of the operator) than other way around. I have come across many programmers that do this than compare a constant with a variable. I always thought that programmers doing the "constant on l

Re: [Nfs-ganesha-devel] commit test Comparisons

2017-06-28 Thread William Allen Simpson
On 6/28/17 8:41 PM, William Allen Simpson wrote: This is a good programming practice of long-standing value. Why of why do these evil commit tests keep creeping in? bill@simpson91:~/rdma/nfs-ganesha$ git commit --amend -a WARNING: Comparisons should place the constant on the right side of the t

[Nfs-ganesha-devel] commit test Comparisons

2017-06-28 Thread William Allen Simpson
This is a good programming practice of long-standing value. Why of why do these evil commit tests keep creeping in? bill@simpson91:~/rdma/nfs-ganesha$ git commit --amend -a WARNING: Comparisons should place the constant on the right side of the test #17: FILE: src/MainNFSD/nfs_rpc_dispatcher_thr