chunked-encoding disable range request

2016-06-28 Thread shuxinyang
Hi, There: I find that range-request is disabled by Nginx proxy if backend server responses with chunked encoding. I verify my observation by: 1) manually edit the cache by replacing chunked-encoding header with content-length header, then range-request is enabled. 2) examine

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

2016-06-27 Thread shuxinyang
It's "trailer support" for the web serving part of NGINX, just not proxying. - the "get" in "ngx_http_chunked_get_trailers" is sort of misleading. The "get" here actually means "generate". I thought you are looking for a existing buffer. That function name got changed a few

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

2016-06-27 Thread shuxinyang
Hi, Piotr: I took some time to read your code, I believe I fully understand your code at this moment. My implementation is slightly differently from yours, and we have different use-cases. Here is my $0.02 value of comment to your code (cosmetic wise): - the verb "support" in

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

2016-06-27 Thread shuxinyang
Hi, Piotr and Maxim: > to Maxim's question about "does trailer has real-world use" first. At least we do, some info is available only after the entire body is sent. Trailer is a viable and convenient solution for that matter, albeit it is not the only solution for it. I cannot "leak" more

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

2016-06-27 Thread shuxinyang
Hi, Piotr: I'm wondering why not just change the ngx_http_chunked_filter_module.c? or add a module inserted right after the chunked-filter-module? Shuxin On 06/27/2016 07:37 AM, Piotr Sikora wrote: Hey Maxim, What's the goal? Any real-world use for this? On 06/27/2016 06:45 AM,

Re: C++ module

2016-06-15 Thread shuxinyang
Quite frankly, I don't know the standard way. My way to tackle this problem is to add config.make to the module like this: cat config.make find $ngx_addon_dir -name "*.cc" -print | while read x; do x=$(basename $x | sed