[nodejs] Request for feedback: Native addon memory management

2012-03-20 Thread Matt Gollob
Hello everyone - I'd like some feedback with regard to a sample addon I've put together for node to demonstrate exposing a C++ library to javascript. In particular, I'm struggling with how to properly manage memory allocated from C++ when its lifetime is coupled to the lifetime of a javascript

Re: [nodejs] Request for feedback: Native addon memory management

2012-03-20 Thread Ben Noordhuis
On Wed, Mar 21, 2012 at 03:21, Matt Gollob wrote: > Hello everyone - > > I'd like some feedback with regard to a sample addon I've put together for > node to demonstrate exposing a C++ library to javascript.  In particular, > I'm struggling with how to properly manage memory allocated from C++ whe

Re: [nodejs] Request for feedback: Native addon memory management

2012-03-21 Thread Matt Gollob
Thanks Ben, that was enough of a nudge in the right direction that I was able to figure things out I think. If you have time, could you possibly review https://github.com/mattness/addonSample/commit/8c775e96 to confirm? Thank you very much for your help. I appreciate it. Matt On Tuesday, Mar

Re: [nodejs] Request for feedback: Native addon memory management

2012-03-22 Thread Ben Noordhuis
On Wed, Mar 21, 2012 at 23:00, Matt Gollob wrote: > Thanks Ben, that was enough of a nudge in the right direction that I was > able to figure things out I think.  If you have time, could you possibly > review https://github.com/mattness/addonSample/commit/8c775e96 to confirm? > > Thank you very mu

Re: [nodejs] Request for feedback: Native addon memory management

2012-03-22 Thread Matt Gollob
Great! Thanks so much :) -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to nodejs@googlegrou