[GitHub] ctubbsii commented on issue #369: [ACCUMULO-4787] Close input stream in AccumuloReplicaSystem

2018-01-28 Thread GitBox
ctubbsii commented on issue #369: [ACCUMULO-4787] Close input stream in AccumuloReplicaSystem URL: https://github.com/apache/accumulo/pull/369#issuecomment-361139353 > why did findbugs not catch this? Probably because the resource is being allocated by a method... like a factory

[GitHub] joshelser commented on issue #369: [ACCUMULO-4787] Close input stream in AccumuloReplicaSystem

2018-01-28 Thread GitBox
joshelser commented on issue #369: [ACCUMULO-4787] Close input stream in AccumuloReplicaSystem URL: https://github.com/apache/accumulo/pull/369#issuecomment-361128632 > Good find. I think we should apply this back to the 1.7 branch, and use try-with-resources to properly close the input