ctubbsii commented on issue #369: [ACCUMULO-4787] Close input stream in
AccumuloReplicaSystem
URL: https://github.com/apache/accumulo/pull/369#issuecomment-365735451
Created follow-on issue for the potentially unclosed crypto stream from
`DfsLogger.readHeaderAndReturnStream`
ctubbsii commented on issue #369: [ACCUMULO-4787] Close input stream in
AccumuloReplicaSystem
URL: https://github.com/apache/accumulo/pull/369#issuecomment-364289229
@adamjshook I'd like to update my review, but with the code relocations, I'm
still having trouble following it. If you
ctubbsii commented on issue #369: [ACCUMULO-4787] Close input stream in
AccumuloReplicaSystem
URL: https://github.com/apache/accumulo/pull/369#issuecomment-362418538
To do a diff on the command-line with git, just do: `git diff
--ignore-all-space`
ctubbsii commented on issue #369: [ACCUMULO-4787] Close input stream in
AccumuloReplicaSystem
URL: https://github.com/apache/accumulo/pull/369#issuecomment-362418316
Ah, it was the relocation to a new method that screwed me up. If you ignore
whitespace, the regular diff without that
ctubbsii commented on issue #369: [ACCUMULO-4787] Close input stream in
AccumuloReplicaSystem
URL: https://github.com/apache/accumulo/pull/369#issuecomment-362403472
@adamjshook Were there additional changes, unrelated to the original issue
also done in your updated commits? It seems like
ctubbsii commented on issue #369: [ACCUMULO-4787] Close input stream in
AccumuloReplicaSystem
URL: https://github.com/apache/accumulo/pull/369#issuecomment-361139353
> why did findbugs not catch this?
Probably because the resource is being allocated by a method... like a
factory
