juzhiyuan commented on pull request #428:
URL: https://github.com/apache/apisix-dashboard/pull/428#issuecomment-684356762
> @juzhiyuan
>
> the `WebSocket` switch should only show in the first step.
>
> we need to delete this switch at 2nd step.
>
>
membphis commented on pull request #428:
URL: https://github.com/apache/apisix-dashboard/pull/428#issuecomment-684329492
@juzhiyuan
the `WebSocket` switch should only show in the first step.
we need to delete this switch at 2nd step.
liuxiran edited a comment on pull request #426:
URL: https://github.com/apache/apisix-dashboard/pull/426#issuecomment-684270281
@LiteSun @juzhiyuan Any feedback is much appreciated:), thanks
This is an automated message from
liuxiran commented on pull request #426:
URL: https://github.com/apache/apisix-dashboard/pull/426#issuecomment-684270281
@LiteSun @juzhiyuan Any feedback is much appreciated:)
This is an automated message from the Apache Git
imjoey commented on issue #431:
URL:
https://github.com/apache/apisix-dashboard/issues/431#issuecomment-684166080
@moonming yep, that's true and will surely bring some sort of complexity,
especially if there are only several routes. While in contrast, if users need
to manage a large
moonming commented on issue #431:
URL:
https://github.com/apache/apisix-dashboard/issues/431#issuecomment-684158042
@imjoey you are welcome :)
I have a concern, will namesapce increase the cost of using and learning for
open source users?
liuxiran commented on a change in pull request #395:
URL: https://github.com/apache/apisix-dashboard/pull/395#discussion_r480621719
##
File path: src/pages/SSL/locales/en-US.ts
##
@@ -15,39 +15,41 @@
* limitations under the License.
*/
export default {
-
juzhiyuan commented on a change in pull request #395:
URL: https://github.com/apache/apisix-dashboard/pull/395#discussion_r480580844
##
File path: src/pages/SSL/locales/en-US.ts
##
@@ -15,39 +15,41 @@
* limitations under the License.
*/
export default {
-
juzhiyuan commented on a change in pull request #395:
URL: https://github.com/apache/apisix-dashboard/pull/395#discussion_r480580844
##
File path: src/pages/SSL/locales/en-US.ts
##
@@ -15,39 +15,41 @@
* limitations under the License.
*/
export default {
-
juzhiyuan commented on pull request #428:
URL: https://github.com/apache/apisix-dashboard/pull/428#issuecomment-684143136
WebSocket should appear in Step2 樂 @membphis right?
This is an automated message from the Apache Git
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new a0d7e0c feat: added chash (#429)
juzhiyuan merged pull request #429:
URL: https://github.com/apache/apisix-dashboard/pull/429
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
imjoey commented on issue #431:
URL:
https://github.com/apache/apisix-dashboard/issues/431#issuecomment-684140753
> cool, that will be great if we can support both namesapce and labels.
Thanks, Ming Wen Twitter: _WenMing Joey
@moonming yeah, that's really awesome for your
moonming commented on issue #431:
URL:
https://github.com/apache/apisix-dashboard/issues/431#issuecomment-684139567
cool, that will be great if we can support both namesapce and labels.
Thanks,
Ming Wen
Twitter: _WenMing
Joey 于2020年9月1日周二 上午9:31写道：
>
imjoey edited a comment on issue #431:
URL:
https://github.com/apache/apisix-dashboard/issues/431#issuecomment-684137827
@moonming `tags/labels` would be very helpful for users easily to get the
wanted `routes/services/upstreams`. Besides, the feature of route grouping we
are working on
imjoey commented on issue #431:
URL:
https://github.com/apache/apisix-dashboard/issues/431#issuecomment-684137827
@moonming `tags/labels` would be very helpful for users easily to get the
wanted `routes/services/upstreams`. Besides, the feature of route grouping we
are working on aims at
membphis commented on issue #2128:
URL: https://github.com/apache/apisix/issues/2128#issuecomment-683889774
we can listen to multiple ports eg: 80 and 8000.
```shell
# foo.com:80
{
"uri": "/*",
"host": "foo.com"
"vars": ["server_port", "==", "80"],
membphis commented on issue #2123:
URL: https://github.com/apache/apisix/issues/2123#issuecomment-683885641
need to patch openresty by yourself, it is not easy for most users.
This is an automated message from the Apache Git
membphis opened a new issue #2138:
URL: https://github.com/apache/apisix/issues/2138
comments: https://github.com/apache/apisix/pull/2121#issuecomment-683882604
```
t/plugin/limit-req.t . ok
# Failed test 'TEST 1: log rotate - response_body_like -
membphis commented on pull request #2121:
URL: https://github.com/apache/apisix/pull/2121#issuecomment-683882604
> # at /home/runner/work/apisix/apisix/test-nginx/lib/Test/Nginx/Socket.pm
line 1635.
> # '2020-08-31_10-25-32__access.log
> #
membphis edited a comment on pull request #2121:
URL: https://github.com/apache/apisix/pull/2121#issuecomment-683882604
```
> # at /home/runner/work/apisix/apisix/test-nginx/lib/Test/Nginx/Socket.pm
line 1635.
> # '2020-08-31_10-25-32__access.log
> #
membphis commented on issue #2137:
URL: https://github.com/apache/apisix/issues/2137#issuecomment-683878019
you need to enable the new plugin first. and please use English on the
public channel.
and if you still have a problem, you need to provide a mini case in which we
can get
moonming commented on issue #431:
URL:
https://github.com/apache/apisix-dashboard/issues/431#issuecomment-683845756
good job,thx
liuxiran 于 2020年8月31日周一 下午9:40写道：
> k8s supports tag too, so I think APISIX supports tag is easy:) Thanks,
> Ming Wen Twitter: _WenMing
liuxiran commented on pull request #428:
URL: https://github.com/apache/apisix-dashboard/pull/428#issuecomment-683799843
modified interface logic
errors：https://github.com/apache/apisix-dashboard/pull/428/commits/f7c1c314dd92b8e6148f170d26af25126c42ba13
liuxiran commented on issue #431:
URL:
https://github.com/apache/apisix-dashboard/issues/431#issuecomment-683785047
> k8s supports tag too, so I think APISIX supports tag is easy:) Thanks,
Ming Wen Twitter: _WenMing liuxiran 于2020年8月31日周一
下午4:44写道：
> […](#)
> @liuxiran
liuxiran opened a new pull request #433:
URL: https://github.com/apache/apisix-dashboard/pull/433
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
-
liuxiran opened a new pull request #432:
URL: https://github.com/apache/apisix-dashboard/pull/432
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
-
xyz2b commented on issue #2123:
URL: https://github.com/apache/apisix/issues/2123#issuecomment-683769168
Will apisix implement this function on its own?
This is an automated message from the Apache Git Service.
To
xyz2b removed a comment on issue #2123:
URL: https://github.com/apache/apisix/issues/2123#issuecomment-683768928
Will apifix implement this function on its own?
This is an automated message from the Apache Git
xyz2b commented on issue #2123:
URL: https://github.com/apache/apisix/issues/2123#issuecomment-683768928
Will apifix implement this function on its own?
This is an automated message from the Apache Git Service.
To
xyz2b commented on issue #2128:
URL: https://github.com/apache/apisix/issues/2128#issuecomment-683767161
like...
http {
...
server {
listen 80;
server_name www.github.com;
location / {
...
}
}
server {
listen 8080;
moonming commented on pull request #2121:
URL: https://github.com/apache/apisix/pull/2121#issuecomment-683760175
```
# Failed test 'TEST 1: log rotate - response_body_like - response is
expected (2020-08-31_10-25-32__access.log 2020-08-31_10-25-31__access.log
moonming merged pull request #2136:
URL: https://github.com/apache/apisix/pull/2136
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
moonming closed issue #2131:
URL: https://github.com/apache/apisix/issues/2131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new d84e3c7 license: fixed license issue for
liuxiran commented on a change in pull request #395:
URL: https://github.com/apache/apisix-dashboard/pull/395#discussion_r480046953
##
File path: src/pages/SSL/locales/en-US.ts
##
@@ -15,39 +15,41 @@
* limitations under the License.
*/
export default {
-
juzhiyuan commented on a change in pull request #395:
URL: https://github.com/apache/apisix-dashboard/pull/395#discussion_r480041316
##
File path: src/pages/SSL/locales/en-US.ts
##
@@ -15,39 +15,41 @@
* limitations under the License.
*/
export default {
-
gy09535 commented on a change in pull request #2121:
URL: https://github.com/apache/apisix/pull/2121#discussion_r480024641
##
File path: t/plugin/limit-count.t
##
@@ -637,3 +637,55 @@ GET /t
passed
--- no_error_log
[error]
+
+
+
+=== TEST 21: when the count is changed,
liubinqi2007 opened a new issue #2137:
URL: https://github.com/apache/apisix/issues/2137
### Issue description
如果我想再插件里改这个地址或者自己的插件也实现一个这样的地址，我应该怎么配置，我现在如果自定义uri提示我没有匹配对应的规则
https://user-images.githubusercontent.com/17898385/91708521-07757400-ebb4-11ea-8520-7a2b3afdb2e8.png;>
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git
The following commit(s) were added to refs/heads/master by this push:
new 897a7b8 Create .asf.yaml
897a7b8
An error occurred while running github feature in .asf.yaml!:
.asf.yaml: Invalid GitHub label 'helm chart' - must be lowercase alphanumerical
and <= 35 characters!
moonming commented on issue #69:
URL: https://github.com/apache/apisix-docker/issues/69#issuecomment-683683984
@gxthrj please take a look.
This is an automated message from the Apache Git Service.
To respond to the message,
moonming merged pull request #70:
URL: https://github.com/apache/apisix-docker/pull/70
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-docker.git
The following commit(s) were added to refs/heads/master by this push:
new 86968b3 feat: add CI for alpine docker
moonming commented on a change in pull request #2092:
URL: https://github.com/apache/apisix/pull/2092#discussion_r47769
##
File path: .travis/linux_apisix_master_luarocks_runner.sh
##
@@ -63,6 +63,14 @@ script() {
sudo mkdir -p /usr/local/apisix/deps
sudo
moonming opened a new pull request #2136:
URL: https://github.com/apache/apisix/pull/2136
### What this PR does / why we need it:
fixed https://github.com/apache/apisix/issues/2131
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or
liuxiran commented on a change in pull request #395:
URL: https://github.com/apache/apisix-dashboard/pull/395#discussion_r479992228
##
File path: src/pages/SSL/locales/en-US.ts
##
@@ -15,39 +15,41 @@
* limitations under the License.
*/
export default {
-
moonming commented on issue #431:
URL:
https://github.com/apache/apisix-dashboard/issues/431#issuecomment-683652629
k8s supports tag too, so I think APISIX supports tag is easy:)
Thanks,
Ming Wen
Twitter: _WenMing
liuxiran 于2020年8月31日周一 下午4:44写道：
> @liuxiran
moonming commented on a change in pull request #2121:
URL: https://github.com/apache/apisix/pull/2121#discussion_r479986030
##
File path: apisix/plugin.lua
##
@@ -297,6 +297,7 @@ local function merge_service_route(service_conf, route_conf)
local new_conf =
liuxiran commented on issue #431:
URL:
https://github.com/apache/apisix-dashboard/issues/431#issuecomment-683650265
> @liuxiran cool, that will be very useful for hundreds of routes.
> How about add `tag` for route, service? which is more flexible, a route
can have multiple tags
juzhiyuan merged pull request #430:
URL: https://github.com/apache/apisix-dashboard/pull/430
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 8f8d173 change: upstream and
gy09535 commented on a change in pull request #2121:
URL: https://github.com/apache/apisix/pull/2121#discussion_r479969372
##
File path: apisix/plugin.lua
##
@@ -297,6 +297,7 @@ local function merge_service_route(service_conf, route_conf)
local new_conf =
moonming commented on a change in pull request #2121:
URL: https://github.com/apache/apisix/pull/2121#discussion_r479962776
##
File path: apisix/plugin.lua
##
@@ -332,7 +333,8 @@ function _M.merge_service_route(service_conf, route_conf)
core.log.info("service conf: ",
moonming commented on a change in pull request #2121:
URL: https://github.com/apache/apisix/pull/2121#discussion_r479962013
##
File path: apisix/init.lua
##
@@ -361,21 +361,11 @@ function _M.http_access_phase()
return core.response.exit(404)
end
-
moonming commented on issue #431:
URL:
https://github.com/apache/apisix-dashboard/issues/431#issuecomment-683623439
@liuxiran cool, that will be very useful for hundreds of routes.
How about add `tag` for route, service? which is more flexible, a route can
have multiple tags
gy09535 edited a comment on pull request #2121:
URL: https://github.com/apache/apisix/pull/2121#issuecomment-683585415
thanks for reviewing , all required format has resolved.
This is an automated message from the Apache
gy09535 commented on pull request #2121:
URL: https://github.com/apache/apisix/pull/2121#issuecomment-683585415
thanks for reviewing , all required format has fixed.
This is an automated message from the Apache Git Service.
58 matches
Mail list logo
