juzhiyuan commented on a change in pull request #2282:
URL: https://github.com/apache/apisix/pull/2282#discussion_r493212313
##
File path: apisix/plugins/batch-requests.lua
##
@@ -45,7 +45,7 @@ local req_schema = {
timeout = {
description = "pipeline
juzhiyuan commented on a change in pull request #2282:
URL: https://github.com/apache/apisix/pull/2282#discussion_r493212313
##
File path: apisix/plugins/batch-requests.lua
##
@@ -45,7 +45,7 @@ local req_schema = {
timeout = {
description = "pipeline
membphis commented on a change in pull request #2282:
URL: https://github.com/apache/apisix/pull/2282#discussion_r493211825
##
File path: apisix/plugins/batch-requests.lua
##
@@ -45,7 +45,7 @@ local req_schema = {
timeout = {
description = "pipeline
membphis commented on pull request #1971:
URL: https://github.com/apache/apisix/pull/1971#issuecomment-697146835
@nic-chen @spacewander @moonming Do you have time to take a look at this PR?
This is an automated message from
Firstsawyou commented on pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#issuecomment-697138410
> the commit msg ` feat: The "limit-req" plugin supports flow control based
on the "consumer"` is unclear, what is ` flow control`?
ok, I will re-edit.
Firstsawyou commented on a change in pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#discussion_r493199624
##
File path: t/plugin/limit-req.t
##
@@ -432,3 +432,367 @@ GET /t
passed
--- no_error_log
[error]
+
+
+
+=== TEST 12: consumer binds the limit-req
Firstsawyou commented on a change in pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#discussion_r493199090
##
File path: apisix/plugins/limit-req.lua
##
@@ -67,7 +67,12 @@ function _M.access(conf, ctx)
return 500
end
-local key =
tokers commented on pull request #2279:
URL: https://github.com/apache/apisix/pull/2279#issuecomment-697108446
@imjoey One thing confuses me that the labels field is attached on the whole
`upstream` object, It's closer to the labels on Kubernetes Service, not the
Pod, and labels on Pod
nic-chen commented on issue #500:
URL:
https://github.com/apache/apisix-dashboard/issues/500#issuecomment-697117973
> Hi I disabled the GoProxy. but got the same error. so it is for something
else. I am behind a company proxy and I do have http_proxy and https_proxy set
up in the system
membphis commented on pull request #2268:
URL: https://github.com/apache/apisix/pull/2268#issuecomment-697116275
@gxthrj please take a look at this PR
This is an automated message from the Apache Git Service.
To respond to
Yiyiyimu commented on issue #2262:
URL: https://github.com/apache/apisix/issues/2262#issuecomment-697108837
thx!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
liuxiran commented on issue #493:
URL:
https://github.com/apache/apisix-dashboard/issues/493#issuecomment-697076611
I have a pr on the way to modify i18n refer to the Proposal #331, which have
been Interrupted by feature development,
If there are no major changes about the proposal,
membphis commented on pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#issuecomment-697099061
@Firstsawyou conflicted, please rebase your branch
This is an automated message from the Apache Git Service.
To
Yiyiyimu commented on a change in pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#discussion_r493136275
##
File path: bin/apisix
##
@@ -940,6 +940,22 @@ function _M.start(...)
end
end
+local argparse = require "argparse"
+local
liuxiran edited a comment on issue #493:
URL:
https://github.com/apache/apisix-dashboard/issues/493#issuecomment-697076611
I have a pr on the way to modify i18n refer to the Proposal #331, which has
been Interrupted by feature development,
If there are no major changes about the
juzhiyuan closed issue #500:
URL: https://github.com/apache/apisix-dashboard/issues/500
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
juzhiyuan commented on issue #500:
URL:
https://github.com/apache/apisix-dashboard/issues/500#issuecomment-697089282
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
moonming commented on pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#issuecomment-697116268
the commit msg ` feat: The "limit-req" plugin supports flow control based on
the "consumer"` is unclear, what is ` flow control`?
juzhiyuan closed issue #494:
URL: https://github.com/apache/apisix-dashboard/issues/494
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
juzhiyuan commented on issue #493:
URL:
https://github.com/apache/apisix-dashboard/issues/493#issuecomment-697086765
> I have a pr on the way to modify i18n refer to the Proposal #331, which
has been Interrupted by feature development,
> If there are no major changes about the
juzhiyuan merged pull request #504:
URL: https://github.com/apache/apisix-dashboard/pull/504
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
juzhiyuan commented on issue #499:
URL:
https://github.com/apache/apisix-dashboard/issues/499#issuecomment-696475343
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
moonming merged pull request #2179:
URL: https://github.com/apache/apisix/pull/2179
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
juzhiyuan edited a comment on issue #458:
URL:
https://github.com/apache/apisix-dashboard/issues/458#issuecomment-696536079
Could we close this issue? @LiteSun
This is an automated message from the Apache Git Service.
To
Firstsawyou closed issue #2229:
URL: https://github.com/apache/apisix/issues/2229
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
juzhiyuan closed issue #444:
URL: https://github.com/apache/apisix-dashboard/issues/444
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
moonming commented on a change in pull request #2265:
URL: https://github.com/apache/apisix/pull/2265#discussion_r492816513
##
File path: doc/zh-cn/plugins/consumer-restriction.md
##
@@ -20,27 +20,36 @@
- [English](../../plugins/consumer-restriction.md)
# 目录
--
moonming merged pull request #2244:
URL: https://github.com/apache/apisix/pull/2244
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
spacewander commented on issue #2272:
URL: https://github.com/apache/apisix/issues/2272#issuecomment-696483718
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
LiteSun closed issue #458:
URL: https://github.com/apache/apisix-dashboard/issues/458
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
nic-chen commented on issue #466:
URL:
https://github.com/apache/apisix-dashboard/issues/466#issuecomment-696536615
@ShiningRush As discussed before, I think we should support this feature
similar to `foreign key constraints`
in the refactored `manager api` .
juzhiyuan merged pull request #503:
URL: https://github.com/apache/apisix-dashboard/pull/503
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
moonming commented on issue #2152:
URL: https://github.com/apache/apisix/issues/2152#issuecomment-696609227
> I'd like to work on this after finish etcd v3 upgrade. [Chaos
Mesh](https://github.com/chaos-mesh/chaos-mesh) seems to have quite an active
community. I'd like to give it a try on
moonming closed issue #2277:
URL: https://github.com/apache/apisix/issues/2277
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
spacewander commented on issue #500:
URL:
https://github.com/apache/apisix-dashboard/issues/500#issuecomment-696484794
CC @MrLightSpeed0
This is an automated message from the Apache Git Service.
To respond to the message,
juzhiyuan merged pull request #502:
URL: https://github.com/apache/apisix-dashboard/pull/502
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Yiyiyimu commented on issue #2277:
URL: https://github.com/apache/apisix/issues/2277#issuecomment-69046
A good reference could be Kafka:
cn doc: https://kafka.apachecn.org/documentation.html#brokerconfigs
en doc: https://kafka.apache.org/documentation/#brokerconfigs
membphis commented on issue #2275:
URL: https://github.com/apache/apisix/issues/2275#issuecomment-696549936
@Firstsawyou you can take a look at this issue.
https://github.com/apache/apisix/pull/2270/files#diff-dfbae0bb78c37ecbf8879c21157751ffR71,
we can implement it in a simpler
Yiyiyimu commented on issue #2152:
URL: https://github.com/apache/apisix/issues/2152#issuecomment-696703573
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
nic-chen commented on issue #499:
URL:
https://github.com/apache/apisix-dashboard/issues/499#issuecomment-696526023
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
moonming commented on a change in pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#discussion_r492793961
##
File path: doc/plugins/limit-req.md
##
@@ -37,7 +40,7 @@ limit request rate using the "leaky bucket" method.
|- ||---|
juzhiyuan commented on issue #458:
URL:
https://github.com/apache/apisix-dashboard/issues/458#issuecomment-696536079
Could we close this issue @LiteSun
This is an automated message from the Apache Git Service.
To respond
MrLightSpeed0 commented on issue #2272:
URL: https://github.com/apache/apisix/issues/2272#issuecomment-697055088
very nice. thank you so much. that worked well. I can now start apisix! I
will follow up on the dashboard question in the other board. let me close this
"issue" and I will open
juzhiyuan closed issue #434:
URL: https://github.com/apache/apisix-dashboard/issues/434
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
membphis commented on issue #2262:
URL: https://github.com/apache/apisix/issues/2262#issuecomment-696556096
if you wants to enalbe specified plugins, you can set a new plugin list in
file `conf/config.yaml`.
here is an example, it only enabled `limit-***` plugins.
```yaml
membphis commented on a change in pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#discussion_r492519914
##
File path: doc/plugins/limit-req.md
##
@@ -104,6 +107,78 @@ Server: APISIX web server
This means that the limit req plugin is in effect.
+### How
membphis commented on a change in pull request #2265:
URL: https://github.com/apache/apisix/pull/2265#discussion_r492527705
##
File path: doc/plugins/consumer-restriction.md
##
@@ -20,31 +20,38 @@
- [中文](../zh-cn/plugins/consumer-restriction.md)
# Summary
--
Firstsawyou commented on a change in pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#discussion_r492527688
##
File path: doc/plugins/limit-req.md
##
@@ -21,11 +21,14 @@
# Summary
-- [**Name**](#name)
-- [**Attributes**](#attributes)
-- [**How To
idbeta commented on issue #2152:
URL: https://github.com/apache/apisix/issues/2152#issuecomment-696608407
@Yiyiyimu ,i am also interested in Chaos Testing for Apache APISIX，hope to
do this with you
This is an
moonming commented on pull request #2265:
URL: https://github.com/apache/apisix/pull/2265#issuecomment-696786945
According to the commit msg, I don't know what the problem this pr solves.
This is an automated message from
spacewander edited a comment on issue #2272:
URL: https://github.com/apache/apisix/issues/2272#issuecomment-696483718
For the first problem, you can also disable `enable_ipv6` in the
config.yaml. There is no need to modify the template code directly.
Firstsawyou commented on pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#issuecomment-696672681
@membphis review required.
This is an automated message from the Apache Git Service.
To respond to the
moonming closed pull request #2205:
URL: https://github.com/apache/apisix/pull/2205
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
moonming merged pull request #2278:
URL: https://github.com/apache/apisix/pull/2278
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
juzhiyuan commented on issue #487:
URL:
https://github.com/apache/apisix-dashboard/issues/487#issuecomment-696499553
Cannot reproduce this issue according to the latest commit[1], if this issue
still occurred, please provide your installation steps, tks.
[1]
juzhiyuan commented on issue #434:
URL:
https://github.com/apache/apisix-dashboard/issues/434#issuecomment-696473359
fe https://github.com/apache/apisix-dashboard/issues/498
This is an automated message from the Apache Git
ShiningRush commented on issue #466:
URL:
https://github.com/apache/apisix-dashboard/issues/466#issuecomment-696748494
OK, I will consider this issue tomorrow, and may need to have little change
in architecture.
This is an
juzhiyuan closed issue #499:
URL: https://github.com/apache/apisix-dashboard/issues/499
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Yiyiyimu commented on issue #2272:
URL: https://github.com/apache/apisix/issues/2272#issuecomment-696465640
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
juzhiyuan closed issue #480:
URL: https://github.com/apache/apisix-dashboard/issues/480
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
moonming closed issue #2195:
URL: https://github.com/apache/apisix/issues/2195
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Firstsawyou commented on pull request #2265:
URL: https://github.com/apache/apisix/pull/2265#issuecomment-696469427
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
membphis commented on a change in pull request #2268:
URL: https://github.com/apache/apisix/pull/2268#discussion_r492435682
##
File path: apisix/admin/init.lua
##
@@ -108,6 +109,11 @@ local function run()
seg_sub_path = core.table.concat(uri_segs, "/", 7)
end
+
juzhiyuan commented on issue #498:
URL:
https://github.com/apache/apisix-dashboard/issues/498#issuecomment-696473955
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
juzhiyuan closed issue #487:
URL: https://github.com/apache/apisix-dashboard/issues/487
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Firstsawyou commented on a change in pull request #2265:
URL: https://github.com/apache/apisix/pull/2265#discussion_r492538624
##
File path: doc/plugins/consumer-restriction.md
##
@@ -20,31 +20,38 @@
- [中文](../zh-cn/plugins/consumer-restriction.md)
# Summary
--
MrLightSpeed0 closed issue #2272:
URL: https://github.com/apache/apisix/issues/2272
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
liuxiran commented on issue #499:
URL:
https://github.com/apache/apisix-dashboard/issues/499#issuecomment-696476300
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
nic-chen commented on issue #500:
URL:
https://github.com/apache/apisix-dashboard/issues/500#issuecomment-697117973
> Hi I disabled the GoProxy. but got the same error. so it is for something
else. I am behind a company proxy and I do have http_proxy and https_proxy set
up in the system
moonming commented on pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#issuecomment-697116268
the commit msg ` feat: The "limit-req" plugin supports flow control based on
the "consumer"` is unclear, what is ` flow control`?
membphis commented on pull request #2268:
URL: https://github.com/apache/apisix/pull/2268#issuecomment-697116275
@gxthrj please take a look at this PR
This is an automated message from the Apache Git Service.
To respond to
moonming commented on a change in pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#discussion_r493178615
##
File path: t/plugin/limit-req.t
##
@@ -432,3 +432,367 @@ GET /t
passed
--- no_error_log
[error]
+
+
+
+=== TEST 12: consumer binds the limit-req
moonming commented on a change in pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#discussion_r493178615
##
File path: t/plugin/limit-req.t
##
@@ -432,3 +432,367 @@ GET /t
passed
--- no_error_log
[error]
+
+
+
+=== TEST 12: consumer binds the limit-req
moonming commented on a change in pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#discussion_r493178364
##
File path: t/plugin/limit-req.t
##
@@ -432,3 +432,367 @@ GET /t
passed
--- no_error_log
[error]
+
+
+
+=== TEST 12: consumer binds the limit-req
moonming commented on a change in pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#discussion_r493177968
##
File path: t/plugin/limit-req.t
##
@@ -432,3 +432,367 @@ GET /t
passed
--- no_error_log
[error]
+
+
+
+=== TEST 12: consumer binds the limit-req
moonming commented on a change in pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#discussion_r493177821
##
File path: apisix/plugins/limit-req.lua
##
@@ -67,7 +67,12 @@ function _M.access(conf, ctx)
return 500
end
-local key =
moonming commented on a change in pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#discussion_r493177709
##
File path: apisix/plugins/limit-req.lua
##
@@ -67,7 +67,12 @@ function _M.access(conf, ctx)
return 500
end
-local key =
moonming commented on a change in pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#discussion_r493176927
##
File path: doc/plugins/limit-req.md
##
@@ -37,7 +40,7 @@ limit request rate using the "leaky bucket" method.
|- ||---|
liuxiran opened a new pull request #506:
URL: https://github.com/apache/apisix-dashboard/pull/506
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
-
Yiyiyimu opened a new pull request #2282:
URL: https://github.com/apache/apisix/pull/2282
### What this PR does / why we need it:
fix #2262 and other doc typos
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have
Yiyiyimu commented on issue #2262:
URL: https://github.com/apache/apisix/issues/2262#issuecomment-697108837
thx!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tokers commented on pull request #2279:
URL: https://github.com/apache/apisix/pull/2279#issuecomment-697108446
@imjoey One thing confuses me that the labels field is attached on the whole
`upstream` object, It's closer to the labels on Kubernetes Service, not the
Pod, and labels on Pod
membphis commented on a change in pull request #2279:
URL: https://github.com/apache/apisix/pull/2279#discussion_r493169984
##
File path: apisix/schema_def.lua
##
@@ -332,6 +332,10 @@ local upstream_schema = {
description = "enable websocket for request",
juzhiyuan commented on issue #498:
URL:
https://github.com/apache/apisix-dashboard/issues/498#issuecomment-697101592
@nic-chen will help to deal with the issue about "How to resolve those
fields in MySQL".
cc @liuxiran
membphis commented on pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#issuecomment-697099061
@Firstsawyou conflicted, please rebase your branch
This is an automated message from the Apache Git Service.
To
membphis commented on a change in pull request #2279:
URL: https://github.com/apache/apisix/pull/2279#discussion_r493163377
##
File path: apisix/schema_def.lua
##
@@ -332,6 +332,10 @@ local upstream_schema = {
description = "enable websocket for request",
Yiyiyimu opened a new issue #2281:
URL: https://github.com/apache/apisix/issues/2281
### Issue description
In
[config-default.yaml](https://github.com/apache/apisix/blob/84ce7ba781affbf93c136ea5d3e2e12460ebe4ed/conf/config-default.yaml),
log-rotate is not enabled as default, but
juzhiyuan closed issue #494:
URL: https://github.com/apache/apisix-dashboard/issues/494
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
juzhiyuan commented on issue #500:
URL:
https://github.com/apache/apisix-dashboard/issues/500#issuecomment-697089282
ping @nic-chen
This is an automated message from the Apache Git Service.
To respond to the message,
juzhiyuan commented on issue #493:
URL:
https://github.com/apache/apisix-dashboard/issues/493#issuecomment-697086765
> I have a pr on the way to modify i18n refer to the Proposal #331, which
has been Interrupted by feature development,
> If there are no major changes about the
MrLightSpeed0 commented on issue #500:
URL:
https://github.com/apache/apisix-dashboard/issues/500#issuecomment-697081400
Hi I disabled the GoProxy. but got the same error. so it is for something
else. I am behind a company proxy and I do have http_proxy and https_proxy set
up in the
liuxiran edited a comment on issue #493:
URL:
https://github.com/apache/apisix-dashboard/issues/493#issuecomment-697076611
I have a pr on the way to modify i18n refer to the Proposal #331, which has
been Interrupted by feature development,
If there are no major changes about the
liuxiran commented on issue #493:
URL:
https://github.com/apache/apisix-dashboard/issues/493#issuecomment-697076611
I have a pr on the way to modify i18n refer to the Proposal #331, which have
been Interrupted by feature development,
If there are no major changes about the proposal,
Firstsawyou commented on a change in pull request #2270:
URL: https://github.com/apache/apisix/pull/2270#discussion_r493137344
##
File path: apisix/plugins/limit-req.lua
##
@@ -67,7 +67,12 @@ function _M.access(conf, ctx)
return 500
end
-local key =
Yiyiyimu commented on a change in pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#discussion_r493136275
##
File path: bin/apisix
##
@@ -940,6 +940,22 @@ function _M.start(...)
end
end
+local argparse = require "argparse"
+local
MrLightSpeed0 opened a new issue #2280:
URL: https://github.com/apache/apisix/issues/2280
### Issue description
Hello,
I was able to start apisix and I am following this
[page](https://github.com/apache/apisix/blob/master/doc/getting-started.md) to
get started:
I was able to
liuxiran commented on issue #499:
URL:
https://github.com/apache/apisix-dashboard/issues/499#issuecomment-697060108
> @liuxiran
> `base_url` is:
> http://apisix-admin-svc:9080/apisix/admin
>
> I think we should judge the value of res before using it :
>
nic-chen commented on issue #499:
URL:
https://github.com/apache/apisix-dashboard/issues/499#issuecomment-697059368
@liuxiran
`base_url` is:
http://apisix-admin-svc:9080/apisix/admin
I think we should judge the value of res before using it :
MrLightSpeed0 closed issue #2272:
URL: https://github.com/apache/apisix/issues/2272
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
MrLightSpeed0 commented on issue #2272:
URL: https://github.com/apache/apisix/issues/2272#issuecomment-697055088
very nice. thank you so much. that worked well. I can now start apisix! I
will follow up on the dashboard question in the other board. let me close this
"issue" and I will open
1 - 100 of 160 matches
Mail list logo
