[GitHub] [apisix] membphis commented on issue #2362: prometheus plugin publicly exposes metrics, even if not enabled

2020-10-06 Thread GitBox
membphis commented on issue #2362: URL: https://github.com/apache/apisix/issues/2362#issuecomment-704674396 @poidl Thank you very much for your reminder, I think we need to solve this issue in version `2.0` . This is an auto

[GitHub] [apisix] spacewander commented on a change in pull request #2029: bugfix: only set one response header when enabled `enable_debug=true`

2020-10-06 Thread GitBox
spacewander commented on a change in pull request #2029: URL: https://github.com/apache/apisix/pull/2029#discussion_r500713424 ## File path: apisix/plugin.lua ## @@ -228,13 +228,34 @@ function _M.api_routes() end -function _M.filter(user_route, plugins) +local function set

[GitHub] [apisix] spacewander commented on a change in pull request #2029: bugfix: only set one response header when enabled `enable_debug=true`

2020-10-06 Thread GitBox
spacewander commented on a change in pull request #2029: URL: https://github.com/apache/apisix/pull/2029#discussion_r500709172 ## File path: apisix/plugin.lua ## @@ -228,13 +228,34 @@ function _M.api_routes() end -function _M.filter(user_route, plugins) +local function set

[GitHub] [apisix] spacewander opened a new pull request #2363: doc(ip-restriction): IPv6 already supported

2020-10-06 Thread GitBox
spacewander opened a new pull request #2363: URL: https://github.com/apache/apisix/pull/2363 ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #538: bug: authentication security issue

2020-10-06 Thread GitBox
juzhiyuan commented on issue #538: URL: https://github.com/apache/apisix-dashboard/issues/538#issuecomment-704625515 would this be fixed in 1.6 before 16.10? This is an automated message from the Apache Git Service. To respo

[GitHub] [apisix] tristan-tsl closed issue #2360: request help: i'm interesting in plugin orchestration, can you provide a video for use it? thank you

2020-10-06 Thread GitBox
tristan-tsl closed issue #2360: URL: https://github.com/apache/apisix/issues/2360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] tristan-tsl commented on issue #2360: request help: i'm interesting in plugin orchestration, can you provide a video for use it? thank you

2020-10-06 Thread GitBox
tristan-tsl commented on issue #2360: URL: https://github.com/apache/apisix/issues/2360#issuecomment-704593091 oh, yes, thank you This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] poidl opened a new issue #2362: prometheus plugin publicly exposes metrics, even if not enabled

2020-10-06 Thread GitBox
poidl opened a new issue #2362: URL: https://github.com/apache/apisix/issues/2362 I'm a beginner and want to return a 404 for a request to http://mydomain.example/apisix/prometheus/metrics. Additional to the issues (linked below) about exposing metrics publicly, which I find pr

[GitHub] [apisix-dashboard] nic-chen opened a new issue #538: bug: authentication security issue

2020-10-06 Thread GitBox
nic-chen opened a new issue #538: URL: https://github.com/apache/apisix-dashboard/issues/538 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ] Requirements - [ ] Feature or performance i

[GitHub] [apisix-dashboard] nic-chen opened a new issue #537: bug: respond status of api should keep same as `admin api` do

2020-10-06 Thread GitBox
nic-chen opened a new issue #537: URL: https://github.com/apache/apisix-dashboard/issues/537 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ x ] Bug - [ ] Requirements - [ ] Feature or performance

[GitHub] [apisix-dashboard] nic-chen commented on issue #536: bug: race detected during execution of test

2020-10-06 Thread GitBox
nic-chen commented on issue #536: URL: https://github.com/apache/apisix-dashboard/issues/536#issuecomment-704293013 @ShiningRush please take a look at https://github.com/nic-chen/incubator-apisix-dashboard/pull/7/checks?check_run_id=1212879646#step:6:274 -

[GitHub] [apisix-dashboard] nic-chen opened a new issue #536: bug: race detected during execution of test

2020-10-06 Thread GitBox
nic-chen opened a new issue #536: URL: https://github.com/apache/apisix-dashboard/issues/536 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ x ] Bug - [ ] Requirements - [ ] Feature or performance

[GitHub] [apisix] membphis opened a new issue #2361: perf: use `table.isarray` which is can be JIT compiled

2020-10-06 Thread GitBox
membphis opened a new issue #2361: URL: https://github.com/apache/apisix/issues/2361 We can use `table.isarray` to check whether the Lua table is a pure array-like table. https://github.com/apache/apisix/blob/master/apisix/core/config_local.lua#L60 Here is the doc link:

[GitHub] [apisix] moonming commented on pull request #2339: feature: breaker request by api

2020-10-06 Thread GitBox
moonming commented on pull request #2339: URL: https://github.com/apache/apisix/pull/2339#issuecomment-704284586 The previous review was not fixed,and the CI failed. I don't think this pr is ready for review. So I will not review this pr until it is really ready --

[GitHub] [apisix] membphis commented on issue #2360: request help: i'm interesting in plugin orchestration, can you provide a video for use it? thank you

2020-10-06 Thread GitBox
membphis commented on issue #2360: URL: https://github.com/apache/apisix/issues/2360#issuecomment-704280193 gif link: https://static.apiseven.com/low-code-api-gateway-example-en-US.gif mp4 link: https://static.apiseven.com/low-code-api-gateway-example-en-US.mp4 -

[GitHub] [apisix] membphis commented on issue #2359: work process 都会执行脚本中的ngx_timer_every 调度吗

2020-10-06 Thread GitBox
membphis commented on issue #2359: URL: https://github.com/apache/apisix/issues/2359#issuecomment-704278236 > 如何规避,让其中一个线程去执行就可以了 welcome PR for a better way ^_^ @sixinyiyu if possible, please use English in a public channel. We hope that more and more people from all o

[GitHub] [apisix] membphis commented on a change in pull request #2339: feature: breaker request by api

2020-10-06 Thread GitBox
membphis commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r500282768 ## File path: t/plugin/api-breaker.t ## @@ -0,0 +1,219 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] membphis commented on pull request #2339: feature: breaker request by api

2020-10-06 Thread GitBox
membphis commented on pull request #2339: URL: https://github.com/apache/apisix/pull/2339#issuecomment-704275765 @liuhengloveyou and please take a look at the output of CI, you need to fix them at first This is an automated

[GitHub] [apisix] moonming commented on a change in pull request #2339: feature: breaker request by api

2020-10-06 Thread GitBox
moonming commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r500226929 ## File path: apisix/plugins/api-breaker.lua ## @@ -0,0 +1,212 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contribut

[GitHub] [apisix] liuhengloveyou commented on pull request #2339: feature: breaker request by api

2020-10-06 Thread GitBox
liuhengloveyou commented on pull request #2339: URL: https://github.com/apache/apisix/pull/2339#issuecomment-704221556 > @liuhengloveyou is this PR still a draft? updated。 This is an automated message from the Apache

[GitHub] [apisix] tristan-tsl opened a new issue #2360: request help: i'm interesting in plugin orchestration, can you provide a video for use it? thank you

2020-10-06 Thread GitBox
tristan-tsl opened a new issue #2360: URL: https://github.com/apache/apisix/issues/2360 ### Issue description can you provide a video for use it? ### Environment * apisix version (cmd: `apisix version`): no * OS: no --

[GitHub] [apisix] sixinyiyu closed issue #2359: work process 都会执行脚本中的ngx_timer_every 调度吗

2020-10-06 Thread GitBox
sixinyiyu closed issue #2359: URL: https://github.com/apache/apisix/issues/2359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] sixinyiyu commented on issue #2359: work process 都会执行脚本中的ngx_timer_every 调度吗

2020-10-06 Thread GitBox
sixinyiyu commented on issue #2359: URL: https://github.com/apache/apisix/issues/2359#issuecomment-704186339 变量可见性 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [apisix] sixinyiyu removed a comment on issue #2359: work process 都会执行脚本中的ngx_timer_every 调度吗

2020-10-06 Thread GitBox
sixinyiyu removed a comment on issue #2359: URL: https://github.com/apache/apisix/issues/2359#issuecomment-704159309 知道原因了,操作的是自己工作线程里的变量,如果将applications 申明成 lua_shared_dict 所有线程可见呢;然后保证一个线程去更新 This is an automated message f

[GitHub] [apisix] sixinyiyu edited a comment on issue #2359: work process 都会执行脚本中的ngx_timer_every 调度吗

2020-10-06 Thread GitBox
sixinyiyu edited a comment on issue #2359: URL: https://github.com/apache/apisix/issues/2359#issuecomment-704159309 知道原因了,操作的是自己工作线程里的变量,如果将applications 申明成 lua_shared_dict 所有线程可见呢;然后保证一个线程去更新 This is an automated message fr

[GitHub] [apisix] membphis edited a comment on issue #2280: Route traffic through company proxy / firewall

2020-10-06 Thread GitBox
membphis edited a comment on issue #2280: URL: https://github.com/apache/apisix/issues/2280#issuecomment-704010247 > You can achieve the same effect with [proxy-rewrite](https://github.com/apache/apisix/blob/master/doc/zh-cn/plugins/proxy-rewrite.md) can you show us an example of thi

[GitHub] [apisix] membphis merged pull request #2352: feat: add referer-restriction plugin

2020-10-06 Thread GitBox
membphis merged pull request #2352: URL: https://github.com/apache/apisix/pull/2352 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis commented on pull request #2352: feat: add referer-restriction plugin

2020-10-06 Thread GitBox
membphis commented on pull request #2352: URL: https://github.com/apache/apisix/pull/2352#issuecomment-704174836 @spacewander merged, many thx This is an automated message from the Apache Git Service. To respond to the messag

[apisix] branch master updated: feat: implemented `referer-restriction` plugin (#2352)

2020-10-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 5b97223 feat: implemented `referer-restrictio

[GitHub] [apisix] membphis closed issue #2267: feature: The "limit-req" plugin adds the "consumer_name" method to limit the request speed.

2020-10-06 Thread GitBox
membphis closed issue #2267: URL: https://github.com/apache/apisix/issues/2267 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] membphis merged pull request #2270: feature: support `consumer_name` as key of `limit-req` plugin.

2020-10-06 Thread GitBox
membphis merged pull request #2270: URL: https://github.com/apache/apisix/pull/2270 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: feature: support `consumer_name` as key for `limit-req` plugin. (#2270)

2020-10-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new c3de84e feature: support `consumer_name` as k

[GitHub] [apisix] spacewander commented on issue #2280: Route traffic through company proxy / firewall

2020-10-06 Thread GitBox
spacewander commented on issue #2280: URL: https://github.com/apache/apisix/issues/2280#issuecomment-704172006 @MrLightSpeed0 How we can use the forward proxy depends on the type of forward proxy your company using. What kind of proxy you are using? Plain http or https or socks?

[GitHub] [apisix] sixinyiyu closed issue #2358: use discovery failed to pick server: discovery is uninitialized while connecting to upstream, client

2020-10-06 Thread GitBox
sixinyiyu closed issue #2358: URL: https://github.com/apache/apisix/issues/2358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] sixinyiyu commented on issue #2358: use discovery failed to pick server: discovery is uninitialized while connecting to upstream, client

2020-10-06 Thread GitBox
sixinyiyu commented on issue #2358: URL: https://github.com/apache/apisix/issues/2358#issuecomment-704161781 可能是工作线程没有杀死,导致的 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [apisix] spacewander commented on issue #1226: feature: Support follow redirect

2020-10-06 Thread GitBox
spacewander commented on issue #1226: URL: https://github.com/apache/apisix/issues/1226#issuecomment-704156541 IMHO, I don't like this idea because it doesn't obey the HTTP "convention". Clients like curl can follow redirect because they are clients, but let the proxy follow the redirect l

[GitHub] [apisix] sixinyiyu opened a new issue #2359: work process 都会执行脚本中的ngx_timer_every 调度吗

2020-10-06 Thread GitBox
sixinyiyu opened a new issue #2359: URL: https://github.com/apache/apisix/issues/2359 ### Issue description discovery 里的nacos.lua会在启动时拉取一下服务列表,我这里打印了下日志 ![QQ图片20201006174034](https://user-images.githubusercontent.com/3435446/95185355-30b0a200-07fb-11eb-9a4f-f9cbca0e129d.png) 同时也显示

[GitHub] [apisix] sixinyiyu opened a new issue #2358: use discovery failed to pick server: discovery is uninitialized while connecting to upstream, client

2020-10-06 Thread GitBox
sixinyiyu opened a new issue #2358: URL: https://github.com/apache/apisix/issues/2358 ### Issue description discovey Nacos 配置路由后,能通过服务名 找到具体实例 走通,但是会存在有一定间隔时间 502 找不到服务,java服务在nacos一直存在没有下线,尝试修改了定时拉取nacos服务信息的间隔时间(30-->20s) 并没有作用 ### Environment * apisix version (cmd: `a