ShiningRush commented on issue #758:
URL:
https://github.com/apache/apisix-dashboard/issues/758#issuecomment-728753099
Out project is follow
[project-layout](https://github.com/golang-standards/project-layout), if we
want other library can use those errors then we can move errors to
moonming commented on issue #2110:
URL: https://github.com/apache/apisix/issues/2110#issuecomment-728751134
Is there a relationship between these two configurations?
This is an automated message from the Apache Git Service.
spacewander commented on issue #2764:
URL: https://github.com/apache/apisix/issues/2764#issuecomment-728750519
@jenskeiner
Thanks for your detailed report. Would you submit a bugfix for it?
This is an automated message
moonming commented on pull request #816:
URL: https://github.com/apache/apisix-dashboard/pull/816#issuecomment-728749330
I’m not sure if the installation document needs to be modified because the
format of the package has changed
moonming commented on pull request #816:
URL: https://github.com/apache/apisix-dashboard/pull/816#issuecomment-728749007
@nic-chen please check the CI
This is an automated message from the Apache Git Service.
To respond to
moonming commented on a change in pull request #2727:
URL: https://github.com/apache/apisix/pull/2727#discussion_r524934920
##
File path: apisix/plugins/zipkin/reporter.lua
##
@@ -105,38 +104,68 @@ function _M.report(self, span)
annotations = span.logs
}
-
moonming commented on a change in pull request #2727:
URL: https://github.com/apache/apisix/pull/2727#discussion_r524934920
##
File path: apisix/plugins/zipkin/reporter.lua
##
@@ -105,38 +104,68 @@ function _M.report(self, span)
annotations = span.logs
}
-
LiteSun opened a new pull request #816:
URL: https://github.com/apache/apisix-dashboard/pull/816
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- Related
moonming opened a new pull request #2773:
URL: https://github.com/apache/apisix/pull/2773
### What this PR does / why we need it:
fix https://github.com/apache/apisix/issues/2762
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR
moonming commented on a change in pull request #810:
URL: https://github.com/apache/apisix-dashboard/pull/810#discussion_r524931901
##
File path: api/test/e2e/route_service_upstream_test.go
##
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
membphis commented on issue #2573:
URL: https://github.com/apache/apisix/issues/2573#issuecomment-728740258
Okay, I got it. I have changed the milestone to the 2.2.
This is an automated message from the Apache Git Service.
EnableAsync commented on a change in pull request #810:
URL: https://github.com/apache/apisix-dashboard/pull/810#discussion_r524924566
##
File path: api/test/e2e/route_service_upstream_test.go
##
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
EnableAsync commented on a change in pull request #810:
URL: https://github.com/apache/apisix-dashboard/pull/810#discussion_r524924440
##
File path: api/test/e2e/route_service_upstream_test.go
##
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
idbeta commented on issue #2573:
URL: https://github.com/apache/apisix/issues/2573#issuecomment-728730850
Sorry, I think I can not finish it this week. @moonming @membphis
This is an automated message from the Apache Git
nic-chen commented on issue #813:
URL:
https://github.com/apache/apisix-dashboard/issues/813#issuecomment-728727929
> Accessible through other pods
could you please use pod ip to start dashboard, so that you could try
access(using etcdctl) to etcd from the pod of the dashboard.
nic-chen edited a comment on issue #813:
URL:
https://github.com/apache/apisix-dashboard/issues/813#issuecomment-728727929
> Accessible through other pods
could you please use pod ip to start dashboard, so that you could try
access(using etcdctl) to etcd from the pod of the
nic-chen commented on issue #2110:
URL: https://github.com/apache/apisix/issues/2110#issuecomment-728726691
Oh, `https_admin` is disable by default:
https://github.com/apache/apisix/blob/1aefe915f1a01ff7d068cfe7013676bfece2d43e/conf/config-default.yaml#L61
but, `ssl` is enable by
juzhiyuan closed pull request #87:
URL: https://github.com/apache/apisix-website/pull/87
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
backnero commented on issue #813:
URL:
https://github.com/apache/apisix-dashboard/issues/813#issuecomment-728707258
Accessible through other pods
This is an automated message from the Apache Git Service.
To respond to the
Firstsawyou commented on a change in pull request #2749:
URL: https://github.com/apache/apisix/pull/2749#discussion_r524888967
##
File path: apisix/plugins/hmac-auth.lua
##
@@ -194,14 +209,28 @@ local function generate_signature(ctx, secret_key, params)
end
spacewander opened a new pull request #2772:
URL: https://github.com/apache/apisix/pull/2772
Fix #2771.
### What this PR does / why we need it:
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features
have been
Firstsawyou commented on issue #2501:
URL: https://github.com/apache/apisix/issues/2501#issuecomment-728689217
assigned to me.
This is an automated message from the Apache Git Service.
To respond to the message, please log
Firstsawyou commented on issue #2501:
URL: https://github.com/apache/apisix/issues/2501#issuecomment-728689118
I will submit a PR later to solve this problem.
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a change to annotated tag v2.0-rc5
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
*** WARNING: tag v2.0-rc5 was modified! ***
from 59515b5 (commit)
to b9602c7 (tag)
tagging
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a change to annotated tag v2.0-rc5
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
*** WARNING: tag v2.0-rc5 was modified! ***
from 59515b5 (commit)
to b9602c7 (tag)
tagging
juzhiyuan opened a new issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815
TODO
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
idbeta commented on issue #2771:
URL: https://github.com/apache/apisix/issues/2771#issuecomment-728673089
It is indeed a problem, thanks for the feedback.
This is an automated message from the Apache Git Service.
To respond
juzhiyuan commented on a change in pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#discussion_r524867441
##
File path: FAQ.md
##
@@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling
HTTP requests. If you
```
2. Reload or
juzhiyuan commented on issue #812:
URL:
https://github.com/apache/apisix-dashboard/issues/812#issuecomment-728668358
Yep, and there will have a proposal to let the community check.
This is an automated message from the
JanLi-air commented on issue #2771:
URL: https://github.com/apache/apisix/issues/2771#issuecomment-728666287
It's very critical, should take priority to fix this.
Suppose this case:
1. Put a upstream with id foobar.
2. Put a route which refers to upstream foo.
3. Instead
nic-chen commented on issue #813:
URL:
https://github.com/apache/apisix-dashboard/issues/813#issuecomment-728663602
@backnero
Could you try to access `gateway-etcd.default.svc.cluster.local:2379` or the
cluster ip from the pod of the dashboard?
spacewander commented on a change in pull request #2676:
URL: https://github.com/apache/apisix/pull/2676#discussion_r524860338
##
File path: apisix/balancer/chash.lua
##
@@ -68,8 +68,13 @@ function _M.new(up_nodes, upstream)
return {
upstream = upstream,
spacewander commented on pull request #2676:
URL: https://github.com/apache/apisix/pull/2676#issuecomment-728662156
Please write new test to verify the fix and make sure the tests are passed.
This is an automated message
spacewander commented on issue #2770:
URL: https://github.com/apache/apisix/issues/2770#issuecomment-728662239
PR: #2676
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Yiyiyimu commented on issue #2110:
URL: https://github.com/apache/apisix/issues/2110#issuecomment-728661264
> We could throw an error when `https_admin` is `true`, but `cert` and `key`
are not configured.
Sure thx
> > the default of
Gary-Airwallex opened a new issue #2771:
URL: https://github.com/apache/apisix/issues/2771
### Issue description
Admin api appears to match config Id by prefix instead of an exact string
match.
### Environment
* apisix version (cmd: `apisix version`): 2.0
* OS: osx +
backnero commented on issue #813:
URL:
https://github.com/apache/apisix-dashboard/issues/813#issuecomment-728656565
In the rancher2.4 +K8S environment, success can be achieved by configuring
the pod ip. The disadvantage is that when the ip changes, you need to modify
the configuration
idbeta commented on issue #813:
URL:
https://github.com/apache/apisix-dashboard/issues/813#issuecomment-728654655
@nic-chen could you help answer this question when you are free?
This is an automated message from the Apache
spacewander commented on a change in pull request #2749:
URL: https://github.com/apache/apisix/pull/2749#discussion_r524851784
##
File path: apisix/plugins/hmac-auth.lua
##
@@ -194,14 +209,28 @@ local function generate_signature(ctx, secret_key, params)
end
juzhiyuan commented on a change in pull request #810:
URL: https://github.com/apache/apisix-dashboard/pull/810#discussion_r524831071
##
File path: api/test/e2e/route_service_upstream_test.go
##
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ziyou434 commented on issue #812:
URL:
https://github.com/apache/apisix-dashboard/issues/812#issuecomment-728648915
> 这将在2.1中解决
I think this issue is similar to #532 .
User need to define plugin's type by themselves.
juzhiyuan commented on a change in pull request #811:
URL: https://github.com/apache/apisix-dashboard/pull/811#discussion_r524846125
##
File path: api/conf/conf.yaml
##
@@ -22,6 +22,8 @@ conf:
etcd:
endpoints: # supports defining multiple etcd host addresses for an
zfs123 opened a new issue #2770:
URL: https://github.com/apache/apisix/issues/2770
### Issue description
when upstream_type is chash, if last picked server does not work, apisix
won't pick next server because of the unchanged chash_key, which make the
function set_more_tries() to be
juzhiyuan commented on issue #812:
URL:
https://github.com/apache/apisix-dashboard/issues/812#issuecomment-728646060
This will be resolved in 2.1
This is an automated message from the Apache Git Service.
To respond to the
Firstsawyou commented on a change in pull request #2749:
URL: https://github.com/apache/apisix/pull/2749#discussion_r524843528
##
File path: apisix/plugins/hmac-auth.lua
##
@@ -194,14 +209,28 @@ local function generate_signature(ctx, secret_key, params)
end
juzhiyuan edited a comment on issue #814:
URL:
https://github.com/apache/apisix-dashboard/issues/814#issuecomment-728643965
We will keep both Form and code-mirror.
All plugins will support this, and it will resolve all most UI issues
finally!
juzhiyuan commented on issue #814:
URL:
https://github.com/apache/apisix-dashboard/issues/814#issuecomment-728643965
We will keep both Form and code-mirror.
All plugins will support this, and it will all most UI issues finally!
juzhiyuan commented on issue #814:
URL:
https://github.com/apache/apisix-dashboard/issues/814#issuecomment-728643029
We are working on a feature for the plugin module, that you could pass JSON
directly to API instead of using Form.
tokers commented on a change in pull request #2769:
URL: https://github.com/apache/apisix/pull/2769#discussion_r524841798
##
File path: conf/config-default.yaml
##
@@ -128,6 +128,7 @@ nginx_config: # config for render the
template to genarate n
#envs:
membphis commented on a change in pull request #2690:
URL: https://github.com/apache/apisix/pull/2690#discussion_r524838230
##
File path: bin/apisix
##
@@ -560,6 +560,27 @@ local function init_etcd(show_output)
for index, host in ipairs(yaml_conf.etcd.host) do
Applenice commented on issue #814:
URL:
https://github.com/apache/apisix-dashboard/issues/814#issuecomment-728635697
> Thanks for your feedback, the same reason as #793, there are some
transform errors in fe plugin component, and after the errors fixed,
`@api7-dashboard/plugin` will be
tzssangglass commented on a change in pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#discussion_r524834780
##
File path: FAQ.md
##
@@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling
HTTP requests. If you
```
2. Reload
ziyou434 commented on issue #813:
URL:
https://github.com/apache/apisix-dashboard/issues/813#issuecomment-728632034
I think you can search "retrying of unary invoker failed", there are many
problems about this on internet.
moonming commented on a change in pull request #807:
URL: https://github.com/apache/apisix-dashboard/pull/807#discussion_r524830489
##
File path: .gitignore
##
@@ -42,6 +42,9 @@ build
manager-api
output
+publish
Review comment:
agreed. @gxthrj please refer to other
moonming commented on a change in pull request #807:
URL: https://github.com/apache/apisix-dashboard/pull/807#discussion_r524830489
##
File path: .gitignore
##
@@ -42,6 +42,9 @@ build
manager-api
output
+publish
Review comment:
agreed. @gxthrj please refer to other
HelloBug0 opened a new pull request #2769:
URL: https://github.com/apache/apisix/pull/2769
### What this PR does / why we need it:
satify the need of [#2713](https://github.com/apache/apisix/issues/2713)
### Pre-submission checklist:
* [X] Did you explain what problem does
spacewander closed issue #158:
URL: https://github.com/apache/apisix/issues/158
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
spacewander commented on issue #158:
URL: https://github.com/apache/apisix/issues/158#issuecomment-728630511
Solved by #2584 . Server side TLS verification is enough to use by now.
This is an automated message from the
backnero commented on issue #813:
URL:
https://github.com/apache/apisix-dashboard/issues/813#issuecomment-728629844
I still get an error using the cluster ip
This is an automated message from the Apache Git Service.
To
moonming commented on a change in pull request #810:
URL: https://github.com/apache/apisix-dashboard/pull/810#discussion_r524826642
##
File path: api/test/e2e/route_service_upstream_test.go
##
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
HelloBug0 closed pull request #2765:
URL: https://github.com/apache/apisix/pull/2765
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
HelloBug0 closed pull request #2766:
URL: https://github.com/apache/apisix/pull/2766
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
spacewander commented on issue #788:
URL: https://github.com/apache/apisix/issues/788#issuecomment-728628491
Solved?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
spacewander closed issue #1268:
URL: https://github.com/apache/apisix/issues/1268
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
spacewander commented on issue #1268:
URL: https://github.com/apache/apisix/issues/1268#issuecomment-728627989
Solved.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
juzhiyuan commented on a change in pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#discussion_r524825421
##
File path: FAQ.md
##
@@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling
HTTP requests. If you
```
2. Reload or
spacewander opened a new pull request #2768:
URL: https://github.com/apache/apisix/pull/2768
### What this PR does / why we need it:
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features
have been added?
* [ ]
juzhiyuan commented on a change in pull request #807:
URL: https://github.com/apache/apisix-dashboard/pull/807#discussion_r524823060
##
File path: .gitignore
##
@@ -42,6 +42,9 @@ build
manager-api
output
+publish
Review comment:
We use `publish` as a folder is not
juzhiyuan commented on a change in pull request #807:
URL: https://github.com/apache/apisix-dashboard/pull/807#discussion_r524823060
##
File path: .gitignore
##
@@ -42,6 +42,9 @@ build
manager-api
output
+publish
Review comment:
We use `publish` as a folder is not
juzhiyuan commented on a change in pull request #807:
URL: https://github.com/apache/apisix-dashboard/pull/807#discussion_r524823060
##
File path: .gitignore
##
@@ -42,6 +42,9 @@ build
manager-api
output
+publish
Review comment:
We use `publish` as a folder is not
liuxiran commented on issue #814:
URL:
https://github.com/apache/apisix-dashboard/issues/814#issuecomment-728606950
Thanks for your feedback, the same reason as
https://github.com/apache/apisix-dashboard/issues/793, there are some transform
errors in fe plugin component, and after the
tzssangglass commented on a change in pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#discussion_r524820583
##
File path: FAQ.md
##
@@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling
HTTP requests. If you
```
2. Reload
HelloBug0 commented on pull request #2766:
URL: https://github.com/apache/apisix/pull/2766#issuecomment-728587183
> #2765 should be put into this one.
It occurs to me, but it's kind of awkward that I still don't know how to PR
once with two changed files in windows even after I
membphis commented on issue #2573:
URL: https://github.com/apache/apisix/issues/2573#issuecomment-728573593
@idbeta please confirm you finish this job in this week. if not, we change
this `Milestone` to `2.2`
This is an
ziyou434 commented on issue #813:
URL:
https://github.com/apache/apisix-dashboard/issues/813#issuecomment-728517186
you should try service's cluster IP .
I did this successfully.
This is an automated message from the
HelloBug0 commented on a change in pull request #2766:
URL: https://github.com/apache/apisix/pull/2766#discussion_r524806755
##
File path: conf/config-default.yaml
##
@@ -128,6 +128,7 @@ nginx_config: # config for render the
template to genarate n
membphis edited a comment on issue #2739:
URL: https://github.com/apache/apisix/issues/2739#issuecomment-728141812
@gewei2000 do you have fixed this issue? find out the reason?
what is it?
This is an automated message
Applenice closed issue #2695:
URL: https://github.com/apache/apisix/issues/2695
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
membphis commented on issue #2739:
URL: https://github.com/apache/apisix/issues/2739#issuecomment-728141812
@gewei2000 do you have fixed this issue? find out the reason?
what is is?
This is an automated message from
Applenice opened a new issue #814:
URL: https://github.com/apache/apisix-dashboard/issues/814
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [X] Bug
- [ ] Requirements
- [ ] Feature or performance
spacewander commented on pull request #2766:
URL: https://github.com/apache/apisix/pull/2766#issuecomment-728130999
#2765 should be put into this one.
This is an automated message from the Apache Git Service.
To respond to
spacewander commented on a change in pull request #2766:
URL: https://github.com/apache/apisix/pull/2766#discussion_r524345630
##
File path: conf/config-default.yaml
##
@@ -128,6 +128,7 @@ nginx_config: # config for render the
template to genarate n
Firstsawyou opened a new issue #2767:
URL: https://github.com/apache/apisix/issues/2767
### Issue description
The configuration field `cache_zone` of the cache zone in the plug-in is a
required item. I think this is unfriendly to some users who are not familiar
with this field.
HelloBug0 opened a new pull request #2766:
URL: https://github.com/apache/apisix/pull/2766
### What this PR does / why we need it:
satify the need of [#2713](https://github.com/apache/apisix/issues/2713)
### Pre-submission checklist:
* [X] Did you explain what problem does
HelloBug0 opened a new pull request #2765:
URL: https://github.com/apache/apisix/pull/2765
### What this PR does / why we need it:
satify the need of [#2713](https://github.com/apache/apisix/issues/2713)
### Pre-submission checklist:
* [X] Did you explain what problem does
gxthrj commented on a change in pull request #807:
URL: https://github.com/apache/apisix-dashboard/pull/807#discussion_r524300851
##
File path: Makefile
##
@@ -91,5 +93,10 @@ endif
.PHONY: release
release:
- tar –cf dashboard.tar ./output/*
+ tar -zcvf
gxthrj commented on a change in pull request #807:
URL: https://github.com/apache/apisix-dashboard/pull/807#discussion_r524300851
##
File path: Makefile
##
@@ -91,5 +93,10 @@ endif
.PHONY: release
release:
- tar –cf dashboard.tar ./output/*
+ tar -zcvf
tzssangglass commented on pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#issuecomment-728064962
> Is it better to add it to [health check
documentation](https://github.com/apache/apisix/blob/master/doc/zh-cn/health-check.md)?
I see the health check documentation
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new c1ac7d6 docs: add a English link of
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new c1ac7d6 docs: add a English link of
spacewander merged pull request #2753:
URL: https://github.com/apache/apisix/pull/2753
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gewei2000 closed issue #2739:
URL: https://github.com/apache/apisix/issues/2739
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jenskeiner opened a new issue #2764:
URL: https://github.com/apache/apisix/issues/2764
### Issue description
When using the OIDC plugin, it looks like request headers with the user
name/access token/id_token may not be set correctly in the code path where an
incoming request is
spacewander commented on issue #2050:
URL: https://github.com/apache/apisix/issues/2050#issuecomment-727922761
It can't happen now since we have removed the lock.
This is an automated message from the Apache Git Service.
To
spacewander closed issue #2050:
URL: https://github.com/apache/apisix/issues/2050
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gy09535 commented on pull request #2727:
URL: https://github.com/apache/apisix/pull/2727#issuecomment-727920569
Please confirm @moonming .
This is an automated message from the Apache Git Service.
To respond to the message,
spacewander commented on issue #2763:
URL: https://github.com/apache/apisix/issues/2763#issuecomment-727918338
The `arg_age` variable is for the query parameter in the URI (`?age=xxx`).
http://nginx.org/en/docs/http/ngx_http_core_module.html#variables
To route according to the
spacewander closed issue #2763:
URL: https://github.com/apache/apisix/issues/2763
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zhuchengxing opened a new issue #2763:
URL: https://github.com/apache/apisix/issues/2763
### Issue description
**1. I add a new route:**
{
"methods": [
"POST"
],
"uris": [
"/test"
],
"vars": [["arg_age","==","20"] ],
jxhecong commented on a change in pull request #2690:
URL: https://github.com/apache/apisix/pull/2690#discussion_r524048203
##
File path: bin/apisix
##
@@ -560,6 +560,23 @@ local function init_etcd(show_output)
for index, host in ipairs(yaml_conf.etcd.host) do
1 - 100 of 114 matches
Mail list logo
