[GitHub] [apisix-docker] nooperpudd opened a new issue #89: docker compose example start failed

nooperpudd opened a new issue #89: URL: https://github.com/apache/apisix-docker/issues/89 `sh gen-config-yaml.sh && docker-compose -p docker-apisix up -d` ERROR: for docker-apisix_apisix_1 UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)

[GitHub] [apisix-dashboard] nic-chen commented on issue #879: Support priority field in Route module

nic-chen commented on issue #879: URL: https://github.com/apache/apisix-dashboard/issues/879#issuecomment-734141419 > cc @nic-chen I remember the manager-api supports this field, right? > > cc @membphis sure, it has supported.

[GitHub] [apisix-docker] moonming commented on issue #89: docker compose example start failed

moonming commented on issue #89: URL: https://github.com/apache/apisix-docker/issues/89#issuecomment-734142688 @gxthrj please take a look This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #876: test: add consumer with username ( E2E )

idbeta commented on a change in pull request #876: URL: https://github.com/apache/apisix-dashboard/pull/876#discussion_r530839799 ## File path: api/test/e2e/consumer_test.go ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[GitHub] [apisix] spacewander commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

spacewander commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r530848742 ## File path: doc/upstream-status-5xx.md ## @@ -0,0 +1,151 @@ + + +[Chinese](zh-cn/upstream-status-5xx.md) + +## `5xx` response status code + +Similar

[GitHub] [apisix-dashboard] idbeta opened a new pull request #880: test: add consumer e2e test without username

idbeta opened a new pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [x] E2E test

[GitHub] [apisix-dashboard] liuxiran commented on issue #861: [Proposal]: Route group feature

liuxiran commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-734167015 > I think @liuxiran 's comment [#861 (comment)](https://github.com/apache/apisix-dashboard/issues/861#issuecomment-734089720) is fine for me. > > It is the way I woul

[GitHub] [apisix-dashboard] codecov-io commented on pull request #880: test: add consumer with incorrect input ( E2E )

codecov-io commented on pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#issuecomment-734167166 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/880?src=pr&el=h1) Report > Merging [#880](https://codecov.io/gh/apache/apisix-dashboard/pull/880?src

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #880: test: add consumer with incorrect input ( E2E )

membphis commented on a change in pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#discussion_r530866988 ## File path: api/test/e2e/consumer_test.go ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #880: test: add consumer with incorrect input ( E2E )

codecov-io edited a comment on pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#issuecomment-734167166 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/880?src=pr&el=h1) Report > Merging [#880](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #881: test: add e2e test cases for route with auth plugin

nic-chen opened a new pull request #881: URL: https://github.com/apache/apisix-dashboard/pull/881 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [x] E2E test

[apisix-website] branch asf-site updated: Deploy to GitHub pages

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 21896db Deploy to GitHub pages

[GitHub] [apisix-dashboard] membphis commented on issue #861: [Proposal]: Route group feature

membphis commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-734171979 We can wait for more time, maybe others want to say something This is an automated message from the Apache

[GitHub] [apisix-dashboard] liuxiran commented on issue #861: [Proposal]: Route group feature

liuxiran commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-734176961 > We can wait for more time, maybe others want to say something ok, that would be better ^-^ This is

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #880: test: add consumer with incorrect input ( E2E )

membphis commented on a change in pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#discussion_r530876380 ## File path: api/test/e2e/consumer_test.go ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [apisix] tokers commented on issue #2853: [DISCUSS] Pagination for fully synchronization from etcd

tokers commented on issue #2853: URL: https://github.com/apache/apisix/issues/2853#issuecomment-734181119 > Do we need to update the `lua-resty-etcd`? Yep, we shall. This is an automated message from the Apache Git Ser

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #880: test: add consumer with incorrect input ( E2E )

LiteSun commented on a change in pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#discussion_r530886474 ## File path: api/test/e2e/consumer_test.go ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[GitHub] [apisix] tokers commented on issue #2853: [DISCUSS] Pagination for fully synchronization from etcd

tokers commented on issue #2853: URL: https://github.com/apache/apisix/issues/2853#issuecomment-734181817 > I think we should let user choose whether to enable pagination and the step size. If pagination is enable, the sync time will be longer, which may be bad for some cases. We ca

[GitHub] [apisix] tokers commented on issue #2853: [DISCUSS] Pagination for fully synchronization from etcd

tokers commented on issue #2853: URL: https://github.com/apache/apisix/issues/2853#issuecomment-734181956 > > lua-resty-etcd > > If we need, may I have a try on this issue. It seems not that hard. PR's Welcome!

[GitHub] [apisix] tokers edited a comment on issue #2853: [DISCUSS] Pagination for fully synchronization from etcd

tokers edited a comment on issue #2853: URL: https://github.com/apache/apisix/issues/2853#issuecomment-734181817 > I think we should let user choose whether to enable pagination and the step size. If pagination is enable, the sync time will be longer, which may be bad for some cases.

[GitHub] [apisix] membphis commented on pull request #2846: feat: confirm only part of the etcd kvs

membphis commented on pull request #2846: URL: https://github.com/apache/apisix/pull/2846#issuecomment-734185876 Yes, you are right. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] idbeta commented on pull request #876: test: add consumer with key-auth ( E2E )

idbeta commented on pull request #876: URL: https://github.com/apache/apisix-dashboard/pull/876#issuecomment-734187351 ping @gxthrj This is an automated message from the Apache Git Service. To respond to the message, please

[apisix-dashboard] branch master updated: test: add consumer with key-auth ( E2E ) (#876)

This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new caab4f7 test: add consumer with key-auth

[GitHub] [apisix-dashboard] gxthrj merged pull request #876: test: add consumer with key-auth ( E2E )

gxthrj merged pull request #876: URL: https://github.com/apache/apisix-dashboard/pull/876 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] spacewander opened a new pull request #2856: fix: validate plugin configuration in the DP

spacewander opened a new pull request #2856: URL: https://github.com/apache/apisix/pull/2856 Fix #2834 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been add

[apisix-dashboard] branch master updated: test: add e2e test cases for route with auth plugin (#881)

This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 14a12d3 test: add e2e test cases for rou

[GitHub] [apisix-dashboard] gxthrj merged pull request #881: test: add e2e test cases for route with auth plugin

gxthrj merged pull request #881: URL: https://github.com/apache/apisix-dashboard/pull/881 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] membphis commented on pull request #2856: fix: validate plugin configuration in the DP

membphis commented on pull request #2856: URL: https://github.com/apache/apisix/pull/2856#issuecomment-734195603 wow, That is a nice PR This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [apisix] membphis commented on pull request #2856: fix: validate plugin configuration in the DP

membphis commented on pull request #2856: URL: https://github.com/apache/apisix/pull/2856#issuecomment-734195990 @spacewander Please update the checklist This is an automated message from the Apache Git Service. To respond t

[GitHub] [apisix-docker] gxthrj commented on issue #89: docker compose example start failed

gxthrj commented on issue #89: URL: https://github.com/apache/apisix-docker/issues/89#issuecomment-734207097 @nooperpudd Would you please show me `docker ps`? I exec `sh gen-config-yaml.sh && docker-compose -p docker-apisix up -d` in a new centos7 just now. Get success. ![image](ht

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #874: test: add E2E testcase about add route with invalid request body

idbeta commented on a change in pull request #874: URL: https://github.com/apache/apisix-dashboard/pull/874#discussion_r530920622 ## File path: api/test/e2e/route_e2e_remote_addr_test.go ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #882: test: add e2e test cases for route with limit plugin

nic-chen opened a new pull request #882: URL: https://github.com/apache/apisix-dashboard/pull/882 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [x] E2E test

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #874: test: add E2E testcase about add route with invalid request body

membphis commented on a change in pull request #874: URL: https://github.com/apache/apisix-dashboard/pull/874#discussion_r530933243 ## File path: api/test/e2e/route_remote_addr_test.go ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix-dashboard] moonming commented on a change in pull request #880: test: add consumer with incorrect input ( E2E )

moonming commented on a change in pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#discussion_r530941014 ## File path: api/test/e2e/consumer_test.go ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [apisix] jenskeiner opened a new issue #2857: bug: authz-keycloak plugin should run in access phase.

jenskeiner opened a new issue #2857: URL: https://github.com/apache/apisix/issues/2857 ### Issue description The `authz-keycloak` plugin currently runs in the Openresty *rewrite* lifecycle phase. This is in line with the plugin development guidelines: "In APISIX, the authentication logi

[GitHub] [apisix] jenskeiner opened a new pull request #2858: 2857 authz keycloak should run in access phase

jenskeiner opened a new pull request #2858: URL: https://github.com/apache/apisix/pull/2858 ### What this PR does / why we need it: See #2857. ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ]

[GitHub] [apisix] jenskeiner closed pull request #2858: 2857 authz keycloak should run in access phase

jenskeiner closed pull request #2858: URL: https://github.com/apache/apisix/pull/2858 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [apisix] jenskeiner commented on pull request #2858: 2857 authz keycloak should run in access phase

jenskeiner commented on pull request #2858: URL: https://github.com/apache/apisix/pull/2858#issuecomment-734242789 Closing and reopening after fixing commit messages. This is an automated message from the Apache Git Service.

[GitHub] [apisix] jenskeiner opened a new pull request #2859: fix: authz keycloak should run in access phase

jenskeiner opened a new pull request #2859: URL: https://github.com/apache/apisix/pull/2859 ### What this PR does / why we need it: See #2857. ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ]

[GitHub] [apisix] membphis commented on pull request #2859: fix: authz keycloak should run in access phase

membphis commented on pull request #2859: URL: https://github.com/apache/apisix/pull/2859#issuecomment-734249801 Authentication type plug-ins should run in the rewrite phase This is an automated message from the Apache Git Se

[GitHub] [apisix] jenskeiner commented on pull request #2859: fix: authz keycloak should run in access phase

jenskeiner commented on pull request #2859: URL: https://github.com/apache/apisix/pull/2859#issuecomment-734261094 > Authentication type plug-ins should run in the rewrite phase How do you suggest this get's fixed then when `openid-connect` and other authentication plugins currently

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #880: test: add consumer with incorrect input ( E2E )

idbeta commented on a change in pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#discussion_r530985601 ## File path: api/test/e2e/consumer_test.go ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #880: test: add consumer with incorrect input ( E2E )

idbeta commented on a change in pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#discussion_r530985601 ## File path: api/test/e2e/consumer_test.go ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[GitHub] [apisix-dashboard] tokers commented on a change in pull request #868: fix: delete POST method in /apisix/admin/consumer

tokers commented on a change in pull request #868: URL: https://github.com/apache/apisix-dashboard/pull/868#discussion_r530990653 ## File path: api/internal/handler/consumer/consumer.go ## @@ -97,35 +95,13 @@ func (h *Handler) List(c droplet.Context) (interface{}, error) {

[GitHub] [apisix-dashboard] gxthrj commented on a change in pull request #882: test: add e2e test cases for route with limit plugin

gxthrj commented on a change in pull request #882: URL: https://github.com/apache/apisix-dashboard/pull/882#discussion_r531009865 ## File path: api/test/e2e/route_with_limit_plugin_test.go ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [apisix-dashboard] nic-chen closed issue #862: bug: 2.1 version create route with jwt-auth will display an error

nic-chen closed issue #862: URL: https://github.com/apache/apisix-dashboard/issues/862 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] nic-chen commented on issue #862: bug: 2.1 version create route with jwt-auth will display an error

nic-chen commented on issue #862: URL: https://github.com/apache/apisix-dashboard/issues/862#issuecomment-734283277 fixed by json schema updated. and here is a test case for it: https://github.com/apache/apisix-dashboard/blob/master/api/test/e2e/route_with_auth_plugin_test.go#L38

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #880: test: add consumer with incorrect input ( E2E )

codecov-io edited a comment on pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#issuecomment-734167166 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/880?src=pr&el=h1) Report > Merging [#880](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #880: test: add consumer with incorrect input ( E2E )

codecov-io edited a comment on pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#issuecomment-734167166 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/880?src=pr&el=h1) Report > Merging [#880](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] gxthrj opened a new pull request #883: chore: Show the correct lines of code in manager logger

gxthrj opened a new pull request #883: URL: https://github.com/apache/apisix-dashboard/pull/883 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance -

[GitHub] [apisix-dashboard] codecov-io commented on pull request #882: test: add e2e test cases for route with limit plugin

codecov-io commented on pull request #882: URL: https://github.com/apache/apisix-dashboard/pull/882#issuecomment-734285692 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/882?src=pr&el=h1) Report > Merging [#882](https://codecov.io/gh/apache/apisix-dashboard/pull/882?src

[GitHub] [apisix-dashboard] codecov-io commented on pull request #883: chore: Show the correct lines of code in manager logger

codecov-io commented on pull request #883: URL: https://github.com/apache/apisix-dashboard/pull/883#issuecomment-734287032 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/883?src=pr&el=h1) Report > Merging [#883](https://codecov.io/gh/apache/apisix-dashboard/pull/883?src

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #882: test: add e2e test cases for route with limit plugin

nic-chen commented on a change in pull request #882: URL: https://github.com/apache/apisix-dashboard/pull/882#discussion_r531019065 ## File path: api/test/e2e/route_with_limit_plugin_test.go ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [apisix] membphis commented on pull request #2859: fix: authz keycloak should run in access phase

membphis commented on pull request #2859: URL: https://github.com/apache/apisix/pull/2859#issuecomment-734311999 reply you later need more time to read your issue and pr first This is an automated message from the Apac

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #874: test: add E2E testcase about add route with invalid request body

membphis commented on a change in pull request #874: URL: https://github.com/apache/apisix-dashboard/pull/874#discussion_r531049077 ## File path: api/test/e2e/route_remote_addr_test.go ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #880: test: add consumer with incorrect input ( E2E )

codecov-io edited a comment on pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#issuecomment-734167166 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/880?src=pr&el=h1) Report > Merging [#880](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] membphis commented on pull request #883: chore: Show the correct lines of code in manager logger

membphis commented on pull request #883: URL: https://github.com/apache/apisix-dashboard/pull/883#issuecomment-734319471 @nic-chen @ShiningRush please take a look at this PR This is an automated message from the Apache Git Se

[GitHub] [apisix-dashboard] membphis merged pull request #882: test: add e2e test cases for route with limit plugin

membphis merged pull request #882: URL: https://github.com/apache/apisix-dashboard/pull/882 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[apisix-dashboard] branch master updated: test: add e2e test cases for route with limit plugin (#882)

This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 0a826e6 test: add e2e test cases fo

[GitHub] [apisix-dashboard] idbeta opened a new pull request #884: test: add route with vaild remote_address (E2E)

idbeta opened a new pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [x] E2E test

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r53106 ## File path: doc/upstream-status-5xx.md ## @@ -0,0 +1,151 @@ + + +[Chinese](zh-cn/upstream-status-5xx.md) + +## `5xx` response status code + +Similar

[GitHub] [apisix-dashboard] membphis commented on pull request #874: test: add E2E testcase about add route with invalid request body

membphis commented on pull request #874: URL: https://github.com/apache/apisix-dashboard/pull/874#issuecomment-73408 @moonming take a look when you have time This is an automated message from the Apache Git Service. To re

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #884: test: add route with vaild remote_address (E2E)

membphis commented on a change in pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r531071867 ## File path: api/test/e2e/route_with_vaild_remote_addr.go ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [apisix] membphis commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

membphis commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r531076377 ## File path: doc/debugging.md ## @@ -0,0 +1,151 @@ + + +[Chinese](zh-cn/debugging.md) Review comment: add a reference to `doc/README.md`

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #885: test: add e2e test cases for route with other plugin

nic-chen opened a new pull request #885: URL: https://github.com/apache/apisix-dashboard/pull/885 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [x] E2E test

[GitHub] [apisix-dashboard] nic-chen commented on pull request #883: chore: Show the correct lines of code in manager logger

nic-chen commented on pull request #883: URL: https://github.com/apache/apisix-dashboard/pull/883#issuecomment-734338541 I think we should add a cli test case for it to make sure the change works fine. This is an automated m

[GitHub] [apisix-dashboard] codecov-io commented on pull request #884: test: add route with vaild remote_address (E2E)

codecov-io commented on pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#issuecomment-734338511 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/884?src=pr&el=h1) Report > Merging [#884](https://codecov.io/gh/apache/apisix-dashboard/pull/884?src

[GitHub] [apisix-dashboard] codecov-io commented on pull request #885: test: add e2e test cases for route with other plugin

codecov-io commented on pull request #885: URL: https://github.com/apache/apisix-dashboard/pull/885#issuecomment-734339774 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/885?src=pr&el=h1) Report > Merging [#885](https://codecov.io/gh/apache/apisix-dashboard/pull/885?src

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #885: test: add e2e test cases for route with other plugin

membphis commented on a change in pull request #885: URL: https://github.com/apache/apisix-dashboard/pull/885#discussion_r531077878 ## File path: api/test/e2e/route_with_other_plugin_test.go ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #884: test: add route with vaild remote_address (E2E)

membphis commented on a change in pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r531083023 ## File path: api/test/e2e/route_with_vaild_remote_addr.go ## @@ -24,7 +24,7 @@ import ( func TestRoute_with_vaild_remote_addr(t *testing.T) {

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #884: test: add route with vaild remote_address (E2E)

membphis commented on a change in pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r531083296 ## File path: api/test/e2e/route_with_vaild_remote_addr.go ## @@ -24,7 +24,7 @@ import ( func TestRoute_with_vaild_remote_addr(t *testing.T) {

[GitHub] [apisix] starsz commented on issue #2855: request help: adminapi supports yaml as the configuration center

starsz commented on issue #2855: URL: https://github.com/apache/apisix/issues/2855#issuecomment-734350777 Hi, @backnero. I think your request help like get a YAML file content through adminapi? If this, I think you can write a plugin to support.

[GitHub] [apisix] starsz edited a comment on issue #2855: request help: adminapi supports yaml as the configuration center

starsz edited a comment on issue #2855: URL: https://github.com/apache/apisix/issues/2855#issuecomment-734350777 Hi, @backnero. I think your request help like get a YAML file content through adminapi? If this, I think you can write a plugin to support. Besides, if you want to obta

[GitHub] [apisix-dashboard] nic-chen commented on pull request #874: test: add E2E testcase about add route with invalid request body

nic-chen commented on pull request #874: URL: https://github.com/apache/apisix-dashboard/pull/874#issuecomment-734357333 need test cases for correct remote addr This is an automated message from the Apache Git Service. To res

[GitHub] [apisix-dashboard] nic-chen commented on pull request #874: test: add E2E testcase about add route with invalid request body

nic-chen commented on pull request #874: URL: https://github.com/apache/apisix-dashboard/pull/874#issuecomment-734358219 the PR title should have a better one. This is an automated message from the Apache Git Service. To resp

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r531099546 ## File path: doc/debugging.md ## @@ -0,0 +1,151 @@ + + +[Chinese](zh-cn/debugging.md) Review comment: added. -

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #885: test: add e2e test cases for route with other plugin

nic-chen commented on a change in pull request #885: URL: https://github.com/apache/apisix-dashboard/pull/885#discussion_r531102061 ## File path: api/test/e2e/route_with_other_plugin_test.go ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [apisix-dashboard] nic-chen opened a new issue #886: test: need cross-testing between `manager api` and `admin api`

nic-chen opened a new issue #886: URL: https://github.com/apache/apisix-dashboard/issues/886 need cross-testing between `manager api` and `admin api`, to make sure they works well between each other. This is an automated m

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #868: WIP: fix: delete POST method in /apisix/admin/consumer

starsz commented on a change in pull request #868: URL: https://github.com/apache/apisix-dashboard/pull/868#discussion_r531108884 ## File path: api/internal/handler/consumer/consumer.go ## @@ -97,35 +95,13 @@ func (h *Handler) List(c droplet.Context) (interface{}, error) {

[GitHub] [apisix-dashboard] nic-chen opened a new issue #887: test: need e2e test to ensure JSONSchema default value works fine

nic-chen opened a new issue #887: URL: https://github.com/apache/apisix-dashboard/issues/887 depends on: https://github.com/apache/apisix/issues/2834 Once this issue is done, we need to add e2e tests to ensure that no default value added in the manager api also works fine --

[GitHub] [apisix] Firstsawyou opened a new issue #2860: chore(kafka-logger): remove semicolon ";" and add blank line

Firstsawyou opened a new issue #2860: URL: https://github.com/apache/apisix/issues/2860 ### Issue description 1.Delete the semicolon after this line of code: [https://github.com/apache/apisix/blob/master/apisix/plugins/kafka-logger.lua#L26](https://github.com/apache/apisix/blob/ma

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #868: WIP: fix: delete POST method in /apisix/admin/consumer

starsz commented on a change in pull request #868: URL: https://github.com/apache/apisix-dashboard/pull/868#discussion_r531114297 ## File path: api/test/e2e/base.go ## @@ -32,6 +33,11 @@ import ( var token string +var MExpect *httpexpect.Expect Review comment: Dele

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #884: WIP: add route with valid remote_address (E2E)

codecov-io edited a comment on pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#issuecomment-734338511 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/884?src=pr&el=h1) Report > Merging [#884](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #874: test: add E2E testcase about add route with invalid request body

codecov-io edited a comment on pull request #874: URL: https://github.com/apache/apisix-dashboard/pull/874#issuecomment-733660890 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/874?src=pr&el=h1) Report > Merging [#874](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] idbeta commented on pull request #874: test: add E2E testcase about add route with invalid request body

idbeta commented on pull request #874: URL: https://github.com/apache/apisix-dashboard/pull/874#issuecomment-734383470 > need test cases for correct remote addr yes, you can check this PR https://github.com/apache/apisix-dashboard/pull/884 --

[GitHub] [apisix-dashboard] idbeta opened a new pull request #888: WIP: add route with invalid uri or uris

idbeta opened a new pull request #888: URL: https://github.com/apache/apisix-dashboard/pull/888 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] E2E test - [ ] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix] Firstsawyou opened a new issue #2861: doc(kafka-logger): optimize the description of the attribute

Firstsawyou opened a new issue #2861: URL: https://github.com/apache/apisix/issues/2861 ### Issue description In the kafka-logger plugin documentation, the description information of the `batch_max_size` and `include_req_body` attributes is not clear, and `include_req_body` lacks de

[GitHub] [apisix] jenskeiner closed issue #2764: bug: OIDC plugin may not be setting request headers correctly.

jenskeiner closed issue #2764: URL: https://github.com/apache/apisix/issues/2764 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] jenskeiner commented on issue #2764: bug: OIDC plugin may not be setting request headers correctly.

jenskeiner commented on issue #2764: URL: https://github.com/apache/apisix/issues/2764#issuecomment-734480738 I'll close this one as I've since confirmed that the headers are actually set correctly. I'll probably open a few more tickets and PRs to address other issues in the area.

[GitHub] [apisix-dashboard] gxthrj commented on a change in pull request #885: test: add e2e test cases for route with other plugin

gxthrj commented on a change in pull request #885: URL: https://github.com/apache/apisix-dashboard/pull/885#discussion_r531250503 ## File path: api/test/e2e/route_with_plugin_proxy_rewrite_test.go ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [apisix-dashboard] membphis commented on issue #886: test: need cross-testing between `manager api` and `admin api`

membphis commented on issue #886: URL: https://github.com/apache/apisix-dashboard/issues/886#issuecomment-734513369 how to resolve this issue? @nic-chen do you have any idea? This is an automated message from the Apache Git

[GitHub] [apisix] membphis commented on pull request #2856: fix: validate plugin configuration in the DP

membphis commented on pull request #2856: URL: https://github.com/apache/apisix/pull/2856#issuecomment-734514790 @spacewander you can continue this issue This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #884: test: add route with valid remote_address (E2E)

membphis commented on a change in pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r531261286 ## File path: api/test/e2e/route_with_valid_remote_addr_test.go ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [apisix-dashboard] membphis commented on pull request #874: test: add E2E testcase about add route with invalid request body

membphis commented on pull request #874: URL: https://github.com/apache/apisix-dashboard/pull/874#issuecomment-734516024 > the PR title should have a better one. agree, why do you submit two PRs about `route + remote_addr`? ---

[GitHub] [apisix-dashboard] gxthrj commented on pull request #883: chore: Show the correct lines of code in manager logger

gxthrj commented on pull request #883: URL: https://github.com/apache/apisix-dashboard/pull/883#issuecomment-734517102 ok, try to add some logger test . This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #884: test: add route with valid remote_address (E2E)

membphis commented on a change in pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r531261060 ## File path: api/test/e2e/route_with_valid_remote_addr_test.go ## @@ -44,14 +44,14 @@ func TestRoute_with_valid_remote_addr(t *testing.T) {

[GitHub] [apisix] membphis commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

membphis commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r531262634 ## File path: apisix/init.lua ## @@ -629,6 +630,24 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header) +

[GitHub] [apisix] membphis commented on issue #2861: doc(kafka-logger): optimize the description of the attribute

membphis commented on issue #2861: URL: https://github.com/apache/apisix/issues/2861#issuecomment-734517859 welcome PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [apisix] membphis commented on issue #2860: chore(kafka-logger): remove semicolon ";" and add blank line

membphis commented on issue #2860: URL: https://github.com/apache/apisix/issues/2860#issuecomment-734517958 welcome PR ^_^ This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] HelloBug0 commented on issue #2843: doc: wrong link

HelloBug0 commented on issue #2843: URL: https://github.com/apache/apisix/issues/2843#issuecomment-734518837 I see. 👍 👍 👍 This is an automated message from the Apache Git Service. To respond to the message, please log on to

  1   2   >