[GitHub] [apisix] Firstsawyou removed a comment on issue #2827: request help: fault-injection abort.body Using variables

2020-11-30 Thread GitBox
Firstsawyou removed a comment on issue #2827: URL: https://github.com/apache/apisix/issues/2827#issuecomment-733469225 This is a related issue: [https://github.com/apache/apisix/issues/2511 ](https://github.com/apache/apisix/issues/2511), I think supporting variables are very useful.

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #906: test: add e2e test cases for route with plugin cors

2020-11-30 Thread GitBox
nic-chen commented on a change in pull request #906: URL: https://github.com/apache/apisix-dashboard/pull/906#discussion_r533133619 ## File path: api/test/e2e/route_with_plugin_cors_test.go ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [apisix] spacewander closed issue #2909: request help: balancer阶段的插件在什么时候执行

2020-11-30 Thread GitBox
spacewander closed issue #2909: URL: https://github.com/apache/apisix/issues/2909 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander commented on issue #2909: request help: balancer阶段的插件在什么时候执行

2020-11-30 Thread GitBox
spacewander commented on issue #2909: URL: https://github.com/apache/apisix/issues/2909#issuecomment-736289145 Balancer phase is not supported yet. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] membphis opened a new issue #935: feat: allow consumer bind with two more auth plugins

2020-11-30 Thread GitBox
membphis opened a new issue #935: URL: https://github.com/apache/apisix-dashboard/issues/935 # Feature request the related issue of APISIX: https://github.com/apache/apisix/issues/2850#issuecomment-733655243 both Manager-API and Dashboard need to update.

[apisix] branch master updated: fix: reject "" for route's remote_addrs (#2907)

2020-11-30 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new ddfeb5d fix: reject "" for route's

[GitHub] [apisix] spacewander merged pull request #2907: fix: reject "" for route's remote_addrs

2020-11-30 Thread GitBox
spacewander merged pull request #2907: URL: https://github.com/apache/apisix/pull/2907 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: feat: allow create consumers with multiple auth plugins (#2898)

2020-11-30 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new a63b6b8 feat: allow create consumers with

[GitHub] [apisix] membphis merged pull request #2898: feat: allow create consumers with multiple auth plugins

2020-11-30 Thread GitBox
membphis merged pull request #2898: URL: https://github.com/apache/apisix/pull/2898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis closed issue #2850: bug: manager-api should not allow create consumers with two more auth plugin

2020-11-30 Thread GitBox
membphis closed issue #2850: URL: https://github.com/apache/apisix/issues/2850 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-dashboard] membphis commented on pull request #934: fix: upstream node can't display when the node's weight is set to 0

2020-11-30 Thread GitBox
membphis commented on pull request #934: URL: https://github.com/apache/apisix-dashboard/pull/934#issuecomment-736285712 @ShiningRush @gxthrj @liuxiran do you have time to look at this PR? This is an automated message from

[GitHub] [apisix] spacewander commented on issue #2899: bug: Etcd jwt refresh error can cause gateway cluster crash.

2020-11-30 Thread GitBox
spacewander commented on issue #2899: URL: https://github.com/apache/apisix/issues/2899#issuecomment-736283075 @gy09535 How many workers per APISIX instance? This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

2020-11-30 Thread GitBox
juzhiyuan commented on a change in pull request #929: URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533124140 ## File path: docs/deploy-with-docker.md ## @@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag . # For users in mainland China, the

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #859: feat: add a unit test for consumer and remove implicit init

2020-11-30 Thread GitBox
juzhiyuan commented on a change in pull request #859: URL: https://github.com/apache/apisix-dashboard/pull/859#discussion_r533123881 ## File path: api/internal/handler/consumer/consumer_test.go ## @@ -399,220 +395,4 @@ func TestHandler_BatchDelete(t *testing.T) {

[GitHub] [apisix] comedown opened a new issue #2909: request help: balancer阶段的插件在什么时候执行

2020-11-30 Thread GitBox
comedown opened a new issue #2909: URL: https://github.com/apache/apisix/issues/2909 ### Issue description 我在example-plugin下面加了balancer方法,但是没有执行 function _M.balancer(conf, ctx) core.log.info("plugin balancer phase, conf: ", core.json.encode(conf)) core.log.info("

[GitHub] [apisix-dashboard] membphis closed issue #901: the manger API should not listen 8080, which is the port of data plane

2020-11-30 Thread GitBox
membphis closed issue #901: URL: https://github.com/apache/apisix-dashboard/issues/901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] membphis merged pull request #931: chore: change the default port of manager api from 8080 to 9000

2020-11-30 Thread GitBox
membphis merged pull request #931: URL: https://github.com/apache/apisix-dashboard/pull/931 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-dashboard] branch master updated (68bdd1d -> f464bbd)

2020-11-30 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 68bdd1d test: add route with invalid remote_addr (E2E) (#874) add f464bbd chore: change the

[GitHub] [apisix-dashboard] ShiningRush commented on pull request #859: feat: add a unit test for consumer and remove implicit init

2020-11-30 Thread GitBox
ShiningRush commented on pull request #859: URL: https://github.com/apache/apisix-dashboard/pull/859#issuecomment-736276356 Our backend e2e test is not stable. : ( This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] moonming commented on issue #825: [Proposal]: Import & Export route from OpenAPI Specification3.0

2020-11-30 Thread GitBox
moonming commented on issue #825: URL: https://github.com/apache/apisix-dashboard/issues/825#issuecomment-736275892 got it. So I think the first plan is good for me. This is an automated message from the Apache Git Service.

[apisix-dashboard] branch master updated (18744a5 -> 68bdd1d)

2020-11-30 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 18744a5 test: add route with priority (E2E) (#893) add 68bdd1d test: add route with invalid

[GitHub] [apisix-dashboard] membphis closed issue #631: add e2e test for config route with remote_addr or remote_addrs

2020-11-30 Thread GitBox
membphis closed issue #631: URL: https://github.com/apache/apisix-dashboard/issues/631 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] membphis merged pull request #874: test: add route with invalid remote_addr (E2E)

2020-11-30 Thread GitBox
membphis merged pull request #874: URL: https://github.com/apache/apisix-dashboard/pull/874 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] liuxiran commented on issue #825: [Proposal]: Import & Export route from OpenAPI Specification3.0

2020-11-30 Thread GitBox
liuxiran commented on issue #825: URL: https://github.com/apache/apisix-dashboard/issues/825#issuecomment-736274949 > how can the user export it if using the second plan? with the second plan, user can only export part of the route info which supported by OAS3.0

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #927: test: config route with management fileds (E2E)

2020-11-30 Thread GitBox
idbeta commented on a change in pull request #927: URL: https://github.com/apache/apisix-dashboard/pull/927#discussion_r533117669 ## File path: api/test/e2e/route_with_management fileds_test.go ## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [apisix-dashboard] membphis commented on pull request #929: CD: auto deploy codes on the master branch to the online demo

2020-11-30 Thread GitBox
membphis commented on pull request #929: URL: https://github.com/apache/apisix-dashboard/pull/929#issuecomment-736274331 @nic-chen CI failed, please take a look This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

2020-11-30 Thread GitBox
membphis commented on a change in pull request #929: URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533117485 ## File path: docs/deploy-with-docker.md ## @@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag . # For users in mainland China, the

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #934: fix: upstream node can't display when the node's weight is set to 0

2020-11-30 Thread GitBox
nic-chen opened a new pull request #934: URL: https://github.com/apache/apisix-dashboard/pull/934 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix-dashboard] ShiningRush edited a comment on pull request #859: feat: add a unit test for consumer and remove implicit init

2020-11-30 Thread GitBox
ShiningRush edited a comment on pull request #859: URL: https://github.com/apache/apisix-dashboard/pull/859#issuecomment-736269188 Already completed consumer handler unit test and refactor some codes, and remove old integration test case, we don't need it anymore. @nic-chen @membphis

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #927: test: config route with management fileds (E2E)

2020-11-30 Thread GitBox
membphis commented on a change in pull request #927: URL: https://github.com/apache/apisix-dashboard/pull/927#discussion_r533116951 ## File path: api/test/e2e/route_with_management fileds_test.go ## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #927: test: config route with management fileds (E2E)

2020-11-30 Thread GitBox
idbeta commented on a change in pull request #927: URL: https://github.com/apache/apisix-dashboard/pull/927#discussion_r533116811 ## File path: api/test/e2e/route_with_management fileds_test.go ## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [apisix-dashboard] membphis commented on issue #933: feat: not allowed to specify `create_time` and `update_time` when create/edit route, service, upstream and consumer

2020-11-30 Thread GitBox
membphis commented on issue #933: URL: https://github.com/apache/apisix-dashboard/issues/933#issuecomment-736273280 The values of `create_time` and `update_time` are maintained by the manager-api itself. This is an

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #927: test: config route with management fileds (E2E)

2020-11-30 Thread GitBox
idbeta commented on a change in pull request #927: URL: https://github.com/apache/apisix-dashboard/pull/927#discussion_r533033361 ## File path: api/test/e2e/route_with_management fileds_test.go ## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [apisix-dashboard] membphis opened a new issue #933: feat: not allowed to specify `create_time` and `update_time` when create/edit route, service, upstream and consumer

2020-11-30 Thread GitBox
membphis opened a new issue #933: URL: https://github.com/apache/apisix-dashboard/issues/933 ```go { caseDesc: "update the route (r1)", Object: ManagerApiExpect(t), Path: "/apisix/admin/routes/r1", Method: http.MethodPut,

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #932: test: e2e test cHash upstream with key (query_string, arg_xxx)

2020-11-30 Thread GitBox
codecov-io edited a comment on pull request #932: URL: https://github.com/apache/apisix-dashboard/pull/932#issuecomment-736241646 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/932?src=pr=h1) Report > Merging

[GitHub] [apisix-docker] hyt05 commented on issue #90: How to connect etcd cluster with tls

2020-11-30 Thread GitBox
hyt05 commented on issue #90: URL: https://github.com/apache/apisix-docker/issues/90#issuecomment-736271377 @gxthrj In fact, I didn't use docker- compose.yml Etcd in, I just use the example docker- compose.yml To start apifix, the etcd connection address used in my configuration file is

[GitHub] [apisix-dashboard] moonming commented on issue #825: [Proposal]: Import & Export route from OpenAPI Specification3.0

2020-11-30 Thread GitBox
moonming commented on issue #825: URL: https://github.com/apache/apisix-dashboard/issues/825#issuecomment-736271095 > For the upstream info or service info which are not supported by OAS3.0, there are two feasible options of implementation scenarios: > > * Expand OAS3.0,

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #859: feat: add a unit test for consumer and remove implicit init

2020-11-30 Thread GitBox
juzhiyuan commented on a change in pull request #859: URL: https://github.com/apache/apisix-dashboard/pull/859#discussion_r533114213 ## File path: api/internal/handler/consumer/consumer_test.go ## @@ -248,16 +568,16 @@ func TestConsumer(t *testing.T) { //create

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #927: test: config route with management fileds (E2E)

2020-11-30 Thread GitBox
membphis commented on a change in pull request #927: URL: https://github.com/apache/apisix-dashboard/pull/927#discussion_r533114051 ## File path: api/test/e2e/route_with_management fileds_test.go ## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix] spacewander commented on a change in pull request #2884: feat: server info

2020-11-30 Thread GitBox
spacewander commented on a change in pull request #2884: URL: https://github.com/apache/apisix/pull/2884#discussion_r533113906 ## File path: apisix/admin/init.lua ## @@ -316,6 +330,11 @@ local uri_route = { methods = {"PUT"}, handler = post_reload_plugins,

[GitHub] [apisix-dashboard] ShiningRush edited a comment on pull request #859: feat: add a unit test for consumer and remove implicit init

2020-11-30 Thread GitBox
ShiningRush edited a comment on pull request #859: URL: https://github.com/apache/apisix-dashboard/pull/859#issuecomment-736269188 Already completed consumer handler unit test and refactor some codes. @nic-chen @membphis

[GitHub] [apisix-dashboard] ShiningRush edited a comment on pull request #859: feat: add a unit test for consumer and remove implicit init

2020-11-30 Thread GitBox
ShiningRush edited a comment on pull request #859: URL: https://github.com/apache/apisix-dashboard/pull/859#issuecomment-736269188 Complete consumer handler unit test and refactor some codes. @nic-chen @membphis This is

[GitHub] [apisix-dashboard] ShiningRush edited a comment on pull request #859: feat: add a unit test for consumer and remove implicit init

2020-11-30 Thread GitBox
ShiningRush edited a comment on pull request #859: URL: https://github.com/apache/apisix-dashboard/pull/859#issuecomment-736269188 Compete consumer handler unit test and refactor some codes. @nic-chen @membphis This is

[GitHub] [apisix] juzhiyuan commented on a change in pull request #2884: feat: server info

2020-11-30 Thread GitBox
juzhiyuan commented on a change in pull request #2884: URL: https://github.com/apache/apisix/pull/2884#discussion_r533113410 ## File path: doc/plugins/server-info.md ## @@ -48,4 +85,20 @@ The meaning of each item in server information is following: | version | string | APISIX

[GitHub] [apisix-dashboard] ShiningRush commented on pull request #859: feat: add a unit test for consumer and remove implicit init

2020-11-30 Thread GitBox
ShiningRush commented on pull request #859: URL: https://github.com/apache/apisix-dashboard/pull/859#issuecomment-736269188 Compete consumer handler unit test and refactor some codes. This is an automated message from the

[GitHub] [apisix-website] juzhiyuan opened a new pull request #99: feat: update download page

2020-11-30 Thread GitBox
juzhiyuan opened a new pull request #99: URL: https://github.com/apache/apisix-website/pull/99 resolve #98 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[apisix-website] branch juzhiyuan-patch-2 created (now 2b5a2c2)

2020-11-30 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-2 in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at 2b5a2c2 feat: update download page This branch includes the following new commits: new

[apisix-website] 01/01: feat: update download page

2020-11-30 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch juzhiyuan-patch-2 in repository https://gitbox.apache.org/repos/asf/apisix-website.git commit 2b5a2c2573142c4a620d3c85b27ff224cd5a873d Author: 琚致远 AuthorDate: Tue Dec 1 15:04:18 2020 +0800

[GitHub] [apisix] spacewander commented on a change in pull request #2884: feat: server info

2020-11-30 Thread GitBox
spacewander commented on a change in pull request #2884: URL: https://github.com/apache/apisix/pull/2884#discussion_r533111811 ## File path: apisix/server_info.lua ## @@ -0,0 +1,168 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix-website] juzhiyuan commented on issue #98: add apisix 2.1 release in download page

2020-11-30 Thread GitBox
juzhiyuan commented on issue #98: URL: https://github.com/apache/apisix-website/issues/98#issuecomment-736267347 Kindly modify this file directly. https://github.com/apache/apisix-website/blob/master/docs/download.md

[GitHub] [apisix] moonming merged pull request #2904: fix: Openid connect plugin should run in rewrite phase.

2020-11-30 Thread GitBox
moonming merged pull request #2904: URL: https://github.com/apache/apisix/pull/2904 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: Change phase from access to rewrite. (#2904)

2020-11-30 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 1526ea5 Change phase from access to rewrite.

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #927: test: config route with management fileds (E2E)

2020-11-30 Thread GitBox
membphis commented on a change in pull request #927: URL: https://github.com/apache/apisix-dashboard/pull/927#discussion_r533109962 ## File path: api/test/e2e/route_with_management fileds_test.go ## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #859: feat: add a unit test for consumer and remove implicit init

2020-11-30 Thread GitBox
codecov-io edited a comment on pull request #859: URL: https://github.com/apache/apisix-dashboard/pull/859#issuecomment-732124292 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/859?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] liuxiran commented on issue #825: [Proposal]: Import & Export route from OpenAPI Specification3.0

2020-11-30 Thread GitBox
liuxiran commented on issue #825: URL: https://github.com/apache/apisix-dashboard/issues/825#issuecomment-736264421 For the upstream info or service info which are not supported by OAS3.0, there are two feasible options of implementation scenarios: - Expand OAS3.0, increase

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #880: test: add consumer with incorrect input ( E2E )

2020-11-30 Thread GitBox
membphis commented on a change in pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#discussion_r533108794 ## File path: api/test/e2e/consumer_test.go ## @@ -131,3 +136,219 @@ func TestConsumer_with_key_auth(t *testing.T) {

[GitHub] [apisix] tokers commented on a change in pull request #2884: feat: server info

2020-11-30 Thread GitBox
tokers commented on a change in pull request #2884: URL: https://github.com/apache/apisix/pull/2884#discussion_r533108660 ## File path: apisix/server_info.lua ## @@ -0,0 +1,168 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] tokers commented on a change in pull request #2884: feat: server info

2020-11-30 Thread GitBox
tokers commented on a change in pull request #2884: URL: https://github.com/apache/apisix/pull/2884#discussion_r533107665 ## File path: apisix/admin/init.lua ## @@ -316,6 +330,11 @@ local uri_route = { methods = {"PUT"}, handler = post_reload_plugins, },

[GitHub] [apisix] tokers commented on a change in pull request #2884: feat: server info

2020-11-30 Thread GitBox
tokers commented on a change in pull request #2884: URL: https://github.com/apache/apisix/pull/2884#discussion_r533106738 ## File path: apisix/server_info.lua ## @@ -0,0 +1,168 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix-docker] membphis commented on pull request #91: feat: modify docs for Apache APISIX 2.1

2020-11-30 Thread GitBox
membphis commented on pull request #91: URL: https://github.com/apache/apisix-docker/pull/91#issuecomment-736259421 @gxthrj Is this PR related to any issue? Please confirm This is an automated message from the Apache Git

[GitHub] [apisix-docker] membphis commented on a change in pull request #91: feat: modify docs for Apache APISIX 2.1

2020-11-30 Thread GitBox
membphis commented on a change in pull request #91: URL: https://github.com/apache/apisix-docker/pull/91#discussion_r533104736 ## File path: example/apisix_conf/config.yaml ## @@ -1,137 +1,22 @@ apisix: Review comment: I do not find any related issue, so I created

[GitHub] [apisix-docker] membphis opened a new issue #92: chore: add ASF header

2020-11-30 Thread GitBox
membphis opened a new issue #92: URL: https://github.com/apache/apisix-docker/issues/92 original comment: https://github.com/apache/apisix-docker/pull/91/files/e69b0059f04bf4cb8ec76873a85a550fe0311a91..87213a8eaf49cedd44aff21241f5a66692599755#r533091870

[GitHub] [apisix] membphis commented on a change in pull request #2884: feat: server info

2020-11-30 Thread GitBox
membphis commented on a change in pull request #2884: URL: https://github.com/apache/apisix/pull/2884#discussion_r533103834 ## File path: apisix/admin/init.lua ## @@ -29,6 +30,7 @@ local reload_event = "/apisix/admin/plugins/reload" local ipairs = ipairs local error = error

[GitHub] [apisix] membphis commented on a change in pull request #2884: feat: server info

2020-11-30 Thread GitBox
membphis commented on a change in pull request #2884: URL: https://github.com/apache/apisix/pull/2884#discussion_r533103648 ## File path: apisix/admin/init.lua ## @@ -18,6 +18,7 @@ local require = require local core = require("apisix.core") local route =

[GitHub] [apisix] membphis commented on a change in pull request #2884: feat: server info

2020-11-30 Thread GitBox
membphis commented on a change in pull request #2884: URL: https://github.com/apache/apisix/pull/2884#discussion_r533100323 ## File path: doc/zh-cn/plugins/server-info.md ## @@ -0,0 +1,104 @@ + + +- [English](../../plugins/server-info.md) + +# Summary + +- [**插件简介**](#插件简介) +-

[GitHub] [apisix-docker] gxthrj commented on a change in pull request #91: feat: modify docs for Apache APISIX 2.1

2020-11-30 Thread GitBox
gxthrj commented on a change in pull request #91: URL: https://github.com/apache/apisix-docker/pull/91#discussion_r533101239 ## File path: example/apisix_conf/config.yaml ## @@ -1,137 +1,22 @@ apisix: Review comment: We can fix this in new PR, so many files do miss

[GitHub] [apisix-docker] gxthrj commented on a change in pull request #91: feat: modify docs for Apache APISIX 2.1

2020-11-30 Thread GitBox
gxthrj commented on a change in pull request #91: URL: https://github.com/apache/apisix-docker/pull/91#discussion_r533100999 ## File path: example/apisix_conf/config.yaml ## @@ -1,137 +1,22 @@ apisix: node_listen: 9080 # APISIX listening port -

[GitHub] [apisix-docker] gxthrj commented on a change in pull request #91: feat: modify docs for Apache APISIX 2.1

2020-11-30 Thread GitBox
gxthrj commented on a change in pull request #91: URL: https://github.com/apache/apisix-docker/pull/91#discussion_r533100951 ## File path: example/apisix_conf/config.yaml ## @@ -1,137 +1,22 @@ apisix: node_listen: 9080 # APISIX listening port -

[GitHub] [apisix-docker] tokers commented on issue #90: How to connect etcd cluster with tls

2020-11-30 Thread GitBox
tokers commented on issue #90: URL: https://github.com/apache/apisix-docker/issues/90#issuecomment-736253916 > This is a bug, we don't respect the scheme when calling `bin/apisix init_etcd`. Sorry, i misunderstood this issue, just ignore it.

[GitHub] [apisix] wfgydbu commented on issue #2906: [DISCUSS]: is it reasonable to support "upstream group"?

2020-11-30 Thread GitBox
wfgydbu commented on issue #2906: URL: https://github.com/apache/apisix/issues/2906#issuecomment-736252910 @tokers Thansk for your reply. The first problem is a bad example here, I will remove it when I send the email. And Yes, it is essentially a load balancing algorithm, except

[GitHub] [apisix-docker] hyt05 commented on issue #90: How to connect etcd cluster with tls

2020-11-30 Thread GitBox
hyt05 commented on issue #90: URL: https://github.com/apache/apisix-docker/issues/90#issuecomment-736252460 @tokers Do you have a good solution This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-docker] gxthrj commented on issue #90: How to connect etcd cluster with tls

2020-11-30 Thread GitBox
gxthrj commented on issue #90: URL: https://github.com/apache/apisix-docker/issues/90#issuecomment-736252433 @hyt05 I have two questions: 1. https://github.com/apache/apisix-docker/tree/master/example use docker-compose with network as below, make sure the `etcd` address can be

[GitHub] [apisix-dashboard] membphis commented on pull request #931: chore: change the default port of manager api from 8080 to 9000

2020-11-30 Thread GitBox
membphis commented on pull request #931: URL: https://github.com/apache/apisix-dashboard/pull/931#issuecomment-736251077 we can update the architecture diagram to help users understand these ports. do this later in a new PR.

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #929: CD: auto deploy codes on the master branch to the online demo

2020-11-30 Thread GitBox
codecov-io edited a comment on pull request #929: URL: https://github.com/apache/apisix-dashboard/pull/929#issuecomment-736125969 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr=h1) Report > Merging

[apisix-dashboard] branch deploy-master-as-demo updated (0a44498 -> 1480ff9)

2020-11-30 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch deploy-master-as-demo in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 0a44498 fix typo add 18744a5 test: add route with priority (E2E) (#893) add

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

2020-11-30 Thread GitBox
nic-chen commented on a change in pull request #929: URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533095028 ## File path: docs/deploy-with-docker.md ## @@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag . # For users in mainland China, the

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

2020-11-30 Thread GitBox
membphis commented on a change in pull request #929: URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533093817 ## File path: docs/deploy-with-docker.md ## @@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag . # For users in mainland China, the

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #906: test: add e2e test cases for route with plugin cors

2020-11-30 Thread GitBox
codecov-io edited a comment on pull request #906: URL: https://github.com/apache/apisix-dashboard/pull/906#issuecomment-735516563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/906?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io commented on pull request #927: test: config route with management fileds (E2E)

2020-11-30 Thread GitBox
codecov-io commented on pull request #927: URL: https://github.com/apache/apisix-dashboard/pull/927#issuecomment-736244788 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/927?src=pr=h1) Report > Merging

[GitHub] [apisix-docker] membphis commented on a change in pull request #91: feat: modify docs for Apache APISIX 2.1

2020-11-30 Thread GitBox
membphis commented on a change in pull request #91: URL: https://github.com/apache/apisix-docker/pull/91#discussion_r533091870 ## File path: example/apisix_conf/config.yaml ## @@ -1,137 +1,22 @@ apisix: Review comment: missing Apache License header, any way we can fix

[GitHub] [apisix-dashboard] codecov-io commented on pull request #931: chore: change the default port of manager api from 8080 to 9000

2020-11-30 Thread GitBox
codecov-io commented on pull request #931: URL: https://github.com/apache/apisix-dashboard/pull/931#issuecomment-736242447 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/931?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io commented on pull request #932: test: e2e test cHash upstream with key (query_string, arg_xxx)

2020-11-30 Thread GitBox
codecov-io commented on pull request #932: URL: https://github.com/apache/apisix-dashboard/pull/932#issuecomment-736241646 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/932?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #929: CD: auto deploy codes on the master branch to the online demo

2020-11-30 Thread GitBox
codecov-io edited a comment on pull request #929: URL: https://github.com/apache/apisix-dashboard/pull/929#issuecomment-736125969 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

2020-11-30 Thread GitBox
nic-chen commented on a change in pull request #929: URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533090365 ## File path: .github/workflows/deploy-with-docker.yml ## @@ -4,6 +4,9 @@ on: push: branches: - master + pull_request: +

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

2020-11-30 Thread GitBox
nic-chen commented on a change in pull request #929: URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533090251 ## File path: docs/deploy-with-docker.md ## @@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag . # For users in mainland China, the

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

2020-11-30 Thread GitBox
nic-chen commented on a change in pull request #929: URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533090228 ## File path: docs/deploy-with-docker.zh-CN.md ## @@ -38,6 +38,9 @@ $ docker build -t apisix-dashboard:$tag . # 对于中国大陆的用户,可启用 `ENABLE_PROXY`

[GitHub] [apisix-dashboard] idbeta opened a new pull request #932: test: e2e test cHash upstream with key (query_string, arg_xxx)

2020-11-30 Thread GitBox
idbeta opened a new pull request #932: URL: https://github.com/apache/apisix-dashboard/pull/932 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] E2E test - [ ] New feature provided - [ ] Improve performance

[apisix-dashboard] branch deploy-master-as-demo updated (4bda232 -> 0a44498)

2020-11-30 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch deploy-master-as-demo in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 4bda232 doc: fix description about build docker image in doc add 0a44498 fix typo

[GitHub] [apisix-dashboard] nic-chen closed issue #635: add e2e test for config route with priority

2020-11-30 Thread GitBox
nic-chen closed issue #635: URL: https://github.com/apache/apisix-dashboard/issues/635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] nic-chen merged pull request #893: test: add route with priority (E2E)

2020-11-30 Thread GitBox
nic-chen merged pull request #893: URL: https://github.com/apache/apisix-dashboard/pull/893 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-dashboard] branch master updated (96e3ad1 -> 18744a5)

2020-11-30 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 96e3ad1 chore: fix typo, `MangerApiExpect` should be `ManagerApiExpect` (#926) add 18744a5

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #880: test: add consumer with incorrect input ( E2E )

2020-11-30 Thread GitBox
idbeta commented on a change in pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#discussion_r533083451 ## File path: api/test/e2e/consumer_test.go ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [apisix] tokers edited a comment on issue #2906: [DISCUSS]: is it reasonable to support "upstream group"?

2020-11-30 Thread GitBox
tokers edited a comment on issue #2906: URL: https://github.com/apache/apisix/issues/2906#issuecomment-736217477 @wfgydbu What you described is more like a load balancing algorithm, which defines the topology for each node (in your context, not the node in APISIX upstream) and the

[GitHub] [apisix] tokers commented on issue #2906: [DISCUSS]: is it reasonable to support "upstream group"?

2020-11-30 Thread GitBox
tokers commented on issue #2906: URL: https://github.com/apache/apisix/issues/2906#issuecomment-736217477 @wfgydbu What you described is more like a load balancing algorithm, which defines the topology for each node (in your context, not the node in APISIX upstream) and the abstraction

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #874: test: add route with invalid remote_addr (E2E)

2020-11-30 Thread GitBox
codecov-io edited a comment on pull request #874: URL: https://github.com/apache/apisix-dashboard/pull/874#issuecomment-733660890 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/874?src=pr=h1) Report > Merging

[GitHub] [apisix-docker] gxthrj removed a comment on pull request #91: feat: modify docs for Apache APISIX 2.1

2020-11-30 Thread GitBox
gxthrj removed a comment on pull request #91: URL: https://github.com/apache/apisix-docker/pull/91#issuecomment-736215382 > NO, you can not delete this line Keep one in the header of README This is an automated

[GitHub] [apisix] gy09535 edited a comment on issue #2899: bug: Etcd jwt refresh error can cause gateway cluster crash.

2020-11-30 Thread GitBox
gy09535 edited a comment on issue #2899: URL: https://github.com/apache/apisix/issues/2899#issuecomment-736213624 > @gy09535 > Can you provide a packet capture file so we can analyze it? [tcp_etcd_01.cap.zip](https://github.com/apache/apisix/files/5620286/tcp_etcd_01.cap.zip)

[GitHub] [apisix-docker] gxthrj commented on pull request #91: feat: modify docs for Apache APISIX 2.1

2020-11-30 Thread GitBox
gxthrj commented on pull request #91: URL: https://github.com/apache/apisix-docker/pull/91#issuecomment-736215382 > NO, you can not delete this line Keep one in the header of README This is an automated message from

[GitHub] [apisix] gy09535 edited a comment on issue #2899: bug: Etcd jwt refresh error can cause gateway cluster crash.

2020-11-30 Thread GitBox
gy09535 edited a comment on issue #2899: URL: https://github.com/apache/apisix/issues/2899#issuecomment-736213624 > @gy09535 > Can you provide a packet capture file so we can analyze it? [tcp_etcd_01.cap.zip](https://github.com/apache/apisix/files/5620286/tcp_etcd_01.cap.zip)

[GitHub] [apisix-docker] tokers commented on issue #90: How to connect etcd cluster with tls

2020-11-30 Thread GitBox
tokers commented on issue #90: URL: https://github.com/apache/apisix-docker/issues/90#issuecomment-736214269 This is a bug, we don't respect the scheme when calling `bin/apisix init_etcd`. This is an automated message from

  1   2   3   4   >