jinchizhou commented on issue #566:
URL:
https://github.com/apache/apisix-dashboard/issues/566#issuecomment-740128575
Hey @nic-chen ,
When setting up, I ran into the issue
```
make api-run
cd api/ && go run .
{"level":"warn","ts":"2020-12-07T11:15:29.958-0800","caller"
jinchizhou commented on issue #566:
URL:
https://github.com/apache/apisix-dashboard/issues/566#issuecomment-740132149
I exported ETCDCTL_API = 2 and got
```
jordans-mbp-4:apisix-dashboard jordanlee$ export ETCDCTL_API=2
jordans-mbp-4:apisix-dashboard jordanlee$ make api-run
cd
juzhiyuan commented on issue #831:
URL:
https://github.com/apache/apisix-dashboard/issues/831#issuecomment-740218196
I see, i will check this ASAP.
This is an automated message from the Apache Git Service.
To respond to the
juzhiyuan commented on pull request #949:
URL: https://github.com/apache/apisix-dashboard/pull/949#issuecomment-740219277
emm selector is used to select nodes, not category.
This is an automated message from the Apache Git S
moonming commented on issue #975:
URL:
https://github.com/apache/apisix-dashboard/issues/975#issuecomment-740272515
What is "web test"?
Please use technical terms
This is an automated message from the Apache Git Servi
nic-chen commented on pull request #976:
URL: https://github.com/apache/apisix-dashboard/pull/976#issuecomment-740285549
> why 0.1 second is not enough？ 0.001 is also should works IMO
I have updated the description, please have a look.
---
nic-chen commented on issue #566:
URL:
https://github.com/apache/apisix-dashboard/issues/566#issuecomment-740287370
Hi @jinchizhou , what's your ETCD version ? 3.4+ is required.
This is an automated message from the Apache
nic-chen commented on issue #566:
URL:
https://github.com/apache/apisix-dashboard/issues/566#issuecomment-740290941
you could contact my QQ 4061470 if convenient. we could quickly communicate
these env issues.
This is
codecov-io edited a comment on pull request #970:
URL: https://github.com/apache/apisix-dashboard/pull/970#issuecomment-739443961
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=h1)
Report
> Merging
[#970](https://codecov.io/gh/apache/apisix-dashboard/pull/
nic-chen commented on issue #603:
URL:
https://github.com/apache/apisix-dashboard/issues/603#issuecomment-740298874
We could add a simple access log first. It is conducive for data analysis
and problem location.
We could add advanced features later, such as custom fields and custom
codecov-io edited a comment on pull request #970:
URL: https://github.com/apache/apisix-dashboard/pull/970#issuecomment-739443961
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=h1)
Report
> Merging
[#970](https://codecov.io/gh/apache/apisix-dashboard/pull/
nic-chen commented on a change in pull request #904:
URL: https://github.com/apache/apisix-dashboard/pull/904#discussion_r537961309
##
File path: api/internal/core/store/validate_test.go
##
@@ -249,6 +248,30 @@ func TestAPISIXJsonSchemaValidator_checkUpstream(t
*testing.T) {
tokers opened a new issue #60:
URL: https://github.com/apache/apisix-ingress-controller/issues/60
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
tokers commented on a change in pull request #2926:
URL: https://github.com/apache/apisix/pull/2926#discussion_r537966724
##
File path: apisix/plugins/server-info.lua
##
@@ -0,0 +1,238 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor
tokers opened a new issue #2988:
URL: https://github.com/apache/apisix/issues/2988
So far we don't enable the SNI extension when communicating with upstream.
We should enable this feature by enable `proxy_ssl_server_name`.
T
tokers commented on a change in pull request #2926:
URL: https://github.com/apache/apisix/pull/2926#discussion_r537966724
##
File path: apisix/plugins/server-info.lua
##
@@ -0,0 +1,238 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor
dickens7 commented on issue #2973:
URL: https://github.com/apache/apisix/issues/2973#issuecomment-740307037
yes this will cause severe performance degration. And this requires further
study of th accelearation service provided by different vendors. just put this
issue aside, and i will su
gy09535 closed issue #2899:
URL: https://github.com/apache/apisix/issues/2899
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
jinchizhou commented on issue #566:
URL:
https://github.com/apache/apisix-dashboard/issues/566#issuecomment-740309060
Unfortunately my windows computer doesn't have the capability to support
ETCD. Sorry, looks like I can't work on this open source repo :(.
--
tokers commented on a change in pull request #2926:
URL: https://github.com/apache/apisix/pull/2926#discussion_r537973912
##
File path: doc/plugins/server-info.md
##
@@ -0,0 +1,104 @@
+
+
+- [中文](../zh-cn/plugins/server-info.md)
+
+# Summary
+
+- [**Name**](#name)
+- [**Attribu
tokers commented on a change in pull request #2926:
URL: https://github.com/apache/apisix/pull/2926#discussion_r537974155
##
File path: apisix/plugins/server-info.lua
##
@@ -0,0 +1,238 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor
tokers commented on a change in pull request #2926:
URL: https://github.com/apache/apisix/pull/2926#discussion_r537974209
##
File path: apisix/plugins/server-info.lua
##
@@ -0,0 +1,238 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor
tokers commented on a change in pull request #2926:
URL: https://github.com/apache/apisix/pull/2926#discussion_r537974741
##
File path: doc/plugins/server-info.md
##
@@ -0,0 +1,104 @@
+
+
+- [中文](../zh-cn/plugins/server-info.md)
+
+# Summary
+
+- [**Name**](#name)
+- [**Attribu
suifff opened a new issue #980:
URL: https://github.com/apache/apisix-dashboard/issues/980
# Feature request
## Please describe your feature
用户下载服务商crt证书后可直接上传 | Users can upload CRT certificate directly after
downloading.
## Describe the solution you'd like
能够在控
codecov-io edited a comment on pull request #970:
URL: https://github.com/apache/apisix-dashboard/pull/970#issuecomment-739443961
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=h1)
Report
> Merging
[#970](https://codecov.io/gh/apache/apisix-dashboard/pull/
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch juzhiyuan-patch-1
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
at 59bee22 feat(CI): supoort markdown links checker
This branch includes the following new com
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch juzhiyuan-patch-1
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
commit 59bee2220a0bb9c8619b6f1a9a819b2f5d1fc78a
Author: 琚致远
AuthorDate: Tue Dec 8 10:28:40 2020 +0800
juzhiyuan opened a new pull request #981:
URL: https://github.com/apache/apisix-dashboard/pull/981
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- Related
Bhanuji95 commented on issue #33:
URL:
https://github.com/apache/apisix-ingress-controller/issues/33#issuecomment-740326084
Hi, I removed admin_key and used allow_admin settings as you suggested, but
then the log message says **admin_key is missing**.
starsz commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r537993157
##
File path: api/build.sh
##
@@ -19,6 +19,9 @@ set -ex
export ENV=local
pwd=`pwd`
+VERSION=$(cat ./api/VERSION)
Review comment:
I agree
Bhanuji95 edited a comment on issue #33:
URL:
https://github.com/apache/apisix-ingress-controller/issues/33#issuecomment-740326084
Hi, I removed admin_key and used allow_admin settings as you suggested, but
then the log message says **admin_key is missing**. Can you please suggest
anythi
starsz commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r537994568
##
File path: api/main.go
##
@@ -35,6 +35,16 @@ import (
"github.com/apisix/manager-api/log"
)
+var Version string
+
+func printInfo() {
Bhanuji95 edited a comment on issue #33:
URL:
https://github.com/apache/apisix-ingress-controller/issues/33#issuecomment-740326084
Hi, I removed admin_key and used allow_admin settings as you suggested, but
then the log message says **admin_key is missing**. Can you please suggest
anythi
ShiningRush commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r537995851
##
File path: api/build.sh
##
@@ -19,6 +19,9 @@ set -ex
export ENV=local
pwd=`pwd`
+VERSION=$(cat ./api/VERSION)
Review comment:
If
tokers edited a comment on issue #2821:
URL: https://github.com/apache/apisix/issues/2821#issuecomment-732206604
OK, let's just add the most basic fields now:
```json
{
"id": "ddea4053-4ffd-4f09-b176-b8c5e919916b",
"hostname": "localhost.local",
"version": "2.0
starsz commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r537997032
##
File path: api/main.go
##
@@ -35,6 +35,16 @@ import (
"github.com/apisix/manager-api/log"
)
+var Version string
+
+func printInfo() {
ShiningRush commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r537995851
##
File path: api/build.sh
##
@@ -19,6 +19,9 @@ set -ex
export ENV=local
pwd=`pwd`
+VERSION=$(cat ./api/VERSION)
Review comment:
If
ziyou434 opened a new issue #2989:
URL: https://github.com/apache/apisix/issues/2989
### Issue description
when I set url: "/index.html" ,there is nothing wrong.
But I set url: "foo/index.html" or "foo/bar/index.html", it will give me
{"error_msg":"failed to match any routes"}.
Is
ShiningRush commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r537999422
##
File path: api/main.go
##
@@ -35,6 +35,16 @@ import (
"github.com/apisix/manager-api/log"
)
+var Version string
+
+func printInfo
wfgydbu commented on issue #2985:
URL: https://github.com/apache/apisix/issues/2985#issuecomment-740344661
https://github.com/apache/apisix/blob/v2.1/apisix/plugins/limit-conn.lua#L88-L94
I think these code should be something like this:
```
if lim:is_committed() then
ShiningRush commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r537999422
##
File path: api/main.go
##
@@ -35,6 +35,16 @@ import (
"github.com/apisix/manager-api/log"
)
+var Version string
+
+func printInfo
codecov-io edited a comment on pull request #904:
URL: https://github.com/apache/apisix-dashboard/pull/904#issuecomment-735344204
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/904?src=pr&el=h1)
Report
> Merging
[#904](https://codecov.io/gh/apache/apisix-dashboard/pull/
spacewander commented on issue #2985:
URL: https://github.com/apache/apisix/issues/2985#issuecomment-740346852
@wfgydbu
Would you try https://github.com/apache/apisix/pull/2465/files and report if
the issue can be fixed by this?
ShiningRush commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r537999422
##
File path: api/main.go
##
@@ -35,6 +35,16 @@ import (
"github.com/apisix/manager-api/log"
)
+var Version string
+
+func printInfo
starsz commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r538005078
##
File path: api/build.sh
##
@@ -19,6 +19,9 @@ set -ex
export ENV=local
pwd=`pwd`
+VERSION=$(cat ./api/VERSION)
Review comment:
Hi, I w
wfgydbu commented on issue #2985:
URL: https://github.com/apache/apisix/issues/2985#issuecomment-740349882
Sure. I'd like to.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nic-chen commented on issue #566:
URL:
https://github.com/apache/apisix-dashboard/issues/566#issuecomment-740350886
> Unfortunately my windows computer doesn't have the capability to support
ETCD. Sorry, looks like I can't work on this open source repo :(.
@jinchizhou It doesn't ma
ShiningRush commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r538007057
##
File path: api/main.go
##
@@ -35,6 +35,16 @@ import (
"github.com/apisix/manager-api/log"
)
+var Version string
+
+func printInfo
spacewander opened a new pull request #2990:
URL: https://github.com/apache/apisix/pull/2990
Also merge bundle of repeated code.
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submission checklist:
* [ ] Did you explain what pr
spacewander commented on a change in pull request #2926:
URL: https://github.com/apache/apisix/pull/2926#discussion_r538007869
##
File path: apisix/plugins/server-info.lua
##
@@ -0,0 +1,238 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contri
ShiningRush commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r538008577
##
File path: api/build.sh
##
@@ -19,6 +19,9 @@ set -ex
export ENV=local
pwd=`pwd`
+VERSION=$(cat ./api/VERSION)
Review comment:
Co
spacewander commented on a change in pull request #2926:
URL: https://github.com/apache/apisix/pull/2926#discussion_r538009963
##
File path: doc/plugins/server-info.md
##
@@ -0,0 +1,104 @@
+
+
+- [中文](../zh-cn/plugins/server-info.md)
+
+# Summary
+
+- [**Name**](#name)
+- [**At
membphis commented on a change in pull request #2964:
URL: https://github.com/apache/apisix/pull/2964#discussion_r538009201
##
File path: apisix/core/ctx.lua
##
@@ -84,6 +158,10 @@ do
key = re_gsub(key, "-", "_", "jo")
val = get_var(key, t._req
spacewander commented on a change in pull request #2964:
URL: https://github.com/apache/apisix/pull/2964#discussion_r538018558
##
File path: t/lib/test_admin.lua
##
@@ -108,14 +108,15 @@ function _M.comp_tab(left_tab, right_tab)
local err
dir_names = {}
+local _
codecov-io edited a comment on pull request #977:
URL: https://github.com/apache/apisix-dashboard/pull/977#issuecomment-739972588
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/977?src=pr&el=h1)
Report
> Merging
[#977](https://codecov.io/gh/apache/apisix-dashboard/pull/
idbeta opened a new pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982
fixed #975
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Frontend E2E test
- [ ] New feature provided
- [ ] Improve pe
juzhiyuan commented on pull request #949:
URL: https://github.com/apache/apisix-dashboard/pull/949#issuecomment-740376380
## APIs
### Fetch Node List
TODO
### Fetch Node Detail
```json
{
"id": "ddea4053-4ffd-4f09-b176-b8c5e919916b",
"hostname": "localhost
moonming commented on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740381246
why e2e test cases in “src” dir？
This is an automated message from the Apache Git Service.
To respond to
moonming commented on a change in pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r538041881
##
File path: web/src/e2e/Route.e2e.js
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contribu
tokers commented on a change in pull request #48:
URL:
https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r537985950
##
File path: README.md
##
@@ -2,7 +2,16 @@
Use Apache APISIX for Kubernetes
[Ingress](https://kubernetes.io/docs/concepts/services-netw
spacewander merged pull request #2986:
URL: https://github.com/apache/apisix/pull/2986
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
spacewander closed issue #2827:
URL: https://github.com/apache/apisix/issues/2827
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 6cd780c feat: install lua-resty-hmac-ffi (#2981)
add 7907500 feat(fault-injection): support Nginx variabl
tokers commented on a change in pull request #2926:
URL: https://github.com/apache/apisix/pull/2926#discussion_r538045822
##
File path: doc/plugins/server-info.md
##
@@ -0,0 +1,104 @@
+
+
+- [中文](../zh-cn/plugins/server-info.md)
+
+# Summary
+
+- [**Name**](#name)
+- [**Attribu
tokers commented on a change in pull request #2926:
URL: https://github.com/apache/apisix/pull/2926#discussion_r538046568
##
File path: apisix/plugins/server-info.lua
##
@@ -0,0 +1,238 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a change to branch kv/docs
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git.
from 0fcd3fd doc: change docs/develop.md to english
add d53868b doc: remove compare with other ing
gxthrj commented on a change in pull request #48:
URL:
https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r538048793
##
File path: README.md
##
@@ -2,7 +2,16 @@
Use Apache APISIX for Kubernetes
[Ingress](https://kubernetes.io/docs/concepts/services-netw
gxthrj commented on a change in pull request #48:
URL:
https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r538050460
##
File path: README.md
##
@@ -2,7 +2,16 @@
Use Apache APISIX for Kubernetes
[Ingress](https://kubernetes.io/docs/concepts/services-netw
gxthrj commented on a change in pull request #48:
URL:
https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r538050918
##
File path: README.md
##
@@ -2,7 +2,16 @@
Use Apache APISIX for Kubernetes
[Ingress](https://kubernetes.io/docs/concepts/services-netw
wfgydbu edited a comment on issue #2985:
URL: https://github.com/apache/apisix/issues/2985#issuecomment-740344661
https://github.com/apache/apisix/blob/v2.1/apisix/plugins/limit-conn.lua#L88-L94
I think these code should be something like this:
```
if lim:is_committed() the
gxthrj commented on a change in pull request #48:
URL:
https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r538051398
##
File path: README.md
##
@@ -2,7 +2,16 @@
Use Apache APISIX for Kubernetes
[Ingress](https://kubernetes.io/docs/concepts/services-netw
gxthrj commented on a change in pull request #48:
URL:
https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r538048793
##
File path: README.md
##
@@ -2,7 +2,16 @@
Use Apache APISIX for Kubernetes
[Ingress](https://kubernetes.io/docs/concepts/services-netw
gxthrj commented on a change in pull request #48:
URL:
https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r538052942
##
File path: README.md
##
@@ -13,147 +22,84 @@ Configure
[plugins](https://github.com/apache/apisix/tree/master/doc/plugins), l
* Support
gxthrj commented on a change in pull request #48:
URL:
https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r538055175
##
File path: README.md
##
@@ -13,147 +22,84 @@ Configure
[plugins](https://github.com/apache/apisix/tree/master/doc/plugins), l
* Support
gxthrj commented on a change in pull request #48:
URL:
https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r538055367
##
File path: docs/FAQ.md
##
@@ -0,0 +1,15 @@
+# FAQ
+
+1. How to bind between Service and Upstream?
Review comment:
Done
--
gxthrj commented on a change in pull request #48:
URL:
https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r538055578
##
File path: docs/design.md
##
@@ -36,6 +36,88 @@ Apache APISIX ingress for Kubernetes.
- match and covert Apisix-ingress-types to Apisi
gxthrj commented on a change in pull request #48:
URL:
https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r538056103
##
File path: docs/design.md
##
@@ -36,6 +36,88 @@ Apache APISIX ingress for Kubernetes.
- match and covert Apisix-ingress-types to Apisi
gxthrj commented on a change in pull request #48:
URL:
https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r538056451
##
File path: docs/develop.md
##
@@ -162,22 +168,22 @@ spec:
host: internalalpha.talkinggenie.com
enable_websocket
idbeta commented on issue #2989:
URL: https://github.com/apache/apisix/issues/2989#issuecomment-740397552
What are your steps? In my environment, APISIX does not have this problem,
but the dashboard will prompt that this setting is not allowed.
---
gxthrj commented on a change in pull request #48:
URL:
https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r538056827
##
File path: docs/install.md
##
@@ -0,0 +1,129 @@
+# Installation
+
+## Dependencies
+
+* Kubernetes
+* [Deploy Apache APISIX in
k8s](http
ziyou434 commented on issue #2989:
URL: https://github.com/apache/apisix/issues/2989#issuecomment-740398515
> What are your steps? In my environment, APISIX does not have this problem,
but the dashboard will prompt that this setting is not allowed.
```
curl http://127.0.0.1:9080/a
codecov-io commented on pull request #972:
URL: https://github.com/apache/apisix-dashboard/pull/972#issuecomment-740398706
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/972?src=pr&el=h1)
Report
> Merging
[#972](https://codecov.io/gh/apache/apisix-dashboard/pull/972?src
codecov-io commented on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1)
Report
> Merging
[#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a change to branch chore/cli
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git.
at 7fd967f chore: added the command line
This branch includes the following new commits:
n
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch chore/cli
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
commit 7fd967fdd3cdb2b45c488a207f1fef13ac31bcf3
Author: tokers
AuthorDate: Tue Dec 8 14:05:42 2020 +0800
tokers opened a new pull request #61:
URL: https://github.com/apache/apisix-ingress-controller/pull/61
Closing #56 .
This PR introduces [cobra](https://github.com/spf13/cobra) as the command
line framework. Currently we have only one custom sub command "ingress", which
is the entryp
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a change to branch kv/docs
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git.
from d53868b doc: remove compare with other ingress controller
add a2f7a66 doc: modify desc
No ne
tokers commented on pull request #61:
URL:
https://github.com/apache/apisix-ingress-controller/pull/61#issuecomment-740403392
@gxthrj @membphis Need your help to review this PR.
This is an automated message from the Apache G
gxthrj commented on a change in pull request #48:
URL:
https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r538061913
##
File path: docs/install.md
##
@@ -0,0 +1,129 @@
+# Installation
+
+## Dependencies
+
+* Kubernetes
+* [Deploy Apache APISIX in
k8s](http
codecov-io edited a comment on pull request #977:
URL: https://github.com/apache/apisix-dashboard/pull/977#issuecomment-739972588
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/977?src=pr&el=h1)
Report
> Merging
[#977](https://codecov.io/gh/apache/apisix-dashboard/pull/
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a change to branch chore/cli
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git.
from 7fd967f chore: added the command line
add 7bf66e0 fix: removed the redundant os.Exit()
membphis commented on issue #2924:
URL: https://github.com/apache/apisix/issues/2924#issuecomment-740405671
@juzhiyuan @liuxiran @nic-chen @moonming
I will close this issue and will create a new issue. I think we have
finished the discussion, and here is the final result.
Ple
membphis closed issue #2924:
URL: https://github.com/apache/apisix/issues/2924
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
membphis opened a new issue #2991:
URL: https://github.com/apache/apisix/issues/2991
**Here is the todo list(from the discussion)**
* `Admin API`: reject request data if it contains an empty array, eg:
`"remote_addrs": []`. `Code + Doc`
* `Manager API`: same as `Admin API`.
* `
juzhiyuan opened a new issue #983:
URL: https://github.com/apache/apisix-dashboard/issues/983
original comment
https://github.com/apache/apisix/issues/2924#issuecomment-740405671
# Feature request
## Please describe your feature
reject request data if it contains an emp
membphis opened a new issue #984:
URL: https://github.com/apache/apisix-dashboard/issues/984
To add a route, if the `remote_addrs` field is an empty array, the matching
behavior is ambiguous.
In order to avoid ambiguity and keep the API design simple and clear, we
should reject the
membphis commented on issue #984:
URL:
https://github.com/apache/apisix-dashboard/issues/984#issuecomment-740410851
@liuxiran @juzhiyuan @moonming pls take a look when you have time ^_^
This is an automated message from the
membphis commented on a change in pull request #48:
URL:
https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r537982915
##
File path: samples/deploy/rbac/apisix_view_clusterrolebinding.yaml
##
@@ -8,5 +8,4 @@ roleRef:
name: apisix-view-clusterrole
subjec
spacewander commented on a change in pull request #2926:
URL: https://github.com/apache/apisix/pull/2926#discussion_r538071956
##
File path: apisix/plugins/server-info.lua
##
@@ -0,0 +1,238 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contri
tokers commented on a change in pull request #2926:
URL: https://github.com/apache/apisix/pull/2926#discussion_r538073325
##
File path: apisix/plugins/server-info.lua
##
@@ -0,0 +1,238 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor
101 - 200 of 224 matches
Mail list logo
