[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1381: docs: Add back end E2E test document

2021-01-26 Thread GitBox
codecov-io edited a comment on pull request #1381: URL: https://github.com/apache/apisix-dashboard/pull/1381#issuecomment-768101272 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1381?src=pr&el=h1) Report > Merging [#1381](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1381: docs: Add back end E2E test document

2021-01-26 Thread GitBox
codecov-io edited a comment on pull request #1381: URL: https://github.com/apache/apisix-dashboard/pull/1381#issuecomment-768101272 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1381?src=pr&el=h1) Report > Merging [#1381](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-website] guoqqqi commented on a change in pull request #160: fix: adjust images' dimension

2021-01-26 Thread GitBox
guoqqqi commented on a change in pull request #160: URL: https://github.com/apache/apisix-website/pull/160#discussion_r565089939 ## File path: website/src/css/customTheme.css ## @@ -8,10 +8,6 @@ --ifm-color-primary-darker: #9a2521; --ifm-color-shadow--lw: #7f1e1b; } -.na

[GitHub] [apisix-website] guoqqqi commented on a change in pull request #160: fix: adjust images' dimension

2021-01-26 Thread GitBox
guoqqqi commented on a change in pull request #160: URL: https://github.com/apache/apisix-website/pull/160#discussion_r565091046 ## File path: website/src/css/customTheme.css ## @@ -8,10 +8,6 @@ --ifm-color-primary-darker: #9a2521; --ifm-color-shadow--lw: #7f1e1b; } -.na

[GitHub] [apisix-website] guoqqqi commented on a change in pull request #160: fix: adjust images' dimension

2021-01-26 Thread GitBox
guoqqqi commented on a change in pull request #160: URL: https://github.com/apache/apisix-website/pull/160#discussion_r565089939 ## File path: website/src/css/customTheme.css ## @@ -8,10 +8,6 @@ --ifm-color-primary-darker: #9a2521; --ifm-color-shadow--lw: #7f1e1b; } -.na

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1381: docs: Add back end E2E test document

2021-01-26 Thread GitBox
codecov-io commented on pull request #1381: URL: https://github.com/apache/apisix-dashboard/pull/1381#issuecomment-768101272 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1381?src=pr&el=h1) Report > Merging [#1381](https://codecov.io/gh/apache/apisix-dashboard/pull/138

[GitHub] [apisix] fukiki commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-26 Thread GitBox
fukiki commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-768098488 About the bug of `openresty-debug`, there are two suggestions: 1. Add conditions: when OpenResty version is not 1.19 , allow to use Lua 5.1 2. Modify document: introduce the b

[GitHub] [apisix-website] juzhiyuan commented on issue #158: adjust images' dimention

2021-01-26 Thread GitBox
juzhiyuan commented on issue #158: URL: https://github.com/apache/apisix-website/issues/158#issuecomment-768095186 Yes, it's related to V2. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] spacewander commented on a change in pull request #3300: feat: ewma use p2c to improve performance

2021-01-26 Thread GitBox
spacewander commented on a change in pull request #3300: URL: https://github.com/apache/apisix/pull/3300#discussion_r565077667 ## File path: apisix/balancer/ewma.lua ## @@ -135,16 +153,23 @@ local function _ewma_find(ctx, up_nodes) return nil, 'up_nodes trans error'

[GitHub] [apisix] Yiyiyimu opened a new issue #3434: todo: upload new grafana example to official webwite

2021-01-26 Thread GitBox
Yiyiyimu opened a new issue #3434: URL: https://github.com/apache/apisix/issues/3434 With #3402 got merged, we also need to update the example on grafana official, as presents in prometheus documentation. This is an automate

[GitHub] [apisix] spacewander opened a new pull request #3433: chore: both 'done' & 'recursive' mean the event is delivered

2021-01-26 Thread GitBox
spacewander opened a new pull request #3433: URL: https://github.com/apache/apisix/pull/3433 Let's use 'done' all the way to make tests happy. Fix #3432. Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist:

[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1381: Add back end E2E test document

2021-01-26 Thread GitBox
Jaycean opened a new pull request #1381: URL: https://github.com/apache/apisix-dashboard/pull/1381 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backpor

[GitHub] [apisix-website] KishaniKandasamy commented on issue #158: adjust images' dimention

2021-01-26 Thread GitBox
KishaniKandasamy commented on issue #158: URL: https://github.com/apache/apisix-website/issues/158#issuecomment-768078045 > ![image](https://user-images.githubusercontent.com/72343596/105866991-8a014300-602f-11eb-8c8c-9e20b71e5b42.png) > > **After upgrading to V2, Here is some CSS th

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1380: Doc: Add the document of backend E2E environment

2021-01-26 Thread GitBox
juzhiyuan commented on issue #1380: URL: https://github.com/apache/apisix-dashboard/issues/1380#issuecomment-768076672 cc @starsz @LiteSun to know this tip. This is an automated message from the Apache Git Service. To respon

[GitHub] [apisix-website] juzhiyuan commented on pull request #160: fix: adjust images' dimension

2021-01-26 Thread GitBox
juzhiyuan commented on pull request #160: URL: https://github.com/apache/apisix-website/pull/160#issuecomment-768075802 @guoqqqi Please review when you have time. This is an automated message from the Apache Git Service. To r

[GitHub] [apisix-website] KishaniKandasamy opened a new pull request #160: fix: adjust images' dimension

2021-01-26 Thread GitBox
KishaniKandasamy opened a new pull request #160: URL: https://github.com/apache/apisix-website/pull/160 Fixes: #158 Changes: I've updated customTheme.css This is an automated message from the Apache Git

[GitHub] [apisix] spacewander commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-26 Thread GitBox
spacewander commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-768074923 The problem occurs with `openresty-debug`. Since people might use openresty-debug package, the robust way is to avoid using LuaJIT unless you are using OpenResty 1.19.

[GitHub] [apisix] membphis commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-26 Thread GitBox
membphis commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-768072871 @spacewander told me that, this is a bug of openresty `1.15` or `1.17` . do you have any suggestions about this? ```shell luajit: lj_asm_x86.h:2819: asm_loop_fix

[GitHub] [apisix] spacewander merged pull request #3417: feat: allow customizing lua_package_path & lua_package_cpath

2021-01-26 Thread GitBox
spacewander merged pull request #3417: URL: https://github.com/apache/apisix/pull/3417 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated (8d61d31 -> d752b6f)

2021-01-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 8d61d31 fix: proxy_set_header Host $host may lose port info (#2079) add d752b6f feat: allow customizing l

[GitHub] [apisix] yongboy closed issue #3423: discuss: the service discovery module should export the number type of port value

2021-01-26 Thread GitBox
yongboy closed issue #3423: URL: https://github.com/apache/apisix/issues/3423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [apisix] yongboy commented on issue #3423: discuss: the service discovery module should export the number type of port value

2021-01-26 Thread GitBox
yongboy commented on issue #3423: URL: https://github.com/apache/apisix/issues/3423#issuecomment-768063466 Yes :)) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [apisix] fukiki commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-26 Thread GitBox
fukiki commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r565053974 ## File path: bin/apisix ## @@ -1,36 +1,40 @@ -#!/usr/bin/env lua +#!/bin/bash --- --- Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [apisix-dashboard] imjoey commented on issue #1380: Doc: Add the document of backend E2E environment

2021-01-26 Thread GitBox
imjoey commented on issue #1380: URL: https://github.com/apache/apisix-dashboard/issues/1380#issuecomment-768056790 @Jaycean good catch. I believe that would be very helpful for every contributor. Your PR is greatly welcome. Thanks. ---

[GitHub] [apisix-ingress-controller] Junnplus edited a comment on pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
Junnplus edited a comment on pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#issuecomment-768044322 @tokers `installCRDs` of kong is for compatibility helm2. this chart require helm 3.0+. see more in [chart best practices](https://helm.sh/docs/c

[GitHub] [apisix-dashboard] imjoey merged pull request #1379: doc: update location of manager-api address conf to config/defaultSettings.ts

2021-01-26 Thread GitBox
imjoey merged pull request #1379: URL: https://github.com/apache/apisix-dashboard/pull/1379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[apisix-dashboard] branch master updated: fix: update location of manager-api address conf to config/defaultSettings.ts in the develop.md (#1379)

2021-01-26 Thread majunjie
This is an automated email from the ASF dual-hosted git repository. majunjie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new e362009 fix: update location of man

[GitHub] [apisix] Firstsawyou commented on pull request #3430: feat: support specifying https in upstream to talk with https backend

2021-01-26 Thread GitBox
Firstsawyou commented on pull request #3430: URL: https://github.com/apache/apisix/pull/3430#issuecomment-768047761 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1372: test: add edit the plugin

2021-01-26 Thread GitBox
codecov-io edited a comment on pull request #1372: URL: https://github.com/apache/apisix-dashboard/pull/1372#issuecomment-766654973 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1372?src=pr&el=h1) Report > Merging [#1372](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-ingress-controller] Junnplus edited a comment on pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
Junnplus edited a comment on pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#issuecomment-768044322 @tokers `installCRDs` of kong is for compatibility helm2. this chart require helm 3.0+. see more in [chart best practices](https://helm.sh/docs/c

[GitHub] [apisix-ingress-controller] Junnplus edited a comment on pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
Junnplus edited a comment on pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#issuecomment-768044322 @tokers `installCRDs` of kong is for compatibility helm2. this chart require helm 3.0+. see more in [chart_best_practices](https://helm.sh/docs/c

[GitHub] [apisix-ingress-controller] Junnplus commented on pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
Junnplus commented on pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#issuecomment-768044322 @tokers `installCRDs` of kong is for compatibility helm2. this chart require helm 3.0+. > With the arrival of Helm 3, we removed the old crd-install hook

[GitHub] [apisix-dashboard] Jaycean opened a new issue #1380: Doc: Add the document of backend E2E environment

2021-01-26 Thread GitBox
Jaycean opened a new issue #1380: URL: https://github.com/apache/apisix-dashboard/issues/1380 # Feature request ## Please describe your feature - In the process of submitting my contribution, I found that there was no local documentation for setting up E2E test environment, an

[GitHub] [apisix-ingress-controller] tokers commented on pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
tokers commented on pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#issuecomment-768042163 @Junnplus The installation of CRDs (and the ClusterRole) should be optional, if we have multiple Ingress controller Deployments, only the first installation shou

[GitHub] [apisix-ingress-controller] Junnplus commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
Junnplus commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r565038361 ## File path: charts/apisix-ingress-controller/templates/rbac.yaml ## @@ -157,5 +153,6 @@ roleRef: name: {{ .Release.Name }}-clusterr

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
tokers commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r565036970 ## File path: charts/apisix-ingress-controller/templates/rbac.yaml ## @@ -157,5 +153,6 @@ roleRef: name: {{ .Release.Name }}-clusterrol

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
tokers commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r565036628 ## File path: charts/apisix-ingress-controller/Chart.yaml ## @@ -15,13 +15,14 @@ # limitations under the License. # apiVersion: v2 -nam

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
tokers commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r565036280 ## File path: charts/apisix-ingress-controller/Chart.yaml ## @@ -15,13 +15,14 @@ # limitations under the License. # apiVersion: v2 -nam

[GitHub] [apisix-ingress-controller] tokers commented on issue #211: request help: get "404 Route Not Found" when requesting to Apache APISIX to verify the route.

2021-01-26 Thread GitBox
tokers commented on issue #211: URL: https://github.com/apache/apisix-ingress-controller/issues/211#issuecomment-768039066 @lianghao208 By default APISIX has the source IP limitations, you need to change the `allow_admin` configuration. You can see https://github.com/apache/apisix-

[GitHub] [apisix-dashboard] membphis commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-26 Thread GitBox
membphis commented on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-768037066 wow, Congratulations this PR was merged This is an automated message from the Apache Git Service. To

[GitHub] [apisix] spacewander merged pull request #2079: fix: proxy_set_header Host $host may lose port info

2021-01-26 Thread GitBox
spacewander merged pull request #2079: URL: https://github.com/apache/apisix/pull/2079 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated (ea8eef8 -> 8d61d31)

2021-01-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from ea8eef8 fix: when called checker:get_target_status got err, we should log it~ (#3424) add 8d61d31 fix: p

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1379: doc: update location of manager-api address conf to config/defaultSettings.ts

2021-01-26 Thread GitBox
codecov-io commented on pull request #1379: URL: https://github.com/apache/apisix-dashboard/pull/1379#issuecomment-768024996 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1379?src=pr&el=h1) Report > Merging [#1379](https://codecov.io/gh/apache/apisix-dashboard/pull/137

[GitHub] [apisix] Yiyiyimu commented on issue #3432: bug: test admin/plugins-reload not stable

2021-01-26 Thread GitBox
Yiyiyimu commented on issue #3432: URL: https://github.com/apache/apisix/issues/3432#issuecomment-768024551 @spacewander do you know the reason of this This is an automated message from the Apache Git Service. To respond to t

[GitHub] [apisix] Yiyiyimu opened a new issue #3432: bug: test admin/plugins-reload not stable

2021-01-26 Thread GitBox
Yiyiyimu opened a new issue #3432: URL: https://github.com/apache/apisix/issues/3432 ### Issue description According to https://github.com/apache/apisix/pull/3404/checks?check_run_id=1774158810 ``` # Failed test 'TEST 3: reload plugins when attributes changed - response_body

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-26 Thread GitBox
juzhiyuan merged pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated (fa080a8 -> 9cb9aa7)

2021-01-26 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from fa080a8 fix: some apis bypassed authentication (#1373) add 9cb9aa7 feat(BE): Export route from Op

[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1379: doc: update location of manager-api address conf to config/defaultSettings.ts

2021-01-26 Thread GitBox
liuxiran opened a new pull request #1379: URL: https://github.com/apache/apisix-dashboard/pull/1379 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix ___ ### Bugfix - How to fix? update the doc due to the

[GitHub] [apisix] spacewander commented on issue #3423: discuss: the service discovery module should export the number type of port value

2021-01-26 Thread GitBox
spacewander commented on issue #3423: URL: https://github.com/apache/apisix/issues/3423#issuecomment-768013430 Consider solved? This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [apisix] spacewander merged pull request #3424: fix: when called checker:get_target_status got err, we should log it~

2021-01-26 Thread GitBox
spacewander merged pull request #3424: URL: https://github.com/apache/apisix/pull/3424 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated (2b532f0 -> ea8eef8)

2021-01-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 2b532f0 feat: proxy-rewrite host support host with port (#3428) add ea8eef8 fix: when called checker:get_

[GitHub] [apisix-ingress-controller] Junnplus commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
Junnplus commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r565013565 ## File path: charts/apisix-ingress-controller/templates/rbac.yaml ## @@ -157,5 +153,6 @@ roleRef: name: {{ .Release.Name }}-clusterr

[GitHub] [apisix] spacewander commented on issue #3431: bug: 插件的body_filter执行了两次

2021-01-26 Thread GitBox
spacewander commented on issue #3431: URL: https://github.com/apache/apisix/issues/3431#issuecomment-768007516 > Nginx output filters may be called multiple times for a single request because response body may be delivered in chunks. Thus, the Lua code specified by in this directive may al

[GitHub] [apisix] spacewander closed issue #3431: bug: 插件的body_filter执行了两次

2021-01-26 Thread GitBox
spacewander closed issue #3431: URL: https://github.com/apache/apisix/issues/3431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix-ingress-controller] lianghao208 commented on issue #211: request help: get "404 Route Not Found" when requesting to Apache APISIX to verify the route.

2021-01-26 Thread GitBox
lianghao208 commented on issue #211: URL: https://github.com/apache/apisix-ingress-controller/issues/211#issuecomment-768007123 @tokers I change the admin port to 9180, the controller log show 403: ```bash [root@VM-187-41-centos ~]# kc logs ingress-controller-79dbd87678-7qzwb -n ing

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
tokers commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r565008865 ## File path: charts/apisix-ingress-controller/templates/rbac.yaml ## @@ -157,5 +153,6 @@ roleRef: name: {{ .Release.Name }}-clusterrol

[GitHub] [apisix-ingress-controller] Junnplus commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
Junnplus commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r565008227 ## File path: charts/apisix-ingress-controller/Chart.yaml ## @@ -15,13 +15,14 @@ # limitations under the License. # apiVersion: v2 -n

[GitHub] [apisix] zhangpeix opened a new issue #3431: bug: 插件的body_filter执行了两次

2021-01-26 Thread GitBox
zhangpeix opened a new issue #3431: URL: https://github.com/apache/apisix/issues/3431 ### Issue description ### Environment * apisix version (cmd: `apisix version`):2.2 * OS: (cmd: `uname -a`) centeros7 * OpenResty / Nginx version: (cmd: `nginx -V` or `openresty -V`)

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
tokers commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r565007460 ## File path: charts/apisix-ingress-controller/templates/rbac.yaml ## @@ -157,5 +153,6 @@ roleRef: name: {{ .Release.Name }}-clusterrol

[GitHub] [apisix] yongboy commented on a change in pull request #3424: fix: when called checker:get_target_status got err, we should log it~

2021-01-26 Thread GitBox
yongboy commented on a change in pull request #3424: URL: https://github.com/apache/apisix/pull/3424#discussion_r565006701 ## File path: apisix/balancer.lua ## @@ -55,10 +55,12 @@ local function fetch_health_nodes(upstream, checker) local port = upstream.checks and upstrea

[GitHub] [apisix-ingress-controller] lianghao208 commented on issue #211: request help: get "404 Route Not Found" when requesting to Apache APISIX to verify the route.

2021-01-26 Thread GitBox
lianghao208 commented on issue #211: URL: https://github.com/apache/apisix-ingress-controller/issues/211#issuecomment-768002249 @tokers ```bash config.yaml: |- apisix: node_listen: 9080 # APISIX listening port enable_heartbeat: true

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
tokers commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r565005993 ## File path: charts/apisix-ingress-controller/templates/rbac.yaml ## @@ -14,11 +14,7 @@ # See the License for the specific language gove

[GitHub] [apisix-ingress-controller] Junnplus commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
Junnplus commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r565005939 ## File path: charts/apisix-ingress-controller/templates/rbac.yaml ## @@ -157,5 +153,6 @@ roleRef: name: {{ .Release.Name }}-clusterr

[GitHub] [apisix-ingress-controller] tokers commented on issue #211: request help: get "404 Route Not Found" when requesting to Apache APISIX to verify the route.

2021-01-26 Thread GitBox
tokers commented on issue #211: URL: https://github.com/apache/apisix-ingress-controller/issues/211#issuecomment-768001332 What's the configuration of apisix (config.y'all), it seems 9080 is not the admin port. This is an a

[GitHub] [apisix] yongboy commented on pull request #3424: fix: when called checker:get_target_status got err, we should log it~

2021-01-26 Thread GitBox
yongboy commented on pull request #3424: URL: https://github.com/apache/apisix/pull/3424#issuecomment-768000686 Now calling `checker:get_target_status` get error, the log example as below: ```bash 2021/01/27 11:34:52 [error] 8#8: *2315 [lua] balancer.lua:73: fetch_health_nodes():

[GitHub] [apisix] spacewander commented on a change in pull request #3424: fix: when called checker:get_target_status got err, we should log it~

2021-01-26 Thread GitBox
spacewander commented on a change in pull request #3424: URL: https://github.com/apache/apisix/pull/3424#discussion_r565004841 ## File path: apisix/balancer.lua ## @@ -55,10 +55,12 @@ local function fetch_health_nodes(upstream, checker) local port = upstream.checks and ups

[GitHub] [apisix-ingress-controller] Junnplus commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
Junnplus commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r565004318 ## File path: charts/apisix-ingress-controller/templates/rbac.yaml ## @@ -14,11 +14,7 @@ # See the License for the specific language go

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
tokers commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r565001676 ## File path: charts/apisix-ingress-controller/templates/rbac.yaml ## @@ -157,5 +153,6 @@ roleRef: name: {{ .Release.Name }}-clusterrol

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
tokers commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r565000280 ## File path: charts/apisix-ingress-controller/templates/rbac.yaml ## @@ -14,11 +14,7 @@ # See the License for the specific language gove

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
tokers commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r564998406 ## File path: charts/apisix-ingress-controller/Chart.yaml ## @@ -15,13 +15,14 @@ # limitations under the License. # apiVersion: v2 -nam

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
tokers commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r564998406 ## File path: charts/apisix-ingress-controller/Chart.yaml ## @@ -15,13 +15,14 @@ # limitations under the License. # apiVersion: v2 -nam

[GitHub] [apisix-helm-chart] Junnplus commented on a change in pull request #20: Modify Helm template to support multiple etcdhost, add anti-affinity

2021-01-26 Thread GitBox
Junnplus commented on a change in pull request #20: URL: https://github.com/apache/apisix-helm-chart/pull/20#discussion_r564996717 ## File path: chart/apisix/values.yaml ## @@ -188,5 +190,5 @@ nodeSelector: {} tolerations: [] -affinity: {} - +affinity: Review comment:

[GitHub] [apisix-ingress-controller] scn7th commented on pull request #214: adapt design diagrams

2021-01-26 Thread GitBox
scn7th commented on pull request #214: URL: https://github.com/apache/apisix-ingress-controller/pull/214#issuecomment-767984452 > @scn7th The docs/images/modules.png should be changed since now we integrated ingress-types to the apisix-ingress-controller. Ok, let me fix it. --

[GitHub] [apisix-ingress-controller] Junnplus commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
Junnplus commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r564993640 ## File path: charts/apisix-ingress-controller/Chart.yaml ## @@ -15,13 +15,14 @@ # limitations under the License. # apiVersion: v2 -n

[GitHub] [apisix] idbeta commented on a change in pull request #3404: feat: chaos test on route could still works when etcd is down

2021-01-26 Thread GitBox
idbeta commented on a change in pull request #3404: URL: https://github.com/apache/apisix/pull/3404#discussion_r564992390 ## File path: t/chaos/kill-etcd_test.go ## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lice

[GitHub] [apisix-ingress-controller] Junnplus commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
Junnplus commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r564992048 ## File path: charts/apisix-ingress-controller/README.md ## @@ -0,0 +1,44 @@ + + +# Apache APISIX Ingress Controller Helm Chart + +## Pr

[GitHub] [apisix-ingress-controller] Junnplus commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
Junnplus commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r564990948 ## File path: charts/apisix-ingress-controller/templates/rbac.yaml ## @@ -14,11 +14,7 @@ # See the License for the specific language go

[GitHub] [apisix] yongboy commented on a change in pull request #3424: fix: when called checker:get_target_status got err, we should log it~

2021-01-26 Thread GitBox
yongboy commented on a change in pull request #3424: URL: https://github.com/apache/apisix/pull/3424#discussion_r564990661 ## File path: apisix/balancer.lua ## @@ -55,10 +55,12 @@ local function fetch_health_nodes(upstream, checker) local port = upstream.checks and upstrea

[GitHub] [apisix] sober-wang commented on issue #3367: bug: When the apisix running in kubernetes ,If etcd is stop, the apisix status is still running.

2021-01-26 Thread GitBox
sober-wang commented on issue #3367: URL: https://github.com/apache/apisix/issues/3367#issuecomment-767980544 No, My means is when the etcd connect is failed ,the apisix pod should print error log in the stdout or stderr . apisix server can used error-logger plugin ---

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
codecov-io edited a comment on pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#issuecomment-767550262 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/213?src=pr&el=h1) Report > Merging [#213](https://codecov.io/gh/apache/api

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
codecov-io edited a comment on pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#issuecomment-767550262 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/213?src=pr&el=h1) Report > Merging [#213](https://codecov.io/gh/apache/api

[GitHub] [apisix] Firstsawyou commented on pull request #2586: chore: `limit-req` plugin code optimization #2448

2021-01-26 Thread GitBox
Firstsawyou commented on pull request #2586: URL: https://github.com/apache/apisix/pull/2586#issuecomment-767976195 Hi,@tashiya-menuri The test case has not been fixed yet, do you need help? This is an automated message

[GitHub] [apisix] spacewander opened a new pull request #3430: feat: support specifying https in upstream

2021-01-26 Thread GitBox
spacewander opened a new pull request #3430: URL: https://github.com/apache/apisix/pull/3430 Fix #3336 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or w

[GitHub] [apisix-ingress-controller] Junnplus commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
Junnplus commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r564983327 ## File path: charts/apisix-ingress-controller/README.md ## @@ -0,0 +1,44 @@ + + +# Apache APISIX Ingress Controller Helm Chart + +## Pr

[GitHub] [apisix-ingress-controller] Junnplus commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
Junnplus commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r564981885 ## File path: charts/apisix-ingress-controller/Chart.yaml ## @@ -15,13 +15,14 @@ # limitations under the License. # apiVersion: v2 -n

[GitHub] [apisix-website] juzhiyuan commented on issue #159: Visit Downloads page without docs prefix

2021-01-26 Thread GitBox
juzhiyuan commented on issue #159: URL: https://github.com/apache/apisix-website/issues/159#issuecomment-767970041 This issue relies on #157, should resolve #157 first. This is an automated message from the Apache Git Service

[GitHub] [apisix-ingress-controller] Junnplus commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
Junnplus commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r564980836 ## File path: charts/apisix-ingress-controller/templates/rbac.yaml ## @@ -157,5 +153,6 @@ roleRef: name: {{ .Release.Name }}-clusterr

[GitHub] [apisix] spacewander merged pull request #3428: feat: proxy-rewrite host support host with port

2021-01-26 Thread GitBox
spacewander merged pull request #3428: URL: https://github.com/apache/apisix/pull/3428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: feat: proxy-rewrite host support host with port (#3428)

2021-01-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 2b532f0 feat: proxy-rewrite host support h

[GitHub] [apisix] spacewander closed issue #3136: bug: why does host proxy_write not support such as ip+port

2021-01-26 Thread GitBox
spacewander closed issue #3136: URL: https://github.com/apache/apisix/issues/3136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] spacewander commented on a change in pull request #3417: feat: allow customizing lua_package_path & lua_package_cpath

2021-01-26 Thread GitBox
spacewander commented on a change in pull request #3417: URL: https://github.com/apache/apisix/pull/3417#discussion_r564975536 ## File path: apisix/cli/ops.lua ## @@ -121,6 +122,19 @@ local function version() end +local function get_lua_path(conf) +if conf then +

[GitHub] [apisix-ingress-controller] lianghao208 commented on issue #211: request help: get "404 Route Not Found" when requesting to Apache APISIX to verify the route.

2021-01-26 Thread GitBox
lianghao208 commented on issue #211: URL: https://github.com/apache/apisix-ingress-controller/issues/211#issuecomment-767961519 @tokers I just configured the pod ip:port of apisix gateway, the controller log shows as follow: ```bash [root@VM-187-41-centos ~]# kc logs ingress-controll

[GitHub] [apisix] TkClark commented on issue #3426: bug: At the same time use proxy-rewrite and traffic-split, may be cause the proxy-rewrite didn't work

2021-01-26 Thread GitBox
TkClark commented on issue #3426: URL: https://github.com/apache/apisix/issues/3426#issuecomment-767960994 now useing apisix-dashboard, we were in the testing, This is an automated message from the Apache Git Service. To resp

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1376: feat: change the order of the nav

2021-01-26 Thread GitBox
LiteSun commented on a change in pull request #1376: URL: https://github.com/apache/apisix-dashboard/pull/1376#discussion_r564973620 ## File path: web/cypress/integration/route/create-route-with-upstream.spec.js ## @@ -88,6 +89,7 @@ context('Create Route with Upstream', () => {

[GitHub] [apisix] tokers commented on a change in pull request #3415: feat: support to communicate with etcd by TLS in command line

2021-01-26 Thread GitBox
tokers commented on a change in pull request #3415: URL: https://github.com/apache/apisix/pull/3415#discussion_r564971324 ## File path: .github/workflows/build.yml ## @@ -54,7 +54,7 @@ jobs: submodules: recursive - name: Linux Get dependencies -run:

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #213: refactoring helm chart

2021-01-26 Thread GitBox
tokers commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r564965301 ## File path: charts/apisix-ingress-controller/README.md ## @@ -0,0 +1,44 @@ + + +# Apache APISIX Ingress Controller Helm Chart + +## Prer

[GitHub] [apisix-ingress-controller] tokers commented on pull request #214: adapt design diagrams

2021-01-26 Thread GitBox
tokers commented on pull request #214: URL: https://github.com/apache/apisix-ingress-controller/pull/214#issuecomment-767950552 @scn7th The docs/images/modules.png should be changed since now we integrated ingress-types to the apisix-ingress-controller. --

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3404: feat: chaos test on route could still works when etcd is down

2021-01-26 Thread GitBox
Yiyiyimu commented on a change in pull request #3404: URL: https://github.com/apache/apisix/pull/3404#discussion_r564963975 ## File path: t/chaos/kill-etcd_test.go ## @@ -51,6 +52,7 @@ func caseCheck(tc httpTestCase) { } if req == nil { + fmt.Pri

[GitHub] [apisix] tokers commented on a change in pull request #3404: feat: chaos test on route could still works when etcd is down

2021-01-26 Thread GitBox
tokers commented on a change in pull request #3404: URL: https://github.com/apache/apisix/pull/3404#discussion_r564960763 ## File path: t/chaos/kill-etcd_test.go ## @@ -51,6 +52,7 @@ func caseCheck(tc httpTestCase) { } if req == nil { + fmt.Print

[GitHub] [apisix-helm-chart] tokers commented on pull request #26: fix the tmplate of deployment.yaml and add hintsfor for affinity setting in values.yaml

2021-01-26 Thread GitBox
tokers commented on pull request #26: URL: https://github.com/apache/apisix-helm-chart/pull/26#issuecomment-767944599 @TkClark This PR is similar with https://github.com/apache/apisix-helm-chart/pull/20. Also conflicts should be resolved. -

  1   2   3   >