nanamikon edited a comment on issue #3528:
URL: https://github.com/apache/apisix/issues/3528#issuecomment-774942415
Refer to apisix/core/response.lua, resp_exit will be called when response
exits, I think it is a global handle for response exiting, we can't use plugin
extension here。 W
nanamikon edited a comment on issue #3528:
URL: https://github.com/apache/apisix/issues/3528#issuecomment-774942415
Refer to apisix/core/response.lua, resp_exit will be called when response
exit, I think it is a global handle for response exit, we can't use plugin
extension here。 What
nanamikon commented on issue #3528:
URL: https://github.com/apache/apisix/issues/3528#issuecomment-774942415
Refer to apisix/core/response.lua, resp_exit will be called when error
occours, I think it is a global handle for response exit, we can't use plugin
extension here。 What about r
starsz opened a new pull request #1460:
URL: https://github.com/apache/apisix-dashboard/pull/1460
Please answer these questions before submitting a pull request
- Why submit this pull request?
for version 2.4 release
---
wettper edited a comment on pull request #3557:
URL: https://github.com/apache/apisix/pull/3557#issuecomment-774939123
I just changed the document, but CI process is not through, and it shouldn't
matter from the content of the error, how i can retry this process ?
@tokers help~~~
wettper commented on pull request #3557:
URL: https://github.com/apache/apisix/pull/3557#issuecomment-774939123
I just changed the document, but CI process is not through, and it shouldn't
matter from the content of the error, how i can retry this process ?
![image](https://user-ima
tokers commented on a change in pull request #3547:
URL: https://github.com/apache/apisix/pull/3547#discussion_r571822562
##
File path: apisix/cli/ops.lua
##
@@ -238,9 +238,19 @@ Please modify "admin_key" in conf/config.yaml .
util.die("missing apisix.proxy_cache for p
Junnplus commented on pull request #26:
URL: https://github.com/apache/apisix-helm-chart/pull/26#issuecomment-774929178
@TkClark Are you still working for this PR, if not, I will fix
https://github.com/apache/apisix-helm-chart/issues/28.
---
LiteSun opened a new pull request #171:
URL: https://github.com/apache/apisix-website/pull/171
Changes: added cypress blog
Screenshots of the change:
-
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch feat-cypress-blog
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
commit f30ad04193b28f8a16055fc02846611ac3494a7a
Author: litesun <7sunm...@gmail.com>
AuthorDate: Mon Feb 8 15:
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a change to branch feat-cypress-blog
in repository https://gitbox.apache.org/repos/asf/apisix-website.git.
at f30ad04 feat: add cypress blog
This branch includes the following new commits:
new f30ad04
tokers commented on a change in pull request #1436:
URL: https://github.com/apache/apisix-dashboard/pull/1436#discussion_r571819668
##
File path: api/internal/handler/ssl/ssl_test.go
##
@@ -19,146 +19,859 @@ package ssl
import (
"encoding/json"
+ "errors"
+
tokers opened a new pull request #3558:
URL: https://github.com/apache/apisix/pull/3558
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been added?
* [ ] Have you
guoqqqi commented on pull request #1451:
URL: https://github.com/apache/apisix-dashboard/pull/1451#issuecomment-774920448
I agree, it seems that we need to use assertions more often to make the
tests more stable. thanks a lot, that reminds me.
-
liuxiran commented on a change in pull request #1452:
URL: https://github.com/apache/apisix-dashboard/pull/1452#discussion_r571816080
##
File path: api/internal/handler/upstream/upstream_test.go
##
@@ -19,285 +19,1719 @@ package upstream
import (
"encoding/json"
-
liuxiran commented on a change in pull request #1452:
URL: https://github.com/apache/apisix-dashboard/pull/1452#discussion_r571816080
##
File path: api/internal/handler/upstream/upstream_test.go
##
@@ -19,285 +19,1719 @@ package upstream
import (
"encoding/json"
-
codecov-io edited a comment on pull request #1459:
URL: https://github.com/apache/apisix-dashboard/pull/1459#issuecomment-774914921
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1459?src=pr&el=h1)
Report
> Merging
[#1459](https://codecov.io/gh/apache/apisix-dashboard/p
codecov-io edited a comment on pull request #1459:
URL: https://github.com/apache/apisix-dashboard/pull/1459#issuecomment-774914921
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1459?src=pr&el=h1)
Report
> Merging
[#1459](https://codecov.io/gh/apache/apisix-dashboard/p
wettper opened a new pull request #3557:
URL: https://github.com/apache/apisix/pull/3557
Markdown syntax exception
### What this PR does / why we need it:
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features
h
codecov-io commented on pull request #1459:
URL: https://github.com/apache/apisix-dashboard/pull/1459#issuecomment-774914921
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1459?src=pr&el=h1)
Report
> Merging
[#1459](https://codecov.io/gh/apache/apisix-dashboard/pull/145
spacewander commented on pull request #3547:
URL: https://github.com/apache/apisix/pull/3547#issuecomment-774912924
Need to resolve the conflict, so that CI can start.
This is an automated message from the Apache Git Service.
hnlq715 commented on a change in pull request #3547:
URL: https://github.com/apache/apisix/pull/3547#discussion_r571811074
##
File path: conf/config.yaml
##
@@ -31,6 +31,12 @@
#
# If the configured environment variable can't be found, an error will be
thrown.
apisix:
+ nod
tokers commented on pull request #215:
URL:
https://github.com/apache/apisix-ingress-controller/pull/215#issuecomment-774907993
> @lianghao208 I think this PR now can be went ahead.
You can refer to the endpoints controller :).
--
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new fe0edaf chore: optimized the lo
gxthrj merged pull request #240:
URL: https://github.com/apache/apisix-ingress-controller/pull/240
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Junnplus opened a new pull request #1459:
URL: https://github.com/apache/apisix-dashboard/pull/1459
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backpo
nic-chen commented on issue #1456:
URL:
https://github.com/apache/apisix-dashboard/issues/1456#issuecomment-774901048
> Nice idea, @starsz @nic-chen What's your opinion?
great.
@liuyang211 would you like to submit a
PR for this feature? ^_^
---
tokers commented on pull request #215:
URL:
https://github.com/apache/apisix-ingress-controller/pull/215#issuecomment-774894827
@lianghao208 I think this PR now can be went ahead.
This is an automated message from the Apache
tokers commented on pull request #240:
URL:
https://github.com/apache/apisix-ingress-controller/pull/240#issuecomment-774891101
@gxthrj Please take a look when you have time.
This is an automated message from the Apache Git
Jaycean commented on a change in pull request #1452:
URL: https://github.com/apache/apisix-dashboard/pull/1452#discussion_r571795912
##
File path: api/internal/handler/upstream/upstream_test.go
##
@@ -19,285 +19,1719 @@ package upstream
import (
"encoding/json"
-
starsz commented on issue #1456:
URL:
https://github.com/apache/apisix-dashboard/issues/1456#issuecomment-774883757
Pretty good. I think it's a good idea.
PRs are welcomed.
This is an automated message from the Apache Git
imjoey commented on a change in pull request #1452:
URL: https://github.com/apache/apisix-dashboard/pull/1452#discussion_r571786346
##
File path: api/internal/handler/upstream/upstream_test.go
##
@@ -19,285 +19,1719 @@ package upstream
import (
"encoding/json"
-
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 291f617 deploy: f5e28b8449769ac
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new cfdd929 deploy: acc270a31404226
juzhiyuan closed issue #168:
URL: https://github.com/apache/apisix-website/issues/168
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
juzhiyuan merged pull request #169:
URL: https://github.com/apache/apisix-website/pull/169
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new f5e28b8 fix: docs link is broken #16
juzhiyuan merged pull request #170:
URL: https://github.com/apache/apisix-website/pull/170
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new acc270a fix: update docusaurus.confi
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from c5f5739 fix: the git commit hash in the docker is empty string (#1446)
add a87028a feat: fixed sider
LiteSun merged pull request #1457:
URL: https://github.com/apache/apisix-dashboard/pull/1457
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
juzhiyuan opened a new pull request #170:
URL: https://github.com/apache/apisix-website/pull/170
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch juzhiyuan-patch-1
in repository https://gitbox.apache.org/repos/asf/apisix-website.git.
at 85f3bdf Update docusaurus.config.js
This branch includes the following new commits:
new
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch juzhiyuan-patch-1
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
commit 85f3bdf7d959ab62a1923a3b91cd61b8f7f097d3
Author: 琚致远
AuthorDate: Mon Feb 8 12:39:07 2021 +0800
juzhiyuan commented on pull request #1457:
URL: https://github.com/apache/apisix-dashboard/pull/1457#issuecomment-774857544
Good catch!
This is an automated message from the Apache Git Service.
To respond to the message, plea
juzhiyuan commented on issue #1458:
URL:
https://github.com/apache/apisix-dashboard/issues/1458#issuecomment-774857273
Ya
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
juzhiyuan commented on issue #1378:
URL:
https://github.com/apache/apisix-dashboard/issues/1378#issuecomment-774857051
cc @LiteSun to know what to do, then assign to @guoqqqi
This is an automated message from the Apache Git
juzhiyuan commented on a change in pull request #1451:
URL: https://github.com/apache/apisix-dashboard/pull/1451#discussion_r571773387
##
File path: web/cypress/integration/route/create-route-with-upstream.spec.js
##
@@ -46,32 +47,27 @@ context('Create Route with Upstream', ()
codecov-io edited a comment on pull request #247:
URL:
https://github.com/apache/apisix-ingress-controller/pull/247#issuecomment-774661264
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/247?src=pr&el=h1)
Report
> Merging
[#247](https://codecov.io/gh/apache/api
spacewander commented on a change in pull request #3547:
URL: https://github.com/apache/apisix/pull/3547#discussion_r571760883
##
File path: doc/grpc-proxy.md
##
@@ -36,7 +36,8 @@ gRPC client -> APISIX -> gRPC/gRPCS server
Here's an example, to proxying gRPC service by specifi
hnlq715 commented on a change in pull request #3547:
URL: https://github.com/apache/apisix/pull/3547#discussion_r571758279
##
File path: t/core/config-default.t
##
@@ -91,3 +91,53 @@ apisix:
GET /t
--- response_body
admin_key: null
+
+
+
+=== TEST 5: support listen multiple
hnlq715 commented on a change in pull request #3547:
URL: https://github.com/apache/apisix/pull/3547#discussion_r571757891
##
File path: apisix/cli/ops.lua
##
@@ -238,10 +238,18 @@ Please modify "admin_key" in conf/config.yaml .
util.die("missing apisix.proxy_cache for
gxthrj opened a new issue #248:
URL: https://github.com/apache/apisix-ingress-controller/issues/248
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
fukiki closed issue #126:
URL: https://github.com/apache/apisix-docker/issues/126
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
tokers commented on issue #99:
URL:
https://github.com/apache/apisix-ingress-controller/issues/99#issuecomment-774835821
Will add test cases when new features come in.
This is an automated message from the Apache Git Service
tokers closed issue #99:
URL: https://github.com/apache/apisix-ingress-controller/issues/99
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
tokers closed issue #92:
URL: https://github.com/apache/apisix-ingress-controller/issues/92
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
tokers commented on issue #92:
URL:
https://github.com/apache/apisix-ingress-controller/issues/92#issuecomment-774835628
Already added it.
This is an automated message from the Apache Git Service.
To respond to the message,
spacewander commented on pull request #3556:
URL: https://github.com/apache/apisix/pull/3556#issuecomment-774835245
Need to fix the linter.
This is an automated message from the Apache Git Service.
To respond to the message,
spacewander commented on a change in pull request #3556:
URL: https://github.com/apache/apisix/pull/3556#discussion_r571756013
##
File path: apisix/plugins/proxy-rewrite.lua
##
@@ -55,6 +55,11 @@ local schema = {
type= "string",
enum= {"http",
Junnplus opened a new issue #1458:
URL: https://github.com/apache/apisix-dashboard/issues/1458
# Feature request
## Please describe your feature
### friendly menu icon
> local req_body, err = core.request.get_body()
> if not req_body then
> return
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 26a4ed4 refactor: remove kubectl dependenc
spacewander merged pull request #3501:
URL: https://github.com/apache/apisix/pull/3501
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
spacewander commented on a change in pull request #3521:
URL: https://github.com/apache/apisix/pull/3521#discussion_r571748583
##
File path: .github/workflows/build.yml
##
@@ -108,3 +129,10 @@ jobs:
- name: Linux Script
run: sudo ./.travis/${{ matrix.os_name }
spacewander commented on a change in pull request #3521:
URL: https://github.com/apache/apisix/pull/3521#discussion_r571747906
##
File path: .github/workflows/build.yml
##
@@ -53,6 +53,30 @@ jobs:
with:
submodules: recursive
+ - name: Extract branch n
Junnplus opened a new pull request #1457:
URL: https://github.com/apache/apisix-dashboard/pull/1457
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backpo
LiteSun commented on a change in pull request #1444:
URL: https://github.com/apache/apisix-dashboard/pull/1444#discussion_r571743974
##
File path: web/cypress/fixtures/data.json
##
@@ -0,0 +1,31 @@
+{
+ "deletePluginSuccess": "Delete Plugin Successfully",
Review comment:
spacewander commented on a change in pull request #3554:
URL: https://github.com/apache/apisix/pull/3554#discussion_r571735429
##
File path: apisix/plugins/auth-hook.lua
##
@@ -0,0 +1,337 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contribu
spacewander commented on pull request #3554:
URL: https://github.com/apache/apisix/pull/3554#issuecomment-774820329
Need to fix the linter.
This is an automated message from the Apache Git Service.
To respond to the message,
liuxiran commented on a change in pull request #1451:
URL: https://github.com/apache/apisix-dashboard/pull/1451#discussion_r571742709
##
File path: web/cypress/integration/route/create-route-with-upstream.spec.js
##
@@ -46,32 +47,27 @@ context('Create Route with Upstream', () =
liuxiran commented on a change in pull request #1451:
URL: https://github.com/apache/apisix-dashboard/pull/1451#discussion_r571742709
##
File path: web/cypress/integration/route/create-route-with-upstream.spec.js
##
@@ -46,32 +47,27 @@ context('Create Route with Upstream', () =
liuxiran commented on a change in pull request #1451:
URL: https://github.com/apache/apisix-dashboard/pull/1451#discussion_r571742709
##
File path: web/cypress/integration/route/create-route-with-upstream.spec.js
##
@@ -46,32 +47,27 @@ context('Create Route with Upstream', () =
codecov-io edited a comment on pull request #1436:
URL: https://github.com/apache/apisix-dashboard/pull/1436#issuecomment-773958991
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1436?src=pr&el=h1)
Report
> Merging
[#1436](https://codecov.io/gh/apache/apisix-dashboard/p
codecov-io edited a comment on pull request #1436:
URL: https://github.com/apache/apisix-dashboard/pull/1436#issuecomment-773958991
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1436?src=pr&el=h1)
Report
> Merging
[#1436](https://codecov.io/gh/apache/apisix-dashboard/p
codecov-io edited a comment on pull request #1436:
URL: https://github.com/apache/apisix-dashboard/pull/1436#issuecomment-773958991
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1436?src=pr&el=h1)
Report
> Merging
[#1436](https://codecov.io/gh/apache/apisix-dashboard/p
Jaycean commented on a change in pull request #1436:
URL: https://github.com/apache/apisix-dashboard/pull/1436#discussion_r571740505
##
File path: api/internal/handler/ssl/ssl.go
##
@@ -494,3 +504,4 @@ func (h *Handler) Exist(c droplet.Context) (interface{},
error) {
Jaycean commented on a change in pull request #1436:
URL: https://github.com/apache/apisix-dashboard/pull/1436#discussion_r571740473
##
File path: api/internal/handler/ssl/ssl_test.go
##
@@ -19,146 +19,859 @@ package ssl
import (
"encoding/json"
+ "errors"
+
xuyancheng24 removed a comment on issue #3545:
URL: https://github.com/apache/apisix/issues/3545#issuecomment-774631043
/apisix/routes/340306895233352835
{"id":"340306895233352835","create_time":1612368316,"update_time":1612684479,"uris":["/token"],"name":"test","vars":[],"upstream_id":"
Jaycean commented on a change in pull request #1436:
URL: https://github.com/apache/apisix-dashboard/pull/1436#discussion_r571738713
##
File path: api/internal/handler/ssl/ssl_test.go
##
@@ -19,146 +19,859 @@ package ssl
import (
"encoding/json"
+ "errors"
+
nic-chen commented on a change in pull request #1436:
URL: https://github.com/apache/apisix-dashboard/pull/1436#discussion_r571738671
##
File path: api/internal/handler/ssl/ssl_test.go
##
@@ -19,146 +19,859 @@ package ssl
import (
"encoding/json"
+ "errors"
+
imjoey commented on pull request #169:
URL: https://github.com/apache/apisix-website/pull/169#issuecomment-774814093
Hi @KishaniKandasamy , the conflict seems that you did not rebase with
latest code. Please use the latest code and then do any changes. As for now, I
guess you could run `gi
tokers commented on issue #1456:
URL:
https://github.com/apache/apisix-dashboard/issues/1456#issuecomment-774813861
Nice idea, @starsz @nic-chen What's your opinion?
This is an automated message from the Apache Git Service.
tokers commented on a change in pull request #1436:
URL: https://github.com/apache/apisix-dashboard/pull/1436#discussion_r571736462
##
File path: api/internal/handler/ssl/ssl_test.go
##
@@ -19,146 +19,859 @@ package ssl
import (
"encoding/json"
+ "errors"
+
liuxiran commented on a change in pull request #1451:
URL: https://github.com/apache/apisix-dashboard/pull/1451#discussion_r571735970
##
File path: web/cypress/integration/route/create-route-with-upstream.spec.js
##
@@ -46,32 +47,27 @@ context('Create Route with Upstream', () =
Jaycean commented on pull request #1452:
URL: https://github.com/apache/apisix-dashboard/pull/1452#issuecomment-774810574
cc @starsz @nic-chen @imjoey
PTAL. Thks.
This is an automated message from the Apache Git Service
spacewander commented on issue #3552:
URL: https://github.com/apache/apisix/issues/3552#issuecomment-774809665
I write a plugin to check it:
```
function _M.access(conf, ctx)
local req_body, err = core.request.get_body()
if not req_body then
return 503, {messag
liuxiran merged pull request #129:
URL: https://github.com/apache/apisix-docker/pull/129
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
This is an automated email from the ASF dual-hosted git repository.
liuxiran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-docker.git
The following commit(s) were added to refs/heads/master by this push:
new 0db26d4 ci: execute ci about apisix an
juzhiyuan commented on pull request #1451:
URL: https://github.com/apache/apisix-dashboard/pull/1451#issuecomment-774809212
ping @guoqqqi
This is an automated message from the Apache Git Service.
To respond to the message, p
spacewander opened a new pull request #3555:
URL: https://github.com/apache/apisix/pull/3555
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new featu
yashi-hub edited a comment on issue #1311:
URL:
https://github.com/apache/apisix-dashboard/issues/1311#issuecomment-774631093
hello, I'm Yashi Vijay. a sophomore undergraduate, INDIA. I'm a newbie at
open source and would like to work on this task as a part of my outreachy
contributions a
Yiyiyimu commented on a change in pull request #3457:
URL: https://github.com/apache/apisix/pull/3457#discussion_r571630061
##
File path: doc/plugins/prometheus.md
##
@@ -120,6 +120,10 @@ Or you can goto [Grafana
official](https://grafana.com/grafana/dashboards/11719)
### Pre-submission checklist:
- [English](../../plugins/auth-hook.md)
liuyang211 opened a new issue #1456:
URL: https://github.com/apache/apisix-dashboard/issues/1456
# Feature request
## Please describe your feature
apisix has supported etcd prefix to store different clusters' configuration.
Dashboard should also support this.
This is very u
Yiyiyimu closed pull request #3472:
URL: https://github.com/apache/apisix/pull/3472
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
1 - 100 of 183 matches
Mail list logo
