[GitHub] [apisix] tzssangglass commented on issue #3692: [discuss]: enable etcd health check

2021-02-27 Thread GitBox
tzssangglass commented on issue #3692: URL: https://github.com/apache/apisix/issues/3692#issuecomment-787407359 > For this case maybe we can resolve the domain each time before retry? Maybe we can do it, but I think we can also do without. My point is: if you configure the `domain`,

[GitHub] [apisix] guoqqqi commented on a change in pull request #3699: docs: added `sidebar` config

2021-02-27 Thread GitBox
guoqqqi commented on a change in pull request #3699: URL: https://github.com/apache/apisix/pull/3699#discussion_r584237930 ## File path: docs/en/latest/README.md ## @@ -105,4 +105,4 @@ The recommended approach is to deploy APISIX with [AWS CDK](https://aws.amazon.c ### Kube

[GitHub] [apisix] nic-chen opened a new pull request #3701: chore: expose schema of `plugin_config` via control API

2021-02-27 Thread GitBox
nic-chen opened a new pull request #3701: URL: https://github.com/apache/apisix/pull/3701 ### What this PR does / why we need it: expose schema of `plugin_config` via control API, Then, we can use the schema to verify the configuration of `plugin_config` in Dashboard.

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #275: updated technical architecture of apisix-ingress-controller

2021-02-27 Thread GitBox
codecov-io commented on pull request #275: URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-787224463 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=h1) Report > Merging [#275](https://codecov.io/gh/apache/apisix-ing

[GitHub] [apisix-ingress-controller] iamayushdas opened a new pull request #275: updated technical architecture of apisix-ingress-controller

2021-02-27 Thread GitBox
iamayushdas opened a new pull request #275: URL: https://github.com/apache/apisix-ingress-controller/pull/275 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance -

[GitHub] [apisix] nic-chen commented on issue #3674: When multiple plugins are configured in plugin_config, only one takes effect

2021-02-27 Thread GitBox
nic-chen commented on issue #3674: URL: https://github.com/apache/apisix/issues/3674#issuecomment-787222468 @spacewander I rechecked it today and found that it was an incremental synchronization problem, not a problem of multiple plugins. Sorry for misleading. Please take

[GitHub] [apisix] nic-chen opened a new pull request #3700: fix: validate plugins configuration of `plugin_config` via incremental sync

2021-02-27 Thread GitBox
nic-chen opened a new pull request #3700: URL: https://github.com/apache/apisix/pull/3700 ### What this PR does / why we need it: close #3674 Currently, the `item_schema` is not set for `plugin_config`, which causes the plugin configuration to not be validated when

[GitHub] [apisix-website] qier222 commented on pull request #214: fix: additional increase in button size due to #213

2021-02-27 Thread GitBox
qier222 commented on pull request #214: URL: https://github.com/apache/apisix-website/pull/214#issuecomment-787220248 🤔 https://user-images.githubusercontent.com/68148142/109405582-f2d03800-79ac-11eb-9138-34322a70bd31.png";> --

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1504: feat: rewrite e2e test(upstream_chash_query_string_arg_xxx_test) with ginkgo

2021-02-27 Thread GitBox
codecov-io edited a comment on pull request #1504: URL: https://github.com/apache/apisix-dashboard/pull/1504#issuecomment-784716574 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr&el=h1) Report > Merging [#1504](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1504: feat: rewrite e2e test(upstream_chash_query_string_arg_xxx_test) with ginkgo

2021-02-27 Thread GitBox
codecov-io edited a comment on pull request #1504: URL: https://github.com/apache/apisix-dashboard/pull/1504#issuecomment-784716574 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr&el=h1) Report > Merging [#1504](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1504: feat: rewrite e2e test(upstream_chash_query_string_arg_xxx_test) with ginkgo

2021-02-27 Thread GitBox
codecov-io edited a comment on pull request #1504: URL: https://github.com/apache/apisix-dashboard/pull/1504#issuecomment-784716574 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr&el=h1) Report > Merging [#1504](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1504: feat: rewrite e2e test(upstream_chash_query_string_arg_xxx_test) with ginkgo

2021-02-27 Thread GitBox
codecov-io edited a comment on pull request #1504: URL: https://github.com/apache/apisix-dashboard/pull/1504#issuecomment-784716574 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr&el=h1) Report > Merging [#1504](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] juzhiyuan commented on a change in pull request #3699: docs: added `sidebar` config

2021-02-27 Thread GitBox
juzhiyuan commented on a change in pull request #3699: URL: https://github.com/apache/apisix/pull/3699#discussion_r584213964 ## File path: docs/en/latest/README.md ## @@ -105,4 +105,4 @@ The recommended approach is to deploy APISIX with [AWS CDK](https://aws.amazon.c ### Ku

[GitHub] [apisix] moonming commented on issue #3673: request help: A node in the K8S environment ETCD cluster died, causing Apisix to fail

2021-02-27 Thread GitBox
moonming commented on issue #3673: URL: https://github.com/apache/apisix/issues/3673#issuecomment-787205587 v3.lua:593: attempt to index field 'result' (a nil value) is this a bug of apisix? GBXing 于2021年2月28日 周日上午1:53写道: > @Yiyiyimu

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1524: ci: use the specified version of `skywalking`

2021-02-27 Thread GitBox
juzhiyuan merged pull request #1524: URL: https://github.com/apache/apisix-dashboard/pull/1524 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated: ci: use the specified version of `skywalking` (#1524)

2021-02-27 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 93e55ec ci: use the specified vers

[GitHub] [apisix-website] juzhiyuan commented on pull request #214: fix: additional increase in button size due to #213

2021-02-27 Thread GitBox
juzhiyuan commented on pull request #214: URL: https://github.com/apache/apisix-website/pull/214#issuecomment-787151325 cc @qier222 to take a look This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [apisix] juzhiyuan commented on a change in pull request #3699: docs: added `sidebar` config

2021-02-27 Thread GitBox
juzhiyuan commented on a change in pull request #3699: URL: https://github.com/apache/apisix/pull/3699#discussion_r584191920 ## File path: docs/en/latest/config.json ## @@ -1,4 +1,161 @@ { "version": 2.3, - "sidebar": {} + "sidebar": [ +{ + "type": "doc", +

[GitHub] [apisix] GBXing commented on issue #3673: request help: A node in the K8S environment ETCD cluster died, causing Apisix to fail

2021-02-27 Thread GitBox
GBXing commented on issue #3673: URL: https://github.com/apache/apisix/issues/3673#issuecomment-787109936 @Yiyiyimu I may be using it in a wrong way, do I need to add any additional configuration in config.yaml for the health check of etcd? ---

[GitHub] [apisix] GBXing commented on issue #3673: request help: A node in the K8S environment ETCD cluster died, causing Apisix to fail

2021-02-27 Thread GitBox
GBXing commented on issue #3673: URL: https://github.com/apache/apisix/issues/3673#issuecomment-787109703 @tokers service name is etcd,namespace is apisix, other nodes can be accessed normally This is an automated message fr

[GitHub] [apisix] guoqqqi commented on pull request #3699: docs: added `sidebar` config

2021-02-27 Thread GitBox
guoqqqi commented on pull request #3699: URL: https://github.com/apache/apisix/pull/3699#issuecomment-787108798 ![image](https://user-images.githubusercontent.com/72343596/109395265-6e5ac680-7966-11eb-836a-bc5b18930fa5.png) These two documents are not yet available in the Chinese directo

[GitHub] [apisix] guoqqqi opened a new pull request #3699: docs: added `sidebar` config

2021-02-27 Thread GitBox
guoqqqi opened a new pull request #3699: URL: https://github.com/apache/apisix/pull/3699 ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you

[GitHub] [apisix] Yiyiyimu edited a comment on issue #3673: request help: A node in the K8S environment ETCD cluster died, causing Apisix to fail

2021-02-27 Thread GitBox
Yiyiyimu edited a comment on issue #3673: URL: https://github.com/apache/apisix/issues/3673#issuecomment-787094518 Hi @GBXing, I tried to reproduce the problem, and my reproduce steps are: 1. Configure etcd host with domain name: ``` DNS_IP=$(kubectl get svc -n kube-

[GitHub] [apisix-website] 1502shivam-singh opened a new pull request #214: Fix: additional increase in button size due to #213

2021-02-27 Thread GitBox
1502shivam-singh opened a new pull request #214: URL: https://github.com/apache/apisix-website/pull/214 Fixes: fixes increase in button size due to pull request #213 Changes: Removed the padding and margin from global button styles and applied them to local styles of specific

[GitHub] [apisix] Yiyiyimu commented on issue #3673: request help: A node in the K8S environment ETCD cluster died, causing Apisix to fail

2021-02-27 Thread GitBox
Yiyiyimu commented on issue #3673: URL: https://github.com/apache/apisix/issues/3673#issuecomment-787094518 Hi @GBXing, I tried to reproduce the problem, and the result seems a bit different from what you get. My reproduce step is: 1. Configure etcd host with domain name:

[GitHub] [apisix] Yiyiyimu closed pull request #3676: chore: update lua-resty-etcd to v1.4.4

2021-02-27 Thread GitBox
Yiyiyimu closed pull request #3676: URL: https://github.com/apache/apisix/pull/3676 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1524: ci: use the specified version of `skywalking`

2021-02-27 Thread GitBox
nic-chen opened a new pull request #1524: URL: https://github.com/apache/apisix-dashboard/pull/1524 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backpo

[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #213: fix: #212

2021-02-27 Thread GitBox
1502shivam-singh commented on a change in pull request #213: URL: https://github.com/apache/apisix-website/pull/213#discussion_r584141022 ## File path: website/src/css/customTheme.css ## @@ -57,9 +57,22 @@ header h2 { color: var(--color-primary); } +.navbar__title{ + fon

[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #213: fix: #212

2021-02-27 Thread GitBox
1502shivam-singh commented on a change in pull request #213: URL: https://github.com/apache/apisix-website/pull/213#discussion_r584140899 ## File path: website/src/css/customTheme.css ## @@ -260,11 +274,12 @@ header h2 { /* button */ .button { margin: 0 10px; - padding: 8

[GitHub] [apisix-website] qier222 commented on pull request #213: fix: #212

2021-02-27 Thread GitBox
qier222 commented on pull request #213: URL: https://github.com/apache/apisix-website/pull/213#issuecomment-787089090 > Okay, so what exactly did you want here can you tell me ? > > Might as well slide it in my next fixing PR, if you like 😄 @qier222 I expect "Version: Next" dis

[GitHub] [apisix-website] qier222 commented on a change in pull request #213: fix: #212

2021-02-27 Thread GitBox
qier222 commented on a change in pull request #213: URL: https://github.com/apache/apisix-website/pull/213#discussion_r584027096 ## File path: website/src/css/customTheme.css ## @@ -260,11 +274,12 @@ header h2 { /* button */ .button { margin: 0 10px; - padding: 8px 18px;

[GitHub] [apisix] spacewander merged pull request #3686: feat: support SRV record

2021-02-27 Thread GitBox
spacewander merged pull request #3686: URL: https://github.com/apache/apisix/pull/3686 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: feat: support SRV record (#3686)

2021-02-27 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 6731ca1 feat: support SRV record (#3686) 6

[GitHub] [apisix-website] 1502shivam-singh commented on pull request #213: fix: #212

2021-02-27 Thread GitBox
1502shivam-singh commented on pull request #213: URL: https://github.com/apache/apisix-website/pull/213#issuecomment-787083489 Okay, so what exactly did you want here can you tell me ? Might as well slide it in my next fixing PR, if you like 😄 @qier222 -

[GitHub] [apisix-website] qier222 edited a comment on pull request #213: fix: #212

2021-02-27 Thread GitBox
qier222 edited a comment on pull request #213: URL: https://github.com/apache/apisix-website/pull/213#issuecomment-787082551 > Also, is this intentional - for some ahead work ? > > > > ![version_issue](https://user-images.githubusercontent.com/57267960/109390273-a64a1580-7936

[GitHub] [apisix-website] qier222 commented on pull request #213: fix: #212

2021-02-27 Thread GitBox
qier222 commented on pull request #213: URL: https://github.com/apache/apisix-website/pull/213#issuecomment-787082551 > Also, is this intentional - for some ahead work ? > > > > ![version_issue](https://user-images.githubusercontent.com/57267960/109390273-a64a1580-7936-11eb-8

[GitHub] [apisix-website] 1502shivam-singh commented on pull request #213: fix: #212

2021-02-27 Thread GitBox
1502shivam-singh commented on pull request #213: URL: https://github.com/apache/apisix-website/pull/213#issuecomment-787081656 Also, is this intentional - for some ahead work ? ![version_issue](https://user-images.githubusercontent.com/57267960/109390273-a64a1580-7936-11eb-89aa-74ae5

[GitHub] [apisix-website] 1502shivam-singh commented on pull request #213: fix: #212

2021-02-27 Thread GitBox
1502shivam-singh commented on pull request #213: URL: https://github.com/apache/apisix-website/pull/213#issuecomment-787080835 @qier222 This looks fine, just added minimal padding ![test3](https://user-images.githubusercontent.com/57267960/109390114-b1e90c80-7935-11eb-8ad1-17c25997a776.p

[GitHub] [apisix] membphis merged pull request #3651: fix(chash): ensure retry can try every node

2021-02-27 Thread GitBox
membphis merged pull request #3651: URL: https://github.com/apache/apisix/pull/3651 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: fix(chash): ensure retry can try every node (#3651)

2021-02-27 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new e58a55f fix(chash): ensure retry can try ever

[GitHub] [apisix-website] qier222 commented on pull request #213: fix: #212

2021-02-27 Thread GitBox
qier222 commented on pull request #213: URL: https://github.com/apache/apisix-website/pull/213#issuecomment-787079369 The content inside "View on GitHub" button is not horizontally centered. This is an automated message from

[GitHub] [apisix] spacewander closed issue #3697: docs(skywalking): Use the specified version of `skywalking` docker image

2021-02-27 Thread GitBox
spacewander closed issue #3697: URL: https://github.com/apache/apisix/issues/3697 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] spacewander commented on issue #3697: docs(skywalking): Use the specified version of `skywalking` docker image

2021-02-27 Thread GitBox
spacewander commented on issue #3697: URL: https://github.com/apache/apisix/issues/3697#issuecomment-787079184 Consider solved This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] spacewander closed issue #3696: ci failed: should use the `skywalking` with the specified version

2021-02-27 Thread GitBox
spacewander closed issue #3696: URL: https://github.com/apache/apisix/issues/3696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[apisix] branch master updated: ci: use the specified version of `skywalking`. (#3698)

2021-02-27 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new edf838e ci: use the specified version of `

[GitHub] [apisix] spacewander merged pull request #3698: ci: use the specified version of `skywalking`.

2021-02-27 Thread GitBox
spacewander merged pull request #3698: URL: https://github.com/apache/apisix/pull/3698 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated (e2f1fc6 -> 79a4fc6)

2021-02-27 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from e2f1fc6 chore: capitalize the constant (#3672) add 79a4fc6 docs: plugin-develop.md add to view all plugin

[GitHub] [apisix] spacewander merged pull request #3680: docs: plugin-develop.md add to view all plugin priorities

2021-02-27 Thread GitBox
spacewander merged pull request #3680: URL: https://github.com/apache/apisix/pull/3680 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1504: feat: rewrite e2e test(upstream_chash_query_string_arg_xxx_test) with ginkgo

2021-02-27 Thread GitBox
codecov-io edited a comment on pull request #1504: URL: https://github.com/apache/apisix-dashboard/pull/1504#issuecomment-784716574 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr&el=h1) Report > Merging [#1504](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] spacewander commented on issue #3692: [discuss]: enable etcd health check

2021-02-27 Thread GitBox
spacewander commented on issue #3692: URL: https://github.com/apache/apisix/issues/3692#issuecomment-787076622 > using a k8s domain For this case maybe we can resolve the domain each time before retry? This is an autom

[GitHub] [apisix-website] juzhiyuan commented on pull request #213: fix: #212

2021-02-27 Thread GitBox
juzhiyuan commented on pull request #213: URL: https://github.com/apache/apisix-website/pull/213#issuecomment-787075855 ![image](https://user-images.githubusercontent.com/2106987/109389083-c6cd9c00-7945-11eb-891b-43efd486a232.png) Hi, please take a look at other pages, the menu butto

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1522: fix(be): fix ci failed

2021-02-27 Thread GitBox
juzhiyuan merged pull request #1522: URL: https://github.com/apache/apisix-dashboard/pull/1522 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated: fix: fix ci failedx (#1522)

2021-02-27 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new d1a7de0 fix: fix ci failedx (#1522

[GitHub] [apisix] membphis commented on a change in pull request #3698: ci: use the specified version of `skywalking`.

2021-02-27 Thread GitBox
membphis commented on a change in pull request #3698: URL: https://github.com/apache/apisix/pull/3698#discussion_r584123984 ## File path: docs/en/latest/plugins/skywalking.md ## @@ -133,7 +133,7 @@ plugin_attr: 3. Run skywalking server: ```shell -

[apisix-website] branch master updated: fix: #212 (#213)

2021-02-27 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new bc2fa1b fix: #212 (#213) bc2fa1b is

[GitHub] [apisix] membphis commented on a change in pull request #3698: ci: use the specified version of `skywalking`.

2021-02-27 Thread GitBox
membphis commented on a change in pull request #3698: URL: https://github.com/apache/apisix/pull/3698#discussion_r584123835 ## File path: docs/en/latest/plugins/skywalking.md ## @@ -133,7 +133,7 @@ plugin_attr: 3. Run skywalking server: ```shell -

[GitHub] [apisix-website] juzhiyuan closed issue #212: Enhancement: fix visible breakages in website UI on mobile, PNG logo is pixelated and other changes for better UX.

2021-02-27 Thread GitBox
juzhiyuan closed issue #212: URL: https://github.com/apache/apisix-website/issues/212 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [apisix-website] juzhiyuan merged pull request #213: fix: #212

2021-02-27 Thread GitBox
juzhiyuan merged pull request #213: URL: https://github.com/apache/apisix-website/pull/213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #213: fix: #212

2021-02-27 Thread GitBox
juzhiyuan commented on a change in pull request #213: URL: https://github.com/apache/apisix-website/pull/213#discussion_r584123827 ## File path: website/src/css/customTheme.css ## @@ -57,9 +57,22 @@ header h2 { color: var(--color-primary); } +.navbar__title{ + font-size:

[GitHub] [apisix] membphis commented on a change in pull request #3698: ci: use the specified version of `skywalking`.

2021-02-27 Thread GitBox
membphis commented on a change in pull request #3698: URL: https://github.com/apache/apisix/pull/3698#discussion_r584123788 ## File path: docs/en/latest/plugins/skywalking.md ## @@ -133,7 +133,7 @@ plugin_attr: 3. Run skywalking server: ```shell -

[GitHub] [apisix] spacewander commented on a change in pull request #3686: feat: support SRV record

2021-02-27 Thread GitBox
spacewander commented on a change in pull request #3686: URL: https://github.com/apache/apisix/pull/3686#discussion_r584123760 ## File path: docs/en/latest/dns.md ## @@ -74,3 +74,60 @@ If you want to specify the port for the upstream server, you can add it to the ` "type"

[GitHub] [apisix] spacewander commented on a change in pull request #3698: ci: use the specified version of `skywalking`.

2021-02-27 Thread GitBox
spacewander commented on a change in pull request #3698: URL: https://github.com/apache/apisix/pull/3698#discussion_r584123270 ## File path: docs/en/latest/plugins/skywalking.md ## @@ -133,7 +133,7 @@ plugin_attr: 3. Run skywalking server: ```shell -

[GitHub] [apisix] membphis opened a new pull request #3698: ci: use the specified version of `skywalking`.

2021-02-27 Thread GitBox
membphis opened a new pull request #3698: URL: https://github.com/apache/apisix/pull/3698 ### What this PR does / why we need it: fix #3696 ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added?

[GitHub] [apisix] membphis opened a new issue #3697: docs(skywalking): Use the specified version of `skywalking` docker image

2021-02-27 Thread GitBox
membphis opened a new issue #3697: URL: https://github.com/apache/apisix/issues/3697 here is the latest doc of skywalking: https://hub.docker.com/r/apache/skywalking-oap-server This is an automated message from the Apa

[GitHub] [apisix] membphis commented on issue #3696: ci failed: should use the `skywalking` with the specified version

2021-02-27 Thread GitBox
membphis commented on issue #3696: URL: https://github.com/apache/apisix/issues/3696#issuecomment-787070935 the latest doc of skywalking: https://github.com/apache/skywalking-docker/blob/master/oap-server/README.md#start-a-standlone-container-with-h2-storage we can follow thi

[GitHub] [apisix] membphis commented on issue #3696: ci failed: should use the `skywalking` with the specified version

2021-02-27 Thread GitBox
membphis commented on issue #3696: URL: https://github.com/apache/apisix/issues/3696#issuecomment-787070169 Skywalking image list: https://hub.docker.com/r/apache/skywalking-oap-server/tags?page=1&ordering=last_updated --

[GitHub] [apisix] membphis opened a new issue #3696: ci failed: should use the `skywalking` with the specified version

2021-02-27 Thread GitBox
membphis opened a new issue #3696: URL: https://github.com/apache/apisix/issues/3696 "Unable to find image 'apache/skywalking-oap-server:latest' locally docker: Error response from daemon: manifest for apache/skywalking-oap-server:latest not found: manifest unknown: manifest unknown

[GitHub] [apisix] membphis edited a comment on issue #3670: request help:

2021-02-27 Thread GitBox
membphis edited a comment on issue #3670: URL: https://github.com/apache/apisix/issues/3670#issuecomment-787066263 please update your title, make it more meaningful This is an automated message from the Apache Git Service. To

[GitHub] [apisix] membphis commented on issue #3670: request help:

2021-02-27 Thread GitBox
membphis commented on issue #3670: URL: https://github.com/apache/apisix/issues/3670#issuecomment-787066263 please update your title, make a more meaningful This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] membphis merged pull request #3672: chore: capitalize the constant

2021-02-27 Thread GitBox
membphis merged pull request #3672: URL: https://github.com/apache/apisix/pull/3672 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: chore: capitalize the constant (#3672)

2021-02-27 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new e2f1fc6 chore: capitalize the constant (#3672

[GitHub] [apisix] membphis commented on pull request #3494: docs: update the docs of the prometheus plugin

2021-02-27 Thread GitBox
membphis commented on pull request #3494: URL: https://github.com/apache/apisix/pull/3494#issuecomment-787065480 > The Chinese and English documents are written not good that they can’t be merged ok, got it. This is a

[GitHub] [apisix-docker] membphis commented on pull request #141: chore: fix spelling

2021-02-27 Thread GitBox
membphis commented on pull request #141: URL: https://github.com/apache/apisix-docker/pull/141#issuecomment-787064620 many thx This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix-docker] membphis merged pull request #141: chore: fix spelling

2021-02-27 Thread GitBox
membphis merged pull request #141: URL: https://github.com/apache/apisix-docker/pull/141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[apisix-docker] branch master updated: chore: fix spelling (#141)

2021-02-27 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-docker.git The following commit(s) were added to refs/heads/master by this push: new f198360 chore: fix spelling (#141) f19

[GitHub] [apisix-docker] membphis commented on pull request #142: chore: remove unneeded whitespace

2021-02-27 Thread GitBox
membphis commented on pull request #142: URL: https://github.com/apache/apisix-docker/pull/142#issuecomment-787064576 merged, many thx This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix-docker] membphis merged pull request #142: chore: remove unneeded whitespace

2021-02-27 Thread GitBox
membphis merged pull request #142: URL: https://github.com/apache/apisix-docker/pull/142 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[apisix-docker] branch master updated: chore: remove unneeded whitespace (#142)

2021-02-27 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-docker.git The following commit(s) were added to refs/heads/master by this push: new 20e2a6a chore: remove unneeded whitesp

[GitHub] [apisix-helm-chart] membphis merged pull request #35: chore: remove unneeded trailing whitespace

2021-02-27 Thread GitBox
membphis merged pull request #35: URL: https://github.com/apache/apisix-helm-chart/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[apisix-helm-chart] branch master updated: chore: remove unneeded trailing whitespace (#35)

2021-02-27 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 6eed5b1 chore: remove unneeded tra

[GitHub] [apisix-ingress-controller] membphis commented on issue #274: docs: update the architecture diagram

2021-02-27 Thread GitBox
membphis commented on issue #274: URL: https://github.com/apache/apisix-ingress-controller/issues/274#issuecomment-787063605 We can submit a PR to replace the image of `README.md`: ![image](https://user-images.githubusercontent.com/6814606/109386761-e6f65e80-7937-11eb-9a39-546ebe9e

[GitHub] [apisix] membphis commented on a change in pull request #3494: docs: update the docs of the prometheus plugin

2021-02-27 Thread GitBox
membphis commented on a change in pull request #3494: URL: https://github.com/apache/apisix/pull/3494#discussion_r584113634 ## File path: docs/zh/latest/plugins/prometheus.md ## @@ -118,12 +118,49 @@ plugin_attr: ### 可有的指标 -* `Status codes`: upstream 服务返回的 HTTP 状态码,每个服务返回状

[GitHub] [apisix] membphis commented on a change in pull request #3686: feat: support SRV record

2021-02-27 Thread GitBox
membphis commented on a change in pull request #3686: URL: https://github.com/apache/apisix/pull/3686#discussion_r584113078 ## File path: docs/en/latest/dns.md ## @@ -74,3 +74,60 @@ If you want to specify the port for the upstream server, you can add it to the ` "type": "

[GitHub] [apisix] membphis merged pull request #3682: chore: add safe limit to avoid infinite loop caused by bug

2021-02-27 Thread GitBox
membphis merged pull request #3682: URL: https://github.com/apache/apisix/pull/3682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: chore: add safe limit to avoid infinite loop caused by bug (#3682)

2021-02-27 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 3950e4a chore: add safe limit to avoid infini

[GitHub] [apisix] membphis merged pull request #3665: fix: cache server picker for nodes without port

2021-02-27 Thread GitBox
membphis merged pull request #3665: URL: https://github.com/apache/apisix/pull/3665 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated (343d484 -> fa028c1)

2021-02-27 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 343d484 chore: no need to package documentation (#3687) add fa028c1 fix: cache server picker for nodes witho

[GitHub] [apisix] yangxikun opened a new issue #3695: bug: upstream timeout not work

2021-02-27 Thread GitBox
yangxikun opened a new issue #3695: URL: https://github.com/apache/apisix/issues/3695 ### Issue description error log: upstream timeout config is 6s ```text 2021/02/27 11:37:07 [info] 51#51: *2258 [lua] balancer.lua:190: pick_server(): >{"read":6000,"connect":6000,"send

[GitHub] [apisix] KafilatAdeleke commented on pull request #3694: fix Error will be reported when apisix starts , if which is not insta…

2021-02-27 Thread GitBox
KafilatAdeleke commented on pull request #3694: URL: https://github.com/apache/apisix/pull/3694#issuecomment-787055122 fix Error will be reported when apisix starts , if which is not installed. https://github.com/apache/apisix/issues/3611 This is my first PR. Let me know if you have an

[GitHub] [apisix] KafilatAdeleke opened a new pull request #3694: fix Error will be reported when apisix starts , if which is not insta…

2021-02-27 Thread GitBox
KafilatAdeleke opened a new pull request #3694: URL: https://github.com/apache/apisix/pull/3694 …lled ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been adde

[GitHub] [apisix-website] 1502shivam-singh commented on pull request #213: fix: #212

2021-02-27 Thread GitBox
1502shivam-singh commented on pull request #213: URL: https://github.com/apache/apisix-website/pull/213#issuecomment-787053912 This looks good - ![test](https://user-images.githubusercontent.com/57267960/109385192-139a7e00-7918-11eb-863f-036f838e2953.png) --

[GitHub] [apisix-website] 1502shivam-singh commented on pull request #213: fix: #212

2021-02-27 Thread GitBox
1502shivam-singh commented on pull request #213: URL: https://github.com/apache/apisix-website/pull/213#issuecomment-787053319 Also while we are at, did you guys check out the SVG variants I made for the original logo (at [figma](https://www.figma.com/file/LeICU6ikwITGemfw8lBRs3/APISIX-Apa

[GitHub] [apisix-website] 1502shivam-singh commented on pull request #213: fix: #212

2021-02-27 Thread GitBox
1502shivam-singh commented on pull request #213: URL: https://github.com/apache/apisix-website/pull/213#issuecomment-787052781 @qier222 Yes keeping the main head in one single line is a good idea 👍👍, will make changes to heading font size for this. @guoqqqi Well centering the button

[GitHub] [apisix] lilien1010 commented on a change in pull request #3577: feat: support conditional response rewrite

2021-02-27 Thread GitBox
lilien1010 commented on a change in pull request #3577: URL: https://github.com/apache/apisix/pull/3577#discussion_r584095639 ## File path: doc/plugins/response-rewrite.md ## @@ -45,6 +45,7 @@ response rewrite plugin, rewrite the content returned by the upstream as well as |

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1523: fix: the CI error for #1518

2021-02-27 Thread GitBox
codecov-io edited a comment on pull request #1523: URL: https://github.com/apache/apisix-dashboard/pull/1523#issuecomment-787041595 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1523?src=pr&el=h1) Report > Merging [#1523](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1523: fix: the CI error for #1518

2021-02-27 Thread GitBox
codecov-io edited a comment on pull request #1523: URL: https://github.com/apache/apisix-dashboard/pull/1523#issuecomment-787041595 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1523?src=pr&el=h1) Report > Merging [#1523](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1523: fix: the CI error for #1518

2021-02-27 Thread GitBox
codecov-io commented on pull request #1523: URL: https://github.com/apache/apisix-dashboard/pull/1523#issuecomment-787041595 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1523?src=pr&el=h1) Report > Merging [#1523](https://codecov.io/gh/apache/apisix-dashboard/pull/152

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1523: fix: the CI error for #1518

2021-02-27 Thread GitBox
guoqqqi opened a new pull request #1523: URL: https://github.com/apache/apisix-dashboard/pull/1523 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backpor

[GitHub] [apisix-website] guoqqqi commented on pull request #213: fix: #212

2021-02-27 Thread GitBox
guoqqqi commented on pull request #213: URL: https://github.com/apache/apisix-website/pull/213#issuecomment-787033730 LGTM, and how about making the button centered? This is an automated message from the Apache Git Service. T