ShaoZeMing commented on issue #3865:
URL: https://github.com/apache/apisix/issues/3865#issuecomment-802571758
> Your configuration data looks strange. It seems that the field names of
apisix have been modified?
Sorry i didn't understand you too much
--
This is an automated
Chinaxiang commented on issue #3851:
URL: https://github.com/apache/apisix/issues/3851#issuecomment-802568704
> @aiyiyi121
> Please use English in the public channel, thx
@moonming 没必要崇洋，中国人的产品，自信起来。
--
This is an automated message from the Apache Git Service.
To respond to the
codecov-io edited a comment on pull request #1619:
URL: https://github.com/apache/apisix-dashboard/pull/1619#issuecomment-802512861
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1619?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #1617:
URL: https://github.com/apache/apisix-dashboard/pull/1617#issuecomment-802004342
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1617?src=pr=h1)
Report
> Merging
codecov-io commented on pull request #308:
URL:
https://github.com/apache/apisix-ingress-controller/pull/308#issuecomment-802563470
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/308?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #1617:
URL: https://github.com/apache/apisix-dashboard/pull/1617#issuecomment-802004342
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1617?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #1617:
URL: https://github.com/apache/apisix-dashboard/pull/1617#issuecomment-802004342
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1617?src=pr=h1)
Report
> Merging
tokers opened a new pull request #308:
URL: https://github.com/apache/apisix-ingress-controller/pull/308
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ]
iamayushdas commented on issue #3857:
URL: https://github.com/apache/apisix/issues/3857#issuecomment-802558881
Could you elaborate me like in which file i have to make changes or
something like that. Please
--
This is an automated message from the Apache Git Service.
To respond to the
tokers commented on issue #3857:
URL: https://github.com/apache/apisix/issues/3857#issuecomment-802558352
@iamayushdas Sure, assigned to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
aiyiyi121 closed issue #3851:
URL: https://github.com/apache/apisix/issues/3851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
aiyiyi121 commented on issue #3851:
URL: https://github.com/apache/apisix/issues/3851#issuecomment-802543381
> @aiyiyi121
> Please use English in the public channel, thx
OK，thx. I think this issue can be closed.
--
This is an automated message from the Apache Git Service.
To
codecov-io edited a comment on pull request #1576:
URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-795836615
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=h1)
Report
> Merging
Jaycean commented on a change in pull request #1615:
URL: https://github.com/apache/apisix-dashboard/pull/1615#discussion_r597396687
##
File path: api/test/e2e/server_info_delete_test.go
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
stu01509 commented on issue #1616:
URL:
https://github.com/apache/apisix-dashboard/issues/1616#issuecomment-802539418
I would like to fix it, please assign this issue to me :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
codecov-io edited a comment on pull request #1576:
URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-795836615
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #1576:
URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-795836615
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=h1)
Report
> Merging
stu01509 commented on pull request #1617:
URL: https://github.com/apache/apisix-dashboard/pull/1617#issuecomment-802537111
> Hi @stu01509, would you mind pushing codes from the master branch to this
PR? It fixes some test issues.
Done
--
This is an automated message from the
spacewander opened a new pull request #3869:
URL: https://github.com/apache/apisix/pull/3869
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new
spacewander opened a new pull request #3868:
URL: https://github.com/apache/apisix/pull/3868
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new
bisakhmondal commented on a change in pull request #1615:
URL: https://github.com/apache/apisix-dashboard/pull/1615#discussion_r597392430
##
File path: api/test/e2e/server_info_delete_test.go
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nic-chen commented on pull request #152:
URL: https://github.com/apache/apisix-docker/pull/152#issuecomment-802532581
CI failed. @gxthrj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
LiteSun commented on a change in pull request #1612:
URL: https://github.com/apache/apisix-dashboard/pull/1612#discussion_r597389516
##
File path: web/cypress/fixtures/route-json-data.json
##
@@ -0,0 +1,30 @@
+{
+ "debugPostJson": {
+"name": "test_https",
+"status":
nic-chen commented on issue #1616:
URL:
https://github.com/apache/apisix-dashboard/issues/1616#issuecomment-802531862
> How about adding an optional `None` to the `Upstream Setector`?
agree +1
--
This is an automated message from the Apache Git Service.
To respond to the message,
LiteSun commented on a change in pull request #1584:
URL: https://github.com/apache/apisix-dashboard/pull/1584#discussion_r597387315
##
File path: web/cypress/integration/service/save-paginator-status.spec.js
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software
nic-chen commented on issue #1482:
URL:
https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802528995
> Hi, after discuss with @nic-chen @starsz @LiteSun, we have a new way to
support this feature.
>
> How about only adding one extra message that tells users:
nic-chen commented on issue #1136:
URL:
https://github.com/apache/apisix-dashboard/issues/1136#issuecomment-802528616
We have another issue #1500 to track. And we have used ginkgo to rewrite
many e2e test cases in milestone 2.5.
This issue can be closed now.
--
This is an
nic-chen closed issue #1136:
URL: https://github.com/apache/apisix-dashboard/issues/1136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
spacewander closed issue #3855:
URL: https://github.com/apache/apisix/issues/3855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
spacewander commented on issue #3855:
URL: https://github.com/apache/apisix/issues/3855#issuecomment-802527024
Close this issue as we don't need it actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
spacewander commented on issue #1593:
URL: https://github.com/apache/apisix/issues/1593#issuecomment-802526163
How many resources can be put into this project?
Is there any market investigation?
Run a `PluginHub` needs , develop tools for the ecosystem needs
--
This is
iamayushdas commented on issue #3855:
URL: https://github.com/apache/apisix/issues/3855#issuecomment-802525169
yeah got your point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
juzhiyuan commented on issue #1482:
URL:
https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802525066
If we support deleting nodes, it will take some other issues:
1. Where should we put the Delete button on this page?
2. Nodes in ETCD have the TTL option, it
Firstsawyou commented on issue #3865:
URL: https://github.com/apache/apisix/issues/3865#issuecomment-802524955
Your configuration data looks strange. It seems that the field names of
apisix have been modified?
--
This is an automated message from the Apache Git Service.
To respond to
spacewander commented on issue #3855:
URL: https://github.com/apache/apisix/issues/3855#issuecomment-802524313
Note that the website is generated from the markdown.
This is the markdown source:
https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/limit-count.md#attributes
iamayushdas commented on issue #3855:
URL: https://github.com/apache/apisix/issues/3855#issuecomment-802523989
> I don't like to repeat the same words multiple times.
okay my bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
spacewander commented on issue #3855:
URL: https://github.com/apache/apisix/issues/3855#issuecomment-802523388
I don't like to repeat the same words multiple times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
juzhiyuan commented on issue #1593:
URL: https://github.com/apache/apisix/issues/1593#issuecomment-802521487
> So for now, I think spending so much works to develop and maintain a
Plugins Hub will not bring much value.
I just rechecked this issue, the concept `PluginHub` looks good
Firstsawyou opened a new issue #3867:
URL: https://github.com/apache/apisix/issues/3867
# Improve Docs
## Please describe which part of docs should be improved or typo fixed
How to perform regular matching on the uri of the route is a relatively
common problem, we should
codecov-io commented on pull request #1619:
URL: https://github.com/apache/apisix-dashboard/pull/1619#issuecomment-802512861
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1619?src=pr=h1)
Report
> Merging
iamayushdas edited a comment on issue #3855:
URL: https://github.com/apache/apisix/issues/3855#issuecomment-802511090
i think markdown file of limit-count plugin will be more helpful for user
after this: #3866 i guess
@spacewander
--
This is an automated message from the Apache Git
iamayushdas commented on issue #3855:
URL: https://github.com/apache/apisix/issues/3855#issuecomment-802511090
i think markdown file of limit-count plugin will be more helpful for user
after this: #3866 i guess
--
This is an automated message from the Apache Git Service.
To respond to
iamayushdas commented on a change in pull request #3866:
URL: https://github.com/apache/apisix/pull/3866#discussion_r597376468
##
File path: docs/en/latest/plugins/limit-count.md
##
@@ -79,7 +79,17 @@ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H
'X-API-KEY:
iamayushdas commented on a change in pull request #3866:
URL: https://github.com/apache/apisix/pull/3866#discussion_r597375631
##
File path: docs/en/latest/plugins/limit-count.md
##
@@ -79,7 +79,17 @@ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H
'X-API-KEY:
Firstsawyou commented on issue #1616:
URL:
https://github.com/apache/apisix-dashboard/issues/1616#issuecomment-802505986
> How about adding an optional `None` to the `Upstream Setector`?
Yes, I think it is appropriate to add an optional None.
--
This is an automated message from
spacewander edited a comment on issue #3855:
URL: https://github.com/apache/apisix/issues/3855#issuecomment-802503020
@tokers @iamayushdas
The key types are recorded in docs.
See http://apisix.apache.org/docs/apisix/plugins/limit-count
```
["remote_addr", "server_addr",
spacewander commented on issue #3855:
URL: https://github.com/apache/apisix/issues/3855#issuecomment-802503020
@tokers
The key types are recorded in docs.
See http://apisix.apache.org/docs/apisix/plugins/limit-count
```
["remote_addr", "server_addr", "http_x_real_ip",
spacewander commented on a change in pull request #3866:
URL: https://github.com/apache/apisix/pull/3866#discussion_r597372780
##
File path: docs/en/latest/plugins/limit-count.md
##
@@ -79,7 +79,17 @@ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H
'X-API-KEY:
benx203 commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r597369333
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,237 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor
damonchen commented on issue #1593:
URL: https://github.com/apache/apisix/issues/1593#issuecomment-802491900
great!
is it the feature completed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
yongboy commented on a change in pull request #3848:
URL: https://github.com/apache/apisix/pull/3848#discussion_r597365858
##
File path: apisix/discovery/consul_kv.lua
##
@@ -230,6 +241,73 @@ local function update_application(server_name_prefix, data)
end
+local function
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r597362835
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,237 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+--
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from f3a6c2a change: remove deprecated upstream.enable_websocket (#3854)
add 1064e2d docs: update
spacewander merged pull request #3862:
URL: https://github.com/apache/apisix/pull/3862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
iamayushdas opened a new pull request #3866:
URL: https://github.com/apache/apisix/pull/3866
### What this PR does / why we need it:
To make users aware of limit-count key types the can use
#3855
### Pre-submission checklist:
* [x] Did you explain what problem does this
spacewander commented on a change in pull request #3839:
URL: https://github.com/apache/apisix/pull/3839#discussion_r597361954
##
File path: apisix/plugins/cors.lua
##
@@ -133,7 +157,7 @@ local function set_cors_headers(conf, ctx)
end
moonming closed issue #3800:
URL: https://github.com/apache/apisix/issues/3800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
moonming commented on issue #3800:
URL: https://github.com/apache/apisix/issues/3800#issuecomment-802462603
@xuyancheng24
Please use English in the public channel, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
moonming commented on issue #3843:
URL: https://github.com/apache/apisix/issues/3843#issuecomment-802462215
@sailershen
Please use English in the public channel, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
moonming commented on issue #3778:
URL: https://github.com/apache/apisix/issues/3778#issuecomment-802461989
@miaoyb
Please use English in the public channel, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
moonming commented on issue #3851:
URL: https://github.com/apache/apisix/issues/3851#issuecomment-802461657
@aiyiyi121
Please use English in the public channel, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
liuxiran commented on pull request #1619:
URL: https://github.com/apache/apisix-dashboard/pull/1619#issuecomment-802461310
related fe pr: #1612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
moonming commented on issue #3849:
URL: https://github.com/apache/apisix/issues/3849#issuecomment-802461303
@godsoul
Please use English in the public channel, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
iamayushdas commented on issue #3857:
URL: https://github.com/apache/apisix/issues/3857#issuecomment-802458769
can i have more help in this from you. i want to understand and solve this
issue from myself. @tokers
--
This is an automated message from the Apache Git Service.
To
batman-ezio commented on a change in pull request #3839:
URL: https://github.com/apache/apisix/pull/3839#discussion_r597354235
##
File path: t/plugin/cors.t
##
@@ -757,4 +757,132 @@ GET /t
--- response_body eval
qr/failed to check the configuration of plugin cors err: you
batman-ezio commented on a change in pull request #3839:
URL: https://github.com/apache/apisix/pull/3839#discussion_r597353916
##
File path: apisix/plugins/cors.lua
##
@@ -133,7 +157,7 @@ local function set_cors_headers(conf, ctx)
end
juzhiyuan commented on pull request #1617:
URL: https://github.com/apache/apisix-dashboard/pull/1617#issuecomment-802453595
Hi @stu01509, would you mind pushing codes from the master branch to this
PR? It fixes some test issues.
--
This is an automated message from the Apache Git
Jaycean commented on a change in pull request #1615:
URL: https://github.com/apache/apisix-dashboard/pull/1615#discussion_r597352834
##
File path: api/test/e2e/server_info_delete_test.go
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
ShaoZeMing commented on issue #3865:
URL: https://github.com/apache/apisix/issues/3865#issuecomment-802452402
> You should provide more detailed route configuration information.
```
{
"components": {
"securitySchemes": {
"api_key": {
"in": "header",
benx203 commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r597352555
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,237 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor
benx203 commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r597351976
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,237 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor
juzhiyuan commented on pull request #1584:
URL: https://github.com/apache/apisix-dashboard/pull/1584#issuecomment-802450495
@guoqqqi Hi, I see there don't have all test cases for each page, because
they have the same logic, right?
Please try to make a public List component, and for
tokers merged pull request #3854:
URL: https://github.com/apache/apisix/pull/3854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
benx203 commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r597350777
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,237 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 6b3140e docs: fix limit-count typo (#3863)
add f3a6c2a change: remove deprecated upstream.enable_websocket
benx203 commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r597350658
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,237 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor
tokers merged pull request #3863:
URL: https://github.com/apache/apisix/pull/3863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
tokers closed issue #264:
URL: https://github.com/apache/apisix-website/issues/264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 6b3140e docs: fix limit-count typo (#3863)
tokers commented on pull request #307:
URL:
https://github.com/apache/apisix-ingress-controller/pull/307#issuecomment-802445999
@fgksgf The types in `config/v2alpha1` should also be added these tags :).
--
This is an automated message from the Apache Git Service.
To respond to the
tokers closed issue #305:
URL: https://github.com/apache/apisix-ingress-controller/issues/305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
tokers commented on issue #305:
URL:
https://github.com/apache/apisix-ingress-controller/issues/305#issuecomment-802443496
@itfabrik You're welcome, now considering it was solved, I will close this
issue.
--
This is an automated message from the Apache Git Service.
To respond to the
tokers commented on a change in pull request #152:
URL: https://github.com/apache/apisix-docker/pull/152#discussion_r597346508
##
File path: Makefile
##
@@ -20,6 +20,10 @@ APISIX_VERSION ?= 2.4
IMAGE_NAME = apache/apisix
IMAGE_TAR_NAME = apache_apisix
nic-chen commented on issue #1618:
URL:
https://github.com/apache/apisix-dashboard/issues/1618#issuecomment-802440302
thanks for feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
spacewander commented on issue #3861:
URL: https://github.com/apache/apisix/issues/3861#issuecomment-802439993
LGTM.
Only a small thing: we can map the dn to an existed consumer instead of
creating a temporary one.
For example,
Firstsawyou commented on issue #3865:
URL: https://github.com/apache/apisix/issues/3865#issuecomment-802439584
You should provide more detailed route configuration information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
starsz merged pull request #1598:
URL: https://github.com/apache/apisix-dashboard/pull/1598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
This is an automated email from the ASF dual-hosted git repository.
starsz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new f4f27d1 feat: check if the service
Jaycean opened a new pull request #1619:
URL: https://github.com/apache/apisix-dashboard/pull/1619
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ]
Firstsawyou commented on issue #3846:
URL: https://github.com/apache/apisix/issues/3846#issuecomment-802435554
> Hi @Firstsawyou thanks for your response. The message body is signed by
our vendor in order to not only authenticate the message but also show that the
message has not been
stu01509 opened a new issue #1618:
URL: https://github.com/apache/apisix-dashboard/issues/1618
## Issue description
Currently, according to the [Start
developing](https://github.com/apache/apisix-dashboard/blob/master/docs/en/latest/develop.md#start-developing
) doc, in Windows
spacewander commented on a change in pull request #3839:
URL: https://github.com/apache/apisix/pull/3839#discussion_r597339059
##
File path: apisix/plugins/cors.lua
##
@@ -133,7 +157,7 @@ local function set_cors_headers(conf, ctx)
end
spacewander commented on a change in pull request #3848:
URL: https://github.com/apache/apisix/pull/3848#discussion_r597337548
##
File path: apisix/discovery/consul_kv.lua
##
@@ -230,6 +241,73 @@ local function update_application(server_name_prefix, data)
end
+local
liuxiran commented on pull request #1576:
URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-802413581
@imjoey @guoqqqi thanks for review, after update to the latest master
branch, there are some new errors occurred in ci, let me try to fix it.
--
This is an
batman-ezio commented on a change in pull request #3839:
URL: https://github.com/apache/apisix/pull/3839#discussion_r597323673
##
File path: docs/en/latest/plugins/cors.md
##
@@ -43,6 +43,7 @@ title: cors
| expose_headers | string | optional| "*" | | Which
batman-ezio commented on a change in pull request #3839:
URL: https://github.com/apache/apisix/pull/3839#discussion_r597322902
##
File path: apisix/plugins/cors.lua
##
@@ -179,8 +196,56 @@ function _M.header_filter(conf, ctx)
end
end
-ctx.cors_allow_origins
batman-ezio commented on a change in pull request #3839:
URL: https://github.com/apache/apisix/pull/3839#discussion_r597322877
##
File path: apisix/plugins/cors.lua
##
@@ -179,8 +196,56 @@ function _M.header_filter(conf, ctx)
end
end
-ctx.cors_allow_origins
batman-ezio commented on a change in pull request #3839:
URL: https://github.com/apache/apisix/pull/3839#discussion_r597322804
##
File path: apisix/plugins/cors.lua
##
@@ -151,16 +176,8 @@ local function set_cors_headers(conf, ctx)
end
end
-
-function _M.rewrite(conf,
batman-ezio commented on a change in pull request #3839:
URL: https://github.com/apache/apisix/pull/3839#discussion_r597322755
##
File path: apisix/plugins/cors.lua
##
@@ -121,19 +137,28 @@ function _M.check_schema(conf)
return false, "you can not set '*' for
codecov-io edited a comment on pull request #1598:
URL: https://github.com/apache/apisix-dashboard/pull/1598#issuecomment-800084435
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1598?src=pr=h1)
Report
> Merging
1 - 100 of 226 matches
Mail list logo
