[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

2021-03-29 Thread GitBox
benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r603799397 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,324 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1674: feat: improved plugin #1631

2021-03-29 Thread GitBox
iamayushdas commented on pull request #1674: URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-809929827 @liuxiran please review this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1689: docs: update the image in the USER_GUIDE.md #1683

2021-03-29 Thread GitBox
iamayushdas edited a comment on pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#issuecomment-809878785 @nic-chen @Firstsawyou @liuxiran can you check for the failing test? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] Firstsawyou commented on issue #3937: [discuss]: when a node in the etcd cluster fails, no error log is output

2021-03-29 Thread GitBox
Firstsawyou commented on issue #3937: URL: https://github.com/apache/apisix/issues/3937#issuecomment-809922659 > @Firstsawyou > Could you investigate this issue? Ok, let me investigate. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] Firstsawyou commented on issue #3944: request help:

2021-03-29 Thread GitBox
Firstsawyou commented on issue #3944: URL: https://github.com/apache/apisix/issues/3944#issuecomment-809919951 Support cluster deployment. Please refer here: https://github.com/apache/apisix/blob/master/docs/en/latest/FAQ.md#how-to-set-up-high-available-apache-apisix-clusters Using the

[GitHub] [apisix-dashboard] nic-chen commented on issue #1684: program panic when failed to initialize etcd store is unreasonable

2021-03-29 Thread GitBox
nic-chen commented on issue #1684: URL: https://github.com/apache/apisix-dashboard/issues/1684#issuecomment-809918444 thanks for feedback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] spacewander commented on issue #3937: [discuss]: when a node in the etcd cluster fails, no error log is output

2021-03-29 Thread GitBox
spacewander commented on issue #3937: URL: https://github.com/apache/apisix/issues/3937#issuecomment-809916240 > > > > If it reports an error log in 18:26, it doesn't get data from another etcd node at that time. > > @Firstsawyou > > Does the error log happen forever or just

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1673: fix: unable to export route with nil methods field

2021-03-29 Thread GitBox
nic-chen commented on a change in pull request #1673: URL: https://github.com/apache/apisix-dashboard/pull/1673#discussion_r603786353 ## File path: api/internal/handler/data_loader/route_export.go ## @@ -233,7 +235,7 @@ func (h *Handler) RouteToOpenAPI3(c droplet.Context,

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3943: test: make plugin/log-rotate.t stable

2021-03-29 Thread GitBox
Firstsawyou commented on a change in pull request #3943: URL: https://github.com/apache/apisix/pull/3943#discussion_r603784591 ## File path: t/plugin/log-rotate.t ## @@ -90,8 +90,8 @@ __DATA__ --- config location /t { content_by_lua_block { -

[GitHub] [apisix] Firstsawyou commented on pull request #3556: feat: support rewrite HTTP method

2021-03-29 Thread GitBox
Firstsawyou commented on pull request #3556: URL: https://github.com/apache/apisix/pull/3556#issuecomment-809905068 > @Firstsawyou you can add test cases too. Okay, got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] moonming commented on a change in pull request #3494: docs: update the docs of the prometheus plugin

2021-03-29 Thread GitBox
moonming commented on a change in pull request #3494: URL: https://github.com/apache/apisix/pull/3494#discussion_r603773164 ## File path: docs/en/latest/plugins/prometheus.md ## @@ -122,26 +122,70 @@ Or you can goto [Grafana

[GitHub] [apisix] moonming commented on issue #3689: docs: the prometheus.md grammar improve

2021-03-29 Thread GitBox
moonming commented on issue #3689: URL: https://github.com/apache/apisix/issues/3689#issuecomment-809898602 any update? @Firstsawyou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] moonming commented on pull request #3556: feat: support rewrite HTTP method

2021-03-29 Thread GitBox
moonming commented on pull request #3556: URL: https://github.com/apache/apisix/pull/3556#issuecomment-809898365 @Firstsawyou you can add test cases too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] moonming commented on pull request #3556: feat: support rewrite HTTP method

2021-03-29 Thread GitBox
moonming commented on pull request #3556: URL: https://github.com/apache/apisix/pull/3556#issuecomment-809898100 @Firstsawyou please help to fix the confict files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] moonming commented on pull request #3624: feat: add pre-commit framework

2021-03-29 Thread GitBox
moonming commented on pull request #3624: URL: https://github.com/apache/apisix/pull/3624#issuecomment-809897793 any update? @jbampton -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] moonming commented on pull request #3627: docs: add Slack to the communication channels

2021-03-29 Thread GitBox
moonming commented on pull request #3627: URL: https://github.com/apache/apisix/pull/3627#issuecomment-809897586 @jbampton please rebase the master branch, thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] moonming commented on a change in pull request #3871: docs: admin-api.md document adds configuration https example

2021-03-29 Thread GitBox
moonming commented on a change in pull request #3871: URL: https://github.com/apache/apisix/pull/3871#discussion_r603770459 ## File path: docs/zh/latest/admin-api.md ## @@ -665,11 +668,52 @@ HTTP/1.1 200 OK ``` +示例二:如何使用 HTTPS 的 scheme 将请求代理到上游。 Review comment:

[GitHub] [apisix] aiyiyi121 commented on issue #3937: [discuss]: when a node in the etcd cluster fails, no error log is output

2021-03-29 Thread GitBox
aiyiyi121 commented on issue #3937: URL: https://github.com/apache/apisix/issues/3937#issuecomment-809896187 > If it reports an error log in 18:26, it doesn't get data from another etcd node at that time. > @Firstsawyou > Does the error log happen forever or just for a moment?

[GitHub] [apisix] moonming commented on a change in pull request #3883: feat: add 5xx error page

2021-03-29 Thread GitBox
moonming commented on a change in pull request #3883: URL: https://github.com/apache/apisix/pull/3883#discussion_r603767827 ## File path: apisix/error_handler.lua ## @@ -0,0 +1,54 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] moonming commented on a change in pull request #3883: feat: add 5xx error page

2021-03-29 Thread GitBox
moonming commented on a change in pull request #3883: URL: https://github.com/apache/apisix/pull/3883#discussion_r603766958 ## File path: apisix/cli/ngx_tpl.lua ## @@ -233,6 +233,9 @@ http { {% end %} {% end %} +# error_page +error_page 500 502 503 504

[apisix] branch master updated: chore: fix Markdown links in the Spanish README (#3919)

2021-03-29 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 0840d0b chore: fix Markdown links in the

[GitHub] [apisix] moonming merged pull request #3919: chore: fix Markdown links in the Spanish README

2021-03-29 Thread GitBox
moonming merged pull request #3919: URL: https://github.com/apache/apisix/pull/3919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [apisix] spacewander commented on a change in pull request #3910: fix: limit-count plugin connect error

2021-03-29 Thread GitBox
spacewander commented on a change in pull request #3910: URL: https://github.com/apache/apisix/pull/3910#discussion_r603762026 ## File path: docs/en/latest/plugins/limit-count.md ## @@ -48,6 +48,7 @@ Limit request rate by a fixed number of requests in a given time window. |

[GitHub] [apisix] zwjzxh520 opened a new issue #3944: request help:

2021-03-29 Thread GitBox
zwjzxh520 opened a new issue #3944: URL: https://github.com/apache/apisix/issues/3944 ### 支持分布式部署吗?分布式部署的时候,限流插件,可以保证正确的工作吗? 查阅了一下源码,发现是用 resty.lrucache 做的缓存,这应该是本机缓存,那假如部署在三台机器,限流配置为每秒 1000 QPS, 会不会导致实际允许 3000 QPS 的流量了 -- This is an automated message from the Apache Git

[GitHub] [apisix] spacewander commented on a change in pull request #3943: test: make plugin/log-rotate.t stable

2021-03-29 Thread GitBox
spacewander commented on a change in pull request #3943: URL: https://github.com/apache/apisix/pull/3943#discussion_r603758443 ## File path: t/plugin/log-rotate.t ## @@ -90,8 +90,8 @@ __DATA__ --- config location /t { content_by_lua_block { -

[GitHub] [apisix] spacewander commented on a change in pull request #3910: fix: limit-count plugin connect error

2021-03-29 Thread GitBox
spacewander commented on a change in pull request #3910: URL: https://github.com/apache/apisix/pull/3910#discussion_r603758017 ## File path: apisix/plugins/limit-count.lua ## @@ -103,6 +103,9 @@ local schema = { redis_timeout = {

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1661: feat: add scheme field to upstream form

2021-03-29 Thread GitBox
LiteSun commented on a change in pull request #1661: URL: https://github.com/apache/apisix-dashboard/pull/1661#discussion_r603756442 ## File path: web/src/components/Upstream/UpstreamForm.tsx ## @@ -694,6 +694,25 @@ const UpstreamForm: React.FC = forwardRef(

[GitHub] [apisix-website] moonming commented on pull request #276: feat: upgrade APISIX Dashboard version

2021-03-29 Thread GitBox
moonming commented on pull request #276: URL: https://github.com/apache/apisix-website/pull/276#issuecomment-809880384 Where can I see the historically released version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1689: docs: update the image in the USER_GUIDE.md #1683

2021-03-29 Thread GitBox
iamayushdas commented on pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#issuecomment-809878785 @nic-chen @Firstsawyou can you check for the failing test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix-website] LiteSun closed issue #266: support jsDelivr to speedup static files

2021-03-29 Thread GitBox
LiteSun closed issue #266: URL: https://github.com/apache/apisix-website/issues/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[apisix-website] branch master updated: feat: #266 speed up static file (#270)

2021-03-29 Thread sunyi
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 75637c4 feat: #266 speed up static file

[GitHub] [apisix-website] LiteSun merged pull request #270: Feat #266 speed up static file

2021-03-29 Thread GitBox
LiteSun merged pull request #270: URL: https://github.com/apache/apisix-website/pull/270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [apisix-website] LiteSun closed issue #255: Action: check broken links after building

2021-03-29 Thread GitBox
LiteSun closed issue #255: URL: https://github.com/apache/apisix-website/issues/255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [apisix-website] LiteSun merged pull request #263: feat: broken link checker script

2021-03-29 Thread GitBox
LiteSun merged pull request #263: URL: https://github.com/apache/apisix-website/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[apisix-website] branch master updated (1bcaba3 -> 6561b84)

2021-03-29 Thread sunyi
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 1bcaba3 feat: support apisix-docker (#275) add 6561b84 feat: broken link checker script (#263) No new

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1689: docs: update the image in the USER_GUIDE.md #1683

2021-03-29 Thread GitBox
codecov-io commented on pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#issuecomment-809877236 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1689?src=pr=h1) Report > Merging

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3943: test: make plugin/log-rotate.t stable

2021-03-29 Thread GitBox
Firstsawyou commented on a change in pull request #3943: URL: https://github.com/apache/apisix/pull/3943#discussion_r603752965 ## File path: t/plugin/log-rotate.t ## @@ -90,8 +90,8 @@ __DATA__ --- config location /t { content_by_lua_block { -

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #322: bug: route vars configure synchronization data exceptions

2021-03-29 Thread GitBox
gxthrj commented on issue #322: URL: https://github.com/apache/apisix-ingress-controller/issues/322#issuecomment-809865343 Yes, It is a bug cc @tokers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] imxhf commented on pull request #3934: feat: Discovery Nacos

2021-03-29 Thread GitBox
imxhf commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-809864565 > GitHub action is not stable enough. Try to push a new commit again. It works. Thanks, ze xuan~ -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix-ingress-controller] pioneer-hash opened a new issue #322: bug: route vars configure synchronization data exceptions

2021-03-29 Thread GitBox
pioneer-hash opened a new issue #322: URL: https://github.com/apache/apisix-ingress-controller/issues/322 ### Issue description When I configured two rules in route.yaml, one carried the rules and the other did not ,Routes with rules are placed on top and routes without rules are

[GitHub] [apisix-dashboard] defp removed a comment on issue #1397: feat: Customize the configurations of Semantic-Pull-Request check in CI

2021-03-29 Thread GitBox
defp removed a comment on issue #1397: URL: https://github.com/apache/apisix-dashboard/issues/1397#issuecomment-809858236 https://github.com/apache/apisix-dashboard/pull/1688/commits/44fa580af59b648957657e56ea3a153aef70daa8 backport type -- This is an automated message from the

[GitHub] [apisix-dashboard] defp commented on issue #1397: feat: Customize the configurations of Semantic-Pull-Request check in CI

2021-03-29 Thread GitBox
defp commented on issue #1397: URL: https://github.com/apache/apisix-dashboard/issues/1397#issuecomment-809858236 https://github.com/apache/apisix-dashboard/pull/1688/commits/44fa580af59b648957657e56ea3a153aef70daa8 backport type -- This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1689: Docs

2021-03-29 Thread GitBox
iamayushdas opened a new pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [X] New feature provided

[GitHub] [apisix-dashboard] defp commented on issue #1397: feat: Customize the configurations of Semantic-Pull-Request check in CI

2021-03-29 Thread GitBox
defp commented on issue #1397: URL: https://github.com/apache/apisix-dashboard/issues/1397#issuecomment-809857396 > Add support for custom types https://github.com/zeke/semantic-pull-requests/pull/67 @nic-chen Yes! -- This is an automated message from the Apache Git Service.

[GitHub] [apisix-helm-chart] wgy-home commented on issue #49: apisix error:failed to fetch data from etcd: xxxx could not be resolved

2021-03-29 Thread GitBox
wgy-home commented on issue #49: URL: https://github.com/apache/apisix-helm-chart/issues/49#issuecomment-809854657 > It seems APISIX doens't use the resolver in `/etc/resolv.conf`. Could you please paste the nginx.conf in your APISIX container? This configuration file ? ```shell

[GitHub] [apisix] spacewander edited a comment on issue #3942: request help: How to proxy to a third-party website by developing a plug-in?

2021-03-29 Thread GitBox
spacewander edited a comment on issue #3942: URL: https://github.com/apache/apisix/issues/3942#issuecomment-809851447 See https://github.com/apache/apisix/blob/master/docs/en/latest/admin-api.md#upstream. You need to use the domain name as the `nodes`. For example, ``` {

[GitHub] [apisix] spacewander edited a comment on issue #3942: request help: How to proxy to a third-party website by developing a plug-in?

2021-03-29 Thread GitBox
spacewander edited a comment on issue #3942: URL: https://github.com/apache/apisix/issues/3942#issuecomment-809851447 See https://github.com/apache/apisix/blob/master/docs/en/latest/admin-api.md#upstream. You need to use the domain name as the `nodes`. For example, ``` {

[GitHub] [apisix] spacewander edited a comment on issue #3942: request help: How to proxy to a third-party website by developing a plug-in?

2021-03-29 Thread GitBox
spacewander edited a comment on issue #3942: URL: https://github.com/apache/apisix/issues/3942#issuecomment-809851447 See https://github.com/apache/apisix/blob/master/docs/en/latest/admin-api.md#upstream. You need to use the domain name as the `nodes`. For example, ``` {

[GitHub] [apisix] hackeryutu closed issue #3935: request help: Specify an upstream and remove it from all routes

2021-03-29 Thread GitBox
hackeryutu closed issue #3935: URL: https://github.com/apache/apisix/issues/3935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [apisix] spacewander closed issue #3942: request help: How to proxy to a third-party website by developing a plug-in?

2021-03-29 Thread GitBox
spacewander closed issue #3942: URL: https://github.com/apache/apisix/issues/3942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [apisix] spacewander commented on issue #3942: request help: How to proxy to a third-party website by developing a plug-in?

2021-03-29 Thread GitBox
spacewander commented on issue #3942: URL: https://github.com/apache/apisix/issues/3942#issuecomment-809851447 See https://github.com/apache/apisix/blob/master/docs/en/latest/admin-api.md#upstream. You need to use the domain name as the `nodes`. -- This is an automated message from the

[GitHub] [apisix] spacewander commented on pull request #3934: feat: Discovery Nacos

2021-03-29 Thread GitBox
spacewander commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-809850957 GitHub action is not stable enough. Try to push a new commit again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] spacewander edited a comment on issue #3937: [discuss]: when a node in the etcd cluster fails, no error log is output

2021-03-29 Thread GitBox
spacewander edited a comment on issue #3937: URL: https://github.com/apache/apisix/issues/3937#issuecomment-809849343 If it reports an error log in 18:26, it doesn't get data from another etcd node at that time. @Firstsawyou Does the error log happen forever or just for a moment?

[GitHub] [apisix] spacewander commented on issue #3937: [discuss]: when a node in the etcd cluster fails, no error log is output

2021-03-29 Thread GitBox
spacewander commented on issue #3937: URL: https://github.com/apache/apisix/issues/3937#issuecomment-809849343 If it reports an error log in 18:26, it doesn't get data from another etcd node. @Firstsawyou Does the error log happen forever or just for a moment? -- This is an

[GitHub] [apisix] imxhf commented on pull request #3934: feat: Discovery Nacos

2021-03-29 Thread GitBox
imxhf commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-809848507 @spacewander @membphis Execuse me, why the checks stopped here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] moonming commented on issue #3942: request help: How to proxy to a third-party website by developing a plug-in?

2021-03-29 Thread GitBox
moonming commented on issue #3942: URL: https://github.com/apache/apisix/issues/3942#issuecomment-809848493 @kongjun01 Please use English in the public channel, thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix] moonming commented on issue #3937: [discuss]: when a node in the etcd cluster fails, no error log is output

2021-03-29 Thread GitBox
moonming commented on issue #3937: URL: https://github.com/apache/apisix/issues/3937#issuecomment-809848286 @Yiyiyimu @spacewander if we can get data from other etcd node, do we need print `ERR` level logs? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] spacewander opened a new pull request #3943: test: make plugin/log-rotate.t stable

2021-03-29 Thread GitBox
spacewander opened a new pull request #3943: URL: https://github.com/apache/apisix/pull/3943 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new

[GitHub] [apisix] kongjun01 opened a new issue #3942: request help: 如何通过开发插件代理到第三方的网站?

2021-03-29 Thread GitBox
kongjun01 opened a new issue #3942: URL: https://github.com/apache/apisix/issues/3942 ### Issue description 如题。 效果和下面类似的(用户访问 http://ip:port,则反向代理到 https://github.com): location / { proxy_pass https://github.com; proxy_redirect off;

[GitHub] [apisix] spacewander merged pull request #3925: feat(skywalking): allow destory and configure report interval for rep…

2021-03-29 Thread GitBox
spacewander merged pull request #3925: URL: https://github.com/apache/apisix/pull/3925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [apisix] spacewander closed issue #2895: Can't disable skywalking plugin on the fly

2021-03-29 Thread GitBox
spacewander closed issue #2895: URL: https://github.com/apache/apisix/issues/2895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[apisix] branch master updated: feat(skywalking): allow destory and configure report interval for reporter (#3925)

2021-03-29 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 7c976b5 feat(skywalking): allow destory

[GitHub] [apisix] kongjun01 closed issue #3783: request help: SSL: error:1408F10B:SSL routines:ssl3_get_record:wrong version number

2021-03-29 Thread GitBox
kongjun01 closed issue #3783: URL: https://github.com/apache/apisix/issues/3783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [apisix] kongjun01 commented on issue #3783: request help: SSL: error:1408F10B:SSL routines:ssl3_get_record:wrong version number

2021-03-29 Thread GitBox
kongjun01 commented on issue #3783: URL: https://github.com/apache/apisix/issues/3783#issuecomment-809844807 问题解决了,强制跳转https用的是重定向,不是重写 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-dashboard] Jaycean commented on issue #1687: request help: What’s the function of export OpenAPI on the dashboard

2021-03-29 Thread GitBox
Jaycean commented on issue #1687: URL: https://github.com/apache/apisix-dashboard/issues/1687#issuecomment-809844608 > > please give some detail about how to reproduce it, thanks. > > Just use the function "导出 OpenAPI" on the dashboard, and it exports data like: > > ``` >

[GitHub] [apisix] juzhiyuan opened a new pull request #3941: docs: improve Getting Started

2021-03-29 Thread GitBox
juzhiyuan opened a new pull request #3941: URL: https://github.com/apache/apisix/pull/3941 ### What this PR does / why we need it: Improve getting started contents to have a more clear & better Read experience. ### Pre-submission checklist: * [x] Did you explain what

[apisix] 01/01: docs: improve Getting Started

2021-03-29 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch docs-admin-api in repository https://gitbox.apache.org/repos/asf/apisix.git commit f56fcbc2af78f4c89787626637ecc97c11c0cd6f Author: juzhiyuan AuthorDate: Tue Mar 30 09:42:13 2021 +0800

[apisix] branch docs-admin-api created (now f56fcbc)

2021-03-29 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-admin-api in repository https://gitbox.apache.org/repos/asf/apisix.git. at f56fcbc docs: improve Getting Started This branch includes the following new commits: new f56fcbc

[GitHub] [apisix] spacewander commented on a change in pull request #3820: feat: add nacos support

2021-03-29 Thread GitBox
spacewander commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r603719667 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,324 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix-dashboard] aiyiyi121 commented on issue #1687: request help: What’s the function of export OpenAPI on the dashboard

2021-03-29 Thread GitBox
aiyiyi121 commented on issue #1687: URL: https://github.com/apache/apisix-dashboard/issues/1687#issuecomment-809840009 > please give some detail about how to reproduce it, thanks. Just use the function "导出 OpenAPI" on the dashboard, and it exports data like: ```components:

[GitHub] [apisix] spacewander commented on pull request #3820: feat: add nacos support

2021-03-29 Thread GitBox
spacewander commented on pull request #3820: URL: https://github.com/apache/apisix/pull/3820#issuecomment-809838710 Please merge master to resolve conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] spacewander commented on a change in pull request #3820: feat: add nacos support

2021-03-29 Thread GitBox
spacewander commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r603719667 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,324 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] spacewander commented on issue #3923: request help: timer enhancement

2021-03-29 Thread GitBox
spacewander commented on issue #3923: URL: https://github.com/apache/apisix/issues/3923#issuecomment-809837517 Yes, you are right. We can add an option to override this behavior and use it in the background timer. PR is welcome! -- This is an automated message from the Apache Git

[GitHub] [apisix] Firstsawyou commented on issue #3935: request help: Specify an upstream and remove it from all routes

2021-03-29 Thread GitBox
Firstsawyou commented on issue #3935: URL: https://github.com/apache/apisix/issues/3935#issuecomment-809835712 Hi, @hackeryutu According to the current description, we do not know what your problem is, you need to describe your problem clearly. -- This is an automated message from

[GitHub] [apisix] spacewander commented on issue #3937: [discuss]: when a node in the etcd cluster fails, no error log is output

2021-03-29 Thread GitBox
spacewander commented on issue #3937: URL: https://github.com/apache/apisix/issues/3937#issuecomment-809834044 The error log is right. If it reports the connection is refused, that means it fails to get any data from etcd at that moment. -- This is an automated message from the Apache

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1685: docs: tells users where they are

2021-03-29 Thread GitBox
codecov-io edited a comment on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-808845894 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1685?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1685: docs: tells users where they are

2021-03-29 Thread GitBox
codecov-io edited a comment on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-808845894 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1685?src=pr=h1) Report > Merging

[GitHub] [apisix] spacewander commented on a change in pull request #3910: fix: limit-count plugin connect error

2021-03-29 Thread GitBox
spacewander commented on a change in pull request #3910: URL: https://github.com/apache/apisix/pull/3910#discussion_r603714643 ## File path: apisix/plugins/limit-count.lua ## @@ -103,6 +103,9 @@ local schema = { redis_timeout = {

[GitHub] [apisix] spacewander commented on a change in pull request #3910: fix: limit-count plugin connect error

2021-03-29 Thread GitBox
spacewander commented on a change in pull request #3910: URL: https://github.com/apache/apisix/pull/3910#discussion_r603714643 ## File path: apisix/plugins/limit-count.lua ## @@ -103,6 +103,9 @@ local schema = { redis_timeout = {

[GitHub] [apisix-dashboard] nic-chen edited a comment on issue #1687: request help: What’s the function of export OpenAPI on the dashboard

2021-03-29 Thread GitBox
nic-chen edited a comment on issue #1687: URL: https://github.com/apache/apisix-dashboard/issues/1687#issuecomment-809830647 please give some detail about how to reproduce it, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix-dashboard] nic-chen commented on issue #1687: request help: What’s the function of export OpenAPI on the dashboard

2021-03-29 Thread GitBox
nic-chen commented on issue #1687: URL: https://github.com/apache/apisix-dashboard/issues/1687#issuecomment-809830647 please give some detail about how to reproduce it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-dashboard] nic-chen commented on issue #1397: feat: Customize the configurations of Semantic-Pull-Request check in CI

2021-03-29 Thread GitBox
nic-chen commented on issue #1397: URL: https://github.com/apache/apisix-dashboard/issues/1397#issuecomment-809830132 > > By default types specified in commitizen/conventional-commit-types is used. > > > See:

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1685: docs: tells users where they are

2021-03-29 Thread GitBox
codecov-io edited a comment on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-808845894 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1685?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1673: fix: unable to export route with nil methods field

2021-03-29 Thread GitBox
Jaycean commented on a change in pull request #1673: URL: https://github.com/apache/apisix-dashboard/pull/1673#discussion_r603712340 ## File path: api/internal/handler/data_loader/route_export.go ## @@ -233,7 +235,7 @@ func (h *Handler) RouteToOpenAPI3(c droplet.Context,

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1685: docs: tells users where they are

2021-03-29 Thread GitBox
iamayushdas commented on a change in pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#discussion_r603709604 ## File path: web/src/pages/Service/Create.tsx ## @@ -116,7 +116,7 @@ const Page: React.FC = (props) => { <>

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1673: fix: unable to export route with nil methods field

2021-03-29 Thread GitBox
nic-chen commented on a change in pull request #1673: URL: https://github.com/apache/apisix-dashboard/pull/1673#discussion_r603707627 ## File path: api/internal/handler/data_loader/route_export.go ## @@ -233,7 +235,7 @@ func (h *Handler) RouteToOpenAPI3(c droplet.Context,

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1667: feat: run manager-api as a systemd daemon/service

2021-03-29 Thread GitBox
nic-chen commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-809821928 > > @bisakhmondal > > > I think we could use a library to automate, instead of writing a configuration for each platform. What do you think? > > >

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1685: docs: tells users where they are

2021-03-29 Thread GitBox
nic-chen commented on a change in pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#discussion_r603704429 ## File path: web/src/pages/Service/Create.tsx ## @@ -116,7 +116,7 @@ const Page: React.FC = (props) => { <> Do we have

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1685: docs: tells users where they are

2021-03-29 Thread GitBox
juzhiyuan commented on a change in pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#discussion_r603694459 ## File path: web/src/locales/zh-CN/component.ts ## @@ -21,19 +21,24 @@ export default { 'component.global.search': '查询',

[GitHub] [apisix] defp opened a new pull request #3940: docs: ret_code type in plugin redirect should be integer (#3932)

2021-03-29 Thread GitBox
defp opened a new pull request #3940: URL: https://github.com/apache/apisix/pull/3940 ### What this PR does / why we need it: fix https://github.com/apache/apisix/issues/3932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1685: docs: tells users where they are

2021-03-29 Thread GitBox
codecov-io edited a comment on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-808845894 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1685?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are

2021-03-29 Thread GitBox
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809525124 @juzhiyuan have a check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are

2021-03-29 Thread GitBox
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809505279 Okay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[apisix-dashboard] tag v2.5 created (now 5c95d97)

2021-03-29 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to tag v2.5 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at 5c95d97 (commit) No new revisions were added by this update.

[GitHub] [apisix-website] nic-chen opened a new pull request #276: feat: upgrade APISIX Dashboard version

2021-03-29 Thread GitBox
nic-chen opened a new pull request #276: URL: https://github.com/apache/apisix-website/pull/276 Changes: upgrade APISIX Dashboard version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-website] branch dashboard-2.5 created (now 842d706)

2021-03-29 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch dashboard-2.5 in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at 842d706 feat: upgrade APISIX Dashboard version This branch includes the following new commits:

[apisix-website] 01/01: feat: upgrade APISIX Dashboard version

2021-03-29 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a commit to branch dashboard-2.5 in repository https://gitbox.apache.org/repos/asf/apisix-website.git commit 842d7066090ec8438d964b0fb5625384638f8653 Author: nic-chen AuthorDate: Mon Mar 29 23:48:47 2021 +0800

[GitHub] [apisix] membphis commented on pull request #3883: feat: add 5xx error page

2021-03-29 Thread GitBox
membphis commented on pull request #3883: URL: https://github.com/apache/apisix/pull/3883#issuecomment-809485058 ci failed now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[apisix] branch master updated (86e168e -> 0c96ffd)

2021-03-29 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 86e168e test: enable master-worker mode by default (#3927) add 0c96ffd test: make consul_kv stable (#3924)

[GitHub] [apisix] membphis merged pull request #3924: test: make consul_kv stable

2021-03-29 Thread GitBox
membphis merged pull request #3924: URL: https://github.com/apache/apisix/pull/3924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

  1   2   >