tokers opened a new pull request #398:
URL: https://github.com/apache/apisix-ingress-controller/pull/398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
Firstsawyou commented on issue #4094:
URL: https://github.com/apache/apisix/issues/4094#issuecomment-823821197
The configuration of etcd client certificate is not supported in APISIX 2.3.
It is only supported in APISIX 2.5 This is the configuration information of
etcd in 2.5
https:
totemofwolf opened a new issue #4095:
URL: https://github.com/apache/apisix/issues/4095
### Issue description
### Environment
* apisix version (cmd: `apisix version`): APISIX/2.5
* OS (cmd: `uname -a`): 2.5-alpine
* OpenResty / Nginx version (cmd: `nginx -V` or `openresty
Firstsawyou commented on issue #4094:
URL: https://github.com/apache/apisix/issues/4094#issuecomment-823805907
In the APISIX configuration file, there is a default `etcd. tls.verify` as
true. Is this okay?
https://github.com/apache/apisix/blob/964a92ee773264999eb67d0cd5539baf8961001
bisakhmondal commented on pull request #1756:
URL: https://github.com/apache/apisix-dashboard/pull/1756#issuecomment-823800940
Any thoughts here ππ€‘? @nic-chen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
ericsyh commented on issue #1803:
URL:
https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823798761
ok for close the issue. But i am quite interesting in what scenario that
users will create a upstream with empty node list?
--
This is an automated message from the Apach
KishaniKandasamy commented on pull request #1807:
URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823797345
> hi @KishaniKandasamy
> I am updating api doc and that will be a big update.
> I think we don't need to update this file now.
Okay:)
--
This is
liuxiran commented on issue #1803:
URL:
https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823786050
@juzhiyuan @nic-chen keep the current behavior is also reasonable for me
If there is no objection, we will close the issue
cc @ericsyh
--
This is
Firstsawyou commented on issue #1796:
URL:
https://github.com/apache/apisix-dashboard/issues/1796#issuecomment-823784682
You can also try to configure it like this in Dashboard:
https://user-images.githubusercontent.com/52862365/115500683-62272180-a2a4-11eb-96d7-d5789b7e7e46.png";>
codecov-commenter edited a comment on pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=
bisakhmondal commented on pull request #1788:
URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-823779141
> hi @bisakhmondal
> I think we should also embed `dag-to-lua`, see:
> https://github.com/apache/apisix-dashboard/blob/master/api/build.sh#L38-L42
Okay.
hzbd closed issue #1811:
URL: https://github.com/apache/apisix-dashboard/issues/1811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
codecov-commenter edited a comment on pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=
codecov-commenter edited a comment on pull request #1705:
URL: https://github.com/apache/apisix-dashboard/pull/1705#issuecomment-821808163
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=
codecov-commenter edited a comment on pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=
codecov-commenter edited a comment on pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=
nic-chen commented on issue #1810:
URL:
https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-823775689
I We can directly try to see the modified effect.
cc @LiteSun @juzhiyuan @liuxiran @guoqqqi
--
This is an automated message from the Apache Git Service.
To resp
netlify[bot] edited a comment on pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822179614
Deploy preview for *apisix-dashboard* processing.
Building with commit 27876cf77506f9a89ea97a5e66ff8b7323c9bc6f
https://app.netlify.com/sites/a
nic-chen commented on issue #1796:
URL:
https://github.com/apache/apisix-dashboard/issues/1796#issuecomment-823774884
> My back-end service is http://localhost:8080/api/user/get, I want to add
/foo[/api/user/get] via apisix
I think you could use the proxy-rewrite plugin to achieve y
bisakhmondal commented on a change in pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r617198607
##
File path: api/manager-api.service
##
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contribut
bisakhmondal commented on a change in pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r617198292
##
File path: api/manager-api.service
##
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review comm
nic-chen commented on issue #1811:
URL:
https://github.com/apache/apisix-dashboard/issues/1811#issuecomment-823774139
hi @hzbd
can't use Dashboard 2.5 with APISIX 2.5, need to wait for Dashboard 2.6.
Dashboard 2.5 works with APISIX 2.4.
--
This is an automated message fro
nic-chen commented on pull request #1807:
URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823771931
hi @KishaniKandasamy
I am updating api doc and that will be a big update.
I think we don't need to update this file now.
--
This is an automated message
StretchV opened a new issue #4094:
URL: https://github.com/apache/apisix/issues/4094
### Issue description
### Environment
* apisix version (cmd: `apisix version`):2.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
netlify[bot] edited a comment on pull request #1705:
URL: https://github.com/apache/apisix-dashboard/pull/1705#issuecomment-818713534
Deploy preview for *apisix-dashboard* processing.
Building with commit 8c21565a846016227d47ca8280cfc911d581fe3b
https://app.netlify.com/sites/a
nic-chen commented on pull request #1788:
URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-823769178
hi @bisakhmondal
I think we should also embed `dag-to-lua`, see:
https://github.com/apache/apisix-dashboard/blob/master/api/build.sh#L38-L42
--
This is an auto
nic-chen commented on issue #1803:
URL:
https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823768235
+1 for keeping the current behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
nic-chen commented on a change in pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r617191937
##
File path: api/manager-api.service
##
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review comment:
Firstsawyou commented on pull request #4092:
URL: https://github.com/apache/apisix/pull/4092#issuecomment-823762795
Related issues: https://github.com/apache/apisix/issues/4090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
hzbd opened a new issue #1811:
URL: https://github.com/apache/apisix-dashboard/issues/1811
**Issue description**
_Request Error Code: 201
The manager-api and apache apisix are mismatched._
 under one or more
+# contributor l
membphis commented on a change in pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r617175576
##
File path: api/manager-api.service
##
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor l
leon1509 edited a comment on issue #1796:
URL:
https://github.com/apache/apisix-dashboard/issues/1796#issuecomment-823750668
My back-end service is http://localhost:8080/api/user/get, I want to add
/foo[/api/user/get] via apisix
--
This is an automated message from the Apache Git Servic
leon1509 commented on issue #1796:
URL:
https://github.com/apache/apisix-dashboard/issues/1796#issuecomment-823750668
My back-end service is http://localhost:8080/api/user/get, I want to add
/api/user/get via apisix
--
This is an automated message from the Apache Git Service.
To respond
nic-chen commented on pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-823750638
@tokers @starsz please have a look again when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
membphis opened a new issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810
--
This is an automated message from the Apache Git Service.
To re
gxthrj commented on pull request #159:
URL: https://github.com/apache/apisix-docker/pull/159#issuecomment-823746325
I submitted an INFRA to discuss this matter. If Apache does not allow this,
we will roll back this PR, and if allowed, we will continue to apply for
secrets.
INFRA: ht
Firstsawyou commented on issue #4091:
URL: https://github.com/apache/apisix/issues/4091#issuecomment-823733774
Assigned to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
tokers commented on pull request #385:
URL:
https://github.com/apache/apisix-ingress-controller/pull/385#issuecomment-823722031
@vincenthcui Ping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
tokers merged pull request #393:
URL: https://github.com/apache/apisix-ingress-controller/pull/393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new cc67f0f test: add api-breake
tokers merged pull request #388:
URL: https://github.com/apache/apisix-ingress-controller/pull/388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 783ba62 test: add e2e test c
wjx8382 commented on issue #356:
URL:
https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-823721227
> > > From the configuration snippet the `allow_admin` was rendered
correctly, so it should work, would you like to try the `0.5.0` version, it was
released few days
gxthrj commented on pull request #159:
URL: https://github.com/apache/apisix-docker/pull/159#issuecomment-823713945
Yes, the secret needed. I will try to set the secrets through infra of
Apache.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-control-plane.git
The following commit(s) were added to refs/heads/master by this push:
new 0183669 chore: fix go code styles (#
gxthrj merged pull request #41:
URL: https://github.com/apache/apisix-control-plane/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
gxthrj commented on pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#issuecomment-823710143
related to : #394 #395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Firstsawyou commented on issue #4090:
URL: https://github.com/apache/apisix/issues/4090#issuecomment-823709437
You can try the traffic-split plug-in. Here is an example of configuration:
```shell
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87a
gxthrj commented on issue #42:
URL:
https://github.com/apache/apisix-control-plane/issues/42#issuecomment-823709420
@kasini3000 Sorry for the late reply. According to the stated configuration,
calling APISIX `admin-api` is already supported, but the command line function
still needs to be
spacewander edited a comment on issue #4090:
URL: https://github.com/apache/apisix/issues/4090#issuecomment-823701104
~~You can write your own plugin like traffic-split.~~
Look like the `rules` in traffic-split is an array, so you can use it with
multiple upstream but not just for 2.
starsz commented on pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-823705817
> > how about ./manager-api start and ./manager-api stop,
> > when run ./manager-api start and the service is not installed, install
it ?
>
> Okay then, I will
gxthrj commented on a change in pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r617134653
##
File path: pkg/ingress/apisix_upstream.go
##
@@ -122,6 +133,8 @@ func (c *apisixUpstreamController) sync(ctx
context.Context, ev *type
gxthrj commented on a change in pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r617134124
##
File path: pkg/ingress/apisix_route.go
##
@@ -16,30 +16,44 @@ package ingress
import (
"context"
+ "fmt"
"time
gxthrj commented on pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#issuecomment-823703348
> @gxthrj The e2e CI failed.
It is strange, scale endpoint getting error.
--
This is an automated message from the Apache Git Service.
To respond to the
gxthrj commented on a change in pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r617132857
##
File path: pkg/ingress/endpoint.go
##
@@ -181,8 +181,8 @@ func (c *endpointsController) onAdd(obj interface{}) {
if !c.controll
spacewander commented on issue #4090:
URL: https://github.com/apache/apisix/issues/4090#issuecomment-823701104
You can write your own plugin like traffic-split.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
spacewander merged pull request #4089:
URL: https://github.com/apache/apisix/pull/4089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new b17bb8f docs: add dynamic contributor over
spacewander merged pull request #4085:
URL: https://github.com/apache/apisix/pull/4085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 81678a7 docs: the link should be to dashbo
spacewander closed issue #4079:
URL: https://github.com/apache/apisix/issues/4079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
tokers commented on issue #115:
URL:
https://github.com/apache/apisix-ingress-controller/issues/115#issuecomment-823697947
Assigned to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
tokers commented on issue #364:
URL:
https://github.com/apache/apisix-ingress-controller/issues/364#issuecomment-823697779
@batman-ezio Ping, any updates? I will wait for you 3 more days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
tokers commented on pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#issuecomment-823696046
@gxthrj The e2e CI failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
tokers commented on a change in pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r617124870
##
File path: pkg/ingress/apisix_route.go
##
@@ -16,30 +16,44 @@ package ingress
import (
"context"
+ "fmt"
"time
tokers commented on pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#issuecomment-823692128
@starsz Conflicts should be resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tokers commented on issue #338:
URL:
https://github.com/apache/apisix-ingress-controller/issues/338#issuecomment-823691506
@bahtou The indent of `backend` is wrong, it should be aligned with `match`,
not inside `match`.
--
This is an automated message from the Apache Git Service.
To res
juzhiyuan commented on issue #1803:
URL:
https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823680775
As @liuxiran said, we actually support an empty node list, it will return a
5xx status code to the client. I would prefer keeping the current behaviour,
because if users
codecov-commenter edited a comment on pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=
netlify[bot] edited a comment on pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822179614
Deploy preview for *apisix-dashboard* ready!
Built with commit 612d303a1be6e4790241908f8d252d78b4516f72
https://deploy-preview-1667--apisix-dash
netlify[bot] edited a comment on pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822179614
Deploy preview for *apisix-dashboard* processing.
Building with commit 612d303a1be6e4790241908f8d252d78b4516f72
https://app.netlify.com/sites/a
netlify[bot] edited a comment on pull request #1807:
URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823368427
Deploy preview for *apisix-dashboard* ready!
Built with commit d7521563209f779c8ac53860dace190574b6c790
https://deploy-preview-1807--apisix-dash
netlify[bot] edited a comment on pull request #1807:
URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823368427
Deploy preview for *apisix-dashboard* processing.
Building with commit d7521563209f779c8ac53860dace190574b6c790
https://app.netlify.com/sites/a
KishaniKandasamy opened a new issue #1809:
URL: https://github.com/apache/apisix-dashboard/issues/1809
## Issue description
https://apisix.apache.org/docs/api/conf/conf.yaml is broken in
deploy-with-docker
**English**
