[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4085: docs: the link should be to dashboard instead of APISIX

2021-04-20 Thread GitBox
KishaniKandasamy commented on a change in pull request #4085: URL: https://github.com/apache/apisix/pull/4085#discussion_r616397018 ## File path: docs/en/latest/getting-started.md ## @@ -262,7 +262,7 @@ $ curl -i -X GET 'http://127.0.0.1:9080/samplePrefix/get?param1=foo¶m2=bar

[GitHub] [apisix] oldthreefeng commented on issue #4067: bug: Updating the ssl certificate does not take effect

2021-04-20 Thread GitBox
oldthreefeng commented on issue #4067: URL: https://github.com/apache/apisix/issues/4067#issuecomment-823026958 fixed ~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. Fo

[GitHub] [apisix] oldthreefeng closed issue #4067: bug: Updating the ssl certificate does not take effect

2021-04-20 Thread GitBox
oldthreefeng closed issue #4067: URL: https://github.com/apache/apisix/issues/4067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [apisix] zwjzxh520 commented on issue #4080: bug: limit-count 中 count 值未生效

2021-04-20 Thread GitBox
zwjzxh520 commented on issue #4080: URL: https://github.com/apache/apisix/issues/4080#issuecomment-823027769 感谢,找到原因了,是我们的统计有误 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [apisix] zwjzxh520 closed issue #4080: bug: limit-count 中 count 值未生效

2021-04-20 Thread GitBox
zwjzxh520 closed issue #4080: URL: https://github.com/apache/apisix/issues/4080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4085: docs: the link should be to dashboard instead of APISIX

2021-04-20 Thread GitBox
KishaniKandasamy commented on a change in pull request #4085: URL: https://github.com/apache/apisix/pull/4085#discussion_r616397018 ## File path: docs/en/latest/getting-started.md ## @@ -262,7 +262,7 @@ $ curl -i -X GET 'http://127.0.0.1:9080/samplePrefix/get?param1=foo¶m2=bar

[GitHub] [apisix-helm-chart] BLasan commented on issue #37: doc: need guidelines to deploy apisix without clone this repo

2021-04-20 Thread GitBox
BLasan commented on issue #37: URL: https://github.com/apache/apisix-helm-chart/issues/37#issuecomment-823031888 @Yiyiyimu Hi, can't we publish the helm chart into to [artifacthub](https://artifacthub.io/) and install it via the helm command -- This is an automated message from the Apac

[GitHub] [apisix-helm-chart] BLasan edited a comment on issue #37: doc: need guidelines to deploy apisix without clone this repo

2021-04-20 Thread GitBox
BLasan edited a comment on issue #37: URL: https://github.com/apache/apisix-helm-chart/issues/37#issuecomment-823031888 @Yiyiyimu Hi, can't we publish the helm chart into to [artifacthub](https://artifacthub.io/) and install it via the helm command ? -- This is an automated message from

[GitHub] [apisix-dashboard] iamayushdas closed issue #1800: Error: while running manager-api on ubuntu 20.04.2

2021-04-20 Thread GitBox
iamayushdas closed issue #1800: URL: https://github.com/apache/apisix-dashboard/issues/1800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1788: feat: embed assets in api binary

2021-04-20 Thread GitBox
netlify[bot] edited a comment on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-822143589 Deploy preview for *apisix-dashboard* processing. Building with commit 99e2684b9873f5c52d2f83802d6f60ade71000e5 https://app.netlify.com/sites/a

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1788: feat: embed assets in api binary

2021-04-20 Thread GitBox
netlify[bot] edited a comment on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-822143589 Deploy preview for *apisix-dashboard* ready! Built with commit 99e2684b9873f5c52d2f83802d6f60ade71000e5 https://deploy-preview-1788--apisix-dash

[GitHub] [apisix] Ben0625 commented on issue #4077: passive healthcheck not working after configuration changing

2021-04-20 Thread GitBox
Ben0625 commented on issue #4077: URL: https://github.com/apache/apisix/issues/4077#issuecomment-823049058 > @Ben0625 Could you try the `2.5` version? And test it whether it can be reproduced in `2.5`? I tried the 2.5 version and it can be reproduced. Let me provide more details.

[GitHub] [apisix-dashboard] bisakhmondal removed a comment on pull request #1788: feat: embed assets in api binary

2021-04-20 Thread GitBox
bisakhmondal removed a comment on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-822427098 go1.16 has been added to the environment https://github.com/apache/apisix-dashboard/pull/1788/checks?check_run_id=2380595572#step:4:10 but still `

[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo

2021-04-20 Thread GitBox
bisakhmondal commented on pull request #1781: URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-823052019 Okay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [apisix-dashboard] bisakhmondal closed pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo

2021-04-20 Thread GitBox
bisakhmondal closed pull request #1781: URL: https://github.com/apache/apisix-dashboard/pull/1781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[GitHub] [apisix-dashboard] bisakhmondal opened a new pull request #1802: feat: rewrite route-with-jwt-plugin-test using ginkgo

2021-04-20 Thread GitBox
bisakhmondal opened a new pull request #1802: URL: https://github.com/apache/apisix-dashboard/pull/1802 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1802: feat: rewrite route-with-jwt-plugin-test using ginkgo

2021-04-20 Thread GitBox
netlify[bot] commented on pull request #1802: URL: https://github.com/apache/apisix-dashboard/pull/1802#issuecomment-823055710 Deploy preview for *apisix-dashboard* processing. Building with commit b0cb37998523b35cc8ef0ce3e8cff7ffa1283984 https://app.netlify.com/sites/apisix-d

[GitHub] [apisix-ingress-controller] wjx8382 commented on issue #356: request help: KubeSphere setup

2021-04-20 Thread GitBox
wjx8382 commented on issue #356: URL: https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-823055957 > From the configuration snippet the `allow_admin` was rendered correctly, so it should work, would you like to try the `0.5.0` version, it was released few days ago

[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1705: fix: detailed error for store init failure and deferred execution of closers

2021-04-20 Thread GitBox
bisakhmondal commented on pull request #1705: URL: https://github.com/apache/apisix-dashboard/pull/1705#issuecomment-823056820 I guess the PR is complete. Anything left that needs to be done? @nic-chen -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [apisix-dashboard] ericsyh opened a new issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?

2021-04-20 Thread GitBox
ericsyh opened a new issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803 ## Issue description When fixing the Upstream form warning message issue, i found a behavior that users can delete all target nodes forms on the page like ![](http://piw45adv3.bkt.cl

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1802: feat: rewrite route-with-jwt-plugin-test using ginkgo

2021-04-20 Thread GitBox
netlify[bot] edited a comment on pull request #1802: URL: https://github.com/apache/apisix-dashboard/pull/1802#issuecomment-823055710 Deploy preview for *apisix-dashboard* ready! Built with commit b0cb37998523b35cc8ef0ce3e8cff7ffa1283984 https://deploy-preview-1802--apisix-dash

[apisix-dashboard] branch master updated (a476ad7 -> 4590801)

2021-04-20 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from a476ad7 feat: Improve debug view (#1779) add 4590801 chore(deps): update actions/upload-artifact

[GitHub] [apisix-dashboard] nic-chen merged pull request #1790: chore(deps): update actions/upload-artifact requirement to v2.2.3

2021-04-20 Thread GitBox
nic-chen merged pull request #1790: URL: https://github.com/apache/apisix-dashboard/pull/1790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servi

[GitHub] [apisix-control-plane] kasini3000 edited a comment on issue #42: feat:Use curl to encapsulate the Admin API into a script

2021-04-20 Thread GitBox
kasini3000 edited a comment on issue #42: URL: https://github.com/apache/apisix-control-plane/issues/42#issuecomment-823014673 从命令行,用脚本和参数控制apisix 功能需求: 从命令行 添加路由, 删除路由, 添加监听, 删除监听, 添加后端, 删除后端。 需求说明: 用户界面=命令行,参数。(类似于istioct

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1667: feat: run manager-api as a systemd daemon/service

2021-04-20 Thread GitBox
nic-chen commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-823118510 > > how about ./manager-api start and ./manager-api stop, > > when run ./manager-api start and the service is not installed, install it ? > > Okay then, I wil

[GitHub] [apisix] Firstsawyou opened a new issue #4086: feat: response-rewrite plugin response header rewriting supports NGINX variables

2021-04-20 Thread GitBox
Firstsawyou opened a new issue #4086: URL: https://github.com/apache/apisix/issues/4086 ### Issue description Background: Current user feedback that the response-rewrite plug-in response header rewrite does not support NGINX variable mode. If you want to carry some parameters

[GitHub] [apisix-dashboard] liuxiran commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?

2021-04-20 Thread GitBox
liuxiran commented on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823120920 Hi @ericsyh thanks for your report. Acctually from the funcitonal point of view, the empty node list is a feature, see: `The nodes can be empty, which means

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #386: feat: add event & status for ApisixRoute v2

2021-04-20 Thread GitBox
gxthrj commented on pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386#issuecomment-823145842 `kubectl get ar -n test httpbin-route -o yaml` ![image](https://user-images.githubusercontent.com/4413028/115376823-9c8bb280-a201-11eb-97ee-6e0d527e6411.png)

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #386: feat: add event & status for ApisixRoute v2

2021-04-20 Thread GitBox
gxthrj commented on pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386#issuecomment-823146744 `kubectl describe ar -n test httpbin-route` ![image](https://user-images.githubusercontent.com/4413028/115377022-ce047e00-a201-11eb-83d8-9afe90e842bf.png)

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #386: feat: add event & status for ApisixRoute v2

2021-04-20 Thread GitBox
gxthrj commented on a change in pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r616532189 ## File path: pkg/ingress/apisix_route.go ## @@ -198,14 +212,50 @@ func (c *apisixRouteController) sync(ctx context.Context, ev *types.Ev

[GitHub] [apisix] Ben0625 edited a comment on issue #4077: passive healthcheck not working after configuration changing

2021-04-20 Thread GitBox
Ben0625 edited a comment on issue #4077: URL: https://github.com/apache/apisix/issues/4077#issuecomment-823049058 > @Ben0625 Could you try the `2.5` version? And test it whether it can be reproduced in `2.5`? I tried the Apisix 2.5 version but not use the dashboard 2.5 version. I jus

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service

2021-04-20 Thread GitBox
netlify[bot] edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822179614 Deploy preview for *apisix-dashboard* processing. Building with commit c2389a5e60a51a6ee2d09f382955939202db4550 https://app.netlify.com/sites/a

[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1667: feat: run manager-api as a systemd daemon/service

2021-04-20 Thread GitBox
bisakhmondal commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-823151812 ![image](https://user-images.githubusercontent.com/41498427/115378133-dfdc2600-a1ed-11eb-9486-83c3b0c8b429.png) new commands -- This is an automated message f

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service

2021-04-20 Thread GitBox
codecov-commenter edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] membphis commented on issue #1801: DockerHub is unstable to install FE dependencies (yarnpkg)

2021-04-20 Thread GitBox
membphis commented on issue #1801: URL: https://github.com/apache/apisix-dashboard/issues/1801#issuecomment-823153094 > I just disabled this auto-build temporarily, and will send a ticket to DockerHub to see what happened. https://hub.docker.com/repository/docker/apache/apisix-dashboard/b

[GitHub] [apisix] membphis merged pull request #4070: feat: upstream grpcs support mTLS

2021-04-20 Thread GitBox
membphis merged pull request #4070: URL: https://github.com/apache/apisix/pull/4070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[apisix] branch master updated: feat: upstream grpcs support mTLS (#4070)

2021-04-20 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 12c9e6f feat: upstream grpcs support mTLS (#4

[GitHub] [apisix] spacewander opened a new pull request #4087: fix: avoid being taint by empty global rule

2021-04-20 Thread GitBox
spacewander opened a new pull request #4087: URL: https://github.com/apache/apisix/pull/4087 Fix #4057 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or w

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service

2021-04-20 Thread GitBox
netlify[bot] edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822179614 Deploy preview for *apisix-dashboard* ready! Built with commit c2389a5e60a51a6ee2d09f382955939202db4550 https://deploy-preview-1667--apisix-dash

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service

2021-04-20 Thread GitBox
codecov-commenter edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix] spacewander opened a new pull request #4088: chore: ask for luarocks version if user ask questions about installation

2021-04-20 Thread GitBox
spacewander opened a new pull request #4088: URL: https://github.com/apache/apisix/pull/4088 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new featu

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service

2021-04-20 Thread GitBox
codecov-commenter edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] Firstsawyou commented on issue #1796: 关于路由/*有效,/foo/*无效

2021-04-20 Thread GitBox
Firstsawyou commented on issue #1796: URL: https://github.com/apache/apisix-dashboard/issues/1796#issuecomment-823174286 Hi,@leon1509 Do you have an API for `/foo/api/user/get` in your backend service? From the response data, it is likely that there is no corresponding API in the back

[GitHub] [apisix] LiteSun opened a new pull request #4089: docs: add dynamic contributor over time chart

2021-04-20 Thread GitBox
LiteSun opened a new pull request #4089: URL: https://github.com/apache/apisix/pull/4089 ### What this PR does / why we need it: ### Pre-submission checklist: Update contributor over time charts with automatic update support. * [x] Did you explain what problem does t

[GitHub] [apisix-helm-chart] tokers commented on issue #37: doc: need guidelines to deploy apisix without clone this repo

2021-04-20 Thread GitBox
tokers commented on issue #37: URL: https://github.com/apache/apisix-helm-chart/issues/37#issuecomment-823185888 > @Yiyiyimu Hi, can't we publish the helm chart into to [artifacthub](https://artifacthub.io/) and install it via the helm command ? We already published them to artifact

[GitHub] [apisix-control-plane] membphis commented on issue #42: feat:Use curl to encapsulate the Admin API into a script

2021-04-20 Thread GitBox
membphis commented on issue #42: URL: https://github.com/apache/apisix-control-plane/issues/42#issuecomment-823245845 @gxthrj do you have time to look at this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [apisix] Ben0625 opened a new issue #4090: Correspondence between matched rules and upstreams within one route

2021-04-20 Thread GitBox
Ben0625 opened a new issue #4090: URL: https://github.com/apache/apisix/issues/4090 Request: > Set just one route and the path is "/test". > Set correspondence between many matched rules and upstreams. For example: > > > if args_id == 1, choose upstream A > > if args_id == 2,

[GitHub] [apisix-helm-chart] Yiyiyimu commented on issue #37: doc: need guidelines to deploy apisix without clone this repo

2021-04-20 Thread GitBox
Yiyiyimu commented on issue #37: URL: https://github.com/apache/apisix-helm-chart/issues/37#issuecomment-823278009 > @Yiyiyimu Hi, can't we publish the helm chart into to [artifacthub](https://artifacthub.io/) and install it via the helm command? Hi @BLasan Yes but we still need to

[GitHub] [apisix] starsz commented on pull request #3883: feat: add 5xx error page

2021-04-20 Thread GitBox
starsz commented on pull request #3883: URL: https://github.com/apache/apisix/pull/3883#issuecomment-823289321 > Then your PR did not solve the issue @starsz I am confused. This PR can solve the issue. The response I give is before this PR. Can you give more details about why this

[GitHub] [apisix] starsz edited a comment on pull request #3883: feat: add 5xx error page

2021-04-20 Thread GitBox
starsz edited a comment on pull request #3883: URL: https://github.com/apache/apisix/pull/3883#issuecomment-823289321 > Then your PR did not solve the issue @starsz I am confused. This PR can solve the issue. The response I give is before this PR. Can you give more details about w

[GitHub] [apisix-ingress-controller] tokers commented on issue #356: request help: KubeSphere setup

2021-04-20 Thread GitBox
tokers commented on issue #356: URL: https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-823299160 > > From the configuration snippet the `allow_admin` was rendered correctly, so it should work, would you like to try the `0.5.0` version, it was released few days ag

[GitHub] [apisix-dashboard] KishaniKandasamy opened a new issue #1804: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE

2021-04-20 Thread GitBox
KishaniKandasamy opened a new issue #1804: URL: https://github.com/apache/apisix-dashboard/issues/1804 ## Issue description Currently we have FAQ section under the sidebar . But there is [an FAQ](https://apisix.apache.org/docs/dashboard/IMPORT_OPENAPI_USER_GUIDE#faq) in the IMPORT_O

[GitHub] [apisix-ingress-controller] bahtou commented on issue #338: bug: minikube setup

2021-04-20 Thread GitBox
bahtou commented on issue #338: URL: https://github.com/apache/apisix-ingress-controller/issues/338#issuecomment-823329241 @tokers Following the documentation here: https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/deployments/minikube.md#install-apisix

[GitHub] [apisix] moonming commented on pull request #3883: feat: add 5xx error page

2021-04-20 Thread GitBox
moonming commented on pull request #3883: URL: https://github.com/apache/apisix/pull/3883#issuecomment-823336035 > > Then your PR did not solve the issue @starsz > > > > I am confused. This PR can solve the issue. The response I give is before this PR. > > Can you give

[GitHub] [apisix] membphis opened a new issue #4091: feature: support to fetch balancer `ip`/`port` from `ctx.vars`

2021-04-20 Thread GitBox
membphis opened a new issue #4091: URL: https://github.com/apache/apisix/issues/4091 we have stored the upstream ip/port in `ctx` object, here is the link: https://github.com/apache/apisix/blob/master/apisix/balancer.lua#L204-L205 we should support to fetch from `ctx.vars`, here is t

[GitHub] [apisix-control-plane] juzhiyuan commented on issue #42: feat:Use curl to encapsulate the Admin API into a script

2021-04-20 Thread GitBox
juzhiyuan commented on issue #42: URL: https://github.com/apache/apisix-control-plane/issues/42#issuecomment-823347833 Please take a look at this one, if we are going to support this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

2021-04-20 Thread GitBox
iamayushdas commented on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823348141 @juzhiyuan @guoqqqi have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [apisix] membphis commented on issue #4091: feature: support to fetch balancer `ip`/`port` from `ctx.vars`

2021-04-20 Thread GitBox
membphis commented on issue #4091: URL: https://github.com/apache/apisix/issues/4091#issuecomment-823348187 @moonming welcome to take a look at this issue and I think @Firstsawyou should familiar with this feature, welcome to make a try. -- This is an automated message from the Ap

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

2021-04-20 Thread GitBox
netlify[bot] commented on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128 Deploy preview for *apisix-dashboard* processing. Building with commit 3f20b9914b49cf7f0ccec2f38784a06a6efe28b6 https://app.netlify.com/sites/apisix-d

[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1805: chore: icons added for auth, security, traffic, serverless

2021-04-20 Thread GitBox
iamayushdas opened a new pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless

2021-04-20 Thread GitBox
netlify[bot] edited a comment on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128 Deploy preview for *apisix-dashboard* ready! Built with commit 3f20b9914b49cf7f0ccec2f38784a06a6efe28b6 https://deploy-preview-1805--apisix-dash

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

2021-04-20 Thread GitBox
juzhiyuan commented on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823357985 **Chinese** ![image](https://user-images.githubusercontent.com/2106987/115421188-56007d00-a22e-11eb-928c-f090c6bbb930.png) **English** ![image](https://u

[GitHub] [apisix-dashboard] KishaniKandasamy opened a new issue #1806: docs: add correct custom IDs to links

2021-04-20 Thread GitBox
KishaniKandasamy opened a new issue #1806: URL: https://github.com/apache/apisix-dashboard/issues/1806 Some links aren't directed properly . Ex: https://apisix.apache.org/docs/dashboard/api/api/#ApiError ![9](https://user-images.githubusercontent.com/53715187/115422808-e339d

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1807: docs: add correct custom IDs to links

2021-04-20 Thread GitBox
netlify[bot] commented on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823368427 Deploy preview for *apisix-dashboard* processing. Building with commit cbaf1eb8f8694f68880a496c657be918d3183295 https://app.netlify.com/sites/apisix-d

[GitHub] [apisix-dashboard] KishaniKandasamy opened a new pull request #1807: docs: add correct custom IDs to links

2021-04-20 Thread GitBox
KishaniKandasamy opened a new pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [X] Bugfix **What changes will

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

2021-04-20 Thread GitBox
codecov-commenter commented on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823368734 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1807: docs: add correct custom IDs to links

2021-04-20 Thread GitBox
netlify[bot] edited a comment on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823368427 Deploy preview for *apisix-dashboard* ready! Built with commit cbaf1eb8f8694f68880a496c657be918d3183295 https://deploy-preview-1807--apisix-dash

[GitHub] [apisix] Firstsawyou opened a new pull request #4092: fix(traffic-split): when there are multiple weighted_upstreams, the request is confused

2021-04-20 Thread GitBox
Firstsawyou opened a new pull request #4092: URL: https://github.com/apache/apisix/pull/4092 ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1807: docs: add correct custom IDs to links

2021-04-20 Thread GitBox
netlify[bot] edited a comment on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823368427 Deploy preview for *apisix-dashboard* processing. Building with commit 0d5d7deb5d82c802159767bcf13e82a9065e18f5 https://app.netlify.com/sites/a

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1807: docs: add correct custom IDs to links

2021-04-20 Thread GitBox
netlify[bot] edited a comment on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823368427 Deploy preview for *apisix-dashboard* ready! Built with commit 0d5d7deb5d82c802159767bcf13e82a9065e18f5 https://deploy-preview-1807--apisix-dash

[GitHub] [apisix-dashboard] KishaniKandasamy opened a new pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE

2021-04-20 Thread GitBox
KishaniKandasamy opened a new pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [X] Bugfix **Related issue

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE

2021-04-20 Thread GitBox
netlify[bot] commented on pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134 Deploy preview for *apisix-dashboard* processing. Building with commit 08b678508fe86065c3c36f2aa3cdb4c942f76994 https://app.netlify.com/sites/apisix-d

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE

2021-04-20 Thread GitBox
netlify[bot] edited a comment on pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE

2021-04-20 Thread GitBox
netlify[bot] edited a comment on pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134 Deploy preview for *apisix-dashboard* ready! Built with commit 61d7078c61539282868f1aaa310a8301777c467b https://deploy-preview-1808--apisix-dash

[GitHub] [apisix-dashboard] KishaniKandasamy opened a new issue #1809: doc: link is broken in deploy-with-docker

2021-04-20 Thread GitBox
KishaniKandasamy opened a new issue #1809: URL: https://github.com/apache/apisix-dashboard/issues/1809 ## Issue description https://apisix.apache.org/docs/api/conf/conf.yaml is broken in deploy-with-docker ![99](https://user-images.githubusercontent.com/53715187/115437928-6b73a800-a

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1807: docs: add correct custom IDs to links

2021-04-20 Thread GitBox
netlify[bot] edited a comment on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823368427 Deploy preview for *apisix-dashboard* processing. Building with commit d7521563209f779c8ac53860dace190574b6c790 https://app.netlify.com/sites/a

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1807: docs: add correct custom IDs to links

2021-04-20 Thread GitBox
netlify[bot] edited a comment on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823368427 Deploy preview for *apisix-dashboard* ready! Built with commit d7521563209f779c8ac53860dace190574b6c790 https://deploy-preview-1807--apisix-dash

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service

2021-04-20 Thread GitBox
netlify[bot] edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822179614 Deploy preview for *apisix-dashboard* processing. Building with commit 612d303a1be6e4790241908f8d252d78b4516f72 https://app.netlify.com/sites/a

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service

2021-04-20 Thread GitBox
netlify[bot] edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822179614 Deploy preview for *apisix-dashboard* ready! Built with commit 612d303a1be6e4790241908f8d252d78b4516f72 https://deploy-preview-1667--apisix-dash

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service

2021-04-20 Thread GitBox
codecov-commenter edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?

2021-04-20 Thread GitBox
juzhiyuan commented on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823680775 As @liuxiran said, we actually support an empty node list, it will return a 5xx status code to the client. I would prefer keeping the current behaviour, because if users

[GitHub] [apisix-ingress-controller] tokers commented on issue #338: bug: minikube setup

2021-04-20 Thread GitBox
tokers commented on issue #338: URL: https://github.com/apache/apisix-ingress-controller/issues/338#issuecomment-823691506 @bahtou The indent of `backend` is wrong, it should be aligned with `match`, not inside `match`. -- This is an automated message from the Apache Git Service. To res

[GitHub] [apisix] tokers commented on pull request #3883: feat: add 5xx error page

2021-04-20 Thread GitBox
tokers commented on pull request #3883: URL: https://github.com/apache/apisix/pull/3883#issuecomment-823692128 @starsz Conflicts should be resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #386: feat: add event & status for ApisixRoute v2

2021-04-20 Thread GitBox
tokers commented on a change in pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r617124870 ## File path: pkg/ingress/apisix_route.go ## @@ -16,30 +16,44 @@ package ingress import ( "context" + "fmt" "time

[GitHub] [apisix-ingress-controller] tokers commented on pull request #386: feat: add event & status for ApisixRoute v2

2021-04-20 Thread GitBox
tokers commented on pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386#issuecomment-823696046 @gxthrj The e2e CI failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-ingress-controller] tokers commented on issue #364: ci: add golint workflow

2021-04-20 Thread GitBox
tokers commented on issue #364: URL: https://github.com/apache/apisix-ingress-controller/issues/364#issuecomment-823697779 @batman-ezio Ping, any updates? I will wait for you 3 more days. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [apisix-ingress-controller] tokers commented on issue #115: feat: Support TCP definition

2021-04-20 Thread GitBox
tokers commented on issue #115: URL: https://github.com/apache/apisix-ingress-controller/issues/115#issuecomment-823697947 Assigned to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [apisix] spacewander closed issue #4079: docs(get-started): the link should be to dashboard instead of APISIX

2021-04-20 Thread GitBox
spacewander closed issue #4079: URL: https://github.com/apache/apisix/issues/4079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[apisix] branch master updated: docs: the link should be to dashboard instead of APISIX (#4085)

2021-04-20 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 81678a7 docs: the link should be to dashbo

[GitHub] [apisix] spacewander merged pull request #4085: docs: the link should be to dashboard instead of APISIX

2021-04-20 Thread GitBox
spacewander merged pull request #4085: URL: https://github.com/apache/apisix/pull/4085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[apisix] branch master updated: docs: add dynamic contributor over time chart (#4089)

2021-04-20 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new b17bb8f docs: add dynamic contributor over

[GitHub] [apisix] spacewander merged pull request #4089: docs: add dynamic contributor over time chart

2021-04-20 Thread GitBox
spacewander merged pull request #4089: URL: https://github.com/apache/apisix/pull/4089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [apisix] spacewander commented on issue #4090: Request help: Correspondence between matched rules and upstreams within one route

2021-04-20 Thread GitBox
spacewander commented on issue #4090: URL: https://github.com/apache/apisix/issues/4090#issuecomment-823701104 You can write your own plugin like traffic-split. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #386: feat: add event & status for ApisixRoute v2

2021-04-20 Thread GitBox
gxthrj commented on a change in pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r617132857 ## File path: pkg/ingress/endpoint.go ## @@ -181,8 +181,8 @@ func (c *endpointsController) onAdd(obj interface{}) { if !c.controll

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #386: feat: add event & status for ApisixRoute v2

2021-04-20 Thread GitBox
gxthrj commented on pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386#issuecomment-823703348 > @gxthrj The e2e CI failed. It is strange, scale endpoint getting error. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #386: feat: add event & status for ApisixRoute v2

2021-04-20 Thread GitBox
gxthrj commented on a change in pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r617134124 ## File path: pkg/ingress/apisix_route.go ## @@ -16,30 +16,44 @@ package ingress import ( "context" + "fmt" "time

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #386: feat: add event & status for ApisixRoute v2

2021-04-20 Thread GitBox
gxthrj commented on a change in pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r617134653 ## File path: pkg/ingress/apisix_upstream.go ## @@ -122,6 +133,8 @@ func (c *apisixUpstreamController) sync(ctx context.Context, ev *type

[GitHub] [apisix-dashboard] starsz commented on pull request #1667: feat: run manager-api as a systemd daemon/service

2021-04-20 Thread GitBox
starsz commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-823705817 > > how about ./manager-api start and ./manager-api stop, > > when run ./manager-api start and the service is not installed, install it ? > > Okay then, I will

[GitHub] [apisix] spacewander edited a comment on issue #4090: Request help: Correspondence between matched rules and upstreams within one route

2021-04-20 Thread GitBox
spacewander edited a comment on issue #4090: URL: https://github.com/apache/apisix/issues/4090#issuecomment-823701104 ~~You can write your own plugin like traffic-split.~~ Look like the `rules` in traffic-split is an array, so you can use it with multiple upstream but not just for 2.

[GitHub] [apisix-control-plane] gxthrj commented on issue #42: feat:Use curl to encapsulate the Admin API into a script

2021-04-20 Thread GitBox
gxthrj commented on issue #42: URL: https://github.com/apache/apisix-control-plane/issues/42#issuecomment-823709420 @kasini3000 Sorry for the late reply. According to the stated configuration, calling APISIX `admin-api` is already supported, but the command line function still needs to be

  1   2   >