[GitHub] [apisix] zhikaichen123 opened a new issue #5637: 官方的cors(跨域组件)独立设置并不能有效、通用的使用, 这个是我的改进代码

2021-11-29 Thread GitBox
zhikaichen123 opened a new issue #5637: URL: https://github.com/apache/apisix/issues/5637 ### Issue description https://github.com/apache/apisix/blob/2a32f13824c0cc8e359feedd23e537422af3b28c/docs/zh/latest/plugins/cors.md "plugins": { "cors": {} } 按照官方说法这样配置就可

[GitHub] [apisix-website] Baoyuantop opened a new pull request #778: feat: optimized twitter card display

2021-11-29 Thread GitBox
Baoyuantop opened a new pull request #778: URL: https://github.com/apache/apisix-website/pull/778 Changes: Optimized Twitter card display when sharing website content to Twitter. Screenshots of the change: ### **Before** https://user-images.githubusercontent.com/30611

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5594: feat(plugins): aws lambda serverless

2021-11-29 Thread GitBox
bisakhmondal commented on a change in pull request #5594: URL: https://github.com/apache/apisix/pull/5594#discussion_r758121837 ## File path: apisix/plugins/aws-lambda.lua ## @@ -0,0 +1,181 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contri

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5594: feat(plugins): aws lambda serverless

2021-11-29 Thread GitBox
bisakhmondal commented on a change in pull request #5594: URL: https://github.com/apache/apisix/pull/5594#discussion_r758123078 ## File path: apisix/plugins/azure-functions.lua ## @@ -14,30 +14,15 @@ -- See the License for the specific language governing permissions and -- li

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5594: feat(plugins): aws lambda serverless

2021-11-29 Thread GitBox
bisakhmondal commented on a change in pull request #5594: URL: https://github.com/apache/apisix/pull/5594#discussion_r758123218 ## File path: apisix/plugins/aws-lambda.lua ## @@ -0,0 +1,181 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contri

[GitHub] [apisix] GreenShadeZhang commented on issue #5425: request help: How to best handle oidc providers that do not support introspection endpoints?

2021-11-29 Thread GitBox
GreenShadeZhang commented on issue #5425: URL: https://github.com/apache/apisix/issues/5425#issuecomment-981400743 > It sounds different. This issue is about using jwks with openid-connect to authenticate a JWT. I checked the document today and found that envoy can realize the verif

[GitHub] [apisix] shuaijinchao commented on issue #5633: bug: enable skywalking plugin , the route rewrite is not affected

2021-11-29 Thread GitBox
shuaijinchao commented on issue #5633: URL: https://github.com/apache/apisix/issues/5633#issuecomment-981406873 Have you checked whether the skywalking service is normal? According to the error message you provided, this is more like an exception thrown by a spring framework? -- This is

[GitHub] [apisix-go-plugin-runner] Easy-deve commented on issue #48: request help: error reporting when deploying plug-ins in running mode

2021-11-29 Thread GitBox
Easy-deve commented on issue #48: URL: https://github.com/apache/apisix-go-plugin-runner/issues/48#issuecomment-981418284 > > execvp() failed while executing /path/to/apisix-go-plugin-runner/go-runner (8: Exec format error) > > The `go-runner` is not a valid executable. Do you compi

[GitHub] [apisix-go-plugin-runner] Easy-deve edited a comment on issue #48: request help: error reporting when deploying plug-ins in running mode

2021-11-29 Thread GitBox
Easy-deve edited a comment on issue #48: URL: https://github.com/apache/apisix-go-plugin-runner/issues/48#issuecomment-981418284 > > execvp() failed while executing /path/to/apisix-go-plugin-runner/go-runner (8: Exec format error) > > The `go-runner` is not a valid executable. Do yo

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2224: ci: fix stream route failed frequent

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2224: URL: https://github.com/apache/apisix-dashboard/pull/2224#issuecomment-979757962 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2224?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-go-plugin-runner] Easy-deve edited a comment on issue #48: request help: error reporting when deploying plug-ins in running mode

2021-11-29 Thread GitBox
Easy-deve edited a comment on issue #48: URL: https://github.com/apache/apisix-go-plugin-runner/issues/48#issuecomment-981418284 > > execvp() failed while executing /path/to/apisix-go-plugin-runner/go-runner (8: Exec format error) > > The `go-runner` is not a valid executable. Do yo

[GitHub] [apisix] spacewander commented on a change in pull request #5594: feat(plugins): aws lambda serverless

2021-11-29 Thread GitBox
spacewander commented on a change in pull request #5594: URL: https://github.com/apache/apisix/pull/5594#discussion_r758167136 ## File path: t/admin/plugins.t ## @@ -40,7 +40,7 @@ __DATA__ --- request GET /apisix/admin/plugins/list --- response_body_like eval -qr/\["real-ip"

[GitHub] [apisix-ingress-controller] tokers commented on pull request #731: feat: Grafana Dashboard Configuration

2021-11-29 Thread GitBox
tokers commented on pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-981461097 @Sindweller What does the `cluster health check` value mean? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix-website] juzhiyuan commented on pull request #778: feat: optimized twitter card display

2021-11-29 Thread GitBox
juzhiyuan commented on pull request #778: URL: https://github.com/apache/apisix-website/pull/778#issuecomment-981471421 LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[apisix-website] branch master updated: feat: optimized twitter card display (#778)

2021-11-29 Thread bzp2010
This is an automated email from the ASF dual-hosted git repository. bzp2010 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 024979f feat: optimized twitter card d

[GitHub] [apisix-website] bzp2010 merged pull request #778: feat: optimized twitter card display

2021-11-29 Thread GitBox
bzp2010 merged pull request #778: URL: https://github.com/apache/apisix-website/pull/778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [apisix-website] juzhiyuan commented on issue #593: support a new open graph tags

2021-11-29 Thread GitBox
juzhiyuan commented on issue #593: URL: https://github.com/apache/apisix-website/issues/593#issuecomment-981479118 **Update** just supported the Twitter card, see #778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [apisix-go-plugin-runner] spacewander commented on issue #48: request help: error reporting when deploying plug-ins in running mode

2021-11-29 Thread GitBox
spacewander commented on issue #48: URL: https://github.com/apache/apisix-go-plugin-runner/issues/48#issuecomment-981480648 Try compiling the go-runner in Linux or cross-compile it for Linux. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [apisix-dashboard] github-actions[bot] commented on issue #2146: support set scope as Path in Advanced Routing Matching Conditions

2021-11-29 Thread GitBox
github-actions[bot] commented on issue #2146: URL: https://github.com/apache/apisix-dashboard/issues/2146#issuecomment-981481588 This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, p

[GitHub] [apisix-dashboard] github-actions[bot] commented on issue #2159: apisix dashboard not coming up

2021-11-29 Thread GitBox
github-actions[bot] commented on issue #2159: URL: https://github.com/apache/apisix-dashboard/issues/2159#issuecomment-981481687 This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, p

[GitHub] [apisix-dashboard] github-actions[bot] commented on issue #2150: support custom plugins type

2021-11-29 Thread GitBox
github-actions[bot] commented on issue #2150: URL: https://github.com/apache/apisix-dashboard/issues/2150#issuecomment-981481639 This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, p

[GitHub] [apisix] tzssangglass commented on issue #5425: request help: How to best handle oidc providers that do not support introspection endpoints?

2021-11-29 Thread GitBox
tzssangglass commented on issue #5425: URL: https://github.com/apache/apisix/issues/5425#issuecomment-981490983 > > It sounds different. This issue is about using jwks with openid-connect to authenticate a JWT. > > I checked the document today and found that envoy can realize the ve

[GitHub] [apisix] tzssangglass commented on issue #5633: bug: enable skywalking plugin , the route rewrite is not affected

2021-11-29 Thread GitBox
tzssangglass commented on issue #5633: URL: https://github.com/apache/apisix/issues/5633#issuecomment-981494582 the 404 code is returned by upstream, pls confirm that this address is available upstream. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [apisix] tzssangglass commented on issue #5637: 官方的cors(跨域组件)独立设置并不能有效、通用的使用, 这个是我的改进代码

2021-11-29 Thread GitBox
tzssangglass commented on issue #5637: URL: https://github.com/apache/apisix/issues/5637#issuecomment-981495412 pls use English on open channel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [apisix] tzssangglass commented on issue #5637: request help: the official cors plugin is not effective and universal, here is my improved code

2021-11-29 Thread GitBox
tzssangglass commented on issue #5637: URL: https://github.com/apache/apisix/issues/5637#issuecomment-981505346 first, it's great that you can adapt APISIX's plug-ins to meet your business needs yourself. > 按照官方说法这样配置就可以有跨域效果,实则不然,这样浏览器调用还会有问题的,还是会有跨域异常 pls describe the probl

[GitHub] [apisix] tzssangglass removed a comment on issue #5637: request help: the official cors plugin is not effective and universal, here is my improved code

2021-11-29 Thread GitBox
tzssangglass removed a comment on issue #5637: URL: https://github.com/apache/apisix/issues/5637#issuecomment-981505346 first, it's great that you can adapt APISIX's plug-ins to meet your business needs yourself. > 按照官方说法这样配置就可以有跨域效果,实则不然,这样浏览器调用还会有问题的,还是会有跨域异常 pls describe t

[GitHub] [apisix] tzssangglass commented on issue #5637: request help: the official cors plugin is not effective and universal, here is my improved code

2021-11-29 Thread GitBox
tzssangglass commented on issue #5637: URL: https://github.com/apache/apisix/issues/5637#issuecomment-981510117 first, it's great that you can adapt APISIX's plug-ins to meet your business needs yourself. > 按照官方说法这样配置就可以有跨域效果,实则不然,这样浏览器调用还会有问题的,还是会有跨域异常 pls describe the proble

[GitHub] [apisix] shuaijinchao commented on issue #5626: bug: attempt to concatenate field 'shm_name' (a nil value)

2021-11-29 Thread GitBox
shuaijinchao commented on issue #5626: URL: https://github.com/apache/apisix/issues/5626#issuecomment-981513230 @kevinw66 based on your description 1. switch to the master branch (commit ID: 8f0b066c) 2. make deps 3. make run I cannot reproduce this problem, can you provide m

[GitHub] [apisix] shuaijinchao edited a comment on issue #5626: bug: attempt to concatenate field 'shm_name' (a nil value)

2021-11-29 Thread GitBox
shuaijinchao edited a comment on issue #5626: URL: https://github.com/apache/apisix/issues/5626#issuecomment-981513230 @kevinw66 based on your description 1. switch to the master branch (last commit ID: 8f0b066c) 2. make deps 3. make run I cannot reproduce this problem, can y

[GitHub] [apisix-ingress-controller] tokers commented on issue #767: request help: ingress forward auth

2021-11-29 Thread GitBox
tokers commented on issue #767: URL: https://github.com/apache/apisix-ingress-controller/issues/767#issuecomment-981556948 > > > > Hi, > > > > > These annotations are not parsed by APISIX Ingress Controller, and what's more, the underlying APISIX doesn't support the forward auth fea

[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #183: feat(apisix): add service monitor support

2021-11-29 Thread GitBox
tokers commented on a change in pull request #183: URL: https://github.com/apache/apisix-helm-chart/pull/183#discussion_r758284311 ## File path: charts/apisix/templates/configmap.yaml ## @@ -226,6 +226,13 @@ data: {{- if .Values.customPlugins.enabled }} plugin_attr:

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2224: ci: fix stream route failed frequent

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2224: URL: https://github.com/apache/apisix-dashboard/pull/2224#issuecomment-979757962 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2224?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] MizuhaHimuraki opened a new pull request #2226: pluginconfig use etcd prefix

2021-11-29 Thread GitBox
MizuhaHimuraki opened a new pull request #2226: URL: https://github.com/apache/apisix-dashboard/pull/2226 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [x] Bugfix - [ ] New feature provide

[GitHub] [apisix] MizuhaHimuraki commented on issue #5608: request help: apisix cannot connect to etcd when etcd auth enabled

2021-11-29 Thread GitBox
MizuhaHimuraki commented on issue #5608: URL: https://github.com/apache/apisix/issues/5608#issuecomment-981606860 OK, this is a limitation of the etcd itself. I will add username and password fields in the config file to workaround. > CommonName of client sending a request against ga

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2201: test: migrate route remote addr e2e

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2201: URL: https://github.com/apache/apisix-dashboard/pull/2201#issuecomment-964751665 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2201?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix] MizuhaHimuraki edited a comment on issue #5608: request help: apisix cannot connect to etcd when etcd auth enabled

2021-11-29 Thread GitBox
MizuhaHimuraki edited a comment on issue #5608: URL: https://github.com/apache/apisix/issues/5608#issuecomment-981606860 >> Note that this feature cannot be used with gRPC-proxy and gRPC-gateway. This is because gRPC-proxy terminates TLS from its client so all the clients share a cert of t

[GitHub] [apisix] membphis commented on pull request #5594: feat(plugins): aws lambda serverless

2021-11-29 Thread GitBox
membphis commented on pull request #5594: URL: https://github.com/apache/apisix/pull/5594#issuecomment-981615409 @shuaijinchao @tzssangglass pls review when you have time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [apisix] MizuhaHimuraki opened a new pull request #5640: feat: report error when use etcd client cert auth

2021-11-29 Thread GitBox
MizuhaHimuraki opened a new pull request #5640: URL: https://github.com/apache/apisix/pull/5640 ### What this PR does / why we need it: fix #5608 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been add

[GitHub] [apisix] membphis commented on a change in pull request #5594: feat(plugins): aws lambda serverless

2021-11-29 Thread GitBox
membphis commented on a change in pull request #5594: URL: https://github.com/apache/apisix/pull/5594#discussion_r758345571 ## File path: t/admin/plugins.t ## @@ -40,7 +40,7 @@ __DATA__ --- request GET /apisix/admin/plugins/list --- response_body_like eval -qr/\["real-ip","c

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2201: test: migrate route remote addr e2e

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2201: URL: https://github.com/apache/apisix-dashboard/pull/2201#issuecomment-964751665 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2201?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix] spacewander commented on a change in pull request #5640: feat: report error when use etcd client cert auth

2021-11-29 Thread GitBox
spacewander commented on a change in pull request #5640: URL: https://github.com/apache/apisix/pull/5640#discussion_r758365827 ## File path: apisix/cli/etcd.lua ## @@ -347,6 +347,11 @@ function _M.init(env, args) util.die(errmsg) end +

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2201: test: migrate route remote addr e2e

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2201: URL: https://github.com/apache/apisix-dashboard/pull/2201#issuecomment-964751665 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2201?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-ingress-controller] Sindweller commented on pull request #731: feat: Grafana Dashboard Configuration

2021-11-29 Thread GitBox
Sindweller commented on pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-981651080 > Can you add a document describing how to monitor and use this dashboard? Thanks > > If you need any help please feel free to ping me. working

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2201: test: migrate route remote addr e2e

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2201: URL: https://github.com/apache/apisix-dashboard/pull/2201#issuecomment-964751665 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2201?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-ingress-controller] Sindweller commented on pull request #731: feat: Grafana Dashboard Configuration

2021-11-29 Thread GitBox
Sindweller commented on pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-981660128 > @Sindweller What does the `cluster health check` value mean? It increases when [checkClusterHealth](https://github.com/apache/apisix-ingress-controll

[GitHub] [apisix-dashboard] bzp2010 opened a new issue #2227: bug: migrate E2E test in CI fails randomly

2021-11-29 Thread GitBox
bzp2010 opened a new issue #2227: URL: https://github.com/apache/apisix-dashboard/issues/2227 ### Issue description In our current backend CI tests, the migrate case frequently fails randomly. You can see a demo on [here](https://github.com/apache/apisix-dashboard/runs/4352169437?ch

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2224: ci: fix stream route failed frequent

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2224: URL: https://github.com/apache/apisix-dashboard/pull/2224#issuecomment-979757962 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2224?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] bzp2010 opened a new pull request #2228: fix: migrate testcase CI crash

2021-11-29 Thread GitBox
bzp2010 opened a new pull request #2228: URL: https://github.com/apache/apisix-dashboard/pull/2228 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [x] Bugfix - [ ] New feature provided -

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2224: ci: fix stream route failed frequent

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2224: URL: https://github.com/apache/apisix-dashboard/pull/2224#issuecomment-979757962 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2224?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2228: fix: migrate testcase CI crash

2021-11-29 Thread GitBox
codecov-commenter commented on pull request #2228: URL: https://github.com/apache/apisix-dashboard/pull/2228#issuecomment-981692905 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5594: feat(plugins): aws lambda serverless

2021-11-29 Thread GitBox
bisakhmondal commented on a change in pull request #5594: URL: https://github.com/apache/apisix/pull/5594#discussion_r758428555 ## File path: docs/en/latest/plugins/aws-lambda.md ## @@ -0,0 +1,156 @@ +--- +title: aws-lambda +--- + + + +## Summary + +- [Summary](#summary) +- [Na

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5594: feat(plugins): aws lambda serverless

2021-11-29 Thread GitBox
bisakhmondal commented on a change in pull request #5594: URL: https://github.com/apache/apisix/pull/5594#discussion_r758461565 ## File path: apisix/plugins/aws-lambda.lua ## @@ -0,0 +1,185 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contri

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5594: feat(plugins): aws lambda serverless

2021-11-29 Thread GitBox
bisakhmondal commented on a change in pull request #5594: URL: https://github.com/apache/apisix/pull/5594#discussion_r758461816 ## File path: apisix/plugins/aws-lambda.lua ## @@ -0,0 +1,185 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contri

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5594: feat(plugins): aws lambda serverless

2021-11-29 Thread GitBox
bisakhmondal commented on a change in pull request #5594: URL: https://github.com/apache/apisix/pull/5594#discussion_r758463163 ## File path: apisix/plugins/aws-lambda.lua ## @@ -0,0 +1,185 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contri

[GitHub] [apisix] bisakhmondal opened a new pull request #5641: docs: minor update in azure faas http2 documentation

2021-11-29 Thread GitBox
bisakhmondal opened a new pull request #5641: URL: https://github.com/apache/apisix/pull/5641 ### What this PR does / why we need it: Suggestion from: https://github.com/apache/apisix/pull/5594#discussion_r758179470 ### Pre-submission checklist: * [x] Did you ex

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2228: fix: migrate testcase CI crash

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2228: URL: https://github.com/apache/apisix-dashboard/pull/2228#issuecomment-981692905 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix] bisakhmondal opened a new pull request #5642: refactor: plugins list test representation

2021-11-29 Thread GitBox
bisakhmondal opened a new pull request #5642: URL: https://github.com/apache/apisix/pull/5642 ### What this PR does / why we need it: Suggestion from: https://github.com/apache/apisix/pull/5594#discussion_r758167136 ### Pre-submission checklist: * [x] Did you ex

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5594: feat(plugins): aws lambda serverless

2021-11-29 Thread GitBox
bisakhmondal commented on a change in pull request #5594: URL: https://github.com/apache/apisix/pull/5594#discussion_r758502099 ## File path: t/admin/plugins.t ## @@ -40,7 +40,7 @@ __DATA__ --- request GET /apisix/admin/plugins/list --- response_body_like eval -qr/\["real-ip

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2228: fix: migrate testcase CI crash

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2228: URL: https://github.com/apache/apisix-dashboard/pull/2228#issuecomment-981692905 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2224: ci: fix stream route failed frequent

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2224: URL: https://github.com/apache/apisix-dashboard/pull/2224#issuecomment-979757962 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2224?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2224: ci: fix stream route failed frequent

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2224: URL: https://github.com/apache/apisix-dashboard/pull/2224#issuecomment-979757962 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2224?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2224: ci: fix stream route failed frequent

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2224: URL: https://github.com/apache/apisix-dashboard/pull/2224#issuecomment-979757962 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2224?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2224: ci: fix stream route failed frequent

2021-11-29 Thread GitBox
codecov-commenter edited a comment on pull request #2224: URL: https://github.com/apache/apisix-dashboard/pull/2224#issuecomment-979757962 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2224?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix] spacewander commented on a change in pull request #5641: docs: minor update in azure faas http2 documentation

2021-11-29 Thread GitBox
spacewander commented on a change in pull request #5641: URL: https://github.com/apache/apisix/pull/5641#discussion_r758849099 ## File path: docs/en/latest/plugins/azure-functions.md ## @@ -104,20 +104,20 @@ Request-Context: appId=cid-v1:38aae829-293b-43c2-82c6-fa94aec0a071 D

[GitHub] [apisix] spacewander commented on a change in pull request #5594: feat(plugins): aws lambda serverless

2021-11-29 Thread GitBox
spacewander commented on a change in pull request #5594: URL: https://github.com/apache/apisix/pull/5594#discussion_r758852167 ## File path: docs/en/latest/plugins/aws-lambda.md ## @@ -0,0 +1,156 @@ +--- +title: aws-lambda +--- + + + +## Summary + +- [Summary](#summary) +- [Nam

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2228: fix: migrate testcase CI crash

2021-11-29 Thread GitBox
bzp2010 commented on pull request #2228: URL: https://github.com/apache/apisix-dashboard/pull/2228#issuecomment-982187870 ping @nic-chen @starsz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-docker] spacewander merged pull request #250: feat: upgrade APISIX to 2.11.0

2021-11-29 Thread GitBox
spacewander merged pull request #250: URL: https://github.com/apache/apisix-docker/pull/250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

[GitHub] [apisix] starsz commented on issue #5634: request help: support get the key from function in limit-* plugins

2021-11-29 Thread GitBox
starsz commented on issue #5634: URL: https://github.com/apache/apisix/issues/5634#issuecomment-982195527 > What about allowing user to register their var in > > https://github.com/apache/apisix/blob/8f0b066c86257ad6af19f9b3b7e209ece95d17c9/apisix/core/ctx.lua#L147 > > ?

[GitHub] [apisix] tokers commented on issue #5608: request help: apisix cannot connect to etcd when etcd auth enabled

2021-11-29 Thread GitBox
tokers commented on issue #5608: URL: https://github.com/apache/apisix/issues/5608#issuecomment-982197676 > > > Note that this feature cannot be used with gRPC-proxy and gRPC-gateway. This is because gRPC-proxy terminates TLS from its client so all the clients share a cert of the proxy. gR

[GitHub] [apisix] tokers commented on a change in pull request #5640: feat: report error when use etcd client cert auth

2021-11-29 Thread GitBox
tokers commented on a change in pull request #5640: URL: https://github.com/apache/apisix/pull/5640#discussion_r758867173 ## File path: apisix/cli/etcd.lua ## @@ -347,6 +347,11 @@ function _M.init(env, args) util.die(errmsg) end +if r

[GitHub] [apisix-dashboard] juzhiyuan closed issue #2227: bug: migrate E2E test in CI fails randomly

2021-11-29 Thread GitBox
juzhiyuan closed issue #2227: URL: https://github.com/apache/apisix-dashboard/issues/2227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2228: fix: migrate testcase CI crash

2021-11-29 Thread GitBox
juzhiyuan merged pull request #2228: URL: https://github.com/apache/apisix-dashboard/pull/2228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

[GitHub] [apisix-ingress-controller] tokers commented on pull request #774: fix: delete the cluster object when give up the leadership

2021-11-29 Thread GitBox
tokers commented on pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#issuecomment-982206376 > better to add e2e for this feature. First of all, this is not a feature, indeed it's a bugfix, also, it's tough to add cases for it. -- This is an aut

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #774: fix: delete the cluster object when give up the leadership

2021-11-29 Thread GitBox
tokers commented on a change in pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#discussion_r758871044 ## File path: tools.go ## @@ -1,3 +1,4 @@ +//go:build tools Review comment: Removed. -- This is an automated message from the

[GitHub] [apisix-ingress-controller] tokers commented on pull request #731: feat: Grafana Dashboard Configuration

2021-11-29 Thread GitBox
tokers commented on pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-982207316 > > @Sindweller What does the `cluster health check` value mean? > > It increases when [checkClusterHealth](https://github.com/apache/apisix-ingress-contro

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #774: fix: delete the cluster object when give up the leadership

2021-11-29 Thread GitBox
tao12345666333 commented on a change in pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#discussion_r758872053 ## File path: tools.go ## @@ -1,3 +1,4 @@ +//go:build tools Review comment: You haven't pushed the latest code yet? --

[GitHub] [apisix] juzhiyuan commented on a change in pull request #5594: feat(plugins): aws lambda serverless

2021-11-29 Thread GitBox
juzhiyuan commented on a change in pull request #5594: URL: https://github.com/apache/apisix/pull/5594#discussion_r758873866 ## File path: docs/en/latest/plugins/aws-lambda.md ## @@ -0,0 +1,156 @@ +--- +title: aws-lambda +--- + + + +## Summary + +- [Summary](#summary) +- [Name]

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #774: fix: delete the cluster object when give up the leadership

2021-11-29 Thread GitBox
tao12345666333 commented on pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#issuecomment-982212833 Maybe we can introduce chaos test later. If you want to add tests here, We can first set the number of replicas of apisix to 0 to ensure that all

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #776: docs: add contribution guidelines

2021-11-29 Thread GitBox
juzhiyuan commented on a change in pull request #776: URL: https://github.com/apache/apisix-website/pull/776#discussion_r758876911 ## File path: website/docs/general/blog-contributing-guide.md ## @@ -0,0 +1,353 @@ +--- +id: blog +title: Blog Contributing Guide +keywords: +- API

[apisix-docker] branch master updated (369f084 -> 2031794)

2021-11-29 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-docker.git. from 369f084 fix: all-in-one docker image build error (#249) add 2031794 feat: upgrade APISIX to 2.11.0

[apisix-docker] branch release/apisix-2.11.0 created (now 2031794)

2021-11-29 Thread sunyi
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a change to branch release/apisix-2.11.0 in repository https://gitbox.apache.org/repos/asf/apisix-docker.git. at 2031794 feat: upgrade APISIX to 2.11.0 (#250) No new revisions were added by this update.

[apisix-dashboard] branch master updated (a555684 -> b788ab3)

2021-11-29 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from a555684 test: migrate global rule e2e (#2202) add b788ab3 fix: migrate testcase CI crash (#2228)

[GitHub] [apisix] xianshun163 commented on issue #5607: bug: traffic-split err

2021-11-29 Thread GitBox
xianshun163 commented on issue #5607: URL: https://github.com/apache/apisix/issues/5607#issuecomment-982219109 the upstreamid are exist, they are create by the apisix auto. I can't reproduce the issue now, -- This is an automated message from the Apache Git Service. To respon

[GitHub] [apisix] tzssangglass commented on a change in pull request #5594: feat(plugins): aws lambda serverless

2021-11-29 Thread GitBox
tzssangglass commented on a change in pull request #5594: URL: https://github.com/apache/apisix/pull/5594#discussion_r758881212 ## File path: apisix/plugins/aws-lambda.lua ## @@ -0,0 +1,183 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contri

[GitHub] [apisix] kevinw66 commented on issue #5626: bug: attempt to concatenate field 'shm_name' (a nil value)

2021-11-29 Thread GitBox
kevinw66 commented on issue #5626: URL: https://github.com/apache/apisix/issues/5626#issuecomment-982221673 Environment apisix version:master branch OS:Darwin wuzhiguodeMacBook-Pro.local 20.6.0 Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021; root:xnu-7195.141.6~3/RELEASE_X

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #776: docs: add contribution guidelines

2021-11-29 Thread GitBox
juzhiyuan commented on a change in pull request #776: URL: https://github.com/apache/apisix-website/pull/776#discussion_r758878114 ## File path: website/docs/general/blog-contributing-guide.md ## @@ -0,0 +1,353 @@ +--- +id: blog +title: Blog Contributing Guide +keywords: +- API

[GitHub] [apisix] kevinw66 commented on issue #5626: bug: attempt to concatenate field 'shm_name' (a nil value)

2021-11-29 Thread GitBox
kevinw66 commented on issue #5626: URL: https://github.com/apache/apisix/issues/5626#issuecomment-98228 ![image](https://user-images.githubusercontent.com/31196226/143975036-fbb6a5fe-23a5-4dee-80f0-208857ceeb0f.png) -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix] zhangweidongyyl opened a new issue #5643: request help: body_filter how to send request in apisix

2021-11-29 Thread GitBox
zhangweidongyyl opened a new issue #5643: URL: https://github.com/apache/apisix/issues/5643 ### Issue description i want send request in body_filter,based on last request returned Status to send different req ### Environment - apisix version (cmd: `apisix versio

[GitHub] [apisix] kevinw66 edited a comment on issue #5626: bug: attempt to concatenate field 'shm_name' (a nil value)

2021-11-29 Thread GitBox
kevinw66 edited a comment on issue #5626: URL: https://github.com/apache/apisix/issues/5626#issuecomment-982221673 @shuaijinchao Environment apisix version:master branch OS:Darwin wuzhiguodeMacBook-Pro.local 20.6.0 Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021; root:x

[GitHub] [apisix] LiteSun commented on a change in pull request #5595: feat: add gen-vote-content script

2021-11-29 Thread GitBox
LiteSun commented on a change in pull request #5595: URL: https://github.com/apache/apisix/pull/5595#discussion_r758884633 ## File path: utils/gen-vote-contents.sh ## @@ -0,0 +1,92 @@ +#!/bin/sh + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contr

[GitHub] [apisix-website] wang-yeliang commented on pull request #776: docs: add contribution guidelines

2021-11-29 Thread GitBox
wang-yeliang commented on pull request #776: URL: https://github.com/apache/apisix-website/pull/776#issuecomment-982223851 For the first time, there is a detailed guide for blogs, and other types of contribution guides can be derived later. -- This is an automated message from the Apache

[GitHub] [apisix] kevinw66 commented on issue #5626: bug: attempt to concatenate field 'shm_name' (a nil value)

2021-11-29 Thread GitBox
kevinw66 commented on issue #5626: URL: https://github.com/apache/apisix/issues/5626#issuecomment-982225198 but this can work correctly on branch release/2.11, I'm confused -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] MizuhaHimuraki commented on a change in pull request #5640: feat: report error when use etcd client cert auth

2021-11-29 Thread GitBox
MizuhaHimuraki commented on a change in pull request #5640: URL: https://github.com/apache/apisix/pull/5640#discussion_r75778 ## File path: apisix/cli/etcd.lua ## @@ -347,6 +347,11 @@ function _M.init(env, args) util.die(errmsg) end +

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2226: fix: plugin_configs should store with etcd prefix

2021-11-29 Thread GitBox
codecov-commenter commented on pull request #2226: URL: https://github.com/apache/apisix-dashboard/pull/2226#issuecomment-982233726 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2226?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2226: fix: plugin_configs should store with etcd prefix

2021-11-29 Thread GitBox
bzp2010 commented on pull request #2226: URL: https://github.com/apache/apisix-dashboard/pull/2226#issuecomment-982233792 LGTM, just wait the CI passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] kevinw66 closed issue #5626: bug: attempt to concatenate field 'shm_name' (a nil value)

2021-11-29 Thread GitBox
kevinw66 closed issue #5626: URL: https://github.com/apache/apisix/issues/5626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [apisix] kevinw66 commented on issue #5626: bug: attempt to concatenate field 'shm_name' (a nil value)

2021-11-29 Thread GitBox
kevinw66 commented on issue #5626: URL: https://github.com/apache/apisix/issues/5626#issuecomment-982234001 After I re-run make deps, the lua-resty-etcd version is upgrade from 1.5.4 to 1.6.0 and this problem disappear. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5641: docs: minor update in azure faas http2 documentation

2021-11-29 Thread GitBox
bisakhmondal commented on a change in pull request #5641: URL: https://github.com/apache/apisix/pull/5641#discussion_r758905790 ## File path: docs/en/latest/plugins/azure-functions.md ## @@ -104,20 +104,20 @@ Request-Context: appId=cid-v1:38aae829-293b-43c2-82c6-fa94aec0a071

  1   2   >