[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 #

[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox
yuz10 commented on a change in pull request #5653: URL: https://github.com/apache/apisix/pull/5653#discussion_r760838391 ## File path: docs/zh/latest/plugins/rocketmq-logger.md ## @@ -0,0 +1,229 @@ +--- +title: rocketmq-logger +--- + + + +## 目录 + +- [**简介**](#简介) +-

[GitHub] [apisix] shuaijinchao edited a comment on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox
shuaijinchao edited a comment on issue #5658: URL: https://github.com/apache/apisix/issues/5658#issuecomment-984375154 > > @lihuawei321 @saintak @jiangkaiyuan98 Thanks feedback. Reopen and compression will cause log record exceptions. We will fix this problem in the latest version. >

[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox
yuz10 commented on a change in pull request #5653: URL: https://github.com/apache/apisix/pull/5653#discussion_r760838167 ## File path: docs/en/latest/plugins/rocketmq-logger.md ## @@ -0,0 +1,234 @@ +--- +title: rocketmq-logger +--- + + + +## Summary + +- [**Name**](#name) +-

[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox
yuz10 commented on a change in pull request #5653: URL: https://github.com/apache/apisix/pull/5653#discussion_r760837218 ## File path: docs/en/latest/plugins/rocketmq-logger.md ## @@ -0,0 +1,234 @@ +--- +title: rocketmq-logger +--- + + + +## Summary + +- [**Name**](#name) +-

[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox
yuz10 commented on a change in pull request #5653: URL: https://github.com/apache/apisix/pull/5653#discussion_r760837115 ## File path: apisix/plugins/rocketmq-logger.lua ## @@ -0,0 +1,271 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox
yuz10 commented on a change in pull request #5653: URL: https://github.com/apache/apisix/pull/5653#discussion_r760836989 ## File path: ci/pod/docker-compose.yml ## @@ -355,10 +355,34 @@ services: networks: apisix_net: + namesrv: Review comment:

[GitHub] [apisix] shuaijinchao commented on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox
shuaijinchao commented on issue #5658: URL: https://github.com/apache/apisix/issues/5658#issuecomment-984375154 > > @lihuawei321 @saintak @jiangkaiyuan98 Thanks feedback. Reopen and compression will cause log record exceptions. We will fix this problem in the latest version. > >

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585 #

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585 #

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 #

[GitHub] [apisix] tzssangglass commented on issue #5654: bug: URI encoding issue

2021-12-01 Thread GitBox
tzssangglass commented on issue #5654: URL: https://github.com/apache/apisix/issues/5654#issuecomment-984370324 Based on this configuration, what do you want to achieve and what are the expected results? > I created a route > /api/v1/groups/* > and made a URI Override >

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 #

[GitHub] [apisix] saintak commented on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox
saintak commented on issue #5658: URL: https://github.com/apache/apisix/issues/5658#issuecomment-984366399 > @lihuawei321 @saintak @jiangkaiyuan98 Thanks feedback. Reopen and compression will cause log record exceptions. We will fix this problem in the latest version.

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 #

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5664: docs: documenting url path forwarding for faas plugins

2021-12-01 Thread GitBox
bisakhmondal commented on a change in pull request #5664: URL: https://github.com/apache/apisix/pull/5664#discussion_r760826430 ## File path: docs/en/latest/plugins/aws-lambda.md ## @@ -136,6 +137,43 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 #

[GitHub] [apisix] saintak commented on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox
saintak commented on issue #5658: URL: https://github.com/apache/apisix/issues/5658#issuecomment-984363130 > @saintak the #5663 question, have you tried to check the file size several times without compression and check the integrity of the file content? > >

[GitHub] [apisix] shuaijinchao commented on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox
shuaijinchao commented on issue #5658: URL: https://github.com/apache/apisix/issues/5658#issuecomment-984360063 @lihuawei321 @saintak @jiangkaiyuan98 Thanks feedback. Reopen and compression will cause log record exceptions. We will fix this problem in the latest version. -- This is

[GitHub] [apisix-helm-chart] Gallardot opened a new pull request #185: feat: add extra labels and annotations for service monitor

2021-12-01 Thread GitBox
Gallardot opened a new pull request #185: URL: https://github.com/apache/apisix-helm-chart/pull/185 If [servicemonitors.matchLabels](https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/user-guides/getting-started.md#include-servicemonitors) are enabled, we

[GitHub] [apisix-go-plugin-runner] hwyzleo commented on issue #49: register plugin success but do not match it when i visit the route

2021-12-01 Thread GitBox
hwyzleo commented on issue #49: URL: https://github.com/apache/apisix-go-plugin-runner/issues/49#issuecomment-984358874 > Could you run the runner with ` -m dev` and see if it has received the RPC from the APISIX during the request? by the go-runner log, i thought the handleConn

[GitHub] [apisix-website] yzeng25 commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox
yzeng25 commented on a change in pull request #784: URL: https://github.com/apache/apisix-website/pull/784#discussion_r760819633 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md ## @@ -0,0 +1,182 @@ +--- +title:

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox
SylviaBABY commented on a change in pull request #784: URL: https://github.com/apache/apisix-website/pull/784#discussion_r760803422 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md ## @@ -0,0 +1,182 @@ +--- +title:

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
juzhiyuan commented on a change in pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#discussion_r760810704 ## File path: web/src/components/Plugin/data.tsx ## @@ -224,4 +224,22 @@ export const PLUGIN_LIST = { type: PluginType.other,

[GitHub] [apisix-website] juzhiyuan commented on issue #782: Prometheus doc 'Grafana dashboard meta ' file link is broken

2021-12-01 Thread GitBox
juzhiyuan commented on issue #782: URL: https://github.com/apache/apisix-website/issues/782#issuecomment-984347270 @huang-x-h may need your help here  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585 #

[GitHub] [apisix] shuaijinchao edited a comment on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox
shuaijinchao edited a comment on issue #5658: URL: https://github.com/apache/apisix/issues/5658#issuecomment-984346459 @saintak the https://github.com/apache/apisix/issues/5663 question, have you tried to check the file size several times without compression and check the integrity of the

[GitHub] [apisix-website] juzhiyuan commented on issue #698: Update SkyWalking plugin's docs

2021-12-01 Thread GitBox
juzhiyuan commented on issue #698: URL: https://github.com/apache/apisix-website/issues/698#issuecomment-984347011 Of course  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-website] juzhiyuan commented on pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox
juzhiyuan commented on pull request #784: URL: https://github.com/apache/apisix-website/pull/784#issuecomment-984346588 ![image](https://user-images.githubusercontent.com/2106987/144373912-6a86eaaf-ca57-430c-9ef1-98b17cb2948d.png) Thanks for @SylviaBABY's review! And we could use

[GitHub] [apisix] shuaijinchao commented on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox
shuaijinchao commented on issue #5658: URL: https://github.com/apache/apisix/issues/5658#issuecomment-984346459 @saintak the https://github.com/apache/apisix/issues/5663 question, have you tried to check the file size several times without compression?

[GitHub] [apisix-website] juzhiyuan merged pull request #783: docs: add weeklyreport 11.30

2021-12-01 Thread GitBox
juzhiyuan merged pull request #783: URL: https://github.com/apache/apisix-website/pull/783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[apisix-website] branch master updated: docs: add weeklyreport 11.30 (#783)

2021-12-01 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 5af2e5a docs: add weeklyreport

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585 #

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox
SylviaBABY commented on a change in pull request #784: URL: https://github.com/apache/apisix-website/pull/784#discussion_r760804943 ## File path: website/blog/2021/12/01/apisix-supports-azure-functions.md ## @@ -0,0 +1,182 @@ +--- +title: "Apache APISIX intergration with Azure

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox
SylviaBABY commented on a change in pull request #784: URL: https://github.com/apache/apisix-website/pull/784#discussion_r760804662 ## File path: website/blog/2021/12/01/apisix-supports-azure-functions.md ## @@ -0,0 +1,182 @@ +--- +title: "Apache APISIX intergration with Azure

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox
SylviaBABY commented on a change in pull request #784: URL: https://github.com/apache/apisix-website/pull/784#discussion_r760803624 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md ## @@ -0,0 +1,182 @@ +--- +title:

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox
SylviaBABY commented on a change in pull request #784: URL: https://github.com/apache/apisix-website/pull/784#discussion_r760803422 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md ## @@ -0,0 +1,182 @@ +--- +title:

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox
SylviaBABY commented on a change in pull request #784: URL: https://github.com/apache/apisix-website/pull/784#discussion_r760802617 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md ## @@ -0,0 +1,182 @@ +--- +title:

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox
SylviaBABY commented on a change in pull request #784: URL: https://github.com/apache/apisix-website/pull/784#discussion_r760801943 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md ## @@ -0,0 +1,182 @@ +--- +title:

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox
SylviaBABY commented on a change in pull request #784: URL: https://github.com/apache/apisix-website/pull/784#discussion_r760801356 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md ## @@ -0,0 +1,182 @@ +--- +title:

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox
SylviaBABY commented on a change in pull request #784: URL: https://github.com/apache/apisix-website/pull/784#discussion_r760801040 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md ## @@ -0,0 +1,182 @@ +--- +title:

[GitHub] [apisix] juzhiyuan opened a new issue #5671: docs: skywalking-logger plugin doc is using an incorrect configuration demo

2021-12-01 Thread GitBox
juzhiyuan opened a new issue #5671: URL: https://github.com/apache/apisix/issues/5671 ### Improved or typo fixed. Please see https://apisix.apache.org/docs/apisix/plugins/skywalking-logger

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox
SylviaBABY commented on a change in pull request #784: URL: https://github.com/apache/apisix-website/pull/784#discussion_r760800344 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md ## @@ -0,0 +1,182 @@ +--- +title:

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox
SylviaBABY commented on a change in pull request #784: URL: https://github.com/apache/apisix-website/pull/784#discussion_r760799976 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md ## @@ -0,0 +1,182 @@ +--- +title:

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox
SylviaBABY commented on a change in pull request #784: URL: https://github.com/apache/apisix-website/pull/784#discussion_r760799904 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md ## @@ -0,0 +1,182 @@ +--- +title:

[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path

2021-12-01 Thread GitBox
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-984335293 > > > We may also add some test cases. > > > > > > have written more test cases. retested the feature > > By say adding test cases, we'd better

[GitHub] [apisix-website] 123liubao commented on issue #698: Update SkyWalking plugin's docs

2021-12-01 Thread GitBox
123liubao commented on issue #698: URL: https://github.com/apache/apisix-website/issues/698#issuecomment-984324331 Hello, @juzhiyuan I want to work on this, please assign it to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-website] huang-x-h commented on issue #782: Prometheus doc 'Grafana dashboard meta ' file link is broken

2021-12-01 Thread GitBox
huang-x-h commented on issue #782: URL: https://github.com/apache/apisix-website/issues/782#issuecomment-984316005 Should i send a PR or you just fixed it ? not diffcult :) @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] juzhiyuan opened a new issue #5668: docs: ldap-auth plugin's doc is missing Consumer parameters

2021-12-01 Thread GitBox
juzhiyuan opened a new issue #5668: URL: https://github.com/apache/apisix/issues/5668 ### Improved or typo fixed. According to `ldap-auth` plugin's implementation[1], our docs are missing parameters when configuring Consumer. See

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585 #

[GitHub] [apisix] leslie-tsang commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox
leslie-tsang commented on a change in pull request #5653: URL: https://github.com/apache/apisix/pull/5653#discussion_r760768602 ## File path: docs/zh/latest/plugins/rocketmq-logger.md ## @@ -0,0 +1,229 @@ +--- +title: rocketmq-logger +--- + + + +## 目录 + +- [**简介**](#简介) +-

[GitHub] [apisix] leslie-tsang commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox
leslie-tsang commented on a change in pull request #5653: URL: https://github.com/apache/apisix/pull/5653#discussion_r760763518 ## File path: docs/en/latest/plugins/rocketmq-logger.md ## @@ -0,0 +1,234 @@ +--- +title: rocketmq-logger +--- + + + +## Summary + +-

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585 #

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
bzp2010 commented on a change in pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#discussion_r760758760 ## File path: web/src/components/Plugin/data.tsx ## @@ -224,4 +224,22 @@ export const PLUGIN_LIST = { type: PluginType.other, hidden:

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585 #

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
bzp2010 commented on a change in pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#discussion_r760758760 ## File path: web/src/components/Plugin/data.tsx ## @@ -224,4 +224,22 @@ export const PLUGIN_LIST = { type: PluginType.other, hidden:

[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
zaunist commented on a change in pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#discussion_r760758406 ## File path: web/src/components/Plugin/data.tsx ## @@ -224,4 +224,22 @@ export const PLUGIN_LIST = { type: PluginType.other, hidden:

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585 #

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585 #

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585 #

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585 #

[GitHub] [apisix] jiangkaiyuan98 commented on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox
jiangkaiyuan98 commented on issue #5658: URL: https://github.com/apache/apisix/issues/5658#issuecomment-984273472 我是将enable_compression设置为true后,会出现access.log没有日志的现象 ![image](https://user-images.githubusercontent.com/4942/144355443-955ab22d-0d9a-4215-9dc8-e5a31837c7a3.png)

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
bzp2010 commented on a change in pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#discussion_r760747010 ## File path: api/conf/schema.json ## @@ -5501,10 +6814,14 @@ "type": "object"

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585 #

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
codecov-commenter commented on pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585 #

[GitHub] [apisix-dashboard] zaunist commented on pull request #2201: test: migrate route remote addr e2e

2021-12-01 Thread GitBox
zaunist commented on pull request #2201: URL: https://github.com/apache/apisix-dashboard/pull/2201#issuecomment-984267980 cc @bzp2010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
zaunist commented on a change in pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233#discussion_r760742640 ## File path: api/conf/schema.json ## @@ -5501,10 +6814,14 @@ "type": "object"

[GitHub] [apisix-dashboard] bzp2010 opened a new pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox
bzp2010 opened a new pull request #2233: URL: https://github.com/apache/apisix-dashboard/pull/2233 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided -

[GitHub] [apisix] saintak commented on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox
saintak commented on issue #5658: URL: https://github.com/apache/apisix/issues/5658#issuecomment-984264664 > hi, @lihuawei321 @saintak , can you provide the steps to reproduce it? According to the document configuration, I did not reproduce the problem.

[GitHub] [apisix-ingress-controller] han6565 edited a comment on issue #781: request help: The route name generated by default is too long

2021-12-01 Thread GitBox
han6565 edited a comment on issue #781: URL: https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-984263687 > > There are actually two problems here. > > * About modifying the route created by apisix-ingress in the dashboard > > **We do not

[GitHub] [apisix-ingress-controller] han6565 commented on issue #781: request help: The route name generated by default is too long

2021-12-01 Thread GitBox
han6565 commented on issue #781: URL: https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-984263687 > > There are actually two problems here. > > * About modifying the route created by apisix-ingress in the dashboard > > **We do not recommend

[GitHub] [apisix] shuaijinchao opened a new pull request #5667: docs(log-rotate): fix typo

2021-12-01 Thread GitBox
shuaijinchao opened a new pull request #5667: URL: https://github.com/apache/apisix/pull/5667 ### What this PR does / why we need it: `USER1` is not a signal name. The description in the log is misleading. If you need to describe the signal in detail, can should use the

[GitHub] [apisix-ingress-controller] han6565 edited a comment on issue #781: request help: The route name generated by default is too long

2021-12-01 Thread GitBox
han6565 edited a comment on issue #781: URL: https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-984248910 我也跟你遇见一样的问题,修改apisix-dashboard源码,他那有个长度验证,改长点就完了. 修改位置如果我没记错应该是/api/conf/schema.json 寻找route下的name,把最长改长点 -- This is an automated message from the Apache

[GitHub] [apisix-ingress-controller] han6565 commented on issue #781: request help: The route name generated by default is too long

2021-12-01 Thread GitBox
han6565 commented on issue #781: URL: https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-984248910 我也跟你遇见一样的问题,修改apisix-dashboard源码,他那有个长度验证,改长点就完了, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox
yuz10 commented on a change in pull request #5653: URL: https://github.com/apache/apisix/pull/5653#discussion_r760727687 ## File path: apisix/plugins/rocketmq-logger.lua ## @@ -0,0 +1,271 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox
yuz10 commented on a change in pull request #5653: URL: https://github.com/apache/apisix/pull/5653#discussion_r760727805 ## File path: apisix/plugins/rocketmq-logger.lua ## @@ -0,0 +1,271 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] shuaijinchao commented on issue #5658: request help: 开启log-rotate插件后日志采集不到

2021-12-01 Thread GitBox
shuaijinchao commented on issue #5658: URL: https://github.com/apache/apisix/issues/5658#issuecomment-984244609 hi, @lihuawei321 @saintak , can you provide the steps to reproduce it? According to the document configuration, I did not reproduce the problem.

[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox
yuz10 commented on a change in pull request #5653: URL: https://github.com/apache/apisix/pull/5653#discussion_r760723620 ## File path: ci/pod/docker-compose.yml ## @@ -355,10 +355,34 @@ services: networks: apisix_net: + namesrv: Review comment: the conf

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2232: fix(username_regex): cp consumer name regx different with dp

2021-12-01 Thread GitBox
codecov-commenter commented on pull request #2232: URL: https://github.com/apache/apisix-dashboard/pull/2232#issuecomment-984239320 #

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #740: feat: Fix lb ingress status

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #740: URL: https://github.com/apache/apisix-ingress-controller/pull/740#issuecomment-962736571 #

[GitHub] [apisix-dashboard] liuxiran merged pull request #2231: feat: support post args advanced match

2021-12-01 Thread GitBox
liuxiran merged pull request #2231: URL: https://github.com/apache/apisix-dashboard/pull/2231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[apisix-dashboard] branch master updated: feat: support post args advanced match (#2231)

2021-12-01 Thread liuxiran
This is an automated email from the ASF dual-hosted git repository. liuxiran pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new cbcac5f feat: support post args

[GitHub] [apisix-ingress-controller] BuptZyc commented on issue #781: request help: The route name generated by default is too long

2021-12-01 Thread GitBox
BuptZyc commented on issue #781: URL: https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-984229613 主要是想开启ext-plugin-pre-req使用自定义插件。不推荐修改路由的话,想问下怎么开启插件并进行配置呢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] leslie-tsang commented on a change in pull request #5660: test(core.log): fix unit test case

2021-12-01 Thread GitBox
leslie-tsang commented on a change in pull request #5660: URL: https://github.com/apache/apisix/pull/5660#discussion_r760712163 ## File path: apisix/core/log.lua ## @@ -15,13 +15,13 @@ -- limitations under the License. -- -local ngx = ngx -local ngx_log = ngx.log -local

[GitHub] [apisix-dashboard] zaunist commented on pull request #2232: fix(username_regex): cp consumer name regx different with dp

2021-12-01 Thread GitBox
zaunist commented on pull request #2232: URL: https://github.com/apache/apisix-dashboard/pull/2232#issuecomment-984228233 cc @liuxiran @bzp2010 @LiteSun @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] zaunist opened a new pull request #2232: fix(username_regex): cp consumer name regx different with dp

2021-12-01 Thread GitBox
zaunist opened a new pull request #2232: URL: https://github.com/apache/apisix-dashboard/pull/2232 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [x] Bugfix - [ ] New feature provided -

[GitHub] [apisix] spacewander opened a new pull request #5666: feat(mqtt-proxy): support using route's upstrewam

2021-12-01 Thread GitBox
spacewander opened a new pull request #5666: URL: https://github.com/apache/apisix/pull/5666 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what

[GitHub] [apisix] spacewander commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox
spacewander commented on a change in pull request #5653: URL: https://github.com/apache/apisix/pull/5653#discussion_r760703274 ## File path: apisix/plugins/rocketmq-logger.lua ## @@ -0,0 +1,271 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2231: feat: support post args advanced match

2021-12-01 Thread GitBox
codecov-commenter commented on pull request #2231: URL: https://github.com/apache/apisix-dashboard/pull/2231#issuecomment-984221756 #

[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #183: feat(apisix): add service monitor support

2021-12-01 Thread GitBox
tokers commented on a change in pull request #183: URL: https://github.com/apache/apisix-helm-chart/pull/183#discussion_r760705861 ## File path: charts/apisix/templates/configmap.yaml ## @@ -226,6 +226,13 @@ data: {{- if .Values.customPlugins.enabled }}

[GitHub] [apisix-ingress-controller] tokers commented on pull request #779: feat: support regex in path

2021-12-01 Thread GitBox
tokers commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-984214474 > > We may also add some test cases. > > have written more test cases. retested the feature By say adding test cases, we'd better also add the E2E

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #779: feat: support regex in path

2021-12-01 Thread GitBox
tokers commented on a change in pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#discussion_r760700157 ## File path: pkg/kube/translation/annotations/types.go ## @@ -18,6 +18,10 @@ import ( "strings" ) +const ( +

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #740: feat: Fix lb ingress status

2021-12-01 Thread GitBox
codecov-commenter edited a comment on pull request #740: URL: https://github.com/apache/apisix-ingress-controller/pull/740#issuecomment-962736571 #

[GitHub] [apisix] spacewander commented on a change in pull request #5660: fix(core.log): fix unit test case

2021-12-01 Thread GitBox
spacewander commented on a change in pull request #5660: URL: https://github.com/apache/apisix/pull/5660#discussion_r760697707 ## File path: apisix/core/log.lua ## @@ -15,13 +15,13 @@ -- limitations under the License. -- -local ngx = ngx -local ngx_log = ngx.log -local

[GitHub] [apisix] spacewander commented on a change in pull request #5664: docs: documenting url path forwarding for faas plugins

2021-12-01 Thread GitBox
spacewander commented on a change in pull request #5664: URL: https://github.com/apache/apisix/pull/5664#discussion_r760693386 ## File path: docs/en/latest/plugins/aws-lambda.md ## @@ -136,6 +137,43 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #782: request help: APISIX Ingress Annotation Document

2021-12-01 Thread GitBox
tao12345666333 commented on issue #782: URL: https://github.com/apache/apisix-ingress-controller/issues/782#issuecomment-984205198 You can find some available annotations and examples of their use here. https://github.com/apache/apisix-ingress-controller/tree/master/test/e2e/annotations

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #776: request help: Can I use admin api to define some rule, and use the upstream the crd defiled?

2021-12-01 Thread GitBox
tao12345666333 commented on issue #776: URL: https://github.com/apache/apisix-ingress-controller/issues/776#issuecomment-984204130 1. yes, you can. 2. Of course you can, as long as you guarantee that there is no conflict. -- This is an automated message from the Apache Git

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #781: request help: The route name generated by default is too long

2021-12-01 Thread GitBox
tao12345666333 commented on issue #781: URL: https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-984202850 There are actually two problems here. * About modifying the route created by apisix-ingress in the dashboard **We do not recommend this, or even

[GitHub] [apisix] moonming merged pull request #5655: docs: add aws lambda plugin to readme

2021-12-01 Thread GitBox
moonming merged pull request #5655: URL: https://github.com/apache/apisix/pull/5655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[apisix] branch master updated: docs: add aws lambda plugin to readme (#5655)

2021-12-01 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 13c119f docs: add aws lambda plugin to readme

  1   2   >