[GitHub] [apisix-ingress-controller] suninuni commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute

2021-12-30 Thread GitBox
suninuni commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003300644 Thanks, I have no other questions. And for this panic, it depends on you whether to resolve it or not. -- This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2276: feat: add dashboard overview

2021-12-30 Thread GitBox
codecov-commenter edited a comment on pull request #2276: URL: https://github.com/apache/apisix-dashboard/pull/2276#issuecomment-1003299981 #

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2276: feat: add dashboard overview

2021-12-30 Thread GitBox
codecov-commenter commented on pull request #2276: URL: https://github.com/apache/apisix-dashboard/pull/2276#issuecomment-1003299981 #

[GitHub] [apisix-ingress-controller] tao12345666333 edited a comment on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute

2021-12-30 Thread GitBox
tao12345666333 edited a comment on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003297684 When upgrading from APISIX Ingress v1.2 to v1.3, you need to upgrade ApisixRoute resources first, because we have removed the support for the

[GitHub] [apisix-ingress-controller] tao12345666333 edited a comment on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute

2021-12-30 Thread GitBox
tao12345666333 edited a comment on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003299256 > Can I wait until version 1.5 to upgrade ApisixRoute from v1beta1 to v2? There are too many changes in our clusters for each modification.

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute

2021-12-30 Thread GitBox
tao12345666333 commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003299256 > Can I wait until version 1.5 to upgrade ApisixRoute from v1beta1 to v2? There are too many changes in our clusters for each modification. Yes, you

[GitHub] [apisix] Drery commented on pull request #5940: feat: mocking plugin

2021-12-30 Thread GitBox
Drery commented on pull request #5940: URL: https://github.com/apache/apisix/pull/5940#issuecomment-1003299223 @shuaijinchao @juzhiyuan Thank you. I already send a proposal to the mailing list. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] tiyorn opened a new issue #5983: request help: 上游配置https,一直报错401

2021-12-30 Thread GitBox
tiyorn opened a new issue #5983: URL: https://github.com/apache/apisix/issues/5983 ### Issue description 上游配置为https,一直报401,怀疑跟ssl有关系。请问APISIX转发https请求至上游的时候,是否会受到SSL certificate verification的干扰,有没有开关可以关闭SSL certificates verify ### Environment - apisix version (cmd:

[GitHub] [apisix-dashboard] zaunist opened a new pull request #2276: feat: add dashboard overview

2021-12-30 Thread GitBox
zaunist opened a new pull request #2276: URL: https://github.com/apache/apisix-dashboard/pull/2276 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided -

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute

2021-12-30 Thread GitBox
tao12345666333 commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003298355 >In 1.4, apisix.apache.org/v2beta3 will be the stored version? Yes. In the last few versions, we are upgrading the api version, in order to make it

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute

2021-12-30 Thread GitBox
tao12345666333 commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003297684 When upgrading from APISIX Ingress v1.2 to v1.3, you need to upgrade ApisixRoute resources first, because we have removed the support for the following:

[GitHub] [apisix-ingress-controller] suninuni commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute

2021-12-30 Thread GitBox
suninuni commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003297698 > Can you try to run `kubectl api-resources --api-group=apisix.apache.org` ? > > ``` > $ kubectl api-resources --api-group=apisix.apache.org > NAME

[GitHub] [apisix] tzssangglass commented on issue #5969: Hope to add support for setting the custom host header to be used for upstream's artive checks!

2021-12-30 Thread GitBox
tzssangglass commented on issue #5969: URL: https://github.com/apache/apisix/issues/5969#issuecomment-1003297286 @sandy420 pls check this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #105: fix: disable null as key of req/resp headers and args

2021-12-30 Thread GitBox
tzssangglass opened a new pull request #105: URL: https://github.com/apache/apisix-java-plugin-runner/pull/105 Signed-off-by: tzssangglass Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature

[GitHub] [apisix] lihuawei321 opened a new issue #5982: 怎样在access.log里输出upstream的名称

2021-12-30 Thread GitBox
lihuawei321 opened a new issue #5982: URL: https://github.com/apache/apisix/issues/5982 ### Issue description 我用upstrem_name并没有获取到上游的名称。 ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V`

[GitHub] [apisix] yourgracee edited a comment on issue #5981: request help: 剪除路径后被再次路由

2021-12-30 Thread GitBox
yourgracee edited a comment on issue #5981: URL: https://github.com/apache/apisix/issues/5981#issuecomment-1003296100 > please provide specific cases and steps to reproduce. 1.配置一条/foo/bar 改写为 /foo的路由正则改写("regex_uri": ["^/foo/(.*)","/$1"]),绑定后端A服务 2.配置一条为/bar的路径重定向到其他路径,绑定后端B服务

[GitHub] [apisix] yourgracee edited a comment on issue #5981: request help: 剪除路径后被再次路由

2021-12-30 Thread GitBox
yourgracee edited a comment on issue #5981: URL: https://github.com/apache/apisix/issues/5981#issuecomment-1003296100 > please provide specific cases and steps to reproduce. 1.配置一条/foo/bar 改写为 /foo的路由正则改写("regex_uri": ["^/foo/(.*)","/$1"]),绑定后端A服务 2.配置一条为/foo的路径重定向到其他路径,绑定后端B服务

[GitHub] [apisix] yourgracee removed a comment on issue #5981: request help: 剪除路径后被再次路由

2021-12-30 Thread GitBox
yourgracee removed a comment on issue #5981: URL: https://github.com/apache/apisix/issues/5981#issuecomment-1003295141 1.配置一条/foo/bar 改写为 /foo的路由正则改写,绑定后端A服务 2.配置一条为/foo的路径重定向到其他路径,绑定后端B服务 3.访问/foo/bar 4.本应该跳转到A服务,结果跳转到B服务 -- This is an automated message from the Apache Git

[GitHub] [apisix] yourgracee commented on issue #5981: request help: 剪除路径后被再次路由

2021-12-30 Thread GitBox
yourgracee commented on issue #5981: URL: https://github.com/apache/apisix/issues/5981#issuecomment-1003296100 > please provide specific cases and steps to reproduce. 1.配置一条/foo/bar 改写为 /foo的路由正则改写,绑定后端A服务 2.配置一条为/foo的路径重定向到其他路径,绑定后端B服务 3.访问/foo/bar 4.本应该跳转到A服务,结果跳转到B服务 --

[GitHub] [apisix] yourgracee edited a comment on issue #5981: request help: 剪除路径后被再次路由

2021-12-30 Thread GitBox
yourgracee edited a comment on issue #5981: URL: https://github.com/apache/apisix/issues/5981#issuecomment-1003295141 1.配置一条/foo/bar 改写为 /foo的路由正则改写,绑定后端A服务 2.配置一条为/foo的路径重定向到其他路径,绑定后端B服务 3.访问/foo/bar 4.本应该跳转到A服务,结果跳转到B服务 -- This is an automated message from the Apache Git

[GitHub] [apisix-ingress-controller] suninuni commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute

2021-12-30 Thread GitBox
suninuni commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003295147 > Can you try to run `kubectl api-resources --api-group=apisix.apache.org` ? > > ``` > $ kubectl api-resources --api-group=apisix.apache.org > NAME

[GitHub] [apisix] yourgracee commented on issue #5981: request help: 剪除路径后被再次路由

2021-12-30 Thread GitBox
yourgracee commented on issue #5981: URL: https://github.com/apache/apisix/issues/5981#issuecomment-1003295141 1.配置一条/foo/bar 改写为 /foo的路由正则改写,绑定后端A服务 2.配置一条为/foo的路径重定向到其他服务,绑定后端B服务 3.访问/foo/bar 4.本应该跳转到A服务,结果跳转到B服务 -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix] shuaijinchao commented on issue #5981: request help: 剪除路径后被再次路由

2021-12-30 Thread GitBox
shuaijinchao commented on issue #5981: URL: https://github.com/apache/apisix/issues/5981#issuecomment-1003294573 please provide specific cases and steps to reproduce. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix] spacewander commented on a change in pull request #5979: feat: add separately install support for `install-dependencies.sh`

2021-12-30 Thread GitBox
spacewander commented on a change in pull request #5979: URL: https://github.com/apache/apisix/pull/5979#discussion_r776942418 ## File path: utils/install-dependencies.sh ## @@ -125,15 +125,34 @@ function install_luarocks() { # Entry function main() { OS_NAME=$(uname -s

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute

2021-12-30 Thread GitBox
tao12345666333 commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003292591 Can you try to run `kubectl api-resources --api-group=apisix.apache.org` ? ``` $ kubectl api-resources --api-group=apisix.apache.org NAME

[GitHub] [apisix] bzp2010 commented on a change in pull request #5970: docs: add OPA plugin document

2021-12-30 Thread GitBox
bzp2010 commented on a change in pull request #5970: URL: https://github.com/apache/apisix/pull/5970#discussion_r776941626 ## File path: docs/en/latest/plugins/opa.md ## @@ -0,0 +1,275 @@ +--- +title: opa +--- + + + +## Summary + +- [**Description**](#description) +-

[GitHub] [apisix] bzp2010 commented on a change in pull request #5970: docs: add OPA plugin document

2021-12-30 Thread GitBox
bzp2010 commented on a change in pull request #5970: URL: https://github.com/apache/apisix/pull/5970#discussion_r776941462 ## File path: docs/en/latest/plugins/opa.md ## @@ -0,0 +1,275 @@ +--- +title: opa +--- + + + +## Summary + +- [**Description**](#description) +-

[GitHub] [apisix-ingress-controller] suninuni commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute

2021-12-30 Thread GitBox
suninuni commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003291552 related https://github.com/apache/apisix-ingress-controller/issues/672#issuecomment-973047308 @tao12345666333 And after I applied the new version of

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field

2021-12-30 Thread GitBox
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 #

[GitHub] [apisix-ingress-controller] suninuni opened a new issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute

2021-12-30 Thread GitBox
suninuni opened a new issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823 ### Issue description I upgraded apisixroute from v1alpha1 to v2beta1 before, so I kept `spec.http[].backend` in ApisixRoute. And now, I'm trying to upgrade

[GitHub] [apisix] yourgracee opened a new issue #5981: request help: 剪除路径后被再次路由

2021-12-30 Thread GitBox
yourgracee opened a new issue #5981: URL: https://github.com/apache/apisix/issues/5981 ### Issue description 我按照官网文档FAQ中的方法剪除路径: ![image](https://user-images.githubusercontent.com/18047268/147808855-b845ce25-0fb6-454b-8dbf-d4285fa573e6.png)

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field

2021-12-30 Thread GitBox
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 #

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field

2021-12-30 Thread GitBox
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 #

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field

2021-12-30 Thread GitBox
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 #

[GitHub] [apisix] juzhiyuan commented on a change in pull request #5970: docs: add OPA plugin document

2021-12-30 Thread GitBox
juzhiyuan commented on a change in pull request #5970: URL: https://github.com/apache/apisix/pull/5970#discussion_r776939207 ## File path: docs/en/latest/plugins/opa.md ## @@ -0,0 +1,275 @@ +--- +title: opa +--- + + + +## Summary + +- [**Description**](#description) +-

[GitHub] [apisix] spacewander opened a new pull request #5980: ci: rerun flaky tests

2021-12-30 Thread GitBox
spacewander opened a new pull request #5980: URL: https://github.com/apache/apisix/pull/5980 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what

[GitHub] [apisix] juzhiyuan commented on a change in pull request #5727: feat: add CSRF plugin

2021-12-30 Thread GitBox
juzhiyuan commented on a change in pull request #5727: URL: https://github.com/apache/apisix/pull/5727#discussion_r776939023 ## File path: docs/zh/latest/plugins/csrf.md ## @@ -65,7 +65,13 @@ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field

2021-12-30 Thread GitBox
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 #

[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2271: feat(upstream): add upstream priority field

2021-12-30 Thread GitBox
zaunist commented on a change in pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#discussion_r776938633 ## File path: api/internal/core/store/validate.go ## @@ -165,12 +165,6 @@ func checkUpstream(upstream *entity.UpstreamDef) error {

[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #104: fix: ensure correct encoding and decoding when data length is greater…

2021-12-30 Thread GitBox
tzssangglass opened a new pull request #104: URL: https://github.com/apache/apisix-java-plugin-runner/pull/104 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance

[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #103: chore: support run on macos

2021-12-30 Thread GitBox
tzssangglass opened a new pull request #103: URL: https://github.com/apache/apisix-java-plugin-runner/pull/103 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #2271: feat(upstream): add upstream priority field

2021-12-30 Thread GitBox
nic-chen commented on a change in pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#discussion_r776936358 ## File path: api/internal/core/store/validate.go ## @@ -165,12 +165,6 @@ func checkUpstream(upstream *entity.UpstreamDef) error {

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #2271: feat(upstream): add upstream priority field

2021-12-30 Thread GitBox
starsz commented on a change in pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#discussion_r776934614 ## File path: api/internal/core/store/validate.go ## @@ -165,12 +165,6 @@ func checkUpstream(upstream *entity.UpstreamDef) error {

[GitHub] [apisix-ingress-controller] crazyMonkey1995 edited a comment on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
crazyMonkey1995 edited a comment on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003280263 > > Okay, why not make an appointment next week, so I can summarize it briefly. > > Sure. Due to the holiday, how about we make an appointment

[GitHub] [apisix] leslie-tsang opened a new pull request #5979: feat: add separately install support for `install-dependencies.sh`

2021-12-30 Thread GitBox
leslie-tsang opened a new pull request #5979: URL: https://github.com/apache/apisix/pull/5979 ### What this PR does / why we need it: Add separately install support for [install-dependencies.sh](https://github.com/apache/apisix/blob/master/utils/install-dependencies.sh) Ref

[GitHub] [apisix-ingress-controller] crazyMonkey1995 commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
crazyMonkey1995 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003280263 > > Okay, why not make an appointment next week, so I can summarize it briefly. > > Sure. Due to the holiday, how about we make an appointment next

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #799: proposal: Add annotations to combine ApisixPluginConfig with k8s ingress resource

2021-12-30 Thread GitBox
tao12345666333 commented on issue #799: URL: https://github.com/apache/apisix-ingress-controller/issues/799#issuecomment-1003278806 Hi, ApisixPluginConfig has been implemented. See #638 for details. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field

2021-12-30 Thread GitBox
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 #

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field

2021-12-30 Thread GitBox
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 #

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field

2021-12-30 Thread GitBox
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 #

[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2271: feat(upstream): add upstream priority field

2021-12-30 Thread GitBox
zaunist commented on a change in pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#discussion_r776930378 ## File path: api/test/e2enew/upstream/upstream_priority_test.go ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #731: docs: Grafana Dashboard Configuration

2021-12-30 Thread GitBox
gxthrj merged pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[apisix-ingress-controller] branch master updated: docs: Grafana Dashboard Configuration (#731)

2021-12-30 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new ae69cd3 docs: Grafana

[GitHub] [apisix] leslie-tsang commented on issue #5976: request help: remove unused utils script

2021-12-30 Thread GitBox
leslie-tsang commented on issue #5976: URL: https://github.com/apache/apisix/issues/5976#issuecomment-1003269514 cc @membphis @nic-chen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
tao12345666333 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003267993 > Okay, why not make an appointment next week, so I can summarize it briefly. Sure. Due to the holiday, how about we make an appointment next Tuesday

[GitHub] [apisix-ingress-controller] crazyMonkey1995 commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
crazyMonkey1995 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003265875 > > I want to know if you would consider combining apisix-ingress-controller with this way: [apache/apisix#4880](https://github.com/apache/apisix/pull/4880)

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #731: feat: Grafana Dashboard Configuration

2021-12-30 Thread GitBox
tao12345666333 commented on pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-1003265292 @Sindweller LGTM. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-ingress-controller] gxthrj edited a comment on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
gxthrj edited a comment on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003263080 > > > > Thanks for your report. > > > > > * your apisix-ingress-controller version (output of apisix-ingress-controller version --long): 2.11.0

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
gxthrj commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003263080 > > > > Thanks for your report. > > > > > * your apisix-ingress-controller version (output of apisix-ingress-controller version --long): 2.11.0

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
tao12345666333 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003262634 > I want to know if you would consider combining apisix-ingress-controller with this way: [apache/apisix#4880](https://github.com/apache/apisix/pull/4880)

[GitHub] [apisix-ingress-controller] crazyMonkey1995 commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
crazyMonkey1995 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003262434 > > > Thanks for your report. > > > > * your apisix-ingress-controller version (output of apisix-ingress-controller version --long): 2.11.0 > > >

[GitHub] [apisix-ingress-controller] crazyMonkey1995 commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
crazyMonkey1995 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003261711 I want to know if you would consider combining apisix-ingress-controller with this way: https://github.com/apache/apisix/pull/4880 -- This is an

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
gxthrj commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003261701 > > Thanks for your report. > > > * your apisix-ingress-controller version (output of apisix-ingress-controller version --long): 2.11.0 > > > > > >

[GitHub] [apisix-ingress-controller] crazyMonkey1995 commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
crazyMonkey1995 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003260796 > Thanks for your report. > > > * your apisix-ingress-controller version (output of apisix-ingress-controller version --long): 2.11.0

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
gxthrj commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003260571 Yes, before #706 we indeed have this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
tao12345666333 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003260112 before #706 , we using `workqueue.AddRateLimited`, this will cause some problems. >This bug is due to a workqueue shared under the same resource, and

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
tao12345666333 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003259597 Thanks for your report. > * your apisix-ingress-controller version (output of apisix-ingress-controller version --long): 2.11.0

[GitHub] [apisix-ingress-controller] crazyMonkey1995 commented on issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
crazyMonkey1995 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003259464 Maybe I’ve said too much, I just think it’s better if the service discovery is done by apisix itself -- This is an automated message from the Apache Git

[GitHub] [apisix-ingress-controller] crazyMonkey1995 opened a new issue #822: bug: CRD and Endpoint watch performance

2021-12-30 Thread GitBox
crazyMonkey1995 opened a new issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822 ### Issue description After I create 3000+ apisixroute objects in the cluster, when the apisix-ingress-controller is started or restarting(OOM Maybe), due to the rate limit

[GitHub] [apisix] juzhiyuan closed issue #5814: bug: java plugin error permission denied

2021-12-30 Thread GitBox
juzhiyuan closed issue #5814: URL: https://github.com/apache/apisix/issues/5814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #731: feat: Grafana Dashboard Configuration

2021-12-30 Thread GitBox
tao12345666333 commented on pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-1003258223 @Sindweller Thanks! It looks great to me! Please fix the markdown lint error. Then we can merge this one. -- This is an automated message from

[GitHub] [apisix] leslie-tsang commented on issue #5814: bug: java plugin error permission denied

2021-12-30 Thread GitBox
leslie-tsang commented on issue #5814: URL: https://github.com/apache/apisix/issues/5814#issuecomment-1003258203 > @juzhiyuan Consider solved. Feel free to reopen it if need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #731: feat: Grafana Dashboard Configuration

2021-12-30 Thread GitBox
tao12345666333 commented on a change in pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#discussion_r776918990 ## File path: docs/en/latest/plugins/prometheus.md ## @@ -0,0 +1,124 @@ +--- +title: prometheus +--- + + + +This guide shows how

[GitHub] [apisix-ingress-controller] Sindweller commented on a change in pull request #731: feat: Grafana Dashboard Configuration

2021-12-30 Thread GitBox
Sindweller commented on a change in pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#discussion_r776918809 ## File path: docs/en/latest/plugins/prometheus.md ## @@ -0,0 +1,124 @@ +--- +title: prometheus +--- + + + +This guide shows how to

[GitHub] [apisix-ingress-controller] Sindweller commented on a change in pull request #731: feat: Grafana Dashboard Configuration

2021-12-30 Thread GitBox
Sindweller commented on a change in pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#discussion_r776918809 ## File path: docs/en/latest/plugins/prometheus.md ## @@ -0,0 +1,124 @@ +--- +title: prometheus +--- + + + +This guide shows how to

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #821: Bugfix: fetching newest Endpoint before sync

2021-12-30 Thread GitBox
codecov-commenter commented on pull request #821: URL: https://github.com/apache/apisix-ingress-controller/pull/821#issuecomment-1003257320 #

[GitHub] [apisix-ingress-controller] chzhuo opened a new pull request #821: Bugfix: fetching newest Endpoint before sync

2021-12-30 Thread GitBox
chzhuo opened a new pull request #821: URL: https://github.com/apache/apisix-ingress-controller/pull/821 ### Type of change: - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches ### What this PR does / why we need

[GitHub] [apisix] spacewander commented on issue #1652: add support for Vault

2021-12-30 Thread GitBox
spacewander commented on issue #1652: URL: https://github.com/apache/apisix/issues/1652#issuecomment-1003254134 Solved by https://github.com/apache/apisix/pull/5745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] spacewander closed issue #1652: add support for Vault

2021-12-30 Thread GitBox
spacewander closed issue #1652: URL: https://github.com/apache/apisix/issues/1652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] spacewander commented on issue #5714: Proposal: support OpenPolicyAgent for access control

2021-12-30 Thread GitBox
spacewander commented on issue #5714: URL: https://github.com/apache/apisix/issues/5714#issuecomment-1003253957 Already done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix] spacewander closed issue #5714: Proposal: support OpenPolicyAgent for access control

2021-12-30 Thread GitBox
spacewander closed issue #5714: URL: https://github.com/apache/apisix/issues/5714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] spacewander closed issue #4301: bug: skywalking not work when upsteam timeout

2021-12-30 Thread GitBox
spacewander closed issue #4301: URL: https://github.com/apache/apisix/issues/4301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] gxthrj commented on pull request #4880: feat: add k8s discovery module

2021-12-30 Thread GitBox
gxthrj commented on pull request #4880: URL: https://github.com/apache/apisix/pull/4880#issuecomment-1003252010 > After our test, apisix-ingress-controller has many problems, so I plan to give up apisix-ingress-controller. I am looking forward to this feature very much, I wonder if you

[GitHub] [apisix] spacewander merged pull request #5971: fix: upgrade skywalking to `0.6.0`

2021-12-30 Thread GitBox
spacewander merged pull request #5971: URL: https://github.com/apache/apisix/pull/5971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[apisix] branch master updated: fix: upgrade skywalking to `0.6.0` (#5971)

2021-12-30 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new cc09ef3 fix: upgrade skywalking to

[GitHub] [apisix] spacewander commented on issue #5976: request help: remove unused utils script

2021-12-30 Thread GitBox
spacewander commented on issue #5976: URL: https://github.com/apache/apisix/issues/5976#issuecomment-1003251398 Good. Can we cc the authors of these scripts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] spacewander commented on issue #5969: Hope to add support for setting the custom host header to be used for upstream's artive checks!

2021-12-30 Thread GitBox
spacewander commented on issue #5969: URL: https://github.com/apache/apisix/issues/5969#issuecomment-1003251120 Fixed in https://github.com/apache/apisix/pull/5175? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] tao12345666333 commented on pull request #4880: feat: add k8s discovery module

2021-12-30 Thread GitBox
tao12345666333 commented on pull request #4880: URL: https://github.com/apache/apisix/pull/4880#issuecomment-1003251040 @crazyMonkey1995 If you have any questions or suggestions about this project, welcome to participate in our community bi-weekly meeting. Thanks

[GitHub] [apisix] tzssangglass commented on issue #5973: ssl是否支持双向认证?

2021-12-30 Thread GitBox
tzssangglass commented on issue #5973: URL: https://github.com/apache/apisix/issues/5973#issuecomment-1003250734 yes, and you need to use apisix-base. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] tzssangglass commented on issue #5969: Hope to add support for setting the custom host header to be used for upstream's artive checks!

2021-12-30 Thread GitBox
tzssangglass commented on issue #5969: URL: https://github.com/apache/apisix/issues/5969#issuecomment-1003250434 > > @sandy420 You can hint that the health check endpoint only accepts domain access, not ip access. > > how do it ? @tzssangglass What I mean is that you could

[GitHub] [apisix] moonming commented on pull request #4880: feat: add k8s discovery module

2021-12-30 Thread GitBox
moonming commented on pull request #4880: URL: https://github.com/apache/apisix/pull/4880#issuecomment-1003250242 > any update for this PR? can we merge this PR first? @membphis please push this PR -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] leslie-tsang opened a new issue #5976: request help: remove unused utils script

2021-12-30 Thread GitBox
leslie-tsang opened a new issue #5976: URL: https://github.com/apache/apisix/issues/5976 ### Issue description Currently, some utility scripts no longer fit the master branch and we should remove them to make sure no one gets confused. ## Solution > unused utils script

[GitHub] [apisix] tao12345666333 commented on pull request #4880: feat: add k8s discovery module

2021-12-30 Thread GitBox
tao12345666333 commented on pull request #4880: URL: https://github.com/apache/apisix/pull/4880#issuecomment-1003250011 > apisix-ingress-controller has many problems @crazyMonkey1995 Have you submitted an issue to the apisix-ingress-controller project? What problem did you

[GitHub] [apisix] Baoyuantop commented on a change in pull request #5727: feat: add CSRF plugin

2021-12-30 Thread GitBox
Baoyuantop commented on a change in pull request #5727: URL: https://github.com/apache/apisix/pull/5727#discussion_r776914120 ## File path: apisix/plugins/csrf.lua ## @@ -0,0 +1,168 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] membphis commented on pull request #4880: feat: add k8s discovery module

2021-12-30 Thread GitBox
membphis commented on pull request #4880: URL: https://github.com/apache/apisix/pull/4880#issuecomment-1003248676 > After our test, apisix-ingress-controller has many problems, so I plan to give up apisix-ingress-controller. I am looking forward to this feature very much, I wonder if you

[GitHub] [apisix-python-plugin-runner] shuaijinchao commented on issue #37: How can i get request body from this plugin ?

2021-12-30 Thread GitBox
shuaijinchao commented on issue #37: URL: https://github.com/apache/apisix-python-plugin-runner/issues/37#issuecomment-1003248668 > do we have any plan about this feature? Yes, we will support it in subsequent versions. -- This is an automated message from the Apache Git Service.

[GitHub] [apisix-python-plugin-runner] shuaijinchao commented on issue #37: How can i get request body from this plugin ?

2021-12-30 Thread GitBox
shuaijinchao commented on issue #37: URL: https://github.com/apache/apisix-python-plugin-runner/issues/37#issuecomment-1003248563 > And I have one more question. Following the example of the stop plugin, I called self.stop() and rewrote Response.body. Why is nothing displayed in the

[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2271: feat(upstream): add upstream priority field

2021-12-30 Thread GitBox
zaunist commented on a change in pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#discussion_r776911080 ## File path: api/test/e2enew/upstream/upstream_priority_test.go ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix] sandy420 commented on issue #5969: Hope to add support for setting the custom host header to be used for upstream's artive checks!

2021-12-30 Thread GitBox
sandy420 commented on issue #5969: URL: https://github.com/apache/apisix/issues/5969#issuecomment-1003243580 > @sandy420 You can hint that the health check endpoint only accepts domain access, not ip access. how do it ? @tzssangglass -- This is an automated message from the

[GitHub] [apisix] leslie-tsang commented on issue #5855: bug: unambiguous fully-qualified domain name(FQDN), i.e. ended in a dot.

2021-12-30 Thread GitBox
leslie-tsang commented on issue #5855: URL: https://github.com/apache/apisix/issues/5855#issuecomment-1003243278 Hello there, @dickens7 Would you submit a PR to fix it ? Here is an [example](https://github.com/apache/apisix/pull/5971) -- This is an automated message from the Apache

  1   2   >