[GitHub] [apisix] bzp2010 commented on a diff in pull request #7028: feat: add pubsub framework

2022-05-11 Thread GitBox
bzp2010 commented on code in PR #7028: URL: https://github.com/apache/apisix/pull/7028#discussion_r871009445 ## docs/zh/latest/pubsub.md: ## @@ -0,0 +1,248 @@ +--- +title: 发布订阅框架 +keywords: + - APISIX + - Pub-Sub +description: This document contains information about the Apach

[apisix-website] branch master updated: Revert "fix: rm trailing slash (#1083)" (#1086)

2022-05-11 Thread guoqi
This is an automated email from the ASF dual-hosted git repository. guoqi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 1abadbe3a74 Revert "fix: rm trailing slas

[GitHub] [apisix-website] guoqqqi merged pull request #1086: revert "fix: rm trailing slash"

2022-05-11 Thread GitBox
guoqqqi merged PR #1086: URL: https://github.com/apache/apisix-website/pull/1086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [apisix-website] juzhiyuan opened a new pull request, #1086: Revert "fix: rm trailing slash"

2022-05-11 Thread GitBox
juzhiyuan opened a new pull request, #1086: URL: https://github.com/apache/apisix-website/pull/1086 Reverts apache/apisix-website#1083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix] zhixiongdu027 commented on issue #7026: help request: Set upstream discovery kubernetes type not work.

2022-05-11 Thread GitBox
zhixiongdu027 commented on issue #7026: URL: https://github.com/apache/apisix/issues/7026#issuecomment-1124603325 Did you see any other logs printed by Kubernetes Discovery, In the debug log mode, kubernetes discovery will print the endpoins information every time it listens https

[GitHub] [apisix-website] netlify[bot] commented on pull request #1086: Revert "fix: rm trailing slash"

2022-05-11 Thread GitBox
netlify[bot] commented on PR #1086: URL: https://github.com/apache/apisix-website/pull/1086#issuecomment-1124603603 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest commit | 0bb52000

[apisix-website] branch revert-1083-try-fix-trailing-slash created (now 0bb520001e4)

2022-05-11 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch revert-1083-try-fix-trailing-slash in repository https://gitbox.apache.org/repos/asf/apisix-website.git at 0bb520001e4 Revert "fix: rm trailing slash (#1083)" This branch includes the f

[apisix-website] 01/01: Revert "fix: rm trailing slash (#1083)"

2022-05-11 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch revert-1083-try-fix-trailing-slash in repository https://gitbox.apache.org/repos/asf/apisix-website.git commit 0bb520001e440a336a06f512ccc93c1c3991f62b Author: 琚致远 AuthorDate: Thu May 12 14:55

[GitHub] [apisix-helm-chart] zhangyihong opened a new issue, #282: etcd的三个POD之一,一直报错重启

2022-05-11 Thread GitBox
zhangyihong opened a new issue, #282: URL: https://github.com/apache/apisix-helm-chart/issues/282 k8s环境: 1. AWS宁夏区 eks ``` kubectl version --short Client Version: v1.19.6-eks-49a6c0 Server Version: v1.20.15-eks-0d102a7 ``` 2. chart版本: ``` helm list -n ingress-ap

[GitHub] [apisix] bzp2010 commented on a diff in pull request #7028: feat: add pubsub framework

2022-05-11 Thread GitBox
bzp2010 commented on code in PR #7028: URL: https://github.com/apache/apisix/pull/7028#discussion_r871008364 ## docs/zh/latest/pubsub.md: ## @@ -0,0 +1,248 @@ +--- +title: 发布订阅框架 +keywords: + - APISIX + - Pub-Sub +description: This document contains information about the Apach

[GitHub] [apisix] sweetpotatoman commented on issue #7026: help request: Set upstream discovery kubernetes type not work.

2022-05-11 Thread GitBox
sweetpotatoman commented on issue #7026: URL: https://github.com/apache/apisix/issues/7026#issuecomment-1124583523 > > log message > > ``` > > 2022/05/12 03:37:55 [info] 43#43: *35664 [lua] init.lua:317: nodes(): get empty endpoint version from discovery DICT testnet/explorer-reader, c

[GitHub] [apisix] zzq926083010 commented on issue #7034: help request: failed to install CRD crds/customresourcedefinitions.yaml

2022-05-11 Thread GitBox
zzq926083010 commented on issue #7034: URL: https://github.com/apache/apisix/issues/7034#issuecomment-1124580371 我的k8s版本是1.14.10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [apisix] zzq926083010 opened a new issue, #7034: help request: failed to install CRD crds/customresourcedefinitions.yaml

2022-05-11 Thread GitBox
zzq926083010 opened a new issue, #7034: URL: https://github.com/apache/apisix/issues/7034 ### Description 执行:helm install apisix-ingress-controller apisix/apisix-ingress-controller --namespace apisix --set config.apisix.serviceName=apisix-dashboard --set ingress-controller.enabled=t

[GitHub] [apisix] crazyMonkey1995 commented on a diff in pull request #6988: feat(real-ip): support search recursive

2022-05-11 Thread GitBox
crazyMonkey1995 commented on code in PR #6988: URL: https://github.com/apache/apisix/pull/6988#discussion_r870989643 ## apisix/plugins/real-ip.lua: ## @@ -67,6 +73,19 @@ function _M.check_schema(conf) end +local function addr_match(conf, addr) +if not conf.trusted_addre

[GitHub] [apisix-helm-chart] tao12345666333 opened a new pull request, #281: chore: upgrade APISIX Ingress v1.4.1

2022-05-11 Thread GitBox
tao12345666333 opened a new pull request, #281: URL: https://github.com/apache/apisix-helm-chart/pull/281 Signed-off-by: Jintao Zhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-website] github-actions[bot] commented on pull request #1079: docs:add weekly report 4.15-4.30

2022-05-11 Thread GitBox
github-actions[bot] commented on PR #1079: URL: https://github.com/apache/apisix-website/pull/1079#issuecomment-1124563678 🚀 Deployed on https://627ca1d97953ed1fc8550418--apache-apisix.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [apisix] juzhiyuan commented on a diff in pull request #7030: docs: update "Traffic" Plugin docs 1

2022-05-11 Thread GitBox
juzhiyuan commented on code in PR #7030: URL: https://github.com/apache/apisix/pull/7030#discussion_r870977301 ## docs/en/latest/plugins/limit-count.md: ## @@ -23,33 +29,33 @@ title: limit-count ## Description -Limit request rate by a fixed number of requests in a given tim

[GitHub] [apisix] juzhiyuan commented on a diff in pull request #7030: docs: update "Traffic" Plugin docs 1

2022-05-11 Thread GitBox
juzhiyuan commented on code in PR #7030: URL: https://github.com/apache/apisix/pull/7030#discussion_r870976933 ## docs/en/latest/plugins/limit-conn.md: ## @@ -93,17 +99,19 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f13 }' ``` -You also c

[GitHub] [apisix-website] juzhiyuan closed issue #1085: [Site]: Mobile can not load the home page style

2022-05-11 Thread GitBox
juzhiyuan closed issue #1085: [Site]: Mobile can not load the home page style URL: https://github.com/apache/apisix-website/issues/1085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [apisix-website] juzhiyuan commented on issue #1085: [Site]: Mobile can not load the home page style

2022-05-11 Thread GitBox
juzhiyuan commented on issue #1085: URL: https://github.com/apache/apisix-website/issues/1085#issuecomment-1124561732 After jsDelivr is banned by GFW, there have been no public better ways to accelerate static files so far. I will close this issue and link it to another open one. ht

[GitHub] [apisix] sweetpotatoman commented on issue #7026: help request: Set upstream discovery kubernetes type not work.

2022-05-11 Thread GitBox
sweetpotatoman commented on issue #7026: URL: https://github.com/apache/apisix/issues/7026#issuecomment-1124561326 > > log message > > ``` > > 2022/05/12 03:37:55 [info] 43#43: *35664 [lua] init.lua:317: nodes(): get empty endpoint version from discovery DICT testnet/explorer-reader, c

[apisix-website] branch master updated: fix: rm trailing slash (#1083)

2022-05-11 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 2313426bab0 fix: rm trailing slash (#

[GitHub] [apisix-website] juzhiyuan merged pull request #1083: fix: rm trailing slash

2022-05-11 Thread GitBox
juzhiyuan merged PR #1083: URL: https://github.com/apache/apisix-website/pull/1083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [apisix-dashboard] gymgym1212 commented on issue #2427: [doc] How about adding a line in the dev-doc to prompt developers to ignore the error about node-gyp?

2022-05-11 Thread GitBox
gymgym1212 commented on issue #2427: URL: https://github.com/apache/apisix-dashboard/issues/2427#issuecomment-1124559969 > Sure! Could you please file a PR and add it https://apisix.apache.org/docs/dashboard/develop here? OK~ -- This is an automated message from the Apache Git Ser

[GitHub] [apisix] zhixiongdu027 commented on issue #7026: help request: Set upstream discovery kubernetes type not work.

2022-05-11 Thread GitBox
zhixiongdu027 commented on issue #7026: URL: https://github.com/apache/apisix/issues/7026#issuecomment-1124555189 > log message > > ``` > 2022/05/12 03:37:55 [info] 43#43: *35664 [lua] init.lua:317: nodes(): get empty endpoint version from discovery DICT testnet/explorer-reader, cl

[GitHub] [apisix-website] SkyeYoung commented on issue #1085: [Site]: Mobile can not load the home page style

2022-05-11 Thread GitBox
SkyeYoung commented on issue #1085: URL: https://github.com/apache/apisix-website/issues/1085#issuecomment-1124551068 cc @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [apisix-website] SkyeYoung commented on issue #1085: [Site]: Mobile can not load the home page style

2022-05-11 Thread GitBox
SkyeYoung commented on issue #1085: URL: https://github.com/apache/apisix-website/issues/1085#issuecomment-1124550909 This is because we don't have a CDN in China anymore, you may need a proxy software. -- This is an automated message from the Apache Git Service. To respond to the messag

[apisix-website] branch asf-site updated (b0a131b39c4 -> a8032f7383f)

2022-05-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git discard b0a131b39c4 deploy: c31dffdf978f140dace30904b17fdef18b7bf008 new a8032f7383f deploy: c31dffdf978f14

[GitHub] [apisix-website] oil-oil opened a new issue, #1085: [Site]: Mobile can not load the home page style

2022-05-11 Thread GitBox
oil-oil opened a new issue, #1085: URL: https://github.com/apache/apisix-website/issues/1085 ### Current State When I open the apisix website from my phone, the home page is gray and the collapsed bar in the upper left corner is not clickable ![image](https://user-images.githu

[GitHub] [apisix] membphis commented on a diff in pull request #7028: feat: add pubsub framework

2022-05-11 Thread GitBox
membphis commented on code in PR #7028: URL: https://github.com/apache/apisix/pull/7028#discussion_r870949550 ## docs/zh/latest/pubsub.md: ## @@ -0,0 +1,248 @@ +--- +title: 发布订阅框架 +keywords: + - APISIX + - Pub-Sub +description: This document contains information about the Apac

[GitHub] [apisix] spacewander commented on a diff in pull request #6988: feat(real-ip): support search recursive

2022-05-11 Thread GitBox
spacewander commented on code in PR #6988: URL: https://github.com/apache/apisix/pull/6988#discussion_r870949710 ## apisix/plugins/real-ip.lua: ## @@ -67,6 +73,19 @@ function _M.check_schema(conf) end +local function addr_match(conf, addr) +if not conf.trusted_addresses

[GitHub] [apisix-website] navendu-pottekkat commented on issue #1084: [Site]: Add lightbox to display images

2022-05-11 Thread GitBox
navendu-pottekkat commented on issue #1084: URL: https://github.com/apache/apisix-website/issues/1084#issuecomment-1124521982 @SkyeYoung Here you go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-website] navendu-pottekkat opened a new issue, #1084: [Site]: Add lightbox to display images

2022-05-11 Thread GitBox
navendu-pottekkat opened a new issue, #1084: URL: https://github.com/apache/apisix-website/issues/1084 ### Current State **Description of the current state/issue**: Currently, to zoom in to an image, users have to open just the image in a new tab. This makes it difficult

[GitHub] [apisix-ingress-controller] elvis-cai commented on pull request #726: feat: add externalname support for upstream

2022-05-11 Thread GitBox
elvis-cai commented on PR #726: URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-1124519728 I am more looking forward to the feature https://github.com/apache/apisix-ingress-controller/issues/927, but sounds good to me , before that's implemented, will look at

[GitHub] [apisix-website] github-actions[bot] commented on pull request #1083: fix: rm trailing slash

2022-05-11 Thread GitBox
github-actions[bot] commented on PR #1083: URL: https://github.com/apache/apisix-website/pull/1083#issuecomment-1124502218 🚀 Deployed on https://627c83766071c30c3a8a17f8--apache-apisix.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [apisix] sweetpotatoman commented on issue #7026: help request: Set upstream discovery kubernetes type not work.

2022-05-11 Thread GitBox
sweetpotatoman commented on issue #7026: URL: https://github.com/apache/apisix/issues/7026#issuecomment-1124499372 > > When the log returns `no valid upstream node: nil`, we are not quite sure what's wrong. > > Why are we still unable to find upstream node with this configuration? >

[GitHub] [apisix] crazyMonkey1995 commented on a diff in pull request #6988: feat(real-ip): support search recursive

2022-05-11 Thread GitBox
crazyMonkey1995 commented on code in PR #6988: URL: https://github.com/apache/apisix/pull/6988#discussion_r870919916 ## apisix/plugins/real-ip.lua: ## @@ -67,6 +73,19 @@ function _M.check_schema(conf) end +local function addr_match(conf, addr) +if not conf.trusted_addre

[GitHub] [apisix] navendu-pottekkat commented on pull request #7030: docs: update "Traffic" Plugin docs 1

2022-05-11 Thread GitBox
navendu-pottekkat commented on PR #7030: URL: https://github.com/apache/apisix/pull/7030#issuecomment-1124498144 > Others LGTM. BTW, @navendu-pottekkat, some community users report that they will get confused by the How to use section because they use Dashboard but follow AdminAPI's Docs. M

[GitHub] [apisix] navendu-pottekkat commented on a diff in pull request #7030: docs: update "Traffic" Plugin docs 1

2022-05-11 Thread GitBox
navendu-pottekkat commented on code in PR #7030: URL: https://github.com/apache/apisix/pull/7030#discussion_r870919414 ## docs/en/latest/plugins/limit-count.md: ## @@ -23,33 +29,33 @@ title: limit-count ## Description -Limit request rate by a fixed number of requests in a g

[GitHub] [apisix] spacewander commented on a diff in pull request #7006: feat(ops): check process running with posix.signal insteadof lsof

2022-05-11 Thread GitBox
spacewander commented on code in PR #7006: URL: https://github.com/apache/apisix/pull/7006#discussion_r870918835 ## apisix/cli/ops.lua: ## @@ -728,14 +730,16 @@ local function start(env, ...) local pid = util.read_file(pid_path) pid = tonumber(pid) if pid then -

[GitHub] [apisix-website] netlify[bot] commented on pull request #1083: fix: rm trailing slash

2022-05-11 Thread GitBox
netlify[bot] commented on PR #1083: URL: https://github.com/apache/apisix-website/pull/1083#issuecomment-1124497216 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest commit | bb3ed46e

[GitHub] [apisix-website] SkyeYoung opened a new pull request, #1083: fix: rm trailing slash

2022-05-11 Thread GitBox
SkyeYoung opened a new pull request, #1083: URL: https://github.com/apache/apisix-website/pull/1083 Fixes: #[Add issue number here] Changes: Screenshots of the change: -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] navendu-pottekkat commented on a diff in pull request #7030: docs: update "Traffic" Plugin docs 1

2022-05-11 Thread GitBox
navendu-pottekkat commented on code in PR #7030: URL: https://github.com/apache/apisix/pull/7030#discussion_r870918952 ## docs/en/latest/plugins/limit-conn.md: ## @@ -93,17 +99,19 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f13 }' ``` -Yo

[GitHub] [apisix] navendu-pottekkat commented on a diff in pull request #7022: docs: update Chinese getting started doc

2022-05-11 Thread GitBox
navendu-pottekkat commented on code in PR #7022: URL: https://github.com/apache/apisix/pull/7022#discussion_r870918563 ## docs/zh/latest/getting-started.md: ## @@ -126,17 +191,13 @@ curl "http://127.0.0.1:9080/apisix/admin/services/"; -H 'X-API-KEY: edd1c9f034335 } ``` -##

[apisix-helm-chart] branch gh-pages updated: Update index.yaml

2022-05-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch gh-pages in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/gh-pages by this push: new 314cd8d Update index.yaml 31

[apisix-helm-chart] tag apisix-ingress-controller-0.9.1 created (now fa2191e)

2022-05-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag apisix-ingress-controller-0.9.1 in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git at fa2191e (commit) No new revisions were added by this update.

[apisix-helm-chart] branch master updated: chore: upgrade apisix-ingress-controller to 1.4.1 (#280)

2022-05-11 Thread zhangjintao
This is an automated email from the ASF dual-hosted git repository. zhangjintao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new fa2191e chore: upgrade apisix-i

[GitHub] [apisix-helm-chart] tao12345666333 closed issue #279: APISIX Ingress v1.4.1 release

2022-05-11 Thread GitBox
tao12345666333 closed issue #279: APISIX Ingress v1.4.1 release URL: https://github.com/apache/apisix-helm-chart/issues/279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #280: chore: upgrade apisix-ingress-controller to 1.4.1

2022-05-11 Thread GitBox
tao12345666333 merged PR #280: URL: https://github.com/apache/apisix-helm-chart/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [apisix] bzp2010 commented on a diff in pull request #7028: feat: add pubsub framework

2022-05-11 Thread GitBox
bzp2010 commented on code in PR #7028: URL: https://github.com/apache/apisix/pull/7028#discussion_r870915900 ## apisix/core/pubsub.lua: ## @@ -0,0 +1,200 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NO

[GitHub] [apisix] bzp2010 commented on a diff in pull request #7028: feat: add pubsub framework

2022-05-11 Thread GitBox
bzp2010 commented on code in PR #7028: URL: https://github.com/apache/apisix/pull/7028#discussion_r870915770 ## docs/en/latest/pubsub.md: ## @@ -0,0 +1,244 @@ +--- +title: PubSub +keywords: + - APISIX + - Pub-Sub +description: This document contains information about the Apach

[GitHub] [apisix] bzp2010 commented on a diff in pull request #7028: feat: add pubsub framework

2022-05-11 Thread GitBox
bzp2010 commented on code in PR #7028: URL: https://github.com/apache/apisix/pull/7028#discussion_r870915666 ## docs/en/latest/pubsub.md: ## @@ -0,0 +1,244 @@ +--- +title: PubSub +keywords: + - APISIX + - Pub-Sub +description: This document contains information about the Apach

[GitHub] [apisix] spacewander commented on a diff in pull request #6988: feat(real-ip): support search recursive

2022-05-11 Thread GitBox
spacewander commented on code in PR #6988: URL: https://github.com/apache/apisix/pull/6988#discussion_r870915504 ## apisix/plugins/real-ip.lua: ## @@ -67,6 +73,19 @@ function _M.check_schema(conf) end +local function addr_match(conf, addr) +if not conf.trusted_addresses

[GitHub] [apisix] zhangyihong commented on issue #6419: bug: One of the three PODs of etcd, has been reporting an error and restarting.

2022-05-11 Thread GitBox
zhangyihong commented on issue #6419: URL: https://github.com/apache/apisix/issues/6419#issuecomment-1124488112 I have the same problem. How to fix it? apisix: apache/apisix:2.13.1-alpine etcd: bitnami/etcd:3.4.18-debian-10-r14 -- This is an automated message from the Apache

[GitHub] [apisix] tzssangglass commented on a diff in pull request #7028: feat: add pubsub framework

2022-05-11 Thread GitBox
tzssangglass commented on code in PR #7028: URL: https://github.com/apache/apisix/pull/7028#discussion_r870896543 ## apisix/core/pubsub.lua: ## @@ -0,0 +1,200 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See t

[GitHub] [apisix] bzp2010 opened a new pull request, #7032: feat: support kafka pubsub

2022-05-11 Thread GitBox
bzp2010 opened a new pull request, #7032: URL: https://github.com/apache/apisix/pull/7032 ### Description Provide kafka implementation on pubsub framework. Split from #6995 ### Checklist - [x] I have explained the need for this PR and the problem it sol

[GitHub] [apisix-ingress-controller] hyt05 commented on issue #941: bug: ingress controller pod crashes when ingress is deleted

2022-05-11 Thread GitBox
hyt05 commented on issue #941: URL: https://github.com/apache/apisix-ingress-controller/issues/941#issuecomment-1124471303 Is there any way to fix it temporarily, our environment is now paralyzed, and the upgrade to 1.4.1 still reports this error -- This is an automated message from the

[GitHub] [apisix] spacewander opened a new pull request, #7031: feat(redis): support pubsub

2022-05-11 Thread GitBox
spacewander opened a new pull request, #7031: URL: https://github.com/apache/apisix/pull/7031 Signed-off-by: spacewander ### Description Fixes # (issue) ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [x] I have

[GitHub] [apisix] tzssangglass commented on issue #7026: help request: Set upstream discovery kubernetes type not work.

2022-05-11 Thread GitBox
tzssangglass commented on issue #7026: URL: https://github.com/apache/apisix/issues/7026#issuecomment-1124461590 > When the log returns `no valid upstream node: nil`, we are not quite sure what's wrong. > Why are we still unable to find upstream node with this configuration? Are th

[GitHub] [apisix] moonming commented on a diff in pull request #7029: docs: update description of how to join slack

2022-05-11 Thread GitBox
moonming commented on code in PR #7029: URL: https://github.com/apache/apisix/pull/7029#discussion_r870891743 ## README.md: ## @@ -43,7 +43,7 @@ The technical architecture of Apache APISIX: - Mailing List: Mail to dev-subscr...@apisix.apache.org, follow the reply to subscrib

[GitHub] [apisix] spacewander commented on pull request #7028: feat: add pubsub framework

2022-05-11 Thread GitBox
spacewander commented on PR #7028: URL: https://github.com/apache/apisix/pull/7028#issuecomment-1124460661 > ### Update > > The current pubsub module switches to use the pubsub module-level independent `pb_state` database, just like the `pb_state` cached in lrucache in `grpc-transcod

[GitHub] [apisix] hf400159 commented on a diff in pull request #7022: docs: update Chinese getting started doc

2022-05-11 Thread GitBox
hf400159 commented on code in PR #7022: URL: https://github.com/apache/apisix/pull/7022#discussion_r870890690 ## docs/zh/latest/getting-started.md: ## @@ -126,17 +191,13 @@ curl "http://127.0.0.1:9080/apisix/admin/services/"; -H 'X-API-KEY: edd1c9f034335 } ``` -## 第二步:创建路由

[GitHub] [apisix] hf400159 commented on a diff in pull request #7022: docs: update Chinese getting started doc

2022-05-11 Thread GitBox
hf400159 commented on code in PR #7022: URL: https://github.com/apache/apisix/pull/7022#discussion_r870889172 ## docs/zh/latest/getting-started.md: ## @@ -68,51 +109,75 @@ curl --location --request GET "http://httpbin.org/get?foo1=bar1&foo2=bar2"; } ``` -## 前提条件 +## 安装 APIS

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2427: [doc] How about adding a line in the dev-doc to prompt developers to ignore the error about node-gyp?

2022-05-11 Thread GitBox
juzhiyuan commented on issue #2427: URL: https://github.com/apache/apisix-dashboard/issues/2427#issuecomment-1124457753 Sure! Could you please file a PR and add it https://apisix.apache.org/docs/dashboard/develop here? -- This is an automated message from the Apache Git Service. To respo

[apisix] branch master updated: feat(xRPC): support log filter (#6960)

2022-05-11 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 935e62f22 feat(xRPC): support log filter (#

[GitHub] [apisix] spacewander merged pull request #6960: feat(xRPC): support log filter

2022-05-11 Thread GitBox
spacewander merged PR #6960: URL: https://github.com/apache/apisix/pull/6960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[apisix] branch master updated: docs: add unit to upstream timeout (#7027)

2022-05-11 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 0957035c1 docs: add unit to upstream timeou

[GitHub] [apisix] spacewander merged pull request #7027: docs: add unit to upstream timeout

2022-05-11 Thread GitBox
spacewander merged PR #7027: URL: https://github.com/apache/apisix/pull/7027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2407: bug: The copy function copied the ID, resulting in duplicate ID and unable to submit

2022-05-11 Thread GitBox
juzhiyuan commented on issue #2407: URL: https://github.com/apache/apisix-dashboard/issues/2407#issuecomment-1124456971 Hi @bzp2010, do you have any update here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix] branch master updated: build(deps): bump apache/skywalking-eyes from 0.2.0 to 0.3.0 (#7024)

2022-05-11 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 96a5d3ca6 build(deps): bump apache/skywalki

[GitHub] [apisix] spacewander merged pull request #7024: build(deps): bump apache/skywalking-eyes from 0.2.0 to 0.3.0

2022-05-11 Thread GitBox
spacewander merged PR #7024: URL: https://github.com/apache/apisix/pull/7024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] tzssangglass commented on issue #7019: help request: How to make it possible for some source ip to access only some open apis

2022-05-11 Thread GitBox
tzssangglass commented on issue #7019: URL: https://github.com/apache/apisix/issues/7019#issuecomment-1124455491 > I've seen this but to meet my requirements I need to blacklist the banned api's which is too costly as there are only a few whiteliste api If you want to do that: allow o

[GitHub] [apisix] juzhiyuan commented on issue #6912: docs: Optimize the table structure in plugin documentation.

2022-05-11 Thread GitBox
juzhiyuan commented on issue #6912: URL: https://github.com/apache/apisix/issues/6912#issuecomment-1124454099 I would prefer keeping this column because it's much more straightforward :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] juzhiyuan commented on a diff in pull request #7022: docs: update Chinese getting started doc

2022-05-11 Thread GitBox
juzhiyuan commented on code in PR #7022: URL: https://github.com/apache/apisix/pull/7022#discussion_r870878662 ## docs/zh/latest/getting-started.md: ## @@ -21,25 +26,61 @@ title: 快速入门指南 # --> -## 概述 +import Tabs from '@theme/Tabs'; +import TabItem from '@theme/TabItem'; -本

[GitHub] [apisix] crazyMonkey1995 commented on a diff in pull request #6988: feat(real-ip): support search recursive

2022-05-11 Thread GitBox
crazyMonkey1995 commented on code in PR #6988: URL: https://github.com/apache/apisix/pull/6988#discussion_r870879873 ## apisix/plugins/real-ip.lua: ## @@ -84,6 +103,17 @@ local function get_addr(conf, ctx) return addrs end +if conf.recursive and c

[GitHub] [apisix] soulbird commented on a diff in pull request #6988: feat(real-ip): support search recursive

2022-05-11 Thread GitBox
soulbird commented on code in PR #6988: URL: https://github.com/apache/apisix/pull/6988#discussion_r870874491 ## apisix/plugins/real-ip.lua: ## @@ -84,6 +103,17 @@ local function get_addr(conf, ctx) return addrs end +if conf.recursive and conf.tru

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #143: bug: setBody not work

2022-05-11 Thread GitBox
tzssangglass commented on issue #143: URL: https://github.com/apache/apisix-java-plugin-runner/issues/143#issuecomment-112264 > Get the orginal content see: https://github.com/apache/apisix-java-plugin-runner/blob/main/docs/en/latest/development.md#write-filter ``` @O

[GitHub] [apisix] juzhiyuan commented on a diff in pull request #7030: docs: update "Traffic" Plugin docs 1

2022-05-11 Thread GitBox
juzhiyuan commented on code in PR #7030: URL: https://github.com/apache/apisix/pull/7030#discussion_r870873912 ## docs/en/latest/plugins/limit-conn.md: ## @@ -93,17 +99,19 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f13 }' ``` -You also c

[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #142: request help: Get I get the tcp stream in java plugin?

2022-05-11 Thread GitBox
tzssangglass closed issue #142: request help: Get I get the tcp stream in java plugin? URL: https://github.com/apache/apisix-java-plugin-runner/issues/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #142: request help: Get I get the tcp stream in java plugin?

2022-05-11 Thread GitBox
tzssangglass commented on issue #142: URL: https://github.com/apache/apisix-java-plugin-runner/issues/142#issuecomment-1124443032 > 我如何能够获取tcp数据? 比如websocket流,mqtt流。 not support, the plugin runner only works at the HTTP level. -- This is an automated message from the Apache Git Ser

[GitHub] [apisix] crazyMonkey1995 commented on a diff in pull request #6988: feat(real-ip): support search recursive

2022-05-11 Thread GitBox
crazyMonkey1995 commented on code in PR #6988: URL: https://github.com/apache/apisix/pull/6988#discussion_r870873211 ## apisix/plugins/real-ip.lua: ## @@ -106,7 +106,7 @@ local function get_addr(conf, ctx) if conf.recursive and conf.trusted_addresses then

[GitHub] [apisix] juzhiyuan commented on pull request #7030: docs: update "Traffic" Plugin docs 1

2022-05-11 Thread GitBox
juzhiyuan commented on PR #7030: URL: https://github.com/apache/apisix/pull/7030#issuecomment-1124438545 cc @hf400159 @kwanhur @avinal @yzeng25 also to have a review~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] tzssangglass commented on issue #5966: doc: benchmark results is not so good,what is the problem,help

2022-05-11 Thread GitBox
tzssangglass commented on issue #5966: URL: https://github.com/apache/apisix/issues/5966#issuecomment-1124436394 > Maybe I can add a little more guides on how to run the benchmark and get the Flame diagram? I don't think it's necessary, it's not about benchmark. If you wish, you can

[GitHub] [apisix] tokers commented on issue #7018: help request: The gateway is forwarding websockets to upstream and I find this latency particularly high, does anyone know the configuration that sho

2022-05-11 Thread GitBox
tokers commented on issue #7018: URL: https://github.com/apache/apisix/issues/7018#issuecomment-1124427015 > > what is the mean the latency here ? > > upstream_latency: time consumed by upstream services to process requests > > But I'm not sure if this metric is meaningful in th

[GitHub] [apisix] bzp2010 commented on pull request #7028: feat: add pubsub framework

2022-05-11 Thread GitBox
bzp2010 commented on PR #7028: URL: https://github.com/apache/apisix/pull/7028#issuecomment-1124109788 ### Update The current pubsub module switches to use the pubsub module-level independent `pb_state` database, just like the `pb_state` cached in lrucache in `grpc-transcode`, which

[GitHub] [apisix-website] EstelleRao commented on a diff in pull request #1064: docs: add a contributor interview blog

2022-05-11 Thread GitBox
EstelleRao commented on code in PR #1064: URL: https://github.com/apache/apisix-website/pull/1064#discussion_r870533492 ## website/i18n/zh/docusaurus-plugin-content-blog/2022/04/29/interview-juzhiyuan-apache-member.md: ## @@ -0,0 +1,278 @@ +--- +title: "琚致远:95 后 Apache Member 的成

[GitHub] [apisix-website] EstelleRao commented on a diff in pull request #1064: docs: add a contributor interview blog

2022-05-11 Thread GitBox
EstelleRao commented on code in PR #1064: URL: https://github.com/apache/apisix-website/pull/1064#discussion_r870530303 ## website/blog/2022/04/29/interview-juzhiyuan-apache-member.md: ## @@ -0,0 +1,340 @@ +--- +title: "Interview with JU Zhiyuan: Becoming One of the 918 ASF Memb

[GitHub] [apisix-ingress-controller] BrandonArp commented on pull request #726: feat: add externalname support for upstream

2022-05-11 Thread GitBox
BrandonArp commented on PR #726: URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-1123962592 This looks like a great feature and I'm really looking forward to having it merged. Is there something I can do to help move it along? -- This is an automated messag

[apisix] branch master updated: docs: update description of how to join slack (#7029)

2022-05-11 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 7cb2af7f7 docs: update description of how t

[GitHub] [apisix] spacewander merged pull request #7029: docs: update description of how to join slack

2022-05-11 Thread GitBox
spacewander merged PR #7029: URL: https://github.com/apache/apisix/pull/7029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] yunwei37 commented on issue #5966: doc: benchmark results is not so good,what is the problem,help

2022-05-11 Thread GitBox
yunwei37 commented on issue #5966: URL: https://github.com/apache/apisix/issues/5966#issuecomment-1123791036 @tzssangglass Thank you! I'd like to do following things: 1. As described above: https://github.com/apache/apisix/issues/5966#issuecomment-1006105454, I need to add @membphis

[GitHub] [apisix] Canonical10 commented on issue #6672: Proposal: create a style guide to ensure consistency in documentation

2022-05-11 Thread GitBox
Canonical10 commented on issue #6672: URL: https://github.com/apache/apisix/issues/6672#issuecomment-1123789775 💯✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [apisix] Canonical10 commented on issue #5247: Proposal: support the upstream TLS settings for the stream subsystem

2022-05-11 Thread GitBox
Canonical10 commented on issue #5247: URL: https://github.com/apache/apisix/issues/5247#issuecomment-1123785630 ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [apisix] navendu-pottekkat opened a new pull request, #7030: docs: update "Traffic" Plugin docs 1

2022-05-11 Thread GitBox
navendu-pottekkat opened a new pull request, #7030: URL: https://github.com/apache/apisix/pull/7030 Signed-off-by: Navendu Pottekkat ### Description Updates the documentation of the "limit-req", "limit-conn", and "limit-count" Plugins. Child PR of #6734 -- This is an

[GitHub] [apisix-ingress-controller] Canonical10 commented on issue #761: CodeQL job failed on master branch

2022-05-11 Thread GitBox
Canonical10 commented on issue #761: URL: https://github.com/apache/apisix-ingress-controller/issues/761#issuecomment-1123783002 ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [apisix-ingress-controller] Canonical10 commented on issue #782: request help: APISIX Ingress Annotation Document

2022-05-11 Thread GitBox
Canonical10 commented on issue #782: URL: https://github.com/apache/apisix-ingress-controller/issues/782#issuecomment-1123773227 ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [apisix] Canonical10 commented on pull request #7029: docs: update description of how to join slack

2022-05-11 Thread GitBox
Canonical10 commented on PR #7029: URL: https://github.com/apache/apisix/pull/7029#issuecomment-1123770063 ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [apisix] Canonical10 commented on issue #5247: Proposal: support the upstream TLS settings for the stream subsystem

2022-05-11 Thread GitBox
Canonical10 commented on issue #5247: URL: https://github.com/apache/apisix/issues/5247#issuecomment-1123768296 ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [apisix] bzp2010 commented on pull request #7028: feat: add pubsub framework

2022-05-11 Thread GitBox
bzp2010 commented on PR #7028: URL: https://github.com/apache/apisix/pull/7028#issuecomment-1123681095 ### Update The pubsub module core and documentation was split to the current PR, and the review comments in #6995 have been modified. -- This is an automated message from the Apac

[GitHub] [apisix-website] SylviaBABY commented on a diff in pull request #1079: docs:add weekly report 4.15-4.30

2022-05-11 Thread GitBox
SylviaBABY commented on code in PR #1079: URL: https://github.com/apache/apisix-website/pull/1079#discussion_r870220270 ## website/blog/2022/05/10/weekly-report-0510.md: ## @@ -0,0 +1,60 @@ +--- +title: Biweekly Report|Explore the weeks of Apr 15th - Apr 30th +keywords: +- Apach

  1   2   >