[GitHub] [apisix] huacnlee opened a new pull request, #8707: Improve autocorrect

2023-01-17 Thread GitBox
huacnlee opened a new pull request, #8707: URL: https://github.com/apache/apisix/pull/8707 ### Description Fixes # (issue) ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new

[GitHub] [apisix] JohnQI8888 commented on issue #8680: help request: 是否有文档可以指导实现多环境

2023-01-17 Thread GitBox
JohnQI commented on issue #8680: URL: https://github.com/apache/apisix/issues/8680#issuecomment-1386565194 > > 支持 /* 这样的通配符吗? > > you can have a try Thanks for help, and another problem is we still work in apisix 1.6.x, I don't think it can work for us. -- This is an

[GitHub] [apisix] Fabriceli commented on a diff in pull request #8651: fix: fix fetch all service info from consul

2023-01-17 Thread GitBox
Fabriceli commented on code in PR #8651: URL: https://github.com/apache/apisix/pull/8651#discussion_r1073110176 ## apisix/discovery/consul/init.lua: ## @@ -242,48 +215,76 @@ function _M.connect(premature, consul_server, retry_delay) -- if current index different last

[GitHub] [apisix] e1ijah1 commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-17 Thread GitBox
e1ijah1 commented on code in PR #8681: URL: https://github.com/apache/apisix/pull/8681#discussion_r1073070382 ## t/cli/plugin/test_file_logger_std_output.sh: ## @@ -0,0 +1,75 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [apisix-website] netlify[bot] commented on pull request #1477: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.2

2023-01-17 Thread GitBox
netlify[bot] commented on PR #1477: URL: https://github.com/apache/apisix-website/pull/1477#issuecomment-1386453065 ###  Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| | Latest commit |

[GitHub] [apisix-website] dependabot[bot] commented on pull request #1465: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.1

2023-01-17 Thread GitBox
dependabot[bot] commented on PR #1465: URL: https://github.com/apache/apisix-website/pull/1465#issuecomment-1386452168 Superseded by #1477. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[apisix-website] branch dependabot/github_actions/peaceiris/actions-gh-pages-3.9.2 created (now 90f4dc03d06)

2023-01-17 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/peaceiris/actions-gh-pages-3.9.2 in repository https://gitbox.apache.org/repos/asf/apisix-website.git at 90f4dc03d06 chore(deps): bump

[GitHub] [apisix-website] dependabot[bot] closed pull request #1465: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.1

2023-01-17 Thread GitBox
dependabot[bot] closed pull request #1465: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.1 URL: https://github.com/apache/apisix-website/pull/1465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-website] dependabot[bot] opened a new pull request, #1477: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.2

2023-01-17 Thread GitBox
dependabot[bot] opened a new pull request, #1477: URL: https://github.com/apache/apisix-website/pull/1477 Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3.9.0 to 3.9.2. Release notes Sourced from

[GitHub] [apisix] e1ijah1 commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-17 Thread GitBox
e1ijah1 commented on code in PR #8681: URL: https://github.com/apache/apisix/pull/8681#discussion_r1073070382 ## t/cli/plugin/test_file_logger_std_output.sh: ## @@ -0,0 +1,75 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [apisix] ronething commented on pull request #8640: feat: stream subsystem support kubernetes service discovery

2023-01-17 Thread GitBox
ronething commented on PR #8640: URL: https://github.com/apache/apisix/pull/8640#issuecomment-1386445246 @tokers @soulbird Could you please take a look, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-17 Thread GitBox
shreemaan-abhishek commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1073068637 ## apisix/plugins/jwt-auth.lua: ## @@ -274,32 +234,16 @@ end local function get_rsa_or_ecdsa_keypair(conf, consumer_name) local public_key =

[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-17 Thread GitBox
shreemaan-abhishek commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1073068637 ## apisix/plugins/jwt-auth.lua: ## @@ -274,32 +234,16 @@ end local function get_rsa_or_ecdsa_keypair(conf, consumer_name) local public_key =

[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-17 Thread GitBox
shreemaan-abhishek commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1073068429 ## apisix/plugins/jwt-auth.lua: ## @@ -274,32 +234,16 @@ end local function get_rsa_or_ecdsa_keypair(conf, consumer_name) local public_key =

[GitHub] [apisix] spacewander commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-17 Thread GitBox
spacewander commented on code in PR #8681: URL: https://github.com/apache/apisix/pull/8681#discussion_r1073059505 ## apisix/plugins/file-logger.lua: ## @@ -39,7 +41,7 @@ local schema = { } } }, -required = {"path"} +required = { "path" }

[apisix-website] branch master updated: docs:add mafengwo usercase blog (#1476)

2023-01-17 Thread yilinzeng
This is an automated email from the ASF dual-hosted git repository. yilinzeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 5d6db5232b2 docs:add mafengwo

[GitHub] [apisix-website] yzeng25 merged pull request #1476: docs:add mafengwo usercase blog

2023-01-17 Thread GitBox
yzeng25 merged PR #1476: URL: https://github.com/apache/apisix-website/pull/1476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] mscb402 commented on issue #8705: feat: As a user, I want file-logger plugin support record response body in a custom format, so that make the log format more flexible

2023-01-17 Thread GitBox
mscb402 commented on issue #8705: URL: https://github.com/apache/apisix/issues/8705#issuecomment-1386436970 @spacewander -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix] mscb402 commented on issue #8705: feat: As a user, I want file-logger plugin support record response body in a custom format, so that make the log format more flexible

2023-01-17 Thread GitBox
mscb402 commented on issue #8705: URL: https://github.com/apache/apisix/issues/8705#issuecomment-1386436647 @tokers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [apisix] mscb402 opened a new issue, #8705: feat: As a user, I want file-logger plugin support record response body in a custom format, so that make the log format more flexible

2023-01-17 Thread GitBox
mscb402 opened a new issue, #8705: URL: https://github.com/apache/apisix/issues/8705 ### Description As a user, I would like the file-logger plugin to support logging the response body in a custom format to make the logging format more flexible. Currently the file-logger plugin

[GitHub] [apisix] spacewander commented on a diff in pull request #8651: fix: fix fetch all service info from consul

2023-01-17 Thread GitBox
spacewander commented on code in PR #8651: URL: https://github.com/apache/apisix/pull/8651#discussion_r1073064191 ## apisix/discovery/consul/init.lua: ## @@ -242,48 +215,76 @@ function _M.connect(premature, consul_server, retry_delay) -- if current index different last

[GitHub] [apisix] spacewander commented on issue #5453: request help: proxy-cache plugin, why the cache expiration time cannot be configured dynamically?

2023-01-17 Thread GitBox
spacewander commented on issue #5453: URL: https://github.com/apache/apisix/issues/5453#issuecomment-1386432946 It uses nginx's proxy-cache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-website] yzeng25 commented on pull request #1476: docs:add mafengwo usercase blog

2023-01-17 Thread GitBox
yzeng25 commented on PR #1476: URL: https://github.com/apache/apisix-website/pull/1476#issuecomment-1386426670 PTAL @SylviaBABY , cc @SkyeYoung @juzhiyuan . - Displayed properly under **Blog** and **Case Studies** page - Author's properties all checked valid - Blog content all

[GitHub] [apisix] e1ijah1 commented on pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-17 Thread GitBox
e1ijah1 commented on PR #8681: URL: https://github.com/apache/apisix/pull/8681#issuecomment-1386421353 > Can you add a test in https://github.com/apache/apisix/tree/master/t/cli? The test has been added. Please take a look if you're available. @spacewander -- This is an automated

[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #297: #296: added admin ingress

2023-01-17 Thread GitBox
tao12345666333 commented on PR #297: URL: https://github.com/apache/apisix-helm-chart/pull/297#issuecomment-1386418081 Hi, #442 has been merged, which allows exposing admin API through Ingress. https://github.com/apache/apisix-helm-chart/pull/442#issuecomment-1376806537 This reason

[GitHub] [apisix-helm-chart] tao12345666333 closed issue #441: feat: allow exposing admin api via ingress resource

2023-01-17 Thread GitBox
tao12345666333 closed issue #441: feat: allow exposing admin api via ingress resource URL: https://github.com/apache/apisix-helm-chart/issues/441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #441: feat: allow exposing admin api via ingress resource

2023-01-17 Thread GitBox
tao12345666333 commented on issue #441: URL: https://github.com/apache/apisix-helm-chart/issues/441#issuecomment-1386413589 ok, #442 has been merged, I will close this one, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[apisix-helm-chart] branch master updated: fix: enable tls for the tcp address (#401)

2023-01-17 Thread zhangjintao
This is an automated email from the ASF dual-hosted git repository. zhangjintao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 7e9ea8d fix: enable tls for

[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #401: fix: enable tls for the tcp address

2023-01-17 Thread GitBox
tao12345666333 merged PR #401: URL: https://github.com/apache/apisix-helm-chart/pull/401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] spacewander commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-17 Thread GitBox
spacewander commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1073050987 ## apisix/plugins/jwt-auth.lua: ## @@ -274,32 +234,16 @@ end local function get_rsa_or_ecdsa_keypair(conf, consumer_name) local public_key = conf.public_key

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #610: proposal: New architecture of Apache APISIX Ingress controller

2023-01-17 Thread GitBox
tao12345666333 commented on issue #610: URL: https://github.com/apache/apisix-ingress-controller/issues/610#issuecomment-1386361494 ![2023-01-18 09-56-25屏幕截图](https://user-images.githubusercontent.com/3264292/213062313-eb915ee9-560f-47d3-976d-94cf8f9b939a.png) I have a new idea.

[GitHub] [apisix-website] yzeng25 commented on a diff in pull request #1476: docs:add mafengwo usercase blog

2023-01-17 Thread GitBox
yzeng25 commented on code in PR #1476: URL: https://github.com/apache/apisix-website/pull/1476#discussion_r1073010881 ## blog/zh/blog/2023/01/15/mafengwo-with-apisix.md: ## @@ -0,0 +1,140 @@ +--- +title: "马蜂窝如何利用 APISIX 网关实现微服务架构升级 +" Review Comment: ```suggestion title:

[apisix] branch master updated (b440a06e0 -> 4131fbf64)

2023-01-17 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git from b440a06e0 ci: kafka should register port in the zookeeper same as exposed (#8672) add 4131fbf64 fix:

[GitHub] [apisix] spacewander closed issue #7785: bug: The `/` in the log will be added with an extra `\` when enabled file-logger and sls-logger

2023-01-17 Thread GitBox
spacewander closed issue #7785: bug: The `/` in the log will be added with an extra `\` when enabled file-logger and sls-logger URL: https://github.com/apache/apisix/issues/7785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] spacewander merged pull request #8684: fix: remove backslash before slash when encoding

2023-01-17 Thread GitBox
spacewander merged PR #8684: URL: https://github.com/apache/apisix/pull/8684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[apisix] branch master updated: ci: kafka should register port in the zookeeper same as exposed (#8672)

2023-01-17 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new b440a06e0 ci: kafka should register port

[GitHub] [apisix] spacewander merged pull request #8672: ci: kafka should register port in the zookeeper same as exposed

2023-01-17 Thread GitBox
spacewander merged PR #8672: URL: https://github.com/apache/apisix/pull/8672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix-website] yzeng25 commented on a diff in pull request #1471: docs:add four blogs

2023-01-17 Thread GitBox
yzeng25 commented on code in PR #1471: URL: https://github.com/apache/apisix-website/pull/1471#discussion_r1073009544 ## blog/zh/blog/2023/01/11/apisix-amesh-introduction.md: ## @@ -0,0 +1,87 @@ +--- +title: "基于 APISIX 的服务网格方案 Amesh 积极开发中!" +authors: + - name: "lingsamuel" +

[GitHub] [apisix-website] SkyeYoung commented on a diff in pull request #1474: fix the display of apisix-dashboard's version and download url

2023-01-17 Thread GitBox
SkyeYoung commented on code in PR #1474: URL: https://github.com/apache/apisix-website/pull/1474#discussion_r1073008099 ## package.json: ## @@ -17,6 +17,7 @@ "scripts": { "sync-docs": "yarn workspace scripts sync-docs", "generate-repos-info": "yarn workspace

[GitHub] [apisix-website] SkyeYoung commented on a diff in pull request #1474: fix the display of apisix-dashboard's version and download url

2023-01-17 Thread GitBox
SkyeYoung commented on code in PR #1474: URL: https://github.com/apache/apisix-website/pull/1474#discussion_r1073007163 ## config/docs.json: ## @@ -0,0 +1 @@ +[{"name":"APISIX®","nameInParamCase":"apisix","description":"A dynamic, real-time, high-performance API

[GitHub] [apisix-website] yzeng25 commented on pull request #1471: docs:add four blogs

2023-01-17 Thread GitBox
yzeng25 commented on PR #1471: URL: https://github.com/apache/apisix-website/pull/1471#issuecomment-1386343155 Hi @SylviaBABY @SkyeYoung @juzhiyuan , need further review and approvals for this pull request. Review contents can be found at

[GitHub] [apisix-ingress-controller] github-actions[bot] closed issue #1322: bug: controller will erase status from ingress that uses another class

2023-01-17 Thread GitBox
github-actions[bot] closed issue #1322: bug: controller will erase status from ingress that uses another class URL: https://github.com/apache/apisix-ingress-controller/issues/1322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-ingress-controller] github-actions[bot] commented on issue #1322: bug: controller will erase status from ingress that uses another class

2023-01-17 Thread GitBox
github-actions[bot] commented on issue #1322: URL: https://github.com/apache/apisix-ingress-controller/issues/1322#issuecomment-1386333626 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue

[apisix] branch master updated: docs: fix plugin config naming (#8701)

2023-01-17 Thread sylviasu
This is an automated email from the ASF dual-hosted git repository. sylviasu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 788705c59 docs: fix plugin config naming

[GitHub] [apisix] SylviaBABY merged pull request #8701: docs: fix plugin config naming

2023-01-17 Thread GitBox
SylviaBABY merged PR #8701: URL: https://github.com/apache/apisix/pull/8701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[apisix] branch master updated: docs: fix code block (#8700)

2023-01-17 Thread sylviasu
This is an automated email from the ASF dual-hosted git repository. sylviasu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new e472d4056 docs: fix code block (#8700)

[GitHub] [apisix] SylviaBABY merged pull request #8700: docs: fix code block

2023-01-17 Thread GitBox
SylviaBABY merged PR #8700: URL: https://github.com/apache/apisix/pull/8700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix-dashboard] cherishman2005 closed issue #2712: error An unexpected error occurred: "https://registry.yarnpkg.com/@ant-design/icons/-/icons-4.6.2.tgz: self signed certificate in certifi

2023-01-17 Thread GitBox
cherishman2005 closed issue #2712: error An unexpected error occurred: "https://registry.yarnpkg.com/@ant-design/icons/-/icons-4.6.2.tgz: self signed certificate in certificate chain". URL: https://github.com/apache/apisix-dashboard/issues/2712 -- This is an automated message from the

[GitHub] [apisix] flechter opened a new issue, #8703: Support plugin opend-id connect in stream proxy route

2023-01-17 Thread GitBox
flechter opened a new issue, #8703: URL: https://github.com/apache/apisix/issues/8703 ### Description We try to use stream proxy, but we would like to add a keycloak autorisation for using the route. When we try to add the plugin openid-connect we have the error :

[GitHub] [apisix] elkh510 commented on issue #8081: help request: access static file by custom nginx.conf but error

2023-01-17 Thread GitBox
elkh510 commented on issue #8081: URL: https://github.com/apache/apisix/issues/8081#issuecomment-1385522538 figured so in our test environment we have apisix ingress that point to test deployment. apisix contains nginx and test deployment contains nginx after we added

[GitHub] [apisix-ingress-controller] wnz27 commented on issue #1568: request help: how to define ApisixPluginConfig and in apisixroute use some other param to overwrite some param

2023-01-17 Thread GitBox
wnz27 commented on issue #1568: URL: https://github.com/apache/apisix-ingress-controller/issues/1568#issuecomment-1385478748 > > ### Issue description > > if i want to 1、define a ApisixPluginConfig use some plugin 2、define a apisixRoute and set same plugin in ApisixPluginConfig with

[GitHub] [apisix-ingress-controller] wnz27 commented on issue #1568: request help: how to define ApisixPluginConfig and in apisixroute use some other param to overwrite some param

2023-01-17 Thread GitBox
wnz27 commented on issue #1568: URL: https://github.com/apache/apisix-ingress-controller/issues/1568#issuecomment-1385477785 > You can actually try it out, they have different priorities i try it, but dont take effect. the plugin config not auto merge -- This is an automated

[GitHub] [apisix] kellyseeme opened a new issue, #8702: if etcd is down,the apisix not affect service?

2023-01-17 Thread GitBox
kellyseeme opened a new issue, #8702: URL: https://github.com/apache/apisix/issues/8702 ### Description if etcd cluster is down ,the apisix also can handle the requests?just affect if the apisix is restart or reload?how much time will be ok if etcd cluster down? ###

[GitHub] [apisix-docker] sashokbg commented on a diff in pull request #405: fix: config files overwritten by docker-entrypoint.sh

2023-01-17 Thread GitBox
sashokbg commented on code in PR #405: URL: https://github.com/apache/apisix-docker/pull/405#discussion_r1072157494 ## centos/docker-entrypoint.sh: ## @@ -22,18 +22,22 @@ PREFIX=${APISIX_PREFIX:=/usr/local/apisix} if [[ "$1" == "docker-start" ]]; then if [

[GitHub] [apisix-docker] sashokbg commented on a diff in pull request #405: fix: config files overwritten by docker-entrypoint.sh

2023-01-17 Thread GitBox
sashokbg commented on code in PR #405: URL: https://github.com/apache/apisix-docker/pull/405#discussion_r1072156896 ## centos/docker-entrypoint.sh: ## @@ -22,18 +22,22 @@ PREFIX=${APISIX_PREFIX:=/usr/local/apisix} if [[ "$1" == "docker-start" ]]; then if [

[GitHub] [apisix] ronething commented on issue #8680: help request: 是否有文档可以指导实现多环境

2023-01-17 Thread GitBox
ronething commented on issue #8680: URL: https://github.com/apache/apisix/issues/8680#issuecomment-1385255160 > 支持 /* 这样的通配符吗? you can have a try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] JohnQI8888 commented on issue #8680: help request: 是否有文档可以指导实现多环境

2023-01-17 Thread GitBox
JohnQI commented on issue #8680: URL: https://github.com/apache/apisix/issues/8680#issuecomment-1385185623 支持 /* 这样的通配符吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-dashboard] huweihuang opened a new issue, #2716: Support configuring multiple prefixes of etcd for apisix-dashboard

2023-01-17 Thread GitBox
huweihuang opened a new issue, #2716: URL: https://github.com/apache/apisix-dashboard/issues/2716 Background: Because we have deployed multiple sets of apisix in a k8s cluster and used different prefixes to distinguish different apisix services. So I want to configure multiple sets of

[GitHub] [apisix] shreemaan-abhishek opened a new pull request, #8701: docs: fix plugin config naming

2023-01-17 Thread GitBox
shreemaan-abhishek opened a new pull request, #8701: URL: https://github.com/apache/apisix/pull/8701 ### Description Fixed plugin config naming. ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or

[GitHub] [apisix] github-actions[bot] commented on issue #5879: docs: Mention four features that can be added later

2023-01-17 Thread GitBox
github-actions[bot] commented on issue #5879: URL: https://github.com/apache/apisix/issues/5879#issuecomment-1385138777 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. --

[GitHub] [apisix] github-actions[bot] closed issue #5879: docs: Mention four features that can be added later

2023-01-17 Thread GitBox
github-actions[bot] closed issue #5879: docs: Mention four features that can be added later URL: https://github.com/apache/apisix/issues/5879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] shreemaan-abhishek opened a new pull request, #8700: docs: fix code block

2023-01-17 Thread GitBox
shreemaan-abhishek opened a new pull request, #8700: URL: https://github.com/apache/apisix/pull/8700 ### Description The documentation for plugin config looks like this currently (inappropriate code block formatting):

[GitHub] [apisix-website] juzhiyuan commented on pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"

2023-01-17 Thread GitBox
juzhiyuan commented on PR #1468: URL: https://github.com/apache/apisix-website/pull/1468#issuecomment-1385127155 https://user-images.githubusercontent.com/2106987/212867302-424f8258-738d-43a1-b2de-35b374385352.png;> No worry  I see this commit changes a lot, @Yilialinn Please have a

[apisix] branch master updated: docs: rename kms to secret (#8697)

2023-01-17 Thread sylviasu
This is an automated email from the ASF dual-hosted git repository. sylviasu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 75b67b200 docs: rename kms to secret (#8697)

[GitHub] [apisix] SylviaBABY merged pull request #8697: docs: rename kms to secret

2023-01-17 Thread GitBox
SylviaBABY merged PR #8697: URL: https://github.com/apache/apisix/pull/8697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] e1ijah1 commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-17 Thread GitBox
e1ijah1 commented on code in PR #8681: URL: https://github.com/apache/apisix/pull/8681#discussion_r1071973979 ## apisix/plugins/file-logger.lua: ## @@ -14,23 +14,23 @@ -- See the License for the specific language governing permissions and -- limitations under the License. --

[GitHub] [apisix] e1ijah1 opened a new pull request, #8699: feat(k8s-discovery): support mTLS

2023-01-17 Thread GitBox
e1ijah1 opened a new pull request, #8699: URL: https://github.com/apache/apisix/pull/8699 ### Description support mTLS authentication with kubernetes apiserver for discovery Fixes #7516 ### Checklist - [x] I have explained the need for this PR and the problem it

[GitHub] [apisix] spacewander commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-17 Thread GitBox
spacewander commented on code in PR #8681: URL: https://github.com/apache/apisix/pull/8681#discussion_r1071941949 ## apisix/plugins/file-logger.lua: ## @@ -14,23 +14,23 @@ -- See the License for the specific language governing permissions and -- limitations under the License.

[GitHub] [apisix] soulbird commented on pull request #8697: change: rename kms to secret

2023-01-17 Thread GitBox
soulbird commented on PR #8697: URL: https://github.com/apache/apisix/pull/8697#issuecomment-1385054707 The content in this PR only includes the documentation part, so the title should be docs: x -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] uran0sH commented on issue #5453: request help: proxy-cache plugin, why the cache expiration time cannot be configured dynamically?

2023-01-17 Thread GitBox
uran0sH commented on issue #5453: URL: https://github.com/apache/apisix/issues/5453#issuecomment-1385043734 > Yes When I read the code of `disk_handler.lua`, I didn't understand how it caches things. It doesn't have the operation like `memory:set` -- This is an automated message

[GitHub] [apisix-ingress-controller] Fabriceli commented on pull request #1576: fix: fix sync delete svc error

2023-01-17 Thread GitBox
Fabriceli commented on PR #1576: URL: https://github.com/apache/apisix-ingress-controller/pull/1576#issuecomment-1385024548 @tao12345666333 @AlinsRan please take a look at this PR, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-website] MirtoBusico commented on pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"

2023-01-17 Thread GitBox
MirtoBusico commented on PR #1468: URL: https://github.com/apache/apisix-website/pull/1468#issuecomment-1385021979 > > > > I've checked the changed file, and it seems that my changes didn't work. For example: I changed "apisix-dashboard" to "APISIX Dashboard" and capitalized the

[GitHub] [apisix] soulbird commented on a diff in pull request #8661: refactor(admin): stream_routes/upstreams/protos/services/global_rules/consumer_groups/plugin_configs

2023-01-17 Thread GitBox
soulbird commented on code in PR #8661: URL: https://github.com/apache/apisix/pull/8661#discussion_r1071884997 ## apisix/admin/init.lua: ## @@ -199,7 +199,17 @@ local function run() end local code, data -if seg_res == "routes" then +local

[GitHub] [apisix] An-DJ commented on a diff in pull request #8661: refactor(admin): stream_routes/upstreams/protos/services/global_rules/consumer_groups/plugin_configs

2023-01-17 Thread GitBox
An-DJ commented on code in PR #8661: URL: https://github.com/apache/apisix/pull/8661#discussion_r1071871509 ## apisix/admin/init.lua: ## @@ -199,7 +199,17 @@ local function run() end local code, data -if seg_res == "routes" then +local refactored_resources =

[GitHub] [apisix] An-DJ commented on a diff in pull request #8661: refactor(admin): stream_routes/upstreams/protos/services/global_rules/consumer_groups/plugin_configs

2023-01-17 Thread GitBox
An-DJ commented on code in PR #8661: URL: https://github.com/apache/apisix/pull/8661#discussion_r1071873312 ## apisix/admin/resource.lua: ## @@ -57,11 +57,21 @@ function _M:check_conf(id, conf, need_id) core.log.info("conf : ", core.json.delay_encode(conf)) --

[GitHub] [apisix] An-DJ commented on a diff in pull request #8661: refactor(admin): stream_routes/upstreams/protos/services/global_rules/consumer_groups/plugin_configs

2023-01-17 Thread GitBox
An-DJ commented on code in PR #8661: URL: https://github.com/apache/apisix/pull/8661#discussion_r1071871509 ## apisix/admin/init.lua: ## @@ -199,7 +199,17 @@ local function run() end local code, data -if seg_res == "routes" then +local refactored_resources =