[GitHub] [apisix-ingress-controller] AlinsRan commented on pull request #1780: fix: secret reference update Ingress

2023-04-13 Thread via GitHub
AlinsRan commented on PR #1780: URL: https://github.com/apache/apisix-ingress-controller/pull/1780#issuecomment-1508016798 When deleting a secret, does the SSL object of APISIX exist? Missing e2e case for delete-secret? -- This is an automated message from the Apache Git Service. To re

[GitHub] [apisix] thor533 commented on issue #9239: priority of the custom plug-in is invalid

2023-04-13 Thread via GitHub
thor533 commented on issue #9239: URL: https://github.com/apache/apisix/issues/9239#issuecomment-1508015965 > > > > > > > > > > > > > > > > > Is this an apisix bug or a configuration problem? > > > > > > > > > maybe this is a feature. > > > Because the core logic of

[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #1780: fix: secret reference update Ingress

2023-04-13 Thread via GitHub
AlinsRan commented on code in PR #1780: URL: https://github.com/apache/apisix-ingress-controller/pull/1780#discussion_r1166357757 ## pkg/providers/ingress/ingress.go: ## @@ -152,6 +152,36 @@ func (c *ingressController) sync(ctx context.Context, ev *types.Event) error {

[GitHub] [apisix] kingluo commented on issue #9049: help request: Decoupled deployment mode DP module cannot get the latest routing and upstream information

2023-04-13 Thread via GitHub
kingluo commented on issue #9049: URL: https://github.com/apache/apisix/issues/9049#issuecomment-1508009832 > Is there any hidden danger in this temporary method? I want to deploy it to our production environment; @jinjianming No danger. Just has a little performance impact. That is,

[GitHub] [apisix] thor533 commented on issue #9308: Health check error

2023-04-13 Thread via GitHub
thor533 commented on issue #9308: URL: https://github.com/apache/apisix/issues/9308#issuecomment-1508008210 > I think this is expected because upstream is referenced by service, not directly by route. Therefore, the status change of route should not affect upstream. If there are other route

[GitHub] [apisix] thor533 commented on issue #9308: Health check error

2023-04-13 Thread via GitHub
thor533 commented on issue #9308: URL: https://github.com/apache/apisix/issues/9308#issuecomment-1508006268 > I think this is expected because upstream is referenced by service, not directly by route. Therefore, the status change of route should not affect upstream. If there are other route

[GitHub] [apisix] thor533 commented on issue #9308: Health check error

2023-04-13 Thread via GitHub
thor533 commented on issue #9308: URL: https://github.com/apache/apisix/issues/9308#issuecomment-1507998544 > I think this is expected because upstream is referenced by service, not directly by route. Therefore, the status change of route should not affect upstream. If there are other route

[GitHub] [apisix] nic-6443 commented on issue #9305: bug: consistent hashing not working

2023-04-13 Thread via GitHub
nic-6443 commented on issue #9305: URL: https://github.com/apache/apisix/issues/9305#issuecomment-1507995312 Your testing method is problematic. You should not use public domain names such as `google.com` and `revoly.dev` as upstream nodes. The DNS resolution results and the order of IP

[GitHub] [apisix] jinjianming commented on issue #9049: help request: Decoupled deployment mode DP module cannot get the latest routing and upstream information

2023-04-13 Thread via GitHub
jinjianming commented on issue #9049: URL: https://github.com/apache/apisix/issues/9049#issuecomment-1507994010 > @jinjianming In decoupled deployment mode, CP only provides https, for access by DP. But with `proxy_buffering on;` (by default), the SSL response (chunked watch result blocks)

[GitHub] [apisix-ingress-controller] AlinsRan commented on issue #1789: request help: apisix-ingress-controller event handling is slow

2023-04-13 Thread via GitHub
AlinsRan commented on issue #1789: URL: https://github.com/apache/apisix-ingress-controller/issues/1789#issuecomment-1507973562 My actual test results are similar to yours. The performance bottleneck lies in network latency. -- This is an automated message from the Apache Git Service.

[GitHub] [apisix] nic-6443 closed issue #8729: docs: tutorial expose your service can not work

2023-04-13 Thread via GitHub
nic-6443 closed issue #8729: docs: tutorial expose your service can not work URL: https://github.com/apache/apisix/issues/8729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [apisix] nic-6443 closed issue #9304: docs: Wrong URL specified on "Expose API" page while testing.

2023-04-13 Thread via GitHub
nic-6443 closed issue #9304: docs: Wrong URL specified on "Expose API" page while testing. URL: https://github.com/apache/apisix/issues/9304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[apisix] branch master updated (03481e36c -> 7790aeb80)

2023-04-13 Thread nic443
This is an automated email from the ASF dual-hosted git repository. nic443 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git from 03481e36c fix: batch-requests: read trailer headers if exist (#9289) add 7790aeb80 docs: (fix) tutorial expose yo

[GitHub] [apisix] nic-6443 merged pull request #8730: docs: (fix) tutorial expose your service

2023-04-13 Thread via GitHub
nic-6443 merged PR #8730: URL: https://github.com/apache/apisix/pull/8730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apis

[GitHub] [apisix] nic-6443 commented on issue #9308: Health check error

2023-04-13 Thread via GitHub
nic-6443 commented on issue #9308: URL: https://github.com/apache/apisix/issues/9308#issuecomment-1507967087 I think this is expected because upstream is referenced by service, not directly by route. Therefore, the status change of route should not affect upstream. If there are other ro

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1721: CI: add regression testing with apisix:dev

2023-04-13 Thread via GitHub
tao12345666333 commented on code in PR #1721: URL: https://github.com/apache/apisix-ingress-controller/pull/1721#discussion_r1166294464 ## .github/workflows/e2e-test-ci-v2-dev.yml: ## @@ -0,0 +1,215 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [apisix-website] dependabot[bot] commented on pull request #1557: chore(deps): bump actions/checkout from 3.1.0 to 3.5.1

2023-04-13 Thread via GitHub
dependabot[bot] commented on PR #1557: URL: https://github.com/apache/apisix-website/pull/1557#issuecomment-1507923327 Superseded by #1560. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[apisix-website] branch dependabot/github_actions/actions/checkout-3.5.2 created (now ef907a6e4cc)

2023-04-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/checkout-3.5.2 in repository https://gitbox.apache.org/repos/asf/apisix-website.git at ef907a6e4cc chore(deps): bump actions/checkout from 3.1.0 to 3.

[GitHub] [apisix-website] netlify[bot] commented on pull request #1560: chore(deps): bump actions/checkout from 3.1.0 to 3.5.2

2023-04-13 Thread via GitHub
netlify[bot] commented on PR #1560: URL: https://github.com/apache/apisix-website/pull/1560#issuecomment-1507923354 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |:-:|| |🔨 Latest commit | ef907a6e4cc3f1353161439603867565d87da2

[GitHub] [apisix-website] dependabot[bot] closed pull request #1557: chore(deps): bump actions/checkout from 3.1.0 to 3.5.1

2023-04-13 Thread via GitHub
dependabot[bot] closed pull request #1557: chore(deps): bump actions/checkout from 3.1.0 to 3.5.1 URL: https://github.com/apache/apisix-website/pull/1557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-website] dependabot[bot] opened a new pull request, #1560: chore(deps): bump actions/checkout from 3.1.0 to 3.5.2

2023-04-13 Thread via GitHub
dependabot[bot] opened a new pull request, #1560: URL: https://github.com/apache/apisix-website/pull/1560 Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.5.2. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9267: fix: body-transformer should have a smaller priority than proxy-cache

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on code in PR #9267: URL: https://github.com/apache/apisix/pull/9267#discussion_r1166263138 ## t/plugin/body-transformer.t: ## @@ -652,3 +662,113 @@ foobar: assert(res.status == 200) } } + + + +=== TEST 10: cooperation of pro

[GitHub] [apisix-dashboard] idb-root opened a new issue, #2791: apisix-dashboard3.0.1 点击插件时白屏,前端地址:https://xxx.xxx.com/plugin/list

2023-04-13 Thread via GitHub
idb-root opened a new issue, #2791: URL: https://github.com/apache/apisix-dashboard/issues/2791 1、apisix-dashboard3.0.1 点击【插件】时白屏,前端地址:https://xxx.xxx.com/plugin/list 2、apisix: 2.1、apisix接口返回null: https://xx.xx.com/apisix/admin/plugins?all=true 这个接口返回的data是null。

[GitHub] [apisix-ingress-controller] zou8944 commented on a diff in pull request #1460: make: dev-env

2023-04-13 Thread via GitHub
zou8944 commented on code in PR #1460: URL: https://github.com/apache/apisix-ingress-controller/pull/1460#discussion_r1166248206 ## Makefile: ## @@ -325,3 +324,19 @@ install-gateway-api-local: .PHONY: uninstall-gateway-api uninstall-gateway-api: kubectl delete -f $(GA

[GitHub] [apisix] monkeyDluffy6017 merged pull request #9289: fix: batch-requests: read trailer headers if exist

2023-04-13 Thread via GitHub
monkeyDluffy6017 merged PR #9289: URL: https://github.com/apache/apisix/pull/9289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

[GitHub] [apisix] kingluo opened a new pull request, #9309: fix: proxy-rewrite should set ngx.var.uri

2023-04-13 Thread via GitHub
kingluo opened a new pull request, #9309: URL: https://github.com/apache/apisix/pull/9309 ### Description Besides custom `upstream_uri` var, it should set `ngx.var.uri` to keep compatible. ### Checklist - [x] I have explained the need for this PR and the prob

[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9173: fix: merge route custom protocol

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on PR #9173: URL: https://github.com/apache/apisix/pull/9173#issuecomment-1507876917 Please make the ci pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [apisix] robertluoxu closed issue #9297: help request: apisix + keycloak using reatfull service 400 – Bad Request

2023-04-13 Thread via GitHub
robertluoxu closed issue #9297: help request: apisix + keycloak using reatfull service 400 – Bad Request URL: https://github.com/apache/apisix/issues/9297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] robertluoxu commented on issue #9297: help request: apisix + keycloak using reatfull service 400 – Bad Request

2023-04-13 Thread via GitHub
robertluoxu commented on issue #9297: URL: https://github.com/apache/apisix/issues/9297#issuecomment-1507871851 感谢,确实如您所说,发现header太长而后端服务未设置header大小导致 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9289: fix: batch-requests: read trailer headers if exist

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on code in PR #9289: URL: https://github.com/apache/apisix/pull/9289#discussion_r1166228488 ## apisix/plugins/batch-requests.lua: ## @@ -275,7 +275,14 @@ local function batch_requests(ctx) headers = resp.headers, } if res

[GitHub] [apisix-ingress-controller] panniyuyu opened a new issue, #1791: request help: There is no route after ApisixRoute applied.

2023-04-13 Thread via GitHub
panniyuyu opened a new issue, #1791: URL: https://github.com/apache/apisix-ingress-controller/issues/1791 ### Issue description this is ingress controller config # log options log_level: "debug" log_output: "stderr" cert_file: "/etc/webhook/certs/cert.pem" key_file:

[GitHub] [apisix-ingress-controller] jensonfxc commented on issue #1789: request help: apisix-ingress-controller event handling is slow

2023-04-13 Thread via GitHub
jensonfxc commented on issue #1789: URL: https://github.com/apache/apisix-ingress-controller/issues/1789#issuecomment-1507843596 ``` 2023-04-14T10:17:42+08:00 debug apisix/apisix_route.go:125 route workqueue {"length": 900, "starttime": 1681438661638853001, "endtime

[GitHub] [apisix] thor533 opened a new issue, #9308: Health check error

2023-04-13 Thread via GitHub
thor533 opened a new issue, #9308: URL: https://github.com/apache/apisix/issues/9308 ### Current Behavior The active health check continued when I closed a route,On the route is the bound service ### Expected Behavior The route is closed, and the health check sto

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1790: fix typo

2023-04-13 Thread via GitHub
codecov-commenter commented on PR #1790: URL: https://github.com/apache/apisix-ingress-controller/pull/1790#issuecomment-1507807106 ## [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1790?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campai

[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9243: fix(ci): markdownlint ci not work

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on PR #9243: URL: https://github.com/apache/apisix/pull/9243#issuecomment-1507807044 Could you show me the ci link of `doc-lint ci seems not work`? Are you sure this pr can fix this? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9243: fix(ci): markdownlint ci not work

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on code in PR #9243: URL: https://github.com/apache/apisix/pull/9243#discussion_r1166184238 ## docs/zh/latest/getting-started.md: ## @@ -143,13 +143,13 @@ curl -sL https://run.api7.ai/apisix/quickstart | sh curl "http://127.0.0.1:9080"; --head | grep

[GitHub] [apisix-ingress-controller] AlinsRan commented on issue #1789: request help: apisix-ingress-controller event handling is slow

2023-04-13 Thread via GitHub
AlinsRan commented on issue #1789: URL: https://github.com/apache/apisix-ingress-controller/issues/1789#issuecomment-1507801758 Yes, we are trying to optimize this issue. This is a related issue #1591. welcome to discuss. -- This is an automated message from the Apache Git Service. To re

[apisix] branch master updated: docs: fix typo in prometheus doc (#9286)

2023-04-13 Thread gallardot
This is an automated email from the ASF dual-hosted git repository. gallardot pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 52a19fef6 docs: fix typo in prometheus doc (#

[GitHub] [apisix] Gallardot merged pull request #9286: docs: fix typo in prometheus doc

2023-04-13 Thread via GitHub
Gallardot merged PR #9286: URL: https://github.com/apache/apisix/pull/9286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@api

[GitHub] [apisix] Gallardot merged pull request #9303: docs: fix admonition in Terminology, Secret

2023-04-13 Thread via GitHub
Gallardot merged PR #9303: URL: https://github.com/apache/apisix/pull/9303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@api

[apisix] branch master updated: docs: fix admonition in Terminology, Secret (#9303)

2023-04-13 Thread gallardot
This is an automated email from the ASF dual-hosted git repository. gallardot pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new b0bd8c944 docs: fix admonition in Terminology

[GitHub] [apisix] cverdela commented on issue #9249: help request: Upstream services require different consumers to return different information on how to place their username in the header, and wheth

2023-04-13 Thread via GitHub
cverdela commented on issue #9249: URL: https://github.com/apache/apisix/issues/9249#issuecomment-1507774007 I need to prevent a from obtaining 22 through any means -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [apisix] cverdela commented on issue #9249: help request: Upstream services require different consumers to return different information on how to place their username in the header, and wheth

2023-04-13 Thread via GitHub
cverdela commented on issue #9249: URL: https://github.com/apache/apisix/issues/9249#issuecomment-1507773000 And abc has different permission controls for different upstream -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] cverdela commented on issue #9249: help request: Upstream services require different consumers to return different information on how to place their username in the header, and wheth

2023-04-13 Thread via GitHub
cverdela commented on issue #9249: URL: https://github.com/apache/apisix/issues/9249#issuecomment-1507772347 There are three consumers a, b, and c. A and b have the same organization as 1, and c has the same organization as 2. The authentication of a, b, and c needs to be different. When ac

[GitHub] [apisix-ingress-controller] monkeyDluffy6017 commented on issue #1768: request help: failed to sync SSL to APISIX label exceeds the maximum length of the schema.

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on issue #1768: URL: https://github.com/apache/apisix-ingress-controller/issues/1768#issuecomment-1507315819 What is the appropriate setting for the length? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9298: fix(wolf-rbac): other plugin in consumer not effective when consumer used wolf-rbac plugin (#9287)

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on PR #9298: URL: https://github.com/apache/apisix/pull/9298#issuecomment-1507311306 Hi @lingliy, test cases are needed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9173: fix: merge route custom protocol

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on code in PR #9173: URL: https://github.com/apache/apisix/pull/9173#discussion_r1165805325 ## t/node/grpc-proxy.t: ## @@ -285,3 +285,36 @@ grpcurl -import-path ./t/grpc_server_example/proto -proto helloworld.proto -plai qr/grpc header: "(:authority|

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9173: fix: merge route custom protocol

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on code in PR #9173: URL: https://github.com/apache/apisix/pull/9173#discussion_r1165804980 ## t/node/grpc-proxy.t: ## @@ -285,3 +285,36 @@ grpcurl -import-path ./t/grpc_server_example/proto -proto helloworld.proto -plai qr/grpc header: "(:authority|

[GitHub] [apisix] skimdz86 opened a new issue, #9307: feat: support for the Timing-Allow-Origin header in CORS plugin

2023-04-13 Thread via GitHub
skimdz86 opened a new issue, #9307: URL: https://github.com/apache/apisix/issues/9307 ### Description When using the CORS plugin, I'd like to be able to set also the Timing-Allow-Origin header (https://www.w3.org/TR/resource-timing/#sec-timing-allow-origin). The plugin configu

[GitHub] [apisix] brentmjohnson opened a new issue, #9306: bug: openid-connect plugin - existing session randomly unavailable for introspection / token renewal

2023-04-13 Thread via GitHub
brentmjohnson opened a new issue, #9306: URL: https://github.com/apache/apisix/issues/9306 ### Current Behavior The openid-connect plugin will randomly redirect requests with valid session cookie and non-expired tokens back through the authentication flow. No errors were generated as

[GitHub] [apisix] Revolyssup opened a new issue, #9305: bug: consistent hashing not working

2023-04-13 Thread via GitHub
Revolyssup opened a new issue, #9305: URL: https://github.com/apache/apisix/issues/9305 ### Current Behavior Following the docs here for cookie based consistent hashing, two nodes are provided in upstream. Even after passing the same cookie consistently as given in the doc, the reque

[GitHub] [apisix-docker] Lanhild closed issue #454: Cannot connect to etcd

2023-04-13 Thread via GitHub
Lanhild closed issue #454: Cannot connect to etcd URL: https://github.com/apache/apisix-docker/issues/454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [apisix-docker] Lanhild commented on issue #454: Cannot connect to etcd

2023-04-13 Thread via GitHub
Lanhild commented on issue #454: URL: https://github.com/apache/apisix-docker/issues/454#issuecomment-1507186053 Hi, That was it. Changing `ETCD_ADVERTISE_CLIENT_URLS` from `http://0.0.0.0:2379` to `http://etcd:2379` did solve it. Thank you! -- This is an automated message from the

[GitHub] [apisix-dashboard] coolboywcm closed issue #2787: dynamically add management users to apisix-dashboard

2023-04-13 Thread via GitHub
coolboywcm closed issue #2787: dynamically add management users to apisix-dashboard URL: https://github.com/apache/apisix-dashboard/issues/2787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [apisix] nic-6443 commented on issue #9300: help request: dynamically add management users to apisix-dashboard

2023-04-13 Thread via GitHub
nic-6443 commented on issue #9300: URL: https://github.com/apache/apisix/issues/9300#issuecomment-1507180060 @coolboywcm No worries, it's okay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] jiangfucheng commented on pull request #9243: fix(ci): markdownlint ci not work

2023-04-13 Thread via GitHub
jiangfucheng commented on PR #9243: URL: https://github.com/apache/apisix/pull/9243#issuecomment-1507137588 The failed CI seems abnormaly, so i submit a empty commit try to re-trigger CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix-ingress-controller] mchtech commented on issue #1785: question: regex path route matching is unstable

2023-04-13 Thread via GitHub
mchtech commented on issue #1785: URL: https://github.com/apache/apisix-ingress-controller/issues/1785#issuecomment-1507133399 I only use `apisix-ingress-controller` to "sync" K8s APISIX Ingress resources to `apisix` routes. > order 1 1. add k8s regex ingress `/api/bbb/.* --> svc-

[GitHub] [apisix] coolboywcm closed issue #9300: help request: dynamically add management users to apisix-dashboard

2023-04-13 Thread via GitHub
coolboywcm closed issue #9300: help request: dynamically add management users to apisix-dashboard URL: https://github.com/apache/apisix/issues/9300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] coolboywcm commented on issue #9300: help request: dynamically add management users to apisix-dashboard

2023-04-13 Thread via GitHub
coolboywcm commented on issue #9300: URL: https://github.com/apache/apisix/issues/9300#issuecomment-1507078917 > Please do not create duplicate issues. You have already created: [apache/apisix-dashboard#2787](https://github.com/apache/apisix-dashboard/issues/2787) [apache/apisix-dashboard#

[GitHub] [apisix-website] kayx23 commented on pull request #1559: fix: removed duplicated `ip-restriction` plugin

2023-04-13 Thread via GitHub
kayx23 commented on PR #1559: URL: https://github.com/apache/apisix-website/pull/1559#issuecomment-1506962906 @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [apisix-website] kayx23 commented on pull request #1559: fix: removed duplicated `ip-restriction` plugin

2023-04-13 Thread via GitHub
kayx23 commented on PR #1559: URL: https://github.com/apache/apisix-website/pull/1559#issuecomment-1506956805 @juzhiyuan : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix] Neilblaze commented on a diff in pull request #8730: docs: (fix) tutorial expose your service

2023-04-13 Thread via GitHub
Neilblaze commented on code in PR #8730: URL: https://github.com/apache/apisix/pull/8730#discussion_r1165499120 ## docs/zh/latest/getting-started.md: ## @@ -257,10 +257,10 @@ curl "http://127.0.0.1:9180/apisix/admin/routes/1"; -H "X-API-KEY: edd1c9f034335f 我们已经创建了路由与上游服务,现在可以通

[GitHub] [apisix] nic-6443 commented on a diff in pull request #8730: docs: (fix) tutorial expose your service

2023-04-13 Thread via GitHub
nic-6443 commented on code in PR #8730: URL: https://github.com/apache/apisix/pull/8730#discussion_r1165496062 ## docs/zh/latest/getting-started.md: ## @@ -257,10 +257,10 @@ curl "http://127.0.0.1:9180/apisix/admin/routes/1"; -H "X-API-KEY: edd1c9f034335f 我们已经创建了路由与上游服务,现在可以通过

[GitHub] [apisix-ingress-controller] jiangfucheng opened a new pull request, #1790: fix typo

2023-04-13 Thread via GitHub
jiangfucheng opened a new pull request, #1790: URL: https://github.com/apache/apisix-ingress-controller/pull/1790 ### Type of change: - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - [x] Documentation - [

[GitHub] [apisix] nic-6443 commented on issue #9304: docs: Wrong URL specified on "Expose API" page while testing.

2023-04-13 Thread via GitHub
nic-6443 commented on issue #9304: URL: https://github.com/apache/apisix/issues/9304#issuecomment-1506919788 Will be fixed in: https://github.com/apache/apisix/pull/8730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix] nic-6443 commented on issue #9300: help request: dynamically add management users to apisix-dashboard

2023-04-13 Thread via GitHub
nic-6443 commented on issue #9300: URL: https://github.com/apache/apisix/issues/9300#issuecomment-1506910981 Please do not create duplicate issues. You have already created: https://github.com/apache/apisix-dashboard/issues/2787 https://github.com/apache/apisix-dashboard/issues/2788

[GitHub] [apisix-docker] tanshunyuan commented on issue #454: Cannot connect to etcd

2023-04-13 Thread via GitHub
tanshunyuan commented on issue #454: URL: https://github.com/apache/apisix-docker/issues/454#issuecomment-1506873190 > Though, might the issue come from the fact that I migrated from ~2.15 to 3.0? I'm not really sure too, I didn't copy directly from [example/docker-compose.yml](https

[GitHub] [apisix-website] kayx23 commented on pull request #1559: fix: removed duplicated `ip-restriction` plugin

2023-04-13 Thread via GitHub
kayx23 commented on PR #1559: URL: https://github.com/apache/apisix-website/pull/1559#issuecomment-1506833523 @guoqqqi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [apisix-website] netlify[bot] commented on pull request #1559: fix: removed duplicated `ip-restriction` plugin

2023-04-13 Thread via GitHub
netlify[bot] commented on PR #1559: URL: https://github.com/apache/apisix-website/pull/1559#issuecomment-1506830233 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |:-:|| |🔨 Latest commit | 59f497cde683740a5c4a222fc674f17029fed6

[GitHub] [apisix-website] kayx23 opened a new pull request, #1559: fix: removed duplicated `ip-restriction` plugin

2023-04-13 Thread via GitHub
kayx23 opened a new pull request, #1559: URL: https://github.com/apache/apisix-website/pull/1559 Currently there are two: ![dup](https://user-images.githubusercontent.com/39619599/231749707-295db87d-e367-49ae-be94-a1699ae91245.png) -- This is an automated message from the Apache G

[GitHub] [apisix-dashboard] mujinhuakai opened a new issue, #2790: Plugin is still working after disable it

2023-04-13 Thread via GitHub
mujinhuakai opened a new issue, #2790: URL: https://github.com/apache/apisix-dashboard/issues/2790 ### Issue description In the plugin list page, click cofig to open the config drawer, disable the plugin and click submit. It says success and we can't see this plugin in the plu

[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9185: feat: limit-count plugin supports username and ssl for redis policy

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on PR #9185: URL: https://github.com/apache/apisix/pull/9185#issuecomment-1506787483 @soulbird @leslie-tsang @kingluo please help to review this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9185: feat: limit-count plugin supports username and ssl for redis policy

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on code in PR #9185: URL: https://github.com/apache/apisix/pull/9185#discussion_r1165373120 ## t/plugin/limit-count-redis3.t: ## @@ -186,3 +186,63 @@ passed } --- response_body ["1","0","0"] + + + +=== TEST 5: set route, with redis host, port an

[GitHub] [apisix-docker] WordlessEcho commented on issue #373: restart docker error:[emerg] 1#1: bind() to unix:/usr/local/apisix/conf/config_listen.sock failed (98: Address already in use)

2023-04-13 Thread via GitHub
WordlessEcho commented on issue #373: URL: https://github.com/apache/apisix-docker/issues/373#issuecomment-1506772781 No. It doesn't fix. I run apisix on WSL. WSL will shutdown automatically. It happens after I start WSL and docker again. ``` /usr/local/openresty//luajit/bin/lua

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9210: feat: Add support for custom named log file names for log-rotate plugin

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on code in PR #9210: URL: https://github.com/apache/apisix/pull/9210#discussion_r1165357541 ## t/plugin/log-rotate3.t: ## @@ -132,3 +132,41 @@ start xx } --- response_body passed + + + +=== TEST 4: max_kept effective on differently named com

[GitHub] [apisix-ingress-controller] Gallardot commented on pull request #1788: Chore: Upgrade Go tool chain version 1.19 to version 1.20

2023-04-13 Thread via GitHub
Gallardot commented on PR #1788: URL: https://github.com/apache/apisix-ingress-controller/pull/1788#issuecomment-1506747334 @WVenus Thank you for your contribution. Notice that CI failed. I've retried the failed job, but it still doesn't work. Before merging, you need to fix CI. Tha

[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9210: feat: Add support for custom named log file names for log-rotate plugin

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on PR #9210: URL: https://github.com/apache/apisix/pull/9210#issuecomment-1506746577 @abs007 please fix the ci problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [apisix] kingluo commented on a diff in pull request #9194: feat: proxy_rewrite support miltiple regex pattern matching

2023-04-13 Thread via GitHub
kingluo commented on code in PR #9194: URL: https://github.com/apache/apisix/pull/9194#discussion_r1165346463 ## docs/en/latest/plugins/proxy-rewrite.md: ## @@ -38,7 +38,8 @@ The `proxy-rewrite` Plugin rewrites Upstream proxy information such as `scheme`, |---

[GitHub] [apisix-dashboard] beginnerWJC opened a new issue, #2789: apisix-dashboard-3.0.0的导入功能,导入后缺少上游和插件部分

2023-04-13 Thread via GitHub
beginnerWJC opened a new issue, #2789: URL: https://github.com/apache/apisix-dashboard/issues/2789 ### Issue description apisix-dashboard-3.0.0的导入功能,导入后缺少上游和插件部分 ### Expected behavior 导出的路由json文件导入后可以直接使用,之前apisix-dashboard-2.13.0可以直接导出导入,3.0.0版本会缺少上游和插件部分 ### How

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9210: feat: Add support for custom named log file names for log-rotate plugin

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on code in PR #9210: URL: https://github.com/apache/apisix/pull/9210#discussion_r1165335872 ## apisix/plugins/log-rotate.lua: ## @@ -49,6 +49,9 @@ local default_logs local enable_compression = false local DEFAULT_ACCESS_LOG_FILENAME = "access.log" l

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9210: feat: Add support for custom named log file names for log-rotate plugin

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on code in PR #9210: URL: https://github.com/apache/apisix/pull/9210#discussion_r1165334626 ## apisix/plugins/log-rotate.lua: ## @@ -325,6 +347,7 @@ end function _M.init() timers.register_timer("plugin#log-rotate", rotate, true) +new_access

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9210: feat: Add support for custom named log file names for log-rotate plugin

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on code in PR #9210: URL: https://github.com/apache/apisix/pull/9210#discussion_r1165328560 ## apisix/plugins/log-rotate.lua: ## @@ -266,11 +271,25 @@ local function rotate_file(files, now_time, max_kept) end +-- get the custom log file name from

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9210: feat: Add support for custom named log file names for log-rotate plugin

2023-04-13 Thread via GitHub
monkeyDluffy6017 commented on code in PR #9210: URL: https://github.com/apache/apisix/pull/9210#discussion_r1165328560 ## apisix/plugins/log-rotate.lua: ## @@ -266,11 +271,25 @@ local function rotate_file(files, now_time, max_kept) end +-- get the custom log file name from

[apisix] branch master updated: fix: hold_body_chunk should use seperate buffer for each plugin in case of pollution (#9266)

2023-04-13 Thread monkeydluffy
This is an automated email from the ASF dual-hosted git repository. monkeydluffy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new f39cadde5 fix: hold_body_chunk should use

[GitHub] [apisix] monkeyDluffy6017 closed issue #9228: bug: hold_body_chunk can not be used in more than one plugin

2023-04-13 Thread via GitHub
monkeyDluffy6017 closed issue #9228: bug: hold_body_chunk can not be used in more than one plugin URL: https://github.com/apache/apisix/issues/9228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [apisix] monkeyDluffy6017 merged pull request #9266: fix: hold_body_chunk should use seperate buffer for each plugin in case of pollution

2023-04-13 Thread via GitHub
monkeyDluffy6017 merged PR #9266: URL: https://github.com/apache/apisix/pull/9266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

[GitHub] [apisix] thor533 commented on issue #9225: The least conn algorithm cant work!!!

2023-04-13 Thread via GitHub
thor533 commented on issue #9225: URL: https://github.com/apache/apisix/issues/9225#issuecomment-1506702619 > yep, i will try again ,thank you reply ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix] github-actions[bot] commented on issue #6893: bug: hack in my server look this

2023-04-13 Thread via GitHub
github-actions[bot] commented on issue #6893: URL: https://github.com/apache/apisix/issues/6893#issuecomment-1506696950 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simp

[GitHub] [apisix] github-actions[bot] closed issue #6835: feat: Suggest that access-control-allow-origin in response header showing just as configured

2023-04-13 Thread via GitHub
github-actions[bot] closed issue #6835: feat: Suggest that access-control-allow-origin in response header showing just as configured URL: https://github.com/apache/apisix/issues/6835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [apisix] github-actions[bot] commented on issue #6835: feat: Suggest that access-control-allow-origin in response header showing just as configured

2023-04-13 Thread via GitHub
github-actions[bot] commented on issue #6835: URL: https://github.com/apache/apisix/issues/6835#issuecomment-1506696858 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- Th

[GitHub] [apisix] Sn0rt commented on issue #9239: priority of the custom plug-in is invalid

2023-04-13 Thread via GitHub
Sn0rt commented on issue #9239: URL: https://github.com/apache/apisix/issues/9239#issuecomment-1506691540 > > > > > > > > > > > > > Is this an apisix bug or a configuration problem? > > > > > > maybe this is a feature. > > Because the core logic of the two plug-ins w

[GitHub] [apisix-ingress-controller] ps-19 commented on a diff in pull request #1787: Added a new make dev-env entry in Makefile which will be exposed on 8000:5000 Port

2023-04-13 Thread via GitHub
ps-19 commented on code in PR #1787: URL: https://github.com/apache/apisix-ingress-controller/pull/1787#discussion_r1165302165 ## Makefile: ## @@ -328,3 +330,44 @@ install-gateway-api-local: .PHONY: uninstall-gateway-api uninstall-gateway-api: kubectl delete -f $(GATE

[GitHub] [apisix] Fabriceli commented on issue #9273: help request: resty http got BAD ARGUMENT exception by accident

2023-04-13 Thread via GitHub
Fabriceli commented on issue #9273: URL: https://github.com/apache/apisix/issues/9273#issuecomment-1506688382 tcpdump file PART 2: ```txt No. Time SourceDestination Protocol Length Info 26025 453.615933 10.86.133.148 10.86.133.61

[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #1787: Added a new make dev-env entry in Makefile which will be exposed on 8000:5000 Port

2023-04-13 Thread via GitHub
lingsamuel commented on code in PR #1787: URL: https://github.com/apache/apisix-ingress-controller/pull/1787#discussion_r1165299541 ## Makefile: ## @@ -328,3 +330,44 @@ install-gateway-api-local: .PHONY: uninstall-gateway-api uninstall-gateway-api: kubectl delete -f $

[GitHub] [apisix-ingress-controller] lingsamuel commented on pull request #1787: Added a new make dev-env entry in Makefile which will be exposed on 8000:5000 Port

2023-04-13 Thread via GitHub
lingsamuel commented on PR #1787: URL: https://github.com/apache/apisix-ingress-controller/pull/1787#issuecomment-1506682041 Why we need two registries? They can share the same registry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] Revolyssup commented on issue #9304: docs: Wrong URL specified on "Expose API" page while testing.

2023-04-13 Thread via GitHub
Revolyssup commented on issue #9304: URL: https://github.com/apache/apisix/issues/9304#issuecomment-1506680308 Can I take this up? Given that its a small issue and straightforward fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] thor533 commented on issue #9239: priority of the custom plug-in is invalid

2023-04-13 Thread via GitHub
thor533 commented on issue #9239: URL: https://github.com/apache/apisix/issues/9239#issuecomment-1506678818 > > > > > > > > > Is this an apisix bug or a configuration problem? > > maybe this is a feature. > > Because the core logic of the two plug-ins works in differ

[GitHub] [apisix] Revolyssup opened a new issue, #9304: docs: Wrong URL specified on "Expose API" page while testing.

2023-04-13 Thread via GitHub
Revolyssup opened a new issue, #9304: URL: https://github.com/apache/apisix/issues/9304 ### Current State On this [page](https://github.com/apache/apisix/blob/master/docs/en/latest/tutorials/expose-api.md), the `uri` to match is specified as `/anything/*` but the request is sent on

[GitHub] [apisix] itw-hewb commented on issue #4653: {"error_msg":"failed to match any routes"}

2023-04-13 Thread via GitHub
itw-hewb commented on issue #4653: URL: https://github.com/apache/apisix/issues/4653#issuecomment-1506677687 这是来自QQ邮箱的假期自动回复邮件。   您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [apisix] monkeyDluffy6017 closed issue #4653: {"error_msg":"failed to match any routes"}

2023-04-13 Thread via GitHub
monkeyDluffy6017 closed issue #4653: {"error_msg":"failed to match any routes"} URL: https://github.com/apache/apisix/issues/4653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

  1   2   >