[GitHub] [apisix] unbeatablekb commented on a change in pull request #3084: feat: add proxy_ssl_server_name

2021-01-25 Thread GitBox
unbeatablekb commented on a change in pull request #3084: URL: https://github.com/apache/apisix/pull/3084#discussion_r564233878 ## File path: t/core/proxy_ssl.t ## @@ -0,0 +1,76 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] unbeatablekb commented on a change in pull request #3084: feat: add proxy_ssl_server_name

2021-01-25 Thread GitBox
unbeatablekb commented on a change in pull request #3084: URL: https://github.com/apache/apisix/pull/3084#discussion_r564216971 ## File path: t/APISIX.pm ## @@ -384,6 +384,24 @@ _EOC_ } } +server { +listen 1985 ssl; Review comment: Thanks. I

[GitHub] [apisix] unbeatablekb commented on a change in pull request #3084: feat: add proxy_ssl_server_name

2021-01-25 Thread GitBox
unbeatablekb commented on a change in pull request #3084: URL: https://github.com/apache/apisix/pull/3084#discussion_r564216971 ## File path: t/APISIX.pm ## @@ -384,6 +384,24 @@ _EOC_ } } +server { +listen 1985 ssl; Review comment: Thanks.

[GitHub] [apisix] unbeatablekb commented on a change in pull request #3084: feat: add proxy_ssl_server_name

2021-01-13 Thread GitBox
unbeatablekb commented on a change in pull request #3084: URL: https://github.com/apache/apisix/pull/3084#discussion_r557064216 ## File path: conf/config-default.yaml ## @@ -174,6 +174,8 @@ nginx_config: # config for render the template to generate n

[GitHub] [apisix] unbeatablekb commented on a change in pull request #3084: feat: add proxy_ssl_server_name

2021-01-13 Thread GitBox
unbeatablekb commented on a change in pull request #3084: URL: https://github.com/apache/apisix/pull/3084#discussion_r556989362 ## File path: conf/config-default.yaml ## @@ -174,6 +174,8 @@ nginx_config: # config for render the template to generate n

[GitHub] [apisix] unbeatablekb commented on a change in pull request #3084: feat: add proxy_ssl_server_name

2021-01-03 Thread GitBox
unbeatablekb commented on a change in pull request #3084: URL: https://github.com/apache/apisix/pull/3084#discussion_r551131483 ## File path: conf/config-default.yaml ## @@ -174,6 +174,8 @@ nginx_config: # config for render the template to generate n

[GitHub] [apisix] unbeatablekb commented on a change in pull request #3084: feat: add proxy_ssl_server_name

2020-12-29 Thread GitBox
unbeatablekb commented on a change in pull request #3084: URL: https://github.com/apache/apisix/pull/3084#discussion_r549918075 ## File path: conf/config-default.yaml ## @@ -174,6 +174,8 @@ nginx_config: # config for render the template to generate n

[GitHub] [apisix] unbeatablekb commented on a change in pull request #3084: feat: add proxy_ssl_server_name

2020-12-29 Thread GitBox
unbeatablekb commented on a change in pull request #3084: URL: https://github.com/apache/apisix/pull/3084#discussion_r549917599 ## File path: conf/config-default.yaml ## @@ -174,6 +174,8 @@ nginx_config: # config for render the template to generate n