Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

2017-01-20 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: Applied the multiway fuzzyjoin based on the prefix-based join and the selectFuzzyJoin testCases. .. Patch Set 45: (8 comments) Still more comments... https://ast

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

2017-01-21 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1350 to look at the new patch set (#36). Change subject: Index-only plan step 3: Top-down Select and Join transformation rule

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

2017-01-21 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1434 to look at the new patch set (#8). Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusExpressionToPlanTranslator .

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

2017-01-22 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: Applied the multiway fuzzyjoin based on the prefix-based join and the selectFuzzyJoin testCases. .. Patch Set 47: (10 comments) A few more comments. Besides, ca

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

2017-01-24 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1434 to look at the new patch set (#9). Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusExpressionToPlanTranslator .

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

2017-01-24 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1350 to look at the new patch set (#37). Change subject: Index-only plan step 3: Top-down Select and Join transformation rule

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

2017-01-25 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1434 to look at the new patch set (#10). Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusExpressionToPlanTranslator

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

2017-01-25 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1350 to look at the new patch set (#38). Change subject: Index-only plan step 3: Top-down Select and Join transformation rule

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

2017-01-26 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1434 to look at the new patch set (#11). Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusExpressionToPlanTranslator

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

2017-01-26 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1350 to look at the new patch set (#39). Change subject: Index-only plan step 3: Top-down Select and Join transformation rule

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

2017-01-30 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1434 to look at the new patch set (#12). Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusExpressionToPlanTranslator

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

2017-01-30 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1350 to look at the new patch set (#40). Change subject: Index-only plan step 3: Top-down Select and Join transformation rule

Change in asterixdb[master]: ASTERIXDB-1778: optimize the edit-distance-check function

2017-02-02 Thread Taewoo Kim (Code Review)
Taewoo Kim has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1481 Change subject: ASTERIXDB-1778: optimize the edit-distance-check function .. ASTERIXDB-1778: optimize the edit-distance-check function

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

2017-02-02 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1350 to look at the new patch set (#42). Change subject: Index-only plan step 3: Top-down Select and Join transformation rule

Change in asterixdb[master]: ASTERIXDB-1778: optimize the edit-distance-check function

2017-02-02 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1481 to look at the new patch set (#2). Change subject: ASTERIXDB-1778: optimize the edit-distance-check function .. ASTER

Change in asterixdb[master]: ASTERIXDB-1778: optimize the edit-distance-check function

2017-02-02 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1778: optimize the edit-distance-check function .. Patch Set 2: Added Steven because of BAD failure. -- To view, visit https://asterix-gerrit.ics.uci.ed

Change in asterixdb[master]: ASTERIXDB-1778: optimize the edit-distance-check function

2017-02-02 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1481 to look at the new patch set (#3). Change subject: ASTERIXDB-1778: optimize the edit-distance-check function .. ASTER

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

2017-02-02 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1350 to look at the new patch set (#43). Change subject: Index-only plan step 3: Top-down Select and Join transformation rule

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

2017-02-02 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: Index-only plan step 3: Top-down Select and Join transformation rule .. Patch Set 42: Added Steven because of BAD failure. -- To view, visit https://asterix-gerr

Change in asterixdb[master]: ASTERIXDB-1778: Optimize the edit-distance-check function

2017-02-02 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1481 to look at the new patch set (#4). Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function .. ASTER

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

2017-02-02 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1434 to look at the new patch set (#14). Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusExpressionToPlanTranslator

Change in asterixdb[master]: ASTERIXDB-1778: Optimize the edit-distance-check function

2017-02-03 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function .. Patch Set 3: (11 comments) @Jianfeng: Thanks! https://asterix-gerrit.ics.uci.edu/#/c/1481/4/asterixdb

Change in asterixdb[master]: ASTERIXDB-1778: Optimize the edit-distance-check function

2017-02-03 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1481 to look at the new patch set (#5). Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function .. ASTER

Change in asterixdb[master]: ASTERIXDB-1778: Optimize the edit-distance-check function

2017-02-03 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function .. Patch Set 5: (1 comment) Addressed Chen's comments. https://asterix-gerrit.ics.uci.edu/#/c/1481/5/ast

Change in asterixdb[master]: ASTERIXDB-1778: Optimize the edit-distance-check function

2017-02-03 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1481 to look at the new patch set (#6). Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function .. ASTER

Change in asterixdb[master]: ASTERIXDB-1778: Optimize the edit-distance-check function

2017-02-03 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function .. Patch Set 5: @Jianfeng: the early termination logic is in place. We have test cases for them, too. In

Change in asterixdb[master]: ASTERIXDB-1778: Optimize the edit-distance-check function

2017-02-03 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function .. Patch Set 6: For your comments, edit-distance-check_strings test case already contains that corner cas

Change in asterixdb[master]: ASTERIXDB-1778: Optimize the edit-distance-check function

2017-02-04 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function .. Patch Set 6: @Jianfeng: I now see what you mean. Since the main function is a private function, yes, I

Change in asterixdb[master]: ASTERIXDB-1778: Optimize the edit-distance-check function

2017-02-04 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1481 to look at the new patch set (#7). Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function .. ASTER

Change in asterixdb[master]: ASTERIXDB-1778: Optimize the edit-distance-check function

2017-02-04 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1481 to look at the new patch set (#8). Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function .. ASTER

Change in asterixdb[master]: ASTERIXDB-1778: Optimize the edit-distance-check function

2017-02-05 Thread Taewoo Kim (Code Review)
Taewoo Kim has submitted this change and it was merged. Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function .. ASTERIXDB-1778: Optimize the edit-distance-check function - Only calculate 2 * (threshold + 1

Change in asterixdb[master]: Truncate a temporary file before deleting it.

2017-02-10 Thread Taewoo Kim (Code Review)
Taewoo Kim has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1501 Change subject: Truncate a temporary file before deleting it. .. Truncate a temporary file before deleting it. - Before RunFileReader t

Change in asterixdb[master]: Truncate a temporary file before deleting it.

2017-02-10 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1501 to look at the new patch set (#2). Change subject: Truncate a temporary file before deleting it. .. Truncate a tempor

Change in asterixdb[master]: Truncate a temporary file before deleting it.

2017-02-10 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1501 to look at the new patch set (#3). Change subject: Truncate a temporary file before deleting it. .. Truncate a tempor

Change in asterixdb[master]: Truncate a temporary file before deleting it.

2017-02-11 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: Truncate a temporary file before deleting it. .. Patch Set 3: (1 comment) Thanks Yingyi. https://asterix-gerrit.ics.uci.edu/#/c/1501/3/hyracks-fullstack/hyracks/h

Change in asterixdb[master]: Truncate a temporary file before deleting it.

2017-02-11 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1501 to look at the new patch set (#4). Change subject: Truncate a temporary file before deleting it. .. Truncate a tempor

Change in asterixdb[master]: Truncate a temporary file before deleting it.

2017-02-12 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1501 to look at the new patch set (#5). Change subject: Truncate a temporary file before deleting it. .. Truncate a tempor

Change in asterixdb[master]: Truncate a temporary file before deleting it.

2017-02-12 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: Truncate a temporary file before deleting it. .. Patch Set 4: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1501/4/hyracks-fullstack/hyracks/hyracks-dataflow-

Change in asterixdb[master]: Truncate a temporary file before deleting it.

2017-02-12 Thread Taewoo Kim (Code Review)
Taewoo Kim has submitted this change and it was merged. Change subject: Truncate a temporary file before deleting it. .. Truncate a temporary file before deleting it. - Before RunFileReader tries to delete a temporary file,

Change in asterixdb[master]: ASTERIXDB-1791: Add a sanity check to hashjoin partition rea...

2017-02-13 Thread Taewoo Kim (Code Review)
Taewoo Kim has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1505 Change subject: ASTERIXDB-1791: Add a sanity check to hashjoin partition reading .. ASTERIXDB-1791: Add a sanity check to hashjoin partit

Change in asterixdb[master]: ASTERIXDB-1791: Add a sanity check to hashjoin partition rea...

2017-02-13 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1505 to look at the new patch set (#2). Change subject: ASTERIXDB-1791: Add a sanity check to hashjoin partition reading ..

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

2017-02-15 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusExpressionToPlanTranslator .. Patch Set 17: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1434/17/a

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

2017-02-16 Thread Taewoo Kim (Code Review)
Taewoo Kim has submitted this change and it was merged. Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusExpressionToPlanTranslator .. AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusExpressi

Change in asterixdb[master]: ASTERIXDB-1806: let inject_failure not utilize an index

2017-02-28 Thread Taewoo Kim (Code Review)
Taewoo Kim has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1536 Change subject: ASTERIXDB-1806: let inject_failure not utilize an index .. ASTERIXDB-1806: let inject_failure not utilize an index - Le

Change in asterixdb[master]: ASTERIXDB-1806: let inject_failure not utilize an index

2017-02-28 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1536 to look at the new patch set (#2). Change subject: ASTERIXDB-1806: let inject_failure not utilize an index .. ASTERIX

Change in asterixdb[master]: ASTERIXDB-1806: let inject_failure not utilize an index

2017-02-28 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1536 to look at the new patch set (#3). Change subject: ASTERIXDB-1806: let inject_failure not utilize an index .. ASTERIX

Change in asterixdb[master]: ASTERIXDB-1806: let inject_failure not utilize an index

2017-02-28 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1806: let inject_failure not utilize an index .. Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1536/1/asterixdb/asterix-common/src/mai

Change in asterixdb[master]: ASTERIXDB-1806: let inject_failure not utilize an index

2017-02-28 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1536 to look at the new patch set (#4). Change subject: ASTERIXDB-1806: let inject_failure not utilize an index .. ASTERIX

Change in asterixdb[master]: ASTERIXDB-1806: let inject_failure not utilize an index

2017-02-28 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1806: let inject_failure not utilize an index .. Patch Set 4: Added Steven since BAD test fails. -- To view, visit https://asterix-gerrit.ics.uci.edu/15

Change in asterixdb[master]: Index-only plan

2016-06-17 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: Index-only plan .. Patch Set 9: To reviewers: I will add more comments to this patch and let you know soon. Do not start reviewing the code yet. -- To view, visi

Change in asterixdb[master]: Index-only plan

2016-06-21 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: Index-only plan .. Patch Set 9: (238 comments) https://asterix-gerrit.ics.uci.edu/#/c/744/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/ru

Change in asterixdb[master]: [ASTERIXDB-2437][COMP] Ensure the index-only plan on a compo...

2018-09-22 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2854 to look at the new patch set (#4). Change subject: [ASTERIXDB-2437][COMP] Ensure the index-only plan on a composite index ...

Change in asterixdb[master]: [ASTERIXDB-2437][COMP] Ensure the index-only plan on a compo...

2018-09-22 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2854 to look at the new patch set (#5). Change subject: [ASTERIXDB-2437][COMP] Ensure the index-only plan on a composite index ...

Change in asterixdb[master]: [ASTERIXDB-2437][COMP] Ensure the index-only plan on a compo...

2018-09-22 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2437][COMP] Ensure the index-only plan on a composite index .. Patch Set 3: (2 comments) @Dmitry: thanks. I have addressed your comments. https://aste

Change in asterixdb[master]: [ASTERIXDB-2454][TEST] Remove most of AQL runtime test cases

2018-09-23 Thread Taewoo Kim (Code Review)
Taewoo Kim has uploaded a new patch set (#2). Change subject: [ASTERIXDB-2454][TEST] Remove most of AQL runtime test cases .. [ASTERIXDB-2454][TEST] Remove most of AQL runtime test cases - user model changes: no - storage format

Change in asterixdb[master]: [ASTERIXDB-2454][TEST] Remove most of AQL runtime test cases

2018-09-23 Thread Taewoo Kim (Code Review)
Taewoo Kim has uploaded a new patch set (#3). Change subject: [ASTERIXDB-2454][TEST] Remove most of AQL runtime test cases .. [ASTERIXDB-2454][TEST] Remove most of AQL runtime test cases - user model changes: no - storage format

Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-09-24 Thread Taewoo Kim (Code Review)
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1076 to look at the new patch set (#91). Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins ...

Change in asterixdb[master]: [ASTERIXDB-2437][COMP] Ensure the index-only plan on a compo...

2018-09-24 Thread Taewoo Kim (Code Review)
Taewoo Kim has submitted this change and it was merged. Change subject: [ASTERIXDB-2437][COMP] Ensure the index-only plan on a composite index .. [ASTERIXDB-2437][COMP] Ensure the index-only plan on a composite index - user mo

Change in asterixdb[master]: [ASTERIXDB-2455][DOC] Deprecate AQL documentations

2018-09-24 Thread Taewoo Kim (Code Review)
Taewoo Kim has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2977 Change subject: [ASTERIXDB-2455][DOC] Deprecate AQL documentations .. [ASTERIXDB-2455][DOC] Deprecate AQL documentations - user model ch

Change in asterixdb[master]: [ASTERIXDB-2455][DOC] Deprecate AQL documentations

2018-09-24 Thread Taewoo Kim (Code Review)
Taewoo Kim has submitted this change and it was merged. Change subject: [ASTERIXDB-2455][DOC] Deprecate AQL documentations .. [ASTERIXDB-2455][DOC] Deprecate AQL documentations - user model changes: no - storage format changes:

Change in asterixdb[master]: [NO ISSUE] User-defined Function Documentation update

2018-09-25 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [NO ISSUE] User-defined Function Documentation update .. Patch Set 11: Can you rebase the patch set first? :-) -- To view, visit https://asterix-gerrit.ics.uci.ed

Change in asterixdb[master]: [NO ISSUE] User-defined Function Documentation update

2018-09-27 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [NO ISSUE] User-defined Function Documentation update .. Patch Set 15: (1 comment) Just one question. https://asterix-gerrit.ics.uci.edu/#/c/2804/15/asterixdb/ast

Change in asterixdb[master]: [NO ISSUE] User-defined Function Documentation update

2018-09-27 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [NO ISSUE] User-defined Function Documentation update .. Patch Set 15: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2804 To unsubscribe, visi

Change in asterixdb[master]: [NO ISSUE] User-defined Function Documentation update

2018-09-28 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [NO ISSUE] User-defined Function Documentation update .. Patch Set 16: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2804 To unsubscribe, visi

Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-02 Thread Taewoo Kim (Code Review)
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1076 to look at the new patch set (#93). Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins ...

Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-03 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins .. Patch Set 93: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/1076/5//COMMIT_MSG Commit Message: Line

Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-03 Thread Taewoo Kim (Code Review)
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1076 to look at the new patch set (#94). Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins ...

Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-03 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins .. Patch Set 93: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1076/93/asterixdb/asterix-algebra/src/mai

Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-08 Thread Taewoo Kim (Code Review)
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1076 to look at the new patch set (#96). Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins ...

Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-08 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins .. Patch Set 93: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1076/93/asterixdb/asterix-algebra/src/mai

Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-08 Thread Taewoo Kim (Code Review)
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1076 to look at the new patch set (#97). Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins ...

Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-08 Thread Taewoo Kim (Code Review)
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1076 to look at the new patch set (#98). Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins ...

Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-08 Thread Taewoo Kim (Code Review)
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1076 to look at the new patch set (#99). Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins ...

Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-08 Thread Taewoo Kim (Code Review)
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1076 to look at the new patch set (#100). Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins ..

Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-09 Thread Taewoo Kim (Code Review)
Taewoo Kim has submitted this change and it was merged. Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins .. [NO ISSUE][COMP][RT] Enable multiway similarity joins - Enable the FuzzyJoinRule that transforms

Change in asterixdb[master]: [NO ISSUE][COMP][RT] Enable multiway similarity joins

2018-10-09 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins .. Patch Set 100: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1076 To unsubscribe, vis

Change in asterixdb[master]: [ASTERIXDB-2454][TEST] Remove most of AQL runtime test cases

2018-10-17 Thread Taewoo Kim (Code Review)
Taewoo Kim has abandoned this change. Change subject: [ASTERIXDB-2454][TEST] Remove most of AQL runtime test cases .. Abandoned Ian Maxon will take care of this issue. -- To view, visit https://asterix-gerrit.ics.uci.edu/2976

Change in asterixdb[master]: [ASTERIXDB-2454] Remove non-unique AQL tests

2018-10-17 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2454] Remove non-unique AQL tests .. Patch Set 7: Code-Review+2 LGTM. Thanks! -- To view, visit https://asterix-gerrit.ics.uci.edu/2979 To unsubscribe,

Change in asterixdb[master]: [ASTERIXDB-2466][FUN] Implement window functions

2018-10-28 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2466][FUN] Implement window functions .. Patch Set 2: (12 comments) Ali already gave good comments. I have some questions. (1) What does "materializati

Change in asterixdb[master]: [ASTERIXDB-2454] Remove non-unique AQL tests (pt.1)

2018-10-29 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2454] Remove non-unique AQL tests (pt.1) .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3007 To unsubscribe, visit h

Change in asterixdb[master]: [ASTERIXDB-2468] Extend CountVarToCountOneRule to support no...

2018-11-20 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2468] Extend CountVarToCountOneRule to support no group-by .. Patch Set 9: @Dmitry: Chen checked that the CountVartoCountOneRule only removes the ASSIGN

Change in asterixdb[master]: [ASTERIXDB-2411][COMP] Error when aggregate inside between o...

2018-07-13 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2411][COMP] Error when aggregate inside between operator .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2759 To uns

Change in asterixdb[master]: ASTERIXDB-2418][COMP] Fix NPE in SqlppExpressionToPlanTransl...

2018-07-19 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-2418][COMP] Fix NPE in SqlppExpressionToPlanTranslator .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2789 To unsubsc

Change in asterixdb[master]: [ASTERIXDB-2417][COMP] Fix issues with LIMIT clause

2018-07-20 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2417][COMP] Fix issues with LIMIT clause .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2788 To unsubscribe, visit h

Change in asterixdb[master]: [ASTERIXDB-2420][COMP] Internal error with limit clause

2018-07-24 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2420][COMP] Internal error with limit clause .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2805 To unsubscribe, vis

Change in asterixdb[master]: [ASTERIXDB-2424][COMP] No limit pushdown if multiple limit c...

2018-07-26 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2424][COMP] No limit pushdown if multiple limit clauses .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2815 To unsu

Change in asterixdb[master]: [ASTERIXDB-2428][COMP] Incorrect result with limit if offset...

2018-07-27 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2428][COMP] Incorrect result with limit if offset is negative .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2821 T

Change in asterixdb[master]: [ASTERIXDB-2434][COMP] Ensure execution mode before EnforceS...

2018-08-07 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2434][COMP] Ensure execution mode before EnforceStructuralPropertiesRule .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci

Change in asterixdb[master]: [ASTERIXDB-2437][COMP] Ensure the index-only plan on a compo...

2018-08-07 Thread Taewoo Kim (Code Review)
Taewoo Kim has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2854 Change subject: [ASTERIXDB-2437][COMP] Ensure the index-only plan on a composite index .. [ASTERIXDB-2437][COMP] Ensure the index-only p

Change in asterixdb[master]: [ASTERIXDB-2437][COMP] Ensure the index-only plan on a compo...

2018-08-07 Thread Taewoo Kim (Code Review)
Taewoo Kim has uploaded a new patch set (#2). Change subject: [ASTERIXDB-2437][COMP] Ensure the index-only plan on a composite index .. [ASTERIXDB-2437][COMP] Ensure the index-only plan on a composite index - user model changes

Change in asterixdb[master]: [ASTERIXDB-2437][COMP] Ensure the index-only plan on a compo...

2018-08-07 Thread Taewoo Kim (Code Review)
Taewoo Kim has uploaded a new patch set (#3). Change subject: [ASTERIXDB-2437][COMP] Ensure the index-only plan on a composite index .. [ASTERIXDB-2437][COMP] Ensure the index-only plan on a composite index - user model changes

Change in asterixdb[master]: [ASTERIXDB-2438][COMP] Allow assigns when pushing limit into...

2018-08-08 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2438][COMP] Allow assigns when pushing limit into data scan .. Patch Set 1: Code-Review+2 (1 comment) Can you remove a trailing white space? Just a min

Change in asterixdb[master]: [ASTERIXDB-2440][COMP] Compiler failure with IN expression

2018-08-13 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2440][COMP] Compiler failure with IN expression .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2890 To unsubscribe,

Change in asterixdb[master]: ASTERIXDB-1806: let inject_failure not utilize an index

2017-03-02 Thread Taewoo Kim (Code Review)
Taewoo Kim has submitted this change and it was merged. Change subject: ASTERIXDB-1806: let inject_failure not utilize an index .. ASTERIXDB-1806: let inject_failure not utilize an index - Change the condition check logic of i

Change in asterixdb[master]: Let SPLIT operator work as expected

2017-03-02 Thread Taewoo Kim (Code Review)
Taewoo Kim has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1542 Change subject: Let SPLIT operator work as expected .. Let SPLIT operator work as expected - Let SPLIT operator function as expected in

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

2017-03-02 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: Index-only plan step 3: Top-down Select and Join transformation rule .. Patch Set 45: (6 comments) Thanks Yingyi. https://asterix-gerrit.ics.uci.edu/#/c/1350/45/

Change in asterixdb[master]: Let SPLIT operator work as expected

2017-03-02 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1542 to look at the new patch set (#2). Change subject: Let SPLIT operator work as expected .. Let SPLIT operator work as

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

2017-03-02 Thread Taewoo Kim (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1350 to look at the new patch set (#49). Change subject: Index-only plan step 3: Top-down Select and Join transformation rule

Change in asterixdb[master]: Index-only plan step 3: Top-down Select and Join transformat...

2017-03-03 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: Index-only plan step 3: Top-down Select and Join transformation rule .. Patch Set 49: (6 comments) Addressed the SonarQube comments. https://asterix-gerrit.ics.u

Change in asterixdb[master]: Let SPLIT operator work as expected

2017-03-03 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change. Change subject: Let SPLIT operator work as expected .. Patch Set 2: (11 comments) Thanks Yingyi. https://asterix-gerrit.ics.uci.edu/#/c/1542/2/hyracks-fullstack/algebricks/algebr

<    1   2   3   4   5   6   7   8   9   >