[GitHub] couchdb-chttpd pull request #128: Call appropriate sockname function for soc...

2016-06-28 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-chttpd/pull/128 Call appropriate sockname function for socket type COUCHDB: 3049 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb

[GitHub] couchdb-chttpd issue #128: Call appropriate sockname function for socket typ...

2016-06-28 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-chttpd/pull/128 BTW, are we delaying merge until after 2.0 code freeze? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-chttpd issue #128: Call appropriate sockname function for socket typ...

2016-06-28 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-chttpd/pull/128 Ok, can you merge for me? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] couchdb-chttpd pull request #130: 3049 fix sockname

2016-07-07 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-chttpd/pull/130 3049 fix sockname @rnewson, @iilyak You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-chttpd 3049-fix-sockname

[GitHub] couchdb-chttpd issue #130: 3049 fix sockname

2016-07-07 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-chttpd/pull/130 Yes, I seem to have tested that code snippet on a non-mochiweb socket (without the tuple), which is utterly my bad :( --- If your project is set up for it, you can reply to this email and

[GitHub] couchdb-couch pull request #185: 3061 adaptive header search

2016-07-15 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-couch/pull/185 3061 adaptive header search The current find_header algorithm performs one file read per block, which can be inefficient when the most recent header is buried deeply in a large file

[GitHub] couchdb-couch issue #185: 3061 adaptive header search

2016-07-15 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch/pull/185 I've been testing with this repl command: ```erlang _time_find_header = fun(File, Algorithm) when is_list(File) -> FileSize = filelib:file_size(File),

[GitHub] couchdb-couch issue #185: 3061 adaptive header search

2016-07-18 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch/pull/185 @theburge, @kocolosk, @davisp, @eiri: can I get some feedback on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] couchdb-couch pull request #185: 3061 adaptive header search

2016-07-18 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/185#discussion_r71275114 --- Diff: src/couch_file.erl --- @@ -524,6 +525,99 @@ handle_info({'EXIT', _, Reason}, Fd) -> {stop, Reason, Fd}.

[GitHub] couchdb-couch pull request #185: 3061 adaptive header search

2016-07-18 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/185#discussion_r71279401 --- Diff: src/couch_file.erl --- @@ -524,6 +525,99 @@ handle_info({'EXIT', _, Reason}, Fd) -> {stop, Reason, Fd}.

[GitHub] couchdb-couch pull request #185: 3061 adaptive header search

2016-07-19 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/185#discussion_r71461794 --- Diff: src/couch_file.erl --- @@ -524,6 +525,99 @@ handle_info({'EXIT', _, Reason}, Fd) -> {stop, Reason, Fd}.

[GitHub] couchdb-couch pull request #185: 3061 adaptive header search

2016-07-19 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/185#discussion_r71462210 --- Diff: src/couch_file.erl --- @@ -524,6 +525,99 @@ handle_info({'EXIT', _, Reason}, Fd) -> {stop, Reason, Fd}.

[GitHub] couchdb-couch pull request #185: 3061 adaptive header search

2016-07-19 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/185#discussion_r71463607 --- Diff: src/couch_file.erl --- @@ -524,6 +525,99 @@ handle_info({'EXIT', _, Reason}, Fd) -> {stop, Reason, Fd}.

[GitHub] couchdb-couch pull request #185: 3061 adaptive header search

2016-07-19 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/185#discussion_r71463598 --- Diff: src/couch_file.erl --- @@ -524,6 +525,99 @@ handle_info({'EXIT', _, Reason}, Fd) -> {stop, Reason, Fd}.

[GitHub] couchdb-couch issue #185: 3061 adaptive header search

2016-07-19 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch/pull/185 Thank you @davisp for the thorough review! I will address your points in turn: > the timing numbers reported are in microseconds so I'm not super convinced on them. What

[GitHub] couchdb-couch issue #185: 3061 adaptive header search

2016-07-20 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch/pull/185 @davisp, thanks for the explanation. You were of course correct that I was confusing `pread/3` with `pread/2`. I think it makes sense to look at an alternate version of header search which

[GitHub] couchdb-couch issue #185: 3061 adaptive header search

2016-09-10 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch/pull/185 I have simplified the pread/2 based header search, and hopefully addressed most of the issues raised against the previous implementations. For a simple speed comparison using the same file

[GitHub] couchdb-couch issue #185: 3061 adaptive header search

2016-09-15 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch/pull/185 @davisp, @theburge, et al, can you guys take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] couchdb-couch issue #185: 3061 adaptive header search

2016-09-21 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch/pull/185 The following image adds vmpage_io.memory.in vmpage_io.memory.out to the experiment. All experiments were searching 4 files in parallel. The first starts around 23:48, using the current

[GitHub] couchdb-fabric pull request #71: Fix compiler warning

2016-09-29 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-fabric/pull/71 Fix compiler warning You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-fabric fix-compiler-warning Alternatively you

[GitHub] couchdb-fabric issue #71: Fix compiler warning

2016-09-29 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-fabric/pull/71 Thanks, @nickva -- can you merge for me pls? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fabric issue #71: Fix compiler warning

2016-09-29 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-fabric/pull/71 Thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] couchdb-fabric issue #71: Fix compiler warning

2016-09-29 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-fabric/pull/71 \o/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] couchdb-fabric pull request #71: Fix compiler warning

2016-09-29 Thread jaydoane
Github user jaydoane closed the pull request at: https://github.com/apache/couchdb-fabric/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-couch pull request #185: 3061 adaptive header search

2016-10-02 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/185#discussion_r81476893 --- Diff: src/couch_file.erl --- @@ -531,27 +537,96 @@ find_header(Fd, Block) -> {ok, Bin} -> {ok, Bin};

[GitHub] couchdb-couch pull request #185: 3061 adaptive header search

2016-10-02 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/185#discussion_r81490840 --- Diff: src/couch_file.erl --- @@ -531,27 +537,96 @@ find_header(Fd, Block) -> {ok, Bin} -> {ok, Bin};

[GitHub] couchdb-couch pull request #185: 3061 adaptive header search

2016-10-03 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/185#discussion_r81645651 --- Diff: src/couch_file.erl --- @@ -531,27 +537,96 @@ find_header(Fd, Block) -> {ok, Bin} -> {ok, Bin};

[GitHub] couchdb-couch issue #185: 3061 adaptive header search

2016-10-04 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch/pull/185 @davisp, formatting fixed in latest commit. Here's a proposed commit message: > Current behavior attempts to read a header at each block, starting at the eof and

[GitHub] couchdb-couch pull request #:

2016-10-05 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/commit/d5fbb6dd0d770861222b6a5de3124f10d9eafd4f#commitcomment-19309476 In src/couch_file.erl: In src/couch_file.erl on line 597: Ugh, you are right @iilyak :( I will create a patch

[GitHub] couchdb-couch issue #203: update typespec of find_newest_header

2016-10-05 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch/pull/203 +1 (and, oops!) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] couchdb-couch-mrview pull request #58: Retry failures in couch_mrview_compac...

2016-10-07 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-couch-mrview/pull/58 Retry failures in couch_mrview_compactor:recompact Currently, if there's an error in the spawned couch_index_updater:update process, the receive block will not match the me

[GitHub] couchdb-couch-mrview issue #58: Retry failures in couch_mrview_compactor:rec...

2016-10-07 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch-mrview/pull/58 @davisp, not sure if this is exactly what you had in mind, but I thought I'd take a stab at it to get the ball rolling --- If your project is set up for it, you can reply to

[GitHub] couchdb-couch-mrview issue #58: Retry failures in couch_mrview_compactor:rec...

2016-10-10 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch-mrview/pull/58 @davisp, thanks for the diff. I updated the PR, added `Pid` and `Ref` params to `recompact_loop` function, and fixed the `State` name issue for `'$gen_cast'` case. O

[GitHub] couchdb-couch-mrview pull request #58: Retry failures in couch_mrview_compac...

2016-10-15 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/58#discussion_r83543939 --- Diff: src/couch_mrview_compactor.erl --- @@ -148,16 +149,41 @@ compact(State) -> recompact(State) -> +rec

[GitHub] couchdb-couch-mrview issue #58: Retry failures in couch_mrview_compactor:rec...

2016-10-15 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch-mrview/pull/58 @davisp, I added a couple tests which seem to exercise all the new retry/progress logic. I'm not familiar with the `~r` control sequence in the `couch_log:warning`, nor

[GitHub] couchdb-couch-mrview issue #58: Retry failures in couch_mrview_compactor:rec...

2016-10-17 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch-mrview/pull/58 @davisp, thanks for the review. Can you merge this for me? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] couchdb-couch pull request #209: remove compact files on failure

2016-10-27 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/209#discussion_r85454009 --- Diff: src/couch_db_updater.erl --- @@ -1454,3 +1450,13 @@ default_security_object(_DbName) -> "

[GitHub] couchdb-couch issue #209: remove compact files on failure

2016-10-28 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch/pull/209 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-couch-mrview issue #59: exceeded_recompact_retry_count: add DbName/I...

2016-11-02 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch-mrview/pull/59 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] couchdb-chttpd issue #146: Handle error terms from fabric

2016-11-09 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-chttpd/pull/146 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] couchdb-couch pull request #206: handle errors terms from fabric

2016-11-09 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/206#discussion_r87302756 --- Diff: test/couchdb_mrview_tests.erl --- @@ -73,6 +78,19 @@ mrview_update_test_() -> } }. +mrview_query_te

[GitHub] couchdb-couch issue #206: handle errors terms from fabric

2016-11-09 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch/pull/206 LGTM, with the caveat that we seem to be unnecessarily running the same test twice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] couchdb-couch pull request #205: truncate revs to revs limit

2016-11-09 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/205#discussion_r87305484 --- Diff: test/couch_db_doc_tests.erl --- @@ -0,0 +1,93 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); yo

[GitHub] couchdb-couch pull request #205: truncate revs to revs limit

2016-11-09 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/205#discussion_r87305643 --- Diff: test/couch_db_doc_tests.erl --- @@ -0,0 +1,93 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); yo

[GitHub] couchdb-couch issue #205: truncate revs to revs limit

2016-11-09 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch/pull/205 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-documentation pull request #88: Fix os_process_limit documentation

2016-11-15 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-documentation/pull/88 Fix os_process_limit documentation Update documentation with correct description of os_process_limit parameter function, correct default value, and hints for typical

[GitHub] couchdb-documentation issue #88: Fix os_process_limit documentation

2016-11-15 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-documentation/pull/88 While the internal default is indeed 100, it's set to 25 in rel/overlay/etc/default.ini -- so I guess it depends on what you mean by "default". I'm happy to chan

[GitHub] couchdb-documentation issue #88: Fix os_process_limit documentation

2016-11-16 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-documentation/pull/88 @rnewson thanks for the review. If you're ok with this, can you +1 and merge for me? Also, shall I open a PR to just remove the explicit hard limit of 25 in defaul

[GitHub] couchdb-couch issue #216: Make couchjs -S option take effect

2016-11-30 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch/pull/216 +1 Though it's curious how the previous fix https://issues.apache.org/jira/browse/COUCHDB-1792 was apparently never applied. However, it clearly seems to be the right thing

[GitHub] couchdb-couch issue #216: Make couchjs -S option take effect

2016-11-30 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch/pull/216 Yes, maybe reverted during a refactor, since all the files that patch applied to (sm170.c, sm180.c, sm185.c) no longer exist. I guess that's easy to do with an absence of unit

[GitHub] couchdb pull request #444: Git ignore rel/snap*

2016-11-30 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb/pull/444 Git ignore rel/snap* Ignore these files in rel: snap.ini snap_run* snapcraft.yaml You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] couchdb issue #444: Git ignore rel/snap*

2016-11-30 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb/pull/444 Thanks @nickva -- can you also merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-couch-replicator pull request #54: Allow configuring maximum documen...

2017-02-03 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/54#discussion_r99449067 --- Diff: src/couch_replicator_changes_reader.erl --- @@ -89,9 +89,20 @@ process_change(#doc_info{id = <<>>} = Doc

[GitHub] couchdb-couch-replicator issue #54: Allow configuring maximum document ID le...

2017-02-03 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/54 LGTM, FWIW --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] couchdb-couch-mrview issue #70: Fix undef error on empty list function respo...

2017-03-15 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch-mrview/pull/70 Having written tests to ensure the patch works as directed, I'm (non-voting) "+1" --- If your project is set up for it, you can reply to this email and have your

[GitHub] couchdb-couch-mrview pull request #70: Fix undef error on empty list functio...

2017-03-15 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/70#discussion_r106344486 --- Diff: src/couch_mrview_show.erl --- @@ -426,4 +424,31 @@ should_apply_headers_with_merge_overwrite() -> ?assertEq

[GitHub] couchdb-couch-mrview pull request #72: Fix end-point _local_docs

2017-03-21 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107325722 --- Diff: test/couch_mrview_local_docs_tests.erl --- @@ -0,0 +1,134 @@ +% Licensed under the Apache License, Version 2.0 (the "Li

[GitHub] couchdb-couch-mrview issue #72: Fix end-point _local_docs

2017-03-21 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch-mrview/pull/72 This LGTM, and tests pass for me locally: ``` module 'couch_mrview_local_docs_tests' _local_docs view tests couch_mrview_local_docs_tests:68: should_

[GitHub] couchdb-couch-log pull request #17: Fix dns timeout for undefined syslog hos...

2017-03-26 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-couch-log/pull/17 Fix dns timeout for undefined syslog host On some platforms, inet:getaddr can take several seconds to return when passed the undefined atom, which is the default value of "syslog

[GitHub] couchdb-couch-log issue #17: Fix dns timeout for undefined syslog host

2017-03-27 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch-log/pull/17 @davisp do you mind taking a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-couch-log issue #17: Fix dns timeout for undefined syslog host

2017-03-27 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch-log/pull/17 @iilyak @davisp thanks for the review. Can someone merge this for me? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] couchdb-ets-lru pull request #7: Suppress erlang:now/0 deprecation warnings

2018-12-06 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-ets-lru/pull/7 Suppress erlang:now/0 deprecation warnings You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-ets-lru suppress-compiler

[GitHub] couchdb-ets-lru issue #7: Suppress erlang:now/0 deprecation warnings

2018-12-06 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-ets-lru/pull/7 Since the topic is access and creation time comparison for purposes of cache eviction, it doesn't seem important whether or not those values are monotonically increasing, nor particu

[GitHub] couchdb-ets-lru issue #7: Suppress erlang:now/0 deprecation warnings

2018-12-07 Thread jaydoane
Github user jaydoane commented on the issue: https://github.com/apache/couchdb-ets-lru/pull/7 I'm definitely _not_ sure, and would appreciate if @rnewson or another person very experienced with ets_lru would chime in. ---

[GitHub] couchdb pull request: Git ignore .pyc (compiled python) files

2015-05-25 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb/pull/323 Git ignore .pyc (compiled python) files You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaydoane/couchdb git-ignore-pyc Alternatively you

[GitHub] couchdb pull request: Git ignore .pyc (compiled python) files

2015-05-25 Thread jaydoane
Github user jaydoane closed the pull request at: https://github.com/apache/couchdb/pull/323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] couchdb-couch-replicator pull request: Handle case when replicatio...

2015-06-29 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-couch-replicator/pull/12 Handle case when replication param "doc_ids": "null" BugzID: 48602 You can merge this pull request into a Git repository by running: $ git pull https:/

[GitHub] couchdb-couch-replicator pull request: Handle case when replicatio...

2015-06-29 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/12#issuecomment-116819764 Yes, it seems like this is a special case for clients who do not understand that "null" != null. Still, returning a 500 doesn't see

[GitHub] couchdb-couch-replicator pull request: Handle case when replicatio...

2015-06-29 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/12#issuecomment-116834561 AFAICT, there's no specific client that is sending this, but it was apparently discovered in testing. The internal Cloudant bug that th

[GitHub] couchdb-couch-replicator pull request: Handle case when replicatio...

2015-07-03 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/12#issuecomment-118463246 It seems like the fundamental issue is that "null" is a string, but we're expecting an array. My inclination would be to return a re

[GitHub] couchdb-couch-replicator pull request: Handle case when replicatio...

2015-07-03 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/12#issuecomment-11846 As an aside, it seems like a more declarative approach to error handling might be desirable. --- If your project is set up for it, you can reply to

[GitHub] couchdb-couch pull request: 48864 bad request on post missing body...

2015-07-08 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-couch/pull/66 48864 bad request on post missing body doc ids filter You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch 48864-bad

[GitHub] couchdb-couch pull request: 48864 bad request on post missing body...

2015-07-08 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/pull/66#issuecomment-119642911 Hmm, of course I was only trying to pull my own changes in... --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] couchdb-couch pull request: 48864 bad request on post missing body...

2015-07-08 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/pull/66#issuecomment-119720733 Righto. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-couch pull request: 48864 bad request on post missing body...

2015-07-08 Thread jaydoane
Github user jaydoane closed the pull request at: https://github.com/apache/couchdb-couch/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-08 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-couch/pull/67 Throw bad request for empty POST request body when filtering by doc_ids BugzID: 48864 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] couchdb-couch pull request: 48864 bad request on post missing body...

2015-07-08 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/pull/66#issuecomment-119729906 I couldn't figure out how to push here, but have opened PR 67 which hopefully has the correct changes. --- If your project is set up for it, you can rep

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-08 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/pull/67#issuecomment-119732326 But this handles the case when the request body is omitted entirely (not just an empty string). --- If your project is set up for it, you can reply to this

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-08 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/pull/67#issuecomment-119733541 ``` curl -vX POST http://adm:pass@127.0.0.1:15984/db1/_changes?filter=_doc_ids -H "Content-Type: application/json" * Hostname was NOT found in

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-08 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/pull/67#issuecomment-119735581 @kxepal: no, I don't think this is specific for chttpd. It came up because someone had tried to use the _doc_ids changes filter without including a body an

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-08 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/pull/67#issuecomment-119735957 ok, I'll open a JIRA ticket, and can also change the wording. I like `_doc_ids` filter requires JSON object body with field "doc_ids" containin

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-08 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/pull/67#issuecomment-119738290 https://issues.apache.org/jira/browse/COUCHDB-2743 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-08 Thread jaydoane
Github user jaydoane closed the pull request at: https://github.com/apache/couchdb-couch/pull/67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-08 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/pull/67#issuecomment-119749343 Thought I could accomplish same as force push by deleting remote branch and re-creating, but was wrong. There's no apparent way to re-open from th

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-08 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-couch/pull/68 Throw bad request for empty POST request body when filtering by doc_ids JIRA: COUCHDB-2743 BugzID: 48864 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-08 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/pull/68#issuecomment-119750405 Please see https://github.com/apache/couchdb-couch/pull/68 for discussion. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-08 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/pull/67#issuecomment-119751184 Yes, I understand that I should have done something like this: git push origin 48864-bad-request-on-post-missing-body-doc-ids-filter --force but I was

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-08 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/pull/68#issuecomment-119752179 Going to try closing this PR in the hopes that doing so may allow me to re-open #67. --- If your project is set up for it, you can reply to this email and have

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-08 Thread jaydoane
Github user jaydoane closed the pull request at: https://github.com/apache/couchdb-couch/pull/68 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-08 Thread jaydoane
GitHub user jaydoane reopened a pull request: https://github.com/apache/couchdb-couch/pull/68 Throw bad request for empty POST request body when filtering by doc_ids JIRA: COUCHDB-2743 BugzID: 48864 You can merge this pull request into a Git repository by running: $ git

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-08 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/pull/68#issuecomment-119752401 No, the UI is not allowing me to re-open #67. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] couchdb-couch pull request: Throw bad request for empty POST reque...

2015-07-11 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/pull/68#issuecomment-120666964 I did test, but not this particular case, unfortunately. I agree that it's broken because of that patch. Going to poke around a bit to see if it can be rep

[GitHub] couchdb-chttpd pull request: Read request body on POST to changes ...

2015-07-11 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/42#issuecomment-120673633 FWIW, this does seem to fix the problem for me locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb-couch pull request:

2015-07-12 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/commit/b65c9180c10f67ba84c9ab92a0f5f43ed0c1a8a4#commitcomment-12124271 This makes a lot of sense. For those following at home, here's the call stack that gets us

[GitHub] couchdb-couch-replicator pull request: Handle case when replicatio...

2015-07-13 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/12#issuecomment-121134650 The follow-up PR: https://github.com/cloudant/chttpd-local/pull/15 --- If your project is set up for it, you can reply to this email and have your

[GitHub] couchdb-couch-epi pull request: Add couch_epi:decide/5

2015-10-09 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch-epi/pull/15#discussion_r41673057 --- Diff: README.md --- @@ -97,6 +97,22 @@ Notes: - `concurrent` is incompatible with `pipe` +## decide functionality

[GitHub] couchdb-chttpd pull request: Handle bad replicate request

2015-10-18 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-chttpd/pull/83 Handle bad replicate request This patch is correctly handles https://github.com/apache/couchdb-couch-replicator/pull/12, and obsoletes https://github.com/cloudant/chttpd-local/pull/15

[GitHub] couchdb-couch-replicator pull request: Handle case when replicatio...

2015-10-18 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/12#issuecomment-149098426 @kxepal, I have closed the obsolete https://github.com/cloudant/chttpd-local/pull/15 and opened https://github.com/apache/couchdb-chttpd/pull/83

[GitHub] couchdb-chttpd pull request: Explicitly create admin user and auth...

2015-11-01 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-chttpd/pull/91 Explicitly create admin user and authenticate requests in chttpd_db_test cases This patch explicitly configures an admin user and then makes all requests using that user's creden

[GitHub] couchdb-config pull request: Don't start lager during setup for ea...

2015-11-01 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-config/pull/7 Don't start lager during setup for each config_test BugzID: 55507 COUCHDB-2866 You can merge this pull request into a Git repository by running: $ git pull https://githu

  1   2   >