[GitHub] couchdb issue #425: Improve reduce function overlow handling

2016-08-01 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/425 @nickva Hmmok. I still don't like it, but cannot propose anything better and the > For example reduce reduce_limit_debug would only work with reduce_limit = false, which is not int

[GitHub] couchdb issue #425: Improve reduce function overlow handling

2016-08-01 Thread nickva
Github user nickva commented on the issue: https://github.com/apache/couchdb/pull/425 @kxepal The problem is the setting is really a tri-state switch of "disabled", "warning", "enabled". SELinux setup on RHEL works the same (disabled, permissive, where it logs but don't bloc

[GitHub] couchdb issue #425: Improve reduce function overlow handling

2016-07-01 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/425 @nickva > have a new additional one "if enabled don't actually enable, but just log" setting. That might be more confusing... What did you have in mind, what's a better setting? `reduce

[GitHub] couchdb issue #425: Improve reduce function overlow handling

2016-07-01 Thread nickva
Github user nickva commented on the issue: https://github.com/apache/couchdb/pull/425 @kxepal It would be useful to have a logging / warning only value for this setting. Is it better to call the value "warning?" or have a new additional one "if enabled don't actually enable, but just

[GitHub] couchdb issue #425: Improve reduce function overlow handling

2016-07-01 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/425 -1 Two problems: 1. Boolean `reduce_limit` flag eventually starts taking string value "log". Things should be consistent and behaviour should be predictable. Here is not the case.